| *** amalagon has quit IRC | 00:01 | |
| *** kgriffs is now known as kgriffs|afk | 00:05 | |
| *** achanda has quit IRC | 00:18 | |
| *** achanda has joined #openstack-zaqar | 00:18 | |
| *** achanda has quit IRC | 00:23 | |
| *** amalagon has joined #openstack-zaqar | 01:11 | |
| *** amalagon has quit IRC | 01:17 | |
| *** akanksha has quit IRC | 02:47 | |
| *** achanda has joined #openstack-zaqar | 02:58 | |
| *** achanda has quit IRC | 03:10 | |
| *** chandankumar has joined #openstack-zaqar | 03:11 | |
| *** flwang has quit IRC | 03:54 | |
| *** achanda has joined #openstack-zaqar | 04:07 | |
| *** miqui has quit IRC | 04:14 | |
| *** chandankumar has quit IRC | 05:17 | |
| *** chandankumar has joined #openstack-zaqar | 05:20 | |
| *** chandankumar has quit IRC | 05:20 | |
| *** achanda has quit IRC | 05:31 | |
| *** achanda has joined #openstack-zaqar | 05:34 | |
| *** achanda has quit IRC | 05:48 | |
| *** achanda has joined #openstack-zaqar | 05:52 | |
| *** achanda has quit IRC | 05:58 | |
| *** achanda has joined #openstack-zaqar | 06:01 | |
| *** achanda has quit IRC | 06:14 | |
| *** chandankumar has joined #openstack-zaqar | 06:41 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:14 | |
| exploreshaifali | morning!!! | 07:17 |
|---|---|---|
| *** flwang has joined #openstack-zaqar | 08:05 | |
| *** exploreshaifali has quit IRC | 08:05 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:07 | |
| flwang | flaper87: ping | 08:31 |
| *** flwang has quit IRC | 09:21 | |
| *** flwang has joined #openstack-zaqar | 09:32 | |
| *** chandankumar has quit IRC | 09:32 | |
| *** chandankumar has joined #openstack-zaqar | 09:45 | |
| flwang | flaper87: around? | 10:06 |
| *** exploreshaifali has quit IRC | 10:38 | |
| *** chandankumar has quit IRC | 10:40 | |
| flwang | flaper87: just update the notification service status | 10:58 |
| flwang | i'm working on the redis driver, will submit a patch on next Mon or Tue | 10:59 |
| flwang | meanwhile, I'm reviewing Shaifali's patch | 11:07 |
| rsFF | btw, https://review.openstack.org/#/c/163223/ how can see what is the offending code? | 11:07 |
| *** akanksha has joined #openstack-zaqar | 11:30 | |
| vkmc | morning! | 12:05 |
| vkmc | rsFF, hi there! you can check what went wrong by looking at the gates logs | 12:06 |
| vkmc | rsFF, http://logs.openstack.org/23/163223/1/check/gate-zaqar-pep8/ab8f2ba/console.html#_2015-03-10_23_28_05_905 | 12:06 |
| vkmc | rsFF, I highlighted the problem | 12:06 |
| vkmc | rsFF, the fix looks great btw | 12:07 |
| rsFF | haaaaaa | 12:07 |
| rsFF | lol | 12:07 |
| rsFF | so now should i do a ammend? | 12:08 |
| vkmc | rsFF, exactly | 12:08 |
| rsFF | oki as soon as i get to the build box... | 12:09 |
| rsFF | any more remarks? | 12:09 |
| vkmc | rsFF, nothing else, everything else looks fine | 12:09 |
| rsFF | kk | 12:09 |
| vkmc | rsFF, thanks! | 12:09 |
| *** exploreshaifali has joined #openstack-zaqar | 12:28 | |
| *** chandankumar has joined #openstack-zaqar | 12:43 | |
| openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 12:52 |
| *** sriram has joined #openstack-zaqar | 13:08 | |
| *** dynarro has joined #openstack-zaqar | 13:10 | |
| *** mpanetta has joined #openstack-zaqar | 13:27 | |
| *** dynarro has quit IRC | 13:28 | |
| *** chandankumar has quit IRC | 13:30 | |
| *** dynarro has joined #openstack-zaqar | 13:43 | |
| akanksha | vkmc, I am trying to work on this bug https://bugs.launchpad.net/zaqar/+bug/1367024. Can you help me a little as to how to approach this ? | 13:51 |
| openstack | Launchpad bug 1367024 in zaqar "Redis driver doesn't explicitly validate UUIDs" [Low,Confirmed] - Assigned to Akanksha Srivastava (akanksha-dlf) | 13:52 |
| *** ametts has joined #openstack-zaqar | 13:52 | |
| vkmc | akanksha, so, first thing, you should ask first before taking a bug that is assigned to somebody else | 13:58 |
| akanksha | Umm okay | 13:58 |
| akanksha | I didnt know that sorry | 13:58 |
| vkmc | akanksha, no worries, something for future reference | 13:58 |
| akanksha | I'll unassign myself for now then? | 13:58 |
| vkmc | akanksha, oh no, let's ask dynarro | 13:59 |
| akanksha | And ma'am for bugs which are unassigned? | 13:59 |
| vkmc | dynarro, hey there, you were working on https://bugs.launchpad.net/zaqar/+bug/1367024? | 13:59 |
| openstack | Launchpad bug 1367024 in zaqar "Redis driver doesn't explicitly validate UUIDs" [Low,Confirmed] | 13:59 |
| flaper87 | flwang: ping ? | 14:00 |
| flaper87 | gosh, you must be sleeping :( | 14:00 |
| *** exploreshaifali has quit IRC | 14:02 | |
| dynarro | vkmc: hey! yes I was :) | 14:03 |
| * flaper87 wonder where his manners are | 14:03 | |
| flaper87 | GOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOD MORNING PPL | 14:03 |
| flaper87 | or whatever it is wherever you are | 14:04 |
| * vkmc wonders the same | 14:04 | |
| flaper87 | vkmc: shut up | 14:04 |
| flaper87 | >.> | 14:04 |
| vkmc | flaper87, bring coffee, at least | 14:04 |
| * flaper87 gives vkmc coffee \_/? | 14:04 | |
| flaper87 | speaking of which, lemme get some | 14:04 |
| vkmc | :D | 14:04 |
| vkmc | dynarro, oh ok | 14:04 |
| vkmc | akanksha, so, let's find another bug for you | 14:05 |
| vkmc | akanksha, is that ok? | 14:05 |
| akanksha | vkmc, this was an unassigned bug. So I assigned it to myself is that okay? https://bugs.launchpad.net/zaqar/+bug/1222932 | 14:05 |
| openstack | Launchpad bug 1222932 in zaqar "perf: Functions defined inline" [Low,Triaged] - Assigned to Akanksha Srivastava (akanksha-dlf) | 14:05 |
| vkmc | akanksha, sure thing! | 14:05 |
| flaper87 | akanksha: hey there, how are you doing? | 14:06 |
| flaper87 | welcome | 14:06 |
| akanksha | Thanks flaper87 | 14:06 |
| akanksha | I am good | 14:06 |
| *** cpallares has joined #openstack-zaqar | 14:06 | |
| akanksha | flaper87, can you give me more details on how to go about solving this bug? | 14:06 |
| akanksha | https://bugs.launchpad.net/zaqar/+bug/1222932 | 14:06 |
| openstack | Launchpad bug 1222932 in zaqar "perf: Functions defined inline" [Low,Triaged] - Assigned to Akanksha Srivastava (akanksha-dlf) | 14:07 |
| akanksha | flaper87, Can you tell me which places I need to check for inline function definitions? | 14:10 |
| flaper87 | akanksha: nested functions aren't any different than other funcions, they just appear in local contexts and are considered closures | 14:14 |
| *** dynarro has quit IRC | 14:14 | |
| *** dynarro has joined #openstack-zaqar | 14:15 | |
| akanksha | flaper87, as I understand that defining a function inside another function affects the performance. So if they are unnecessarily defined inside another function what we can do is define it outside and call it wherever they are needed? | 14:17 |
| flaper87 | akanksha: correct, unless you need to capture the environment of the caller function, in that case you may want to use a nested function. | 14:19 |
| flaper87 | The impact on performance is not HUGE but it may be if the function is called many many times | 14:19 |
| *** dynarro has quit IRC | 14:19 | |
| akanksha | Since the bug was reported, I am guessing there would be such places where the environment of the caller function can be passed as args to a function? | 14:21 |
| flaper87 | akanksha: right | 14:21 |
| akanksha | flaper87, so should I look for such places in the codebase or is there a list or something handy which I can refer to? | 14:22 |
| akanksha | flaper87, I am new to zaqar and am still familiarising myself with the workflow so forgive me if I am not talking sense. | 14:23 |
| vkmc | akanksha, you are making complete sense | 14:24 |
| vkmc | akanksha, you should locate those places in the codebase | 14:24 |
| vkmc | akanksha, unfortunately, the reporter didn't mention where those functions are defined | 14:25 |
| akanksha | vkmc, I was thinking maybe I'll go through all files and make a not of places where I find nested functions and then tackle them one-by-one? | 14:27 |
| akanksha | vkmc, does that seem like a good approach? | 14:27 |
| akanksha | that was even if I am unable to resolve all such occurences, someone else will atleast have a list of places to check in case they want to solve the bug later? | 14:29 |
| akanksha | *that way | 14:29 |
| vkmc | akanksha, it sounds good to me | 14:29 |
| vkmc | akanksha, but it will be a lot of work for you | 14:29 |
| vkmc | akanksha, maybe we can find another low hanging fruit | 14:30 |
| vkmc | and ask the reporter if he can submit more information | 14:30 |
| akanksha | Hmm | 14:32 |
| vkmc | unless you want to work on that, I'm ok with it | 14:33 |
| akanksha | Alright, lets search for another bug meanwhile. We can ask for more information and wait for a reply on that. If we get a reply I'll work on it or whenever I have extra time | 14:33 |
| vkmc | akanksha, that sounds great | 14:34 |
| vkmc | akanksha, the other day I filed one you might find interesting | 14:34 |
| akanksha | Okay. | 14:34 |
| vkmc | https://bugs.launchpad.net/zaqar/+bug/1429393 | 14:34 |
| openstack | Launchpad bug 1429393 in zaqar "Move debug option to common options" [Medium,New] | 14:34 |
| vkmc | let me know what do you think | 14:35 |
| akanksha | vkmc, This sounds interesting and doable. Can you give me some more information on common options though. I dont understand what that means | 14:36 |
| vkmc | akanksha, sure thing | 14:37 |
| akanksha | vkmc, where is the debug option located in the code? | 14:41 |
| *** chandankumar has joined #openstack-zaqar | 15:00 | |
| *** kgriffs|afk is now known as kgriffs | 15:18 | |
| *** exploreshaifali has joined #openstack-zaqar | 15:34 | |
| *** exploreshaifali has quit IRC | 15:42 | |
| *** kgriffs has quit IRC | 16:13 | |
| *** flwang1 has quit IRC | 16:14 | |
| *** kgriffs has joined #openstack-zaqar | 16:15 | |
| *** flwang1 has joined #openstack-zaqar | 16:17 | |
| *** mpanetta has quit IRC | 16:25 | |
| *** mpanetta_ has joined #openstack-zaqar | 16:25 | |
| *** dynarro has joined #openstack-zaqar | 16:28 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:44 | |
| *** openstack has joined #openstack-zaqar | 16:55 | |
| *** mpanetta_ has quit IRC | 17:15 | |
| dynarro | akanksha: sorry, I was working on https://bugs.launchpad.net/zaqar/+bug/1367024 but I'm not really working on it at the moment...that's what I meant earlier. So there's not problem if you want to work on it ;) | 17:16 |
| openstack | Launchpad bug 1367024 in zaqar "Redis driver doesn't explicitly validate UUIDs" [Low,Confirmed] - Assigned to Doraly Navarro (doralynavarro) | 17:16 |
| *** mpanetta has joined #openstack-zaqar | 17:22 | |
| *** exploreshaifali has quit IRC | 17:29 | |
| *** chandankumar has quit IRC | 17:36 | |
| *** chandankumar has joined #openstack-zaqar | 17:44 | |
| *** chandankumar has quit IRC | 17:47 | |
| *** achanda has joined #openstack-zaqar | 17:54 | |
| *** exploreshaifali has joined #openstack-zaqar | 18:01 | |
| *** reed has joined #openstack-zaqar | 18:03 | |
| *** reed has quit IRC | 18:03 | |
| *** reed has joined #openstack-zaqar | 18:03 | |
| *** dynarro has quit IRC | 18:11 | |
| *** chandankumar has joined #openstack-zaqar | 18:11 | |
| *** flwang has quit IRC | 18:39 | |
| *** chandankumar has quit IRC | 18:57 | |
| *** exploreshaifali has quit IRC | 19:03 | |
| akanksha | vkmc,ping? | 19:09 |
| *** achanda has quit IRC | 19:27 | |
| *** achanda has joined #openstack-zaqar | 19:38 | |
| *** chandankumar has joined #openstack-zaqar | 19:41 | |
| *** kgriffs is now known as kgriffs|afk | 19:48 | |
| *** flwang has joined #openstack-zaqar | 19:52 | |
| *** PrincessRiikka has quit IRC | 19:54 | |
| openstackgerrit | Ricardo Ferreira proposed openstack/zaqar: Syntax enhancements https://review.openstack.org/163223 | 20:01 |
| openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: Adds websockets driver to Zaqar server https://review.openstack.org/140155 | 20:02 |
| *** kgriffs|afk is now known as kgriffs | 20:02 | |
| *** exploreshaifali has joined #openstack-zaqar | 20:03 | |
| vkmc | akanksha, sorry, I had to rush | 20:05 |
| vkmc | akanksha, could you check out the code_ | 20:05 |
| akanksha | kgriffs,flaper87, I want to solve this bug and I am just getting started. Could you point me in the right direction https://bugs.launchpad.net/zaqar/+bug/1367024 | 20:21 |
| openstack | Launchpad bug 1367024 in zaqar "Redis driver doesn't explicitly validate UUIDs" [Low,Confirmed] - Assigned to Doraly Navarro (doralynavarro) | 20:21 |
| *** chandankumar has quit IRC | 20:24 | |
| kgriffs | akanksha: from what I recall, we aren't checking that the IDs passed into the driver are valid UUIDs (input validation - security). We just pass through the string. | 20:30 |
| kgriffs | akanksha: so, I'd say the approach would be to validate every ID passed into a driver method, before ever sending it to redis. | 20:31 |
| akanksha | valid uuids means existing in the database or just following the general uuid scheme? | 20:33 |
| akanksha | Kgriffs: If its the latter (or even the former) I guess we could just write a method which would validate the UUID and then call the driver method. We could pass the driver method as an argument into our validator and call it inside our validator or just call the method after validation(before every instance of passing the UUID into a driver method we could | 20:38 |
| akanksha | call that method and flag it as an invalid UUID and check the flag before calling our driver) | 20:38 |
| akanksha | kgriffs: can you point me to the specific drivers? | 20:39 |
| akanksha | So I can have a look? | 20:39 |
| *** achanda has quit IRC | 20:55 | |
| *** mpanetta has quit IRC | 21:01 | |
| kgriffs | akanksha: https://github.com/openstack/zaqar/tree/master/zaqar/storage/redis | 21:04 |
| akanksha | kgriffs: where do you think I should implement the UUID validation? | 21:05 |
| kgriffs | you could start by looking at the messages controller | 21:06 |
| kgriffs | https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/messages.py | 21:06 |
| akanksha | I was reading up on general UUID validation and all that has to done is apparently pass it to the python UUID() method and it will raise a value error if its not a valid UUID. | 21:07 |
| kgriffs | akanksha: that's the easiest way. I wonder how expensive that call is? | 21:08 |
| akanksha | Hmm okay lemme look at more ways. | 21:08 |
| kgriffs | I just ran a quick test on my MBP and got 3.55 microseconds. It's probably OK. | 21:09 |
| akanksha | Oh cool | 21:12 |
| akanksha | Then we can do that | 21:12 |
| kgriffs | interesting, I found this: https://pypi.python.org/pypi/pyvalid/0.9 | 21:12 |
| kgriffs | not sure on how much overhead it adds, but may be a way to DRY up validation logic | 21:13 |
| kgriffs | also, not sure if it is in requirements.txt or oslo has it's own way of doing this. | 21:13 |
| kgriffs | (global requirements) | 21:14 |
| kgriffs | htmmm | 21:14 |
| kgriffs | https://github.com/openstack/requirements/blob/master/global-requirements.txt | 21:14 |
| kgriffs | no pyvalid | 21:15 |
| kgriffs | flaper87 should know about oslo | 21:15 |
| akanksha | We could use it | 21:16 |
| akanksha | @accepts(object, Validator.password_checker) | 21:16 |
| akanksha | This is an example usage | 21:17 |
| akanksha | where it uses a validation function | 21:17 |
| akanksha | We could just use the accepts wrapper before every function | 21:17 |
| akanksha | which uses uuids | 21:17 |
| akanksha | Add pyvalid to requirements maybe? | 21:18 |
| kgriffs | akanksha: maybe, but I think we'd have to get it added to global-requirements.txt - might be a challenge. | 21:25 |
| * kgriffs still thinks global-requirements.txt hurts more than it helps. | 21:26 | |
| *** achanda has joined #openstack-zaqar | 21:28 | |
| akanksha | Hehe XD | 21:30 |
| akanksha | Global requirements gave me a very hard time when i tried installing zaqar behind a proxy | 21:30 |
| *** boris-42 has quit IRC | 21:32 | |
| akanksha | So for now should I go for pyvalid or do a normal implementation of calling the validator before every function call? | 21:33 |
| akanksha | If we do get pyvalid added later in requirements we will just need to change the validator call to the accepts decorator right? | 21:34 |
| akanksha | kgriffs: what do you think? Also please tell me where to write my validator function since I am new and have no clue. Still need to orients myself around the code | 21:36 |
| akanksha | *orient | 21:36 |
| kgriffs | akanksha: hmmm... I kind of like the decorator approach, so that may be the way to go even if we have to create our own in lieu of using pyvalid. We could model it after pyvalid, although at some point it gets pretty silly (why not just use pyvalid?) | 21:38 |
| kgriffs | You would apply the decorator to controller methods that take a message ID. For example - https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/messages.py#L372 | 21:38 |
| akanksha | Yeah | 21:39 |
| akanksha | Decorator follows DRY. | 21:40 |
| akanksha | Writing the decorator may not be hard. Should I look into it? | 21:41 |
| *** sriram has quit IRC | 22:01 | |
| *** exploreshaifali has quit IRC | 22:04 | |
| *** csoukup has joined #openstack-zaqar | 22:09 | |
| *** exploreshaifali has joined #openstack-zaqar | 22:31 | |
| flaper87 | flwang1: ping | 22:50 |
| flwang1 | flaper87: pong | 22:50 |
| flaper87 | kgriffs: jeeeeeeeeeeeeeeeeeeeeeeesus, you're alive! | 22:50 |
| flaper87 | flwang1: hey, so, notifications. How's it going? | 22:50 |
| flwang1 | i'm working on the redis driver, will submit a patch next Mon | 22:51 |
| flwang1 | and meanwhile, i'm reviewing the patch from Shaifali | 22:51 |
| flaper87 | flwang1: ok, count on it! :) | 22:51 |
| flaper87 | as in, I'm counting on it | 22:51 |
| flwang1 | flaper87: I hope we can close this in m-3 | 22:52 |
| flwang1 | really busy recently, lots of internal stuff | 22:53 |
| *** echevemaster has joined #openstack-zaqar | 22:56 | |
| flaper87 | flwang1: np :) | 22:57 |
| flaper87 | kgriffs: say hi to me | 22:57 |
| flaper87 | >.> | 22:57 |
| * flaper87 says hi to kgriffs | 22:57 | |
| *** exploreshaifali has quit IRC | 23:10 | |
| openstackgerrit | Merged openstack/zaqar: Adds websockets driver to Zaqar server https://review.openstack.org/140155 | 23:20 |
| * kgriffs says hi to flaper87 | 23:39 | |
| *** sriram has joined #openstack-zaqar | 23:49 | |
| *** sriram has quit IRC | 23:51 | |
| *** sriram has joined #openstack-zaqar | 23:52 | |
| openstackgerrit | Merged openstack/zaqar: Updated from global requirements https://review.openstack.org/161593 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!