| *** vkmc has quit IRC | 00:00 | |
| *** kgriffs is now known as kgriffs|afk | 00:07 | |
| *** vkmc has joined #openstack-zaqar | 00:08 | |
| *** cpallares has quit IRC | 00:39 | |
| *** wpf1 has quit IRC | 01:00 | |
| *** zhiyan has quit IRC | 01:10 | |
| *** wpf1 has joined #openstack-zaqar | 01:17 | |
| *** zhiyan has joined #openstack-zaqar | 01:21 | |
| *** davideagnello has quit IRC | 01:24 | |
| *** achanda has quit IRC | 01:31 | |
| *** kgriffs|afk is now known as kgriffs | 01:46 | |
| *** kgriffs is now known as kgriffs|afk | 01:55 | |
| *** davideagnello has joined #openstack-zaqar | 01:56 | |
| *** davideagnello has quit IRC | 01:56 | |
| *** davideagnello has joined #openstack-zaqar | 02:51 | |
| *** flwang has quit IRC | 03:24 | |
| *** kgriffs|afk is now known as kgriffs | 03:35 | |
| *** flwang has joined #openstack-zaqar | 03:35 | |
| *** kgriffs is now known as kgriffs|afk | 03:44 | |
| *** sebasmagri has quit IRC | 03:50 | |
| *** sebasmagri has joined #openstack-zaqar | 03:50 | |
| *** davideagnello has quit IRC | 04:02 | |
| *** davideagnello has joined #openstack-zaqar | 04:03 | |
| *** davideagnello has quit IRC | 04:03 | |
| *** flwang has quit IRC | 04:09 | |
| *** jdaggett_ has quit IRC | 04:11 | |
| *** jdaggett_ has joined #openstack-zaqar | 04:11 | |
| *** achanda has joined #openstack-zaqar | 04:12 | |
| *** amalagon has quit IRC | 04:12 | |
| *** amalagon has joined #openstack-zaqar | 04:12 | |
| *** amalagon has quit IRC | 04:17 | |
| *** kgriffs|afk is now known as kgriffs | 04:35 | |
| *** kgriffs is now known as kgriffs|afk | 04:45 | |
| *** achanda has quit IRC | 04:55 | |
| openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 05:07 |
|---|---|---|
| *** achanda has joined #openstack-zaqar | 05:16 | |
| *** echevemaster has quit IRC | 05:27 | |
| openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 05:38 |
| *** davideagnello has joined #openstack-zaqar | 05:51 | |
| *** davideagnello has quit IRC | 05:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/151549 | 06:03 |
| *** kgriffs|afk is now known as kgriffs | 06:24 | |
| *** kgriffs is now known as kgriffs|afk | 06:34 | |
| *** miqui has quit IRC | 06:35 | |
| *** achanda has quit IRC | 07:04 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:22 | |
| exploreshaifali | flaper87, ping | 07:25 |
| *** achanda has joined #openstack-zaqar | 07:29 | |
| *** achanda has quit IRC | 07:54 | |
| *** achanda has joined #openstack-zaqar | 08:01 | |
| *** kgriffs|afk is now known as kgriffs | 08:13 | |
| exploreshaifali | flaper87, if you have a bit of time please can we discuss about message_controller and pipeling ? | 08:22 |
| *** kgriffs is now known as kgriffs|afk | 08:22 | |
| flaper87 | exploreshaifali: hey hey | 08:23 |
| flaper87 | exploreshaifali: shoot | 08:23 |
| flaper87 | It may take me a bit to answer, this week is quite busy for me | 08:23 |
| exploreshaifali | flaper87, so we decided to add new class MessageQueueHandler kinda in storage/mongodb/messages and connect it with pipeline | 08:24 |
| *** wpf1 has quit IRC | 08:25 | |
| exploreshaifali | flaper87, so that ControlDriver or QueueController can fetch the stuff from pipeline | 08:25 |
| exploreshaifali | flaper87, but the pipeline have only DataDriver class | 08:25 |
| exploreshaifali | flaper87, logically it should also have ControlDriver class | 08:26 |
| exploreshaifali | https://github.com/openstack/zaqar/blob/master/zaqar/storage/pipeline.py#L84 | 08:26 |
| exploreshaifali | and whatever we need to hack with pipeline should come from pipeline.ControlDriver | 08:26 |
| *** wpf1 has joined #openstack-zaqar | 08:26 | |
| exploreshaifali | this is the issue | 08:27 |
| exploreshaifali | flaper87, no problem, take your time to answer :P | 08:27 |
| *** flwang has joined #openstack-zaqar | 08:29 | |
| flaper87 | exploreshaifali: why does it have to have the control driver? | 08:29 |
| exploreshaifali | flaper87, we need message_controller access to QueueController, and we decided following steps to get it -- 1. create in mongodb.messages a `QueueMessageHandlerThingy`2. then add that to the entry-points and let the pipeline do its job | 08:31 |
| exploreshaifali | flaper87, so for second step | 08:31 |
| exploreshaifali | we need to add that to entry point, if we will add it to pipeline.DataDriver it will be again of no use | 08:31 |
| exploreshaifali | as we need to add QueueMessageHandler to entry point such that it could be used by QueueController | 08:32 |
| *** achanda has quit IRC | 08:32 | |
| exploreshaifali | QueueController cannot access anything from DataDriver | 08:33 |
| exploreshaifali | it have access of ControlDriver | 08:33 |
| flaper87 | exploreshaifali: but you have a control instance in the data driver already | 08:42 |
| flaper87 | and you can access the data driver from the message controller | 08:42 |
| exploreshaifali | flaper87, but we need to access message_controller access in QueueController, may be I am not getting exactly what was your thought | 08:44 |
| exploreshaifali | flaper87, should I start everything from scratch ? | 08:44 |
| flaper87 | I don't think we need to access the message controller from the queue controller. The point of using the pipeline is to just put the message handler in the queue's ops pipeline and have some things triggered | 08:46 |
| flaper87 | do you have a review of the current state? | 08:46 |
| exploreshaifali | flaper87, I am reading https://review.openstack.org/#/c/51049/ to understand how stuff moves from pipeling to further steps | 08:49 |
| flwang | flaper87: ping | 09:30 |
| *** kgriffs|afk is now known as kgriffs | 10:02 | |
| *** davideagnello has joined #openstack-zaqar | 10:07 | |
| flaper87 | q/bu17 | 10:10 |
| flaper87 | ops | 10:10 |
| *** kgriffs is now known as kgriffs|afk | 10:11 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 10:24 |
| openstackgerrit | Merged openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/151549 | 10:55 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 11:13 |
| flwang | flaper87: ping | 11:13 |
| flwang | flaper87: ^ | 11:14 |
| flwang | pls take a look at the notifier patch | 11:14 |
| flwang | i'd like to discuss with you about the notifier driver, I have some concerns for current design | 11:15 |
| flaper87 | flwang: pong | 11:18 |
| flaper87 | flwang: I'm about to go afk | 11:18 |
| flaper87 | but I'll take a look | 11:18 |
| vkmc | flwang, hi! | 11:27 |
| flwang | vkmc: hi | 11:27 |
| vkmc | flwang, what is your concern with the design? | 11:27 |
| flwang | vkmc: i will review your patch | 11:27 |
| vkmc | flwang, np | 11:28 |
| flwang | vkmc: ah, the concern is the way retrieving the subscriptions for notifier | 11:28 |
| flwang | my initial thought is implementing different driver for different subscriber types, like email, webhook, sms, etc | 11:29 |
| flwang | but when I implementing it, i just realized that most of the code of sending notification(leveraging taskflow) is common | 11:30 |
| flwang | only the task of taskflow is different | 11:30 |
| vkmc | well, that's good | 11:30 |
| flwang | so i'm going to implement one notifier(no driver anymore) and many tasks | 11:30 |
| *** exploreshaifali has quit IRC | 11:31 | |
| flwang | https://review.openstack.org/#/c/151529/3/zaqar/notifier/webhook.py | 11:31 |
| flwang | in other words, most of the code in post() is common | 11:31 |
| flwang | we just need different task types for different subscribers | 11:32 |
| vkmc | yeah, only the nested for loop is for webhook, right? | 11:32 |
| flwang | hope my explanation make some sense | 11:32 |
| vkmc | so you could add in the same class some private methods and call them whatever the suscriber you have? | 11:32 |
| flwang | i think so | 11:33 |
| vkmc | neat | 11:33 |
| vkmc | and what was your perf concern? | 11:34 |
| flwang | otherwise, even i can extract the common code, there is another issue we can not avoid | 11:34 |
| flwang | if we keep current way, we have to talk with database many times to get the different subscriptions with different types | 11:34 |
| flwang | if we take above way I just explained, we only need one | 11:35 |
| vkmc | for what I understand in webhook.py | 11:36 |
| vkmc | you only have one connection with the db to retrieve the list of subscriptions | 11:36 |
| flwang | for now yes, since we only support webhook | 11:36 |
| vkmc | then you delegate all the work to taskflow | 11:36 |
| flwang | and it's a work in progress ;) | 11:37 |
| flwang | vkmc: right | 11:37 |
| vkmc | and how do you retrieve the subscriptions when they are... for instance, sms? | 11:37 |
| vkmc | flwang, sure, I'm curious about it :) | 11:37 |
| flwang | vkmc: that's what i'm talking about | 11:37 |
| flwang | we may need a query to get the subscriptions with specific subscriber type | 11:38 |
| vkmc | oh... hmm | 11:38 |
| vkmc | makes sense now | 11:38 |
| flwang | there are some work for current patch | 11:39 |
| flwang | but you got my point i hope ;) | 11:39 |
| vkmc | yeah totally | 11:39 |
| flwang | btw, I'm sure current patch is workable | 11:39 |
| vkmc | so... hmm... subscriber type is a key in the current implementation? | 11:39 |
| vkmc | probably that's the case | 11:40 |
| flwang | yep | 11:40 |
| flwang | ok, pls feel free leave your comments on the patch | 11:40 |
| vkmc | sure | 11:40 |
| flwang | i have to drop off now | 11:40 |
| flwang | it's late at here | 11:41 |
| vkmc | ok, thanks flwang | 11:41 |
| vkmc | oh yes, time to head out | 11:41 |
| flwang | vkmc: i will eat your patch tomorrow as my breakfast | 11:41 |
| vkmc | take care flwang! | 11:41 |
| flwang | ttyl | 11:41 |
| vkmc | w000t :D ttyl | 11:41 |
| *** kgriffs|afk is now known as kgriffs | 11:50 | |
| *** kgriffs is now known as kgriffs|afk | 12:00 | |
| *** boris-42 has quit IRC | 12:22 | |
| *** boris-42 has joined #openstack-zaqar | 12:22 | |
| *** cpallares has joined #openstack-zaqar | 12:30 | |
| *** davideagnello has quit IRC | 12:36 | |
| *** exploreshaifali has joined #openstack-zaqar | 12:46 | |
| exploreshaifali | vkmc, \o/ | 12:48 |
| exploreshaifali | kragniz, \o/ | 12:48 |
| kragniz | exploreshaifali: o/ o/ o/ o/ o/ o/ o/ | 12:49 |
| vkmc | heeeeeeey exploreshaifali! | 12:49 |
| vkmc | morning kragniz | 12:50 |
| vkmc | :) | 12:50 |
| exploreshaifali | what's going on ? | 12:50 |
| kragniz | good morning vkmc | 12:50 |
| *** diga has quit IRC | 12:52 | |
| kragniz | exploreshaifali: I'm having a "lovely time" with a glance spec | 12:53 |
| kragniz | I'd like it to be in k2 ;_; | 12:53 |
| exploreshaifali | kragniz, cool, which spec btw ? | 12:54 |
| kragniz | exploreshaifali: a spec of sadness | 12:54 |
| kragniz | exploreshaifali: https://review.openstack.org/#/c/146437/ | 12:54 |
| exploreshaifali | kragniz, lovely time with sadness | 12:56 |
| exploreshaifali | :P | 12:56 |
| exploreshaifali | but there are loads of comments, sign of your hard work | 12:56 |
| *** g4rg4m3|_ has joined #openstack-zaqar | 12:57 | |
| cpallares | kragniz: I would approve this spec of sadness. | 12:57 |
| *** flwang has quit IRC | 12:57 | |
| *** jasondotstar has quit IRC | 12:57 | |
| *** flwang has joined #openstack-zaqar | 12:57 | |
| cpallares | (which is probably why I'm not core) | 12:57 |
| exploreshaifali | cpallares, lol | 12:58 |
| kragniz | cpallares: you just understand it well enough! | 13:00 |
| *** jasondotstar has joined #openstack-zaqar | 13:28 | |
| *** exploreshaifali has quit IRC | 13:37 | |
| *** jasondotstar has quit IRC | 14:08 | |
| *** sriram has joined #openstack-zaqar | 14:13 | |
| *** jasondotstar has joined #openstack-zaqar | 14:20 | |
| *** mpanetta has joined #openstack-zaqar | 14:29 | |
| *** boris-42 has quit IRC | 14:32 | |
| *** davideagnello has joined #openstack-zaqar | 14:36 | |
| *** malini has joined #openstack-zaqar | 14:59 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:30 | |
| *** kgriffs|afk is now known as kgriffs | 15:31 | |
| *** diga has joined #openstack-zaqar | 15:31 | |
| *** kgriffs is now known as kgriffs|afk | 15:32 | |
| *** kgriffs|afk is now known as kgriffs | 15:32 | |
| *** achanda has joined #openstack-zaqar | 15:32 | |
| *** achanda has quit IRC | 15:40 | |
| *** diga has quit IRC | 16:01 | |
| *** diga has joined #openstack-zaqar | 16:02 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:38 | |
| *** boris-42 has joined #openstack-zaqar | 17:02 | |
| *** amalagon has joined #openstack-zaqar | 17:17 | |
| *** flwang has quit IRC | 18:04 | |
| *** kgriffs is now known as kgriffs|afk | 18:18 | |
| *** achanda has joined #openstack-zaqar | 18:18 | |
| *** kgriffs|afk is now known as kgriffs | 19:28 | |
| *** jasondotstar has quit IRC | 19:30 | |
| *** bradjones has quit IRC | 20:10 | |
| *** boris-42 has quit IRC | 20:12 | |
| *** bradjones has joined #openstack-zaqar | 20:14 | |
| *** flwang has joined #openstack-zaqar | 20:16 | |
| *** jasondotstar has joined #openstack-zaqar | 20:25 | |
| *** flwang2 has joined #openstack-zaqar | 20:27 | |
| *** flwang has quit IRC | 20:27 | |
| *** kgriffs is now known as kgriffs|afk | 20:35 | |
| *** malini has quit IRC | 20:37 | |
| *** openstackgerrit has quit IRC | 20:50 | |
| *** jasondotstar has quit IRC | 20:50 | |
| *** openstackgerrit has joined #openstack-zaqar | 20:50 | |
| *** exploreshaifali has quit IRC | 20:52 | |
| *** kgriffs|afk is now known as kgriffs | 21:01 | |
| *** achanda has quit IRC | 21:03 | |
| *** achanda has joined #openstack-zaqar | 21:21 | |
| *** mpanetta has quit IRC | 21:40 | |
| *** exploreshaifali has joined #openstack-zaqar | 21:49 | |
| *** kgriffs is now known as kgriffs|afk | 21:53 | |
| *** kgriffs|afk is now known as kgriffs | 21:54 | |
| *** kgriffs is now known as kgriffs|afk | 22:03 | |
| *** kgriffs|afk is now known as kgriffs | 22:19 | |
| *** jasondotstar has joined #openstack-zaqar | 22:20 | |
| *** sriram has quit IRC | 22:21 | |
| *** cpallares has quit IRC | 22:27 | |
| *** diga has quit IRC | 22:28 | |
| *** davideagnello has quit IRC | 22:36 | |
| *** jasondotstar has quit IRC | 22:46 | |
| *** kgriffs is now known as kgriffs|afk | 23:07 | |
| *** zhiyan has quit IRC | 23:08 | |
| *** kgriffs|afk is now known as kgriffs | 23:10 | |
| *** jasondotstar has joined #openstack-zaqar | 23:15 | |
| *** zhiyan has joined #openstack-zaqar | 23:21 | |
| *** amitgandhinz has quit IRC | 23:21 | |
| *** kgriffs is now known as kgriffs|afk | 23:22 | |
| *** kgriffs|afk is now known as kgriffs | 23:23 | |
| *** jasondotstar has quit IRC | 23:45 | |
| *** kgriffs is now known as kgriffs|afk | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!