Saturday, 2018-04-21

*** harlowja has quit IRC00:24
*** aspiers has quit IRC00:41
*** glance_ has quit IRC03:58
*** aspiers has joined #openstack-watcher05:22
*** rajat has quit IRC11:11
*** nicolasbock has joined #openstack-watcher12:47
*** alexchadin has joined #openstack-watcher16:16
*** erakli has joined #openstack-watcher16:19
*** alexchadin has quit IRC16:28
eraklihi all. I currently work on tests for and found that test watcher.tests.db.test_audit_template.DbAuditTemplateTestCase.test_get_audit_template_list_with_filters() works not as supposed. When it calls get_audit_template_list() with filters on 'goal', it's done incorrectly. Filter named 'goal' is accepted by API and it converts 'goal' to 'goal_name' or 'goal_uuid" filter, that is actu16:36
erakliSo, DB wait only fields that explicitly passed to Connection._add_filters() method. The most interesting part is that Connection._add_audit_templates_filters() doesn't define 'goal' field in plain_fields variable.16:36
erakliAnd the key point is here: Connection._add_filters() method iterates over plain_fields and join_fieldmap but do nothing with filter, that is not a part of these arguments. I wonder why not to add something like exception or log entry on bad filter?16:36
erakliThis is the reason, why bug wasn't cathed by tests. Test, that should caught it checks nothing. I fix it, but would it be a good idea to add checks on bad filters?16:36
openstackLaunchpad bug 1761956 in watcher "'watcher audittemplate list' returns deleted Audit Templates" [Undecided,In progress] - Assigned to Egor Panfilov (erakli)16:36
*** erakli has quit IRC17:58
openstackgerritEgor Panfilov proposed openstack/watcher master: Replace of private _create methods in tests
*** nicolasbock has quit IRC19:44
openstackgerritEgor Panfilov proposed openstack/watcher master: Grouped _add_*_filters methods together
openstackgerritEgor Panfilov proposed openstack/watcher master: Updated tests on bug, when get list returns deleted items

Generated by 2.15.3 by Marius Gedminas - find it at!