Friday, 2016-08-05

*** thorst has quit IRC00:06
*** thorst has joined #openstack-watcher01:04
*** thorst has quit IRC01:11
*** thorst has joined #openstack-watcher01:15
*** thorst has quit IRC01:16
*** esberglu has quit IRC01:43
openstackgerritMerged openstack/watcher: Removed unused function in uniform airflow  https://review.openstack.org/35116301:43
*** esberglu has joined #openstack-watcher02:14
*** thorst has joined #openstack-watcher02:17
*** thorst has quit IRC02:25
*** esberglu has quit IRC02:35
*** thorst has joined #openstack-watcher02:43
*** thorst has quit IRC02:43
*** esberglu has joined #openstack-watcher02:58
*** esberglu has quit IRC02:59
*** thorst has joined #openstack-watcher03:44
*** thorst has quit IRC03:52
*** gzhai has quit IRC03:55
*** gzhai has joined #openstack-watcher03:55
*** esberglu has joined #openstack-watcher03:55
*** esberglu has quit IRC04:02
*** thorst has joined #openstack-watcher04:51
*** thorst has quit IRC04:58
*** gzhai has quit IRC04:58
*** gzhai has joined #openstack-watcher04:59
*** gzhai has quit IRC05:00
*** gzhai has joined #openstack-watcher05:00
*** jwcroppe has joined #openstack-watcher05:11
*** jwcroppe has quit IRC05:51
*** thorst has joined #openstack-watcher05:56
*** thorst has quit IRC06:03
*** ecelik has joined #openstack-watcher06:07
*** jimbaker has quit IRC06:19
*** jimbaker has joined #openstack-watcher06:23
*** jimbaker has quit IRC06:23
*** jimbaker has joined #openstack-watcher06:23
*** diga has joined #openstack-watcher06:34
*** danpawlik has joined #openstack-watcher06:44
*** thorst has joined #openstack-watcher07:01
*** thorst has quit IRC07:08
*** jimbaker has quit IRC07:16
*** jimbaker has joined #openstack-watcher07:19
*** jimbaker has quit IRC07:20
*** jimbaker has joined #openstack-watcher07:20
*** vincentfrancoise has joined #openstack-watcher07:34
*** openstackgerrit has quit IRC08:03
*** openstackgerrit has joined #openstack-watcher08:03
*** thorst has joined #openstack-watcher08:08
*** thorst has quit IRC08:13
*** gzhai has quit IRC08:21
openstackgerritTomasz Kaczynski proposed openstack/watcher: Add Scoring Module implementation  https://review.openstack.org/35157708:46
*** thorst has joined #openstack-watcher09:10
*** thorst has quit IRC09:18
vincentfrancoisehi tkaczynski09:51
tkaczynskihi vincentfrancoise09:52
vincentfrancoiseI started reading your code on the scoring engine09:52
tkaczynski+1 :)09:52
vincentfrancoiseand I was wondering if you tested the dynamic reload that I see in https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/scoring_factory.py09:52
vincentfrancoiseI mean without restarting Watcher09:53
tkaczynskiyes, I tested09:53
tkaczynskiessentially, this reload is being called from Sync class. I tested it using watcher-sync script09:55
vincentfrancoisebut if you add a new scoring engine in the SEcontainer09:55
vincentfrancoisecan you then execute it?09:55
vincentfrancoiseI asking because by default, python caches the modules that were already loaded09:56
vincentfrancoiseso the watcher-sync works because it is in a separate process09:56
vincentfrancoisebut the currently one would not see the newly synced SE code09:56
vincentfrancoiseat least that is my guess09:56
tkaczynskiso the SE container is returning the instances, not classes. the idea behind this dynamic behavior is that this list can be dynamic and configuration driven09:57
tkaczynskiI guess it won't be possible to change the implementation "on the fly". it it's possible to change some DB configuration and then for example instantiate some additional scoring engines09:58
tkaczynskiof course using the same already loaded class09:58
tkaczynskiplease look at this: https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/scoring_container.py09:59
tkaczynskisorry, wrong link: https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/dummy_scoring_container.py10:00
vincentfrancoisein the 1st link you say "dynamic reloading of Scoring Engineimplementations without having to restart any Watcher services"10:00
vincentfrancoisethat's why I was asking about this10:01
tkaczynskithere is SimpleFunctionScorer, which implements a generic scoring engine (takes a function as an argument)10:01
tkaczynskiimagine that this can be based on some config and for example be a proxy to some scoring engine running in the cloud10:01
tkaczynskiyes, but there is no magic - I don't plan to change the code on the fly, but I plan to change the configuration based on which the code is running10:02
tkaczynski(I need to go now, be back in 1 hour if you still need me)10:03
vincentfrancoisethat's what I thaught10:03
vincentfrancoiseok no pb10:03
vincentfrancoisewill continue making comments10:03
vincentfrancoisemost  is styling issues10:03
*** thorst has joined #openstack-watcher10:16
*** thorst has quit IRC10:23
tkaczynskisure, did my best, but I'm still new to python etc.11:03
tkaczynskivincentfrancoise: long list :) thanks for taking time on this review, I will address all points11:07
*** thorst has joined #openstack-watcher11:20
*** thorst has quit IRC11:28
*** thorst has joined #openstack-watcher11:48
vincentfrancoisetkaczynski: yeah but most of it is just aesthetic comments12:09
*** thorst_ has joined #openstack-watcher12:45
*** thorst has quit IRC12:49
*** edleafe is now known as figleaf12:51
*** diga has quit IRC13:07
*** esberglu has joined #openstack-watcher13:12
*** hvprash has joined #openstack-watcher13:19
openstackgerritVincent Fran├žoise proposed openstack/watcher: Add Oslo Versioned Object + Indirection API  https://review.openstack.org/32779313:20
*** akijak has left #openstack-watcher13:22
*** hvprash_ has joined #openstack-watcher13:25
*** hvprash has quit IRC13:28
*** hvprash_ has quit IRC13:32
*** hvprash has joined #openstack-watcher13:33
*** jwcroppe has joined #openstack-watcher13:33
*** hvprash_ has joined #openstack-watcher13:37
*** hvprash has quit IRC13:40
*** danpawlik has quit IRC13:42
*** michaelgugino has joined #openstack-watcher13:53
*** ecelik has quit IRC13:54
openstackgerritTomasz Kaczynski proposed openstack/watcher: Add Scoring Module implementation  https://review.openstack.org/35157713:59
*** hvprash has joined #openstack-watcher14:01
*** hvprash_ has quit IRC14:02
*** openstackgerrit has quit IRC14:03
*** openstackgerrit has joined #openstack-watcher14:03
*** hvprash has quit IRC14:03
*** hvprash has joined #openstack-watcher14:04
*** hvprash has quit IRC14:04
*** hvprash has joined #openstack-watcher14:04
*** hvprash has quit IRC14:15
*** hvprash_ has joined #openstack-watcher14:15
*** AndroUser2 has joined #openstack-watcher15:10
*** jwcroppe has quit IRC15:12
*** jwcroppe has joined #openstack-watcher15:13
*** vincentfrancoise has quit IRC15:35
*** jimbaker has quit IRC16:11
*** jimbaker has joined #openstack-watcher16:15
*** jimbaker has quit IRC16:15
*** jimbaker has joined #openstack-watcher16:15
*** AndroUser2 has quit IRC16:37
*** jed56 has quit IRC17:35
*** vincentfrancoise has joined #openstack-watcher18:48
*** esberglu has quit IRC18:53
*** jimbaker has quit IRC18:58
*** jimbaker has joined #openstack-watcher19:02
*** jimbaker has quit IRC19:02
*** jimbaker has joined #openstack-watcher19:02
*** ss4 has joined #openstack-watcher19:05
*** esberglu has joined #openstack-watcher19:10
*** thorst__ has joined #openstack-watcher19:23
*** thorst_ has quit IRC19:26
*** thorst__ is now known as thorst_19:26
*** thorst__ has joined #openstack-watcher20:16
*** thorst_ has quit IRC20:18
*** hvprash has joined #openstack-watcher20:25
*** hvprash_ has quit IRC20:26
*** hvprash_ has joined #openstack-watcher20:40
*** hvprash has quit IRC20:43
*** thorst__ has quit IRC20:46
*** thorst_ has joined #openstack-watcher20:50
*** thorst_ has quit IRC20:55
*** Metabulation has joined #openstack-watcher21:11
*** ss4 has quit IRC21:14
*** hvprash_ has quit IRC21:14
*** Metabulation has quit IRC21:20
*** michaelgugino has quit IRC21:28
*** vincentfrancoise has quit IRC21:32
*** figleaf is now known as edleafe21:54
*** esberglu has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!