Monday, 2016-07-04

*** gzhai2 has joined #openstack-watcher00:03
*** jwcroppe_ has quit IRC01:48
*** jwcroppe has joined #openstack-watcher02:33
*** jwcroppe has quit IRC03:39
*** jwcroppe has joined #openstack-watcher04:25
*** jwcroppe has quit IRC04:40
*** danpawlik has joined #openstack-watcher07:01
*** jed56 has joined #openstack-watcher07:10
openstackgerritMerged openstack/watcher: Added filter operators  https://review.openstack.org/32579407:10
*** dtardivel has joined #openstack-watcher07:13
*** vincentfrancoise has joined #openstack-watcher07:31
*** diga has joined #openstack-watcher07:51
openstackgerritJean-Emile DARTOIS proposed openstack/watcher-specs: Make default Planner generic  https://review.openstack.org/33704908:04
openstackgerritJean-Emile DARTOIS proposed openstack/watcher-specs: Make default Planner generic  https://review.openstack.org/33704908:09
openstackgerritJean-Emile DARTOIS proposed openstack/watcher-specs: Make default Planner generic  https://review.openstack.org/33704908:10
*** pkoniszewski_ has quit IRC08:14
*** alexchadin has joined #openstack-watcher08:15
alexchadinjed56: hi08:15
jed56hi08:15
alexchadincould I discuss with you cont-opt?08:16
jed56cont-opt ?08:19
jed56yes08:19
alexchadinEdwin Zhai proposed to add job directly through the API, without calling launch_audits_periodically08:21
alexchadinwhat if our service was in down state?08:21
alexchadinthen we need to add jobs back to apscheduler with the same periods08:21
vincentfrancoisehi alexchadin08:22
alexchadinhi vincentfrancoise08:22
alexchadinhttps://review.openstack.org/#/c/321411/08:23
vincentfrancoisealexchadin: jed56 just left his desk so dunno when he'll get back08:24
alexchadinvincentfrancoise: may I discuss it with you?08:25
vincentfrancoiseyeah08:26
vincentfrancoiseI'm looking at it right now08:26
jed56alexchadin: I don't see the point08:30
jed56what are the advantages ?08:30
vincentfrancoiseseems like his comment is linked to adding notifications into the mix08:32
alexchadinjed56: IMHO we need to use launch_audits_periodically08:32
vincentfrancoisebut since we will do this later, I guess there's not much need for it08:32
vincentfrancoisecoffee time!08:33
jed56vincentfrancoise: +208:33
jed56coffee time08:33
danpawlikjed56: +108:40
*** pkoniszewski has joined #openstack-watcher08:51
openstackgerritMerged openstack/watcher: Enable strategy parameters  https://review.openstack.org/29755608:57
dtardivelgzhai2: Hi Edwin, regarding your changeset https://review.openstack.org/#/c/297557/, I proposed to you in my last comment to use -P, --parameter  command option for setting strategy parameters. What do you think ?09:00
vincentfrancoisedtardivel: +109:01
openstackgerritDaniel Pawlik proposed openstack/puppet-watcher: Implement watcher-db-manage commands  https://review.openstack.org/33693909:05
digajed56: vincentfrancoise : I am getting error while running tox09:26
vincentfrancoisehi diga09:26
digavincentfrancoise: hey09:26
vincentfrancoisecan you pastebin me your errors then?09:26
digaCaptured traceback: ~~~~~~~~~~~~~~~~~~~     Traceback (most recent call last):       File "watcher/tests/db/test_audit.py", line 261, in test_get_audit_list_with_filters         self.assertEqual([audit1['id']], [r.id for r in res])       File "/home/digambar/watcher/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual         self.assertThat(observed, matcher, message)       File "/hom09:27
digamismatch error at watcher/tests/db/test_audit.py +16109:27
digaFAKE_OLD_DATE = '2015-01-01T09:52:05.21941409:28
digais there any problem with this09:28
digamy problems are got resolved09:28
vincentfrancoiseis this the only error you have?09:28
digayes09:28
vincentfrancoisedid you fix the 'type' filters of this test to 'audit_type'?09:29
vincentfrancoiseline 259 and 26409:29
digayes09:30
digavincentfrancoise: may be got the fix, let me try that way first09:36
openstackgerritAlexander Chadin proposed openstack/watcher: Add continuously optimization  https://review.openstack.org/32141109:36
vincentfrancoiseok09:38
openstackgerritDigambar proposed openstack/watcher: Fix field type to audit_type  https://review.openstack.org/33639010:01
digavincentfrancoise: I tested above patch locally10:01
digavincentfrancoise: please take a look at it10:02
vincentfrancoiseI'm on something else right now10:04
vincentfrancoiseso I'll review it later10:04
digasure10:07
*** diga has quit IRC10:42
*** Kevin_Zheng has quit IRC10:53
openstackgerritOpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements  https://review.openstack.org/33625611:43
*** alexchadin has quit IRC12:59
*** alexchadin has joined #openstack-watcher13:00
*** alexchadin has quit IRC13:03
*** alexchadin has joined #openstack-watcher13:03
*** diga has joined #openstack-watcher13:47
digavincentfrancoise: jed56 : Hi13:53
vincentfrancoisehi13:53
digavincentfrancoise: http://logs.openstack.org/90/336390/3/check/gate-watcher-python27/2e827f8/console.html13:56
digaAll the tests failed are related to strategy code13:56
digaI didn't have any changes in that code,13:56
digavincentfrancoise: Error is - AttributeError: 'Strategy' object has no attribute 'parameters_spec13:57
digavincentfrancoise: The error is from earlier patch - commit 64903ce56c700d23a28d9056e6525ad754ad102713:58
digajust checked13:58
vincentfrancoiselet me have a look at this13:58
digavincentfrancoise:13:59
digavincentfrancoise: got it13:59
digavincentfrancoise: strategy doesn't have paramaters_spec field in the db14:00
digavincentfrancoise: should I add that in separate patch ?14:00
digavincentfrancoise: let me open the14:01
digabug for14:01
digafor that14:01
vincentfrancoiseLet me see for myself so I can answer you properly14:02
digasure14:02
digavincentfrancoise: Reported bug for that - https://bugs.launchpad.net/watcher/+bug/159885814:09
openstackLaunchpad bug 1598858 in watcher "strategy doesn't have paramaters_spec field in the db" [Undecided,New]14:09
vincentfrancoisediga: the problem comes from your code14:12
digavincentfrancoise: didn't get you ?14:12
vincentfrancoisethe way you rebase your code onto master made you lose the changes that were introduced in the patchset you mentioned earlier14:13
digaokay14:13
vincentfrancoisefor example https://review.openstack.org/#/c/336390/3/watcher/db/sqlalchemy/models.py14:13
vincentfrancoisehttps://review.openstack.org/#/c/336390/3/watcher/db/sqlalchemy/models.py@127 to be more precise14:14
vincentfrancoiseyou removed DB fields that were actually needed for the tests to pass14:14
digaohh14:14
digayeah, got it.14:14
jed56:)14:14
diga:)14:15
digaI think I did merge the code & then apply changes but didn't resolve conflict14:15
vincentfrancoiseI'll leave it to you then ;)14:16
digayep14:16
digaI will resolve it14:16
digavincentfrancoise: Thank you!14:17
openstackgerritVincent Fran├žoise proposed openstack/watcher: Fix failing Tempest tests  https://review.openstack.org/33724714:20
alexchadinvincentfrancoise: do we have shared resources in Watcher?14:23
alexchadinvincentfrancoise: I mean, if I create audit as admin then switch to the demo user and list audits14:23
alexchadinvincentfrancoise: I will see admin audit, right?14:23
*** alexchadin has quit IRC14:42
*** alexchadin has joined #openstack-watcher14:43
vincentfrancoisehi alexchadin14:43
alexchadinhi vincentfrancoise14:44
vincentfrancoiseI guess what you are referring to is what https://blueprints.launchpad.net/watcher/+spec/define-the-audit-scope will try to address14:44
vincentfrancoiseso for now, not really14:44
*** alexchadin has quit IRC14:58
*** danpawlik has quit IRC15:09
openstackgerritVladimir Ostroverkhov proposed openstack/watcher-dashboard: Add support continuously-optimization  https://review.openstack.org/32709515:19
*** diga has quit IRC15:24
*** vincentfrancoise has quit IRC16:29
openstackgerritDigambar proposed openstack/watcher: Fix field type to audit_type  https://review.openstack.org/33639017:22
openstackgerritDaniel Pawlik proposed openstack/puppet-watcher: Implement watcher-db-manage commands  https://review.openstack.org/33693917:49
openstackgerritDaniel Pawlik proposed openstack/python-watcherclient: Add license file  https://review.openstack.org/33734718:05
*** danpawlik has joined #openstack-watcher18:05
*** dtardivel has quit IRC18:47
*** wootehfoot has joined #openstack-watcher18:58
*** jed56 has quit IRC19:05
*** wootehfoot has quit IRC19:33
*** wootehfoot has joined #openstack-watcher19:42
*** wootehfoot has quit IRC21:01
*** danpawlik has quit IRC21:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!