| *** thorst_ has quit IRC | 00:00 | |
| *** michaelgugino has quit IRC | 00:08 | |
| *** thorst_ has joined #openstack-watcher | 00:59 | |
| *** thorst_ has quit IRC | 01:07 | |
| *** thorst_ has joined #openstack-watcher | 01:23 | |
| *** thorst_ has quit IRC | 01:24 | |
| *** jinquan has joined #openstack-watcher | 01:36 | |
| *** thorst_ has joined #openstack-watcher | 02:19 | |
| *** thorst_ has quit IRC | 02:20 | |
| *** thorst_ has joined #openstack-watcher | 02:20 | |
| *** thorst_ has quit IRC | 02:29 | |
| *** diga has quit IRC | 02:46 | |
| *** jwcroppe has quit IRC | 02:55 | |
| *** thorst_ has joined #openstack-watcher | 03:35 | |
| *** thorst_ has quit IRC | 03:44 | |
| *** diga has joined #openstack-watcher | 03:46 | |
| openstackgerrit | Edwin Zhai proposed openstack/watcher: Enable strategy parameters https://review.openstack.org/297556 | 04:06 |
|---|---|---|
| openstackgerrit | Edwin Zhai proposed openstack/watcher: Documentation for strategy parameters https://review.openstack.org/334143 | 04:06 |
| openstackgerrit | Edwin Zhai proposed openstack/python-watcherclient: Enable strategy parameter https://review.openstack.org/297557 | 04:07 |
| *** jwcroppe has joined #openstack-watcher | 04:08 | |
| *** jwcroppe has quit IRC | 04:10 | |
| diga | Hi acabot, jed56 | 04:29 |
| diga | I am commiting the change but it is asking me password | 04:30 |
| diga | fatal: Authentication failed for 'https://digambar@review.openstack.org/openstack/watcher.git/ | 04:30 |
| diga | digambar@pt-acceng4567:~/watcher$ git review | 04:30 |
| diga | Password for 'https://digambar@review.openstack.org': | 04:30 |
| diga | fatal: Authentication failed for 'https://digambar@review.openstack.org/openstack/watcher.git/' | 04:30 |
| diga | but I think there is no password needed for commit | 04:31 |
| *** thorst_ has joined #openstack-watcher | 04:43 | |
| *** thorst_ has quit IRC | 04:49 | |
| diga | Hi All | 05:31 |
| diga | has anyone faced this problem, now password error has gone but its asking passphrase | 05:32 |
| *** jwcroppe has joined #openstack-watcher | 05:40 | |
| *** thorst_ has joined #openstack-watcher | 05:46 | |
| *** thorst_ has quit IRC | 05:53 | |
| *** jwcroppe has quit IRC | 06:04 | |
| *** thorst_ has joined #openstack-watcher | 06:52 | |
| *** jed56 has joined #openstack-watcher | 06:54 | |
| *** thorst_ has quit IRC | 06:59 | |
| *** alexchadin has joined #openstack-watcher | 07:05 | |
| alexchadin | jed56: hi :) | 07:05 |
| alexchadin | jed56: how are you? | 07:06 |
| jed56 | hi alexchadin | 07:06 |
| openstackgerrit | Digambar proposed openstack/watcher: Fix field type to audit_type https://review.openstack.org/336390 | 07:06 |
| *** ostroverkhov has joined #openstack-watcher | 07:06 | |
| jed56 | very well thanks and you ? | 07:06 |
| alexchadin | jed56: I'm fine | 07:07 |
| jed56 | :) | 07:08 |
| alexchadin | I had discussion with ostroverkhov about period field in watcher/w-client/w-dashboard | 07:08 |
| openstackgerrit | Muzammil proposed openstack/watcher: removed column parameters from the following methods in both files def get_audit_template_list(self, context, columns=None, filters=None, limit=None, marker=None, sort_key=None, sort_dir= https://review.openstack.org/336392 | 07:09 |
| alexchadin | The Idea is that ONESHOT audits don't have to get period set | 07:09 |
| alexchadin | Should be None | 07:09 |
| alexchadin | For continuous audits this field should be set or 3600 as default | 07:10 |
| alexchadin | right? | 07:10 |
| alexchadin | Can't we change audit types after it is created? | 07:10 |
| jed56 | We can't change the audit type after his creation | 07:16 |
| alexchadin | cool | 07:16 |
| alexchadin | when we create ONESHOT audit | 07:17 |
| alexchadin | period field should be None | 07:17 |
| jed56 | yes for ONESHOT the period should be None | 07:17 |
| alexchadin | and in DB this field also should be None | 07:17 |
| alexchadin | Cool | 07:17 |
| jed56 | sadly, we can't use inheritance with the watcher objects | 07:18 |
| jed56 | if it was the case, we could create Continuous Audit which extends Audit in the db | 07:18 |
| alexchadin | If we set period to 0 | 07:21 |
| alexchadin | could it be translated as None to API? | 07:21 |
| alexchadin | cause ostroverkhov have some problems with IntegerField in w-dashboard | 07:22 |
| alexchadin | It can't be set to None, only integer values | 07:22 |
| *** dtardivel has joined #openstack-watcher | 07:24 | |
| dtardivel | ostroverkhov: Hi, I would like to review the changeset https://review.openstack.org/#/c/327095 "Add support continuously-optimizatiion" on watcher-dashbard. | 07:25 |
| dtardivel | ostroverkhov: you replied Done on last comments from vincentfrancoise, but you did not push another PS. Are you working on it ? | 07:25 |
| jed56 | alexchadin: The period can be set as None => 'period': obj_utils.int_or_none, | 07:26 |
| jed56 | https://review.openstack.org/#/c/321411/8/watcher/objects/audit.py | 07:26 |
| ostroverkhov | dtardivel: Hi, yes I'm working on it now. | 07:27 |
| dtardivel | ostroverkhov: ok, great !!! | 07:27 |
| alexchadin | jed56: It can in watcher object | 07:27 |
| alexchadin | jed56: take a look https://review.openstack.org/#/c/327095/1/watcher_dashboard/content/audits/forms.py | 07:28 |
| alexchadin | 55 line | 07:28 |
| alexchadin | dtardivel: hi:) | 07:29 |
| alexchadin | dtardivel: how are you? | 07:29 |
| dtardivel | alexchadin: fine :) | 07:29 |
| jed56 | alexchadin: I'm not sure for the dashboard | 07:29 |
| dtardivel | HI Alex | 07:29 |
| alexchadin | dtardivel: could you please also review it? https://review.openstack.org/#/c/321411/ | 07:30 |
| alexchadin | dtardivel: if you have a time, of course | 07:30 |
| jed56 | alexchadin: you can't set None ? forms.IntegerField(initial=None, | 07:31 |
| *** vincentfrancoise has joined #openstack-watcher | 07:33 | |
| dtardivel | alexchadin: I would like to review this feature globally with the dashboard changeset :) But It is in my plan .... | 07:33 |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #openstack-watcher | 07:33 | |
| alexchadin | dtardivel: okay :) | 07:34 |
| ostroverkhov | jed56: I have already fixed it | 07:38 |
| jed56 | ostroverkhov: great | 07:39 |
| *** alexchadin has quit IRC | 07:42 | |
| *** ostroverkhov has quit IRC | 07:45 | |
| *** thorst_ has joined #openstack-watcher | 07:57 | |
| *** thorst_ has quit IRC | 08:04 | |
| openstackgerrit | Digambar proposed openstack/watcher: Fix field type to audit_type https://review.openstack.org/336390 | 08:07 |
| diga | jed56: Hi | 08:08 |
| diga | can you check my above comming | 08:08 |
| jed56 | yes | 08:09 |
| diga | ok | 08:09 |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #openstack-watcher | 08:18 | |
| dtardivel | zigo: Hi, I have a bug on installing of the watcher-api Debian experimental package. I have started a Docker container based on the debian:experimental image, and I tried to install into this container the watcher-api. | 08:35 |
| zigo | dtardivel: What is the problem exactly? | 08:35 |
| dtardivel | zigo: In the configuration step, I have this error: | 08:35 |
| dtardivel | https://www.irccloud.com/pastebin/M541X7Dn/ | 08:35 |
| zigo | dtardivel: Can you add a "set -x" in /var/lib/dpkg/info/watcher-api.postinst, and run "apt-get -f install", so that we see what happens? | 08:37 |
| zigo | Oh, sorry. | 08:37 |
| zigo | Got it above. | 08:37 |
| zigo | Well, it needs /sbin/route | 08:37 |
| dtardivel | zigo: /sbin/route binary is not installed on Debian experimental container | 08:37 |
| zigo | apt-get install net-tools | 08:37 |
| zigo | I'll add it as a hard dependency. | 08:38 |
| dtardivel | zigo: great, thanks | 08:38 |
| zigo | dtardivel: Fix uploaded, however I just missed the dak run, so it will take a few hours until it reaches Debian. | 08:52 |
| *** thorst_ has joined #openstack-watcher | 09:02 | |
| *** vtech has joined #openstack-watcher | 09:06 | |
| *** jwcroppe has joined #openstack-watcher | 09:08 | |
| *** thorst_ has quit IRC | 09:09 | |
| *** jwcroppe has quit IRC | 09:13 | |
| *** jwcroppe has joined #openstack-watcher | 09:18 | |
| openstackgerrit | Tomasz Kaczynski proposed openstack/watcher: Add scoring engines to database and API layers https://review.openstack.org/330382 | 09:42 |
| diga | jed56: py27 jenkin job is failing, dont know how this file is checked in earlier | 09:44 |
| diga | because the error it is showing are there in the file before this patch | 09:45 |
| vincentfrancoise | hi diga | 09:45 |
| diga | vincentfrancoise: hey | 09:45 |
| diga | vincentfrancoise: can go through this patch - https://review.openstack.org/#/c/336390/ | 09:46 |
| vincentfrancoise | did you try to run the tests locally? | 09:47 |
| vincentfrancoise | (to see if there are any discrepancies between you running it locally I the failing results we see on the gates) | 09:48 |
| vincentfrancoise | diga: I'm looking at the error you got | 09:51 |
| diga | okay | 09:52 |
| diga | actually those failed errors alraedy existed in the file | 09:52 |
| diga | because when I downloaded the code, I run some pep8 tests. I was failing there | 09:53 |
| diga | so I dont know who has commited that | 09:53 |
| vincentfrancoise | How did you run pep8? | 09:53 |
| diga | flake8 | 09:53 |
| diga | I try with flake8 then try pep8 | 09:54 |
| vincentfrancoise | can you use the 'tox -e pep8' command as explained in http://docs.openstack.org/developer/watcher/dev/testing.html#unit-tests ? | 09:54 |
| vincentfrancoise | because we may have gotten errors coming from some error codes we purposefully deactivated | 09:56 |
| vincentfrancoise | s/we may/you may | 09:56 |
| *** jwcroppe has quit IRC | 09:57 | |
| diga | okay | 10:03 |
| diga | I will run it | 10:03 |
| *** thorst_ has joined #openstack-watcher | 10:09 | |
| *** thorst_ has quit IRC | 10:14 | |
| *** vtech has quit IRC | 10:31 | |
| *** vtech has joined #openstack-watcher | 10:33 | |
| *** jed56 has quit IRC | 10:35 | |
| *** vtech has quit IRC | 10:38 | |
| diga | vincentfrancoise: Hi | 11:39 |
| diga | vincentfrancoise: we need to change the type attribute from audit table & for that we need to add sqlalchemy migration | 11:40 |
| diga | before going to add it, we need to file seperate dependant for that | 11:41 |
| diga | acabot: vincentfrancoise : anyone there ? | 11:43 |
| *** jwcroppe has joined #openstack-watcher | 11:46 | |
| vincentfrancoise | hi diga | 11:58 |
| diga | vincentfrancoise: hey | 11:58 |
| vincentfrancoise | as for SQL migration | 11:59 |
| diga | vincentfrancoise: this change requires db field migration also for audit table | 11:59 |
| vincentfrancoise | we currently do not do them since we did not reach a 1.0 version yet | 11:59 |
| diga | okay | 12:00 |
| vincentfrancoise | we expect DB migrations to be handled around the end of the Newton cycle | 12:00 |
| diga | then If I add/update field name in the table, I need to do db-manage command again to reflect the column in audit table | 12:01 |
| diga | okay | 12:01 |
| vincentfrancoise | although this is to be taken with a grain of salt | 12:01 |
| diga | hmm | 12:01 |
| vincentfrancoise | yes you will have to recreate your DB | 12:01 |
| diga | got it | 12:02 |
| diga | vincentfrancoise: thanks for your immediate reply | 12:02 |
| vincentfrancoise | you're welcome ;) | 12:03 |
| diga | I appreciate | 12:03 |
| vincentfrancoise | feel free to drop questions again :) | 12:03 |
| diga | yep :) | 12:03 |
| diga | your geographical region | 12:03 |
| vincentfrancoise | France so UTC+2 | 12:04 |
| diga | okay | 12:04 |
| diga | I am from India | 12:04 |
| *** edleafe is now known as figleaf | 12:04 | |
| vincentfrancoise | cool :) | 12:06 |
| *** jed56 has joined #openstack-watcher | 12:09 | |
| *** jwcroppe has quit IRC | 12:15 | |
| *** jwcroppe has joined #openstack-watcher | 12:17 | |
| *** diga has quit IRC | 12:18 | |
| *** jwcroppe has quit IRC | 12:21 | |
| dtardivel | zigo, I have another issue with the watcher-api debian experimental package. It seems the 'Authentication server hostname' (Keystone) is not correctly reported into the Keystone URL use to query token while Watcher endpoints creation. | 12:25 |
| dtardivel | https://www.irccloud.com/pastebin/t8LLEhPh/ | 12:25 |
| dtardivel | zigo: ^^ | 12:27 |
| tkaczynski | hi guys, do you have any idea why my change is failing test in multinode environment? the logs are here: http://logs.openstack.org/82/330382/4/check/gate-watcher-dsvm-multinode-nv/ca7b030/console.html | 12:33 |
| tkaczynski | it doesn't seem to be related to my changes whatsoever | 12:34 |
| vincentfrancoise | there are 2 or 3 tests that are currently failing in the multinode env | 12:34 |
| vincentfrancoise | a bug was created | 12:35 |
| vincentfrancoise | but no one fixed it yet: https://bugs.launchpad.net/watcher/+bug/1595534 | 12:35 |
| openstack | Launchpad bug 1595534 in watcher "Fix failing Watcher Tempest tests" [Medium,Triaged] | 12:35 |
| tkaczynski | shouldn't they be disabled then until the bug is fixed? | 12:35 |
| vincentfrancoise | the fix is very minimal, the thing is that whoever gets close to it will fix it fairly quickly | 12:36 |
| tkaczynski | ok. so I shouldn't worry about my change then :) | 12:36 |
| vincentfrancoise | it's a known issue so yeah, no worries :) | 12:38 |
| tkaczynski | cheers :) | 12:40 |
| vincentfrancoise | tkaczynski: since you are here | 12:45 |
| vincentfrancoise | I have a question regarding your code | 12:45 |
| tkaczynski | sure | 12:45 |
| vincentfrancoise | why did you make the ID column be a String(50) for the ScoringEngine model? | 12:46 |
| tkaczynski | why is is a string? or why it has 50 chars? | 12:46 |
| vincentfrancoise | kind of both actually: is it meant to be a normal string or a UUID one? if so the others are String(36) | 12:47 |
| tkaczynski | basically, the idea for the scoring engines is that they are identified by a unique string, but I didn't need the uuid. it should be short, readable by human. the size 50 I chose arbitrarily. not too long, not too short | 12:49 |
| tkaczynski | I thought that string(50) is used in some other places now, but I did that some time ago and I might not remember correctly. any particular reason to use String(36)? | 12:50 |
| vincentfrancoise | I'm asking because a couple of months ago I tried to do the same thing and I had many comments on it | 12:52 |
| vincentfrancoise | here is the review https://review.openstack.org/#/c/296633/6 | 12:52 |
| tkaczynski | so what was the conclusion? | 12:52 |
| vincentfrancoise | https://review.openstack.org/#/c/296633/6/watcher/db/sqlalchemy/models.py to be more precise | 12:52 |
| vincentfrancoise | basically, people feel that an ID has to be an Integer somehow | 12:53 |
| *** alexchadin has joined #openstack-watcher | 12:53 | |
| *** vtech has joined #openstack-watcher | 12:55 | |
| tkaczynski | I don't think the world assumed that id in database means integer :) | 12:55 |
| vincentfrancoise | agreed | 12:55 |
| jed56 | ah ah ah : ) | 12:55 |
| jed56 | yes | 12:55 |
| jed56 | also agreed but this is the openstack way : ) | 12:56 |
| jed56 | thanks to oslo_db | 12:56 |
| tkaczynski | I was thinking about it actually and also about UUID. for my use cases, UUID was completely unnecessary. zero benefits, just work to handle it around. but I've noticed that there are few places, which assume that UUID is present | 12:57 |
| vincentfrancoise | tkaczynski: yes that's the issue | 12:57 |
| tkaczynski | but I managed to overcame it, everything works for me without UUID | 12:58 |
| tkaczynski | so what should I do with this id being integer then? should this id be auto-generated by watcher when discovering new scoring engine plugin? should strategy developers rely on this id then? | 13:00 |
| tkaczynski | my idea was that scoring engine plugin developer picks his unique id and then it can be used everywhere, strategies could rely on it etc. | 13:00 |
| tkaczynski | and id being a string allows to introduce some naming convention, so there will not be id conflicts etc | 13:01 |
| vincentfrancoise | I agree, I am simply playing the devil's advocate | 13:02 |
| tkaczynski | I fully understand and see where you are coming from | 13:03 |
| vincentfrancoise | the thing is that back then | 13:03 |
| vincentfrancoise | I had to change the whole thing to ad IDs everywhere, so I don't want you to go through the same experience :p | 13:04 |
| tkaczynski | question is what to do now: do I need to change it? I would really prefer to work on the next part of the scoring module than refactoring the whole thing for no benefits really | 13:04 |
| vincentfrancoise | jed56: what do you think of it? | 13:05 |
| tkaczynski | btw: is the id field currently autoincremented? | 13:06 |
| vincentfrancoise | yes it is | 13:06 |
| tkaczynski | and what is the story with uuid everywhere? if id is so great, do you really need uuid? | 13:07 |
| jed56 | we don't really need uuid for most of the use cases | 13:09 |
| vincentfrancoise | the uuid is because it is a security issue to display it via the API | 13:09 |
| jed56 | in restFul Api | 13:09 |
| vincentfrancoise | because it is sequential | 13:10 |
| jed56 | this is not recommanded that we could guest the uuid | 13:10 |
| vincentfrancoise | tkaczynski: BTW, you have both a Unique constraint and a primary key constraint | 13:12 |
| jed56 | +1 | 13:13 |
| vincentfrancoise | tkaczynski: I guess you can leave it as-is for now, if someone else complains in the meantime, we will reconsider it then | 13:13 |
| jed56 | +1 | 13:14 |
| jed56 | :) | 13:14 |
| tkaczynski | vincentfrancoise: sounds good. waiting for the review then, I hope to get it merged, because I have quite big change coming next, it's getting harder and harder to maintain 2 branches | 13:15 |
| vincentfrancoise | tkaczynski: I'm well aware of that, I had 15 chained changesets at some point waiting to get merged | 13:16 |
| vincentfrancoise | it takes one hell of a time to rebase the lot | 13:17 |
| tkaczynski | :)) | 13:17 |
| tkaczynski | honestly, I can't even imagine that :) I would rather implement a bot for these merges, than do it myself ;) | 13:18 |
| *** alexchadin has quit IRC | 13:19 | |
| *** alexchadin has joined #openstack-watcher | 13:20 | |
| *** jwcroppe has joined #openstack-watcher | 13:21 | |
| *** jwcroppe has quit IRC | 13:25 | |
| jed56 | vincentfrancoise: you love to rebase patchsets ;) | 13:26 |
| *** alexchadin has quit IRC | 13:33 | |
| *** alexchadin has joined #openstack-watcher | 13:34 | |
| zigo | dtardivel: If you don't have the keystone server in localhost, you have to dpkg-reconfigure debconf to set a lower priority, so that it will ask you the IP of your keystone server. | 13:38 |
| zigo | dtardivel: Otherwise, just setup the endpoint by yourself, by hand ... | 13:38 |
| zigo | That works too. | 13:39 |
| zigo | There's nothing mandatory with the debconf stuff. | 13:39 |
| dtardivel | zigo: ok, thanks, This is what I did (declare the endpoint by myself) | 13:40 |
| *** vtech has quit IRC | 14:01 | |
| *** danpawlik has quit IRC | 15:05 | |
| *** alexchadin has quit IRC | 15:06 | |
| *** jwcroppe has joined #openstack-watcher | 15:23 | |
| *** jwcroppe has quit IRC | 15:28 | |
| *** brunograz has quit IRC | 15:54 | |
| *** vincentfrancoise has quit IRC | 15:56 | |
| *** jwcroppe has joined #openstack-watcher | 17:26 | |
| *** jwcroppe has quit IRC | 17:31 | |
| *** jed56 has quit IRC | 17:45 | |
| *** dtardivel has quit IRC | 17:47 | |
| *** jwcroppe has joined #openstack-watcher | 18:25 | |
| *** figleaf has quit IRC | 19:40 | |
| *** edleafe has joined #openstack-watcher | 19:48 | |
| *** harlowja has quit IRC | 21:53 | |
| *** harlowja has joined #openstack-watcher | 21:53 | |
| *** harlowja_ has joined #openstack-watcher | 22:55 | |
| *** harlowja has quit IRC | 22:59 | |
| *** dronshaw has quit IRC | 23:01 | |
| *** jwcroppe has quit IRC | 23:42 | |
| *** jwcroppe has joined #openstack-watcher | 23:49 | |
| *** jwcroppe has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!