| *** Apoorva has quit IRC | 01:07 | |
| *** Apoorva has joined #openstack-third-party-ci | 01:47 | |
| *** Apoorva has quit IRC | 01:50 | |
| *** rfolco has quit IRC | 01:56 | |
| *** rfolco has joined #openstack-third-party-ci | 02:14 | |
| *** rfolco has quit IRC | 03:41 | |
| *** watanabe_isao has joined #openstack-third-party-ci | 07:39 | |
| *** watanabe_isao has quit IRC | 08:09 | |
| *** ChanServ has quit IRC | 09:14 | |
| *** hexlibris has quit IRC | 09:17 | |
| *** openstackgerrit has quit IRC | 09:17 | |
| *** strigazi has quit IRC | 09:17 | |
| *** azvyagintsev has quit IRC | 09:17 | |
| *** wznoinsk has quit IRC | 09:17 | |
| *** patrickeast has quit IRC | 09:17 | |
| *** wznoinsk has joined #openstack-third-party-ci | 10:07 | |
| *** azvyagintsev has joined #openstack-third-party-ci | 10:07 | |
| *** patrickeast has joined #openstack-third-party-ci | 10:07 | |
| *** azvyagintsev has quit IRC | 10:10 | |
| *** wznoinsk has quit IRC | 10:10 | |
| *** patrickeast has quit IRC | 10:10 | |
| *** wznoinsk has joined #openstack-third-party-ci | 10:26 | |
| *** azvyagintsev has joined #openstack-third-party-ci | 10:26 | |
| *** patrickeast has joined #openstack-third-party-ci | 10:26 | |
| *** hexlibris has joined #openstack-third-party-ci | 10:28 | |
| *** openstackgerrit has joined #openstack-third-party-ci | 10:28 | |
| *** strigazi has joined #openstack-third-party-ci | 10:28 | |
| *** azvyagintsev has quit IRC | 10:28 | |
| *** ChanServ has joined #openstack-third-party-ci | 10:30 | |
| *** tepper.freenode.net sets mode: +o ChanServ | 10:30 | |
| *** mmedvede has joined #openstack-third-party-ci | 10:59 | |
| *** rfolco has joined #openstack-third-party-ci | 12:01 | |
| *** TheJulia has joined #openstack-third-party-ci | 13:14 | |
| TheJulia | o/ | 13:14 |
|---|---|---|
| krtaylor | mmedvede, TheJulia is trying to turn on voting for their CI - can you help with the layout.yaml changes ? | 13:15 |
| *** fdegir has joined #openstack-third-party-ci | 13:15 | |
| TheJulia | Well, not my CI, OPNFV is attempting to post +1/-1 results to bifrost revisions | 13:16 |
| TheJulia | but, we seem to be missing something along the way | 13:16 |
| krtaylor | sorry, I summarized too much :) | 13:16 |
| TheJulia | no worries ;) | 13:16 |
| mmedvede | sure | 13:16 |
| mmedvede | I can take a look | 13:17 |
| krtaylor | TheJulia, is their layout.yaml similar to https://github.com/openstack-infra/zuul/blob/master/etc/layout.yaml-sample? | 13:17 |
| TheJulia | so, My parsing of the doc, I feel like it should just work as-is, but it doesn't seem to be. fdegir indicated that they are sending it from their jenkins deployment upon job completion | 13:17 |
| TheJulia | krtaylor: I would guess not, since jenkins and fdegir has indicated they are using the gerrit jenkins trigger | 13:19 |
| fdegir | hi | 13:19 |
| fdegir | as TheJulia says, we use jenkins gerrit trigger | 13:19 |
| fdegir | and we don't have zuul | 13:19 |
| fdegir | so it is basic jenkins job that gets triggered via patchset-created and that's all | 13:19 |
| mmedvede | I am unfamiliar with that :( | 13:19 |
| mmedvede | but I guess it should be the same principle | 13:19 |
| fdegir | it is http://docs.openstack.org/infra/system-config/third_party.html#the-jenkins-gerrit-trigger-plugin-way | 13:20 |
| fdegir | it can post -1/+1 to sandbox-ci project patches | 13:20 |
| fdegir | https://review.openstack.org/#/c/385969/ | 13:20 |
| fdegir | but not to bifrost patches | 13:21 |
| fdegir | https://review.openstack.org/#/c/367608/ | 13:21 |
| fdegir | and this is the jjb job template | 13:22 |
| fdegir | https://gerrit.opnfv.org/gerrit/gitweb?p=releng.git;a=blob;f=jjb/infra/bifrost-verify-jobs.yml | 13:22 |
| fdegir | the openstack gerrit trigger is defined towards the end of the file | 13:23 |
| mmedvede | I wonder if the CI needs to be added to the voting group of the project? | 13:24 |
| fdegir | mmedvede: the doc says the ci should be in project-ci group on gerrit | 13:25 |
| fdegir | mmedvede: but there is no group called birost-ci | 13:25 |
| fdegir | mmedvede: and the interesting thing is, Cisco CI can vote for ironic patches | 13:25 |
| TheJulia | except ironic for example, doesn't an ironic-ci group, and they have this sort of voting on their jobs | 13:25 |
| fdegir | mmedvede: ironic doesn't have a group called ironic-ci either | 13:25 |
| fdegir | :) | 13:25 |
| * TheJulia wonders if this becomes a conundrum and we get a phone call in a few minutes from a time traveler :) | 13:31 | |
| *** yolanda has joined #openstack-third-party-ci | 13:31 | |
| mmedvede | :) | 13:32 |
| mmedvede | If you are using the same settings for trying to vote on bifrost as you do on sandbox, and it does not come through, one possibility is that your CI does not have right access | 13:34 |
| mmedvede | I did not look into this in a long time | 13:34 |
| mmedvede | looking through various groups on gerrit right now | 13:35 |
| fdegir | mmedvede: I'm looking in to project-config/gerrit/acls/openstack | 13:35 |
| fdegir | for example for fuel plugins | 13:35 |
| fdegir | https://review.openstack.org/gitweb?p=openstack-infra/project-config.git;a=blob;f=gerrit/acls/openstack/fuel-plugin-debug.config | 13:35 |
| fdegir | they have that group set to use label verified | 13:36 |
| fdegir | so we might need similar thing for bifrost too | 13:36 |
| fdegir | as it's not defined in bifrost.config | 13:36 |
| fdegir | and have bifrost-ci group created as well | 13:36 |
| mmedvede | also, there is always a possibility that jeepyb manage_projects script did not run correctly on review.o.o to set permissions | 13:37 |
| yolanda | mm, so one thing may be that job results are published on the change, and another thing is that these job results are voting? | 13:38 |
| yolanda | i mean, for ironic it just can be informative jobs, but not affecting jenkins results | 13:38 |
| TheJulia | so, registered users is granted explicit permission to review on ironci | 13:38 |
| TheJulia | but not fuel | 13:38 |
| mmedvede | yolanda: they are able to post non-voting comments on bifrost patches, but they want to vote and unable. So it seems there is some acl config that is not right/not applied | 13:41 |
| openstackgerrit | Mark Hamzy proposed openstack/third-party-ci-tools: Add Continuous Integration (CI) example https://review.openstack.org/384243 | 13:41 |
| yolanda | well yes, bifrost does not have this bifrost-ci acl, so first thing shall be to update the acl | 13:41 |
| TheJulia | but ironic doesn't either | 13:42 |
| yolanda | then add the opnfv ci user to that group | 13:42 |
| TheJulia | that is what has me a little confused | 13:42 |
| yolanda | but they can post verified results to jenkins? | 13:42 |
| TheJulia | yup | 13:42 |
| TheJulia | well, various third party CIs can | 13:42 |
| *** hamzy has quit IRC | 13:42 | |
| TheJulia | is the opnfv user in registered users? | 13:43 |
| fdegir | yes | 13:43 |
| TheJulia | I wonder if it is via the explicit grant to registered users | 13:47 |
| * TheJulia thinks to herself that she has seen gerrit inheritance misbehave before. | 13:50 | |
| mmedvede | TheJulia: could be | 13:50 |
| yolanda | but registered users can only give +1/-1 as code review, not verified flags | 13:52 |
| mmedvede | TheJulia: I do not think you want verified flag, do you? just +1/-1 is what you want? | 13:53 |
| fdegir | I think I confused you | 13:56 |
| fdegir | those CIs don't vote to ironic | 13:56 |
| TheJulia | no, they only post +1/-1, and that would be my preference here, visibility | 13:56 |
| fdegir | but they are listed in tabl | 13:56 |
| fdegir | so the acl config seems right | 13:57 |
| yolanda | ah, then it makes sense | 13:57 |
| TheJulia | could jenkins be trying to post +2? | 13:57 |
| fdegir | TheJulia: I think bifrost needs bifrost-ci group | 13:57 |
| yolanda | no need of ironic-ci just to post reviews, they act as normal users | 13:57 |
| fdegir | and then project config needs updating | 13:57 |
| fdegir | yolanda: but how those CIs are listed in table? | 13:57 |
| fdegir | https://review.openstack.org/#/c/384899/ | 13:57 |
| fdegir | with links to logs or whatever | 13:58 |
| yolanda | i think that it's because the format of their answer | 13:58 |
| yolanda | they have to follow some specific syntax | 13:58 |
| fdegir | or maybe they all use zuul | 13:59 |
| fdegir | which handles all those things | 13:59 |
| fdegir | TheJulia: it doesn't post +2/-2 | 14:00 |
| fdegir | TheJulia: do you think we can get bifrost-ci created? | 14:00 |
| TheJulia | krtaylor indicated his is using zuul... | 14:00 |
| krtaylor | "Once you have done this you will have everything you need to comment on Gerrit changes from our CI system but you will not be able to vote +/-1 Verified on changes. To get voting rights you will need to get the release group of the project you are testing to add you to their project specific <project>-ci group." | 14:00 |
| krtaylor | from: http://docs.openstack.org/infra/system-config/third_party.html | 14:01 |
| fdegir | krtaylor: yes, the CIs posting comments to ironic confused me/us | 14:01 |
| krtaylor | just wondering if this has been set up | 14:01 |
| * TheJulia wonders if the zuul based deployments just have a little more logic in this regard | 14:01 | |
| krtaylor | pass/fail comments should be fine | 14:01 |
| krtaylor | and open to everyone | 14:02 |
| krtaylor | looks like acls on the gerrit side | 14:02 |
| krtaylor | is this comment/verified being done with a service account? | 14:03 |
| krtaylor | something_something_CI? | 14:03 |
| TheJulia | fdegir: I'll go-ahead and post a change to create it | 14:03 |
| fdegir | TheJulia: https://review.openstack.org/#/c/386002/ | 14:05 |
| krtaylor | also, try using openstack-dev/ci-sandbox | 14:05 |
| fdegir | TheJulia: seen your comment after I git reviewed | 14:06 |
| TheJulia | Once landed, we will need to get someone to grand bifrost-release or bifrost-core ownership of bifrost-ci | 14:06 |
| fdegir | I can abandon | 14:06 |
| krtaylor | if you can post a verified there, then you know it is ACLs on the project | 14:06 |
| fdegir | krtaylor: yes, I tried sandbox-ci and it works fine | 14:06 |
| TheJulia | fdegir: that is fine, you beat me to it | 14:06 |
| fdegir | krtaylor: I think things make more sense now | 14:06 |
| fdegir | krtaylor: the acls cntrol verified stuff | 14:06 |
| krtaylor | fdegir, there you go, it is prob acls then | 14:06 |
| fdegir | krtaylor: and using zuul puts you to that table | 14:06 |
| fdegir | krtaylor: perhaps zuul is posting stuff in certain way/format as yolanda | 14:07 |
| fdegir | says | 14:07 |
| fdegir | TheJulia: but I don't know how to create that group or who does that | 14:07 |
| krtaylor | not sure if that would be a factor as much as service account name, etc | 14:07 |
| fdegir | TheJulia: and who make opnfv ci user member | 14:07 |
| fdegir | krtaylor: the username is opnfvci | 14:07 |
| fdegir | krtaylor: and it's been added to all the places listed on that third party ci wiki | 14:08 |
| * krtaylor looks up account | 14:09 | |
| TheJulia | fdegir: once defined in a config and merged, the group is auto-created. We just need one of the gerrit-admins to grant ownership of the group to bifrost-release or bifrost-core | 14:09 |
| yolanda | yep, i can do it | 14:09 |
| TheJulia | \o/ | 14:10 |
| mmedvede | fdegir: TheJulia: If you just want your CI to be shown in review.o.o table, it is just formatting of your comment that needs changing | 14:10 |
| mmedvede | I am looking at https://review.openstack.org/#/c/367608/ | 14:11 |
| krtaylor | name format looks OK in gerrit Third Party CI group | 14:11 |
| mmedvede | compare your comment with jenkins comment format | 14:11 |
| TheJulia | fdegir: ^^^ | 14:11 |
| fdegir | mmedvede: will do that in sandbox-ci | 14:12 |
| fdegir | yolanda: while you are at it: https://review.openstack.org/#/c/386006/ | 14:12 |
| fdegir | :) | 14:12 |
| *** openstackgerrit has quit IRC | 14:18 | |
| mmedvede | fyi, this is the script that parses gerrit comments and creates the table up top https://github.com/openstack-infra/system-config/blob/master/modules/openstack_project/files/gerrit/hideci.js | 14:18 |
| *** openstackgerrit has joined #openstack-third-party-ci | 14:19 | |
| fdegir | mmedvede: thx, the name matches so the content is what I need to adjust as you say | 14:23 |
| *** hamzy has joined #openstack-third-party-ci | 14:30 | |
| *** rajinir has joined #openstack-third-party-ci | 15:00 | |
| openstackgerrit | Mark Hamzy proposed openstack/third-party-ci-tools: Add Continuous Integration (CI) example https://review.openstack.org/384243 | 15:28 |
| *** krtaylor has quit IRC | 15:56 | |
| *** krtaylor has joined #openstack-third-party-ci | 16:52 | |
| *** Apoorva has joined #openstack-third-party-ci | 16:55 | |
| *** Apoorva has quit IRC | 16:57 | |
| *** Apoorva has joined #openstack-third-party-ci | 16:58 | |
| *** Apoorva has quit IRC | 17:03 | |
| *** Apoorva has joined #openstack-third-party-ci | 17:08 | |
| *** rfolco has quit IRC | 17:13 | |
| *** rfolco has joined #openstack-third-party-ci | 17:14 | |
| *** Apoorva has quit IRC | 17:14 | |
| *** Apoorva has joined #openstack-third-party-ci | 17:22 | |
| *** rfolco has quit IRC | 18:50 | |
| *** rfolco has joined #openstack-third-party-ci | 18:58 | |
| *** hamzy has quit IRC | 20:00 | |
| *** openstackgerrit has quit IRC | 20:19 | |
| *** openstackgerrit has joined #openstack-third-party-ci | 20:19 | |
| *** Apoorva has quit IRC | 20:23 | |
| *** Apoorva has joined #openstack-third-party-ci | 20:41 | |
| *** Apoorva has quit IRC | 20:48 | |
| *** Apoorva has joined #openstack-third-party-ci | 20:49 | |
| *** krtaylor has quit IRC | 21:23 | |
| *** Apoorva_ has joined #openstack-third-party-ci | 21:23 | |
| *** Apoorva has quit IRC | 21:27 | |
| *** rfolco has quit IRC | 21:28 | |
| *** Apoorva_ has quit IRC | 21:28 | |
| *** rajinir has quit IRC | 22:16 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!