| *** rfolco has joined #openstack-third-party-ci | 01:24 | |
| *** rfolco has quit IRC | 01:25 | |
| *** sandanar has joined #openstack-third-party-ci | 04:01 | |
| *** sandanar_ has joined #openstack-third-party-ci | 04:09 | |
| *** sandanar has quit IRC | 04:12 | |
| *** sandanar_ has quit IRC | 04:20 | |
| *** sandanar has joined #openstack-third-party-ci | 06:03 | |
| openstackgerrit | Isaac Beckman proposed openstack/third-party-ci-tools: Bind\unbind to pci vfio driver https://review.openstack.org/346639 | 08:12 |
|---|---|---|
| openstackgerrit | Isaac Beckman proposed openstack/third-party-ci-tools: Bind\unbind pci device to vfio driver https://review.openstack.org/346639 | 08:14 |
| openstackgerrit | Isaac Beckman proposed openstack/third-party-ci-tools: Bind\unbind pci device to vfio-pci driver https://review.openstack.org/346639 | 08:20 |
| openstackgerrit | Isaac Beckman proposed openstack/third-party-ci-tools: Bind\unbind pci device to vfio-pci driver https://review.openstack.org/346639 | 09:39 |
| *** krtaylor has joined #openstack-third-party-ci | 12:04 | |
| *** rfolco has joined #openstack-third-party-ci | 12:33 | |
| *** azvyagintsev has joined #openstack-third-party-ci | 14:02 | |
| *** pglass has joined #openstack-third-party-ci | 14:22 | |
| *** pglass has left #openstack-third-party-ci | 14:23 | |
| *** AJaeger has joined #openstack-third-party-ci | 14:31 | |
| azvyagintsev | AJaeger: thanks | 14:31 |
| AJaeger | azvyagintsev: not sure why you want to discuss here, but here am I ;) | 14:32 |
| azvyagintsev | i have no idea) we just do same on friday, with mmedvede :) | 14:32 |
| AJaeger | azvyagintsev: I can only tell you what we do in OpenStack CI ;) | 14:32 |
| AJaeger | http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/projects.yaml#n2140 shows how the tox template can be used. | 14:33 |
| azvyagintsev | so, i dint get an idea , do you have any example of using ? | 14:33 |
| AJaeger | IF you use that - here's the name is linters - then OpenStack CI will basically run "tox -e linters". | 14:33 |
| AJaeger | Basically, since it does some logging etc as well. | 14:33 |
| AJaeger | and your project would have an tox.ini environment like fuel-ccp-debian-base has | 14:34 |
| azvyagintsev | found, looks pretty same with tox builder | 14:35 |
| AJaeger | azvyagintsev: and you also need to schedule the tox invocation in zuul/layout.yaml - just search for fuel-ccp-debian-base and how it invokes linters. Or any other repo. That repo might use a template. | 14:36 |
| azvyagintsev | but, its skip some logs.. such "test-results" | 14:36 |
| AJaeger | it includes the most relevant logs needed for these - and most logging is done to the console anyway | 14:37 |
| AJaeger | azvyagintsev: add the tox environment, best as non-voting, and then get it working. | 14:38 |
| azvyagintsev | okay, i can't see 'huge' difference for it:) if you ask me to use "linters" - i just migrate to it. give me a moment | 14:38 |
| azvyagintsev | btw, is it possible to move it into 'vote' mote later ? | 14:39 |
| AJaeger | pep8 is used by python projects - linters by some others. | 14:39 |
| AJaeger | You can also use another name. But each tox run needs a new virtual machine, therefore we prefer to group them - and linters is one name to use... | 14:40 |
| azvyagintsev | ah, there the point..sure its better to group the | 14:41 |
| AJaeger | your call - if you have very distinct jobs, use distinct environments. But if grouping is possible... | 14:43 |
| azvyagintsev | They definitely can be grouped.I found in builder macro- envlist: linters - i din't gate how-to run it againt my tox...should i create such env? | 14:45 |
| azvyagintsev | AJaeger: found, another one env https://github.com/openstack/fuel-ccp-ci-config/blob/master/tox.ini#L6-L9 | 14:46 |
| azvyagintsev | is it possible to push custom env list or whatever ? | 14:47 |
| *** AJaeger has quit IRC | 14:50 | |
| *** AJaeger has joined #openstack-third-party-ci | 15:03 | |
| AJaeger | azvyagintsev: sorry, had to reboot... | 15:03 |
| azvyagintsev | np, wait for you anyway :) | 15:03 |
| AJaeger | azvyagintsev: what do you mean with "push custom env list"? | 15:03 |
| azvyagintsev | in example https://github.com/openstack/fuel-ccp-ci-config/blob/master/tox.ini#L6-L9 - they use testenv linters which run bash. how-to deal if i have multiple envs to test in one time ? | 15:04 |
| azvyagintsev | is it possible to pass liest of env's to test, or somehow combine them in tox. or i should do same linters check in bash file? | 15:05 |
| AJaeger | azvyagintsev: you would use one env that does several calls, let me show example... | 15:05 |
| azvyagintsev | AJaeger: it will be great, thanks !) | 15:06 |
| AJaeger | http://git.openstack.org/cgit/openstack/neutron/tree/tox.ini#n87 | 15:06 |
| AJaeger | Several commands, one after the other | 15:06 |
| azvyagintsev | sure, i saw this option - but if first one fail with exit 1 ; second one will not run ;( | 15:07 |
| AJaeger | azvyagintsev: there're way to do this with tox. | 15:08 |
| AJaeger | there's an option | 15:08 |
| azvyagintsev | AJaeger yeah, i found | 15:09 |
| azvyagintsev | '-' before command | 15:09 |
| AJaeger | azvyagintsev: I suggest you start with linters, see how it works and go from there... | 15:10 |
| AJaeger | you don't need to have it perfect the first iteration ;) | 15:10 |
| azvyagintsev | AJaeger: but i want :) since it's really to hard sometimes to merge changes...specially in project's which don't have ant tests | 15:11 |
| azvyagintsev | AJaeger: tox suppress exit code from itself also ;( so its no sense to use - since tox -ve linters ;echo $? always = 0. thats mean, job always will be green | 15:24 |
| AJaeger | azvyagintsev: tox fails definitely for me in tests... | 15:25 |
| azvyagintsev | AJaeger: i mean, with "commands = -test1 \n -test2". (i add 'minus' before command, https://testrun.org/tox/latest/example/basic.html#ignoring-a-command-exit-code but i still want to get exit 1 from tox | 15:26 |
| azvyagintsev | otherwise , tox will exit from test, on first test1 fail | 15:26 |
| AJaeger | azvyagintsev: read https://tox.readthedocs.io/en/latest/config.html?highlight=ignore_errors#confval-ignore_errors=True|False(default) as well | 15:27 |
| AJaeger | I find it good to abort directly on first fail... | 15:27 |
| AJaeger | otherwise you might need a shell script that records failures and exits with -1 in case one of the tests fails. | 15:27 |
| azvyagintsev | AJaeger: awesome. ignore_errors=True fix issue! | 15:28 |
| AJaeger | ;) | 15:29 |
| azvyagintsev | AJaeger: would you kindly to take a look https://review.openstack.org/#/c/344838/ and https://review.openstack.org/#/c/344922/ ? i hope, i'm on finish line :) | 15:43 |
| * AJaeger checks | 15:44 | |
| AJaeger | azvyagintsev: check how it's done in infra in similar cases, just search for linters. I commented on the issues. The murano-apps chagne LGTM | 15:47 |
| azvyagintsev | AJaeger: thx, only one- didn't get what it 'And move the voting defition to the top like others are.' you want to move 'vote' row to '['jobs']' part> to this section https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L1061 ? | 15:57 |
| AJaeger | azvyagintsev: yes, to that part. | 16:14 |
| * AJaeger has to sign off now. | 16:14 | |
| *** AJaeger has left #openstack-third-party-ci | 16:14 | |
| azvyagintsev | AJaeger: thanks for hepl! i guess patch done | 16:20 |
| *** Apoorva has joined #openstack-third-party-ci | 16:24 | |
| *** Apoorva has quit IRC | 16:27 | |
| *** Apoorva has joined #openstack-third-party-ci | 16:28 | |
| openstackgerrit | Merged openstack/third-party-ci-tools: Bind\unbind pci device to vfio-pci driver https://review.openstack.org/346639 | 17:30 |
| *** sandanar has quit IRC | 17:52 | |
| *** Apoorva_ has joined #openstack-third-party-ci | 18:01 | |
| *** Apoorva has quit IRC | 18:04 | |
| *** Apoorva_ has quit IRC | 18:51 | |
| *** Apoorva has joined #openstack-third-party-ci | 18:52 | |
| *** Apoorva has quit IRC | 19:53 | |
| *** Apoorva has joined #openstack-third-party-ci | 19:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!