| hemanth | tkajinam: thanks for review on https://review.opendev.org/c/openstack/aodh/+/837053, I left some comments on LP#1974682. Please check when you have time. In short this is fixed in gnocchi but waiting for to be part of release | 04:09 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Ignore Gnocchi API error when the metric is not yet created https://review.opendev.org/c/openstack/aodh/+/843764 | 04:42 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Ignore Gnocchi API error when the metric is not yet created https://review.opendev.org/c/openstack/aodh/+/843764 | 05:02 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Ignore Gnocchi API error when the metric is not yet created https://review.opendev.org/c/openstack/aodh/+/843764 | 05:04 |
| tkajinam | hemanth, thanks | 05:12 |
| tkajinam | hemanth, I've replied to your comment in ^^^ | 05:14 |
| hemanth | tkajinam: thanks, I am thinking an additional check similar to this https://review.opendev.org/c/openstack/cloudkitty/+/801324/2/cloudkitty/collector/gnocchi.py | 05:14 |
| tkajinam | hemanth, yeah checking the metric in advance would be an option | 05:15 |
| tkajinam | an alternative option I mean | 05:16 |
| tkajinam | just checking the response like that example might be enough | 05:16 |
| hemanth | yes that could be better approach as 400 error code can be returned for various reasons | 05:17 |
| hemanth | and aodhclient functional tests need to be adjusted a bit.. the aggregate method should be mean instead of last and creator should be admin | 05:18 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Ignore Gnocchi API error when the metric is not yet created https://review.opendev.org/c/openstack/aodh/+/843764 | 05:21 |
| tkajinam | hemanth, ^^^ wdyt | 05:22 |
| hemanth | tkajinam: thanks, i will test this with python-aodhclient and will let you know | 05:23 |
| opendevreview | Takashi Kajinami proposed openstack/python-aodhclient master: DNM: Testing ... https://review.opendev.org/c/openstack/python-aodhclient/+/843767 | 05:24 |
| tkajinam | hmm... gerrit might not allow usage of depends-on, looking at how we pull aodh into python-aodhclient's tests | 05:25 |
| opendevreview | Hemanth N proposed openstack/python-aodhclient master: Change aggregation method to mean https://review.opendev.org/c/openstack/python-aodhclient/+/843776 | 06:16 |
| hemanth | tkajinam, aodhclient changes ^^ to make functional tests work with https://review.opendev.org/c/openstack/aodh/+/843764 | 06:17 |
| opendevreview | Hemanth N proposed openstack/python-aodhclient master: Change aggregation method to mean https://review.opendev.org/c/openstack/python-aodhclient/+/843776 | 06:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!