| opendevreview | hongbin proposed openstack/election master: Add Hongbin Lu Candidacy for Zun https://review.opendev.org/c/openstack/election/+/909345 | 02:26 |
|---|---|---|
| *** tkajinam is now known as Guest213 | 08:56 | |
| opendevreview | Artem Goncharov proposed openstack/election master: Add Artem Goncharov candidacy for OpenStackSDK PTL https://review.opendev.org/c/openstack/election/+/909450 | 13:37 |
| opendevreview | Hervé Beraud proposed openstack/governance master: Takashi Kajinami is now an Oslo release liaison https://review.opendev.org/c/openstack/governance/+/909455 | 15:05 |
| frickler | hberaud: ^^ reminds me that you might want to check https://review.opendev.org/c/openstack/governance/+/907350 | 15:16 |
| hberaud | ack thanks | 15:16 |
| opendevreview | Sean McGinnis proposed openstack/openstack-manuals master: Update link to git-review setup https://review.opendev.org/c/openstack/openstack-manuals/+/909458 | 15:26 |
| opendevreview | Hervé Beraud proposed openstack/governance master: Takashi Kajinami is now an Oslo release liaison https://review.opendev.org/c/openstack/governance/+/909455 | 15:39 |
| opendevreview | Merged openstack/governance master: Update jakeyip email https://review.opendev.org/c/openstack/governance/+/909080 | 15:45 |
| frickler | tc-members: do liaison updates fall under project updates? I would say yes, but it might help to actually list them under https://governance.openstack.org/tc/reference/house-rules.html#other-project-team-updates ? | 15:51 |
| JayF | I've always marked them as such. | 15:53 |
| JayF | but as you noticed; it's not super clear -- I always assumed that was intentional discretion left in there rather than an omission, but I'm OK with making it more specific | 15:53 |
| opendevreview | Merged openstack/governance master: Drop six https://review.opendev.org/c/openstack/governance/+/909339 | 15:56 |
| spotz[m] | gmann: I got a few of those reviews, I'll do some more later if no one has grabbed them | 16:53 |
| JayF | With that ping, I've got 'em open too | 16:54 |
| spotz[m] | Like Jay I always went with that | 16:54 |
| JayF | Doesn't look like we have +2 on all those repos | 16:56 |
| JayF | e.g. https://review.opendev.org/c/openstack/openstack-chef/+/909168 | 16:56 |
| JayF | landed the changes that already had 2x+2, put a +2 on the rest excepting ^ that one which I don't have access to | 16:59 |
| frickler | hmm, I do have +3 on openstack-chef and approved that patch now | 17:01 |
| frickler | guess I'll also need to use release team powers to abandon other open reviews later | 17:01 |
| spotz[m] | I didn't have +2 on that one either JayF | 17:03 |
| frickler | spotz[m]: I think you wanted to vote CR+2 instead of Verified+2 on https://review.opendev.org/c/openstack/cookbook-openstack-dashboard/+/909156 . with the latter, zuul isn't running so no trigger is happening to merge the change | 18:00 |
| frickler | (and I admit it took me some time to spot the issue, too ;) | 18:01 |
| fungi | yeah, for those changes you basically have to emulate zuul | 18:04 |
| frickler | do we? I thought the noop template would take care of that. | 18:06 |
| fungi | oh, if they have the noop template applied then it should just merge them as soon as they're approved | 18:07 |
| frickler | I mean, I could manually submit the change now, but I'd prefer to leave that task to zuul | 18:07 |
| fungi | i wasn't clear on how the openstack-retired acl was arranged | 18:07 |
| frickler | it's not the acl, the noop template was added to the repos explicitly | 18:07 |
| frickler | https://review.opendev.org/c/openstack/project-config/+/909134/2/zuul.d/projects.yaml | 18:08 |
| fungi | nut yes, if you don't have the noop-jobs template on those projects you have to *also* add verified +2 votes and click the approve button (or rest api equivalent), with the noop-jobs template applied you merely have to satisfy the other merge requirements (code-review +2, workflow +1, no cr-2 nor w-1, no wip flag...) | 18:09 |
| fungi | s/nut/but/ | 18:09 |
| frickler | actually adding a second W+1 triggered zuul now. so it somehow only did not react to the combination of W+1 and V+2 at the same time | 18:12 |
| frickler | or it did not react because the CR+2 was missing, hmm | 18:12 |
| fungi | it won't react if there is no cr+2 (more precisely, it won't enqueue changes if the combination of current gerrit merge requirements and those it's configured to add won't result in a mergeable change) | 18:17 |
| spotz[m] | frickler: yep, if someone can fix it please do or I’ll get it when I get home | 18:18 |
| frickler | spotz[m]: already solved, thx | 18:20 |
| * frickler is still feeling a bit weird, deleting all the stuff I started my career in OpenStack with ... | 18:29 | |
| fungi | pretend it's cathartic | 18:34 |
| fungi | eventually you'll delete enough of your own work that it just seems like a monday | 18:35 |
| TheJulia | heh | 18:39 |
| frickler | yeah, I guess I'm done with that now. except ... | 18:43 |
| frickler | JayF: did you not see my almost-parallel -1 on https://review.opendev.org/c/openstack/openstack-chef-repo/+/909169 or do you intend to not agree? | 18:43 |
| JayF | your comment is valid | 18:44 |
| JayF | and my vote is removed | 18:44 |
| JayF | (I batch-opened them and never saw your vote/comment) | 18:44 |
| frickler | JayF: that's kind of what I assumed, thx for checking. now just need to wait and see whether gmann also agrees | 18:56 |
| gmann | frickler: thanks checking | 19:05 |
| gmann | frickler: this was to correct the README file, I updated the commit msg now, https://review.opendev.org/c/openstack/openstack-chef-repo/+/909169 | 19:12 |
| gmann | frickler: for liaison updates: you are right. its project-update topic | 19:13 |
| opendevreview | Merged openstack/openstack-manuals master: Update link to git-review setup https://review.opendev.org/c/openstack/openstack-manuals/+/909458 | 20:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!