| rosmaita | JayF: did you upload the 2023-11-07 meeting recording ? I don't see it at https://www.youtube.com/@openstack-tc/videos | 00:02 |
|---|---|---|
| JayF | I did. I don't know why it's not up there. I'm going to go see if I missed mashing a button. | 00:52 |
| JayF | helps if I mark the video public | 00:53 |
| JayF | rosmaita: https://www.youtube.com/watch?v=qv6nSRhfV_M | 00:53 |
| JayF | sorry about that, thank you for noticing! | 00:53 |
| rosmaita | thanks! | 00:53 |
| opendevreview | Brian Rosmaita proposed openstack/governance master: Resolution to create openstack-unmaintained core https://review.opendev.org/c/openstack/governance/+/900940 | 13:33 |
| *** d34dh0r5- is now known as d34dh0r53 | 15:00 | |
| opendevreview | Merged openstack/governance master: Update Nodejs Runtime to Nodejs v20 From Nodejs v18 for Caracal Cycle https://review.opendev.org/c/openstack/governance/+/900224 | 15:19 |
| opendevreview | Merged openstack/governance master: Retire js-openstack-lib https://review.opendev.org/c/openstack/governance/+/898858 | 15:19 |
| opendevreview | Merged openstack/governance master: Appoint Eric Zhang as PTL of Venus https://review.opendev.org/c/openstack/governance/+/899781 | 15:37 |
| opendevreview | Merged openstack/governance master: Appoint Alex Song as PTL of Cyborg https://review.opendev.org/c/openstack/governance/+/899813 | 15:37 |
| opendevreview | Merged openstack/governance master: Mark Sahara project Inactive https://review.opendev.org/c/openstack/governance/+/899986 | 15:37 |
| *** gthiemon1e is now known as gthiemonge | 15:55 | |
| frickler | tc-members: something new came in in regard to the unmaintained process: gerrit requires that there are no open reviews before a branch gets deleted. do we want to abandon all open branches on e.g. stable/yoga or do we want to look into moving them over to unmaintained/yoga? | 16:14 |
| fungi | i had previously assumed we would abandon open changes before deleting the stable branch, and then the author would create new changes on unmaintained if still relevant, but i didn't know about the move change rest api method until a few minutes ago; it does seem like a friendlier option | 16:16 |
| dansmith | that's kinda unfortunate, but if that's how it has to be then... | 16:17 |
| fungi | i think the point is that it doesn't *have* to be unfortunate, whatever scripting is done around this could enumerate open changes for the to-be-deleted branch and move them to the replacement branch, we just need to create e.g. unmaintained/yoga (perhaps immediately) prior to deleting stable/yoga so that both exist long enough to iterate over open changes and move them | 16:20 |
| dansmith | if you want to go to that complication, sure, but honestly closing them is probably easiest right? | 16:21 |
| dansmith | I just meant unfortunate because I'd rather they stay open and be unmerge-able or something. but maybe closing them and requiring them to be reopened manually will help to avoid there being a bunch still open when it goes to eol | 16:21 |
| frickler | oh, we'll also need to update .gitreview similar to when branching from master | 16:22 |
| frickler | and I don't think one can re-open a patch that was against stable/yoga, would have to download and re-submit against unmaintained/yoga | 16:23 |
| JayF | Now, using the API to post something saying "run `git-review --move 12345 unmaintained/lol` to move your change to the new branch" as a comment (if such a thing exists), would be awesome | 16:23 |
| JayF | but I doube such a thing exists yet | 16:23 |
| JayF | *doubt | 16:23 |
| frickler | well the API endpoint exists, but no CLI afaict https://gerrit-documentation.storage.googleapis.com/Documentation/3.0.3/rest-api-changes.html#move-change | 16:25 |
| frickler | also no UI? | 16:25 |
| clarkb | hitting the gerrit api with curl is really easy. I do it semi regularly for admin actions | 16:25 |
| frickler | so maybe someone wants to checks whether it is possible to move an abandoned change off an deleted branch and restore it afterwards? | 16:27 |
| dansmith | download and resubmit seems easy enough to me | 16:27 |
| frickler | can we just document this in the p-t-g patch or do we need a second amendment? | 16:30 |
| JayF | this feels like implementation details to me | 16:31 |
| fungi | frickler: i don't think the change needs to be abandoned in order to move it, just that the permission that rest api call relies on is whether the user is allowed to abandon the original | 16:32 |
| fungi | oh, wait, i get it. you're saying abandon rather than move them, but then expect the owner to move the abandoned change later if they want to resubmit it | 16:33 |
| fungi | that's probably about the same amount of work for the user as fetching and pushing it again | 16:34 |
| dansmith | that's what I'd say | 16:34 |
| dansmith | abandon them and let the user rebase and resubmit | 16:34 |
| fungi | yeah, if the plan is to abandon all open changes anyway, i don't see that the move method in the rest api really buys anyone much convenience. it would be useful if there was a desire to move open changes to the new branch automatically before deleting the old branch | 16:35 |
| fungi | however, that's a relatively minor improvement that can be made to the process in the future too, it doesn't have to be implemented now | 16:36 |
| *** JasonF is now known as JayF | 18:47 | |
| gmann | rosmaita: thanks for resolution amendment, I left one comment otherwise I am ok with change. option to create project specific group resolve my concern I raised in meeting https://review.opendev.org/c/openstack/governance/+/900940/3/resolutions/20231114-amend-unmaintained-status.rst#27 | 22:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!