Wednesday, 2023-12-13

opendevreviewClay Gerrard proposed openstack/swift master: wip: shards listing tests  https://review.opendev.org/c/openstack/swift/+/90356700:07
opendevreviewMerged openstack/swift master: proxy: remove x-backend-record-type=shard in object listing  https://review.opendev.org/c/openstack/swift/+/90147704:00
zigotimburke: (and all other contributors) https://bugs.launchpad.net/swift/+bug/204635213:57
zigo(3x unit test failure under Python 3.12)13:57
opendevreviewAlistair Coles proposed openstack/swift master: sq: fixups  https://review.opendev.org/c/openstack/swift/+/90360217:53
opendevreviewAlistair Coles proposed openstack/swift master: sq: get rid of s3api FakeSwift  https://review.opendev.org/c/openstack/swift/+/90360317:53
opendevreviewAlistair Coles proposed openstack/swift master: sq: fixups  https://review.opendev.org/c/openstack/swift/+/90360219:03
opendevreviewAlistair Coles proposed openstack/swift master: sq: get rid of s3api FakeSwift  https://review.opendev.org/c/openstack/swift/+/90360319:03
acolesnot sure if there is a meeting today but I can't make it, apologies20:49
mattoliverThanks acoles 21:00
mattoliver@zigo thanks for the link. timburke is on jury duty, but I'll take a look21:01
jianjianEnjoy your evening, acoles21:01
zigomattoliver: Great!21:01
zigomattoliver: There's also this that is a concern: https://bugs.debian.org/105818621:02
mattoliverTim's on jury duty, so I'll chair the meeting today... it might be a quick one because I don't have all the info.. but we can at least get things into the minutes for links21:02
mattoliverzigo: kk21:02
zigoThe issue seems to be in future, though it needs fixing too ... :/21:02
zigoI had a look, unit tests are failing all over in this package ...21:03
mattoliverI know tim was looking into py312 support a while ago, so I'll try and figure out where he was at21:03
mattoliveranyway meeting21:03
mattoliver#startmeeting21:04
opendevmeetmattoliver: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee'21:04
zigoI'll see if I can share some patches too, but can't promis (I have 4 dozens of packages that are more or less in the same state since Py 3.12 was made as available version in Unstable).21:04
mattoliverHold on its been a while :P21:04
mattoliver#startmeeting swift21:04
opendevmeetMeeting started Wed Dec 13 21:04:32 2023 UTC and is due to finish in 60 minutes.  The chair is mattoliver. Information about MeetBot at http://wiki.debian.org/MeetBot.21:04
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.21:04
opendevmeetThe meeting name has been set to 'swift'21:04
mattoliverWhose here for the swift meeting?21:04
mattolivero/21:04
jianjianmaybe it's eventlet issue, does eventlet support 3.12 yet?21:04
mattoliverjianjian: welcome!21:05
jianjianthanks :-)21:05
mattoliveracoles: wont be here unfortuantely21:05
mattoliverI've only just updated the agenda (last minute based on what I could see in email), so as you can see I'm super ready for this :P21:06
mattoliver#link https://wiki.openstack.org/wiki/Meetings/Swift21:06
mattoliverLooks like it's just you and me today jianjian, not sure where everyone else is 🤷 21:07
mattoliverbut thats ok. Could be a nice quick one :)21:07
mattoliver#topic Tim on jury duty21:07
mattoliverSo tim isn't around and he may be off until mid to late Jan he says. 21:08
jianjianyeah, Jan 19 I remember21:08
mattoliverAs we all know timburke does an amazing amount of work for the project, so we may need to pitch in and help while he's absent. 21:09
mattoliveroh nice thanks jianjian 21:09
mattoliverI'm happy to chair the meetings while he's gone and attempt to do other things, but I'm defintely no timburke .21:10
mattoliverNext topic21:10
mattoliver#topic  Christmas break21:10
jianjianthanks Matt for carrying the baton21:10
mattolivernps 21:11
jianjianand a lot of swift developers will be on christmas break, plus company holiday starting from Dec.2121:12
mattoliverFor those of us in countries that celebrate this time of year the next few weeks will be a little spotty with availablity. So we need to decide what to do about meetings and such21:12
mattoliveryeah!21:12
jianjianI am available for next week, but not the one after21:14
mattoliverkk, I think meeting on the 27th should defintely be off. But I'll also be on vacation on 3rd Jan. So I wonder if we should skip those 2.21:14
mattoliverOK, so lets have a meeting next week and that can be the last. Maybe the first meeting of the new year will be on 10th of Jan.21:15
mattoliverI'll make sure I make a not of that the swift meeting page and maybe figure out how to add it to the channel header here 21:15
mattoliverSound good to you jianjian seeing as we seem to get to decide :P 21:16
jianjian10th of Jan works for me.21:16
jianjian😉21:17
mattoliverI'll remind and bring it up again at next weeks meeting. If someone else wants to chair on the 3rd Jan then they until next week to let me know ;) 21:17
mattolivernice!21:17
mattoliver#topic Unit test failure under Python 3.1221:17
mattoliver#link https://bugs.launchpad.net/swift/+bug/204635221:17
jianjianI just saw this https://review.opendev.org/c/openstack/governance/+/902585/12/goals/proposed/modernize-openstack-async-model.rst#1421:17
jianjian"Indeed this library currently do not support Python 3.12 and face many issues with Python 3.11 (those are described below)."21:18
mattoliveroh interesting21:18
jianjianso eventlet needs work to support 3.1121:18
mattoliver#link https://review.opendev.org/c/openstack/governance/+/902585/12/goals/proposed/modernize-openstack-async-model.rst#1421:18
jianjianthis is the link from @zaitcev yesterday21:19
mattoliverahh ok21:19
mattoliverthis also doesn't help the eventlet 3.11 problems: 21:20
mattoliver#link https://github.com/eventlet/eventlet/issues/82421:20
mattoliverBasically they need to dev support.21:20
jianjianunfortunately21:20
jianjianyeah21:20
mattoliveryeah. I think this is a dicussion that probably needs the whole team to work through.21:21
jianjianI agree21:21
zaitcevPrimarily Tim I think21:21
zaitcevHe's been our interface to Eventlet for years.21:22
mattoliveryeah21:22
mattoliverI'll take a poke at the bug at least and see where Tim got with py312 support in python.. so attempt some kind of progress or at least familarization. 21:23
mattoliverI'll contact timburke and get some of his thoughts too.21:23
jianjiangreat!21:23
mattoliverNot sure what else to discuss on it now though.21:24
mattoliverThe next few topics are gleaned from what I saw in recent work in Swift via my emails. I'll do better a curating a proper list for next week.21:25
mattoliverThe next 2 topics I was hoping al or ash would be here to talk about.. so I'll bring them up for the minutes but there probably wont be anything to say or update about them.21:25
mattoliver#topic s3acl and fakeswift21:26
mattoliverI've seen a bunch of work on s3acl and fakeswift from Al and clay, so was curious about all this work. 21:26
mattoliverI assume its fall out from the s3api PartNum stuff, although maybe not21:27
mattoliverchain seems to start21:27
mattoliver#link https://review.opendev.org/c/openstack/swift/+/90256421:27
jianjianack21:27
mattoliverWhen Al and Clay are going back a forwards on something I assume there is a reason ;) 21:28
jianjianand both patches are work in progress21:28
mattoliverBut I have no context, so moving on :P 21:28
mattoliveryeah21:28
mattoliver#topic Partnum support21:28
mattoliverI was hoping to get an update from ash on this21:29
mattoliverBut he doesn't seem to be around. So I'll drop a link and move on I guess21:29
mattoliverchain starts:21:30
mattoliver#link https://review.opendev.org/c/openstack/swift/+/89457021:30
jianjianI heard from clay, seems this patch is getting closer to done.21:30
mattoliverThere are some patches at the end of the chain that are meant for squashing in, so things are still happening21:30
mattolivernice!21:30
mattoliverwell maybe next week we wont have to talk about it at all. and with the base at patchset 76, I bet Ash would be happy about that!21:31
mattoliver#topic get_namespaces api21:31
mattoliverThis is the one I'm more interesting in :)21:31
jianjianyess21:32
mattoliverI've been stuck working on a Nvidia downstream project (related to swift) and just starting to get back to speed on this one21:32
jianjiansaw you started again to review them, thanks21:32
mattolivernps21:33
jianjianwe just got two prerequisite patches from al merged21:33
mattoliverthis feels like a good first patch in the chain:21:33
mattoliver#link https://review.opendev.org/c/openstack/swift/+/90264621:33
mattoliveryeah, looks like first 3 (in the link I just posted) have now been merged.21:34
mattoliverjianjian: your container server patch and my proxy side patch seem to be pretty good too 21:34
jianjianI feel so, they are in good shape :-)21:35
mattoliverI'm excited to see 900740 to finally get marker/end_marker and includes support21:35
jianjianso next step will be, squash the container follow-up into the container patch, and squash proxy follow-up into your proxy patch21:35
mattoliverkk21:35
mattoliveror at least land them at the same time I guess21:35
mattoliverI've almost finished reviewing 900740, just a wanted to run some vsaio testing of my own and run the probetests myself.21:36
jianjianyes. maybe carry and deploy them internally at nvidia after each follow-up get +121:36
jianjiansince we are already running the first container/proxy patches.21:37
mattoliverBut the really interesting one in the chain (for me) is 21:37
mattoliver#link https://review.opendev.org/c/openstack/swift/+/900350 21:37
mattoliveryeah, true.. I still feel a bit weird that we use nvidia prod as a preprod for upstream patches :P 21:38
jianjianthanks for testing 90074021:38
mattoliverit's like burn in testing of patches :P 21:38
jianjianfor 900350, I have tested in my vsaio, and ran those probe tests. all good21:39
mattoliver900350 reworks and refactors a bunch of the when and how we use caching of shardranges/namespaces21:39
mattoliveroh great to know!21:39
mattolivercool. I'll move onto that one next too. but that gives me great confidence21:39
mattoliverthere is a lot of code churn in it, but I think it'21:40
jianjianI ran probe tests, based the 900350 + your proxy patch on top of master branch, I wanted to check backward compatibility for upgrade purpose 21:40
mattoliverit's for the the better21:40
jianjianonly a few probe tests failed, because setup was wrong (checking shard-type to be Namespace)21:40
jianjianafter fixed, they all passed21:41
mattolivercool21:41
zaitcevI wish you named it something other than namespace. But it's in a grand Swift tradition of devices that are not devices, partitions that are not partitions, and of course containers.21:41
mattoliverROFL zaitcev +10021:42
jianjianROFL21:42
jianjianany suggestions, zaitcev?21:42
zaitcevI thought they were more like segments or regions.21:43
zaitcevLooking at what they do.21:43
zaitcevBut I kept quiet because I know nothing about their design and function.21:44
jianjianwe already have concept of segment or region, SLO segments, region for swift cluster21:44
jianjianthanks for bringing it up though, we will keep working on this most difficult task in programming, naming!21:45
mattoliverthe proxy shard list building in the container controller is a little nuts and then we threw in caching, which made it even more complicated to follow (although it make things work much better at scale). Al has reworked the logic, found places the old code would do the wrong thing (although we never envoked, luckily these areas) and refactored to make it much more readable and easier to define when things happen.. so it's an amazing21:45
mattoliveramount of work.. but needs some close review attention to make sure we haven't missed anything!21:45
zaitcevIn my mind, a namespace has something to do with a supra-object evolution. When you need two of the same names to exist, but they don't necessarily have an administrative division, that would make them tenants.21:46
zaitcevIt does not look like anything that happens with sharding.21:47
jianjianI can also help on reviewing that shard list patch 21:47
zaitcevAnyhow, it's too late.21:47
mattoliverthanks jianjian 21:48
mattoliverthats all I had so..21:48
mattoliver#topic open discussion21:48
mattoliverwas there anything else to bring up?21:48
zaitcevMatt21:49
zaitcevCould you replace Al and just land the watcher patch?21:49
jianjianNamespace is a simplified version of ShardRange (a sub-shard of sharded container), mainly for performance reasons. only has attributes name, lower and upper.21:49
zaitcevhttps://review.opendev.org/c/openstack/swift/+/78765621:49
zaitcevHe'll never get to it21:49
zaitcevAnd I'm afraid it will rot out of the tree. If we commit it, at least you two will remember to change the watcher for the next API change.21:50
mattoliverzaitcev: yes! that damn thing is still around, I'll put it on my todo list before Christmas break21:50
mattoliverstill not landed I mean21:51
mattoliverby around.. it should be landed. It makes darkdata better which already exists21:52
zaitcevYeah it's pretty safe for regressions. If you aren't running watchers, you'll never know it's there.21:52
mattoliversorry it's taken so long zaitcev 21:52
zaitcevWell, Tim invented it.21:53
zaitcevI completely forgot about it when I introduced watchers.21:53
mattoliverthe patch could also grab namespace objects (sorry) instead of shards too. So yeah I good one to maybe try and sneak in before the get_namespace patches land.. although it's ok if it just asks for shardranges, that api isn't going anywhere :)21:56
mattolivermight even be able to trick jianjian to take a look too seeing as he's becoming a sharding expert ;) 21:56
mattoliveranyway, we're almost at time and I have a 5 year old yelling for me21:57
mattoliverSo maybe I'll call it21:57
zaitcevTake care.21:57
mattoliverThanks for coming and thanks for working on swift!21:57
jianjianno problem, I will take a look at it21:57
mattoliver#endmeeting21:57
opendevmeetMeeting ended Wed Dec 13 21:57:28 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)21:57
opendevmeetMinutes:        https://meetings.opendev.org/meetings/swift/2023/swift.2023-12-13-21.04.html21:57
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/swift/2023/swift.2023-12-13-21.04.txt21:57
opendevmeetLog:            https://meetings.opendev.org/meetings/swift/2023/swift.2023-12-13-21.04.log.html21:57

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!