| opendevreview | Tim Burke proposed openstack/swift master: Inline parse_request from cpython https://review.opendev.org/c/openstack/swift/+/866801 | 00:27 |
|---|---|---|
| opendevreview | Tim Burke proposed openstack/swift master: Move non-ascii header parsing into parse_request() https://review.opendev.org/c/openstack/swift/+/866813 | 00:27 |
| opendevreview | Matthew Oliver proposed openstack/swift-bench master: refactor bin/bench into swiftbench/cli for testing https://review.opendev.org/c/openstack/swift-bench/+/866826 | 06:59 |
| opendevreview | Tim Burke proposed openstack/swift master: Move non-ascii header parsing into parse_request() https://review.opendev.org/c/openstack/swift/+/866813 | 20:05 |
| opendevreview | Tim Burke proposed openstack/swift master: Take on header parsing ourselves https://review.opendev.org/c/openstack/swift/+/866934 | 20:05 |
| kota | good morning | 20:58 |
| seongsoocho | good morning! | 20:59 |
| kota | seongsoocho: o/ | 20:59 |
| seongsoocho | \o/ | 21:00 |
| mattoliver | morning | 21:01 |
| acoles | o/ | 21:03 |
| mattoliver | so we just need a timburke | 21:04 |
| timburke | oh, right! | 21:06 |
| timburke | #startmeeting swift | 21:06 |
| opendevmeet | Meeting started Wed Dec 7 21:06:49 2022 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:06 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:06 |
| opendevmeet | The meeting name has been set to 'swift' | 21:06 |
| timburke | looks like we've already got people here for a swift meeting :-) | 21:07 |
| mattoliver | yup :) | 21:07 |
| timburke | i neglected to update the agenda, but mostly i just wanted to give updates on last week's items, anyway | 21:08 |
| timburke | #topic leading slashes bug | 21:08 |
| timburke | clayg pushed back on continuing to hack do pre/post processing, instead thinking that just inlining (and fixing) parse_request may be better | 21:09 |
| timburke | i finally got around to trying that approach -- and i'm torn about which one i prefer | 21:10 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/866801 | 21:10 |
| timburke | ^^^ inlines and fixes up parse_request | 21:10 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/863441 | 21:11 |
| timburke | ^^^ undoes the change with some post-processing | 21:11 |
| mattoliver | I guess there is a bigger maintainence burden on the latter approach.. but the other is trying to fix things in potentually odd spots. | 21:11 |
| mattoliver | either way, the initial refactor http protocol stuff is nice :) | 21:12 |
| timburke | the inlining did give me the opportunity to clean up some other hacks we had (specifically, by addressing https://bugs.python.org/issue33973 in a much more direct way) | 21:12 |
| timburke | and the function itself hasn't seen *that many* updates in the past ten years or so, looking at main | 21:13 |
| mattoliver | OK well that's promising. Not too much of a maintence burden if it doesn't change too much | 21:14 |
| acoles | timburke: thanks for doing more work! I haven't had chance to look at the second approach yet | 21:14 |
| timburke | otoh, there's a whole bunch more branches now present in our code that are likely untested, and it seems unlikely that we'd notice any upstream changes to the function in the future (so when there's inevitably another patch in a couple years, we won't even know to think about whether to apply it) | 21:15 |
| mattoliver | need a monthly zuul git diff job :P | 21:17 |
| acoles | mattoliver: volunteering ;-) | 21:17 |
| timburke | mattoliver, there's enough of a delta between us and upstream that i'm not sure how helpful that would be... though maybe diffing between upstream revisions could work well enough? | 21:17 |
| mattoliver | well maybe no diff from what we have, but from current master of eventlet is. | 21:18 |
| mattoliver | or whatever. so we can detect changes | 21:18 |
| mattoliver | or a git blame, or just an md5 check | 21:18 |
| mattoliver | (me is thinking out loud) | 21:18 |
| timburke | i also proposed a couple follow-ons -- the first moves another stdlib-workaround to parse_request, so we don't have to repeat a bunch of work that eventlet's doing; the second removes the need for the workaround entirely | 21:19 |
| timburke | so if you get a chance, take a look at the new approach, see which way you prefer. i think we *do* still need to do *something* -- there are just too many versions of python in the wild that break us, and no traction from upstream to fix it | 21:21 |
| timburke | and it'd be nice to have even our non-voting jobs green as we do some other CI maintenance stuff | 21:22 |
| timburke | speaking of... | 21:22 |
| timburke | #topic pytest | 21:22 |
| timburke | still no further feedback on the requirements change that's blocking us moving to pytest, which in turn is blocking us from testing on py310 in the gate | 21:23 |
| timburke | #link https://review.opendev.org/c/openstack/requirements/+/863581/ | 21:23 |
| timburke | i'll continue to badger people about that | 21:24 |
| mattoliver | thanks for that | 21:24 |
| timburke | but i also recently refreshed some gate results, and it looks like i might need to respin a bit anyway (some dependency errors around py2 probe tests) | 21:24 |
| mattoliver | ahh py2 :( | 21:25 |
| kota | :/ | 21:25 |
| timburke | #topic py311 segfault | 21:25 |
| timburke | upstream *did* respond quickly on https://github.com/python/cpython/issues/99886 -- the fix is merged, so it looks like there's just the one upstream release affected | 21:26 |
| mattoliver | oh cool | 21:26 |
| kota | nice | 21:27 |
| mattoliver | great job timburke | 21:27 |
| timburke | unit tests still fail on py311, though, so some of https://review.opendev.org/c/openstack/swift/+/866051 will still be necessary (just not necessarily the __slots__) | 21:27 |
| timburke | i'll respin it soon; it should be even more targeted now that https://review.opendev.org/c/openstack/swift/+/866239 has landed | 21:28 |
| timburke | that's all i've got | 21:29 |
| timburke | #topic open discussion | 21:29 |
| timburke | anything else we should bring up this week? | 21:29 |
| timburke | in that case, we'll wrap up early :-) | 21:31 |
| timburke | thank you all for coming, and thank you for working on swift! | 21:32 |
| timburke | #endmeeting | 21:32 |
| opendevmeet | Meeting ended Wed Dec 7 21:32:14 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:32 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-12-07-21.06.html | 21:32 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-12-07-21.06.txt | 21:32 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-12-07-21.06.log.html | 21:32 |
| mattoliver | hey indianwhocodes | 21:33 |
| indianwhocodes | i am late | 21:33 |
| mattoliver | thats ok, at least you made it :) | 21:33 |
| timburke | o/ | 21:34 |
| mattoliver | meetings are weekly around this time. or rather starting on the hour 30 mins ago 2100 UTC, 1pm your time I think | 21:34 |
| timburke | though it shifts in the summer :-) | 21:35 |
| mattoliver | but there are minutes if you ever miss one | 21:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!