Wednesday, 2022-05-25

*** timburke__ is now known as timburke20:59
timburke#startmeeting swift21:00
opendevmeetMeeting started Wed May 25 21:00:56 2022 UTC and is due to finish in 60 minutes.  The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot.21:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.21:00
opendevmeetThe meeting name has been set to 'swift'21:00
timburkewho's here for the swift meeting?21:01
ade_leeo/21:01
mattolivero/21:01
timburkeas usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift21:02
timburkeand as usual, i haven't updated it like i should have ;-)21:03
timburkefirst up21:03
timburke#topic gate failures21:03
timburkeour gate's busted!21:03
timburkebut https://review.opendev.org/c/openstack/swift/+/842817 should fix it21:03
timburketl;dr is that with openstack dropping py36 and py37 support for zed, we've got to maintain our own constraints file for the old versions again21:04
mattoliveroh thanks for dinning into hat21:04
mattoliver*that21:04
timburkesee also https://governance.openstack.org/tc/reference/runtimes/zed.html21:05
mattoliver*digging21:05
mattoliverwow, you can tell it's early here, I can't even type :P 21:05
timburkeand http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028611.html21:06
mattoliverok and centos stream 9 for zed, interesting21:06
timburkenow i just need to get the fix merged ;-)21:07
timburkeyeah, i started looking at getting a centos stream 9 job running somewhere... pyeclib or liberasurecode, maybe? but i don't think i actually got it passing21:08
timburkeah! sure enough, libec: https://review.opendev.org/c/openstack/liberasurecode/+/82096921:08
timburkelast run was a few months ago, though, and i don't remember what the failure mode was21:09
ade_leetimburke, its definitely worth re-running21:09
mattoliveryeah, just attempted to click on the output. 21:09
timburkeanyway, that's all i had about the gate: if your patches keep failing, don't freak out just yet ;-)21:10
timburkenext up21:10
timburke#topic sha1 deprecation21:10
mattolivercschwede-: has +2'ed the first in the chain21:11
timburkewe've got a bunch of patches we ought to land! ade_lee even managed to get cschwede to do some reviews, so it *must* be important ;-)21:11
mattoliverlol21:11
ade_leeand you got me to join this meeting too :)21:12
timburkeit's like whoa21:12
ade_leeso yeah - pretty please, this is the patch thats holding up a bunch of fips jobs across projects21:12
ade_lee(patches)21:12
timburkedo we know what the status is on the tempest dependency? https://review.opendev.org/c/openstack/tempest/+/83277121:13
mattoliver525771 also has a +2 in the second last patchset from pete.. so maybe we just land21:13
ade_leehuh - I actually didn't realize we had a tempest dependency ..21:14
timburkethe tempurl remove-sha1-from-defaults can't pass with tempest master21:15
ade_leeso -- we need to fix a few tests ..21:15
ade_leeor a few more tests ..21:15
ade_leealthough I guess that things pass right now with the tests that were fixed?21:16
ade_leetimburke, I haven't been following closely - but is there an issue in fixing the formpost tests?21:17
timburkein tempest? yeah, we've got a bit of a chicken-and-egg problem since swift currently *only* supports sha1 for formpost. can't move tempest to using sha256 for those until swift actually supports it21:19
ade_leebut mattoliver subsequent patch adds support for sha256 , right?21:19
ade_leehttps://review.opendev.org/c/openstack/swift/+/83843421:20
timburkeyup. and sha1 is still an allowed-by-default digest, which is as it should be21:20
timburkethere could absolutely be another patch written against tempest to switch the formpost tests to sha256. can't be part of https://review.opendev.org/c/openstack/tempest/+/832771, though, since it'll depend on mattoliver's patch, which eventually depends on 83277121:22
ade_leetimburke, ok -- so if I understand this -- to get the tempest patch in -- all we need to do is fix test_object_temp_url_negative.py as well.  21:22
ade_leeand yeah we defer the formpost stuff21:22
ade_leeto a different patch21:23
timburkei think so? seems right to me. unfortunately, i don't think i have much leverage on getting tempest code merged, though21:23
ade_leethen we need a second patch which fixes the tempest tests for formpost , which depends on mattoliver formpost patch?21:23
ade_leeack - I can talk to martin 21:24
ade_leeI just didn't realize there was still a tempest issue 21:24
timburkecool, thanks! and i'll work on getting my gate fixed and patches +A'ed21:24
timburke#topic ring v221:25
ade_leetimburke, for the formpost patches, presumably those can be merged without changes to tempest21:25
timburke#undo21:25
opendevmeetRemoving item from minutes: #topic ring v221:25
ade_leeand then we can do the tempest change to actually make sure its tested ..21:26
timburkeade_lee, well, except they depend on the tempurl patch (at least, as things currently stand)21:26
ade_leewell yeah - we're asuming that goes in21:26
ade_leeassuming21:26
ade_leefor the formtest changes -- I see there is something about optionally specifying the digest21:27
timburkeand that going in is dependent upon the tempest change to tempurl tests going in21:27
ade_leedoes that mean that when we set up the tempest tests for formpost +  sha256, we'll have to add some config?21:28
timburkedon't think so, but i haven't looked closely at mattoliver's patch since it got broken up. it's on my list for this week21:28
timburkeshould be able to just swap sha1 to sha256, similar to the tempurl tempest patch21:29
mattoliverif you use sha256 it'll detect that21:29
mattoliverno extra config21:29
ade_leecool - so plan is -- I'll fix up that addtional test, and talk to martin about merging tempest patch without formpost changes21:30
timburkethe follow-up should just give clients an option for another way to spell it21:30
ade_leethen we can merge all the swift patches21:30
ade_leeand then we can add extra patch to tempest to switch formpost tests21:30
timburkeyup! sounds right to me21:30
mattoliver+121:30
ade_leecool thanks!21:30
timburke#topic ring v221:31
timburkesorry, mattoliver, i still haven't gotten to following up on your review :-(21:32
mattolivernps, i mean it'll be good to get too, but you are saving our gate bacon :P 21:32
mattoliverI tried to address most the todos in the follow up. 21:33
timburkethanks for that -- though i think there's one part i won't be taking as-is21:33
timburke(around unrecognized digest algos)21:33
timburkelet's see... the memcache patches are mostly resolved now...21:34
timburke#topic eventlet, logging, and locking21:35
timburkemattoliver, am i remembering right that you were going to try this out in our staging environment?21:35
timburkei *know* we still haven't tried it out in prod yet21:35
mattoliverI was suppose to. But onboarding new devs got in the way. I know I said it last week, but I'll try generating a load and giving it whirl this week. 21:36
mattoliverSeems we have Als backend ratelimint in there 2.21:37
timburkesounds good -- just wanted to make sure i wasn't the one who'd committed to it ;-)21:37
mattoliverso load generation we might be able to do 2 birds one stone21:37
timburkeyup!21:37
mattoliverlol21:37
timburke#topic backend ratelimiting21:38
timburkewe're up to 2 +2s on https://review.opendev.org/c/openstack/swift/+/836046/ ! should we wait on the results of your testing before merging?21:38
timburkeor should i just blindly +A once we've got the gate passing again? ;-)21:39
mattolivergood question, in theory it can be turned off. But maybe work on the gate and hopefully by then we'll have some staging results21:40
timburkesounds good21:40
timburke#topic ptg21:41
timburkei almost forgot! they've set the dates for the next (in person!) PTG21:41
timburke#link http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028601.html21:41
mattoliver\o/21:42
timburkeOctober 17-20th, in Columbus, Ohio21:42
mattoliverIt'll be so awesome to meet up face to face with everyone again!21:43
timburkefor sure21:43
timburkei can hardly wait21:43
mattoliverI should confirm work will send me, then get my esta organised so I can enter the US :P 21:43
timburkethat's all i've got21:43
mattolivergot a few months :P 21:43
timburke#topic open discussion21:43
timburkeanything else we should bring up this week?21:43
mattoliverBeen playing with the next steps for not moving to Cleaved until we're ready. Hopefully have something up to review today or tomorrow21:45
timburkenice!21:45
mattolivercode just doesn't look right yet. OCD :P 21:45
timburkeoh yeah, and i should go re-review https://review.opendev.org/c/openstack/swift/+/84114321:46
mattoliveryeah, then we can land it21:46
mattoliverit's better then what we have now. And saved our bacon in prod. 21:46
mattoliverso think it's a win21:46
timburke👍21:47
timburkeall right, i'll let you get on with your morning, then21:47
timburkethanks for coming, and thanks for working on swift!21:47
timburke#endmeeting21:47
opendevmeetMeeting ended Wed May 25 21:47:35 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)21:47
opendevmeetMinutes:        https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.html21:47
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.txt21:47
opendevmeetLog:            https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.log.html21:47
opendevreviewMerged openstack/swift master: CI: constrain py36 deps  https://review.opendev.org/c/openstack/swift/+/84281723:29

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!