| opendevreview | Alistair Coles proposed openstack/swift master: Trim sensitive information in the logs (CVE-2017-8761) https://review.opendev.org/c/openstack/swift/+/822585 | 10:53 |
|---|---|---|
| *** cschwede- is now known as cschwede | 11:56 | |
| afaranha | hi timburke__, I'm having some issue on a patch to swift, it fails due to "The nodeset "centos-8-arm64" was not found.", this part was not touched by the patch, is this some issue currently on swift for Xena branch? https://review.opendev.org/c/openstack/swift/+/827901 | 14:34 |
| opendevreview | Alistair Coles proposed openstack/swift master: container-server: plumb includes down into _get_shard_range_rows https://review.opendev.org/c/openstack/swift/+/569847 | 15:30 |
| opendevreview | Tim Burke proposed openstack/swift stable/xena: Make arm jobs voting (but not the pipeline) https://review.opendev.org/c/openstack/swift/+/828584 | 16:21 |
| opendevreview | Tim Burke proposed openstack/swift stable/xena: Move CI from CentOS 8 to CentOS 8 Stream https://review.opendev.org/c/openstack/swift/+/828585 | 16:21 |
| timburke__ | afaranha, thanks for letting me know! i *think* those two should square it, though i probably need to squash them together | 16:21 |
| afaranha | timburke++ thanks! | 16:25 |
| afaranha | we'll backport that to wallaby as well, do we need to backport these patches as well? | 16:25 |
| opendevreview | Andre Aranha proposed openstack/swift stable/xena: Add FIPS CI jobs https://review.opendev.org/c/openstack/swift/+/827901 | 16:26 |
| timburke__ | shouldn't be -- the arm64 jobs started with https://github.com/openstack/swift/commit/41a3e1ff which is in xena but not wallaby | 16:29 |
| opendevreview | Tim Burke proposed openstack/swift stable/xena: Add FIPS CI jobs https://review.opendev.org/c/openstack/swift/+/827901 | 16:38 |
| opendevreview | Tim Burke proposed openstack/swift stable/xena: Fix arm64 jobs on stable/xena https://review.opendev.org/c/openstack/swift/+/828588 | 16:38 |
| opendevreview | Tim Burke proposed openstack/swift master: CI: fix lower-constraints job https://review.opendev.org/c/openstack/swift/+/828604 | 19:03 |
| timburke__ | almost meeting time! | 20:54 |
| *** timburke__ is now known as timburke | 20:54 | |
| kota | good morning | 20:57 |
| mattoliver | Morning | 20:58 |
| timburke | #startmeeting swift | 21:00 |
| opendevmeet | Meeting started Wed Feb 9 21:00:11 2022 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
| opendevmeet | The meeting name has been set to 'swift' | 21:00 |
| timburke | who's here for the swift meeting? | 21:00 |
| kota | o/ | 21:00 |
| acoles | o/ | 21:02 |
| timburke | as usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift | 21:03 |
| timburke | #topic PTG | 21:03 |
| timburke | first, a reminder to register | 21:03 |
| timburke | #link https://openinfra-ptg.eventbrite.com/ | 21:03 |
| timburke | the team sign-up instructions are also out | 21:03 |
| timburke | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027051.html | 21:04 |
| timburke | i'll put together a doodle poll by next week at the latest to help us select times | 21:04 |
| mattoliver | Sorry im here too, just getting distracted by parenting duties. | 21:04 |
| mattoliver | Kk | 21:04 |
| timburke | the last couple times, i had a time shift part-way through the week -- has that worked out OK for everyone, or would it be better to try to keep it consistent all week? or no real preference? | 21:05 |
| mattoliver | I guess I don't mind, however can't guarantee brain power at 2am 😜 | 21:06 |
| mattoliver | So it worked well for me. | 21:06 |
| acoles | split times seems fairer | 21:07 |
| timburke | 👍 | 21:08 |
| timburke | #topic summit | 21:08 |
| timburke | it's fast approaching! | 21:09 |
| timburke | i hadn't realized, but the call for presentations is closing soon! | 21:09 |
| timburke | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027129.html | 21:09 |
| timburke | #link https://cfp.openinfra.dev/app/berlin-2022 | 21:09 |
| timburke | if you've got ideas for swift talks, please get them submitted asap :-) | 21:10 |
| timburke | #topic election season | 21:11 |
| timburke | nominations are now open! | 21:11 |
| timburke | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027117.html | 21:11 |
| timburke | i'm happy to run for swift ptl again -- though i need to write up my statement :-) | 21:12 |
| mattoliver | +100 for swift ptl! So long as you ok with it :) | 21:12 |
| mattoliver | Tim for swift ptl | 21:13 |
| timburke | all right, i think that covers the general announcements... | 21:13 |
| mattoliver | Phone lost the Tim in thr first one | 21:13 |
| timburke | :-) | 21:13 |
| timburke | #topic 2.29.0 release | 21:13 |
| timburke | if you haven't already, i'd encourage everyone to read over the proposed change log | 21:14 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/826947 | 21:14 |
| timburke | there's a lot of great stuff in there! | 21:14 |
| acoles | timburke: run run run for ptl!! | 21:14 |
| timburke | there's still one more patch i'd like to land, and a couple more release notes, but i think i should be ready to tag later this week or early next week | 21:15 |
| timburke | speaking of the patch i'd like to land... | 21:17 |
| mattoliver | nice | 21:17 |
| timburke | #topic signatures in logs | 21:17 |
| timburke | the new registry module has landed | 21:17 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/825694 | 21:17 |
| mattoliver | oh cool! | 21:17 |
| timburke | and acoles has a +2 on the actual fix | 21:18 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/822585 | 21:18 |
| kota | registry, cool | 21:19 |
| mattoliver | Thanks for cleaning them up and pushing them across the line (or almost across for the last one). | 21:20 |
| timburke | acoles, i think you still had a few comments in test_proxy_logging -- is it safe to assume those could be addressed as a follow-up? | 21:20 |
| mattoliver | I like how in fixing the CVE we actually add a usful feature inside swift for devs. | 21:21 |
| kota | +1 | 21:21 |
| acoles | wait, I think I fixed those comments today but maybe I didn't push to gerrit :O | 21:22 |
| timburke | then i'll hold off on approving *right now* ;-) | 21:23 |
| timburke | fwiw, i was eyeing the "_sensitive_headers and _sensitive_params are not cleared at end of this test" comment in particular, though i think there was another case-sensitivity comment that looked un-addressed | 21:24 |
| timburke | hmm... i keep leaving "mpu expiration" on the agenda hoping that clayg will be around to give a quick run-down | 21:25 |
| mattoliver | its we can just skip it until he's here ;) | 21:25 |
| timburke | i had this memory that there were a bunch of patches, and it was tricky to see which arrow had the wood behind it... but maybe a bunch of them got abandoned? | 21:27 |
| timburke | i *think* this is the primary patch: | 21:27 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/800701 | 21:27 |
| timburke | at any rate, that's the one we're trying out in prod :P | 21:28 |
| timburke | well, anyway | 21:29 |
| timburke | #topic open discussion | 21:29 |
| timburke | what else should we bring up this week? | 21:29 |
| zaitcev | I'm bored with vPTG. | 21:29 |
| timburke | me too. not the same :( | 21:29 |
| mattoliver | who knows, could be the last virtual one | 21:30 |
| timburke | 🤞 | 21:30 |
| mattoliver | I've been playing with encoding the device into the container db ID. As this ID is recreated after any rsyc or rsync_then_move. | 21:31 |
| mattoliver | https://review.opendev.org/c/openstack/swift/+/828069 | 21:31 |
| mattoliver | Or rather adding it not really encoding it. | 21:31 |
| mattoliver | In an attempt to make it easier to debug replication issues because you can then go look at incoming/outgoing syncs and know where each id came from (at least at a particular timestamp). | 21:32 |
| timburke | oh yeah, i'd been meaning to take a look at that... | 21:32 |
| mattoliver | The db id is just text so shouldn't hurt. And the device is pulled from the broker path. | 21:33 |
| mattoliver | So long as you have unique device names across the cluster, this will allow you to do a lookup in your ring to know what node is syncing with a container. | 21:33 |
| mattoliver | This kinda came up when I was attempting to figure out which handoff was breaking / resetting the root epoch. But got the incoming_sync table and was a deadend. | 21:35 |
| timburke | do we make an explicit recommendation to have unique device names across the cluster? i know it's certainly the way *i'd* recommend, but i'm not sure if we've got that written down anywhere... | 21:35 |
| mattoliver | no we don't. But I could add some text to the doc to recommend it. | 21:36 |
| timburke | mattoliver, speaking of, have we seen that root epoch thing come up any more recently? if memory serves, there was some patch to at least detect the situation better... | 21:36 |
| acoles | timburke: re https://review.opendev.org/c/openstack/swift/+/822585, it's all good, I got confused by the gerrit comments, I think I did address my own concerns in patchset 12 | 21:36 |
| timburke | 👍 | 21:37 |
| mattoliver | I'd love to add something more, like device ID, but I can grab the device from the path for free as it all happens inside the broker classes. And anything else might involve having access to the ring. | 21:37 |
| timburke | *cough, cough* https://review.opendev.org/c/openstack/swift/+/670674 | 21:38 |
| timburke | ;-) | 21:38 |
| mattoliver | On another note, I have a "new" version of serialiaztion V2 based on the discussions from the last vPTG: https://review.opendev.org/c/openstack/swift/+/827276 | 21:38 |
| timburke | i ought to rebase that and try it out again | 21:39 |
| mattoliver | oh yeah. | 21:39 |
| mattoliver | that would change things :) | 21:39 |
| mattoliver | on the ring V2 ptg front, managed to get it to know behave in both Py2 and Py3 | 21:40 |
| timburke | \o/ | 21:40 |
| mattoliver | py2 has seeking backward issues. So turns out I just always seek forwards and now V2 will work for both versions. | 21:40 |
| timburke | thanks for pushing on that. i keep meaning to look at it again | 21:41 |
| mattoliver | nps | 21:41 |
| mattoliver | just wanted to get something up before the next PTG :P | 21:42 |
| acoles | I revived an old patch of timburke 's this week https://review.opendev.org/c/openstack/swift/+/569847 | 21:43 |
| acoles | it's a change to the way we lookup shard ranges in container backend | 21:43 |
| acoles | delegates more filtering to the sql query rather than python | 21:44 |
| acoles | turns out it makes a big difference to the lookup time i.e. faster | 21:45 |
| acoles | especially when there are larger numbers of shard ranges in the table (like, 1000's) | 21:45 |
| mattoliver | brilliant! | 21:46 |
| acoles | I benchmarked it with a copy of one of our production db's and it's 20x faster! | 21:47 |
| mattoliver | \o/ | 21:47 |
| mattoliver | doing it down in SQL land would be far more efficient. Nice. I wonder if there are other areas we could push things down to SQL land. | 21:47 |
| timburke | theeeee change itself is pretty targetted... i wonder if it's the sort of thing where it's worth running an experiment in prod... | 21:49 |
| timburke | all right | 21:50 |
| timburke | thank you all for coming, and thank you for working on swift! | 21:50 |
| timburke | #endmeeting | 21:50 |
| opendevmeet | Meeting ended Wed Feb 9 21:50:37 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:50 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-02-09-21.00.html | 21:50 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-02-09-21.00.txt | 21:50 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-02-09-21.00.log.html | 21:50 |
| opendevreview | Tim Burke proposed openstack/swift master: read-only: Only act on Swift paths https://review.opendev.org/c/openstack/swift/+/828612 | 22:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!