| mattoliverau | morning | 00:17 |
|---|---|---|
| *** diablo_rojo has joined #openstack-swift | 01:32 | |
| *** diablo_rojo has quit IRC | 01:47 | |
| seongsoocho | morning | 02:32 |
| *** mvkr has quit IRC | 03:15 | |
| *** psachin has joined #openstack-swift | 03:19 | |
| *** mvkr has joined #openstack-swift | 03:28 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-swift | 04:37 | |
| *** zaitcev has quit IRC | 05:22 | |
| AJaeger | morning, could I get a second +2 on https://review.opendev.org/717271 to update hacking for swift, please? | 06:20 |
| patchbot | patch 717271 - swift - Update hacking for Python3 - 5 patch sets | 06:20 |
| *** ccamacho has joined #openstack-swift | 06:34 | |
| *** rpittau|afk is now known as rpittau | 06:35 | |
| *** ccamacho has quit IRC | 06:46 | |
| *** ccamacho has joined #openstack-swift | 06:46 | |
| *** spsurya_ has joined #openstack-swift | 07:59 | |
| *** markguz_ has quit IRC | 08:40 | |
| *** rcernin has quit IRC | 09:03 | |
| *** camelCaser has quit IRC | 10:02 | |
| *** ccamel has joined #openstack-swift | 10:02 | |
| *** rcernin has joined #openstack-swift | 10:38 | |
| *** tkajinam has quit IRC | 10:59 | |
| *** tkajinam has joined #openstack-swift | 11:51 | |
| *** rcernin has quit IRC | 12:04 | |
| *** rcernin has joined #openstack-swift | 12:05 | |
| *** jv__ has quit IRC | 12:17 | |
| *** jv has joined #openstack-swift | 12:17 | |
| *** tkajinam has quit IRC | 12:18 | |
| mattia | hi guys | 12:20 |
| mattia | I guess those options are better left as they are.. | 12:21 |
| *** rcernin has quit IRC | 12:52 | |
| *** ccamacho has quit IRC | 13:25 | |
| *** ccamacho has joined #openstack-swift | 13:35 | |
| *** psachin has quit IRC | 14:43 | |
| *** manuvakery has joined #openstack-swift | 15:29 | |
| *** gyee has joined #openstack-swift | 15:38 | |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| *** diablo_rojo has joined #openstack-swift | 16:22 | |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-swift | 16:37 | |
| clayg | @AJaeger can you offer any clarity on W503 & W504 - they can't both be enabled by default can they? | 16:43 |
| AJaeger | clayg: correct, you need to choose whether you care and select one - or don't care and ignore both | 16:45 |
| AJaeger | clayg: I won't make that decision for you ;) | 16:46 |
| clayg | is there a default? | 16:46 |
| AJaeger | no | 16:46 |
| clayg | it looks like they're both enabled by default - ignoring both is definitely correct given the current lack of preference. | 16:46 |
| AJaeger | I looked at the code, and if you had a consistent style, I would have made the choice... | 16:47 |
| clayg | so a project can't effectively use hacking without ignoring one of those rules? Are you aware of any general preference across openstack? | 16:48 |
| AJaeger | clayg: that comes from flake8 which hacking uses. | 16:48 |
| AJaeger | clayg: no, I'm not aware of a preference across openstack | 16:48 |
| clayg | I guess it must have something to do with the default ignore list... if I remove ignore from the config I get lots of errors - but none for W503 or W504 🤔 | 16:57 |
| * clayg well at least we're in good company! from flake8.defaults | 16:58 | |
| clayg | IGNORE = ("E121", "E123", "E126", "E226", "E24", "E704", "W503", "W504") | 16:59 |
| AJaeger | clayg: exactly, if you remove it, ignore uses the default you cite above | 17:04 |
| AJaeger | clayg: so, to get all warnings, you need to set ignore to something like "ignore = _" ;) | 17:04 |
| clayg | @AJaeger but you can't do that! because you HAVE to ignore W503 or W504 or both!? | 17:05 |
| clayg | or just never have statements with operators that span lines maybe... | 17:05 |
| AJaeger | clayg: or write different python code that does not trigger either of them ;) | 17:05 |
| clayg | heh | 17:05 |
| AJaeger | you're slightly faster ;) | 17:05 |
| clayg | either way it's funny | 17:05 |
| clayg | thanks for the help with the linting updates! | 17:05 |
| AJaeger | indeed | 17:05 |
| AJaeger | you're welcome! Thanks for reviewing! | 17:05 |
| *** zaitcev has joined #openstack-swift | 17:51 | |
| *** ChanServ sets mode: +v zaitcev | 17:51 | |
| zaitcev | From: Tessa Plum <tessa@plum.ovh> | 18:03 |
| zaitcev | OVH TLD | 18:03 |
| rledisez | (just in case of any doubts, .ovh does not mean it comes from the company OVH. It comes from an OVH customer who bought a .ovh domain) | 18:08 |
| clayg | rledisez: 😍 | 18:29 |
| zaitcev | Yeah, I figured the "plum." part was indicative. | 18:32 |
| zaitcev | But I was very close to telling her "why don't you ask Romain" before I stopped myself. | 18:32 |
| clayg | rledisez: how do you roll out updates to log_msg_template? | 18:48 |
| clayg | rledisez: it seems like my proxies blow up if I add a field the current version of swift doesn't know about yet | 18:48 |
| clayg | rledisez: you just sort of... upgrade everyone and when you're sure for sure you don't have out-of-date node you change the template to have new fields like ttfb? | 18:48 |
| clayg | for me it seems like it be easier to just print a warning and replace it with a `-` and maybe even update our default to include awesome new stuff like ttfb on the end? | 18:49 |
| *** kukacz has quit IRC | 18:55 | |
| rledisez | clayg: yeah, we deploy features when we know they are available. sometime we check the version we are deploying in puppet to check if we should enable a feature or not | 18:55 |
| clayg | yeah, i'm writing code to do something similar now | 18:56 |
| clayg | I guess it's easier to notice your proxies aren't started than a warning in logs 🤷 | 18:56 |
| *** kukacz has joined #openstack-swift | 18:57 | |
| rledisez | exactly. we are able to get a nice view of exceptions occuring, but just a warning, we never check that | 18:58 |
| *** ccamacho has quit IRC | 20:15 | |
| timburke | rledisez, makes me wonder what we can do to improve the signal-to-noise ratio for warnings... | 20:37 |
| rledisez | timburke: my first step would be to remove everything that are out of control for the operator. I'm mostly thinking of messages like 'Client disconnected without sending enough data' | 21:34 |
| rledisez | it should be an info, not a warning | 21:34 |
| rledisez | there is many in the proxy-server | 21:34 |
| timburke | yeah, seems reasonable | 21:34 |
| *** rcernin has joined #openstack-swift | 22:30 | |
| *** tkajinam has joined #openstack-swift | 22:42 | |
| mattoliverau | morning | 23:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!