| notmyname | kota_: rledisez: alecuyer: FYI, https://review.openstack.org/#/c/635697/ | 00:14 |
|---|---|---|
| patchbot | patch 635697 - releases - create feature/losf branch in swift - 1 patch set | 00:14 |
| zaitcev | Argh... Went to hack on the proxy/controller/base.py, and its tests call base._get_shard_ranges. Everything needs the damn sharder. | 01:09 |
| openstackgerrit | Tim Burke proposed openstack/swift master: encryption: Stop being cutesy with os.path.join() https://review.openstack.org/635380 | 01:41 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Fix decryption for broken objects https://review.openstack.org/633671 | 01:59 |
| *** psachin has joined #openstack-swift | 02:51 | |
| *** gkadam has joined #openstack-swift | 03:18 | |
| openstackgerrit | Pete Zaitcev proposed openstack/swift master: py3: adapt proxy base controller https://review.openstack.org/635707 | 03:28 |
| *** gkadam_ has joined #openstack-swift | 03:28 | |
| *** gkadam has quit IRC | 03:31 | |
| *** ianychoi has quit IRC | 03:49 | |
| *** ianychoi has joined #openstack-swift | 03:55 | |
| *** gyee has quit IRC | 05:36 | |
| *** e0ne has joined #openstack-swift | 06:50 | |
| *** e0ne has quit IRC | 07:06 | |
| *** remi_ness has joined #openstack-swift | 07:15 | |
| *** pcaruana has joined #openstack-swift | 07:23 | |
| *** ccamacho has joined #openstack-swift | 08:00 | |
| *** takamatsu has joined #openstack-swift | 08:00 | |
| zigo | timburke: That's what our patch is about: it makes it possible to decrypt these objects. | 08:09 |
| zigo | My understanding is that we had a wrong pipeline, and that's what caused it. | 08:10 |
| *** tkajinam has quit IRC | 08:14 | |
| *** ianychoi has quit IRC | 08:50 | |
| *** e0ne has joined #openstack-swift | 09:20 | |
| *** cschwede has joined #openstack-swift | 10:00 | |
| *** ChanServ sets mode: +v cschwede | 10:00 | |
| *** remi_ness has quit IRC | 10:07 | |
| *** takamatsu_ has joined #openstack-swift | 11:20 | |
| *** takamatsu has quit IRC | 11:20 | |
| *** e0ne has quit IRC | 12:29 | |
| *** psachin has quit IRC | 13:03 | |
| *** mrjk has quit IRC | 13:08 | |
| *** mrjk has joined #openstack-swift | 13:10 | |
| *** e0ne has joined #openstack-swift | 13:17 | |
| *** ianychoi has joined #openstack-swift | 13:27 | |
| *** remi_ness has joined #openstack-swift | 15:27 | |
| *** pcaruana has quit IRC | 15:31 | |
| openstackgerrit | Clay Gerrard proposed openstack/swift master: Be more tolerant of success in test setup https://review.openstack.org/635864 | 15:35 |
| alecuyer | hah I was looking at that failure just now :) also searching for where the retry happens | 15:38 |
| clayg | alecuyer: yeah, very strange... it's like the proxy did it!? because the 201 and the 202 are both to the same device w/ the same trans-id!? | 15:46 |
| clayg | timburke: I can make tests more reliable on p 629056 if I rebase - but since you've been looking at it I don't want to throw you off? | 15:46 |
| patchbot | https://review.openstack.org/#/c/629056/ - swift - Rebuild frags for unmounted disks - 8 patch sets | 15:46 |
| clayg | slightly surprising but probably fine easy test fixup review -> https://review.openstack.org/#/c/635864/ | 15:49 |
| patchbot | patch 635864 - swift - Be more tolerant of success in test setup - 1 patch set | 15:49 |
| timburke | good morning | 16:11 |
| *** e0ne has quit IRC | 16:17 | |
| *** gyee has joined #openstack-swift | 16:38 | |
| notmyname | good morning | 17:27 |
| notmyname | kota_: rledisez: alecuyer: clayg: feature/losf has been created | 17:27 |
| notmyname | fungi: can you remind me where the config is that controls what branches the bot reports in irc? | 17:31 |
| *** gkadam_ has quit IRC | 17:32 | |
| notmyname | timburke: thanks for the boilerplate patches :-) | 17:32 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Stop using duplicate dev IDs in write_fake_ring https://review.openstack.org/635899 | 17:42 |
| *** remi_ness has quit IRC | 17:50 | |
| *** ccamacho has quit IRC | 17:50 | |
| clayg | timburke: that's a pretty weak ass ring... two devices.. | 17:51 |
| clayg | it's used a lot tho! | 17:51 |
| timburke | yeah... but it's what we were already doing... | 17:52 |
| timburke | when we set up the servers, we make like 12 or so "disks" -- i wouldn't be opposed to *actually* providing some handoffs... | 17:53 |
| timburke | but the 202 just *didn't make sense*... until i noticed the doubled up dev ids... which *still* doesn't make it make sense, but at least when i fixed that, the handoffs go away and things make *more* sense | 17:54 |
| fungi | notmyname: sorry, was lunching... i think you're looking for this? https://git.openstack.org/cgit/openstack-infra/project-config/tree/gerritbot/channels.yaml#n1938 | 17:56 |
| notmyname | fungi: yep, thanks. does that support wildcards? is there any way I can update that once to work with all feature/* branches in swift? | 17:57 |
| timburke | notmyname: looks like yes -- see openstack-telemetry | 17:58 |
| fungi | i believe it's regex now (as of not terribly long ago)... look just a ways down | 17:58 |
| timburke | ^feature/.* | 17:58 |
| fungi | right, that's the one i spotted | 17:58 |
| timburke | trove does stable branches, too | 17:58 |
| fungi | you could probably just do ^.* if you want all branches of those repos | 17:59 |
| timburke | yeah, i'm trying to think of why we *wouldn't* want that | 17:59 |
| fungi | (i would argue that should be the default behavior if the branches array were omitted, but i can't say that for sure without actually looking at the gerritbot docs/code) | 17:59 |
| timburke | ^.* *totally* seems like the way to go (at least, for us) | 17:59 |
| notmyname | fungi: the "alert on -2 review" feature is still not implemented, right? | 18:02 |
| notmyname | https://review.openstack.org/#/c/635905/ | 18:03 |
| patchbot | patch 635905 - openstack-infra/project-config - swift: gerritbot alert on all the branches - 1 patch set | 18:03 |
| timburke | clayg: i think i'm'a just go ahead and rebase p 629056 -- i haven't started really looking at the newest patchset anyway, and it should make gating better | 18:04 |
| patchbot | https://review.openstack.org/#/c/629056/ - swift - Rebuild frags for unmounted disks - 8 patch sets | 18:04 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Rebuild frags for unmounted disks https://review.openstack.org/629056 | 18:05 |
| fungi | notmyname: yeah, i'm at least not aware of anyone fixing that but will skim the commit log | 18:05 |
| notmyname | no worries. just saw that section and it triggered an old memory | 18:05 |
| clayg | timburke: sweet no worries - just didn't want to do it if you needed to look at the diff from last patch set 👍 | 18:06 |
| clayg | timburke: what you need me looking at? | 18:06 |
| fungi | yeah, not seeing anything at https://git.openstack.org/cgit/openstack-infra/gerritbot/log/ which would lead me to think we support it yet | 18:06 |
| timburke | clayg: p 621055 p 629301 p 628701 p 628292 would all be lovely | 18:11 |
| patchbot | https://review.openstack.org/#/c/621055/ - swift - s3api: Look for more indications of aws-chunked up... - 4 patch sets | 18:11 |
| patchbot | https://review.openstack.org/#/c/629301/ - swift - Verify client input for v4 signatures - 1 patch set | 18:11 |
| patchbot | https://review.openstack.org/#/c/628701/ - swift - s3api: Delete multipart uploads via multi-delete - 4 patch sets | 18:11 |
| patchbot | https://review.openstack.org/#/c/628292/ - swift - s3api: Block ETag header from CompleteMultipartUpl... - 1 patch set | 18:11 |
| timburke | i suppose my list is a little s3api-heavy... | 18:11 |
| clayg | 👍 | 18:12 |
| notmyname | timburke: clayg: tdasilva: kota_: rledisez: zaitcev: mattoliverau: I've been asked to update the one swift question on the openstack user survey. I propose the following on, but I would appreciate your feedback (specifically, did I miss something or choose a wrong item in the list?) | 18:12 |
| notmyname | https://etherpad.openstack.org/p/m06METHBW7 | 18:12 |
| timburke | that and the mess of encryption stuff... i think p 635380 and p 634507 are probably gtg -- p 633671 needs more tests for sure, but i think it's getting there... i really ought to write some tests for p 586903 -- it woulda been so handy while i was testing some of those | 18:15 |
| patchbot | https://review.openstack.org/#/c/635380/ - swift - encryption: Stop being cutesy with os.path.join() - 3 patch sets | 18:15 |
| patchbot | https://review.openstack.org/#/c/634507/ - swift - encryption: Be more tolerant of errors while decry... - 2 patch sets | 18:15 |
| patchbot | https://review.openstack.org/#/c/633671/ - swift - Fix decryption for broken objects - 7 patch sets | 18:15 |
| patchbot | https://review.openstack.org/#/c/586903/ - swift - Display crypto data/metadata details in swift-obje... - 4 patch sets | 18:15 |
| clayg | notmyname: symlinks! | 18:15 |
| clayg | and quotas... | 18:15 |
| zaitcev | Add CORS to static websites | 18:19 |
| timburke | bulk uploads/downloads (maybe as two separate items?) | 18:19 |
| zaitcev | Erasure coding? | 18:19 |
| timburke | versioning | 18:19 |
| zaitcev | No, it's the same module, which is a massive PITA | 18:19 |
| timburke | yeah, but just because they've enabled the module doesn't mean they're using both halves | 18:20 |
| zaitcev | Guys, wait. Why are we saying it here when it says "please add proposed changes below" | 18:20 |
| *** remi_ness has joined #openstack-swift | 18:20 | |
| timburke | (and by downloads, i meant deletes 😞) | 18:21 |
| zaitcev | ah, okay | 18:21 |
| timburke | good news is, we register them separately, so i *think* we could break them apart fairly painlessly... include an entrypoint with the old name that composes both, but also give the option to just have uploads or just have delete... | 18:23 |
| notmyname | thanks for the feedback on the question. great stuff! | 18:57 |
| *** jdewald has joined #openstack-swift | 19:00 | |
| timburke | tdasilva: with the multinode upgrade tests, is the test runner supposed to be on the *old* version? i wasn't expecting to hit the error around http://logs.openstack.org/56/629056/9/check/swift-multinode-rolling-upgrade/cb583ad/job-output.txt.gz#_2019-02-08_18_36_39_464807 since p 634456 landed... but then i noticed that the line doesn't match what's at that line number in that file on the patch's sha... | 19:07 |
| patchbot | https://review.openstack.org/#/c/634456/ - swift - func tests: Be willing to retry PUTs (MERGED) - 3 patch sets | 19:07 |
| tdasilva | timburke: correct, the test runner runs the old version | 19:10 |
| timburke | ok, cool. just making sure things are as we're expecting | 19:11 |
| tdasilva | and then in p 626663 we added a new test runner to run the latest code | 19:12 |
| patchbot | https://review.openstack.org/#/c/626663/ - swift - Add rolling upgrade tests - 4 patch sets | 19:12 |
| tdasilva | timburke: the reasoning for running old func tests being that we should expect to be able to upgrade a swift cluster without impact to client apps | 19:13 |
| timburke | yeah, yeah... i like it. just had to remember our reasoning :-) | 19:26 |
| clayg | timburke: can we backport changes that make tests more stable? | 20:01 |
| timburke | clayg: i'm in favor of it! still not going to help in all cases, though -- i think even if we tag a 2.20.1 on a stable branch, master will keep testing with 2.20.0 until we tag again on master (presumably, 2.21.0) | 20:02 |
| timburke | but like https://review.openstack.org/#/c/628280/ took six rechecks to actually get it merged! | 20:03 |
| patchbot | patch 628280 - swift (stable/rocky) - Use eventlet.patcher.original to get Python select... (MERGED) - 1 patch set | 20:03 |
| timburke | if we can make it less painful the next time we want to backport something, let's do it -- low risk (should be test-only, right?), moderate-to-high reward | 20:04 |
| *** e0ne has joined #openstack-swift | 20:29 | |
| clayg | tdasilva: do you have any idea how we might change the node_timeout to 20s for probe tests? | 20:39 |
| timburke | clayg: they use the configs from doc/saio as i recall... we could just update that while leaving the default configs alone... though i don't exactly love recommending different configs (particularly timeouts) for dev vs prod :-/ | 21:03 |
| timburke | func tests would get a little more interesting. i think we could poke the in-process func test loader, though? | 21:03 |
| *** e0ne has quit IRC | 21:06 | |
| *** e0ne has joined #openstack-swift | 21:11 | |
| *** e0ne has quit IRC | 21:24 | |
| *** remi_ness has quit IRC | 22:09 | |
| *** remi_ness has joined #openstack-swift | 22:26 | |
| *** remi_ness has quit IRC | 22:35 | |
| openstackgerrit | Merged openstack/swift master: s3api: Look for more indications of aws-chunked uploads https://review.openstack.org/621055 | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!