Wednesday, 2019-01-09

zaitcevSo, we can settle on representing both keys and values as native strings, it seems.00:00
*** rcernin has quit IRC00:07
timburkebut there *isn't* a native-string representation of b'\xff' under py3 :-( i think that commit message is saying we standardized on *bytes*, and if we happen to unpickle some unicode, we'll encode it to bytes00:07
timburkeor, we assume that people probably aren't stuffing non-utf8 metadata on objects, call the ability to do so a bug, and fix the bug00:08
*** rcernin has joined #openstack-swift00:09
timburkelooks like acoles first noticed this around http://eavesdrop.openstack.org/irclogs/%23openstack-swift/%23openstack-swift.2016-02-26.log.html#t2016-02-26T17:14:25 -- we were looking at it in the context of https://review.openstack.org/#/c/284822/ (which was a follow-up for https://review.openstack.org/#/c/282363/ )00:16
patchbotpatch 284822 - python-swiftclient - Fix test for redacting sensitive data in client.ht... (MERGED) - 3 patch sets00:16
patchbotpatch 282363 - python-swiftclient - Do not reveal auth token in swiftclient log messag... (MERGED) - 6 patch sets00:16
zaitcevit's fine, it's fine. I only need to make a decision on representation, and someone has done it for me already00:19
zaitcevhttps://github.com/openstack/swift/blob/2.20.0/swift/obj/diskfile.py#L15600:19
*** itlinux has joined #openstack-swift01:03
*** itlinux has quit IRC01:19
*** baojg has quit IRC01:24
*** itlinux has joined #openstack-swift02:11
*** itlinux has quit IRC02:13
*** psachin has joined #openstack-swift02:48
openstackgerritMerged openstack/swift master: Modify the description content  https://review.openstack.org/62365003:02
*** gyee has quit IRC03:10
kota_hello03:21
*** itlinux has joined #openstack-swift03:33
*** spsurya has joined #openstack-swift03:46
mattoliveraukota_: o/03:50
kota_mattoliverau: o/03:50
zaitcevAttributeError: 'tuple_iterator' object has no attribute 'next'03:56
zaitcevato chotto03:56
*** lifeless_ has joined #openstack-swift04:57
*** psachin has quit IRC05:02
*** joeljwright has quit IRC05:02
*** lifeless has quit IRC05:02
*** joeljwright has joined #openstack-swift05:03
*** ChanServ sets mode: +v joeljwright05:03
*** e0ne has joined #openstack-swift06:22
*** e0ne has quit IRC06:23
*** mikecmpbll has quit IRC06:36
*** mikecmpbll has joined #openstack-swift06:39
*** pcaruana has joined #openstack-swift07:06
*** e0ne has joined #openstack-swift07:18
*** e0ne has quit IRC07:22
*** rcernin has quit IRC07:26
*** e0ne has joined #openstack-swift07:47
*** itlinux has quit IRC07:48
*** mikecmpbll has quit IRC07:49
*** hseipp has joined #openstack-swift07:52
*** e0ne has quit IRC08:47
*** mikecmpbll has joined #openstack-swift08:52
*** mikecmpbll has quit IRC08:54
*** mikecmpbll has joined #openstack-swift09:13
*** ccamacho has joined #openstack-swift09:16
*** pavelkv has joined #openstack-swift09:59
pavelkvThanks @timburke for slow object expirator patch; we need it after Pike upgrade to resolve 450M objects today :-) because we PUT objects much faster than expirer deletes them10:03
pavelkvcan somebody ack me cherry-pick to Pike #629402 ?10:04
pavelkvhttps://review.openstack.org/#/c/629402/10:05
patchbotpatch 629402 - swift (stable/pike) - object-server can 409 in response to x-if-delete-at - 1 patch set10:05
*** e0ne has joined #openstack-swift10:21
*** e0ne has quit IRC12:30
*** ybunker has joined #openstack-swift12:52
*** e0ne has joined #openstack-swift13:24
*** ybunker has quit IRC15:56
*** ybunker has joined #openstack-swift15:57
*** ybunker has quit IRC16:01
*** ybunker has joined #openstack-swift16:02
*** pcaruana has quit IRC16:03
openstackgerritzhulingjie proposed openstack/swift master: Update hacking version  https://review.openstack.org/62851516:05
*** gyee has joined #openstack-swift16:18
*** e0ne has quit IRC17:03
*** itlinux has joined #openstack-swift17:05
openstackgerrit98k proposed openstack/python-swiftclient master: Add doc/requirements.txt to releasenotes tox environment  https://review.openstack.org/62957817:12
*** hseipp has quit IRC17:25
tdasilvatimburke: just trying to understand a bit more about s3api code, the reason for verifying the etag and size on a MPU upload is so that it can return a "s3" error message as opposed to an "slo" error message, correct. Ultimately slo does the verification for of the manifest anyway...this is re. p 61074717:27
patchbothttps://review.openstack.org/#/c/610747/ - swift - s3api: Stop relying on container listings during m... - 9 patch sets17:27
tdasilvas/correct./correct?17:27
*** mikecmpbll has quit IRC17:30
*** mikecmpbll has joined #openstack-swift17:43
openstackgerritMerged openstack/swift master: Add slo_manifest_hook callback  https://review.openstack.org/60986017:56
openstackgerritPete Zaitcev proposed openstack/swift master: WIP py3: object server  https://review.openstack.org/62961018:03
*** zaitcev has quit IRC18:05
timburkezaitcev: oh jeeze... we do .next() all over the place in tests, don't we...18:25
timburketdasilva: yeah, more or less. there's some historical context going on, too, though. it used to be that SLO required that you specify all of path, etag, and size_bytes in the manifest. swift3 could generate the path from the part number and upload id, and etag is provided by the client, but it still needed size_bytes or SLO would reject the manifest18:32
timburkefollowing https://review.openstack.org/#/c/184479/ etag and size_bytes became optional (and following https://review.openstack.org/#/c/391090/ you could omit them completely), but swift3 still had to work with old swift, so it did a container listing to get all the sizes18:32
patchbotpatch 184479 - swift - Allow SLO PUTs to forgo per-segment integrity checks (MERGED) - 6 patch sets18:32
patchbotpatch 391090 - swift - SLO: Make etag and size_bytes fully optional (MERGED) - 6 patch sets18:32
timburkeas long as it had the listing in hand, it could check etag, too, and avoid all the HEADs18:32
*** e0ne has joined #openstack-swift18:35
*** itlinux has quit IRC18:36
*** itlinux has joined #openstack-swift18:38
*** e0ne has quit IRC19:02
*** e0ne has joined #openstack-swift19:05
*** ybunker has quit IRC19:43
*** e0ne has quit IRC20:08
cwrightHi everyone, I've had a situation where account quotas stopped getting updated. Container counts continued to be updated quickly.20:35
cwrightI restarted all services, and the quotas began updating again.  All processes were still running before the restart.20:35
cwrightFrom what I've read, the container-updater is responsible for updating account bytes used. Is there any explanation for it to have stopped updating?20:35
cwrightby "quotas began updating again", I mean "bytes-used" started getting updated again20:36
openstackgerritTim Burke proposed openstack/swift master: slo_manifest_hook follow-up  https://review.openstack.org/62965920:40
timburkecwright: sounds like https://bugs.launchpad.net/swift/+bug/172295120:45
openstackLaunchpad bug 1722951 in swift (Ubuntu) "Container updater may be stuck and not make progress" [Undecided,New]20:45
timburkeshould be fixed with https://github.com/openstack/swift/commit/dc8da5b20:47
mattoliveraumorning20:56
kota_morning20:57
notmynamehello mattoliverau and kota_20:58
notmynamemattoliverau: kota_: timburke: rledisez: clayg: tdasilva: zaitcev: swift team meeting in 2 minutes in #openstack-meeting20:59
notmynameof course, anyone else is welcome too :-)21:00
*** m_kazuhiro has joined #openstack-swift21:01
cwrighttimburke: thanks for the link to that bug, it does sound like what I'm experiencing21:23
timburkegood news is that it's fixed in newer swift, and even backported to affected stable branches. bad news is that we haven't had new tags on the stable branches in a while, but i think notmyname is planning on fixing that soon :-)21:25
notmyname...soon...21:26
openstackgerritTim Burke proposed openstack/swift master: WIP py3: object server  https://review.openstack.org/62961021:27
tdasilvamattoliverau: I think we even documented that behavior: https://github.com/openstack/swift/blob/master/swift/common/middleware/versioned_writes.py#L107,L11121:48
mattoliverauYeah, that's why I added it was known in the bugm21:50
mattoliverauBut figured it was still a problem21:50
mattoliverauAnd now that we have a warning people want to remove it21:50
claygrledisez: the main issue I have with ssync is that it tries to act like it's http-ish - which is broken for streaming requests when an expect-100 continue returns an error21:55
claygPUT content-length: X (w/ expect: 100-contineu); get_expect -> 409 => HTTP IS BROKEN21:56
claygbecause the server HAS to get those X bytes before it can handle another request21:56
rledisezclayg: yeah, ok, you're right, i'm not fixing that for now :D21:57
claygssync is weird in that it has some "failure count" non-sense in there, because we don't get many failures in the final status *after* we send the bytes21:57
claygeven the whole "here's all the objects i have tell me what you want" is so stupid!  if we could do errors the conversation would be "you want this one?  nope.  This one?  sure.  This one?  nah. ..."21:57
claygi don't much care for ssync21:58
clayglet's just get get in gRPC and then rewrite the protocol21:58
*** m_kazuhiro has quit IRC21:59
rledisezi'm working on ssync because it's here, and it (finally) works, it's not perfect, but it can be improved a lot with few simple patches. gRPC is a long term goal IMHO, SSYNC is the quick win. I take every win I can :)22:00
clayg👍22:05
*** ccamacho has quit IRC22:08
*** ccamacho has joined #openstack-swift22:27
*** ccamacho has quit IRC22:28
*** rcernin has joined #openstack-swift22:52
*** pavelkv has quit IRC22:59
openstackgerritTim Burke proposed openstack/swift master: slo_manifest_hook follow-up  https://review.openstack.org/62965923:03
*** itlinux has quit IRC23:06
openstackgerritClay Gerrard proposed openstack/swift master: wip: rebuild frags for unmounted disks  https://review.openstack.org/62905623:12

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!