Tuesday, 2018-07-24

*** gyee has quit IRC00:03
*** itlinux has quit IRC00:13
*** threestrands has quit IRC00:38
notmynameI worked with timur on a couple of swiftclient patches today. they're both in the gate now. I'll update the authors/changelog patch, and then do the tag request00:51
*** rcernin_ has joined #openstack-swift00:56
*** rcernin has quit IRC00:58
openstackgerritJohn Dickinson proposed openstack/python-swiftclient master: authors/changelog update for next release  https://review.openstack.org/58408100:59
timuryay!01:02
timurthanks notmyname!01:02
*** links has joined #openstack-swift01:17
*** ^andrea^ has quit IRC01:27
mattoliveraunice02:02
*** armaan has quit IRC02:19
*** armaan has joined #openstack-swift02:20
ktsuyuzakigood morning02:27
ktsuyuzakiI'm back from long summer vacation02:28
ktsuyuzakiand it seems like i missed my nick at my irc client?02:28
ktsuyuzakilet me check...02:28
*** ktsuyuzaki is now known as kota_02:28
kota_hello, testing.02:28
kota_it looks to work.02:28
*** psachin` has joined #openstack-swift02:50
mattoliveraukota_: welcome back03:13
*** ukaynar_ has joined #openstack-swift03:23
*** ukaynar_ has quit IRC03:29
*** ukaynar_ has joined #openstack-swift03:29
*** ukaynar_ has quit IRC03:30
*** ukaynar_ has joined #openstack-swift03:30
*** ukaynar_ has quit IRC03:35
kota_mattoliverau: o/03:41
openstackgerritMerged openstack/python-swiftclient master: Add close() to _RetryBody.  https://review.openstack.org/54990103:48
*** armaan has quit IRC04:15
*** psachin` has quit IRC04:15
*** armaan has joined #openstack-swift04:18
*** psachin` has joined #openstack-swift04:19
*** mahatic has quit IRC04:23
*** itlinux has joined #openstack-swift04:28
*** mahatic has joined #openstack-swift04:28
*** kei_yama has quit IRC04:43
*** armaan has quit IRC05:05
*** armaan has joined #openstack-swift05:06
*** drewn3ss has quit IRC05:07
*** armaan has quit IRC05:09
*** armaan has joined #openstack-swift05:10
*** itlinux has quit IRC05:30
*** viks_ has joined #openstack-swift05:30
*** cshastri has joined #openstack-swift05:31
*** armaan has quit IRC05:43
*** armaan has joined #openstack-swift05:44
*** ccamacho has joined #openstack-swift05:44
*** drewn3ss has joined #openstack-swift05:53
timburke_notmyname: idk where you are in the swiftclient tagging yet, but i think https://review.openstack.org/#/c/568914/ might still be worth considering06:15
patchbotpatch 568914 - python-swiftclient - Back out some version bumps06:15
*** armaan_ has joined #openstack-swift06:26
timburke_cleaning up and landing https://review.openstack.org/#/c/581921/ might also be nice. seems like an easy win (that may also generate some good will with -infra)06:28
patchbotpatch 581921 - python-swiftclient - Log exceptions received during retrying06:29
*** armaan has quit IRC06:29
*** pcaruana has joined #openstack-swift06:34
mattoliverautimburke_: do it!06:35
timburke_mattoliverau: i might need to sleep first ;-)06:35
mattoliveraupfft :P06:35
timburke_just got back from a trip, trying to catch up a little before bed06:35
mattoliverauWe appreciate that, I've been meaning to review a bunch today, but a work thing that was only suppose to take the morning has taken over my day. But on the plus side I've now pushed 2 monasca swift check plugins. So not completely wasted time ;)06:39
timburke_yay!06:40
mattoliveraufor more reference: https://oliver.net.au/?p=35806:45
mattoliverauThough I'm sure SwiftStack already have much better monitoring/metrics. but hopefully this will open the doors for others :)06:46
openstackgerritMerged openstack/python-swiftclient master: Properly handle unicode headers.  https://review.openstack.org/56205906:52
*** tesseract has joined #openstack-swift07:18
kota_mattoliverau: nice work on the monasca plugins07:34
*** neonpastor has joined #openstack-swift07:36
mattoliverauta :)07:41
*** rcernin_ has quit IRC07:56
*** geaaru has joined #openstack-swift08:07
*** rcernin_ has joined #openstack-swift08:09
*** gkadam has joined #openstack-swift08:13
*** armaan_ has quit IRC08:34
*** armaan has joined #openstack-swift08:34
*** kei_yama has joined #openstack-swift08:50
*** armaan has quit IRC09:07
*** armaan has joined #openstack-swift09:08
*** kei_yama has quit IRC10:14
*** mvk_ has quit IRC10:23
*** rcernin_ has quit IRC10:52
*** mvk_ has joined #openstack-swift10:53
*** mvk_ has quit IRC11:33
*** stephen_m has joined #openstack-swift11:38
*** mvk_ has joined #openstack-swift11:47
openstackgerritAlexander Bolshakov proposed openstack/python-swiftclient master: Fix update when PUT on containers not allowed  https://review.openstack.org/58532511:51
*** linkmark has joined #openstack-swift11:54
*** mikecmpbll has joined #openstack-swift12:00
*** armaan has quit IRC12:26
*** armaan has joined #openstack-swift12:26
*** psachin` has quit IRC12:30
*** mikecmpbll has quit IRC12:38
*** mikecmpbll has joined #openstack-swift12:46
*** ianychoi has quit IRC13:08
*** ianychoi has joined #openstack-swift13:08
*** ccamacho1 has joined #openstack-swift13:43
*** ccamacho has quit IRC13:43
*** neonpastor has quit IRC13:58
*** links has quit IRC14:31
*** armaan has quit IRC14:37
*** armaan has joined #openstack-swift14:38
timburke_notmyname: we really ought to land https://review.openstack.org/#/c/541817/14:43
patchbotpatch 541817 - swift (stable/queens) - Update UPPER_CONSTRAINTS_FILE for stable/queens14:43
timburke_also, if you wanted https://review.openstack.org/#/c/568470/ to land, it'll need a +2 vote14:45
patchbotpatch 568470 - swift (stable/queens) - Deprecate auth_uri option14:45
*** stephen_m has quit IRC14:47
*** stephen_m has joined #openstack-swift14:50
*** stephen_m has quit IRC14:50
notmynametimburke_: welcome back :-)14:54
timburke_NOW GO MERGE THINGS!14:54
timburke_;-)14:54
notmynameTHINGS ARE LANDING NOW!14:57
timburke_yay!14:58
timburke_ty14:58
timburke_oh yeah, and someone besides me probably ought to look at https://review.openstack.org/#/c/578075/ -- otherwise i'll get antsy and just land it anyway14:59
patchbotpatch 578075 - swift - Add keymaster to fetch root secret from KMIP service14:59
notmynametimburke_: any reson not to land the authors/changelog for swiftclient? I'd like to get that started in the gate asap. but you mentioned a couple of things on patch 562059 that may need to be conidered15:01
patchbothttps://review.openstack.org/#/c/562059/ - python-swiftclient - Properly handle unicode headers. (MERGED)15:01
notmynametimburke_: you're clearly still on eastern time zone ;-)15:01
timburke_i clearly don't have a kid to get to daycare :P15:01
notmynamelol15:02
timburke_*shrug* i don't think those are blockers, but i'll try to get a patch up to address the latter two comments today15:03
*** cshastri has quit IRC15:03
timburke_want me to give the a/cl patch a once over?15:03
timburke_oh! right! the dep bumps. that patch *is* viable now -- but if we do a release, i'll probably just abandon it15:04
timburke_https://review.openstack.org/#/c/568914/15:04
patchbotpatch 568914 - python-swiftclient - Back out some version bumps15:04
notmynametimburke_: may be better to look at https://review.openstack.org/#/c/585325/ instead of the a/cl one, if you have to choose (although a/cl is very short)15:04
patchbotpatch 585325 - python-swiftclient - Fix update when PUT on containers not allowed15:04
*** rcernin_ has joined #openstack-swift15:05
notmynamehowever, that one doesn't seem to have tests...15:05
timburke_yeah, i'd taken a brief look... might be better handled in shell.py... i'll see how ugly that gets15:05
notmynameok, I gotta pull myself away. YOU CAN'T GET ME SUCKED INTO EVERYTHING RIGHT NOW, timburke_!15:05
notmynamei need to get ready and go to the office, then I can get pulled into outstanding patches and stuff :-)15:06
timburke_or maybe we could just override success for those responses? i'm just nervous about dropping responses on the floor instead of passing them back to the caller...15:06
*** ccamacho1 has quit IRC15:18
*** rcernin_ has quit IRC15:30
*** pcaruana has quit IRC15:32
*** gyee has joined #openstack-swift15:37
*** itlinux has joined #openstack-swift15:49
*** ccamacho has joined #openstack-swift16:24
*** ccamacho has quit IRC16:25
*** ccamacho has joined #openstack-swift16:25
notmynamegood morning again. this time for real16:34
openstackgerritJohn Dickinson proposed openstack/python-swiftclient master: authors/changelog update for 3.6.0  https://review.openstack.org/58408116:41
*** mikecmpbll has quit IRC16:41
notmynametimburke_: ^16:43
*** mikecmpbll has joined #openstack-swift17:03
*** itlinux_ has joined #openstack-swift17:07
timburke_ugh, i gotta get https://review.openstack.org/#/c/577874/ into shape... took longer than i'd like to admit to figure out that the 500s i'm seeing are the result of some leftover test data while reviewing that17:08
patchbotpatch 577874 - swift - Add support for multiple root encryption secrets17:08
*** itlinux has quit IRC17:09
*** mvk_ has quit IRC17:09
timurtimburke_: I'll try to look into the keystone interaction that you mentioned. Unless you're way ahead of me on that already17:13
timburke_haven't actually started on that follow-up patch yet; thanks for looking at it17:14
*** tesseract has quit IRC17:17
*** ccamacho has quit IRC17:20
*** armaan has quit IRC17:25
*** itlinux_ has quit IRC17:42
*** itlinux has joined #openstack-swift17:42
*** mvk_ has joined #openstack-swift17:50
itlinuxhi guys, what's the best way to set a project quota on swift17:50
itlinuxI remember there is some changes I need to make17:50
notmynameitlinux: what sort of quota are you looking for? bytes used? objects used? requests?17:50
itlinuxand since I have not made some changes to swift for at least a year.. I want to make sure that I do have a quota set to bytes..17:51
itlinuxnot opbject17:51
itlinuxjust want to make sure they do not go over the disk usage allocatated to that project17:52
notmynameis a project mapped to a single swift account?17:52
itlinuxno I have several accounts on a project17:52
notmynameah17:53
itlinuxthis is on LDAP and using groups for the projects17:53
notmynameyou can set a soft max bytes quota on an account. but you can't do something like "allow a total of XXX bytes on these N accounts"17:54
notmynamethat would require running your own utilization reports and then attaching it to the auth system to reject access for write reuqests17:54
itlinuxahh ok.. how is the soft quota set?17:54
notmynamehttps://docs.openstack.org/swift/latest/middleware.html#module-swift.common.middleware.account_quotas17:55
itlinuxok thanks notmyname:17:55
notmynameit references some info included in https://docs.openstack.org/swift/latest/middleware.html#module-swift.common.middleware.container_quotas too17:55
itlinuxok.. looks like the quota there is account is per user?17:56
itlinuxuhm.. or account is project?17:56
notmynamethere is a swift account (a place where you put stuff, like a bank account). a project is an auth thing that can be mapped to swift accounts). and a user is a thing that has access to particular resources17:57
itlinuxok I will dig into that..17:57
notmynamein swift, you can set quotas on either the swift account or a container in a swift account17:58
itlinuxwhich means that the tenant can create new containers..17:58
itlinuxI am not sure I want them to do that more than x number so that the total will be xMB17:59
itlinuxis there a way to set max number of containers they can create?18:00
notmynameno. but you can limit the max number of containers in an account at the cluster level. but not per account18:05
notmynamecould be an interesting thing to add to the account quota middleware, though18:06
*** geaaru has quit IRC18:09
timurtimburke_: while trying to setup keystone to test these swiftclient changes, it appears that the openstack client doesn't handle non-ASCII characters in projects names correctly when trying to create a user for such a project... grrr18:12
timburke_that seems... utterly unsurprising.18:13
*** timburke_ is now known as timburke18:14
timburkeso this is kinda weird: i'm seeing some unit test failures locally on stable/queens and stable/pike18:14
timburkefrom queens: http://paste.openstack.org/show/726545/18:15
timburkeand pike: http://paste.openstack.org/show/726546/18:16
*** gkadam has quit IRC18:17
timburkefor the socket error, i guess i oughta backport https://review.openstack.org/#/c/577313/ -- apparently bionic's py27 includes https://github.com/python/cpython/commit/3ef3bcb18:27
patchbotpatch 577313 - swift - py36: Fix test_get_logger_sysloghandler_plumbing (MERGED)18:27
notmynametimur: instead of doing more of the keystone checking (if existing tools don't let us set up the unicode accounts), we could instead leave it until we get a bug report about it18:30
timburkehuh. the proposal bot seems to be down. or just can't get the feed of proposals18:33
timburkep 585506 p 585507 p 58550818:34
patchbothttps://review.openstack.org/#/c/585506/ - swift (stable/queens) - py36: Fix test_get_logger_sysloghandler_plumbing18:34
patchbothttps://review.openstack.org/#/c/585507/ - swift (stable/pike) - Clean up a couple hand-rolled mocks.18:34
patchbothttps://review.openstack.org/#/c/585508/ - swift (stable/pike) - py36: Fix test_get_logger_sysloghandler_plumbing18:34
timurnotmyname: well, turns out I can't use openstack client to add a user with a non-ASCII name to the admin role so I can actually test this. I'll address timburke's suggestion of applying this fix only for v1 Auth and punt on keystone18:37
notmynametimur: ok18:37
timurerr, "I can't test this" is what I meant to say18:37
timurI did learn how to setup keystone so it's not all wasted effort :)18:37
timburketimur: fwiw, i still use https://github.com/openstack/swift3/blob/master/swift3/test/functional/setup_keystone as my how-to-keystone reference...18:39
timurtimburke: thanks for the pointer! I found this: https://wiki.openstack.org/wiki/Swift/DevstackSetupForKeystoneV318:42
*** itlinux has quit IRC18:54
timurtimburke: actually, we don't even need to call parse_header_string() at all, because getheader() is the thing that we fixed! I somehow missed that entirely before18:54
timburkeeven better!18:55
openstackgerritTimur Alperovich proposed openstack/python-swiftclient master: Remove unnecessary calls to parse_header_string().  https://review.openstack.org/58551518:55
timurnotmyname timburke ^^^ that's the fixup. I only needed to remove some of the existing calls. Tests passed and I did some functional testing of non-ASCII account names with v1 auth... and gave up on keystone v318:56
*** armaan has joined #openstack-swift18:57
*** itlinux has joined #openstack-swift19:02
*** itlinux has quit IRC19:03
timburketimur: i'm starting to wonder how much (if at all) we really need to have parse_header_string now...19:05
timurgood question! I don't want this patch to get any bigger, though19:05
timurI think the two spots you found can be removed, though19:06
timburkefair enough19:06
timurmaybe a follow on change after notmyname makes the release?19:07
openstackgerritMerged openstack/swift master: py3: fix up some NameErrors  https://review.openstack.org/57047819:22
*** armaan has quit IRC19:24
*** armaan has joined #openstack-swift19:25
*** armaan has quit IRC19:29
*** itlinux has joined #openstack-swift19:58
notmynametimburke: what are your thoughts on https://review.openstack.org/#/c/585515/? should I keep waiting on a release for it?20:10
patchbotpatch 585515 - python-swiftclient - Remove unnecessary calls to parse_header_string().20:10
timburkeseems better than what we've got now, and pretty close to what we had before. might still be able to take out more calls to parse_header_string20:13
timburkebut in general, it shouldn't really be much of an issue following https://review.openstack.org/#/c/571904/ *anyway*... auth tokens and storage urls shouldn't really have non-ascii data...20:14
patchbotpatch 571904 - swift - tempauth: Send back url-encoded account names (MERGED)20:14
timburkecalling parse_header_string too many times will definitely cause problems... if you've got a (quoted) url with a %2525 in it, we need to get to *exactly* '%25' and not double-unquote to just '%'...20:17
*** rcernin_ has joined #openstack-swift20:18
*** d0ugal has quit IRC20:44
timuragreed. timburke do we have tests for the quoting behavior?21:07
timurif it's broken right now, none of the tests catch this :\21:07
*** rcernin_ has quit IRC21:30
*** patchbot has quit IRC21:32
*** patchbot has joined #openstack-swift21:33
*** patchbot has quit IRC21:35
*** patchbot has joined #openstack-swift21:35
*** itlinux has quit IRC21:38
*** mikecmpbll has quit IRC22:03
notmynamedid anyone follow up with the probetests fail on master question that came up a week or so ago?22:04
*** rcernin has joined #openstack-swift22:30
timburkei'm gonna go out on a limb here and say that despite installing ipaddress 1.0.22 (see http://logs.openstack.org/11/427911/32/check/swift-probetests-centos-7/fef8d27/job-output.txt.gz#_2018-07-18_22_53_35_967709) we're still getting system-installed ipaddress 1.0.1622:48
timburkeso, most likely introduced with https://review.openstack.org/#/c/569404/ (sorry, that was on my watch)22:48
patchbotpatch 569404 - swift - IP Range restrictions in temp urls (MERGED)22:48
timburkebut i'm pretty sure we're fine to lower the required version22:49
openstackgerritTim Burke proposed openstack/swift master: Lower the required version of ipaddress  https://review.openstack.org/58556822:51
*** kei_yama has joined #openstack-swift23:11
openstackgerritMerged openstack/python-swiftclient master: Back out some version bumps  https://review.openstack.org/56891423:12
mattoliveraumorning23:14
openstackgerritMerged openstack/python-swiftclient master: authors/changelog update for 3.6.0  https://review.openstack.org/58408123:27
*** linkmark has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!