Tuesday, 2018-05-22

openstackgerritMerged openstack/swift master: Use sets instead of dicts when we only care about the keys  https://review.openstack.org/56986100:05
*** gyee has quit IRC00:17
*** mikecmpbll has quit IRC00:25
openstackgerritTim Burke proposed openstack/swift master: Prevent IndexError on bad fragment index  https://review.openstack.org/56989700:35
*** itlinux has joined #openstack-swift00:41
*** itlinux has quit IRC00:45
notmynamejust finished my presentation slides for the "state of the project" talk. there's a lot going on in swift, a lot going on around swift, and a lot to keep us very busy for a long time. it's all pretty exciting01:08
*** amandap has joined #openstack-swift01:12
*** psachin has joined #openstack-swift01:50
*** zhongjun_ has joined #openstack-swift01:53
*** armaan has quit IRC02:06
*** armaan has joined #openstack-swift02:07
openstackgerritMerged openstack/swift master: Fix probe tests in the gate  https://review.openstack.org/56988202:22
*** itlinux has joined #openstack-swift03:08
*** itlinux has quit IRC03:12
mattoliveraunotmyname: I saw romain and m_kazuhiro here too03:16
*** cshastri has joined #openstack-swift03:28
hugokuomorning !03:33
hugokuoSince the deep container is under developing. I wonder if there's an existing tool for benchmarking SqliteDB for container DB so far?03:34
hugokuoIt seems like the sqlite DB can only handle lower than 200 concurrent update with 10secs lock timeout.03:35
hugokuoWhile the DB is located on SSD.03:35
*** _alastor_ has quit IRC03:55
*** threestrands has quit IRC04:02
*** links has joined #openstack-swift04:06
*** l4yerffej has quit IRC04:17
*** pcaruana has joined #openstack-swift04:44
*** spsurya has joined #openstack-swift04:45
*** amandap_ has joined #openstack-swift04:49
*** amandap has quit IRC04:52
*** pcaruana has quit IRC05:03
*** amandap_ has quit IRC05:05
*** ccamacho has quit IRC05:07
*** amandap has joined #openstack-swift05:23
*** amandap has joined #openstack-swift05:23
*** cshastri has quit IRC05:38
*** ccamacho has joined #openstack-swift05:51
*** links has quit IRC06:08
*** cshastri has joined #openstack-swift06:17
*** links has joined #openstack-swift06:25
*** cshastri has quit IRC06:28
*** cshastri has joined #openstack-swift06:31
*** armaan has quit IRC06:42
*** armaan has joined #openstack-swift06:43
*** pcaruana has joined #openstack-swift06:46
*** lifeless has quit IRC06:47
*** neonpastor has quit IRC07:00
*** ccamacho has quit IRC07:00
*** ccamacho has joined #openstack-swift07:00
*** neonpastor has joined #openstack-swift07:01
*** rcernin has quit IRC07:03
*** armaan has quit IRC07:04
*** mikecmpbll has joined #openstack-swift07:05
*** armaan has joined #openstack-swift07:13
*** lifeless has joined #openstack-swift07:15
*** armaan has quit IRC07:15
*** tesseract has joined #openstack-swift07:22
*** hseipp has joined #openstack-swift07:31
*** mikecmpb_ has joined #openstack-swift07:56
*** links has quit IRC07:58
*** mikecmpbll has quit IRC07:58
*** geaaru has joined #openstack-swift08:00
*** cbartz has joined #openstack-swift08:04
*** threestrands has joined #openstack-swift08:11
*** links has joined #openstack-swift08:11
*** hugokuo has quit IRC08:17
*** hugokuo has joined #openstack-swift08:20
*** threestrands has quit IRC08:46
openstackgerritAlistair Coles proposed openstack/swift master: Improve building listings from shards  https://review.openstack.org/56979608:52
openstackgerritAlistair Coles proposed openstack/swift master: Check for unexpected shard ranges when building sharded listings  https://review.openstack.org/56994208:52
*** NM has joined #openstack-swift09:03
*** armaan has joined #openstack-swift09:24
*** NM1 has joined #openstack-swift09:35
*** armaan has quit IRC09:35
*** NM has quit IRC09:37
*** armaan has joined #openstack-swift09:39
openstackgerritAlistair Coles proposed openstack/swift master: Reclaim expired cleaving context metadata  https://review.openstack.org/56983210:20
*** mikecmpb_ has quit IRC10:21
*** mikecmpbll has joined #openstack-swift10:22
*** silor has joined #openstack-swift10:27
*** amandap has quit IRC10:38
*** NM1 has quit IRC10:40
*** NM has joined #openstack-swift10:40
*** NM has quit IRC10:44
*** pcaruana has quit IRC10:53
*** pcaruana has joined #openstack-swift11:09
*** SkyRocknRoll has joined #openstack-swift11:09
*** SkyRocknRoll has joined #openstack-swift11:09
openstackgerritAlistair Coles proposed openstack/swift master: Reclaim expired cleaving context metadata  https://review.openstack.org/56983211:14
*** SkyRocknRoll_ has joined #openstack-swift11:14
*** SkyRocknRoll has quit IRC11:16
*** SkyRocknRoll has joined #openstack-swift11:17
*** SkyRocknRoll_ has quit IRC11:20
openstackgerritAlistair Coles proposed openstack/swift master: Simplify ContainerBroker._get_shard_range_rows()  https://review.openstack.org/56996211:21
*** spsurya has quit IRC11:41
*** armaan has quit IRC11:41
*** armaan has joined #openstack-swift11:44
*** armaan has quit IRC11:48
*** armaan has joined #openstack-swift11:49
*** armaan has quit IRC11:49
*** armaan has joined #openstack-swift11:50
*** armaan has quit IRC11:51
openstackgerritAlistair Coles proposed openstack/swift master: Test rsync error log truncation  https://review.openstack.org/56996811:59
*** silor has quit IRC12:03
*** vinsh has quit IRC12:04
*** vinsh has joined #openstack-swift12:04
*** vinsh has quit IRC12:04
*** vinsh has joined #openstack-swift12:05
openstackgerritAlistair Coles proposed openstack/swift master: Avoid premature shrinking in sharder probe test  https://review.openstack.org/56997312:35
*** mvenesio has joined #openstack-swift12:43
*** pcaruana has quit IRC12:54
*** cshastri has quit IRC12:58
openstackgerritMerged openstack/swift master: Remove exclude_states from get_shard_ranges  https://review.openstack.org/56984013:04
*** pcaruana has joined #openstack-swift13:13
*** zigo_ is now known as zigo13:22
*** NM has joined #openstack-swift13:27
*** NM has quit IRC13:33
*** psachin has quit IRC13:37
*** ccamacho has quit IRC14:19
*** ccamacho has joined #openstack-swift14:31
*** ccamacho has quit IRC14:31
*** ccamacho has joined #openstack-swift14:32
*** cshastri has joined #openstack-swift14:34
*** spsurya has joined #openstack-swift14:43
*** pcaruana has quit IRC14:58
*** armaan has joined #openstack-swift15:05
*** cshastri has quit IRC15:09
*** links has quit IRC15:37
*** gyee has joined #openstack-swift15:38
*** cshastri has joined #openstack-swift15:39
*** cbartz has quit IRC16:05
*** tesseract has quit IRC16:17
openstackgerritAlistair Coles proposed openstack/swift master: Add unit tests for replicator sync_shard_ranges  https://review.openstack.org/57000516:18
*** ccamacho has quit IRC16:23
openstackgerritMerged openstack/swift master: s3api: simplify BaseAclHandler.request_with  https://review.openstack.org/56587216:28
*** armaan has quit IRC16:34
*** armaan has joined #openstack-swift16:35
*** geaaru has quit IRC16:37
*** armaan has quit IRC16:38
*** armaan_ has joined #openstack-swift16:38
*** mikecmpbll has quit IRC16:39
openstackgerritTim Burke proposed openstack/swift master: Prevent IndexError on bad fragment index  https://review.openstack.org/56989716:46
openstackgerritAlistair Coles proposed openstack/swift master: Add unit tests for replicator sync_shard_ranges  https://review.openstack.org/57000516:57
openstackgerritTim Burke proposed openstack/swift master: Bump up timeout for swift-probetests-centos-7  https://review.openstack.org/57001116:58
claygtimburke: ^ great commit message on that one!17:03
acolesthis patch https://review.openstack.org/#/c/565748/ is still showing as open and polluting the dashboards even though it is merged?17:05
patchbotpatch 565748 - swift (feature/deep-review) - Add sharder daemon, manage_shard_ranges tool and p... (MERGED)17:05
claygwhat is MHNIASP !? google and urban dictionary don't know - so I don't feel bad not knowing either.17:06
acolesmust have needed it at some point17:06
acoles(I made it up)17:07
claygI like it!17:07
acolesclayg: YCMTUT17:07
claygwe should definitely have a short hand for MHNIASP - that's basically all code I've written and the only real excuse for half of it!17:07
acoles(you can make things up too!)17:08
openstackgerritTim Burke proposed openstack/swift master: Clean up direct_client's gen_headers  https://review.openstack.org/56988417:18
timburkeacoles: on the unmerged-yet-clearly-merged patch, i think we may need -infra's help...17:21
*** hseipp has quit IRC17:25
*** armaan_ has quit IRC17:25
*** armaan has joined #openstack-swift17:26
openstackgerritTim Burke proposed openstack/swift master: Get rid of tpool_reraise  https://review.openstack.org/51878317:31
*** armaan has quit IRC17:35
*** armaan has joined #openstack-swift17:35
*** ccamacho has joined #openstack-swift17:53
kota_good morning Vancouver Day 217:55
*** links has joined #openstack-swift17:59
openstackgerritMerged openstack/swift master: Truncate error logs to prevent log handler runs out of the buffer.  https://review.openstack.org/56114218:06
*** armaan has quit IRC18:07
*** armaan has joined #openstack-swift18:08
*** SkyRocknRoll has quit IRC18:29
*** cshastri has quit IRC18:35
*** germs has joined #openstack-swift18:36
mahaticnotmyname: sure, looking forward to meet you. Met kota_ mattoliverau and joe arnold. Not sure cschwede is around18:50
mahaticcongrats everyone on sharding merge!18:51
*** hseipp has joined #openstack-swift18:57
*** links has quit IRC19:01
openstackgerritKota Tsuyuzaki proposed openstack/swift master: Fix versioned writes error with url-encoded object name  https://review.openstack.org/55524519:07
openstackgerritTim Burke proposed openstack/swift master: Get rid of tpool_reraise  https://review.openstack.org/51878319:08
kota_timburke: push an update for the versioned_wirte fix and response for your comments.19:08
*** Anticime1 is now known as Anticimex19:09
timburkethanks kota_! i'll try to look at it again later today, maybe tomorrow19:10
*** hseipp has quit IRC19:10
*** hseipp has joined #openstack-swift19:10
kota_yeah, i think you have good eyes but I don't remember so much for the patch written at one month ago so feel free to talk around to get it understand together.19:12
openstackgerritTim Burke proposed openstack/swift master: Make the decision between primary/handoff sets more obvious  https://review.openstack.org/56794019:13
*** hseipp has quit IRC19:15
openstackgerritKota Tsuyuzaki proposed openstack/swift master: WIP: Add ceph-s3 test non-voting job  https://review.openstack.org/56470019:16
*** mikecmpbll has joined #openstack-swift19:24
openstackgerritMerged openstack/swift master: Simplify ContainerBroker._get_shard_range_rows()  https://review.openstack.org/56996219:31
*** mvenesio has quit IRC19:39
*** mvenesio has joined #openstack-swift19:39
*** mvenesio has quit IRC19:44
*** amandap has joined #openstack-swift19:52
openstackgerritTim Burke proposed openstack/swift master: Clean up logging interpolation  https://review.openstack.org/57003419:54
openstackgerritMerged openstack/swift master: Avoid premature shrinking in sharder probe test  https://review.openstack.org/56997319:54
openstackgerritMerged openstack/swift master: Test rsync error log truncation  https://review.openstack.org/56996819:54
openstackgerritTim Burke proposed openstack/swift master: Move handling of missing table outside of do_query  https://review.openstack.org/57003620:00
openstackgerritMerged openstack/swift master: Bump up timeout for swift-probetests-centos-7  https://review.openstack.org/57001120:09
*** d0ugal_ has joined #openstack-swift20:19
*** d0ugal has quit IRC20:21
*** mikecmpbll has quit IRC20:31
*** mikecmpbll has joined #openstack-swift20:32
*** germs has quit IRC20:34
*** bigdogstl has joined #openstack-swift20:41
rledisezmahatic: i saw cschwede in a hallway ;)20:42
*** mvenesio has joined #openstack-swift20:45
*** bigdogstl has quit IRC20:46
*** germs has joined #openstack-swift20:47
kota_rledisez: nice!20:49
openstackgerritTim Burke proposed openstack/swift master: Let make_db_file_path accept epoch=None  https://review.openstack.org/57005420:50
*** germs has quit IRC20:51
openstackgerritTim Burke proposed openstack/swift master: Stop overriding _in_sync in container replicator  https://review.openstack.org/57005521:02
timburketorgomatic: what do you mean about https://review.openstack.org/#/c/556192/ ? requirements.txt bumped both requests and six past what's provided by trusty... and even xenial (well, for requests)!21:10
patchbotpatch 556192 - python-swiftclient - add lower-constraints job21:10
torgomatictimburke: the lower constraints didn't, though... I thought that was the one that mattered21:11
torgomaticor have I misunderstood how that stuff works?21:11
timburkeeh? i see requests==2.14.2, six==1.10.0 in lower-constraints.txt for that patch21:12
timburketrusty ships requests 2.2.1, six 1.5.221:12
torgomaticbah, apparently I can't read :(21:12
torgomatictimburke: shall I -2 it, or is it not worth the hassle?21:13
timburkei started messing around with backing out most of the delta from patchset 8 in https://review.openstack.org/#/c/568914/ but it looks like our --insecure option actually *does* require a newer requests...21:14
patchbotpatch 568914 - python-swiftclient - Back out some version bumps21:14
timburkeidk man, idk...21:14
torgomaticyeah, me neither21:15
timburkefwiw, i notice that a few days ago: "dependencies are the worst. when i did https://github.com/openstack/python-swiftclient/commit/ff505d7 i made a liar of our impressively-low requests>=1.1 requirement, 'cause the exception came in with https://github.com/requests/requests/commit/811ee4e (so, requests 2.4.0)"21:15
timburkebut i haven't gotten around to doing anything with that info21:15
torgomaticMaybe just let it go and see if anything catches fire. We can revert it later if need be, I imagine.21:16
timburkewhat i *do* know is that the failure output looks like shit: http://logs.openstack.org/14/568914/4/check/openstack-tox-lower-constraints/bca39dc/job-output.txt.gz#_2018-05-16_18_34_43_90155421:16
torgomaticit reminds me of C++ template errors, only with more console colors21:17
openstackgerritClay Gerrard proposed openstack/swift master: Add a helper context for optional connection args  https://review.openstack.org/57005821:17
*** germs has joined #openstack-swift21:40
*** germs has quit IRC21:40
*** germs has joined #openstack-swift21:40
*** germs has quit IRC21:45
*** germs has joined #openstack-swift21:46
*** germs has quit IRC21:54
*** germs has joined #openstack-swift21:57
*** germs has quit IRC22:01
openstackgerritTim Burke proposed openstack/swift master: WIP: Get rid of _transform_record in ContainerBroker  https://review.openstack.org/57006322:03
openstackgerritClay Gerrard proposed openstack/swift master: Use maybe_get more  https://review.openstack.org/57006822:04
*** d0ugal_ has quit IRC22:06
*** mikecmpbll has quit IRC22:07
claygtimburke: ok, this time I even checked for a Related-Change-Id... I'm not seeing the *why* part of patch 57006322:07
patchbothttps://review.openstack.org/#/c/570063/ - swift - WIP: Get rid of _transform_record in ContainerBroker22:07
*** d0ugal_ has joined #openstack-swift22:07
claygI can't evaluate if it's good/bad to change the contract w/o a use-case - I mean... I would say "there's no reason for this; this is needless code churn; needless code churn is bad" - but I know you too well.  You have some sneaky plan... what is it!?22:08
timburke'cause it bugs me that we smear the responsibility of transforming a row from the database to something consumable by a client across three separate little helper functions, one of which you kind-of-sometimes get for free-ish22:09
openstackgerritSamuel Merritt proposed openstack/swift master: Add live status report to object replicator  https://review.openstack.org/56586822:09
timburkeeven *better* would be if i could get update_data_record and _record_to_dict unified to some degree22:10
timburkebut i haven't thought that far ahead22:10
timburkeeven better than *that* though would be to *actually use row_factory* instead of reinventing it22:11
*** amandap has quit IRC22:12
claygok, acctually the only one of those I think I understood and immediately associated with value was the last one - and only because it sounded like less code - thinking about "less code" immediately triggers dopamine for me.22:14
timburkeclayg: well hell, it's already a net -16 -- merge it!22:15
timburke:P22:16
*** rcernin has joined #openstack-swift22:21
*** germs has joined #openstack-swift22:25
openstackgerritMerged openstack/python-swiftclient master: add lower-constraints job  https://review.openstack.org/55619222:30
*** germs has quit IRC22:32
zaitcevI'm working on adding py3 to sharding22:34
zaitcevMan22:34
zaitcevLooks like attempts were made, but it requires a serious concentration to track what is string and what is bytes, so regardless everything is mixed up.22:35
openstackgerritTim Burke proposed openstack/python-swiftclient master: Back out some version bumps  https://review.openstack.org/56891422:35
timburkezaitcev: that seems to *always* be the case when trying to write py2/py3 code. it sucks.22:36
zaitcevValueError: upper (b'') must be greater than or equal to lower (b"b'obj89'")22:37
*** germs has joined #openstack-swift22:38
*** germs has quit IRC22:38
*** germs has joined #openstack-swift22:38
*** threestrands has joined #openstack-swift22:39
timburkeugh. so, should ShardRange bounds always be bytes, always be unicode, or always be native str?22:40
timburkeit seems like probably native str? but i'm not sure22:40
zaitcevI chose bytes, primarily because it permits stuffing them from sqlite without any conversions.22:40
zaitcevBut keep in mind that they also have special type that adds comparisons, the MIN and MAX22:41
timburkebut surely py3 lets you use native strings with sqlite, yeah?22:41
zaitcevDunno, maybe the table needs to have some different types22:41
zaitcever, columns in the table22:42
timburkeregardless, https://github.com/openstack/swift/blob/master/swift/common/utils.py#L4601 (for example) should probably be `if value in (None, b'', u''):`22:42
timburkeheh. column types in sqlite are really more of a "recommendation"...22:42
*** germs has quit IRC22:42
timburkeoh, interesting... https://docs.python.org/2/library/sqlite3.html#sqlite3.Connection.text_factory22:46
openstackgerritMerged openstack/swift master: Clean up logging interpolation  https://review.openstack.org/57003422:50
*** timur has joined #openstack-swift22:59
timurI noticed that the X-Timestamp header for objects does not include the offset (i.e. the metadata update date) and while the Last-Modified date does include it, it does not offer sub-second resolution and may return a date in the "future" (because it calls math.ceil(float(file_x_ts))). Would Swift be open to including an additional header, like X-Timestamp, that includes the sub-second resolution of23:03
timurthe created time + metadata offset?23:03
*** kei_yama has joined #openstack-swift23:14
openstackgerritMerged openstack/swift master: Improve building listings from shards  https://review.openstack.org/56979623:22
*** amandap has joined #openstack-swift23:43
*** germs has joined #openstack-swift23:46
openstackgerritSamuel Merritt proposed openstack/swift master: Use X-Timestamp when checking object expiration  https://review.openstack.org/53259523:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!