Thursday, 2017-12-28

timburkeoh extra fun, even openstackgerrit is gone...00:00
timburkei knew i shoulda gone and downloaded the undelete patch as i was reviewing...00:02
zaitcevyeah, always git review -d N00:24
*** linkmark has quit IRC00:25
zaitcevoh, crap00:25
zaitcevProgramming in Go is harmful, you start returning tuples everywhere.00:25
notmynamezaitcev: do you know if you'll be able to go to dublin for the PTG?00:25
zaitcevnotmyname: Most likely yes, although I haven't gotten air tickets yet.00:26
notmynamegreat!00:26
zaitcevnotmyname: I addressed all issues raised at the big PUT+POST video meeting, so I'm going to poke Clay et al for reviews before PTG. Then maybe PTG will only need to rubber-stamp it, if that. We committed Symlink without in-person meetings, so surely it can be done.00:27
zaitcevMan, I really wish Mr. Gun1x saved that account.builder that makes a traceback just from looking at it.00:29
zaitcevLooked like EmptyRingError wasn't caught as intended00:29
zaitcevokay, I need to continue setting up a TV that I bought just now.00:29
*** itlinux has joined #openstack-swift00:43
*** tovin07_ has joined #openstack-swift00:58
*** cshastri_ has joined #openstack-swift01:33
*** awkwardpenguin has joined #openstack-swift01:42
*** psachin has joined #openstack-swift01:47
*** awkwardpenguin has quit IRC02:03
*** openstackgerrit has joined #openstack-swift02:27
openstackgerritMerged openstack/swift master: Better mock out OSErrors in test_replicator before raising them  https://review.openstack.org/49643302:27
*** bkopilov has quit IRC03:14
*** kei_yama has quit IRC03:45
*** awkwardpenguin has joined #openstack-swift03:46
*** awkwardpenguin has quit IRC03:46
*** awkwardpenguin has joined #openstack-swift03:48
*** kei_yama has joined #openstack-swift04:02
*** links has joined #openstack-swift04:12
*** kei_yama has quit IRC04:12
openstackgerritTim Burke proposed openstack/swift master: tempurl: Make the digest algorithm configurable  https://review.openstack.org/52577004:20
openstackgerritTim Burke proposed openstack/swift master: tempurl: Deprecate sha1 signatures  https://review.openstack.org/52577104:20
*** bkopilov has joined #openstack-swift04:33
*** kei_yama has joined #openstack-swift04:48
*** gkadam has joined #openstack-swift05:23
*** gkadam has quit IRC05:24
*** gkadam has joined #openstack-swift05:24
*** gkadam has quit IRC06:01
*** gkadam has joined #openstack-swift06:01
*** kei_yama has quit IRC06:04
*** itlinux has quit IRC06:08
*** gkadam has quit IRC06:25
*** gkadam has joined #openstack-swift06:26
*** SkyRocknRoll has joined #openstack-swift06:45
*** awkwardpenguin has quit IRC07:03
*** awkwardpenguin has joined #openstack-swift07:04
*** gkadam has quit IRC07:06
*** awkwardpenguin has quit IRC07:09
*** gkadam has joined #openstack-swift07:25
*** gkadam has quit IRC07:50
*** awkwardpenguin has joined #openstack-swift09:06
*** awkwardpenguin has quit IRC09:10
openstackgerritGuoqiang Ding proposed openstack/python-swiftclient master: Update docs build job for new documentation PTI jobs  https://review.openstack.org/53033009:37
*** silor has joined #openstack-swift09:40
*** tovin07_ has quit IRC10:12
*** psachin has quit IRC10:21
*** cshastri_ has quit IRC10:25
gun1xnotmyname:  i managed to get this done10:28
gun1xi just reinstalled the storage node10:28
gun1xzaitcev: yea, sorry, i wanted to get this done fast :D10:29
*** awkwardpenguin has joined #openstack-swift11:08
*** awkwardpenguin has quit IRC11:12
*** silor has quit IRC11:36
*** bkopilov has quit IRC12:09
*** hoonetorg has quit IRC12:27
*** hoonetorg has joined #openstack-swift12:56
*** hoonetorg_ has joined #openstack-swift12:57
*** hoonetorg_ has quit IRC12:58
*** cbartz has joined #openstack-swift13:00
*** awkwardpenguin has joined #openstack-swift13:09
*** awkwardpenguin has quit IRC13:14
*** hoonetorg has quit IRC13:17
*** hoonetorg has joined #openstack-swift13:33
*** gkadam has joined #openstack-swift13:37
*** links has quit IRC13:57
*** silor has joined #openstack-swift14:00
*** bkopilov has joined #openstack-swift14:15
*** awkwardpenguin has joined #openstack-swift14:33
*** awkwardpenguin has quit IRC14:37
*** gkadam has quit IRC14:41
*** itlinux has joined #openstack-swift15:05
*** silor has quit IRC15:09
*** itlinux has quit IRC15:12
openstackgerritGuoqiang Ding proposed openstack/python-swiftclient master: Update new documentation PTI jobs  https://review.openstack.org/53033015:25
*** SkyRocknRoll has quit IRC15:27
*** SkyRocknRoll has joined #openstack-swift15:36
*** SkyRocknRoll has quit IRC15:41
*** SkyRocknRoll has joined #openstack-swift15:53
*** itlinux has joined #openstack-swift16:03
openstackgerritGuoqiang Ding proposed openstack/python-swiftclient master: Update new documentation PTI jobs  https://review.openstack.org/53033016:16
*** awkwardpenguin has joined #openstack-swift16:35
*** SkyRocknRoll has quit IRC16:35
*** awkwardpenguin has quit IRC16:39
*** cbartz has quit IRC16:49
*** SkyRocknRoll has joined #openstack-swift16:52
timburkegood morning16:52
notmynamegood morning17:29
*** two_tired has joined #openstack-swift17:42
claygtimburke: thanks for all the great comments on patch 528155 - I'll see what I can do!17:55
patchbothttps://review.openstack.org/#/c/528155/ - swift - Represent dispersion worse than one replicanth17:55
timburkeyeah! i was just about to ping you on that. i'm pretty sure deducting max_replicas is the right move there -- i was suspicious about how big some of those max_dispersion numbers were17:57
timburkei've got a diff stashed somewhere... gimme a sec...17:57
timburkeclayg: see what you think of http://paste.openstack.org/show/632654/17:58
claygso if a tier should only have at max 1 replica of a part per maximum dispersion - and it has *two* - then only what part-replica is at risk...18:01
claygi guess - does that make everyone's dispersion like a ton smaller?  I was already weirded out at how smaller our dispersion numbers are getting... and I think it's weird that the more replicas you have the more you have to worry about even a tiny bit of dispersion being really rather bad18:02
timburkemaybe i'd be ok taking out the divided-by-total-replicas so overall dispersion can go past 100? but then i'd have to think again about what's going on in the per-tier calculations...18:05
claygyeah i have no idea :'(18:05
claygit's all made up18:05
claygand then we're going to make it up differently now18:05
claygbut ... there's got to be some benifit in having 3-4 people be like "yeah, that number sort of makes some intuitive sense to me"18:06
claygnotmyname just says it has to get bigger when it's badder18:06
clayg^ which seems reasonable to me18:06
notmynameoh did I?18:07
claygyeah because of balance working that way?18:07
notmynameI thought bigger numbers were always better ;-)18:07
claygif you have two gauges - they should both go red in the same direction18:07
notmynameyeah, I definitely agree with that analogy18:07
claygyeah I think you would have preferred if balance 100% meant 100% good-to-go but that wasn't up to us18:07
claygso... 0-0 means good18:08
notmyname"dispersion" seems like a good thing (gut reaction). so bigger dispersion == better18:08
claygsigh - you can't change your mind now (although mattoliverau made the same observation, honestly I'm pretty sure my first pass worked that way)18:08
notmynamelol18:08
notmynameTBH, I don't htink it matters too much. going in the same direction (and showing changes after the user does something) is way more important than which way it goes18:09
claygI'm totally open to changing it!  What I really want to be able to fix is rebalance of rings that so fucked dispersion is getting stuck at 100% terrible - I need a better measuring stick is all18:09
claygI can start shitting out a boolean - "you_are_less_fucked_keep_going = True"18:09
notmynameI can be totally fine with the best number being 0.0. or the best number being 100. either way, I *really* like the goal behind the patch--give users a better measuring stick so they know to keep going18:11
notmyname$ swift-ring-builder object.builder rebalance18:11
notmynameGood job! Keep going!18:12
notmynamehmm... perhaps that's a little too patronizing ;-)18:12
*** awkwardpenguin has joined #openstack-swift18:12
*** gkadam has joined #openstack-swift18:15
*** chsc has joined #openstack-swift18:38
*** chsc has joined #openstack-swift18:38
*** gkadam has quit IRC18:54
openstackgerritMerged openstack/swift master: Skip symlink + vw functional tests if symlink is not enabled  https://review.openstack.org/53001418:55
*** cbartz has joined #openstack-swift19:00
*** cbartz has quit IRC19:01
timburkei wonder if the dispersion report should grow some knowledge about the underlying storage policy... i mean, you can square dispersion *and* balance for a 10+3 EC policy with 3 zones that have 2 equally-weighted nodes and a fourth zone with a single half-weight node (assuming you have enough drives) -- but that doesn't mean you're in a good place!19:08
timburkei feel like somewhere we should be saying "good job standing up that extra zone -- but you've *still* likely got an availability issue if you lose two nodes!19:09
openstackgerritTim Burke proposed openstack/swift master: tempurl: Make the digest algorithm configurable  https://review.openstack.org/52577019:12
openstackgerritTim Burke proposed openstack/swift master: tempurl: Deprecate sha1 signatures  https://review.openstack.org/52577119:12
*** awkwardpenguin has joined #openstack-swift19:14
timburkenotmyname: are the tempurl tests part of defcore? i'm wondering how much trouble it'll be to get that second one to pass (needs tempest updates as written)19:15
notmynameI think so. but let me check19:15
notmynametempest.api.object_storage.test_object_temp_url.ObjectTempUrlTest.test_get_object_using_temp_url19:17
openstackgerritClay Gerrard proposed openstack/swift master: Represent dispersion worse than one replicanth  https://review.openstack.org/52815519:17
notmynametempest.api.object_storage.test_object_temp_url.ObjectTempUrlTest.test_put_object_using_temp_url19:17
notmynamethose two tests are in the defcore guidelines19:17
notmynamefound on https://refstack.openstack.org/#/guidelines19:17
notmynameselect the object storage target program19:17
notmynamenot that tempest puts a uuid on each test (I think each time it's updated) and the defcore guidelines refer to a particular uuid19:18
*** awkwardpenguin has quit IRC19:18
notmynameyou can see them under the "test list" link on the right19:18
timburkeyeah, i'd found the tests... wasn't clear from there whether it was in or not. so... it'll probably be a while before we can drop sha1 from default allowed-signatures19:28
notmynamenothing different than our normal deprication policy, I think19:32
*** flwang has quit IRC20:48
*** flwang has joined #openstack-swift21:01
openstackgerritMerged openstack/swift master: add name to core emeritus  https://review.openstack.org/52784521:09
claygtimburke: there is not _currently_ anyway to recalculate dispersion w/o a rebalance21:20
claygtimburke: ultimately it happens in builder.RingBuilder._build_dispersion_graph which only gets called at the end of rebalance (and also dynamically if your on-disk serialized builder is missing the cached _dispersion_graph attribute because your it was balanced before we added that data)21:21
claygtimburke: I think it'd be a nice followup to add something like that... dispersion --recalculate (?) and that will also save back?  dunno...21:22
claygi think if we could agree on the interface the code would be trivial21:22
claygthanks for the final review +2 on patch 52815521:23
patchbothttps://review.openstack.org/#/c/528155/ - swift - Represent dispersion worse than one replicanth21:23
*** Jeffrey4l has quit IRC21:36
*** jlvillal has quit IRC21:37
*** jlvillal has joined #openstack-swift21:38
*** timur has quit IRC21:39
*** timur has joined #openstack-swift21:40
*** lifeless has quit IRC21:43
*** Jeffrey4l has joined #openstack-swift21:45
*** lifeless has joined #openstack-swift22:22
*** itlinux has quit IRC22:28
mattoliverauI'm out at a holiday house with in-laws.. so looking forward to catching up with the dispersion patch whether it's landed or not when I'm back next week. (If I can't get to it before)22:51
notmynamemattoliverau: nice! enjoy the vacation. must be so good to get away from the beach house from time to time ;-)22:52
notmynamenever have to make those hard decisions like "should I go walk on the beach now? or later? or both?"22:52
*** itlinux has joined #openstack-swift23:16
*** awkwardpenguin has joined #openstack-swift23:22
openstackgerritSamuel Merritt proposed openstack/swift master: Fix socket leak on 416 EC GET responses.  https://review.openstack.org/53041123:26
*** awkwardpenguin has quit IRC23:29
*** itlinux has quit IRC23:29
*** chsc has quit IRC23:32
clayg  # no super(); we inherit from an old-style class (it's23:37
clayg  # httplib's fault; don't try and fix it).23:37
clayg^ lol23:37
*** SkyRocknRoll has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!