| *** timburke_ has quit IRC | 00:00 | |
| *** JimCheung has joined #openstack-swift | 00:01 | |
| *** MeltedLux has joined #openstack-swift | 00:02 | |
| *** timburke has joined #openstack-swift | 00:02 | |
| *** ChanServ sets mode: +v timburke | 00:02 | |
| *** tdasilva has joined #openstack-swift | 00:05 | |
| *** DuncanT has joined #openstack-swift | 00:10 | |
| *** portdirect has joined #openstack-swift | 00:29 | |
| *** tovin07_ has joined #openstack-swift | 00:45 | |
| *** SkyRocknRoll has quit IRC | 00:50 | |
| *** gyee has quit IRC | 00:57 | |
| *** SkyRocknRoll has joined #openstack-swift | 01:03 | |
| *** SkyRocknRoll has joined #openstack-swift | 01:03 | |
| kota_ | good morning | 01:10 |
|---|---|---|
| kota_ | oh, it looks like acoles has joined back to symlink reviews, very nice. | 01:12 |
| kota_ | clayg: thanks for doing that checking symlink + vw behavior. if you find something buggy, please let me know anytime. | 01:13 |
| kota_ | timburke: yeah, as you know, we have the chance that we can give initiated connection with allow_redirects=False so that I agree with you it's not hurry for now. | 01:16 |
| *** SkyRocknRoll has quit IRC | 01:16 | |
| kota_ | that is another thing though, it may be worth to add new command when symlink land, that is like `swift ln` or `swift link` to make the symlink | 01:19 |
| kota_ | with current swift-client, we should make an empty file in the local and then call `swift upload container link -H "container/obj"`. Even the local empty content object is just a garbage. | 01:21 |
| *** cshastri has joined #openstack-swift | 01:30 | |
| *** MeltedLux has quit IRC | 01:37 | |
| *** m_kazuhiro has joined #openstack-swift | 01:37 | |
| *** MeltedLux has joined #openstack-swift | 01:37 | |
| m_kazuhiro | good morning | 01:38 |
| *** SkyRocknRoll has joined #openstack-swift | 01:42 | |
| *** two_tired has joined #openstack-swift | 01:49 | |
| kota_ | m_kazuhiro: morning | 01:54 |
| kota_ | it looks like acoles is already back to England? | 01:55 |
| *** JimCheung has quit IRC | 02:07 | |
| m_kazuhiro | kota_: morning | 02:22 |
| kota_ | m_kazuhiro: how's going on symlink? I think, some reviewers have follow ups (me, clayg, and acoles). | 02:26 |
| kota_ | m_kazuhiro: do you like those changes? if you have time to look at them and call me, I can work to squash and resolve merge conflicts in the main patch. | 02:31 |
| m_kazuhiro | kota_: I will check the follow ups today. At my light reading them, the follow ups looks great. If you can work for symlink, it will be very helpful for me. | 02:32 |
| kota_ | m_kazuhiro: ok, anytime let me know if you need my help | 02:33 |
| m_kazuhiro | kota_: Thank you very much. | 02:34 |
| *** JimCheung has joined #openstack-swift | 02:38 | |
| *** JimCheung has quit IRC | 02:42 | |
| *** JimCheung has joined #openstack-swift | 02:59 | |
| *** armaan has quit IRC | 03:02 | |
| *** armaan has joined #openstack-swift | 03:02 | |
| *** JimCheung has quit IRC | 03:03 | |
| *** ianychoi has joined #openstack-swift | 03:08 | |
| *** bkopilov has quit IRC | 03:10 | |
| *** JimCheung has joined #openstack-swift | 03:31 | |
| *** JimCheung has quit IRC | 03:35 | |
| *** kei_yama has quit IRC | 03:37 | |
| *** JimCheung has joined #openstack-swift | 03:45 | |
| *** JimCheung has quit IRC | 03:53 | |
| openstackgerrit | Matthew Oliver proposed openstack/swift master: Unlink Asyncs older then reclaim_age https://review.openstack.org/527296 | 03:57 |
| *** JimCheung has joined #openstack-swift | 04:00 | |
| *** kei_yama has joined #openstack-swift | 04:01 | |
| *** JimCheung has quit IRC | 04:04 | |
| *** JimCheung has joined #openstack-swift | 04:19 | |
| *** JimCheung has quit IRC | 04:23 | |
| *** SkyRocknRoll has quit IRC | 04:29 | |
| *** bkopilov has joined #openstack-swift | 04:33 | |
| *** m_kazuhiro_ has joined #openstack-swift | 04:36 | |
| *** m_kazuhiro has quit IRC | 04:40 | |
| m_kazuhiro_ | kota_: I have finished checking details of symlink's following patches (https://review.openstack.org/#/c/526564 https://review.openstack.org/#/c/526615 https://review.openstack.org/#/c/526985 https://review.openstack.org/#/c/527126 ). I feel these patches are great and should be squashed into symlink's main implementation patch. | 05:14 |
| patchbot | patch 526564 - swift - Do not leak symlinks to proxy & obj layer | 05:14 |
| patchbot | patch 526615 - swift - Testing Implementation to divide symlink headers | 05:14 |
| patchbot | patch 526985 - swift - SYMLINK: symlink path and account can be in separe... | 05:14 |
| patchbot | patch 527126 - swift - Use symlink in container-sync internal client pipe... | 05:14 |
| *** two_tired has quit IRC | 05:32 | |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/swift master: Symlink implementation. https://review.openstack.org/232162 | 05:38 |
| kota_ | m_kazuhiro: done to squash. I will work around rebase acoles follow up to clarify what's changed from the squashed patch. | 05:39 |
| *** robcresswell has quit IRC | 05:39 | |
| *** fungi has quit IRC | 05:45 | |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/swift master: Use symlink in container-sync internal client pipeline https://review.openstack.org/527126 | 05:46 |
| *** fungi has joined #openstack-swift | 05:48 | |
| openstackgerrit | Matthew Oliver proposed openstack/swift master: Add a -L or --list to recon to list all results https://review.openstack.org/525039 | 05:56 |
| m_kazuhiro_ | kota_: Thank you! | 06:08 |
| *** SkyRocknRoll has joined #openstack-swift | 06:32 | |
| *** bkopilov has quit IRC | 07:09 | |
| *** rcernin has quit IRC | 07:21 | |
| *** bkopilov has joined #openstack-swift | 07:26 | |
| *** armaan has quit IRC | 07:33 | |
| *** armaan has joined #openstack-swift | 07:34 | |
| *** robcresswell has joined #openstack-swift | 07:39 | |
| *** m_kazuhiro_ has quit IRC | 07:39 | |
| *** hseipp has joined #openstack-swift | 07:41 | |
| *** m_kazuhiro has joined #openstack-swift | 07:47 | |
| *** d0ugal has quit IRC | 07:51 | |
| *** d0ugal has joined #openstack-swift | 07:57 | |
| *** neonpastor has quit IRC | 08:00 | |
| *** neonpastor has joined #openstack-swift | 08:02 | |
| *** armaan has quit IRC | 08:03 | |
| *** hoonetorg has quit IRC | 08:06 | |
| *** gkadam has joined #openstack-swift | 08:07 | |
| *** hoonetorg has joined #openstack-swift | 08:19 | |
| *** tesseract has joined #openstack-swift | 08:22 | |
| *** armaan has joined #openstack-swift | 08:23 | |
| *** armaan has quit IRC | 08:32 | |
| *** armaan has joined #openstack-swift | 08:32 | |
| *** rcernin has joined #openstack-swift | 08:36 | |
| -openstackstatus- NOTICE: Our CI system Zuul is currently not accessible. Wait with approving changes and rechecks until it's back online. Currently waiting for an admin to investigate. | 08:49 | |
| *** linkmark has joined #openstack-swift | 08:51 | |
| *** m_kazuhiro has quit IRC | 08:58 | |
| *** cbartz has joined #openstack-swift | 09:06 | |
| -openstackstatus- NOTICE: Zuul is back online, looks like a temporary network problem. | 09:09 | |
| *** jappleii__ has quit IRC | 09:10 | |
| *** hseipp has quit IRC | 09:22 | |
| *** armaan has quit IRC | 09:24 | |
| *** armaan has joined #openstack-swift | 09:25 | |
| *** mvk has quit IRC | 09:25 | |
| *** hseipp has joined #openstack-swift | 09:35 | |
| *** mvk has joined #openstack-swift | 09:51 | |
| *** kei_yama has quit IRC | 09:53 | |
| *** tovin07_ has quit IRC | 10:11 | |
| *** armaan has quit IRC | 10:29 | |
| *** armaan has joined #openstack-swift | 10:30 | |
| *** cshastri has quit IRC | 10:50 | |
| acoles | kota_: yes I am back home | 11:20 |
| acoles | thanks for the rebasing | 11:20 |
| acoles | mattoliverau: thanks for exploring the test failure on patch 525192 - sounds like it is ok to recheck and try to merge it? | 11:24 |
| patchbot | https://review.openstack.org/#/c/525192/ - swift - Ringbuilder: Forbid writing empty rings | 11:24 |
| mattoliverau | acoles: well I can confirm it happens on master.. though it seems less often. At least on my saio. But yeah, it didn't cause it. but might be an indication of where the problem lies. | 11:28 |
| tdasilva | mmm..symlink gate jobs failed on func tests | 11:28 |
| mattoliverau | I haven't had enough time to look closey.. just noticed it, so ran it repeatily. I hope to take a closer look when I get a chance tomorrow. | 11:29 |
| mattoliverau | anyway, I'm off to bed now. night o/ | 11:29 |
| tdasilva | mattoliverau: night | 11:32 |
| acoles | mattoliverau: ok. g'night | 11:32 |
| tdasilva | i'm going to try running now on my env | 11:32 |
| *** mvk has quit IRC | 11:42 | |
| *** mvk has joined #openstack-swift | 11:55 | |
| acoles | tdasilva: func tests pass on my saio | 12:05 |
| tdasilva | tdasilva: yeah, mine too | 12:05 |
| acoles | and the zuul jobs, it is the community cluster jobs that failed | 12:05 |
| tdasilva | acoles: maybe the problem is with third-party cluster | 12:05 |
| tdasilva | yeah | 12:06 |
| kota_ | tdasilva: it seems just a zuul matter so i think we are able to recheck | 12:10 |
| tdasilva | kota_: yeah, i was waiting for the ci infra jobs to finish | 12:12 |
| kota_ | I noticed zuul had a trouble in this evening | 12:12 |
| kota_ | tdasilva: :) | 12:12 |
| *** cshastri has joined #openstack-swift | 12:25 | |
| *** armaan has quit IRC | 12:59 | |
| *** zhurong has joined #openstack-swift | 12:59 | |
| *** SkyRocknRoll has quit IRC | 13:10 | |
| *** zhurong has quit IRC | 13:14 | |
| *** armaan has joined #openstack-swift | 13:15 | |
| *** cshastri has quit IRC | 13:32 | |
| *** hseipp has quit IRC | 13:45 | |
| *** hseipp has joined #openstack-swift | 13:55 | |
| openstackgerrit | Thiago da Silva proposed openstack/swift master: environment variable to set swift_dir https://review.openstack.org/527405 | 13:57 |
| *** tesseract has quit IRC | 14:26 | |
| -openstackstatus- NOTICE: We're currently seeing an elevated rate of timeouts in jobs and the zuulv3.openstack.org dashboard is intermittently unresponsive, please stand by while we troubleshoot the issues. | 14:40 | |
| *** bkopilov has quit IRC | 14:48 | |
| *** rcernin has quit IRC | 15:00 | |
| *** armaan has quit IRC | 15:01 | |
| *** armaan has joined #openstack-swift | 15:03 | |
| *** armaan_ has joined #openstack-swift | 15:10 | |
| *** armaan has quit IRC | 15:10 | |
| *** cshastri has joined #openstack-swift | 15:10 | |
| tdasilva | hseipp: this reminded me of you: https://developer.ibm.com/code/events/jumpstart-your-iot-implementation/ | 15:50 |
| tdasilva | hseipp: I thought you would be presenting :) | 15:50 |
| *** armaan_ has quit IRC | 16:12 | |
| *** cshastri has quit IRC | 16:13 | |
| *** gkadam has quit IRC | 16:29 | |
| *** armaan has joined #openstack-swift | 16:37 | |
| *** gyee has joined #openstack-swift | 16:50 | |
| notmyname | good morning | 16:59 |
| *** bkopilov has joined #openstack-swift | 17:09 | |
| *** cbartz has quit IRC | 17:12 | |
| *** JimCheung has joined #openstack-swift | 17:24 | |
| *** hseipp has quit IRC | 17:24 | |
| *** mvk has quit IRC | 17:27 | |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Symlink doc clean up https://review.openstack.org/527475 | 17:32 |
| timburke | git st | 17:35 |
| timburke | i mean, "good morning!" | 17:35 |
| acoles | timburke: you are on branch #openstack-swift | 17:35 |
| notmyname | nothing to commit, working tree clean | 17:35 |
| timburke | but what are my ahead/behind counts?? | 17:35 |
| acoles | your are way ahead | 17:36 |
| timburke | yeah, seems pretty likely that i'll need to rebase... could get ugly | 17:36 |
| notmyname | I'm looking at joel's data segment patch | 17:36 |
| notmyname | how's the symlink patch looking? anyone think it will land by tomorrow? | 17:37 |
| acoles | notmyname: I've not found any reason it shouldn't, except for some discussion of patch 527126 | 17:39 |
| patchbot | https://review.openstack.org/#/c/527126/ - swift - Use symlink in container-sync internal client pipe... | 17:39 |
| notmyname | ok, great | 17:40 |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Assert X-Newest and X-Backend headers are propagated to symlink target https://review.openstack.org/527477 | 17:40 |
| acoles | ^^ these are trivial follow-ons | 17:40 |
| notmyname | symlink in the pipeline seems like a good idea | 17:40 |
| notmyname | explicit over implicit, and all that | 17:41 |
| acoles | notmyname: I think so, but it comes down to not bleeding implementation detail - use the API query param rather than importing a helper function | 17:41 |
| acoles | maybe others could weigh in with an opinion on p 527126 | 17:42 |
| patchbot | https://review.openstack.org/#/c/527126/ - swift - Use symlink in container-sync internal client pipe... | 17:42 |
| acoles | The doc changes for symlink are good IMHO - even the new swift.source SYM has been documented! good work whoever kota_ tdasilva m_kazuhiro | 17:53 |
| acoles | m_kazuhiro needs a bouncer or will miss all the fireworks when symlinks lands :) | 17:53 |
| *** shaner has quit IRC | 17:54 | |
| *** shaner has joined #openstack-swift | 17:55 | |
| acoles | tdasilva: zuul has been flakey today, I can't get the dashboard to load, and the symlinks patch currently has a bunch of failed tests - maybe you could do another recheck at end of your day and hopefully it will be all green when kota_ wakes up? | 18:00 |
| *** shaner has quit IRC | 18:01 | |
| *** shaner has joined #openstack-swift | 18:01 | |
| notmyname | how do I get a detailed coverage report these days? the one that shows the lines that aren't covered (instead of just the count of uncovered lines)? | 18:59 |
| *** armaan has quit IRC | 18:59 | |
| *** armaan has joined #openstack-swift | 19:00 | |
| *** shaner has quit IRC | 19:02 | |
| *** armaan has quit IRC | 19:03 | |
| *** armaan has joined #openstack-swift | 19:04 | |
| *** shaner has joined #openstack-swift | 19:04 | |
| *** tonyb_ has quit IRC | 19:52 | |
| *** oshritf has joined #openstack-swift | 19:52 | |
| *** tonyb has joined #openstack-swift | 19:52 | |
| *** chsc has joined #openstack-swift | 20:07 | |
| *** chsc has quit IRC | 20:07 | |
| *** chsc has joined #openstack-swift | 20:07 | |
| *** mvk has joined #openstack-swift | 20:10 | |
| -openstackstatus- NOTICE: The zuul scheduler has been restarted after lengthy troubleshooting for a memory consumption issue; earlier changes have been reenqueued but if you notice jobs not running for a new or approved change you may want to leave a recheck comment or a new approval vote | 20:16 | |
| clarkb | notmyname: locally? iirc there is a comman you can run to produce an html report from exieting coverage data | 20:21 |
| clarkb | `coverage html` says the docs | 20:22 |
| *** oshritf has quit IRC | 20:30 | |
| *** cschwede has quit IRC | 20:34 | |
| *** openstackgerrit has quit IRC | 20:34 | |
| *** notmyname has quit IRC | 20:34 | |
| *** cschwede has joined #openstack-swift | 20:34 | |
| *** ndk- has quit IRC | 20:34 | |
| *** armaan has quit IRC | 20:35 | |
| *** timss has quit IRC | 20:35 | |
| *** armaan has joined #openstack-swift | 20:35 | |
| *** amrith has quit IRC | 20:35 | |
| *** nikivi has quit IRC | 20:35 | |
| *** csmart has quit IRC | 20:36 | |
| clayg | timburke: yeah PUT/X-Copy-From is definitely following the symlink and ignoring ?symlink=get (unlike COPY where the qs does seem to effect the GET request) | 20:36 |
| *** JimCheung has quit IRC | 20:36 | |
| *** StevenK has quit IRC | 20:36 | |
| *** JimCheung has joined #openstack-swift | 20:37 | |
| clayg | I mean generally speaking it'd be an artifact of the COPY middleware to take the qs from the PUT and add it to the GET request it makes up? is that reasonable? | 20:37 |
| clayg | maybe... depends on how PUT/X-Copy-From works on SLO manifests I guess.. | 20:37 |
| timburke | copy needs to know to throw in the format=raw -- https://github.com/openstack/swift/blob/2.16.0/swift/common/middleware/copy.py#L354-L358 | 20:38 |
| clayg | hrm... looks like there's special handling | 20:38 |
| timburke | and translate the multipart-manifest=get to a multipart-manifest=put -- https://github.com/openstack/swift/blob/2.16.0/swift/common/middleware/copy.py#L441-L449 | 20:39 |
| *** nikivi has joined #openstack-swift | 20:39 | |
| *** ndk_ has joined #openstack-swift | 20:39 | |
| clayg | yeah, that's what i was just reading | 20:39 |
| timburke | but it's relying on the client to ever have the multipart-manifest=get | 20:39 |
| clayg | ok I'll write it up as a failing functest and see what we wanna do | 20:40 |
| clayg | yeah, copy middleware maybe should have similar handling for symlink=get i 'spse | 20:40 |
| timburke | and the COPY handling ultimately punts to the PUT handling -- https://github.com/openstack/swift/blob/2.16.0/swift/common/middleware/copy.py#L344 | 20:40 |
| timburke | it seems bizarre to me that COPY should work but PUT doesn't | 20:40 |
| *** timss has joined #openstack-swift | 20:40 | |
| *** notmyname has joined #openstack-swift | 20:41 | |
| *** ChanServ sets mode: +v notmyname | 20:41 | |
| *** csmart has joined #openstack-swift | 20:41 | |
| clayg | rly? re-write the existing request as a PUT instead of creating a new one | 20:41 |
| timburke | were you including the query param in the PUT url? or the x-copy-from header? | 20:41 |
| clayg | I think that's how my COPY requests qs is keeping around | 20:41 |
| clayg | the PUT url | 20:42 |
| timburke | good... | 20:42 |
| clayg | (can i add it in the *header* !??) | 20:42 |
| timburke | don't think so | 20:42 |
| *** amrith has joined #openstack-swift | 20:43 | |
| *** StevenK has joined #openstack-swift | 20:44 | |
| *** clarkb has quit IRC | 20:45 | |
| *** andymccr has quit IRC | 20:45 | |
| *** jistr has quit IRC | 20:45 | |
| *** jistr has joined #openstack-swift | 20:45 | |
| *** andymccr has joined #openstack-swift | 20:45 | |
| *** clarkb has joined #openstack-swift | 20:45 | |
| *** JimCheung has quit IRC | 20:47 | |
| *** JimCheung has joined #openstack-swift | 20:48 | |
| *** JimCheung has quit IRC | 20:53 | |
| *** JimCheung has joined #openstack-swift | 20:54 | |
| *** JimCheung has quit IRC | 21:03 | |
| *** linkmark has quit IRC | 21:20 | |
| clayg | timburke: thanks for the help - i think i have an idea how it can be fixed - hopefully kota_ and m_kazuhiro will know what to do | 21:22 |
| *** JimCheung has joined #openstack-swift | 21:23 | |
| *** jappleii__ has joined #openstack-swift | 21:23 | |
| *** jappleii__ has quit IRC | 21:24 | |
| *** jappleii__ has joined #openstack-swift | 21:25 | |
| *** jappleii__ has quit IRC | 21:26 | |
| *** jappleii__ has joined #openstack-swift | 21:27 | |
| timburke | clayg: on https://gist.github.com/clayg/95cc8f0ecdbec1ee2c85afa0f134507a -- i don't think setting `source_req.params['symlink'] = 'get'` will do what you think... it's not a proxy into env['QUERY_STRING'] (a la req.headers) -- you gotta do an explicit `source_req.params = ...` to trigger the magic in https://github.com/openstack/swift/blob/2.16.0/swift/common/swob.py#L882-L897 | 21:27 |
| *** jappleii__ has quit IRC | 21:27 | |
| *** jappleii__ has joined #openstack-swift | 21:28 | |
| timburke | (i'm not really happy with that interface... but to make it more like the headers proxy would give the impression that setting params is like setting a dict... which it just *won't be*. QUERY_STRING is a bit of a horrible interface...) | 21:28 |
| *** JimCheung has quit IRC | 21:30 | |
| *** JimCheung has joined #openstack-swift | 21:46 | |
| *** JimCheung has quit IRC | 21:50 | |
| *** rcernin has joined #openstack-swift | 21:58 | |
| *** joeljwright has joined #openstack-swift | 21:59 | |
| *** ChanServ sets mode: +v joeljwright | 21:59 | |
| joeljwright | timburke: you around? | 22:00 |
| timburke | yup | 22:00 |
| joeljwright | I just say notmyname's review of the data segments in SLO patch | 22:01 |
| joeljwright | it looks nice, was just wondering about the current state of the nested SLOs with data segments | 22:01 |
| timburke | should be fine -- i added a func test to cover it in https://review.openstack.org/#/c/365371/37..39/test/functional/test_slo.py | 22:02 |
| patchbot | patch 365371 - swift - Add support for data segments to SLO and Segmented... | 22:02 |
| timburke | (in previous patchsets, it'd 500) | 22:02 |
| joeljwright | okay, cool, I saw the comments and wondered if it was worth testing it | 22:03 |
| joeljwright | thanks so much for keeping this moving! | 22:03 |
| timburke | sure! it's a really cool feature -- i like the possibilities this opens up | 22:04 |
| joeljwright | I'll get on with some more testing in the morning | 22:04 |
| joeljwright | nice to see a +2 on it :) | 22:04 |
| *** flwang has quit IRC | 22:06 | |
| mattoliverau | morning | 22:09 |
| *** flwang has joined #openstack-swift | 22:19 | |
| *** JimCheung has joined #openstack-swift | 22:27 | |
| *** JimCheung has quit IRC | 22:31 | |
| *** JimCheung has joined #openstack-swift | 23:01 | |
| *** armaan has quit IRC | 23:03 | |
| *** armaan has joined #openstack-swift | 23:04 | |
| *** JimCheung has quit IRC | 23:05 | |
| *** JimCheung has joined #openstack-swift | 23:28 | |
| *** chsc has quit IRC | 23:29 | |
| *** kei_yama has joined #openstack-swift | 23:34 | |
| *** JimCheung has quit IRC | 23:34 | |
| *** JimCheung has joined #openstack-swift | 23:34 | |
| *** JimCheung has quit IRC | 23:35 | |
| *** JimCheung has joined #openstack-swift | 23:36 | |
| *** JimCheung has quit IRC | 23:40 | |
| *** edausq has quit IRC | 23:46 | |
| *** m_kazuhiro has joined #openstack-swift | 23:50 | |
| *** shaner has quit IRC | 23:52 | |
| *** shaner has joined #openstack-swift | 23:52 | |
| *** JimCheung has joined #openstack-swift | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!