Monday, 2017-05-01

*** baffle has quit IRC00:25
*** baffle has joined #openstack-swift00:25
*** AndyWojo has quit IRC00:53
mattoliverauMorning01:33
*** mingyu has joined #openstack-swift02:11
kota_good morning02:36
*** psachin has joined #openstack-swift03:09
*** psachin has quit IRC03:13
*** klrmn has quit IRC03:34
*** psachin has joined #openstack-swift03:39
mattoliveraukota_: morning03:44
kota_mattoliverau: o/03:45
*** links has joined #openstack-swift04:12
*** vinsh has joined #openstack-swift04:14
*** vinsh has quit IRC04:14
*** flwang1 has quit IRC05:07
*** mingyu has quit IRC05:26
*** arunman has joined #openstack-swift05:53
*** adriant has quit IRC06:08
*** arunman has quit IRC06:22
*** arunman has joined #openstack-swift06:52
*** tesseract has joined #openstack-swift07:06
*** mingyu has joined #openstack-swift07:07
*** arunman has quit IRC07:10
*** rcernin has joined #openstack-swift07:12
kota_hmmm.... why https://review.openstack.org/#/c/453827 failed, idk07:13
patchbotpatch 453827 - swift - Add CompositeRingBuilder class07:13
kota_that has no message, just said "invocation error" so no hint to me...07:13
kota_let's check also the master07:14
*** rcernin has quit IRC07:32
kota_hmm... the master works07:54
kota_and my rebasing doesn't, so something happens during the changes.07:55
*** mingyu has quit IRC07:55
mattoliverauMaybe just do a recheck and see if it happens again07:56
*** mingyu has joined #openstack-swift07:57
*** SkyRocknRoll has joined #openstack-swift07:57
*** SkyRocknRoll has quit IRC08:00
*** SkyRocknRoll has joined #openstack-swift08:01
*** d0ugal has quit IRC08:07
*** d0ugal has joined #openstack-swift08:08
*** geaaru_ has quit IRC08:09
*** geaaru has joined #openstack-swift08:19
kota_mattoliverau: thx for the suggestion but it happens in my local so that something wrong i think08:22
* kota_ is now doubting `from mock import mock` line in the unit test that looks odd08:23
openstackgerritAlistair Coles proposed openstack/swift master: Fix unit test failing when swift.conf has default policy index >10  https://review.openstack.org/46106208:24
acolesgood morning08:24
kota_acoles: good morning08:25
kota_acoles: thx for fixing a lot for my WIP patch :-D08:26
kota_that is already squashed to the parent08:26
mattoliverauacoles: o/08:26
acoleskota_: your patch was really good, hope it was ok for me to squash it08:27
acolesmattoliverau: o/08:27
kota_acoles: that's cool except it hits an invocation error on unit test. I'm now digging why it happesn08:27
kota_happens08:27
*** arunman has joined #openstack-swift08:28
kota_i think, it's not gate problem because i also have been able to hit it.08:28
acoleskota_: I'm just running locally (although I am sure I would have done that before pushing to gerrit)08:30
kota_acoles: hmm... weird. the invocation error looked to occur the end of unit tests08:32
kota_the log says test.unit.test_locale -> ok so all unit tests inside test/unit runs successfully08:32
acoleskota_: I see it too but I ignored because I had 3 tests fail due to https://review.openstack.org/46106208:34
patchbotpatch 461062 - swift - Fix unit test failing when swift.conf has default ...08:34
* acoles slap self08:34
*** arunman has quit IRC08:39
acolesmattoliverau: if you have chance to revisit it, i now have +2 on https://review.openstack.org/45438608:43
patchbotpatch 454386 - swift - Fix install guide filter:authtoken config example08:43
*** hseipp has joined #openstack-swift08:43
* kota_ has no idea for now how to debug the invocation error because it has no message :/08:48
* kota_ is running the parent patch independently to clarify when it was injected.08:48
kota_it looks like patch set4 ran successfully at the gate but the diff since that not so strange except `from mock import mock`. However, when I fixed that, it still happesn08:50
kota_happens08:50
acolesmattoliverau: thank you!08:52
acoleskota_: more output from 'tox -e py27 --  test.unit.common.ring.test_composite_builder.py'08:53
acoleskota_: I have an idea what the cause is08:53
acolesjust trying a fix08:54
kota_acoles: oh, that enables us to reproduce? I was waiting whole test run with `tox -e py27`08:54
kota_acoles: (because, just `nosetests test/unit/common/ring/test_composite_builder.py` didn't fail)08:55
* kota_ tries08:55
acoleskota_: yep. but the traceback is in coverage08:55
acoles'nosetests ./test/unit/common/ring/test_composite_builder.py --with-coverage' fails08:56
kota_oic08:56
kota_make sense08:57
acoleskota_: I am betting a beer that it is because I chdir to the tempdir here https://github.com/openstack/swift/blob/d079c3d5b3ff3b097fcb1e12cd5e0defa7d69305/test/unit/common/ring/test_composite_builder.py#L490-L49008:57
acoleskota_: yes! it is the chdir08:58
kota_wow, it sounds dengerous :/08:58
*** mingyu has quit IRC08:58
acolesyeah :/08:59
kota_ah, and the coverage cannot report the output on 'current dir' because the tempdir already removed08:59
kota_got it!08:59
acolescrazy09:00
* kota_ is waiting acoles pushed the new version :)09:00
acolesI will09:00
kota_kk, let's leave my comments to the current version now09:00
kota_acoles: the left comments on the patch from my side is for the compose method09:04
kota_acoles: that looks designed for overriding current components in the CompositeRingBuilder. And I'm wondering how it works with the check_against_existing.09:05
kota_i didn't try to check the test and to write some assertions by my self but from my quick view, if overriding with other path, the compose can fail with different components?09:06
kota_so I'm not sure it's for just path change operation or, completly overwriting of components for now.09:07
*** arunman has joined #openstack-swift09:09
kota_let me continue tomorrow09:09
acoleskota_: My intent was to allow builder file paths to be passed in case the paths had changed09:10
acolesor, if with force=True s ome or all of the builders was changing09:10
kota_acoles: so the component contents should not be changed?09:10
acolessome*09:10
acoleskota_: correct, normally09:11
kota_acoles: ok, force=True is same with my thought.09:11
kota_acoles: ok, that's same with my reading for the code.09:11
kota_so it looks correct coding.09:11
kota_acoles: nice :D09:11
acoleskota_: hmmm, but now I can see that the same could be achieved using the set_builders method, so no need for builders arg on compose09:12
acolesset_builder_files*09:12
kota_acoles: maybe09:12
kota_yeah09:12
acolesthat would perhaps make the compose() signature less confusing?09:14
kota_acoles: maybe. and i'd like to add some docs, the components will be still checked even if the builder files changed09:16
*** arunman has quit IRC09:16
acoleskota_: I'll think about it some more and maybe make that change09:16
kota_any of 'override the builder files' sounds to replace every component09:16
acoleskota_: ack re doc09:17
kota_it may be only me though.09:17
kota_acoles: thx!09:17
*** mingyu has joined #openstack-swift09:17
acolessorry for the weird test failures :/09:17
kota_acoles: np09:18
kota_acoles: and fyi, tomorrow is the last *office* day to me before OpenStack Summit because this is a long national holiday week in Japan.09:19
acoleskota_: ok. thanks09:19
kota_acoles: I'm willing to attend the irc meeting Thu in JST morning but my activity will be slow down until the summit.09:19
acoleskota_: sure, enjoy the holiday09:20
kota_thx09:20
acoleskota_: so  *if* we have enough agreement then maybe we could merge the CompositeRingBuilder patch into patch 441921, tomorrow? But I don't want to force it if there are still issues09:22
patchbothttps://review.openstack.org/#/c/441921/ - swift - Add Composite Ring Functionality09:22
*** mingyu has quit IRC09:25
*** SkyRocknRoll has quit IRC09:29
openstackgerritjunboli proposed openstack/swift master: Tests: Use the recommended assertions  https://review.openstack.org/44907709:59
kota_acoles: maybe we can, maybe can't. I'll try to make me to do that.10:08
openstackgerritMerged openstack/swift master: Fix install guide filter:authtoken config example  https://review.openstack.org/45438610:17
*** hseipp has quit IRC10:18
*** mingyu has joined #openstack-swift10:19
*** flwang1 has joined #openstack-swift10:25
*** mingyu has quit IRC10:40
openstackgerritjunboli proposed openstack/swift master: Remove the unused import code  https://review.openstack.org/46136010:47
*** chlong has joined #openstack-swift11:07
*** silor has joined #openstack-swift11:22
*** mingyu has joined #openstack-swift11:34
*** mingyu has quit IRC11:45
*** mvk has quit IRC11:46
openstackgerritjunboli proposed openstack/swift master: Tests: Use the recommended assertions  https://review.openstack.org/44907711:47
*** mingyu has joined #openstack-swift11:54
*** mvk has joined #openstack-swift12:04
*** mingyu has quit IRC12:11
*** gkadam has joined #openstack-swift12:13
*** klamath has joined #openstack-swift12:14
*** klamath has joined #openstack-swift12:14
*** gkadam has quit IRC12:39
*** mingyu has joined #openstack-swift12:45
*** mingyu has quit IRC12:46
*** mingyu has joined #openstack-swift12:46
*** arunman has joined #openstack-swift12:59
*** arunman has quit IRC13:11
*** gkadam has joined #openstack-swift13:11
*** arunman has joined #openstack-swift13:16
*** arunman has quit IRC13:17
*** hoonetorg has quit IRC13:19
*** hoonetorg has joined #openstack-swift13:20
openstackgerritAlistair Coles proposed openstack/swift master: Experimental swift-ring-composer CLI to build composite rings  https://review.openstack.org/45150713:24
openstackgerritAlistair Coles proposed openstack/swift master: Add composite ring doc  https://review.openstack.org/45150013:24
openstackgerritAlistair Coles proposed openstack/swift master: Add CompositeRingBuilder class  https://review.openstack.org/45382713:24
*** mingyu has quit IRC13:26
openstackgerritOpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements  https://review.openstack.org/8873613:28
*** links has quit IRC13:29
*** mingyu has joined #openstack-swift13:32
*** mingyu has quit IRC13:36
*** arunman has joined #openstack-swift13:41
*** mingyu has joined #openstack-swift14:10
*** SkyRocknRoll has joined #openstack-swift14:11
*** gkadam has quit IRC14:12
*** mingyu has quit IRC14:15
*** mingyu has joined #openstack-swift14:15
*** SkyRocknRoll has quit IRC14:22
*** SkyRocknRoll has joined #openstack-swift14:24
*** oshritf has joined #openstack-swift14:25
*** catintheroof has joined #openstack-swift14:30
*** catintheroof has quit IRC14:36
*** catintheroof has joined #openstack-swift14:40
*** oshritf has quit IRC14:40
*** catintheroof has quit IRC14:42
*** arunman has quit IRC14:44
*** SkyRocknRoll has quit IRC14:44
*** peterlisak has quit IRC14:45
*** peterlisak has joined #openstack-swift14:46
*** vinsh has joined #openstack-swift14:57
*** vinsh_ has joined #openstack-swift14:59
*** vinsh has quit IRC15:00
*** links has joined #openstack-swift15:13
*** links has quit IRC15:17
*** arunman has joined #openstack-swift15:22
*** arunman has quit IRC15:25
*** arunman has joined #openstack-swift15:28
*** arunman has quit IRC15:31
*** arunman has joined #openstack-swift15:48
*** gyee has joined #openstack-swift16:00
*** Sukhdev has joined #openstack-swift16:00
*** arunman has quit IRC16:09
*** Sukhdev has quit IRC16:14
notmynamegood morning16:16
*** tesseract has quit IRC16:29
*** hseipp has joined #openstack-swift16:29
*** openstack has joined #openstack-swift17:00
*** openstack has joined #openstack-swift17:23
*** tonanhngo has joined #openstack-swift17:24
*** psachin has quit IRC17:25
*** tonanhngo_ has joined #openstack-swift17:27
*** tonanhngo has quit IRC17:29
*** tonanhngo_ has quit IRC17:29
notmynameFYI there are three interesting governance patches that will be discussed in tomorrow's tc meeting. here's a summary of each...17:30
notmynamepatch 459848 proposes dropping the TC meetings entirely and moving to ad-hoc discussions in #openstack-dev17:30
notmynamepatch 460946 proposes a new principle that no decisions should be made in a synchronous way (eg in a meeting). instead, decisions should be made in an async way, and the patch suggests using gerrit and the ML for that17:30
notmynamepatch 460951 proposes redefining the current pike goal of using mod_wsgi. The proposal is to change to using uWSGI instead. The patch claims this will be much easier on projects17:30
patchbothttps://review.openstack.org/#/c/459848/ - governance - Drop Technical Committee meetings17:30
patchbothttps://review.openstack.org/#/c/460946/ - governance - Do not make decisions using synchronous communication17:30
patchbothttps://review.openstack.org/#/c/460951/ - governance - Change the target for this goal to uWSGI not Apach...17:30
*** tonanhngo has joined #openstack-swift17:32
*** tongli has quit IRC17:41
timburkeacoles: ok, one more idea on that patch: rather than having expected_headers and unexpected_headers, what about *just* having expected_headers, and anything *not* there is automatically unexpected? http://paste.openstack.org/show/608537/17:43
acolestimburke: that might be too brittle - someone might run func tests against a cluster with custom middleware that adds a header we don't know about?17:47
timburkehmmm... i've just got a feeling like there are probably *other* headers we want to be sure to not find, only we haven't even realized it yet...17:49
*** silor has joined #openstack-swift17:52
timburkePragma, say, or Upgrade17:55
*** chsc has joined #openstack-swift18:05
*** chsc has joined #openstack-swift18:05
*** tdasilva has joined #openstack-swift18:07
*** openstackstatus has joined #openstack-swift18:15
*** ChanServ sets mode: +v openstackstatus18:15
notmynamerledisez: here?18:15
*** mingyu has quit IRC18:15
notmynameI have (tentatively?) scheduled an additional 2 hours for the swift team in room 109 next wednesday from 10:30 to 12:30. This is in addition to our existing 2:20 time block on tuesday.18:19
tdasilvanotmyname: do you have a link to the final forum schedule handy?18:21
notmynameunfortunately, this conflicts with the OVH conference talk on small file optimization (rledisez), but it's the largest block of time that's non-conflicting as possible i could find18:21
notmynameyes.18:21
notmynamehttps://ethercalc.openstack.org/Boston_Forum_Hacking_Rooms18:21
notmynamethat link is for the reservable rooms18:21
notmynamethe final schedule for the forum is what's on https://www.openstack.org/summit/boston-2017/summit-schedule/18:22
*** xinli has joined #openstack-swift18:42
rledisezhi notmyname, the losf talk is not an OVH talk. it's a guy from iqiyi that does the same kind of work, but on hummingbird. i exchanged mail with him and i'm hoping to meet him in boston18:54
notmynameoh right!18:55
rledisezwell, i'll try to arrange between that time slot you got and his talk18:56
notmynameI just saw LOSF and put it in the " rledisez will save us" bucket :-)18:56
rledisezwill save us *one day* :)18:56
notmynamerledisez: yeah, I think there will be some conflict for most days of the week where some poeple willneed to step out for some amount of time18:56
openstackgerritTim Burke proposed openstack/swift master: Always check for unexected requests in mocked_http_conn  https://review.openstack.org/46148319:07
*** silor has quit IRC19:40
*** mingyu has joined #openstack-swift20:04
*** mingyu has quit IRC20:08
*** klamath has quit IRC20:08
*** xinli has quit IRC20:29
*** flwang1 has quit IRC20:32
openstackgerritMerged openstack/swift master: Do not sync suffixes when remote rejects reconstructor revert  https://review.openstack.org/43515220:38
openstackgerritOpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements  https://review.openstack.org/8873620:41
*** klamath has joined #openstack-swift21:02
*** Sukhdev_ has joined #openstack-swift21:08
*** flwang1 has joined #openstack-swift21:30
*** adriant has joined #openstack-swift21:37
*** geaaru has quit IRC21:45
*** catintheroof has joined #openstack-swift21:50
openstackgerritTim Burke proposed openstack/swift master: Always check for unexected requests in mocked_http_conn  https://review.openstack.org/46148322:12
*** klamath has quit IRC22:34
*** catintheroof has quit IRC22:39
*** tonanhngo has quit IRC22:41
*** tonanhngo has joined #openstack-swift22:42
*** tonanhngo_ has joined #openstack-swift22:45
*** tonanhngo has quit IRC22:46
*** tonanhngo_ has quit IRC22:50
*** chsc has quit IRC23:37
*** jamielennox is now known as jamielennox|away23:56
*** jamielennox|away is now known as jamielennox23:58
mattoliverauMorning23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!