Tuesday, 2016-10-11

*** jamielennox is now known as jamielennox|away00:30
*** jamielennox|away is now known as jamielennox00:48
kota_good morning01:03
* kota_ is back from long weekend due to Japanese holiday.01:04
mattoliveraukota_: morning, and welcome back :)01:13
kota_mattolivaeru: o/01:14
*** klrmn has quit IRC01:15
*** takashi has joined #openstack-swift01:18
*** Jeffrey4l has joined #openstack-swift01:21
*** Jeffrey4l has quit IRC01:22
*** Jeffrey4l has joined #openstack-swift01:23
*** Jeffrey4l has quit IRC01:24
*** Jeffrey4l has joined #openstack-swift01:25
*** Jeffrey4l has quit IRC01:26
*** Jeffrey4l has joined #openstack-swift01:26
*** Jeffrey4l_ has joined #openstack-swift01:54
*** Jeffrey4l has quit IRC01:57
*** tqtran has quit IRC02:01
*** yarkot has joined #openstack-swift02:03
*** takashi has quit IRC02:06
*** jcook has quit IRC02:08
*** jcook has joined #openstack-swift02:13
openstackgerritHanxi Liu proposed openstack/swift: Add links to more detailed overview in overview_architecture  https://review.openstack.org/38144602:20
*** klrmn has joined #openstack-swift02:30
-openstackstatus- NOTICE: Jobs running on osic nodes are failing due to network issues with the mirror. We are temporarily disabling the cloud.02:49
*** lhx_ has joined #openstack-swift03:13
openstackgerritHanxi Liu proposed openstack/swift: Add links to more detailed overview in overview_architecture  https://review.openstack.org/38144603:23
*** psachin has joined #openstack-swift03:40
*** vern has quit IRC03:57
claygtimburke: Do you know Jamie Lennox?  Is he helping us with keystone sessions work?  Do you have any experience with requests-mock?  Could you splash a little water on patch 360298 - i'm worried I may have un-intentionally been a little thorny04:00
patchbothttps://review.openstack.org/#/c/360298/ - python-swiftclient - Use requests_mock and oslotest04:00
*** links has joined #openstack-swift04:01
*** vern has joined #openstack-swift04:17
*** vern has quit IRC04:24
openstackgerritMerged openstack/swift: add assert error information  https://review.openstack.org/37942804:45
*** tqtran has joined #openstack-swift04:57
*** tqtran has quit IRC05:03
*** lhx_ has quit IRC05:05
*** lhx_ has joined #openstack-swift05:11
*** d0ugal has quit IRC05:40
*** d0ugal has joined #openstack-swift05:41
*** takashi has joined #openstack-swift05:51
*** qwertyco has joined #openstack-swift06:00
*** qwertyco has quit IRC06:01
*** qwertyco has joined #openstack-swift06:02
*** lhx_ has quit IRC06:06
*** rcernin has joined #openstack-swift06:07
*** vern has joined #openstack-swift06:17
*** klrmn has quit IRC06:18
*** bjolo_ has joined #openstack-swift06:21
*** lhx_ has joined #openstack-swift06:26
*** vern has quit IRC06:26
*** pcaruana has joined #openstack-swift06:36
*** vern has joined #openstack-swift06:52
*** Vinsh has quit IRC07:02
*** Vinsh has joined #openstack-swift07:03
*** rledisez has joined #openstack-swift07:28
*** takashi has quit IRC07:38
*** amoralej|off is now known as amoralej07:39
*** qwertyco has quit IRC07:39
*** takashi has joined #openstack-swift07:40
*** hogepodge has quit IRC07:51
*** Vinsh has quit IRC07:52
*** acoles_ is now known as acoles07:54
acolesgoo dmorning07:56
*** geaaru has joined #openstack-swift07:57
*** hogepodge has joined #openstack-swift07:58
*** zaitcev has quit IRC07:58
*** acoles is now known as acoles_08:00
*** zaitcev has joined #openstack-swift08:16
*** ChanServ sets mode: +v zaitcev08:16
kota_good morning acoles08:20
kota_acoles: thanks for pinging me sometimes in the back log. I was in long weekend (and actually down wiht cold). I'm trying to open it step by step.08:22
*** jordanP has joined #openstack-swift08:22
*** admin6_ has joined #openstack-swift08:27
*** natarej has joined #openstack-swift08:31
*** acoles_ is now known as acoles08:35
*** jeblair_ has joined #openstack-swift08:36
*** mahatic_ has joined #openstack-swift08:36
*** clayg_ has joined #openstack-swift08:36
*** ChanServ sets mode: +v clayg_08:36
*** dosaboy_ has joined #openstack-swift08:37
*** early has joined #openstack-swift08:38
*** mmotiani has joined #openstack-swift08:38
*** swifterdarrell_ has joined #openstack-swift08:39
*** amoralej_ has joined #openstack-swift08:40
*** jraju has joined #openstack-swift08:40
*** vern has quit IRC08:41
*** links has quit IRC08:41
*** yarkot has quit IRC08:41
*** hoonetorg has quit IRC08:41
*** amoralej has quit IRC08:41
*** peterlisak has quit IRC08:41
*** clayg has quit IRC08:41
*** early` has quit IRC08:41
*** zackmdavis has quit IRC08:41
*** amit213 has quit IRC08:41
*** ogelbukh has quit IRC08:41
*** ediardo has quit IRC08:41
*** nottrobin has quit IRC08:41
*** wasmum has quit IRC08:41
*** fungi has quit IRC08:41
*** zacksh has quit IRC08:41
*** sudorandom has quit IRC08:41
*** charz has quit IRC08:41
*** swifterdarrell has quit IRC08:41
*** a1|away has quit IRC08:41
*** mahatic has quit IRC08:41
*** jeblair has quit IRC08:41
*** dosaboy has quit IRC08:41
*** onovy has quit IRC08:41
*** swifterdarrell_ is now known as swifterdarrell08:41
*** amoralej_ is now known as amoralej08:41
*** charz has joined #openstack-swift08:41
*** zackmdavis has joined #openstack-swift08:42
*** yarkot has joined #openstack-swift08:42
*** a1|away has joined #openstack-swift08:44
*** hoonetorg has joined #openstack-swift08:45
*** vern has joined #openstack-swift08:49
*** peterlisak has joined #openstack-swift08:49
*** amit213 has joined #openstack-swift08:49
*** ogelbukh has joined #openstack-swift08:49
*** ediardo has joined #openstack-swift08:49
*** nottrobin has joined #openstack-swift08:49
*** wasmum has joined #openstack-swift08:49
*** fungi has joined #openstack-swift08:49
*** zacksh has joined #openstack-swift08:49
*** sudorandom has joined #openstack-swift08:49
*** onovy has joined #openstack-swift08:49
*** ogelbukh has quit IRC08:52
*** ogelbukh has joined #openstack-swift08:56
*** takashi has quit IRC09:01
*** admin6 has quit IRC09:08
*** admin6_ is now known as admin609:08
*** admin6_ has joined #openstack-swift09:13
*** admin6_ has left #openstack-swift09:14
*** admin6 has quit IRC09:15
*** admin6_ has joined #openstack-swift09:15
*** vern has quit IRC09:24
*** tanee_ is now known as tanee09:26
*** openstack has joined #openstack-swift09:31
*** onovy has joined #openstack-swift09:38
*** peterlisak has joined #openstack-swift09:38
*** VonGoofy has joined #openstack-swift09:54
VonGoofyHello09:54
VonGoofyProblem09:54
VonGoofy I have a problem with swift. I have added x-object-account metadata to my swift account, deleted it because it had space in it, so it was invalid, and now I can't add the metadata to account anymore. Doing this via object storage API.09:54
VonGoofyI get 204 response on my metadata POST request, issue show metadata, metadata is not there09:55
VonGoofyhelp? anyone?10:00
*** VonGoofy has quit IRC10:02
*** kodokuu has joined #openstack-swift10:03
*** Vinsh has joined #openstack-swift10:04
kodokuuHi, anyone have a script for GET all DATA in swift ?? I create a new platform and we need to transfer all data to the new swift .10:04
*** VonGoofy has joined #openstack-swift10:09
VonGoofyif anyone knows why I cant inject metadata definitions to the account that would be helpful. I'm trying to add X-Account-Temp-URL-Key10:10
*** jraju has quit IRC10:15
*** tanee is now known as tanee_away10:17
*** bjolo_ has quit IRC10:18
*** tqtran has joined #openstack-swift10:20
*** tqtran has quit IRC10:24
*** mvk has quit IRC10:30
VonGoofyAnyone?10:32
*** dfflanders has quit IRC10:37
acolesVonGoofy: temp url key metadata starts with X-Account-Meta- see http://docs.openstack.org/developer/swift/api/temporary_url_middleware.html#secret-keys10:44
VonGoofyyes I know10:50
VonGoofyI cannot set this X-Account-Meta-Temp-URL-Key, nor this X-Container-Meta-Temp-URL-Key10:50
VonGoofyI had a typo in my previous post10:51
VonGoofyAny other metadata definition I can set10:51
*** mvk has joined #openstack-swift11:01
*** links has joined #openstack-swift11:09
*** qwertyco has joined #openstack-swift11:12
*** thebloggu has joined #openstack-swift11:15
*** qwertyco has quit IRC11:15
*** qwertyco has joined #openstack-swift11:16
*** etienneme has quit IRC11:32
*** jamielennox is now known as jamielennox|away11:36
*** nikivi has joined #openstack-swift11:43
acolesVonGoofy: sorry, been away. so using the swiftclient, I can do 'swift post -H "x-account-meta-tempurl-key:foo"' and then 'swift stat' will show me the Tempurl-Key11:45
VonGoofyI got it why it's not showing through api. Because those are secret metadata keys and won't show for other users11:47
VonGoofyonly to owners of swift and if it's set in the prox-server.conf11:47
*** openstackgerrit has quit IRC11:48
*** openstackgerrit has joined #openstack-swift11:49
VonGoofyacoles: Now I'm fighting with a post form and how to upload files from remote website11:50
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873612:07
*** thebloggu has quit IRC12:16
*** openstackgerrit has quit IRC12:18
*** openstackgerrit has joined #openstack-swift12:18
*** amoralej is now known as amoralej|lunch12:23
*** admin6_ has quit IRC12:25
*** admin6 has joined #openstack-swift12:25
*** bjolo_ has joined #openstack-swift12:27
*** qwertyco has quit IRC12:50
VonGoofyIs there any example on how to upload files through browser remotely? using signed forms not username/password/token. Form post doesn't work for me for some reason. It only changes metadata12:51
*** kei_yama has quit IRC12:52
*** lhx_ has quit IRC13:11
*** kodokuu has quit IRC13:17
*** StraubTW has joined #openstack-swift13:24
*** amoralej|lunch is now known as amoralej13:33
*** lhx_ has joined #openstack-swift13:36
*** VonGoofy has quit IRC13:42
*** StraubTW_ has joined #openstack-swift13:46
*** StraubTW has quit IRC13:50
*** rcernin has quit IRC14:07
acolestdasilva: hi. re your comment here https://review.openstack.org/#/c/355958/5/test/probe/test_reconstructor_durable.py, I had same thought - I think the test isn't doing what the comment suggests. But I thought it could be fixed separately to keep this patch simpler. what do you think?14:23
patchbotpatch 355958 - swift - EC - eliminate .durable files14:23
*** bjolo_ has quit IRC14:28
*** sgundur has joined #openstack-swift14:34
*** _JZ_ has joined #openstack-swift14:54
*** klrmn has joined #openstack-swift15:09
*** psachin has quit IRC15:17
*** sgundur has quit IRC15:19
*** jistr is now known as jistr|biab15:25
*** sgundur has joined #openstack-swift15:30
*** pcaruana has quit IRC15:31
tdasilvaacoles: agree, I can submit that as a follow-up patch, what do you think?15:37
tdasilvaacoles: I was also going to take a look at the other probe tests to see if actual data reconstruction is being tested the same way15:38
tdasilvaacoles: looks like it is15:39
tdasilvaacoles: https://github.com/openstack/swift/blob/master/test/probe/test_reconstructor_rebuild.py#L9215:39
acolestdasilva: that would be great since you have already started a patch (your paste)15:46
acolestdasilva: that test ^^ you link to looks ok, I think?15:47
acolestdasilva: although it does look like there is some repeated code wrt the one I fixed15:47
acolestdasilva: yesterday I searched for all occurrences of '.durable' in the code paste and stepped through them all to be sure they were appropriate (basically, legacy testing)15:48
tdasilvaacoles: sorry, the link above is not really about the .durable issue, it's more about the issue I brought up about how the test is written15:49
*** sgundur has quit IRC15:49
tdasilvaacoles: it's following the same pattern as the .durable tests, but for the actual data file15:49
*** geaaru has quit IRC15:50
tdasilvayou can see in lines 155-157, it builds the lists of nodes to delete data from, but then it deletes and reconstructs each node individually15:50
*** nikivi has quit IRC15:50
*** sgundur has joined #openstack-swift15:51
acolestdasilva: oic sorry, yes that issue, how it just iterates over the list of lists but only ever breaks one node at a time.15:52
tdasilvaacoles: right15:53
tdasilvaacoles: so in the new patch i will fix both and look for more15:53
acolestdasilva: feels like there could be a common pattern between the two tests, break the *list* of nodes, run reconstructor, validate, where definition of 'break' differs between tests15:53
acolestda great, thanks!15:54
acolestdasilva: ^^15:54
*** links has quit IRC15:54
tdasilvaacoles: right :)15:54
*** chsc has joined #openstack-swift15:58
*** chsc has joined #openstack-swift15:58
*** donagh has quit IRC16:03
*** jistr|biab is now known as jistr16:07
*** chsc has quit IRC16:12
openstackgerritCheng Li proposed openstack/swift: add check of min_part_hours  https://review.openstack.org/34552416:14
*** acoles is now known as acoles_16:15
*** acoles_ is now known as acoles16:17
*** acoles is now known as acoles_16:17
*** acoles_ is now known as acoles16:18
*** sgundur has quit IRC16:24
brianclinewhat's the history behind the object controller's x-container-{partition,host,device} headers being more authoritative than an object server doing an in-memory lookup of the same info?16:24
*** sgundur has joined #openstack-swift16:24
brianclinetraced it back to the initial commit16:25
*** tongli has joined #openstack-swift16:27
*** hoonetorg has quit IRC16:35
*** lhx_ has quit IRC16:37
*** rledisez has quit IRC16:47
*** hoonetorg has joined #openstack-swift16:48
*** sgundur has quit IRC16:48
*** sgundur has joined #openstack-swift16:58
notmynamegood morning17:00
*** chsc has joined #openstack-swift17:01
tdasilvaacoles: just realized you already wrote some of the tests I was thinking about here: https://review.openstack.org/#/c/376630/17:03
patchbotpatch 376630 - swift - EC: reconstruct using non-durable fragments17:03
tdasilvaacoles: nice!!!!17:03
*** tongli has quit IRC17:04
*** tqtran has joined #openstack-swift17:11
acolestdasilva: oh yeah, I had forgotten that! so break_nodes there is a multipurpose tool to set up some broken state across the nodes.17:27
acoleshuh.17:27
tdasilvaacoles: yep! we could probably even get rid of the check_nodes method, it seems to be trying to do similar work17:28
*** sgundur has quit IRC17:36
*** sgundur has joined #openstack-swift17:37
*** vint_bra has joined #openstack-swift17:42
*** vint_bra has quit IRC17:42
*** vint_bra has joined #openstack-swift17:44
*** amoralej is now known as amoralej|off17:59
*** jordanP has quit IRC17:59
timurzaitcev: no, that's a different timur18:04
zaitcevtimur: sorry18:04
timurno worries18:04
*** mvk has quit IRC18:04
*** jamielennox|away is now known as jamielennox18:10
*** bjolo_ has joined #openstack-swift18:11
*** sgundur has quit IRC18:12
clayg_tdasilva: is https://github.com/dtantsur/ironic-bug-dashboard the dashboard thing you were adapting to run on swit?18:19
*** clayg_ is now known as clayg18:19
claygdid you see the ironic subteam update - it had some bug stats - week deltas - pretty interesting!18:19
tdasilvaclayg: no, i forked off a project from the fuel team: https://github.com/thiagodasilva/launchpad-reporting18:20
tdasilvabut will take a look18:20
tdasilvaclayg: just found the update email, yeah, they seem to keep a very updated delta18:25
tdasilvaclayg: it looks like they have a process for staying on top of (initial) bug triaging: https://bugs.launchpad.net/ironic\18:26
tdasilvayou can see they have very few "Undecided"18:26
*** vint_bra has quit IRC18:26
*** vint_bra has joined #openstack-swift18:26
claygtdasilva: I like that18:29
*** hoonetorg has quit IRC18:35
*** sgundur has joined #openstack-swift18:36
tdasilvanotmyname: there's been a lot of emails on the ML about the PTG (e.g., 'Sahara PTG plans') and I was wondering where that is coming from? just wondering if we are supposed to be telling somebody else we are planning to be there...18:37
tdasilvanotmyname: if you already took care of that sorry for the nosie18:37
notmynametdasilva: I've got some notes I'm working on similar to "here's what we've done that works, and we'll do something similar at the PTG"18:37
tdasilvanotmyname: cool, it's a bit weird that this conversation is coming up before barca, but it is probably due to the very short release cycle18:38
*** sgundur has quit IRC18:43
*** sgundur has joined #openstack-swift18:48
*** hoonetorg has joined #openstack-swift18:50
*** ppalacios has joined #openstack-swift18:52
ppalaciosdoes anyone know if it is possible to change etag header on swift object operations to use sha256 instead of md5?18:54
claygi know that is is not18:54
notmynameno. but you can add your own hash to your own key name. like x-object-meta-better-etag18:54
claygnotmyname: oh that's a good idea18:54
tdasilvabut it won't be "verified" by the swift cluster, like it is for the etag18:55
zaitcevYeah, that. But you can't know if it's stored correctly.18:55
zaitcevWell, I meant the value that PUT returns18:55
zaitcevppalacios: So, was there ever a problem with using MD5 or you're just curious?18:56
claygzaitcev: custom middleware to avlidate x-object-meta-better-etag?18:56
zaitcevclayg: maybe18:57
ppalaciostdasilva: so is there no option to change how swift verifies it?18:57
claygi honestly would *love* to see a discussion about ehancing the content verification system to support other algorithms besides md5 - specifically i'm interested in crc instead of expensive stuff like md5 and sha - but if other pople have cpu cycles to burn I'm done18:57
pdardeau^ +118:58
clayg... http doesn't care at all about the content of etag - just that it does a good job at indicating same-ness from one request to the next18:58
notmynameclayg: yeah, md5 is like the worst possible thing. not good enough for any crypto checks and there are so many much faster ones out there for bit flip checks18:58
tdasilvappalacios: i was saying the same thing as zaitcev said and was thinking that the same solution would be what clayg said ;)18:58
clayglol18:58
claygso we're all thinking about and no one is working on it18:59
ppalacioszaitcev: not really, it is just we have a project where we use sha256 to make this verification, so we would like to not waste it.18:59
claygi've seen apis that say something like 'x-etag-value-algorithm' and there's some set of supported values19:00
tdasilvaclayg: any idea why the "industry" settled as md5 and sha as the default? i'm thinking of all the websites that provide downloads and checksums for people to verify19:01
notmynametorgomatic worked on a patch a long time ago that let the algo be selectable19:01
openstackgerritMerged openstack/swift: updated output for swift stat  https://review.openstack.org/37194419:01
claygnotmyname: I think that was for ring hash19:01
notmynametdasilva: widely available + decent crypto (at the time) + fast enough19:01
claygtdasilva: swift used md5 cause we were already using it other places - crc is far less suitable for spreading things out evenly - which is why md5 was choosen and also why it's slower than crc19:02
notmynamealso, built into python (no no new dependencies for stuff like murmur)19:03
* tdasilva nods19:03
notmynamealso, remember swift came from an existing system which used md5 and was written circa 2008. so here we are19:04
tdasilvappalacios: so you already have the shas calculated when you are uploading the objects to swift?19:04
notmynamewe should have used a Content-Md5 header and then been free to change etag to be whatever we wanted (as long as it was stable)19:05
notmynamethat's what 6-8 years of experience gets you, i guess ;-)19:05
ppalaciostdasilva: in fact, we already have an infrastructure that uses sha256. We are migrating this infrastructure to use swift as storage and it will be very strange to calculate MD5 and sha256 to feed swift and this structure.19:10
* tdasilva just realized that hummingbird is also pretty hardcoded to use md5 for etag19:12
hurricanerixnotmyname you could add Content-Md5 to the v2 docs, and maybe some day there will be enough stuff there for people to want a v2.19:13
hurricanerixor maybe it is there already, can't remember...19:13
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873619:16
clayghurricanerix: yeah I don't see much other option beyond v219:19
*** bjolo_ has quit IRC19:22
hurricanerixclayg yeah, i still think v2 could be a good thing allowing stuff to be simplified and made more consistent.  but i don't think many people have shared that opinion (at least to the extent where they thought it was worth developing it).19:22
openstackgerritOndřej Nový proposed openstack/swift: Apply bash error handling consistently in all bash scripts  https://review.openstack.org/35702519:42
onovyclayg: hi, maybe we can continue discussion here? ^^19:43
*** sgundur has quit IRC19:45
onovynotmyname: hi, can anyone look to https://review.openstack.org/#/c/240726/ pls? ~5 weeks without reply :/19:47
patchbotpatch 240726 - swift - Respect server type for --md5 check in swift-recon19:47
*** sgundur has joined #openstack-swift19:50
claygonovy: yeah!19:53
claygonovy: so honestly on resetswift I'm not sure I disagree - thank you for offering your counter point19:53
claygin truth it won't effect my workflow - i use vsaio and it has it own method for doing a reset -> https://github.com/swiftstack/vagrant-swift-all-in-one/blob/master/bin/resetswift19:54
onovyhmhmm19:54
claygonovy: my assumption is that `resetswift && resetswift` would exit 0 because the point should be - it reset - if the second one fails because swift is already stopped or something....19:55
onovyit swift is already stopped, resetswift should return 019:55
claygonovy: cool, i'm not sure if any of the other reset behaviors would have the property of failing if it's not already cleared up19:56
claygI could also imagine that my data file system got unmounted for some point - and I'm not sure if unmount would exit because... it's already unmounted?19:56
onovyhmm. if swift is stopped, swift-init all stop returns 019:56
claygthat sort of thing19:56
onovysry returns 119:56
onovywhich is wrong19:56
claygyeah - i think that's not uncommon - oh rly?19:56
onovyswift-init all kill19:57
onovy            kill: stop a server (no error if not running)19:57
onovyso i will change it to "kill"19:57
claygonovy: what amount unmount?19:57
claygshould it be unmount || true?19:57
onovygood question19:57
claygthe ideal would say unmount if mounted but the point is - make it be not mounted19:57
onovy3219:57
*** vint_bra has quit IRC19:57
clayg:\19:58
onovyso wrong too19:58
onovyso i will change it to kill + unmount if mounted19:58
onovyso unmount of unmounted = return 019:58
claygmaybe this is a systemd thing? I would have *swore* i've had the experience with provisioning automation that if you try to call stop and the service is already stopped it exits 1 (not just swift-init; i'm sure it's behavior was modeled after some /etc/init.d script) - same for start when already running19:59
claygbut on my current xenial/systemd build it's all stop stop stop stop = 0 0 0 020:00
clayg^ does that sound right to everyone?20:00
onovysysv init scripts returns 0, if you try to stop already stopped service20:00
clayghrm... so i'm misremembering20:00
onovymmnt i will check20:00
ahalei just remember swift-init having weird unexpected return codes for some stuff, years ago20:01
claygahale: and you filed the bug.... where?  :P20:01
*** vint_bra has joined #openstack-swift20:01
ahalei was naive and tried to submit a patch, then realised the horrors inside swift-init and ran away20:02
claygahale: good call there20:02
ahalehttps://bugs.launchpad.net/swift/+bug/92052020:02
openstackLaunchpad bug 920520 in OpenStack Object Storage (swift) "swift-init reload/restart inconsistencies" [Undecided,Invalid]20:02
ahale!20:02
* clayg hugs ahale20:05
claygwhat... why's it invalid?20:05
onovywhat about: if grep -qs '/mnt/foo' /proc/mounts; then umount20:05
ahaleno idea really, maybe something changed20:06
claygonovy: seems reasonable - i'll try to make a cursory validation that `resetswift && resetswift` works once OMM and call it good enough20:08
claygbecause of the way we build saio's it's not very likely to break someone unless they actively recopy the new scirpts into the $PATH20:08
*** sgundur has quit IRC20:10
onovyclayg: in progress20:11
claygonovy: regarding .functests and .probetests and consistency -> http://redsymbol.net/articles/unofficial-bash-strict-mode/#expect-nonzero-exit-status20:12
claygthe unofficial bash strict mode is a good reminder that a) bash is trying to make your life difficult at every possible turn b) if you're trying to write bash you are either lazy or doing it wrong20:13
clayg... lazy isn't so bad tho really - it's just lazy - lazy is good sometimes20:13
claygunless the effort you have to put into defeats the point of being lazy in the first place20:13
*** sgundur has joined #openstack-swift20:14
onovyyep. so that's reason why i'm not using set -e in .functests :]20:14
patchbotError: Spurious "]".  You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands.20:14
openstackgerritOndřej Nový proposed openstack/swift: Apply bash error handling consistently in all bash scripts  https://review.openstack.org/35702520:14
claygonovy: well except I think it'd be more reasonable to just wrap the command you expect to generate the useful non-zero exit code and let the set -e do it's job?20:15
claygor "just as reasonable"20:15
clayg... maybe more - see I've already thought about it to much ;)20:15
onovyso i will enable "set -e", and only command which can fail i will override with ||20:16
claygonovy: i'm not sure - don't put to much faith into me - i'm actively anti bash20:16
onovyoverengineering? :)20:17
claygi know... see that's my point :'(  i'm so sorry - use your best judgement20:17
onovyso i think i fixed resetswift now - never fail if already reseted and i will keep .functests this way. we can change it later :)20:19
claygis patch 3 the latest one you'd like me to opine on?20:19
*** gyee has joined #openstack-swift20:19
onovyyep20:19
claygonovy: awesome - thanks for pining me in here!20:19
onovythanks too20:19
timburkeso i was looking at the pyeclib memory leak that kota pointed out (as a bit of an aside) in bug 163114420:25
openstackbug 1631144 in OpenStack Object Storage (swift) "Swift Erasure Coding : Error when decoding fragment" [High,Confirmed] https://launchpad.net/bugs/163114420:25
timburkeand trying to wrap my head around reference ownership, the nuances of the various Py*_SetItem functions and how they relate to ownership, and what all needs a Py_XDECREF in https://github.com/openstack/pyeclib/blob/1.3.1/src/c/pyeclib_c/pyeclib_c.c#L1030-L109420:25
timburkewhen i came across this snippet from https://docs.python.org/2/c-api/intro.html#reference-count-details : "However, in practice, you will rarely use these ways of creating and populating a tuple or list. There’s a generic function, Py_BuildValue(), that can create most common objects from C values, directed by a format string."20:25
timburkeso... does anyone know why we don't just use that?20:25
claygonovy: find: ‘/var/log/swift’: No such file or directory20:25
claygthere's a bit about "remove the following line if you didn't setup rsyslog ...." something?20:26
onovy# Remove the following line if you did not set up rsyslog for individual logging20:26
onovyso remove that line, if you did not setup resyslog for logging in this directory :)20:26
claygso but ... i mean if everyone is just writing/editing this script/template to suit their own needs?20:27
onovyyep, you should edit this script if you don't follow SAIO docs completly20:28
claygtimburke: you could try to email tushar and kevin - but I'm guessing if works and simplifies things it would be acceptable?20:28
brianclinedoes the use of x-container-{partition,host,device} maybe have to do with race conditions between ring changes and object-updater?20:31
claygbriancline: I think it's mostly because object servers's don't have container rings loaded in memory20:31
brianclineorly20:32
claygbriancline: I think they could do the hash calculation and figure the partition from the container name - but they don't even validate the partition in the object request matches the name - they do whatever the proxy tells it20:32
claygif the proxy didn't send the host & device - it'd have to look it up in the ring - and then also figure out some deterministic pattern to decide *which* of thoe nodes int he ring *this* object server should update20:33
clayg... i'm not sure if there's an expectation that the proxy service will reload new rings faster that other services on the object nodes20:33
brianclineoh, right. the coordination aspect of which nodes. that makes sense20:33
claygthe object-updater (pushes async pendings to container dbs) *does* reload the it's container rings and recalc the container host/device form the partition20:34
brianclineahh, so those headers are only really used when there's no need to write out an async20:35
briancline(which hopefully is almost always)20:35
onovy"always"20:36
onovy[async_pending] low: 24, high: 367, avg: 205.1, total: 6975, Failed: 0.0%, no_result: 0, reported: 3420:36
brianclineafter 4 years with swift, i still learn all sorts of new nuanced things often20:36
onovydon't know if this number is normal but it's normal for our production cluster :)20:37
brianclineyeah, that seems pretty normal. i usually see similar numbers for our busiest cluster20:39
*** acoles is now known as acoles_20:46
*** sgundur has quit IRC20:50
onovyclayg: hey! if i change pwd in bash script, it's not changed in parent? that's new for me20:51
onovyso that cd - is completly useless20:51
onovyso i think i should change my opinion and add set -e to .*tests, and remove that cd -20:52
claygonovy: no idea20:53
onovyah, in .unittests is rm -rf of .coverage20:53
* clayg taps out20:53
onovyfok it :)20:54
*** sgundur has joined #openstack-swift20:55
claygtimburke: i pinged you last night on patch 360298 - any opinion on requests-mock?  I think you and Jamie have been working on some sessions/keystone stuff with swiftclient - i may be incorrectly infering the use of requests-mock is related to that effort?20:55
patchbothttps://review.openstack.org/#/c/360298/ - python-swiftclient - Use requests_mock and oslotest20:55
onovythanks for review20:56
clayghonestly the *only* think I like about the current handling of httplib mocking is that if i'm not clear what it's doing I can read it in the same tree i'm currently working and if it doesn't do what I want in my test I can change it w/o any fuss20:56
claygI do but a high value on both of those - but if using requests-mock means I don't have to go read source to have a good expectation of what it does or have to make any changes because it already does what I want - there's not really any downside ;)20:57
*** chsc has quit IRC21:00
*** jordanP has joined #openstack-swift21:01
mattoliverauMorning21:09
*** mvk has joined #openstack-swift21:22
*** jordanP has quit IRC21:29
*** tdasilva has quit IRC21:30
*** ppalacios has quit IRC21:31
*** tdasilva has joined #openstack-swift21:33
*** sgundur has quit IRC21:34
*** sgundur has joined #openstack-swift21:34
*** sgundur has quit IRC21:51
*** zigo has quit IRC22:02
*** zigo has joined #openstack-swift22:05
*** zigo is now known as Guest5063022:05
*** StraubTW_ has quit IRC22:09
*** vint_bra has quit IRC22:16
*** _JZ_ has quit IRC22:39
*** vint_bra has joined #openstack-swift22:44
*** vint_bra has quit IRC22:53
openstackgerritTim Burke proposed openstack/pyeclib: Fix formatted get_metadata memory leak  https://review.openstack.org/38518522:57
openstackgerritTim Burke proposed openstack/pyeclib: Avoid segfault when raising exceptions  https://review.openstack.org/38518623:01
*** nikivi has joined #openstack-swift23:27
*** kei_yama has joined #openstack-swift23:27
*** chsc has joined #openstack-swift23:39
*** nikivi has quit IRC23:53
*** nikivi has joined #openstack-swift23:53
*** nottrobin has quit IRC23:54
*** nottrobin has joined #openstack-swift23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!