Tuesday, 2016-06-28

*** siva_krish has joined #openstack-swift00:03
*** siva_krish has quit IRC00:07
*** Suyash has quit IRC00:08
*** zaitcev has joined #openstack-swift00:15
*** ChanServ sets mode: +v zaitcev00:15
*** diogogmt has quit IRC00:17
*** gyee has quit IRC00:29
*** ManojK has quit IRC00:30
openstackgerritClay Gerrard proposed openstack/swift: Preserve X-Static-Large-Object from .data file after POST  https://review.openstack.org/33471900:34
claygtimburke: acoles_: kota_: ^ I think it's is a better way to get solve lp bug #145380700:35
openstackLaunchpad bug 1453807 in OpenStack Object Storage (swift) "Post (not as copy) to SLO manifest destroys its state as a manifest" [Undecided,Fix released] https://launchpad.net/bugs/1453807 - Assigned to Kota Tsuyuzaki (tsuyuzaki-kota)00:35
*** lyrrad has quit IRC00:43
*** siva_krish has joined #openstack-swift00:51
*** ManojK has joined #openstack-swift00:53
kota_morning00:55
kota_oh, what? I've been poked?00:55
claygkota_: it's not super important - timburke pointed out to me something about x-static-large-object metadata handling that I had missed; you and acoles_ had basically already squared it - but he thought there was a consistency issue... i'm not sure if the comments on patch 334719 really make it any clearer00:57
patchbotclayg: https://review.openstack.org/#/c/334719/ - swift - Preserve X-Static-Large-Object from .data file aft...00:57
*** siva_krish has quit IRC00:57
kota_clayg: alright, gotcha.00:58
kota_clayg: I added the link to my review stack :)00:58
*** tqtran has quit IRC01:01
*** klamath has quit IRC01:01
*** klamath has joined #openstack-swift01:02
*** ManojK has quit IRC01:03
*** ManojK has joined #openstack-swift01:06
*** ManojK has quit IRC01:11
*** rcernin has quit IRC01:11
*** klrmn has quit IRC01:12
*** klamath has quit IRC01:24
kota_clayg: with my quick look, your patch changed the x-static-large-object header holder from .meta into the root .data file right?01:24
kota_it seems better (and easy) to tracking an issue of .meta racing.01:25
claygaww you put it at the top of the stack :)01:26
claygyeah that's pretty much the idea01:26
kota_clayg: k, proably https://gist.github.com/bloodeagle40234/1badfff746df1db00fbac95e7e351b68 is a new test for the change :)01:27
kota_When I opened the link, I noticed it's small change so easy to start on today's work beginning ;)01:28
kota_ah, swiftstack/vagrant-swift-all-in-one] support vagrant AWS provider (#39) merged!01:33
kota_great tools for me :)01:33
claygah, yeah that's nice01:34
kota_oh, jenkins failed :/01:36
kota_ugh, test_mem_server stands up in front of me again :.(01:39
kota_clayg: that change affects diskfile and mem_server file system doesn't support PRESERVED_DATAFILE/DATAFILE_SYSTEM_META change01:44
kota_clayg: https://gist.github.com/bloodeagle40234/1badfff746df1db00fbac95e7e351b68 is a new version for passing test, I ran localy test/unit/proxy/test_server and that succeded. Now I'm running whole py27 tests yet.01:45
*** vinsh_ has quit IRC01:47
*** vinsh has joined #openstack-swift01:49
claygaw, that makes sense - oops - good catch01:53
*** baojg has joined #openstack-swift01:54
claygkota_: I'll circle back around to it tmrw and I can pull in any additional fixups you have - or just push over and we can each put a half a +2 on it ;)01:54
openstackgerritKota Tsuyuzaki proposed openstack/swift: Patch for Clay's diskfile change  https://review.openstack.org/33472801:55
claygif you get it looking sharp I'm sure we could trick timburke or acoles_ into the +A01:55
kota_clayg: pushed into the fix to gerrit :)01:55
claygkota_: ah, np, that works too!01:55
claygkota_: the changes in mem_diskfile in your patch probably should get merged in with the other fix tho - I might just squash everything and co-author you if that's ok?01:56
claygAND THANKS!01:56
kota_clayg: enough for me :) tentatively, I drop my +2, and will add +2 again after you merged it :)01:57
*** baojg has quit IRC01:58
*** tqtran has joined #openstack-swift01:59
kota_clayg: anyway, have a good evening/night :D02:01
*** tqtran has quit IRC02:03
*** mwheckmann has joined #openstack-swift02:06
*** Jeffrey4l__ has quit IRC02:07
*** Suyash has joined #openstack-swift02:09
*** baojg has joined #openstack-swift02:11
*** klrmn has joined #openstack-swift02:12
*** ManojK has joined #openstack-swift02:16
*** remimin has joined #openstack-swift02:22
*** remimin has quit IRC02:27
*** baojg has quit IRC02:33
*** mtreinish has quit IRC02:36
*** mtreinish has joined #openstack-swift02:36
*** chlong has quit IRC02:37
*** ManojK has quit IRC02:44
*** arch-nemesis has quit IRC02:47
*** chlong has joined #openstack-swift02:49
*** ManojK has joined #openstack-swift02:58
*** sheel has joined #openstack-swift03:07
*** SkyRocknRoll has joined #openstack-swift03:21
openstackgerritPete Zaitcev proposed openstack/swift: Add a global fix for anything that involves GetHashPrefixAndSuffix  https://review.openstack.org/33310803:22
*** ppai has joined #openstack-swift03:23
*** ManojK has quit IRC03:35
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380103:41
*** links has joined #openstack-swift03:50
*** tqtran has joined #openstack-swift04:01
*** tqtran has quit IRC04:06
openstackgerritKota Tsuyuzaki proposed openstack/swift: Patch for Clay's diskfile change  https://review.openstack.org/33472804:06
*** Jeffrey4l has joined #openstack-swift04:31
*** psachin has joined #openstack-swift04:33
*** manous has joined #openstack-swift04:39
*** manous has quit IRC04:44
*** ppai has quit IRC04:45
*** rcernin has joined #openstack-swift04:46
*** manous has joined #openstack-swift04:57
*** ppai has joined #openstack-swift04:58
*** manous has quit IRC05:02
*** mariusv has joined #openstack-swift05:03
*** mariusv has quit IRC05:03
*** mariusv has joined #openstack-swift05:03
*** mariusv has quit IRC05:03
*** zaitcev has quit IRC05:08
*** mariusv has joined #openstack-swift05:11
*** ppai has quit IRC05:13
*** manous has joined #openstack-swift05:15
*** manous has quit IRC05:19
*** baojg has joined #openstack-swift05:22
timburkeclayg: yay! i should complain about things more often!05:22
timburkei'm not sure i understand the link between that bug and the cve on it, though...05:25
*** ChubYann has quit IRC05:27
*** manous has joined #openstack-swift05:32
*** kei_yama has quit IRC05:35
*** rcernin has quit IRC05:37
*** mariusv has quit IRC05:37
*** manous has quit IRC05:38
*** kei_yama has joined #openstack-swift05:42
*** baojg has quit IRC05:45
*** manous has joined #openstack-swift05:49
*** rcernin has joined #openstack-swift06:09
*** ppai has joined #openstack-swift06:09
*** Suyash has quit IRC06:20
*** kei_yama_ has joined #openstack-swift06:29
*** kei_yama has quit IRC06:29
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380106:29
*** klrmn has quit IRC06:41
*** jamielennox is now known as jamielennox|away06:44
*** pcaruana has joined #openstack-swift06:46
*** manous has quit IRC06:58
*** tesseract- has joined #openstack-swift06:59
*** asettle has joined #openstack-swift07:03
*** daemontool has joined #openstack-swift07:04
*** mwheckmann has quit IRC07:05
*** manous has joined #openstack-swift07:09
*** manous has quit IRC07:14
*** manous has joined #openstack-swift07:17
*** jordanP has joined #openstack-swift07:18
*** jordanP has quit IRC07:18
*** koko has joined #openstack-swift07:22
*** koko is now known as Guest7497607:22
*** rledisez has joined #openstack-swift07:23
*** manous has quit IRC07:25
*** Guest74976 has quit IRC07:27
*** manous has joined #openstack-swift07:38
*** manous has quit IRC07:42
*** diogogmt has joined #openstack-swift07:53
*** joeljwright has joined #openstack-swift07:56
*** ChanServ sets mode: +v joeljwright07:56
*** asettle has quit IRC07:58
*** acoles_ is now known as acoles07:58
*** geaaru has joined #openstack-swift08:00
*** hseipp has joined #openstack-swift08:02
*** dmk0202 has joined #openstack-swift08:06
openstackgerritDavanum Srinivas (dims) proposed openstack/swift: [WIP] Testing latest u-c  https://review.openstack.org/31844108:10
*** mvk_ has quit IRC08:19
acolestdasilva: like I said, never assume anything :(08:24
*** daemontool has quit IRC08:40
*** asettle has joined #openstack-swift08:45
*** sanchitmalhotra has joined #openstack-swift08:45
*** mvk_ has joined #openstack-swift08:51
*** jistr is now known as jistr|mtg09:04
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380109:09
*** hseipp has quit IRC09:20
*** asettle has quit IRC09:21
*** jistr|mtg is now known as jistr09:31
*** baojg has joined #openstack-swift09:37
*** baojg has quit IRC09:37
*** asettle has joined #openstack-swift09:40
*** baojg has joined #openstack-swift09:46
*** mvk_ has quit IRC09:48
*** sanchitmalhotra has quit IRC09:49
*** baojg has quit IRC09:50
*** sanchitmalhotra has joined #openstack-swift09:50
*** mvk_ has joined #openstack-swift10:01
*** kei_yama_ has quit IRC10:35
*** kei_yama has joined #openstack-swift10:36
*** kei_yama has quit IRC10:41
*** hosanai has quit IRC10:43
*** silor has joined #openstack-swift10:45
*** silor has quit IRC10:47
*** daemontool has joined #openstack-swift10:48
*** silor has joined #openstack-swift10:49
*** gvernik has joined #openstack-swift11:13
*** gvernik has quit IRC11:23
*** wanghua has quit IRC11:25
*** joeljwright has quit IRC11:28
*** manous has joined #openstack-swift11:43
*** arcimboldo has joined #openstack-swift11:46
arcimboldohi all, I have a swift/liberty and a container is not getting deleted. There is a ".pending" file and when I try to delete I get "409 conflict" reply11:47
*** manous has quit IRC11:47
arcimboldowhat's happening?11:47
arcimboldoBesides: it is supposed to be a replica-2 container but for some reason (maybe a past test) I have 3 copies of the container data11:48
arcimboldoconatiner is empty11:48
arcimboldo(ah ok, that's my fault: containers are stored in 3 replicas ring, so that's fine)11:48
*** raildo-afk is now known as raildo11:53
*** manous has joined #openstack-swift12:00
*** ppai has quit IRC12:04
*** manous has quit IRC12:05
*** manous has joined #openstack-swift12:05
*** manous has quit IRC12:10
*** ppai has joined #openstack-swift12:18
*** jamielennox|away is now known as jamielennox12:21
*** diogogmt has quit IRC12:21
*** diogogmt has joined #openstack-swift12:22
*** _JZ_ has joined #openstack-swift12:24
openstackgerritSachin Patil proposed openstack/swift: Fix swift-get-nodes arg parsing for missing ring  https://review.openstack.org/33423812:25
*** daemontool has quit IRC12:28
arcimboldoI'll ask again: what's the meaning of ".pending" files? I have containers with ".pending" file and ".lock", and I cannot delete the container because I get a 409 - HTTPConflict error12:31
* arcimboldo suspects everyone here is living on the west coast12:32
*** diogogmt has quit IRC12:34
*** daemontool has joined #openstack-swift12:36
*** joeljwright has joined #openstack-swift12:37
*** ChanServ sets mode: +v joeljwright12:37
*** links has quit IRC12:40
*** ManojK has joined #openstack-swift12:46
*** links has joined #openstack-swift12:52
*** klamath has joined #openstack-swift12:54
*** daemontool has quit IRC12:57
*** klamath_ has joined #openstack-swift13:02
*** klamath has quit IRC13:02
*** klamath_ has quit IRC13:02
*** klamath has joined #openstack-swift13:03
*** pauloewerton has joined #openstack-swift13:03
*** daemontool has joined #openstack-swift13:13
*** diogogmt has joined #openstack-swift13:15
*** jamielennox has quit IRC13:25
*** daemontool has quit IRC13:25
*** daemontool has joined #openstack-swift13:41
*** fifieldt has joined #openstack-swift13:43
*** ManojK has quit IRC13:44
*** mmcardle has quit IRC13:44
*** mmcardle has joined #openstack-swift13:48
acolesarcimboldo: containers must be empty before they can be deleted, the 409 may be indicating that the container is not empty13:51
openstackgerritChristian Schwede proposed openstack/swift: Fix inline tempurl/formpost signature examples  https://review.openstack.org/33504413:53
acolesarcimboldo: the .pending file contains a journal of recent updates waiting to be committed to the container objects table, it is normal to see that. The .pending file is processed periodically, and always when an attempt is made to delete the container.13:54
tdasilvagood morning13:54
*** mwheckmann has joined #openstack-swift13:55
*** ametts has joined #openstack-swift13:57
tdasilvaacoles: tough game, but this video is awesome to watch: http://espn.go.com/video/clip?id=espn:1656550814:01
acolestdasilva: what game? what are you talking about? ;) it has been erased from history14:03
acolestdasilva: heh, I saw some footage of the commentator14:03
tdasilvaacoles: hehe, believe me, I know the feeling all too well now14:03
*** delattec has joined #openstack-swift14:14
*** cdelatte has quit IRC14:16
*** delattec has quit IRC14:20
*** ManojK has joined #openstack-swift14:22
*** ppai has quit IRC14:30
*** diogogmt has quit IRC14:32
*** diogogmt has joined #openstack-swift14:32
*** siva_krish has joined #openstack-swift14:33
*** jamielennox has joined #openstack-swift14:36
*** links has quit IRC14:38
*** arch-nemesis has joined #openstack-swift14:39
*** cdelatte has joined #openstack-swift14:40
*** cdelatte has quit IRC14:42
*** macsun has joined #openstack-swift14:43
*** ManojK has quit IRC14:44
*** ManojK has joined #openstack-swift14:44
*** thumpba has joined #openstack-swift14:49
*** cdelatte has joined #openstack-swift14:55
*** cdelatte has quit IRC15:05
*** jistr is now known as jistr|mtg15:13
notmynamegood morning15:17
*** klrmn has joined #openstack-swift15:17
*** cdelatte has joined #openstack-swift15:31
*** jistr|mtg is now known as jistr15:32
*** Suyash has joined #openstack-swift15:33
*** cdelatte has quit IRC15:34
*** psachin has quit IRC15:37
*** dmk0202 has quit IRC15:42
*** jmccarthy has quit IRC15:44
*** jmccarthy has joined #openstack-swift15:44
notmynameacoles: WIP on patch 328207?15:47
patchbotnotmyname: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking15:47
acolesnotmyname: I saw enough comments pushing towards a different approach (shifting encrypted vals to transient sysmeta)15:48
acolesnotmyname:  don't want people wasting time reviewing that patch if it is not needed15:48
notmynamewell *something* is needed15:49
acolesnotmyname: I have the alternative working ;)15:49
notmynameoh, ok. carry on then ;-)15:49
acolesnotmyname: yes, just leave me to type ... ;-)15:49
acolesJK15:49
acolesnotmyname: I am just summarising the change on an etherpad so some of us can discuss15:50
notmynameok15:50
notmynamefeature that is working and landed and updated later is much preferred to perfectly designed feature that will land some time later15:51
*** Jeffrey4l has quit IRC15:55
*** tesseract- has quit IRC15:56
*** daemontool_ has joined #openstack-swift16:00
*** daemontool has quit IRC16:03
acolesnotmyname: ^^ that is very much in my mind as I deal with review comments16:08
*** cdelatte has joined #openstack-swift16:12
*** SkyRocknRoll has quit IRC16:15
*** geaaru has quit IRC16:17
*** gyee has joined #openstack-swift16:17
*** lyrrad has joined #openstack-swift16:17
acolesnotmyname: timburke jrichli kota_ torgomatic mattoliverau - we have an option to change user metadata handling and avoid the contentious patch 328207 altogether, change is summarised here https://etherpad.openstack.org/p/swift_encryption_meta_headers, I'd like feedback before I push to gerrit (or not)16:22
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking16:22
*** cdelatte has quit IRC16:22
jrichliacoles: ill take a look16:23
*** asettle has quit IRC16:27
jrichliacoles: sounds like a good plan - still thinking it all through.16:31
*** daemontool_ has quit IRC16:35
*** sambhare has joined #openstack-swift16:37
timburkegood morning16:39
*** Suyash has quit IRC16:39
jrichliacoles: I think this solution could also be applied to account and container metadata, but I know that the "transient-sysmeta" was originally developed only for object metadata.16:40
*** joeljwright has quit IRC16:40
jrichliwould you see this being the same scheme we'd maybe use for acct and cont in the future?16:40
*** Suyash has joined #openstack-swift16:40
*** rledisez has quit IRC16:42
*** sambhare has quit IRC16:43
*** ManojK has quit IRC16:43
*** permalac has joined #openstack-swift16:43
*** asettle has joined #openstack-swift16:44
*** ManojK has joined #openstack-swift16:45
*** permalac_ has quit IRC16:45
acolesjrichli: No. they would use sysmeta. but otherwise, could be similar pattern.16:45
timburkejrichli: i think it might be a bit messier for account/container data since we'd need to reconcile between the encrypted sysmeta and any lurking user meta. it may be sufficient to have the encrypter *always* set both (clearing the encrypted sysmeta when encryption is disabled), but we'd need to ensure it stays in the pipeline16:46
*** Suyash has quit IRC16:48
*** zul_ is now known as zul16:48
*** cdelatte has joined #openstack-swift16:49
*** pcaruana has quit IRC16:49
*** rcernin has quit IRC16:51
*** cdelatte has quit IRC16:53
*** macsun has quit IRC16:54
*** tqtran has joined #openstack-swift16:59
timburkeacoles: your new (unsubmitted) patch still calls check_metadata in the encrypter, right?17:01
acolestimburke: it should ;)17:01
acolestimburke: yes, just double checked17:02
timburkeacoles: thanks :)17:02
*** gyee has quit IRC17:03
timburkei'm starting to wonder whether the version in the key_id needs to have some sort of namespacing for the keymaster that generated it...17:04
*** vinsh has quit IRC17:04
*** ChubYann has joined #openstack-swift17:04
openstackgerritAlistair Coles proposed openstack/swift: Enable middleware to set metadata on object POST  https://review.openstack.org/32820617:04
*** asettle has quit IRC17:04
*** vinsh has joined #openstack-swift17:04
openstackgerritAlistair Coles proposed openstack/swift: Allow middleware to override metadata header checking  https://review.openstack.org/32820717:04
openstackgerritAlistair Coles proposed openstack/swift: Enable object body and metadata encryption  https://review.openstack.org/32820817:04
openstackgerritAlistair Coles proposed openstack/swift: Add encryption overview doc  https://review.openstack.org/32820917:05
*** Suyash has joined #openstack-swift17:05
acoles^^ today's updates, thanks for everyone's reviews17:05
*** arcimboldo has quit IRC17:07
jrichlitimburke: I am in favor of the key_id namespacing.  good idea17:08
*** cdelatte has joined #openstack-swift17:11
*** cdelatte has quit IRC17:11
claygi think it's perfectly reasonable to expect there to be only one keymaster17:14
acolesjrichli: timburke are you planning to support multiple keymasters contributing keys for the *same* object request? I only imagined a single keymaster providing keys for any given request, so the key_id meta does not need to accommodate contributions from multiple sources17:15
clayglet's wait to have two keymasters because we invent a use-case for two keymasters - and then also lets just write a single keymaster that can talk to multiple backends specific for that use-case17:16
clayg*before we invent17:16
* acoles back later17:17
*** flwang1 has joined #openstack-swift17:17
flwang1greetings, i have some questions about swift monitoring17:17
flwang1if we would like to focus on the cluster health, except dispersion and recon, anything else i can leverage?17:19
flwang1thanks17:19
*** hoonetorg has quit IRC17:19
jrichliclayg acoles: I see that only one key could apply at one time.  I guess I was thinking of the breadcrumbs to indicate which keymaster may be associated.  Somebody using a custom keymaster may be able to add to the crypto-meta - ill think about that17:20
timburkeacoles: i'd imagine that for conditional requests we'd need to get all possible keys for the target, for PUTs we'd need some designated "primary" key, and for GETs we'd need to be able to request a particular key17:20
claygflwang1: log aggregation and statsd are useful tools for various operational scenarios - althought perhaps not quite as useful as dispersion reporting and recon for like... leveled health/alert triggers17:24
flwang1clayg: thanks, based on my understanding, 'health' of swift means all the data can have the eventual consistency, swift has already provide a lot of process/services to ensure that17:26
flwang1so does that mean generally, we just need to make sure those services/process are in a good status?17:26
claygflwang1: yeah sure *generally*17:27
flwang1clayg: for example, when we see '77.56% of object copies found (6094 of 7857)' from dispersion report,  does that mean swift is not healthy?17:28
claygflwang1: it probably means it's replicating - or you have some capacity that's not available17:28
flwang1clayg: yep, that's what i'm trying to understand17:29
flwang1so what's the metric can help us define if the cluster is healthy or not?17:29
claygthere's no one number - it takes lots of input17:30
jrichliclay acoles timburke : ah, I am just catching up with reviews from the last couple days.  acoles had already replied to these concerns with key['id'] can be a dict (in fact, it is in the keymaster), so that should allow other key manager impls to persist arbitrary private metadata with the object crypto-meta.17:30
claygdispersion is a good canary - it's worth investigating - do you have devices that are not available - can you check?  are the replicators logging lots of errors?17:31
flwang1clayg: so dispersion is like a overview alarm/alert, and if we see it's not 'good', then we need to check the others, right?17:34
*** d0ugal has quit IRC17:37
*** d0ugal has joined #openstack-swift17:37
*** d0ugal has quit IRC17:37
*** d0ugal has joined #openstack-swift17:37
*** vinsh_ has joined #openstack-swift17:40
*** d0ugal has quit IRC17:41
*** d0ugal has joined #openstack-swift17:42
*** d0ugal has quit IRC17:42
*** d0ugal has joined #openstack-swift17:42
*** vinsh has quit IRC17:44
*** rcernin has joined #openstack-swift17:44
*** mvk_ has quit IRC17:45
claygflwang1: yeah, but even as an alarm/alert you may *know* that you have a node down waiting for a new mb, or you may *know* that you just added six nodes and a bunch of replication is still pushing data to the new capacity17:49
flwang1clayg: yep, i see. another question is, if one of the replicator or auditor is down, can we see any difference from the recon api response?17:50
claygso it doesn't mean like nesscessarily "ZOMG YOU'RE GOINGTO LOOSE DATAZ!?/11" as much as "hey bro, just FYI stuff ain't where I'd expect, pls look, kthxbai"17:50
claygflwang1: well they wouldn't be updating their recon drops - so you'd seem timestamps getting old - but it'd probably be a good idea to add some process monitoring/alerting - stuff shouldn't just "die"17:52
*** cschwede has quit IRC17:52
flwang1clayg: yep, we do monitor the daemon as well. but some times process is alive but it may have died. hence i asked above question17:53
flwang1clayg: btw, i think the recon api's data come from database, right? where can i find the database?17:54
claygah, yeah liked locked up on a tarpit disk or something - yeah if it's hung sometimes your best indicator is the recon drop not getting updates17:54
claygit's just a json file17:54
clayg/var/[lib|cache]/swift/something.[recon|json] or something?17:54
claygi'm going with /var/cache/swift/service.recon17:55
acolestimburke: OIC, https://review.openstack.org/#/c/328206/9/swift/common/request_helpers.py line 47, yes makes sense17:55
patchbotacoles: patch 328206 - swift (feature/crypto-review) - Enable middleware to set metadata on object POST17:55
timburkeacoles: but like i said, could be done as a follow-up17:56
*** diogogmt has quit IRC17:58
claygacoles: everyone picking on you about going with the obviously more correct and clear get_*_meta(key) instead of the gross and obviously leaky get_*_meta_prefix([type]) + 'key' (or is it + '-key' !?)17:58
*** cschwede has joined #openstack-swift17:59
*** diogogmt has joined #openstack-swift18:00
flwang1clayg: cool, does swift use any database to save something?18:00
pdardeauclayg: tarpit disk. i like it. that one's gonna stick :-^18:01
claygflwang1: not for... monitoring - accounts and containers use sqlite databases...18:03
timburkeclayg: acoles: i *like* passing the key well enough; i'm just somewhat hesitant to create a second style without enabling authors to also use that style for the existing functions18:04
flwang1clayg: cool, i'm good now, thank you so much18:05
flwang1clayg: i may bug you again :)18:05
*** gyee has joined #openstack-swift18:08
*** klamath has quit IRC18:13
*** diogogmt has quit IRC18:16
*** mvk_ has joined #openstack-swift18:20
*** chsc has joined #openstack-swift18:22
*** chsc has joined #openstack-swift18:22
*** cdelatte has joined #openstack-swift18:24
*** pcaruana has joined #openstack-swift18:25
*** cdelatte has quit IRC18:25
*** mvk_ has quit IRC18:26
*** diogogmt has joined #openstack-swift18:28
*** PsionTheory has joined #openstack-swift18:29
*** zaitcev has joined #openstack-swift18:36
*** ChanServ sets mode: +v zaitcev18:36
*** pauloewerton has quit IRC18:37
*** PsionTheory has quit IRC18:39
*** MooingLemur has quit IRC18:39
*** ManojK has quit IRC18:44
*** ManojK has joined #openstack-swift18:45
*** mvk has joined #openstack-swift18:49
openstackgerritMichael Barton proposed openstack/swift: go: move hummingbird.go  https://review.openstack.org/33517118:51
*** mvk has quit IRC18:52
*** sheel has quit IRC18:55
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873618:56
acolesnotmyname: quick crypto-review update...the first 4 of 7 patches seem to be stablilising and collecting +2. The next patch 328207 is the subject of this etherpad discussion https://etherpad.openstack.org/p/swift_encryption_meta_headers. That leaves patch 328208 and the docs. The docs have had plenty of review so I hope are stable-ish.18:57
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking18:57
patchbotacoles: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption18:57
acolesnotmyname: I am focussed now more on changes that might affect what we are writing to disk or config i.e. things that could make life hard if we need to change. Changes where we can to follow up on master I may or may not apply.19:00
notmynameacoles: sounds great. looking over the etherpad now19:01
*** fifieldt has quit IRC19:01
notmynameacoles: what's your gut feeling on if we can finish this up by the end of the week?19:01
acolesnotmyname: unless there are unknown issues still to arise, I think we can, obviously, the reviewers decide. The two significant *known* issues that I think should be finalised before master first the subject of the etherpad  https://etherpad.openstack.org/p/swift_encryption_meta_headers, and second a discussion that has started in review of 328208 over whether we need/want 3 discrete middlewares, or could simplify. IMHO w19:04
acolese can simplify if we want to by at least merging the encrypter and decrypter (mostly a case of moving code between modules), and of course it is best to do that before we land a config pattern on master.19:04
acolesnotmyname:  but hopefully 4/7 are done, 5 is either done or not needed, 6 is the meat, and 7 is docs19:05
acolesI say 5 (patch 328207) is done or not needed because reviews have said any changes to address concerns could be done as a follow up.19:06
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking19:06
*** asettle has joined #openstack-swift19:11
timburkeon combining middlewares -- note that we *could* keep the current structure (having discrete encrypter/decrypter filters that take an app and return a filtered app), and just roll them up ourselves instead of having paste do it for us19:13
*** MooingLemur has joined #openstack-swift19:14
notmynametimburke: ie one python module with 2 classes? or, 2 filter_factory() methods, I'd guess19:14
acolestimburke: ok. so the goal is to reduce the number of ways to break your pipeline by moving to 'keymaster encryption' - is that what you are thinking too? (I'm inclined to leave keymaster independent, but the other two can become one with no change to the callback interface)19:16
timburkenotmyname: or even keep the two python modules. drop the encrypter/decrypter filter_factory entrypoints we have now and add a new crypto entrypoint that points to (idk) some filter_factory in crypto_utils19:16
timburkeacoles: yeah, more or less19:16
*** fifieldt has joined #openstack-swift19:16
*** vinsh_ has quit IRC19:17
timburkei think operators are fairly aware of the fact that order of things matter. if we can get this down to two middlewares and we can say "look, this one needs to be to the left so the keys are available to the one on the right", i think it'll be a good improvement19:18
acolestimburke: the critical thing is what we say goes in the pipeline - how the code lives in modules, where the factory method is can all change later, so yeah whatever minimises code churn works for me. which is probably just creating a single factory method somewhere that chains the two filters.19:18
timburkeyup19:19
*** mmcardle has quit IRC19:19
acolestimburke: yeah, its reasonable to expect ops to know left from right, but putting things in the middle might be a step too far :P19:19
acolesnotmyname: timburke ok, how about this plan - I'll push etherpad plan B as separate review (cos i have limited time right now to run all my "QA" on the chain) - then if anyone has time they can review that and I can squash it in tomorrow - plus others can still disagree on the etherpad.19:22
notmyname+119:22
* acoles thinks it will conflict with timburke's fantastic patch, so will be a little time19:22
timburkewhich patch am i supposed to be doing now?19:22
acolesthen tomorrow we can beat on filter factory changes19:23
acolestimburke: you already did it - the one you left for me to append etag meta to the end of the header19:23
acoles;)19:23
acolesI already merged and publsihed that in latest version19:23
timburkeyay! i was afraid i'd already promised something else :-)19:24
acolestimburke: sorry for the scare19:24
*** gyee has quit IRC19:25
claygok, so no more encrypted x-object-meta-<key> then?  it's all about the composite x-object-transient-sysmeta-crypto-<key> now?19:29
clayglol19:32
*** siva_krish has quit IRC19:32
*** ametts has quit IRC19:40
*** flwang1 has quit IRC19:49
openstackgerritAlistair Coles proposed openstack/swift: Switch to transient sysmeta for stashing encrypted user metadata  https://review.openstack.org/33520919:51
acolesnotmyname: timburke jrichli ^^ like i said, if we like it I will squash it in to the chain tomorrow19:52
acolesclayg: transient is where its at man19:52
*** siva_krish has joined #openstack-swift19:53
notmynameacoles: how is that in the dependency chain?19:53
*** siva_krish has left #openstack-swift19:53
acolesit depends on patch 32820819:54
patchbotacoles: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption19:54
*** hoonetorg has joined #openstack-swift19:54
notmynamegot it. thanks19:54
acolesit doesn't need patch 328207 but I don't want branch further down the chain since this is just testing the water19:55
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking19:55
*** ametts has joined #openstack-swift19:56
notmynamestarted running local tests on it. now to go pick up some lunch19:56
acolesI'm done for today, have to fix the washing machine now :/19:57
*** acoles is now known as acoles_20:03
*** vinsh has joined #openstack-swift20:08
*** joeljwright has joined #openstack-swift20:16
*** ChanServ sets mode: +v joeljwright20:16
*** joeljwright has quit IRC20:16
*** silor has quit IRC20:18
*** asettle has quit IRC20:20
*** zul has quit IRC20:20
*** Suyash has quit IRC20:32
*** gyee has joined #openstack-swift20:39
mwheckmannhello. Can anyone tell me what swift process would be responsible for *removing* partitions if I lower the replica count of a ring?20:41
*** asettle has joined #openstack-swift20:42
notmynamemwheckmann: the replication process (for replicated storage) or the reconciler for EC storage20:42
*** Suyash has joined #openstack-swift20:42
mwheckmannok. That's what I was thinking. I'm guess the removal of partitions would be treated the same way as shuffling partitions of new devices are added?20:43
notmynameyup20:43
mwheckmannthanks20:43
*** ManojK has quit IRC20:43
*** thumpba has quit IRC20:45
*** ManojK has joined #openstack-swift20:45
*** ametts has quit IRC20:49
*** ukaynar has joined #openstack-swift21:03
notmynametimburke: I feel like this was asked before, but I don't remember the answer: why is encrypt_header_val() in encrypter.py instead of crypto_utils.py?21:08
timburkenotmyname: just compartmentalizing encryption operations to encrypter.py, IIRC21:10
*** cdelatte has joined #openstack-swift21:11
*** dmk0202 has joined #openstack-swift21:11
*** asettle has quit IRC21:40
*** zul has joined #openstack-swift21:41
*** dmk0202 has quit IRC21:42
*** ManojK has quit IRC21:46
*** flwang1 has joined #openstack-swift21:59
*** ManojK has joined #openstack-swift22:01
*** cdelatte has quit IRC22:05
*** ManojK has quit IRC22:16
*** _JZ_ has quit IRC22:29
*** ukaynar has quit IRC22:33
mattoliveraumorning22:41
*** mwheckmann has quit IRC22:49
*** ManojK has joined #openstack-swift23:01
*** rcernin has quit IRC23:03
*** kei_yama has joined #openstack-swift23:11
*** zul has quit IRC23:24
notmynamehi mattoliverau23:30
*** chsc has quit IRC23:31
notmynameclayg: without a keymaster goes boom23:34
notmynamegerrit down for everyone or just me?23:37
notmyname(that was temporary)23:43
mattoliveraunotmyname: hey hey23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!