| *** hosanai has joined #openstack-swift | 00:07 | |
| *** ChanServ sets mode: +v hosanai | 00:07 | |
| *** rcernin has quit IRC | 00:13 | |
| *** zaitcev has joined #openstack-swift | 00:22 | |
| *** ChanServ sets mode: +v zaitcev | 00:22 | |
| *** ouchkernel has quit IRC | 00:35 | |
| *** chlong has joined #openstack-swift | 00:36 | |
| *** NM has joined #openstack-swift | 01:06 | |
| kota_ | good morning | 01:12 |
|---|---|---|
| *** nadeem has quit IRC | 01:20 | |
| kota_ | I'm starting to look at crypt-review branch. | 02:20 |
| kota_ | I picked up the last patch set (patch 328209) for the first review because I have to know what will happen in those changes. | 02:21 |
| patchbot | kota_: https://review.openstack.org/#/c/328209/ - swift (feature/crypto-review) - Add encryption overview doc | 02:21 |
| notmyname | kota_: great, thanks! | 02:29 |
| notmyname | and good morning :-) | 02:29 |
| kota_ | notmyname: morning | 02:30 |
| *** NM has quit IRC | 02:31 | |
| kota_ | acoles, notmyname: no worries about patch 322773, I noticed it conflicts with something with encryption *probe* and I think rewrite the probe refactoring *AFTER* encryption got merged. | 02:32 |
| patchbot | kota_: https://review.openstack.org/#/c/322773/ - swift - Apply container update probe to both of REPL/EC | 02:32 |
| notmyname | kota_: ah, good | 02:32 |
| notmyname | so we'll wait and land patch 322773 after crypto lands, and the merge conflict won't be too bad (you've already done it) | 02:33 |
| patchbot | notmyname: https://review.openstack.org/#/c/322773/ - swift - Apply container update probe to both of REPL/EC | 02:33 |
| kota_ | yup | 02:34 |
| *** wanghua has joined #openstack-swift | 02:51 | |
| *** takashi has joined #openstack-swift | 02:52 | |
| takashi | good morning :-) | 02:55 |
| *** NM has joined #openstack-swift | 02:58 | |
| *** NM has quit IRC | 02:58 | |
| jrichli | kota_: thanks for reviewing! | 03:04 |
| kota_ | jrichli: no problem. I'm at the start line yet :) | 03:14 |
| *** zaitcev has quit IRC | 03:32 | |
| *** klrmn has quit IRC | 03:59 | |
| *** psachin has joined #openstack-swift | 04:13 | |
| *** nadeem has joined #openstack-swift | 04:25 | |
| *** links has joined #openstack-swift | 04:26 | |
| *** ppai has joined #openstack-swift | 05:11 | |
| *** natarej has quit IRC | 05:37 | |
| *** McMurlock has joined #openstack-swift | 05:48 | |
| *** chlong has quit IRC | 06:03 | |
| openstackgerrit | Christian Schwede proposed openstack/swift: Add simple multiple server type test https://review.openstack.org/326399 | 06:08 |
| *** rcernin has joined #openstack-swift | 06:14 | |
| *** chlong has joined #openstack-swift | 06:15 | |
| *** rcernin has quit IRC | 06:18 | |
| *** rcernin has joined #openstack-swift | 06:19 | |
| *** ozeri has joined #openstack-swift | 06:29 | |
| *** takashi has quit IRC | 06:51 | |
| *** tesseract has joined #openstack-swift | 07:00 | |
| *** Jeffrey4l has joined #openstack-swift | 07:09 | |
| *** chlong has quit IRC | 07:15 | |
| *** hseipp has joined #openstack-swift | 07:28 | |
| *** jamie_h has joined #openstack-swift | 07:42 | |
| *** nadeem has quit IRC | 07:44 | |
| kota_ | done the docs patch. Let's move on to the first patch of the review chain. | 07:50 |
| kota_ | acoles: I'm wondering where the patch 328299 located in the patch chain? Do we need to land it before crypt-review chain? Or is it waiting as the last item of the queue? | 07:52 |
| patchbot | kota_: https://review.openstack.org/#/c/328299/ - swift (feature/crypto-review) - crypto - revert EC container update overrides to X... | 07:52 |
| kota_ | hmm... older gerrit is easy to find the chain order but current ui is harder to follow the dependencies. | 07:53 |
| kota_ | older *was* | 07:53 |
| kota_ | anyway, pick up the patch 328203 as next one for review. | 07:54 |
| patchbot | kota_: https://review.openstack.org/#/c/328203/ - swift (feature/crypto-review) - Refactor tests and add tests | 07:54 |
| *** permalac has joined #openstack-swift | 08:00 | |
| ntt | Hi, is there any tool that I can use for backup and automatic upload to swift with file rotation? | 08:04 |
| kota_ | ntt: Though I don't know in detail, amanda back up seems one of the backup software which is able to store the data into OpenStack swift. | 08:20 |
| ntt | kota_: I'm searching for a simple "client" utility.... I don't like to setting up amanda server | 08:21 |
| kota_ | ntt: lol | 08:21 |
| *** ozeri has quit IRC | 08:30 | |
| *** ozeri has joined #openstack-swift | 08:30 | |
| *** dmk0202 has joined #openstack-swift | 08:44 | |
| *** acoles_ is now known as acoles | 09:04 | |
| acoles | kota_: patch 328299 depends on patch 328205, it's a fix for something I spotted after creating the patch chain on feature/crypto-review, and I will be squashing it into 328205 | 09:07 |
| patchbot | acoles: https://review.openstack.org/#/c/328299/ - swift (feature/crypto-review) - crypto - revert EC container update overrides to X... | 09:07 |
| patchbot | acoles: https://review.openstack.org/#/c/328205/ - swift (feature/crypto-review) - Make container update override headers persistent | 09:07 |
| acoles | kota_: thanks for your reviews | 09:07 |
| kota_ | acoles: thanks for that info. ok, the order is 0->1->2 (and patch 328299) -> 3 ->.... | 09:10 |
| patchbot | kota_: https://review.openstack.org/#/c/328299/ - swift (feature/crypto-review) - crypto - revert EC container update overrides to X... | 09:10 |
| acoles | kota_: yes the chain is 328203 -> 328209 in order, 328299 will be squashed into 328205 (so wait before reviewing 328205 if you have not already started, I will make that change today). | 09:12 |
| kota_ | acoles: reading the fist test refactoring, I noticed it probably conflicts my global ec cluster patch 219165. Perhaps I can rework for applying my patch to crypt change... | 09:13 |
| patchbot | kota_: https://review.openstack.org/#/c/219165/ - swift - PUT/GET path for global ec cluster | 09:13 |
| kota_ | :/ | 09:13 |
| acoles | kota_: also the gerrit topics are encryption-0 -> encryption-6 (my git review script worked!) | 09:13 |
| kota_ | I added some statements for the do_setup in the test/unit/proxy/test_server.py :P | 09:13 |
| acoles | kota_: oh, sorry, so that is the conflict ^^ ? the moved code is almost unchanged so hopefully not too hard to diff and re-apply your changes? | 09:15 |
| kota_ | ok, I've not yet for 328205. | 09:15 |
| kota_ | acoles: I hope so :) | 09:15 |
| acoles | kota_: I'll help! | 09:15 |
| kota_ | acoles: yes please^^ | 09:16 |
| acoles | let's wait til it merges though, until then the conflict is imaginary ;) | 09:16 |
| kota_ | yup | 09:17 |
| kota_ | anyway, that patch needs your ec buckets patch for non-durable data though :P | 09:18 |
| kota_ | acoles:^^ | 09:18 |
| acoles | kota_: right! I need to fix that from conflicts too I think :/ | 09:19 |
| *** mvk_ has quit IRC | 09:24 | |
| *** pcaruana has joined #openstack-swift | 09:27 | |
| *** ppai has quit IRC | 09:29 | |
| *** ppai has joined #openstack-swift | 09:30 | |
| *** mvk_ has joined #openstack-swift | 09:51 | |
| *** ppai has quit IRC | 09:53 | |
| *** takashi has joined #openstack-swift | 10:00 | |
| *** ppai has joined #openstack-swift | 10:03 | |
| *** jmccarthy has quit IRC | 10:04 | |
| openstackgerrit | Christian Schwede proposed openstack/swift: Add content-encoding parameter to formpost middleware https://review.openstack.org/328937 | 10:07 |
| *** ppai has quit IRC | 10:10 | |
| *** takashi has quit IRC | 10:17 | |
| *** jmccarthy has joined #openstack-swift | 10:18 | |
| *** ppai has joined #openstack-swift | 10:23 | |
| kota_ | k, done encrypthon-0. | 10:27 |
| kota_ | am going to back home. I'll try to some of the rest tommorow. | 10:28 |
| *** ppai has quit IRC | 10:28 | |
| *** ppai has joined #openstack-swift | 10:39 | |
| *** hosanai has quit IRC | 10:43 | |
| *** kei_yama has quit IRC | 11:01 | |
| *** cdelatte has joined #openstack-swift | 11:02 | |
| *** cdelatte has quit IRC | 11:05 | |
| *** silor has joined #openstack-swift | 11:15 | |
| *** vinsh has joined #openstack-swift | 11:18 | |
| *** NM has joined #openstack-swift | 11:24 | |
| *** ppai has quit IRC | 11:34 | |
| *** ppai has joined #openstack-swift | 11:39 | |
| *** Jeffrey4l has quit IRC | 11:48 | |
| *** Jeffrey4l has joined #openstack-swift | 11:49 | |
| *** raildo-afk is now known as raildo | 12:01 | |
| *** mvk_ has quit IRC | 12:03 | |
| *** NM has quit IRC | 12:04 | |
| *** pauloewerton has joined #openstack-swift | 12:07 | |
| *** oshritf has joined #openstack-swift | 12:32 | |
| *** klamath has joined #openstack-swift | 12:34 | |
| *** klamath has quit IRC | 12:34 | |
| *** klamath has joined #openstack-swift | 12:35 | |
| *** mvk has joined #openstack-swift | 12:49 | |
| *** chlong has joined #openstack-swift | 12:57 | |
| *** sheel has joined #openstack-swift | 13:05 | |
| *** diogogmt has quit IRC | 13:26 | |
| *** hseipp has quit IRC | 13:28 | |
| *** mvk has quit IRC | 13:32 | |
| *** permalac has quit IRC | 13:37 | |
| *** diogogmt has joined #openstack-swift | 13:39 | |
| tdasilva | good morning | 13:47 |
| *** diogogmt has quit IRC | 13:53 | |
| *** pgbridge has joined #openstack-swift | 13:54 | |
| *** links has quit IRC | 13:54 | |
| *** mvk has joined #openstack-swift | 13:56 | |
| *** diogogmt has joined #openstack-swift | 14:01 | |
| acoles | tdasilva: good morning | 14:03 |
| tdasilva | acoles: hello! good job on crypto work! | 14:03 |
| *** rvasilets___ has joined #openstack-swift | 14:06 | |
| acoles | tdasilva: thanks...I'm bracing myself for the review comments ;) | 14:07 |
| tdasilva | acoles: is the plan to have everything merged before hackathon? | 14:08 |
| acoles | tdasilva: yes. notmyname actually estimated 2 weeks. | 14:08 |
| tdasilva | acoles: awesome :) | 14:09 |
| *** diogogmt has quit IRC | 14:12 | |
| *** permalac has joined #openstack-swift | 14:21 | |
| *** ppai has quit IRC | 14:27 | |
| *** ozeri has quit IRC | 14:28 | |
| *** jrichli_ has joined #openstack-swift | 14:32 | |
| *** jrichli_ has left #openstack-swift | 14:33 | |
| *** corvus is now known as jeblair | 14:39 | |
| *** ukaynar has joined #openstack-swift | 14:46 | |
| *** suyash has joined #openstack-swift | 14:57 | |
| *** permalac has quit IRC | 14:58 | |
| *** pgbridge has quit IRC | 14:59 | |
| *** diogogmt has joined #openstack-swift | 15:02 | |
| *** ChanServ changes topic to "Time to review feature/crypto-review https://review.openstack.org/#/q/status:open+project:openstack/swift+branch:feature/crypto-review | Logs: http://eavesdrop.openstack.org/irclogs/%23openstack-swift/ | Meetings: https://wiki.openstack.org/wiki/Meetings/Swift | Hackathon: https://www.eventbrite.com/e/openstack-swift-july-2016-hackathon-tickets-25913773795" | 15:04 | |
| *** _JZ_ has joined #openstack-swift | 15:11 | |
| notmyname | hurricanerix: good morning. seems that when you click through on the hotel reservation link, it says the "contracted rate is no longer available". can you check on this this morning | 15:12 |
| notmyname | (and ping cschwede when it's taken care of?) | 15:12 |
| hurricanerix | notmyname sure thing, they probably hit the room limit, but they told me they could extend it. | 15:13 |
| *** permalac has joined #openstack-swift | 15:13 | |
| notmyname | there are 23 people registered right now on the site | 15:13 |
| cschwede | hurricanerix: notmyname: thx a lot! | 15:14 |
| hurricanerix | np | 15:15 |
| *** pgbridge has joined #openstack-swift | 15:16 | |
| hurricanerix | notmyname cschwede Just talked to Gabby from the hotel and she said she made an update and to try again in about 30 min. If you have trouble after that, let me know and I will bug them again. =) | 15:21 |
| notmyname | thanks! | 15:21 |
| cschwede | hurricanerix: wonderful, thx! | 15:22 |
| *** psachin has quit IRC | 15:22 | |
| notmyname | acoles: any feeling on when you'll normally be fixing up the crypto review branch? beginning of your day or end of your day? | 15:22 |
| hurricanerix | np, sorry about the inconvenience | 15:22 |
| *** dmorita has joined #openstack-swift | 15:27 | |
| *** garthb has joined #openstack-swift | 15:30 | |
| cschwede | hurricanerix: notmyname: thx for the quick help, room is booked & confirmed \o/ | 15:31 |
| *** welldannit has quit IRC | 15:31 | |
| acoles | acoles: i was thinking I would aim to push a new set of patches towards the end of my day, based on reviews that I find at start of my day. make sense? | 15:32 |
| *** klrmn has joined #openstack-swift | 15:32 | |
| acoles | notmyname: question is whether I should do that *every day* or wait for reviews to accumulate. probably depends on quantity of comments. | 15:33 |
| acoles | notmyname: so for example right now I am close to being ready to push responses to kota_'s and timburke's reviews | 15:34 |
| notmyname | yeah, that makes sense (EoD). and as comments accumulate | 15:34 |
| *** awelleck has joined #openstack-swift | 15:34 | |
| *** dmorita has quit IRC | 15:35 | |
| *** dmorita has joined #openstack-swift | 15:35 | |
| hurricanerix | cschwede no problem! see you soon! | 15:36 |
| *** dmorita has quit IRC | 15:37 | |
| *** dmorita has joined #openstack-swift | 15:38 | |
| *** hseipp has joined #openstack-swift | 15:38 | |
| *** tesseract has quit IRC | 15:39 | |
| *** ukaynar has quit IRC | 15:44 | |
| *** gmmaha has quit IRC | 15:44 | |
| *** gmmaha has joined #openstack-swift | 15:45 | |
| *** gmmaha has quit IRC | 15:46 | |
| *** gmmaha has joined #openstack-swift | 15:47 | |
| *** wasmum has quit IRC | 15:49 | |
| *** oshritf has quit IRC | 15:49 | |
| *** dmk0202 has quit IRC | 15:51 | |
| *** dmorita has quit IRC | 15:54 | |
| *** rcernin has quit IRC | 15:59 | |
| *** dmorita has joined #openstack-swift | 15:59 | |
| *** gyee has joined #openstack-swift | 16:10 | |
| *** suyash has quit IRC | 16:11 | |
| *** lyrrad has joined #openstack-swift | 16:11 | |
| *** klrmn has quit IRC | 16:14 | |
| *** rvasilets___ has quit IRC | 16:16 | |
| tdasilva | someone just asked me if I was wearing a Taylor Swift t-shirt :) | 16:20 |
| *** dmorita has quit IRC | 16:24 | |
| jrichli | tdasilva: lol | 16:26 |
| *** suyash has joined #openstack-swift | 16:29 | |
| *** rcernin has joined #openstack-swift | 16:30 | |
| notmyname | lol | 16:33 |
| *** rcernin has quit IRC | 16:35 | |
| *** rcernin has joined #openstack-swift | 16:36 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Refactor tests and add tests https://review.openstack.org/328203 | 16:37 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Support for http footers - Replication and EC https://review.openstack.org/328204 | 16:37 |
| timburke | good morning | 16:38 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Make container update override headers persistent https://review.openstack.org/328205 | 16:38 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Allow middleware to override metadata header checking https://review.openstack.org/328207 | 16:38 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Enable object body and metadata encryption https://review.openstack.org/328208 | 16:38 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Add encryption overview doc https://review.openstack.org/328209 | 16:38 |
| *** pcaruana has quit IRC | 16:38 | |
| *** ukaynar has joined #openstack-swift | 16:38 | |
| *** nadeem has joined #openstack-swift | 16:41 | |
| notmyname | acoles: all updated and ready to pull down for review? | 16:41 |
| acoles | notmyname: err, not sure that worked, hold fire, gerrit is confusing me | 16:42 |
| acoles | please hold off pulling those changes ^^, something went wrong :/ | 16:50 |
| notmyname | well, regardless of that, in about 10 minutes I went from zero crypto to getting it configured, dependencies installed, and saving/reading data that's encrypted. that's pretty cool :-) | 16:53 |
| jrichli | notmyname: yay! | 16:53 |
| *** early has quit IRC | 16:54 | |
| notmyname | and all the on-disk stuff looks like gibberish. so that seems right | 16:57 |
| *** hseipp has quit IRC | 17:04 | |
| *** klrmn has joined #openstack-swift | 17:16 | |
| acoles | tdasilva: so are you wearing a taylor swift t-shirt? ;) | 17:19 |
| acoles | running all the tests again locally | 17:19 |
| tdasilva | lol | 17:19 |
| tdasilva | it's got a big bird on it | 17:19 |
| notmyname | http://cdn.akamai.steamstatic.com/steamcommunity/public/images/avatars/e8/e811ceb28762ad51b3559839f381b524287bdac4_full.jpg | 17:20 |
| acoles | lol | 17:20 |
| *** jamie_h has quit IRC | 17:27 | |
| tdasilva | hahaha, yes, that one | 17:29 |
| *** pcaruana has joined #openstack-swift | 17:39 | |
| hurricanerix | tdasilva oh, i thought it was this one http://store.taylorswift.com/Seagull-Long-Sleeved-Top.html | 17:43 |
| hurricanerix | =) | 17:44 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Make container update override headers persistent https://review.openstack.org/328205 | 17:46 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Enable middleware to set metadata on object POST https://review.openstack.org/328206 | 17:46 |
| *** tongli has joined #openstack-swift | 17:47 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Allow middleware to override metadata header checking https://review.openstack.org/328207 | 17:47 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Enable object body and metadata encryption https://review.openstack.org/328208 | 17:47 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Add encryption overview doc https://review.openstack.org/328209 | 17:47 |
| *** Guest78093 has joined #openstack-swift | 17:50 | |
| *** early has joined #openstack-swift | 17:52 | |
| acoles | ok that looks better ^^ | 17:53 |
| *** ukaynar has quit IRC | 17:55 | |
| *** dmorita has joined #openstack-swift | 18:01 | |
| *** dmorita has quit IRC | 18:05 | |
| *** acoles is now known as acoles_ | 18:09 | |
| *** Jeffrey4l has quit IRC | 18:17 | |
| *** mwheckmann has joined #openstack-swift | 18:18 | |
| *** tqtran has joined #openstack-swift | 18:35 | |
| *** mvk has quit IRC | 18:51 | |
| *** manous has joined #openstack-swift | 19:10 | |
| tdasilva | neat! we've got liberasurecode unit tests on the gate: https://review.openstack.org/#/c/325029 | 19:11 |
| tdasilva | pyeclib is next | 19:11 |
| *** tqtran has quit IRC | 19:11 | |
| *** Guest78093 has left #openstack-swift | 19:16 | |
| *** mwheckmann has quit IRC | 19:26 | |
| *** sheel has quit IRC | 19:35 | |
| *** cebreidian has quit IRC | 19:59 | |
| *** dmorita has joined #openstack-swift | 20:02 | |
| *** mvk has joined #openstack-swift | 20:03 | |
| *** zul has quit IRC | 20:06 | |
| *** acorwin has quit IRC | 20:09 | |
| *** McMurlock has quit IRC | 20:09 | |
| notmyname | tdasilva: great! nice work | 20:11 |
| *** chlong has quit IRC | 20:12 | |
| *** acorwin has joined #openstack-swift | 20:12 | |
| *** tongli has quit IRC | 20:16 | |
| *** _JZ_ has quit IRC | 20:32 | |
| *** tqtran has joined #openstack-swift | 20:34 | |
| *** mwheckmann has joined #openstack-swift | 20:37 | |
| *** StraubTW has joined #openstack-swift | 20:40 | |
| *** StraubTW has left #openstack-swift | 20:40 | |
| *** silor has quit IRC | 20:43 | |
| *** ouchkernel has joined #openstack-swift | 20:48 | |
| notmyname | jrichli: ping | 20:52 |
| jrichli | notmyname ... yes? | 20:53 |
| notmyname | (your name was on the line for git blame, although there are a lot of other authors mentioned in the commit message) | 20:53 |
| notmyname | I'm looking at the crypto middlewares | 20:53 |
| notmyname | jrichli: let me walkt through my thinking, and tell me if I'm thinking about it correctly. and I think there's an issue (simple-ish to fix, probably) | 20:54 |
| jrichli | ok, sure | 20:54 |
| notmyname | all three have a pretty generic __call__ method | 20:54 |
| notmyname | which then does The Right Thing in the related *Context class | 20:55 |
| notmyname | so that's cool, I think | 20:55 |
| notmyname | it means that if we want to do something different later on, all we have to do is add a new method to the class and things Just Work, right? | 20:55 |
| notmyname | eg we've got a GET, so add a PUT or PATCH or whatever else we invent | 20:56 |
| notmyname | eg in DecrypterContext | 20:56 |
| jrichli | yes | 20:56 |
| *** pauloewerton has quit IRC | 20:57 | |
| jrichli | it will call the method with the name of the action | 20:57 |
| notmyname | right | 20:58 |
| notmyname | which is pretty powerful, but you're using user input to call some method | 20:58 |
| notmyname | which means this can happen https://gist.github.com/notmyname/306c498e03b75735bd0768b09e81ae00 | 20:58 |
| notmyname | refresh that. I added the command I used | 20:59 |
| notmyname | so I gave the verb "process_json_response" which is a valid method of DecrypterContext | 20:59 |
| notmyname | we actually used to have this exact same bug in the proxy server a long time ago | 21:01 |
| timburke | haha nice notmyname | 21:01 |
| *** ouchkernel has quit IRC | 21:01 | |
| jrichli | notmyname: oh yes, i see. | 21:01 |
| jrichli | thanks for showing me this | 21:02 |
| notmyname | jrichli: so if you look at proxy/server.py around line 385, you see that it does the getattr with req.method (just like the crypto code does), but then it does another for the publicly_accessible attribute | 21:02 |
| notmyname | jrichli: which the @public decorator adds | 21:02 |
| *** raildo is now known as raildo-afk | 21:02 | |
| notmyname | so something is needed in the crypto middleware like this. either we need something way up front that does all the right filters--probably not good when you think of external middleware. or we need the @public decorators on the *Context classes with the associated checks in the __call__ methods | 21:03 |
| jrichli | ok, i'll work on that tonight | 21:04 |
| notmyname | it's probably simplest to do the @public decorator and check, but I probably haven't thought all the way through it yet. let me know what you think | 21:04 |
| jrichli | i' | 21:05 |
| jrichli | i'll have to play with it and dig in before i have any questions :-). and i cant start this until tonight, probably | 21:05 |
| notmyname | ok :-) | 21:06 |
| notmyname | I'll keep going through it. I'll be pretty busy tomorrow though. might not get too much review time in (someone asked me to step in last-minute to do a talk for them at a local conference) | 21:06 |
| jrichli | that sounds fun | 21:07 |
| jrichli | dont forget to wear a swift taylor shirt ;-) | 21:07 |
| jrichli | i meant taylor swift | 21:07 |
| jrichli | ugh | 21:07 |
| notmyname | I'll have some made up with that pic from earlier :-) | 21:07 |
| jrichli | good plan! be creative | 21:08 |
| *** ouchkernel has joined #openstack-swift | 21:08 | |
| torgomatic | notmyname: jrichli: we have, what, 6 HTTP verbs supported in Swift? PUT, POST, DELETE, GET, HEAD, OPTIONS, and COPY? Probably not even COPY if you're to the right of that middleware. | 21:19 |
| notmyname | yeah, but COPY proves my point though. middleware can add verbs, so we can't filter it eg in catch_errors or gatekeeper | 21:19 |
| torgomatic | a little if/else cascade with 6 entries is not that onerous, and it's simple enough that even I can read it | 21:19 |
| notmyname | but yeah, in the middleware, we could be explicit | 21:20 |
| notmyname | are you thinking just explicitly list them out instead of doing the @public stuff? | 21:20 |
| torgomatic | that's what I was thinking | 21:20 |
| torgomatic | @public wouldn't be bad either | 21:21 |
| notmyname | I'm working on a diff with @public in the decrypter middleware. might play with the explicit choice in keymaster just to compare | 21:22 |
| torgomatic | I think you'd still have the same problem with new verbs either way, though; if someone says "BUFFALO /v1/a/c/o HTTP/ish" and the buffalo middleware is to the right of crypto, then it wouldn't work | 21:22 |
| jrichli | togormatic: that is how it all started out. i think it was suggested to change when we were still supporting the different verbs for containers and accounts as well. | 21:22 |
| torgomatic | whether that's @public, if/elif/elif/else cascade, or whatever | 21:22 |
| notmyname | I thought I was nearly done, then I realized that there is DecrypterObjContext and DecrypterContContext. my eyes went right over that | 21:22 |
| torgomatic | IMO, let's just not add new verbs; then everyone can stick to what's in RFC 7230 and we can all sleep better at night ;) | 21:23 |
| notmyname | torgomatic: no, if user specifies BUFFALO, then we pass through instead of returning 405 | 21:23 |
| notmyname | s/we/crypto/ | 21:23 |
| jrichli | notmyname: yes, there is still the container context because of listings. but we used to also encyrpt/decrypt acct and container user-metadata | 21:23 |
| torgomatic | notmyname: oh, that's fine then | 21:23 |
| notmyname | jrichli: yeah, just my eyes didn't distinguish the difference at first... | 21:24 |
| jrichli | yes. i bring that up because i think that was the reason behind the suggestion: the __call__ cases get a little more lengthy with that extra handling | 21:25 |
| *** _JZ_ has joined #openstack-swift | 21:25 | |
| *** manous has quit IRC | 21:34 | |
| notmyname | jrichli: torgomatic: https://gist.github.com/notmyname/a3cbb534b2d49c2813cbf6da0634d135 | 21:35 |
| torgomatic | notmyname: seems reasonable, except I'd rather have an explicit check for the attribute... something like "if getattr(handler, 'publicly_accessible', False):" | 21:36 |
| torgomatic | "except AttributeError" makes me nervous | 21:37 |
| torgomatic | it's just... lurking there | 21:37 |
| torgomatic | waiting for me to type something like "return self.ap(env, start_response)" | 21:37 |
| notmyname | yeah, makes sense. probably should update the proxy server.py like that too :-) | 21:37 |
| torgomatic | and then BOOM! It pounces and eats half an hour of my time | 21:37 |
| notmyname | ok, gist updated. will work on an explicit method version for keymaster to compare | 21:38 |
| timburke | torgomatic: good thinking. that's exactly the sort of thing that lead to me writing patch 306091 :) | 21:39 |
| patchbot | timburke: https://review.openstack.org/#/c/306091/ - python-openstackclient - Propagate AttributeErrors when lazily loading plugins (MERGED) | 21:39 |
| *** klrmn has quit IRC | 21:47 | |
| *** dmk0202 has joined #openstack-swift | 21:47 | |
| *** rcernin has quit IRC | 21:48 | |
| *** awelleck has quit IRC | 21:55 | |
| *** hoonetorg has quit IRC | 22:05 | |
| *** hoonetorg has joined #openstack-swift | 22:08 | |
| *** chlong has joined #openstack-swift | 22:20 | |
| *** nadeem has quit IRC | 22:24 | |
| *** ouchkernel has quit IRC | 22:32 | |
| *** ouchkernel has joined #openstack-swift | 22:34 | |
| *** ouchkernel has quit IRC | 22:43 | |
| *** ouchkernel has joined #openstack-swift | 22:44 | |
| *** dmk0202 has quit IRC | 22:52 | |
| notmyname | jrichli: torgomatic: FWIW https://gist.github.com/notmyname/a3cbb534b2d49c2813cbf6da0634d135 | 23:01 |
| *** klrmn has joined #openstack-swift | 23:03 | |
| mattoliverau | Morning, just an FYI, I'll probably be mostly out this week in unpacking, getting set up and organising internet etc. I can still be pinged and I'll check in when I can. | 23:06 |
| notmyname | mattoliverau: if you get tired of unpacking, the crypto-review branch will be waiting for you :-) | 23:07 |
| torgomatic | besides, don't you guys have a national broadband network? I bet it's super-easy to connect to and works brilliantly! | 23:07 |
| notmyname | torgomatic: I think mattoliverau would have responded already, but since your comment they got a new prime minister, again, who, again, changed the whole direction of the NBN ;-) | 23:11 |
| *** mwheckmann has quit IRC | 23:18 | |
| mattoliverau | Lol, Yeah don't get me started on the NBN. Let's just say when I do get internet here it won't be very good, so I'll be waiting for the NBN to get to this area.. If it ever makes it that far :p | 23:20 |
| notmyname | jrichli: FYI I've left a diff on the patch chain that does the @public decorator method with some commentary on it. unless you want to do it a different way (which might be entirely likely), no need to work on it tonight :-) | 23:22 |
| *** kei_yama has joined #openstack-swift | 23:34 | |
| *** hosanai has joined #openstack-swift | 23:44 | |
| *** ChanServ sets mode: +v hosanai | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
