Thursday, 2016-06-02

*** kei_yama has quit IRC00:01
*** kei_yama_ has joined #openstack-swift00:01
claygtorgomatic: oh sorry - didn't notice you already had domain sockets wip'd00:01
stewie925hey clayg - after applying the patch the failure is now down to just the test_delete_policy_override_params00:07
stewie925and I see you mentioned youre not sure how the 'test_delete_policy_override_params' is related00:11
claygstewie925: no, i see it now - that was my rant on the ValueError handling in obj/replicatory.py being poorly organized00:13
claygbut basically that test is causing the replicator to call get_part_nodes with 99 and it's blowing up "handling it" and leaving the part around00:13
claygthere might be other tests in there that hit the same code path but aren't triggered to assert on the behavior00:14
claygI think you need to change your code to raise a different exception that's not a ValueError - you'll get a bunch more errors - you should be able to mostly track them down to that code path in the replicator (or something similar in the other consistency daemons)00:14
claygin most cases they're probably not code paths that are mostly just tickled by tests throwing garbage at the fake rings - but each one is an oppertunity to think about how the real code should really handle this condition when it sees it in the wild00:15
claygyou could even just grep around for everywhere that we call get_part_nodes and make sure they're prepared to handle and log the ValueError - then decide where the code goes from there - return an error to a client?  skip the part and go onto the next one?  depends on the context00:16
stewie925hi clayg, yeah I am looking for  a list of errors that may be used for assertRaises00:16
claygthen any tests that are hitting that path can either be updated to expect the new behavior (garbage in garbage out) or updated to provide parts that are reasonable/valid for the test rings they're setting up00:16
claygassertRaises doesn't care what exception you give it?00:17
*** diogogmt has joined #openstack-swift00:17
stewie925am hoping to get a list to see which type of error that I can replace the valueerror with00:18
stewie925also, I assume we need to change this in both  ring.py as well as test_ring.py00:19
claygjust do a plane Exception for now00:23
claygplain?00:24
stewie925oh ok, will do - thanks00:24
stewie925!00:24
*** NM has left #openstack-swift00:35
stewie925hi clayg - I ve changed the assertRaises(ValueError...) to assertRaises(Exception...)   - here are the test results http://paste.openstack.org/show/507059/00:37
*** suyash has quit IRC00:38
stewie925and thank you very much for your help so far, clayg -  will try to get in touch with you tomorrow00:38
openstackgerritTim Burke proposed openstack/python-swiftclient: Suppress InsecureRequestWarning when using --insecure  https://review.openstack.org/32414800:38
claygsorta sucks to unittest behavior of external dependencies don't it :\00:42
stewie925:\00:42
claygcode change - call library like this - unit test - validate called libaary like this - #WOMM00:42
stewie925i apologize can you elaborate the above?00:44
claygstewie925: i was talking to tb00:44
stewie925oops sorry00:44
claygstewie925: np00:45
stewie925well, thank you so much again and good night00:45
claygdon't know unless you ask - it's np00:45
claygstewie925: yeah - thanks for working on that one - sorry to setup the bomb on you - i'm sure you'll get it all squared if you stick with it!  keep asking questions!00:45
* stewie925 waves00:46
stewie925will do, and appreciate your helpfulness00:46
*** stewie925 has quit IRC00:47
timburkeclayg: yeah, it's not great. supposedly it's the way to do it, though00:52
clayglol00:52
claygoh you ment supposedly the way to disable the warning :P00:52
claygi ment supposedly the way to unittest interactions with external dependencies - which is also true as I've come to understand it!00:53
claygyeah I mean the only way to know if that code works is to get a self signed cert going on your dev saio and test it out00:53
timburkehehe also true00:53
claygon the plus side if I review it there's a fair chance vsaio will grow a ssl=true option :P00:53
claygwhich i might want to do to test torgomatic's domain socket thing anyway - so maybe it's wins all around00:54
timburkeclayg: if it does, it might be preferable to set OS_CACERT00:54
claygunless jrichli gets wind of any of this - then I'll be in trouble for not reviewing crypto :\00:54
timburkeclayg: you don't want to make pandas cry, do you??00:55
claygtimburke: is cacert plumbed into the swift endpoint/storage-url or is it just for auth?00:57
*** elambert_ has quit IRC00:57
timburkeif it's just auth, we need to fix it00:57
timburkeclayg: looks like it's good? https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L38500:58
claygyeah I think i went to the original introduction and didn't realize it got improved domewhere along the line -> https://review.openstack.org/#/c/18393/2/swiftclient/client.py00:59
patchbotclayg: patch 18393 - python-swiftclient - Add --os-cacert (MERGED)00:59
claygtimburke: any idea what merged that blew up the copy command change?  :'(01:03
claygtimburke: swiftclient of course01:03
timburkeclayg: ima guess https://review.openstack.org/#/c/323975/01:06
patchbottimburke: patch 323975 - python-swiftclient - Fixed a typo in SwiftService API doc (MERGED)01:06
claygjoel - i used to think docs were good - now i hate them01:06
* clayg thinks that didn't take much :\01:07
openstackgerritTim Burke proposed openstack/python-swiftclient: boolean logic cleanup in service.Swift[Copy|Post]Object  https://review.openstack.org/32180801:08
openstackgerritTim Burke proposed openstack/python-swiftclient: Add copy object method  https://review.openstack.org/28020001:08
timburkeclayg: better?01:08
claygtimburke: did you use the rebase buttom!?01:08
timburkeno, just did it on my machine01:09
claygtimburke: whoa - and the dependent patches too01:09
claygjoel ok, docs can stay - apparently we have tburke-bot for this kind of thing01:09
timburkewell, one, anyway. was there another?01:09
claygtimburke: oh yeah, but everyone hates patch 321815 anyway01:09
patchbotclayg: https://review.openstack.org/#/c/321815/ - python-swiftclient - Use requests CaseInsensitiveDict in swiftclient.co...01:09
timburkei dunno that we *hate* it...01:10
claygoic, hate *me*01:11
openstackgerritTim Burke proposed openstack/python-swiftclient: Use requests CaseInsensitiveDict in swiftclient.copy_object  https://review.openstack.org/32181501:14
*** klrmn has quit IRC01:24
*** sheel has joined #openstack-swift01:28
*** amit213 has joined #openstack-swift01:39
*** amit213 has quit IRC01:41
*** amit213 has joined #openstack-swift01:44
*** kei_yama_ has quit IRC01:45
*** kei_yama has joined #openstack-swift01:45
*** bill_az has quit IRC01:47
*** nadeem has joined #openstack-swift01:55
*** kei_yama has quit IRC01:56
*** klamath has quit IRC01:57
*** klamath has joined #openstack-swift01:57
openstackgerritTim Burke proposed openstack/python-swiftclient: Suppress InsecureRequestWarning when using --insecure  https://review.openstack.org/32414801:57
*** nadeem has quit IRC01:58
*** tanee is now known as tanee_away01:59
*** tanee_away is now known as tanee02:00
*** kei_yama has joined #openstack-swift02:03
kota_back to online again at office02:11
*** nadeem has joined #openstack-swift02:19
*** klrmn has joined #openstack-swift02:21
*** nadeem has quit IRC02:26
*** dmorita has quit IRC02:26
*** StraubTW has joined #openstack-swift02:49
*** diogogmt has quit IRC03:10
*** StraubTW has quit IRC03:20
*** links has joined #openstack-swift03:35
*** zaitcev has quit IRC03:40
*** elambert_ has joined #openstack-swift03:43
*** nadeem has joined #openstack-swift03:47
*** natarej_ has quit IRC03:48
*** natarej_ has joined #openstack-swift03:49
*** nadeem has quit IRC03:54
*** arch-nemesis has joined #openstack-swift03:59
openstackgerritMerged openstack/swift: Adding sorting_method to admin_guide  https://review.openstack.org/32409704:01
openstackgerritOpenStack Proposal Bot proposed openstack/python-swiftclient: Updated from global requirements  https://review.openstack.org/8925004:09
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873604:10
*** sams-gleb has joined #openstack-swift04:13
*** sams-gleb has quit IRC04:17
*** patchbot has quit IRC04:22
*** patchbot has joined #openstack-swift04:22
*** mlanner has quit IRC04:23
*** ctennis has quit IRC04:23
*** Lickitysplitted has quit IRC04:23
*** Lickitysplitted has joined #openstack-swift04:23
*** swifterdarrell has quit IRC04:24
*** dmellado has quit IRC04:24
*** cschwede has quit IRC04:24
*** mmotiani_ has quit IRC04:24
*** cschwede has joined #openstack-swift04:25
*** ctennis has joined #openstack-swift04:25
*** swifterdarrell has joined #openstack-swift04:25
*** ChanServ sets mode: +v swifterdarrell04:25
*** mlanner has joined #openstack-swift04:26
*** dmorita has joined #openstack-swift04:26
*** mmotiani_ has joined #openstack-swift04:26
*** dmellado has joined #openstack-swift04:27
*** dmorita has quit IRC04:31
*** nadeem has joined #openstack-swift04:36
*** psachin has joined #openstack-swift04:47
*** jamielennox is now known as jamielennox|away04:48
*** nadeem has quit IRC04:57
openstackgerritMerged openstack/swift: Fix swift-dispersion in multi-region setups  https://review.openstack.org/32282004:57
*** nadeem has joined #openstack-swift04:58
*** furlongm_ is now known as furlongm04:59
*** jamielennox|away is now known as jamielennox05:04
*** ChubYann has quit IRC05:19
*** hosanai has joined #openstack-swift05:23
*** ChanServ sets mode: +v hosanai05:23
*** janonymous has quit IRC05:26
*** ppai has joined #openstack-swift05:26
*** cguadall_ has joined #openstack-swift05:27
*** cguadall has quit IRC05:30
*** SkyRocknRoll has joined #openstack-swift05:31
*** delatte has quit IRC05:44
*** rcernin has joined #openstack-swift05:48
*** mmcardle has joined #openstack-swift05:51
*** wer has joined #openstack-swift05:51
*** greghaynes has quit IRC05:58
*** jamielennox is now known as jamielennox|away06:01
*** cdelatte has joined #openstack-swift06:03
*** greghaynes has joined #openstack-swift06:10
*** sams-gleb has joined #openstack-swift06:14
*** jamielennox|away is now known as jamielennox06:16
*** sams-gleb has quit IRC06:19
*** arch-nemesis has quit IRC06:20
*** zul has quit IRC06:21
*** mmcardle has quit IRC06:22
*** arch-nemesis has joined #openstack-swift06:35
*** zul has joined #openstack-swift06:36
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Imported Translations from Zanata  https://review.openstack.org/32423406:41
*** ChanServ sets mode: +v cschwede06:51
openstackgerritKota Tsuyuzaki proposed openstack/swift: Add Pros/Cons table for global clusetr consideration  https://review.openstack.org/30438206:51
*** mvk_ has quit IRC06:52
*** tesseract- has joined #openstack-swift06:53
openstackgerritKota Tsuyuzaki proposed openstack/swift: pids in probe is no longer used  https://review.openstack.org/32424606:55
*** sams-gleb has joined #openstack-swift06:55
*** SkyRocknRoll has quit IRC07:05
*** nadeem has quit IRC07:05
*** nadeem has joined #openstack-swift07:12
*** rledisez has joined #openstack-swift07:17
*** SkyRocknRoll has joined #openstack-swift07:22
*** fbo has joined #openstack-swift07:27
kota_I noticed, launchpad says "mitaka series is the current focus of development", interesting.07:33
*** hoonetorg has quit IRC07:38
*** janonymous has joined #openstack-swift07:40
*** elambert_ has quit IRC07:43
*** cguadall_ has quit IRC07:46
*** klrmn has quit IRC07:48
*** hoonetorg has joined #openstack-swift07:50
*** anticw_ has joined #openstack-swift07:55
openstackgerritAlistair Coles proposed openstack/swift: crypto combine crypto.py with crypto_utils.py  https://review.openstack.org/32397807:56
*** acoles_ is now known as acoles07:56
acolesclayg: cheer up, we *love* you and your patches :D07:58
*** SkyRocknRoll has quit IRC08:01
acolesclayg: notmyname huh, I see i just strayed out of my quadrant with my use of the word "love" there, it did feel kindof unnatural08:02
*** SkyRocknRoll has joined #openstack-swift08:08
openstackgerritDavanum Srinivas (dims) proposed openstack/swift: [WIP] Testing latest u-c  https://review.openstack.org/31844108:10
*** nadeem has quit IRC08:21
*** jmccarthy has quit IRC08:31
*** janonymous has quit IRC08:32
*** jmccarthy has joined #openstack-swift08:32
*** arch-nemesis has quit IRC08:45
*** psachin has quit IRC08:45
openstackgerritAlistair Coles proposed openstack/swift: crypto - add tests for override headers  https://review.openstack.org/32429908:47
*** arch-nemesis has joined #openstack-swift08:48
openstackgerritAlistair Coles proposed openstack/swift: crypto - add tests for override headers  https://review.openstack.org/32429908:51
*** mmcardle has joined #openstack-swift08:54
*** psachin has joined #openstack-swift09:01
*** psachin has quit IRC09:01
*** psachin has joined #openstack-swift09:01
*** mmcardle has quit IRC09:02
*** mmcardle has joined #openstack-swift09:09
openstackgerritAlistair Coles proposed openstack/swift: crypto - refactor footers callback  https://review.openstack.org/32431309:10
openstackgerritAlistair Coles proposed openstack/swift: crypto - catch errors when decrypting update override sysmeta (WIP)  https://review.openstack.org/32163809:19
*** arch-nemesis has quit IRC09:22
*** dmorita has joined #openstack-swift09:27
*** dmorita has quit IRC09:32
*** SkyRocknRoll has quit IRC09:33
*** SkyRocknRoll has joined #openstack-swift09:49
*** mmcardle has quit IRC10:01
*** mmcardle has joined #openstack-swift10:02
*** mvk_ has joined #openstack-swift10:41
*** hosanai has quit IRC10:45
openstackgerritMerged openstack/swift: Imported Translations from Zanata  https://review.openstack.org/32423410:47
openstackgerritMerged openstack/swift: crypto combine crypto.py with crypto_utils.py  https://review.openstack.org/32397810:49
openstackgerritMerged openstack/swift: crypto - add tests for override headers  https://review.openstack.org/32429910:49
*** mmuffinman has quit IRC11:00
*** mmuffinman has joined #openstack-swift11:00
*** psachin has quit IRC11:06
*** mmcardle has quit IRC11:19
*** mmcardle has joined #openstack-swift11:20
*** raildo-afk is now known as raildo11:53
*** furlongm has quit IRC11:56
*** furlongm has joined #openstack-swift11:56
acolesnotmyname: please consider patch 324392 backport to liberty12:04
patchbotacoles: https://review.openstack.org/#/c/324392/ - swift (stable/liberty) - Put correct Etag and Accept-Ranges in EC 304 and 4...12:04
*** psachin has joined #openstack-swift12:11
*** hoonetorg has quit IRC12:12
*** sams-gleb has quit IRC12:18
tdasilvaacoles: haha, too funny...keep sharing the love12:23
*** hoonetorg has joined #openstack-swift12:27
mahaticacoles: " so I am going to be bold and go ahead with approving." on 323978. good decision! :)12:32
*** mmcardle has joined #openstack-swift12:34
*** sams-gleb has joined #openstack-swift12:35
openstackgerritAlistair Coles proposed openstack/swift: crypto - remove default root secret  https://review.openstack.org/31820812:52
*** sams-gleb has quit IRC12:54
openstackgerritAlistair Coles proposed openstack/swift: crypto - stop using key id to derive GET path keys  https://review.openstack.org/31814812:55
*** NM has joined #openstack-swift12:56
*** NM has quit IRC12:56
*** NM has joined #openstack-swift12:57
*** kei_yama has quit IRC12:57
*** _JZ_ has joined #openstack-swift13:02
*** ppai has quit IRC13:02
*** sams-gleb has joined #openstack-swift13:08
*** dfg_ has quit IRC13:13
*** klamath has quit IRC13:15
*** klamath has joined #openstack-swift13:16
*** pauloewerton has joined #openstack-swift13:22
*** diogogmt has joined #openstack-swift13:22
*** SkyRocknRoll has quit IRC13:33
*** bill_az has joined #openstack-swift13:37
*** SkyRocknRoll has joined #openstack-swift13:45
*** mmuffinman has quit IRC13:49
*** ametts has joined #openstack-swift13:53
*** bill_az has quit IRC13:57
*** bill_az has joined #openstack-swift13:57
*** sams-gleb has quit IRC14:02
*** sams-gleb has joined #openstack-swift14:03
cschwedenotmyname: I submitted a patch for stable/libery, that we already backported to kilo but somehow missed for Liberty: https://review.openstack.org/#/c/324551/114:09
patchbotcschwede: patch 324551 - swift (stable/liberty) - Fix replicator intersection exception when sync da...14:09
cschwedes/libery/liberty/14:09
*** links has quit IRC14:12
*** diogogmt has quit IRC14:19
*** diogogmt has joined #openstack-swift14:20
*** SkyRocknRoll has quit IRC14:21
*** MikeG451 has joined #openstack-swift14:24
*** dmorita has joined #openstack-swift14:27
*** vint_bra has joined #openstack-swift14:28
*** mmcardle has quit IRC14:29
*** dmorita has quit IRC14:32
*** elambert_ has joined #openstack-swift14:33
*** mmcardle has joined #openstack-swift14:33
*** elambert_ has joined #openstack-swift14:35
*** elambert_ has quit IRC14:39
*** david-lyle has joined #openstack-swift14:44
*** diogogmt has quit IRC14:44
*** cdelatte has quit IRC14:47
*** thumpba has joined #openstack-swift14:49
*** sams-gleb has quit IRC14:49
*** adu has joined #openstack-swift14:50
openstackgerritCheng Li proposed openstack/python-swiftclient: Add an option: disable etag check on downloads  https://review.openstack.org/32315014:54
*** sams-gleb has joined #openstack-swift14:57
*** thumpba has quit IRC15:00
*** thumpba has joined #openstack-swift15:01
*** diogogmt has joined #openstack-swift15:04
*** thumpba has quit IRC15:05
*** arch-nemesis has joined #openstack-swift15:08
*** klrmn has joined #openstack-swift15:12
acolestdasilva: fyi patch 324607 (the bot failed to report it here)15:15
patchbotacoles: https://review.openstack.org/#/c/324607/ - swift - Use source etag when copying unless using Range he...15:15
notmynamegood morning15:15
notmynameacoles: cschwede: ack on the liberty backports15:16
acolesnotmyname: goo dmorning15:16
*** dmorita has joined #openstack-swift15:16
notmynameacoles: well this is going to be interesting for liberty backports http://logs.openstack.org/92/324392/1/check/gate-swift-tox-func-in-process-fast-post/71bba98/console.html#_2016-06-02_12_58_29_17715:17
*** thumpba has joined #openstack-swift15:17
acolesnotmyname: :(15:19
notmynameacoles: maybe an easy way to fix it is to land a change to tox.ini for liberty that defines func-in-process-fast-post exactly the same way as func (ie doesn't set env and just calls .functests)15:19
tdasilvaacoles: ack, looking now15:19
acolesnotmyname: yes, or maybe the same job will pass, i have run func tests with fast post omm for a long time now15:20
acolesnotmyname: or i figure out the correct yaml for it to not be run on the stable branches15:20
notmynamepatch 32461115:23
patchbotnotmyname: https://review.openstack.org/#/c/324611/ - swift (stable/liberty) - added func-in-process-fast-post to mirror func15:23
notmynameacoles: ^15:23
notmynamepatch set 2 fixes the spelling error :-)15:24
notmynameacoles: so let's see if the gate works for that, then land than one first?15:24
acolesnotmyname: gets my vote. thanks15:25
notmynametdasilva: email on the ML putting swiftonfile in a will-be-EOL'd list15:26
notmynameI think? the email is hard to read15:27
notmynameoh, maybe that's just to mark the kilo branch as EOL15:28
acolestimburke: you were +1 on version 6 of this https://review.openstack.org/#/c/318208 - comments addressed in v7 and just rebases since then, are you still +ve?15:29
timburkeacoles: looking...probably...15:29
timburkeacoles: still kinda weirds me out that we're raising the *type* ValueError instead of an *instance of* ValueError15:32
acolestimburke: its valid syntax - the raise creates an instance of the type15:34
timburkek15:35
notmynamehttps://review.openstack.org/#/c/323501/ landed! new client docs for everyone, now15:37
patchbotnotmyname: patch 323501 - openstack-infra/project-config - Publish python-swiftclient docs on every patch (MERGED)15:37
notmynameI'm guessing the next client patch that lands should trigger that15:37
tdasilvanotmyname: looking for email15:39
notmynametdasilva: the -dev list. '[stable][all] Takking kilo-eol for "the world"'15:40
acolestimburke: thanks15:41
*** psachin has quit IRC15:41
notmynametdasilva: *tagging15:42
acolestdasilva: timburke when i cherry pick patch 324607 to feature/crypto the new func test for copy with a Range fails with incorrect etag in container listing. I strongly suspect that is because we copy across the etag override header from the source.15:43
patchbotacoles: https://review.openstack.org/#/c/324607/ - swift - Use source etag when copying unless using Range he...15:43
tdasilvanotmyname: that email is confusing, swiftonfile shows up in list 2, which is described as: "A project is in list 2 that would like to opt *IN* to tagging/EOLing", so I'm assuming it won't be in the list to EOL15:43
notmynametdasilva: yeah, definitely a confusing email15:43
timburkeacoles: makes sense. i was just starting to look at that patch and make sense of what was going on15:44
acolestdasilva: timburke since I don't expect us to stop copying ranges in the next 24 hours I am going to purge the override headers during the copy and hopefully fix things15:44
tdasilvanotmyname: and openstack-ansible is waiting for swift???15:44
timburkeacoles: so should copy always drop the override, or only when doing a ranged GET?15:45
acolestimburke: took me a while to realise that sink_req.etag = source_resp.etag achieves absolutely nothing ;)15:45
tdasilvaI wonder where that code came from :P15:46
notmynametdasilva: that makes sense. since swift isn't EOL'd yet, it doesn't make sense to EOL the ansible-swift stuff either15:46
timburkeyeah, thanks for calling out what was going on in the commit message. sure enough, there's only a _resp_etag_protperty15:46
notmynametdasilva: AFAIK, ansible-swift comes from andymccr15:46
acolestdasilva: I'm not being critical of anyone - it's a language feature that allows it to be written :)15:46
tdasilvanotmyname: no no, sorry, that was a reply to acoles15:47
tdasilvaacoles: haha15:47
timburkeacoles: that's right, get back in your quadrant :P15:47
tdasilvalol15:48
* tdasilva is going to grab some lunch and will be right back15:48
acolestimburke: idk. I am inclined to keep it simple. well, to start with and get things passing the test.15:48
acolestimburke: tdasilva i think we should spend every Friday in one of our 3 alien quadrants15:49
notmynameacoles: :-)15:51
notmynameacoles: "last week I was expressive/non-confrontational. this week, I'll be unexpressive/confrontational"15:53
acolesnotmyname: that's such a bad idea it makes me rage15:56
acolesoops, it's not Friday yet ;)15:56
notmynamelol15:57
*** tesseract- has quit IRC15:59
*** rcernin has quit IRC16:01
*** mvk_ has quit IRC16:03
acolesjrichli: could I beg you to look at patch 318148 again?16:06
patchbotacoles: https://review.openstack.org/#/c/318148/ - swift (feature/crypto) - crypto - stop using key id to derive GET path keys16:06
*** gyee has joined #openstack-swift16:08
*** bill_az has quit IRC16:11
*** bill_az has joined #openstack-swift16:11
*** elambert_ has joined #openstack-swift16:14
tdasilvaacoles: problem is having lived in a different country for more than half of my life, i'm really not sure which quadrant I should be anymore... just something different everyday16:21
*** david-lyle has quit IRC16:24
*** rledisez has quit IRC16:25
*** tesseract has joined #openstack-swift16:44
jrichliacoles: lol.  you only have to ask!16:49
*** tesseract has quit IRC16:51
*** sams-gleb has quit IRC16:52
*** bill_az has quit IRC16:55
*** suyash has joined #openstack-swift16:56
*** mmuffinman has joined #openstack-swift17:03
tdasilvaacoles: re patch 324607, func tests failed for me on my first run. resetting everything and running again...17:11
patchbottdasilva: https://review.openstack.org/#/c/324607/ - swift - Use source etag when copying unless using Range he...17:11
*** mvk_ has joined #openstack-swift17:14
*** dmorita_ has joined #openstack-swift17:14
notmynamecschwede: what do you think about backporting https://review.openstack.org/#/c/303994/ ?17:16
patchbotnotmyname: patch 303994 - swift - Don't delete misplaced dbs if not replicated (MERGED)17:16
*** dmorita has quit IRC17:17
openstackgerritAlistair Coles proposed openstack/swift: crypto - purge crypto sysmeta from responses  https://review.openstack.org/32057917:18
jrichliacoles: I took an initial look.  I left a comment explaining the part I need to think more on before giving a score.  But if you needed to move this forward today, then I can still catch up with you on it later.17:18
acolestimburke: tdasilva patch 320579 now selectively removes the override headers during ranged copies. the func test in patch 324607 will help verify but obviously that's not on feature/crypto.17:20
patchbotacoles: https://review.openstack.org/#/c/320579/ - swift (feature/crypto) - crypto - purge crypto sysmeta from responses17:20
patchbotacoles: https://review.openstack.org/#/c/324607/ - swift - Use source etag when copying unless using Range he...17:20
tdasilvaacoles: looks like there's some issue with *lo in patch 32460717:21
patchbottdasilva: https://review.openstack.org/#/c/324607/ - swift - Use source etag when copying unless using Range he...17:21
tdasilvahttp://logs.openstack.org/07/324607/1/check/gate-swift-tox-func/9ce038c/console.html17:21
*** mmcardle has quit IRC17:22
notmynameworking on the changelog. in this release, we have patches that fix the times when swift might delete data when it's not supposed to and patches that fix the times when swift wasn't deleting data when it's supposed to17:28
tdasilvaacoles: so timburke was correct, the issue with actually assigning the etag to the correct header is that you now get a 422 from the object server when copying *LO objects17:31
acolestdasilva: ok, well we learnt something then :)17:32
timburkenotmyname: i've got a concern that in fixing bug 1582723, we may have created another one (specifically, that containers will report the wrong size for an object that was copied from an EC policy to a replicated one)17:32
openstackbug 1582723 in OpenStack Object Storage (swift) "EC object may have wrong size in container listing after POST" [High,Fix released] https://launchpad.net/bugs/1582723 - Assigned to Alistair Coles (alistair-coles)17:32
timburkewill investigate further, but thought you might want to know for release-related reasons17:33
notmynametimburke: ok, let me know what you find17:33
acolesjrichli: ack. left reply on gerrit.17:33
*** gyee has quit IRC17:40
acolestimburke: are you seeing wrong size after the copy, or after a post to the copied object?17:41
timburkeacoles: i haven't actually seen it yet; it was a thought experiment. i'm becoming more convinced that it's not a real problem, though. the override should be the client-facing size, so it should be the same for both replicated and EC17:42
timburkeworst case, we get an override for an object that didn't technically need it17:43
timburkenotmyname: ^^ i don't think it's actually a problem17:43
clayglooks like we're porting some good fixes back to liberty?  anything particular prompting that?17:43
acolestimburke: ok, phew, that was how i saw it work out, but I do suspect that the x-object-sysmeta-ec-etag/size leaks from the source to the copy. they just happen to have the right values (I think).17:44
notmynameclayg: AFAICT, noticing the good fixes that have landed since we're kinda looking back at them now as part of a new release17:44
*** nadeem has joined #openstack-swift17:44
timburkealso, couldn't hurt in getting that stable-branch checkbox on http://www.openstack.org/software/releases/mitaka/components/swift17:45
acolestimburke: but I'd prefer them not to leak across, if they do, cos it will be very confusing when looking at swift-get-info17:45
notmynametimburke: ack for the copy17:45
*** nadeem has quit IRC17:46
*** nadeem has joined #openstack-swift17:47
acolesclayg: QA people come to me and tell me tempest tests fail with EC17:47
acolesand I have been dragging my feet17:47
*** thumpba has quit IRC17:48
timburkeacoles: yup. maybe something that ECObjectController._fix_response should clean up, like you're doing with the crypto meta?17:48
* acoles afk17:48
acolestimburke: exactly my thought17:48
* acoles afk really17:49
*** dtoast has joined #openstack-swift17:51
*** sams-gleb has joined #openstack-swift17:53
*** thumpba has joined #openstack-swift17:54
*** links has joined #openstack-swift17:56
*** sams-gleb has quit IRC17:58
*** diogogmt has quit IRC18:03
*** diogogmt has joined #openstack-swift18:04
openstackgerritMohit Motiani proposed openstack/python-swiftclient: Inaccurate info about read and write ACL syntax  https://review.openstack.org/32473918:04
openstackgerritShashirekha Gundur proposed openstack/swift: Add content-disposition header to tempurl request  https://review.openstack.org/29390718:05
*** ChubYann has joined #openstack-swift18:05
openstackgerritJohn Dickinson proposed openstack/swift: AUTHORS/CHANGELOG updates for 2.8.0 release  https://review.openstack.org/32474218:06
notmynamefor your consideration ^18:06
*** david-lyle has joined #openstack-swift18:09
*** diogogmt has quit IRC18:10
*** mvk has joined #openstack-swift18:10
*** mvk_ has quit IRC18:13
*** diogogmt has joined #openstack-swift18:13
*** dmorita has joined #openstack-swift18:14
*** dmorita_ has quit IRC18:14
notmynameacoles: cschwede: ok, I'm landing https://review.openstack.org/#/c/324611/ now that the gate passed on it. please rebase your liberty backports on top of it18:21
patchbotnotmyname: patch 324611 - swift (stable/liberty) - added func-in-process-fast-post to mirror func18:21
acolesjrichli: I get you now - I thought you meant passing key_id as an arg of the callback, rather than in response. It shoudl be in the response dict, I have done something bad on that patch while rebasing :/18:21
*** bill_az has joined #openstack-swift18:21
acolesnotmyname: ack18:21
acolesjrichli: I'll have to fix it tomorrow18:22
*** zaitcev has joined #openstack-swift18:22
*** ChanServ sets mode: +v zaitcev18:22
acolesjrichli: looks like I based v7 on v3 :/18:24
*** acoles is now known as acoles_18:27
*** garthb has joined #openstack-swift18:34
*** nadeem has quit IRC18:34
*** david-lyle has quit IRC18:35
openstackgerritMerged openstack/swift: crypto - remove default root secret  https://review.openstack.org/31820818:39
*** links has quit IRC18:39
jrichliacoles: I thought the diff looked strange!  I was thinking i got confused between all the recent patches18:41
*** ChubYann has quit IRC18:53
*** MikeG451 has quit IRC18:53
*** sams-gleb has joined #openstack-swift18:54
*** sams-gleb has quit IRC19:00
*** ChubYann has joined #openstack-swift19:06
*** MikeG451 has joined #openstack-swift19:08
*** thumpba has quit IRC19:09
*** thumpba has joined #openstack-swift19:11
openstackgerritMerged openstack/swift: pids in probe is no longer used  https://review.openstack.org/32424619:22
*** david-lyle has joined #openstack-swift19:24
*** Jeffrey4l_ has quit IRC19:30
*** Jeffrey4l_ has joined #openstack-swift19:31
*** dtoast has quit IRC19:36
*** openstackstatus has quit IRC19:39
*** openstack has joined #openstack-swift19:41
openstackgerritJohn Dickinson proposed openstack/swift: AUTHORS/CHANGELOG updates for 2.8.0 release  https://review.openstack.org/32474219:44
*** david-lyle has quit IRC19:57
*** thumpba has quit IRC20:12
*** tqtran has joined #openstack-swift20:14
NMHello guys!20:17
NMCan someone point out docs or explain how proxies handle write failures? Our proxy returned a 503 for a PUT resquest. However it only tried to write on two object-servers. After those tries, it gave up. Should it have tried more servers? (We use 4 replicas and 12 object-servers)20:18
notmynameNM: what version of swift?20:19
*** rcernin has joined #openstack-swift20:20
notmynameNM: and do you have a pastebin for the logs with that trans id ?20:21
*** gyee has joined #openstack-swift20:31
*** sheel has quit IRC20:35
openstackgerritMichael Barton proposed openstack/swift: go: portability work  https://review.openstack.org/32480720:40
*** raildo is now known as raildo-afk20:56
*** sams-gleb has joined #openstack-swift20:56
*** nadeem has joined #openstack-swift21:00
*** sams-gleb has quit IRC21:01
Vinshanyone know if/when ubuntu will be adding initd scripts for swift-object-replicator?  or maybe that just isn't in the plans?21:01
VinshMaybe they are only going to support systemd ?21:02
VinshI mean reconstructor not replicator.21:02
VinshMost folks using EC probably do so from git or some non package method... but it probably makes the feature less accessible to the others not doing so.21:03
VinshI see a bug from 6 months ago with no activity https://bugs.launchpad.net/ubuntu/+source/swift/+bug/152244821:03
openstackLaunchpad bug 1522448 in swift (Ubuntu) "initd script missing for swift-object-reconstructor process" [Undecided,New]21:03
notmynameVinsh: is canonical/ubuntu doing anything specific for swift or are they just picking up whatever debian does? if the latter, then onovy is your guy.21:05
VinshThey seem to be doing bare-minimum, so likely copy debian21:06
clarkbI thought that zigo said ubuntu does lal of their own packaging for openstack things21:06
VinshThough they do offer the latest versions of swift in UCA.. they don't appear to have upstart support for swift-object-reconstructor yet.21:07
VinshI'm looking to see if they have it for systemd.  same for debian/centos. looking21:07
Vinshah, debian upstream does support it: https://packages.debian.org/sid/all/swift-object/filelist21:09
Vinshso it's just ubuntu slacking21:09
VinshI understand their package team has been understaffed for some time.  I'll see what I can do to correct this/help them.21:10
claygVinsh: you the man!21:10
NMnotmyname: 2.5.0 upgrading to 2.7.021:13
claygNM, if it was in the middle of writing the object when they went offline (with like restart instead of reload) there's nothing it can do to resend the already sent chunks to a different node.21:14
*** adu has quit IRC21:16
*** bill_az has quit IRC21:20
*** pauloewerton has quit IRC21:22
NMclayg: Actually the object storage logged a 201 but they took more then 10sec, the timeout limit21:23
claygNM, ah - yeah that's annoying21:23
NMhttp://pastebin.com/KuPWDBTt21:24
claygdid you have some exception IO going on - like in *addition* to the upgrade?21:24
NMI just wonder why the proxy just gave up after two tries21:24
claygwhat do you mean "gave up" - it was *done* - what else was there for it to do?  wait on the backends forever?21:25
NMSince we have 12 object storage servers, I thought it would try to write on other servers.21:26
claygit had already written it?21:26
notmynameyou don't have any write affinity turned on, do you?21:27
NMWrite no. Just read.21:27
NMI was wondering if there is any rule like 'If the proxy fail to write replicas / 2 without success it wont retry.'21:28
claygwhat are those nodes doing where they're taking >10s to eat a 100K object tho?  even the "fast" nodes where 6 seconds?  is this common in this cluster?  how much ram what's your part power?  do you have containers on these disks?21:28
claygNM the proxy does not buffer the object - once the connections for the backend nodes are made - the bytes stream through - end the end it will gather status from the reaining connections ot determine the success - if the majority has failed/timedout it will return an error - since the bytes have already left the proxy - there is no oppertunity to retry21:29
claygFWIW in this case the fact that all nodes ultimately returned success means the object was fully durable - presumably in the primary locations - so the 5XX response in this case turned out to be conservative21:30
claygAlso, we moved the needle on quorum for even replicas in this last release (2.8) hopefully @notmyname is going to do a great job selling that in the release nodes ;)21:31
clayg*notes21:31
notmynameclayg: patch 324742 line 36. definitely open to different words21:33
patchbotnotmyname: https://review.openstack.org/#/c/324742/ - swift - AUTHORS/CHANGELOG updates for 2.8.0 release21:33
notmynameI didn't do anything to "sell" it, just stated that it changed21:33
NMOne of our clients put millions of object in a single container,  so our load is quite high.21:34
*** bill_az has joined #openstack-swift21:34
notmynamecontainers are on the same drive?21:35
NMclayg: your explanation about the proxy streaming answer my question :)21:35
NMnotmyname:  yes :(21:36
notmynameNM: I only say this because you already know it: don't do that21:36
claygI EAT IOPS FOR BREAKFAST21:37
brianclinefunny you guys mention this 503 frontend vs 201 backend issue... we have just seen this very recently21:37
NMI'll print this chat and show our manager "The guys who created swift are saying to not do that. Can you please give me those ssds?"21:37
notmynamelol21:38
claygnice ;)21:38
*** NM has quit IRC21:38
claygNM it's acctually a pretty good win if you can just put the containers on different devices form the the object devices21:38
claygyou said like 12 nodes?21:38
*** rcernin_ has joined #openstack-swift21:38
brianclinein our case it took a long time for at least one of the data nodes to issue a 100 Continue (longer than node_timeout)21:38
notmynamelooks like he just left?21:38
claygso 2 disks out of 4 of those are probably pleanty for your container durability availablity at that size, or 1 disk out of each node - something like that21:39
claygit should just be ring manipulation and a few rebalances21:39
CaioBrentanonotmyname clayg NM had to leave to pick up his son in school21:39
notmynamebriancline: that's the kind of thing that really intrigues me about the OVH setup. I'd be really interested to know if they've seen that too21:39
notmynameCaioBrentano: ah ok21:39
claygbriancline: in *that* case it should try to grab the next node off the node iter21:39
CaioBrentanoNM typing: I'm sorry to leave that way. I'm really late :(21:40
notmynameno worries. I completely understand21:40
*** CaioBrentano has quit IRC21:41
*** adu has joined #openstack-swift21:41
brianclineclayg: yeah, I think we only had a wireshark trace from one node showing that. though all three still logged 201s (this was on a PUT)21:41
brianclinenotmyname: yeah, me too21:42
brianclinethings like power saving settings and the like can heavily affect that sequence21:43
claygbriancline: i don't see why the node that was slow to give back the 100 continue would have ever seen anymore bytes from the proxy - can't imagine how that turns into a 20121:43
claygbut having nodes timeout in the get final status stanza is pretty common - it's where the fsync is21:43
claygand fucking disks are slow as shit21:43
claygunless you write to them with golang21:43
zaitcevkernel can make it worse with various memory balancing issues21:44
notmynamebriancline: IIRC we had to disable the power saving functions in the drive firmware. that stuff is terrible for swift21:44
zaitcevLike for example if someone plugs a USB key into a storage node21:44
brianclineclayg: I... er.. I think I'm confusing two issues that behaved in the same manner21:44
zaitcevSuddenly every I/O has to wait until something gets drained to that key.21:45
claygzaitcev: use golang21:45
zaitcevclayg: Now you're kidding.21:45
claygit's like pixy dust - did you hear the tweet from PHP CEO?21:45
brianclinenotmyname: yeah. bios too. even the kernel will complain about it21:45
claygbriancline: write the bios in golang21:45
claygsorry i can't stop21:46
clayg... i'll stop21:46
zaitcevYes. It was a tweet urging to rewrite everything in APPLE Swift, right?21:46
notmynamezaitcev: https://twitter.com/php_ceo/status/73808833802485760221:46
zaitcevnotmyname: that sounds like a parody account21:46
brianclineso, discounting the 100-Continue bit I metnioned.. what was strange in the 5xx/201 case is that each object node logged that they completed the write in <1 sec. but the proxy logged an entry node_timeout seconds later than all of the entries with its 5xx status21:47
claygbriancline: that *is* interesting!21:47
notmynamesounds like eventlet hub starvation21:47
claygbriancline: could point to network congestion, or hub starvation on the object server nodes - sometimes they lie about how long they take - were you looking at the log line timestamps or just the time recording on the log line?21:47
brianclineI'd have to check the ticket but I think we're still trying to figure that one out21:47
zaitcevI'm wondering if a switch could cause that.21:48
zaitcevI'll shut up now21:48
brianclinenotmyname: yeah. that was one of my initial hunches21:48
claygyeah it could totally just be packets in the wind21:48
claygbut hub starvation is a real deal - if your clocks are syncronized pretty good sometimes you can get hints of it from timestamps - esp if your node timeout is big enough where you're gunna spot that kind of thing21:48
claygI had a patch to make eventlet tell the truth a little more in the storage nodes - but i didn't follow through21:49
notmynameclayg: we'll just rewrite that part in golang, right?21:49
brianclinelol21:50
zaitcev*groan*21:50
claygnotmyname: srly, hub starvation shouldn't be a thing we have to talk about - fucking python21:50
zaitcevWhy not. It's a basic technology and modern switches unfortunately do very deep packet inspection. It's a reality with which we have to deal.21:51
brianclineclayg: on the timestamps I believe I was looking at syslog's timestamp. on the proxy I can see a line where container-quotas checked the container when the request came in, then the 5xx status line for the actual request a bit later21:51
claygbriancline: found it!  https://review.openstack.org/#/c/173622/21:52
patchbotclayg: patch 173622 - swift - Better storage server eventlet logging (ABANDONED)21:52
brianclineguess I'd better double check the actual request start timestamp in the proxy log21:52
brianclineoh yeah, I remember this now21:53
brianclineman, that feels way more recent than 9 months ago :|21:53
claygoh yeah i was going to statsd that shit!21:55
clayg:'(21:55
claygsigh21:55
*** ametts has quit IRC22:03
*** nadeem has quit IRC22:04
*** nadeem has joined #openstack-swift22:06
*** rcernin_ has quit IRC22:06
*** nadeem has quit IRC22:07
mattoliverauMorning22:16
*** klrmn has quit IRC22:17
*** klrmn has joined #openstack-swift22:18
*** klamath has quit IRC22:19
*** openstackgerrit has quit IRC22:19
*** openstackgerrit has joined #openstack-swift22:20
torgomaticmorning22:34
*** _JZ_ has quit IRC22:34
*** klrmn has quit IRC22:39
*** klrmn has joined #openstack-swift22:39
*** _JZ_ has joined #openstack-swift22:41
*** NM has joined #openstack-swift22:46
*** NM has quit IRC22:48
*** adu has quit IRC22:52
*** sams-gleb has joined #openstack-swift22:58
*** sams-gleb has quit IRC23:03
*** rcernin has quit IRC23:10
*** dtoast has joined #openstack-swift23:11
*** MikeG451 has quit IRC23:12
*** arch-nemesis has quit IRC23:16
*** david-lyle has joined #openstack-swift23:20
*** adu has joined #openstack-swift23:23
zaitcevI'm going to ask something terrible23:30
zaitcevDo we even have a document like old install_multinode.rst that would be like "do this, this, this to add EC policy to your cluster"23:30
*** CaioBrentano has joined #openstack-swift23:32
*** kei_yama has joined #openstack-swift23:33
notmynamezaitcev: http://docs.openstack.org/developer/swift/overview_erasure_code.html#using-an-erasure-code-policy is probably the closest23:34
notmynametdasilva: looks like we need to update links on http://docs.openstack.org/developer/swift/overview_erasure_code.html#pyeclib-external-erasure-code-library23:34
zaitcevnotmyname: I already have that document, but thanks a lot, I'll run through it again23:35
notmynamezaitcev: ok. I was thinking "you just gotta add the stanza to swift.conf" and that's pretty much it23:36
zaitcevyay23:36
zaitcevthe example starts with 2, so I presume discontiguous policy indexes are permissible.23:37
mattoliverauzaitcev: you can use any index you want so long as you continue using it for that policy.23:40
notmynameand it's an integer >= 123:41
*** hosanai has joined #openstack-swift23:43
*** ChanServ sets mode: +v hosanai23:43
*** _JZ_ has quit IRC23:45
*** bill_az has quit IRC23:49
*** hosanai has quit IRC23:49
*** bill_az has joined #openstack-swift23:51
zaitcevI'm enjoying devops if only of a short while.23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!