Friday, 2016-01-08

*** diogogmt has quit IRC00:00
*** nadeem has quit IRC00:01
*** kei_yama has quit IRC00:06
*** kei_yama has joined #openstack-swift00:07
notmynametsg_: ping00:11
notmynametsg_: given the client-visible length of an object (eg I uploaded a 100MB file), can pyeclib tell me how long the fragment archive will be?00:12
notmynameit's soemthing like this00:12
notmynameexpected_fa_size = client_cl // segment_size * fragment_size + tail00:12
notmynamewhere tail = pyeclib.tell_me_size_of_this(client_cl % segments)00:13
notmynameie the ec'd left over bits that don't fill up the last segment00:13
*** haomaiwang has joined #openstack-swift00:18
*** haomaiwang has quit IRC00:24
*** openstackgerrit has quit IRC00:32
*** openstackgerrit has joined #openstack-swift00:33
redbo_I don't know, how do we feel about these?  I don't mind them, but some people do.  "port = match.group('port') or port"00:35
openstackgerritTimur Alperovich proposed openstack/swift: Fix IPv6 handling in MemcacheConnPool.  https://review.openstack.org/25870400:39
*** lcurtis has quit IRC00:39
*** m_kazuhiro has joined #openstack-swift00:40
torgomatic_notmyname: it's not even that generators have tp_del defined; it's that has_finalizer() in gcmodule.c has an explicit check for generators with a corresponding set of conditions00:41
torgomatic_for everything else, it's whether or not tp_del is filled in00:41
notmynametorgomatic_: what could possibly go wrong!00:42
*** zhill has joined #openstack-swift00:46
openstackgerritCatherine Northcott proposed openstack/swift: [WIP] Get Accounts by Cluster  https://review.openstack.org/26208700:50
ZyricI think I have the first version of the get accounts by cluster patch going - which is to say it's logging, filtering, and displaying okay in my local environment.00:52
*** zhill has quit IRC00:53
*** garthb__ has quit IRC00:56
*** garthb__ has joined #openstack-swift00:59
notmynameZyric: cool01:12
*** haomaiwang has joined #openstack-swift01:12
Zyricnotmyname: The account data (names/paths) doesn't have a real home yet. Should be stored in the recon cache, or someplace in info? I'll add some comments to the patch.01:14
Zyricnotmyname: I could use some feedback at this point, should I take the WIP off to encourage review even though it's still very rough?01:16
*** haomaiwang has quit IRC01:16
notmynameZyric: yeah, that's a good idea01:17
notmynameZyric: I'm about to head home, so I won't get a chance to look at it today01:18
Zyricnotmyname: No worries, I can spend the rest of the week doing patch review and fixing small bugs.01:19
notmynamecool, nice01:20
*** tsg_ has quit IRC01:28
*** garthb__ has quit IRC01:34
*** changbl has joined #openstack-swift01:36
*** fthiagogv has quit IRC01:39
*** badari_ has quit IRC01:44
claygtimur: I think maybe like latest memcache with trusty (1.4.14) does *not* support ipv6?01:48
claygtimur: I tried all the invocations of memcached -l ::1 that I could think of but it kept complaining about parsing it like a port01:49
*** badari has joined #openstack-swift01:50
*** badari has quit IRC02:02
*** haomaiwang has joined #openstack-swift02:10
*** robefran has quit IRC02:14
openstackgerritBing Hu proposed openstack/python-swiftclient: Support uploading to an object in swift from stdin update code and add unittest use mkstemp instead of NamedTemporaryFile, upadte unittest Closes-bug: #1521342  https://review.openstack.org/25941002:16
openstackbug 1521342 in python-swiftclient "support uploading from a stdin stream" [Wishlist,In progress] https://launchpad.net/bugs/1521342 - Assigned to Bing Hu (hubingsh)02:16
claygtimur: so you have to have *the latest* memcache 1.4.25 - tagged Nov '1502:17
clayghttps://github.com/memcached/memcached/wiki/ReleaseNotes142502:17
claygi would have swore we had memcache_server.conf reloading now?02:48
claygGD, i bet we never merged it02:49
claygpatch 21849002:50
patchbotclayg: https://review.openstack.org/#/c/218490/ - Automatic refresh of memcache config settings02:50
claygi guess I can't complain if I never reviewed it - i thought i did02:51
*** badari has joined #openstack-swift03:00
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-swift03:01
*** gyee has quit IRC03:04
*** sanchitmalhotra has joined #openstack-swift03:06
clayghow do you review a change in gerrit!?03:11
claygi found reply at the top - but it has no scores - i am very confused03:11
claygwow ok, i was old an old patch set03:12
*** janonymous has quit IRC03:16
*** badari has quit IRC03:27
*** janonymous has joined #openstack-swift03:30
*** dmorita has quit IRC03:40
openstackgerritCatherine Northcott proposed openstack/swift: Get Accounts by Cluster  https://review.openstack.org/26208703:42
*** Jeffrey4l has quit IRC03:43
mattoliverauclayg: yeah, patchsets are also confusing, ie which one your in etc.03:43
*** dmorita has joined #openstack-swift03:43
*** Jeffrey4l has joined #openstack-swift03:55
*** haomaiwang has quit IRC04:01
*** haomaiwa_ has joined #openstack-swift04:01
*** diogogmt has joined #openstack-swift04:14
*** links has joined #openstack-swift04:27
*** diogogmt has quit IRC04:32
*** ppai has joined #openstack-swift04:47
openstackgerritMerged openstack/swift: Merge branch 'master' into feature/hummingbird  https://review.openstack.org/26451704:54
*** ajiang has joined #openstack-swift04:58
*** bhakta has joined #openstack-swift04:59
*** haomaiwa_ has quit IRC05:01
*** haomaiwa_ has joined #openstack-swift05:01
*** doxavore has quit IRC05:02
*** suresh_ has joined #openstack-swift05:03
suresh_hi, using a separate partition for Swift data or using a loopback device instead of another partition Which is the best practice ?05:05
suresh_please someone help05:05
*** trifon has joined #openstack-swift05:10
*** klrmn1 has quit IRC05:12
*** blmartin has quit IRC05:13
*** yatin has joined #openstack-swift05:13
kota_hello05:17
mattoliverausuresh_: for a SAIO you mean?05:19
mattoliveraukota_: o/05:19
*** trifon has quit IRC05:19
kota_mattoliverau: o/05:21
*** yatin has quit IRC05:24
*** jamielennox is now known as jamielennox|away05:27
*** esker has joined #openstack-swift05:31
*** yatin has joined #openstack-swift05:36
*** yatin has quit IRC05:37
suresh_mattoliverau:  In any case either SAIO or Cluster05:39
*** trifon has joined #openstack-swift05:40
*** mragupat has joined #openstack-swift05:40
*** mragupat has quit IRC05:42
*** mragupat has joined #openstack-swift05:42
mattoliverausuresh_: loop back is really just for SAIO, it's better to use a bunch of disks, mounted those mount points become the devices in the ring.05:43
suresh_mattoliverau: For SAIO i added my strogae nodes05:45
suresh_but in swift-recon --diskusage command shows only disks which are not loop backdevices05:46
*** ppai has quit IRC05:49
* suresh_ slaps bsdkurt around a bit with a large fishbot05:58
*** haomaiwa_ has quit IRC06:01
*** haomaiwang has joined #openstack-swift06:01
*** wuhg has joined #openstack-swift06:02
*** SkyRocknRoll has joined #openstack-swift06:02
*** dslevin has quit IRC06:06
*** dslevin has joined #openstack-swift06:07
*** SkyRocknRoll has quit IRC06:07
*** logan- has quit IRC06:08
*** logan- has joined #openstack-swift06:08
*** siva_krishnan has quit IRC06:09
*** patchbot has quit IRC06:09
*** notmyname has quit IRC06:09
*** sgundur has quit IRC06:09
*** patchbot has joined #openstack-swift06:09
*** notmyname has joined #openstack-swift06:10
*** ChanServ sets mode: +v notmyname06:10
*** asettle has joined #openstack-swift06:10
*** sgundur has joined #openstack-swift06:11
*** esker has quit IRC06:13
*** siva_krishnan has joined #openstack-swift06:15
*** bkmz_ has quit IRC06:16
*** bkmz has joined #openstack-swift06:16
*** ChubYann has quit IRC06:21
*** suresh_ has quit IRC06:22
*** yatin has joined #openstack-swift06:26
*** Jeffrey4l has quit IRC06:27
*** dmorita has quit IRC06:35
*** dmorita has joined #openstack-swift06:36
*** Lickitysplitted has joined #openstack-swift06:36
*** dmorita_ has joined #openstack-swift06:38
*** dmorita has quit IRC06:38
*** dmorita_ has quit IRC06:38
*** Jeffrey4l has joined #openstack-swift06:40
*** mragupat has quit IRC06:45
openstackgerritLiuNanke proposed openstack/python-swiftclient: Put py34 first in the env order of tox  https://review.openstack.org/26510606:48
*** ppai has joined #openstack-swift06:49
*** itlinux has joined #openstack-swift06:58
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-swift07:01
*** jsuchome has joined #openstack-swift07:02
*** Jeffrey4l has quit IRC07:09
*** itlinux has quit IRC07:14
*** itlinux has joined #openstack-swift07:15
*** itlinux has quit IRC07:16
*** Jeffrey4l has joined #openstack-swift07:21
*** yarkot has quit IRC07:28
*** logan- has quit IRC07:44
*** arnox has joined #openstack-swift07:59
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-swift08:02
*** asettle has quit IRC08:06
*** asettle has joined #openstack-swift08:06
*** cschwede has joined #openstack-swift08:10
*** zaitcev has quit IRC08:10
*** asettle has quit IRC08:11
*** rledisez has joined #openstack-swift08:15
*** haomaiwang has quit IRC08:19
*** philipw_ has quit IRC08:22
*** philipw has joined #openstack-swift08:22
*** ChanServ sets mode: +v cschwede08:22
*** jistr has joined #openstack-swift08:24
*** haomaiwang has joined #openstack-swift08:24
*** Jeffrey4l has quit IRC08:33
*** SkyRocknRoll has joined #openstack-swift08:35
openstackgerritrenminmin proposed openstack/swift: Byte-quotas should allow object re-upload  https://review.openstack.org/26322708:37
*** yatin has quit IRC08:37
*** Jeffrey4l has joined #openstack-swift08:49
*** haomaiwang has quit IRC08:50
*** marekkaleta has joined #openstack-swift08:51
timurclayg: right -- I did not notice when they packaged it up. When I was looking at the change initially, they still haven't released it and I actually tested with the master branch08:52
timurI'll update the review to reflect that08:52
*** trifon has quit IRC08:52
timurabout the failure mode: I agree that it would be better to fail in the constructor (or if there is any other config validation that runs, we could fail ealier?). Although, I'd rather defer that into another patchset08:52
timurI'm happy to submit it for review, though -- will look into that tomorrow08:53
timurare there strong objections to defering that work? my rationale is to keep commits to the smallest changes possible and the IP address issue existed prior to IPv6 work08:54
*** haomaiwa_ has joined #openstack-swift08:54
*** trifon has joined #openstack-swift08:56
*** kaleta has joined #openstack-swift08:59
*** haomaiwa_ has quit IRC09:01
*** haomaiwa_ has joined #openstack-swift09:05
openstackgerritKazuhiro MIYAHARA proposed openstack/swift: Remove execute permissions  https://review.openstack.org/26514509:05
*** marekkaleta has quit IRC09:06
*** marekkaleta has joined #openstack-swift09:06
*** wmn-tech has quit IRC09:22
*** wuhg has quit IRC09:28
*** suresh has joined #openstack-swift09:31
openstackgerritKota Tsuyuzaki proposed openstack/swift: Add note COPY with conditional headers  https://review.openstack.org/26515409:32
sureshhi, I am getting dispersion while doing swift-ring-builder rebalance Is it really a problem09:33
sureshplease someone help09:33
openstackgerritting wang proposed openstack/swift: Use the oslo.utils.reflection to extract the class name  https://review.openstack.org/26515509:35
*** yatin has joined #openstack-swift09:39
*** jordanP has joined #openstack-swift09:39
*** suresh has quit IRC09:42
*** acoles_ is now known as acoles09:45
ahaleyou are probably trying to make a ring change that needs to move more partitions around than is possible - i would deploy the unbalanced ring then wait until replication has moved that data around and/or your dispersion-report looks better, then do more rebalances until it can get balanced09:45
*** suresh has joined #openstack-swift09:46
sureshI am getting dispersion while doing rebalance09:46
sureshplease someone help09:46
*** haomaiwa_ has quit IRC09:47
openstackgerritKazuhiro MIYAHARA proposed openstack/swift: Remove execute permissions from files which are not run  https://review.openstack.org/26514509:49
*** haomaiwang has joined #openstack-swift09:50
*** joeljwright has joined #openstack-swift09:51
*** ChanServ sets mode: +v joeljwright09:51
*** Jeffrey4l has quit IRC10:00
*** haomaiwang has quit IRC10:01
*** haomaiwang has joined #openstack-swift10:01
*** Jeffrey4l has joined #openstack-swift10:06
*** janonymous has quit IRC10:06
*** yatin has quit IRC10:16
*** yatin has joined #openstack-swift10:17
*** hseipp has joined #openstack-swift10:17
acolescd ../swift10:42
acolesoops10:42
onovyjupiter:~ onovy$ passwd10:47
onovyChanging password for onovy.10:47
onovyOld Password: mySecretPassword10:47
onovyoops sry too10:47
acolesonovy: :)10:48
acolesmahatic: patch 211451 merged so I will rebase others now10:51
patchbotacoles: https://review.openstack.org/#/c/211451/ - Modify unit tests to include real crypto (MERGED)10:51
openstackgerritAlistair Coles proposed openstack/swift: Remove content-type encryption/decryption  https://review.openstack.org/26129210:54
openstackgerritOpenStack Proposal Bot proposed openstack/python-swiftclient: Updated from global requirements  https://review.openstack.org/17398210:56
*** kaleta has quit IRC10:57
*** kaleta has joined #openstack-swift10:57
*** daemontool has joined #openstack-swift10:58
*** kaleta has quit IRC10:59
*** kaleta has joined #openstack-swift10:59
acolesmahatic: so to pick up from yesterday...you now need to pull latest version of patch 261292 from gerrit, check its ok, then rebase your other patch (multipart) on that and push it to gerrit11:00
patchbotacoles: https://review.openstack.org/#/c/261292/ - Remove content-type encryption/decryption11:00
acolesmahatic: i abandoned the patches that got pushed by mistake yesterday to avoid any confusion11:00
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-swift11:01
*** acoles is now known as acoles_11:02
*** kaleta has quit IRC11:05
*** kaleta has joined #openstack-swift11:05
*** kaleta has quit IRC11:09
*** kaleta has joined #openstack-swift11:09
*** marekkaleta has quit IRC11:10
openstackgerritPeter Lisák proposed openstack/swift: Change schedule priority of daemon/server in config  https://review.openstack.org/23879911:10
*** acoles_ is now known as acoles11:10
*** janonymous has joined #openstack-swift11:11
*** janonymous has quit IRC11:24
*** haomaiwang has quit IRC11:28
*** sanchitmalhotra has quit IRC11:34
mahaticacoles: thanks much! I was busy with some paper work, just around to these, will pick it up11:35
mahaticjust got around*11:36
acolesmahatic: ok. it would be worth checking 261292 to make sure it is still removing all the content-type stuff, because there may have been stuff added in 211451 since 261292 got authored11:36
mahaticcorrect11:37
mahaticacoles: ccould you let me know what is that you had to do 261292? Because since 211451 one is merged, I thought, you'd point 261292 to the latest feature/crypto?11:38
acolesmahatic: actually i took a risk and pushed rebase on gerrit! but checked that the parent it used was in fact the commit id of 211451 (gerrit will show you the parent commit id for a patch set)11:39
suresh I am getting dispersion while doing rebalance11:40
sureshplease someone help11:40
mahaticacoles: oh, how come it didn't show conflicts? (there was the small change I pointed out and you corrected on 211451)11:40
*** silor has joined #openstack-swift11:41
mahaticacoles: I'll start with checking 26129211:41
acolessuresh see ahale reply 2 hours ago. i'm not best person to answer your question.11:44
acolessuresh: but in general if you see large dispersion it means that some partitions' replicas cannot be spread across your devices ideally.11:44
acoleswhich may be due to device weights preventing that happening. the overload option can be used to allow weight to be 'overridden' somewhat.11:45
acolessuresh: but, i don't have a great deal of experience doing that in production, so maybe ask here again in US timezone11:46
acolesmahatic: it would only show conflict if it failed to merge changes11:46
sureshacoles: Thanks for your reply11:47
mahaticacoles: yes, come to think of it, you only removed stuff11:47
acolesmahatic: well, i did put in a couple of extra tests...for the bad iv and bad key11:49
mahaticacoles: oh no, I mean the very last patchset11:49
mahatic:)11:49
mahaticacoles: because of my comment on some bad iv that was not required in a test11:49
mahatic261292 has your changes apart from the last minor one11:50
acolesmahatic: looking11:55
sureshIs having more Zones is a problem or Not11:56
onovysuresh: hi, are you adding new devices?11:56
onovyif yes, how much vs. how much do you have actually11:56
onovy+what is your replication factor11:56
sureshonovy: yes i am adding new devices and i have 3 replicas11:57
mahaticacoles: oh nevermind, I meant it before looking at the changes (and before jenkin's +1). I verified now, looks like it does11:57
onovyall questions and answers pls :)11:57
onovyswift will move only one replica of partion per rebalance, so all data is available. so if you added too much space to cluster, it's normal to have dispersion11:58
onovywait at least min_part_hours and do rebalance again11:58
onovymin_part_hours should be bigger "convergate" time. so all replicas are on correct place after it11:59
sureshonovy:  I am setting min_part_hours to zero Is it is a problem12:01
sureshonovy: vs means12:03
onovyit's production cluster?12:04
onovywith r/w traffic?12:04
sureshonovy: yeah it's for production12:05
onovyso don't set min_part_hours to 012:06
acolesmahatic: errr, https://review.openstack.org/#/c/261292/4/test/unit/common/middleware/test_decrypter.py lines 92 126 and 161 - that is what I was worried about. #willfix12:06
onovyyou can have data unvailable12:06
onovyno data lost, but unavailable for read or for new put to existing cont./acc.12:06
onovyyou should do rebalance, wait for rebalance finished and then do another rebalance12:07
onovyi could recommend one book for swift admins. mmnt12:07
onovysuresh: http://shop.oreilly.com/product/0636920033288.do this12:07
mahaticacoles: how did you even find them? :) when they were in "skipped common lines"12:07
onovythere is explained how to add new devices to small cluster12:07
onovywith small weight for example12:07
*** yatin has quit IRC12:09
sureshonovy: if i have 1 hour min_part_time means after adding new device i should wait one hour to rebalance12:09
onovyno :)12:09
onovyit means swift-ring-builder will rebalance it after 1 hour12:09
onovyat first12:10
onovyif you call it12:10
*** km_ has quit IRC12:10
onovyyou should look into logs of replicator12:10
onovymin_part_time is just soft limit. you choose "how long will replication probably take"12:10
onovyyou can put 24/48 hours here. after this time, cluster __should__ be balance12:11
onovybut you couldn't be sure12:11
onovyuse swift-dispersion-populate/report to check. and logs of replicator12:11
openstackgerritAlistair Coles proposed openstack/swift: Remove content-type encryption/decryption  https://review.openstack.org/26129212:12
acolesmahatic: ^^ I'm not sure about the skipped tests in there but i can't review it all today12:12
*** yatin has joined #openstack-swift12:12
mahaticacoles: sure, no problem. They are mean to used to test etag12:13
mahaticmeant*12:13
acolesmahatic: so grab that version ^^ and use it to rebase your other patch12:14
sureshonovy: when doing rebalance its giving some two lines warning  like No partitions could be reassigned. Either none need to be or none can be due to min_part_hours [1].12:14
sureshIs this is a problem12:14
mahaticacoles: yup, thanks12:14
onovysuresh: yes, because you are rebalancing before min_part_hours time12:14
onovyif you wait this time, rebalance will fix dispersion then12:14
onovyof course if it's possible to "fix it". sometimes it's not possible12:14
sureshonovy: when should i wait Before rebalancing or after rebalancing12:15
onovyrebalance, push it to cluster, wait, rebalance, push it to cluster, wait, ...12:16
*** yatin has quit IRC12:17
onovyswift cores: this review https://review.openstack.org/#/c/257577/ should help with problems like suresh have now12:17
*** ppai has quit IRC12:19
*** kei_yama has quit IRC12:23
sureshonovy: If i am using different Zones for different devices i am not getting dispersion Is it recommendable way12:24
*** jmccarthy has quit IRC12:26
*** jmccarthy has joined #openstack-swift12:27
onovysuresh: different zones is fine12:28
*** suresh has quit IRC12:28
*** ppai has joined #openstack-swift12:32
openstackgerritMahati Chamarthy proposed openstack/swift: Decrypt multipart mime doc  https://review.openstack.org/24837712:53
*** m_kazuhiro has quit IRC12:53
*** Jeffrey4l has quit IRC12:53
*** esker has joined #openstack-swift13:13
*** esker has quit IRC13:20
*** links has quit IRC13:25
*** miurahr has quit IRC13:32
*** ppai has quit IRC13:40
openstackgerritStuart McLaren proposed openstack/python-swiftclient: Retry download of object body  https://review.openstack.org/15920813:42
*** Jeffrey4l has joined #openstack-swift13:45
*** sileht has quit IRC13:46
*** sileht has joined #openstack-swift13:48
*** badari has joined #openstack-swift14:02
*** asettle has joined #openstack-swift14:07
*** dslevin has quit IRC14:10
*** asettle has quit IRC14:12
*** jordanP is now known as jordanP|away14:14
*** SkyRocknRoll has quit IRC14:16
*** esker has joined #openstack-swift14:17
*** esker has quit IRC14:22
*** esker has joined #openstack-swift14:22
*** jsuchome has quit IRC14:25
*** C1ShaunID has joined #openstack-swift14:27
*** petertr7_away is now known as petertr714:47
*** esker has quit IRC14:48
*** jordanP|away is now known as jordanP14:50
*** haomaiwa_ has joined #openstack-swift14:51
*** esker has joined #openstack-swift14:54
*** yarkot has joined #openstack-swift14:55
*** blmartin has joined #openstack-swift14:56
*** esker has quit IRC14:58
*** haomaiwa_ has quit IRC15:01
*** esker has joined #openstack-swift15:01
*** haomaiwang has joined #openstack-swift15:02
*** lpabon has joined #openstack-swift15:03
*** esker has quit IRC15:08
*** esker has joined #openstack-swift15:09
*** esker has quit IRC15:15
*** petertr7 is now known as petertr7_away15:19
*** esker has joined #openstack-swift15:20
*** petertr7_away is now known as petertr715:24
*** SkyRocknRoll has joined #openstack-swift15:24
*** esker has quit IRC15:25
*** diogogmt has joined #openstack-swift15:25
*** esker has joined #openstack-swift15:30
*** C1ShaunID has left #openstack-swift15:30
*** breitz has quit IRC15:30
*** esker has quit IRC15:30
*** breitz has joined #openstack-swift15:31
*** mragupat has joined #openstack-swift15:38
*** bjkeller has joined #openstack-swift15:41
*** links has joined #openstack-swift15:47
*** diogogmt has quit IRC15:50
*** garthb__ has joined #openstack-swift15:51
*** lcurtis has joined #openstack-swift15:53
*** lcurtis has quit IRC15:58
*** esker has joined #openstack-swift16:00
*** esker has quit IRC16:00
*** haomaiwang has quit IRC16:01
*** haomaiwang has joined #openstack-swift16:01
*** diogogmt has joined #openstack-swift16:03
*** klrmn has joined #openstack-swift16:06
*** diogogmt has quit IRC16:08
*** zigo has quit IRC16:09
*** zigo has joined #openstack-swift16:10
*** yarkot has quit IRC16:11
*** petertr7 is now known as petertr7_away16:11
*** diogogmt has joined #openstack-swift16:12
*** daemontool has quit IRC16:15
*** petertr7_away is now known as petertr716:17
*** links has quit IRC16:27
*** jistr has quit IRC16:33
*** lcurtis has joined #openstack-swift16:34
*** dslevin has joined #openstack-swift16:40
*** gyee has joined #openstack-swift16:40
*** dslevin has quit IRC16:42
*** dslevin__ has joined #openstack-swift16:42
*** dslevi___ has joined #openstack-swift16:45
*** dslevin__ has quit IRC16:47
*** blmartin has quit IRC16:48
*** nadeem has joined #openstack-swift16:50
*** blmartin has joined #openstack-swift16:50
*** nadeem has quit IRC16:50
*** nadeem has joined #openstack-swift16:51
*** dslevi___ has quit IRC16:59
*** mragupat has quit IRC16:59
*** mragupat has joined #openstack-swift17:00
*** haomaiwang has quit IRC17:01
*** haomaiwang has joined #openstack-swift17:01
*** dslevin has joined #openstack-swift17:07
*** dslevin has quit IRC17:10
*** klrmn has quit IRC17:13
*** esker has joined #openstack-swift17:16
openstackgerritAlistair Coles proposed openstack/python-swiftclient: Retry download of object body  https://review.openstack.org/15920817:20
*** esker has quit IRC17:25
*** joeljwright has quit IRC17:30
*** dslevin__ has joined #openstack-swift17:39
*** dmorita has joined #openstack-swift17:41
*** dslevin__ has quit IRC17:42
*** jordanP has quit IRC17:45
notmynamegood morning17:47
*** dslevin has joined #openstack-swift17:48
*** dslevin has quit IRC17:48
*** dslevin has joined #openstack-swift17:48
*** zhill has joined #openstack-swift17:58
*** haomaiwang has quit IRC18:01
*** haomaiwang has joined #openstack-swift18:01
*** dslevin has quit IRC18:02
*** dslevin has joined #openstack-swift18:02
*** mragupat_ has joined #openstack-swift18:02
*** tristanC_ has joined #openstack-swift18:04
*** wbhuber has quit IRC18:04
*** tristanC has quit IRC18:04
*** bsdkurt has quit IRC18:04
*** bsdkurt has joined #openstack-swift18:04
*** onovy has quit IRC18:05
*** wbhuber has joined #openstack-swift18:05
*** rledisez has quit IRC18:05
*** mragupat has quit IRC18:06
*** dslevin has quit IRC18:07
*** proteusguy_ has quit IRC18:11
*** onovy has joined #openstack-swift18:12
*** SkyRocknRoll has quit IRC18:13
*** klrmn has joined #openstack-swift18:16
openstackgerritTim Burke proposed openstack/swift: Autovivify X-Versions-Location container  https://review.openstack.org/26501518:21
*** proteusguy_ has joined #openstack-swift18:23
*** klrmn has quit IRC18:26
*** klrmn has joined #openstack-swift18:28
claygtimur: yeah I think follow up dependent patch for ipv6 memcache config validation is the right thing - good judgement - still need to get the doc update in.18:34
*** arnox has quit IRC18:40
*** acoles is now known as acoles_18:41
*** hseipp has quit IRC18:41
*** pgbridge has joined #openstack-swift18:41
*** petertr7 is now known as petertr7_away18:43
*** silor has quit IRC18:43
*** zaitcev has joined #openstack-swift18:43
*** ChanServ sets mode: +v zaitcev18:43
*** dmorita has quit IRC18:52
*** itlinux has joined #openstack-swift18:53
*** delattec has joined #openstack-swift18:53
*** geaaru has joined #openstack-swift18:54
*** dmorita has joined #openstack-swift18:54
*** delatte has quit IRC18:56
*** dmorita has quit IRC18:57
*** dmorita has joined #openstack-swift18:59
*** haomaiwang has quit IRC19:01
*** dmorita has quit IRC19:01
*** haomaiwang has joined #openstack-swift19:01
*** dmorita has joined #openstack-swift19:03
*** asettle has joined #openstack-swift19:06
*** asettle has quit IRC19:11
*** dmorita has quit IRC19:13
*** dmorita has joined #openstack-swift19:13
*** dmorita has quit IRC19:16
*** dmorita has joined #openstack-swift19:17
*** dmorita has quit IRC19:20
*** itlinux has quit IRC19:20
*** dmorita has joined #openstack-swift19:20
*** dmorita has quit IRC19:22
*** dmorita has joined #openstack-swift19:24
notmynameI cleaned up the starred patches. I unstarred a lot; the 3 that are starred now are ones that I'd like to see land today or monday so we can have a release asap (swift 2.6.0)19:27
notmynameafter a release, I can go back through and re-star things that are prioritized19:28
*** Jeffrey4l has quit IRC19:31
*** Jeffrey4l has joined #openstack-swift19:32
openstackgerritTim Burke proposed openstack/python-swiftclient: _RetryBody doesn't need to track etag/content-length  https://review.openstack.org/26541719:32
*** dmorita has quit IRC19:37
*** chsc has joined #openstack-swift19:38
timurclayg: yep -- I'll upload both in the next hour or so19:39
*** petertr7_away is now known as petertr719:39
*** delatte has joined #openstack-swift19:40
*** delattec has quit IRC19:40
*** dmorita has joined #openstack-swift19:43
openstackgerritTim Burke proposed openstack/python-swiftclient: _RetryBody doesn't need to track etag/content-length  https://review.openstack.org/26541719:44
*** chsc has quit IRC19:46
*** delatte has quit IRC19:55
*** dmorita has quit IRC19:57
*** dmorita has joined #openstack-swift19:59
*** haomaiwang has quit IRC20:01
*** zhill has quit IRC20:01
*** haomaiwang has joined #openstack-swift20:01
ZyricGood morning20:01
*** dmorita has quit IRC20:02
*** dmorita has joined #openstack-swift20:03
*** dmorita has quit IRC20:03
*** ChubYann has joined #openstack-swift20:08
*** cdelatte has joined #openstack-swift20:13
openstackgerritTim Burke proposed openstack/swift: Fix versioned_writes functional test skipping  https://review.openstack.org/26501720:19
*** dmorita has joined #openstack-swift20:32
*** blmartin has quit IRC20:38
*** dmorita has quit IRC20:55
*** garthb_ has joined #openstack-swift20:58
*** garthb__ has quit IRC20:59
*** daemontool has joined #openstack-swift20:59
*** haomaiwang has quit IRC21:01
*** haomaiwang has joined #openstack-swift21:01
claygtimur: yay!21:08
*** cdelatte has quit IRC21:09
claygacoles_: timburke: tell stuart congrats on the retry download of object body patch!  nice work on the review.21:09
*** dmorita has joined #openstack-swift21:13
*** blmartin has joined #openstack-swift21:14
*** minwoob has joined #openstack-swift21:15
*** dmorita has quit IRC21:18
*** daemontool has quit IRC21:27
*** zhill has joined #openstack-swift21:29
*** dmorita has joined #openstack-swift21:32
*** dmorita has quit IRC21:32
*** daemontool has joined #openstack-swift21:32
openstackgerritTim Burke proposed openstack/swift: Fix versioned_writes functional test skipping  https://review.openstack.org/26501721:33
*** diogogmt has quit IRC21:40
*** diogogmt has joined #openstack-swift21:41
*** garthb_ has quit IRC21:44
*** garthb_ has joined #openstack-swift21:44
*** esker has joined #openstack-swift21:59
*** esker has quit IRC21:59
*** dmorita has joined #openstack-swift21:59
*** haomaiwang has quit IRC22:01
*** haomaiwang has joined #openstack-swift22:01
*** esker has joined #openstack-swift22:03
*** esker has quit IRC22:17
timurclayg: I finished the follow on patch and looked at documenting the IPv6 behavior. I think it makes sense to either add it to the top level module paragraph "Why our own memcache client?.." or to the description of the MemcacheConnPool class. I'd rather not document the internal _get_addr() method. What do you think is best?22:22
*** esker has joined #openstack-swift22:22
timurI think the best way would be to document the parameters to the constructor, but it looks like the __init__ documentation is skipped/not desired by default and I'd rather not break away from that22:23
claygtimur: well i obviously thought it better to extract _get_addr to a pure function and paramertize server - documenting our parser as a toplevel function22:23
claygtimur: I think a class docstring is preferred to explicitly documenting __init__22:24
timurclayg: right, I got that from the gist, but my hesitation is that its really internal to the pool class (hence not wanting to move it out)22:24
claygtimur: if there's not already a __doc__ on the MemcacheConnPool I think you should add one22:24
timurThere is a very short blurb and I was thinking about expanding it to describe the _server_ parameter22:25
claygtimur: yup, probably best22:25
timuralright, let me do that and upload it and we can iterate on that if you'd prefer the top-level get_addr function22:25
*** esker has quit IRC22:27
claygtimur: i'm sure I'd prefer the MemcacheConnPool's parsing of ipv6 strings moved to a pure function - in fact I'd probably just rather have it in utils - but you're correct that's neither here nor their for this patch - get something in docs somewhere (doc-tree for config opts, class docstring, etc/sample.conf, man pages - SOMEWHERE) and then we can do follow up patches for all of that and the others22:27
*** petertr7 is now known as petertr7_away22:34
timurclayg: alright, sounds good. utils sounds like the right place for it22:36
claygtimur: ok, again, can be follow up - and now that you've mentioned it - probably want to update the class doc for the server param anyway (and if you extrat the parser then to be stay dry you'll want to figure out the sphinx syntax to reference the utils function!)22:44
claygtimur: sorry :\22:44
claygtimur: I really just wanted words somewhere a deployer/operator might have a chance of using it - in case we don't get any of the other docs in at least having words in the sample configs would be pretty good22:45
openstackgerritPaul Dardeau proposed openstack/swift: Look for device holes that can be reused when adding new device.  https://review.openstack.org/26546122:51
clayg^ pdardeau whoot whoot!22:51
pdardeauclayg: :-)22:54
*** mragupat_ has quit IRC22:55
claygpdardeau: at first glance I feel like try: devs.index(None) except ValueError: len(devs) + 1 might do the same thing?22:56
clayg... i'm checking out the branch now22:56
pdardeauclayg: i figured there was probably a better way, but my python-fu is still low22:57
claygpdardeau: what about if you try to create a new dev with device_id > 65K - seperate patch?22:57
*** bjkeller has left #openstack-swift22:57
pdardeauclayg: good question. let me have a look22:58
*** haomaiwang has quit IRC23:01
*** haomaiwang has joined #openstack-swift23:01
openstackgerritTimur Alperovich proposed openstack/swift: Fix IPv6 handling in MemcacheConnPool.  https://review.openstack.org/25870423:01
openstackgerritTimur Alperovich proposed openstack/swift: Fail early if the memcache address is invalid.  https://review.openstack.org/26546523:01
pdardeauclayg: OverflowError: unsigned short is greater than maximum23:02
timurclayg: no problem. Updated the original review to add documentation and the commit message. I also uploaded the follow-on patch to fail early. Will work on the next patch to move _get_addr() and its test into utils in a bit23:03
claygtimur: sure np, i'll take a look!23:04
*** asettle has joined #openstack-swift23:06
claygpdardeau: well, unittests seem to think this would be good enough -> https://gist.github.com/clayg/409b9ed47fa550cfc8ca23:07
pdardeauclayg: more elegant, for sure23:11
*** asettle has quit IRC23:12
pdardeauclayg: agreed. cleaner and much more succinct23:14
claygpdardeau: i think there might be some test cases missing (you're going to have to submit again 'cause pep8 anyway I think)23:14
claygso... it'd be nice to have a assertRaises(Duplicate) for when you add a dev specifying id that exists (is there already such a test?)23:15
claygpdardeau: k, scratch that - test_add_dev does exactly that - so already covered there23:15
pdardeauclayg: good point. i don't think there is a test for that23:15
pdardeauok23:16
claygpdardeau: I think also both tests use the common add/remove-first-n setup - so you never exercise this code on a ring like [dev, dev, None, dev, dev, None]23:16
claygit'd be nice to like add three devs to that ring and verify new_dev_ids is [2, 5, 6] or something like that maybe?23:16
clayg... so just that one more test I think - I'm glad it seems to be a fairly stright forward fix - thanks for filing the bug23:17
pdardeauclayg: thanks. i'll make those updates and make another patch23:18
claygAWESOME!23:19
claygtimur: !! rfc3986 link - KUDOS!23:21
timurclayg: yea, I figured that's better than the wiki :)23:23
claygtimur: although on my machine https://tools.ietf.org/html/rfc3986#page-19 links into the relevant 3.2.2 Host section a little better :23:24
claygtimur: I guess using external links in docs is always risky like that :'(23:24
timurclayg: that's actually my fault, it should be: https://tools.ietf.org/html/rfc3986#section-3.2.223:25
timurbecause we want to refer to the _section_ and not the page23:25
timurlet me fix that23:25
claygtimur: oh yeah, that's probably less brittle - good call23:25
claygtimur: I like the cut of your jib man23:26
openstackgerritTimur Alperovich proposed openstack/swift: Fix IPv6 handling in MemcacheConnPool.  https://review.openstack.org/25870423:27
timurI'll update the follow-on commit after the first one merges (to avoid the unnecessary verifier runs)23:28
claygtimur: poor jenkins :'(23:29
timurmore like, poor other people waiting for patches23:29
timurbut jenkins too :)23:30
*** minwoob has quit IRC23:32
*** itlinux has joined #openstack-swift23:47
*** pgbridge has quit IRC23:55
*** nadeem has quit IRC23:59
*** trifon has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!