Friday, 2015-09-18

*** m_kazuhiro has joined #openstack-swift00:00
*** garthb has quit IRC00:10
*** hrou has joined #openstack-swift00:15
*** 77CAATUOY has joined #openstack-swift00:22
*** 18VAAO48R has joined #openstack-swift00:22
*** CR7 has quit IRC00:26
*** jkugel has joined #openstack-swift00:33
*** annegentle has joined #openstack-swift00:34
*** darrenc is now known as darrenc_afk00:37
*** david-lyle has quit IRC00:40
*** david-lyle has joined #openstack-swift00:44
*** kota_ has joined #openstack-swift00:45
*** ChanServ sets mode: +v kota_00:45
kota_good morning00:45
claygkota_: hey I was working on your patch!  hope that's ok :\00:51
kota_clayg: thanks! I noticed that and will look at in today ;)00:52
*** dipe has quit IRC00:54
*** darrenc_afk is now known as darrenc01:00
*** 18VAAO48R has quit IRC01:03
*** 77CAATUOY has quit IRC01:03
mattoliveraukota_: morning01:10
*** annegentle has quit IRC01:10
kota_mattoliverau: morning!01:12
*** dmorita has quit IRC01:18
*** jrichli has joined #openstack-swift01:24
*** dmorita has joined #openstack-swift01:26
*** rohit_ has quit IRC01:50
*** haomaiwang has joined #openstack-swift01:56
*** jkugel has quit IRC02:00
*** haomaiwang has quit IRC02:01
*** haomaiwa_ has joined #openstack-swift02:05
*** haomaiwa_ has quit IRC02:05
*** haomaiwa_ has joined #openstack-swift02:06
*** baojg has joined #openstack-swift02:17
*** baojg has quit IRC02:20
*** baojg has joined #openstack-swift02:22
*** gyee has quit IRC02:30
*** esker has joined #openstack-swift02:44
*** haomaiwa_ has quit IRC03:01
*** haomaiwang has joined #openstack-swift03:01
*** DericHorn-HP has joined #openstack-swift03:12
*** esker has quit IRC03:19
*** bill_az has quit IRC03:34
*** tongli has joined #openstack-swift03:35
*** garthb has joined #openstack-swift03:36
*** garthb has quit IRC03:42
*** trifon has quit IRC03:50
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-swift04:01
*** ktsuyuzaki has joined #openstack-swift04:03
*** kota_ has quit IRC04:04
*** kota_ has joined #openstack-swift04:08
*** ChanServ sets mode: +v kota_04:08
*** ktsuyuzaki has quit IRC04:09
*** jrichli has quit IRC04:10
*** ktsuyuzaki has joined #openstack-swift04:12
*** kota_ has quit IRC04:14
*** kota_ has joined #openstack-swift04:17
*** ChanServ sets mode: +v kota_04:17
*** ktsuyuzaki has quit IRC04:19
*** ktsuyuzaki has joined #openstack-swift04:19
*** kota_ has quit IRC04:21
*** kota_ has joined #openstack-swift04:22
*** ChanServ sets mode: +v kota_04:22
*** ktsuyuzaki has quit IRC04:24
*** ktsuyuzaki has joined #openstack-swift04:24
*** kota_ has quit IRC04:26
*** kota_ has joined #openstack-swift04:27
*** ChanServ sets mode: +v kota_04:27
*** ktsuyuzaki has quit IRC04:29
*** ktsuyuzaki has joined #openstack-swift04:29
*** kota_ has quit IRC04:31
*** kota_ has joined #openstack-swift04:34
*** ChanServ sets mode: +v kota_04:34
*** ktsuyuzaki has quit IRC04:35
*** kota_ has quit IRC04:36
*** tongli has quit IRC04:42
*** trifon has joined #openstack-swift04:48
brianclineugh, keystoneclient somehow broke openstackclient in the last few days04:49
*** m_kazuhiro has quit IRC04:54
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-swift05:01
brianclineos-client-config rather05:09
*** m_kazuhiro has joined #openstack-swift05:21
*** SkyRocknRoll has joined #openstack-swift05:28
*** nakagawamsa has joined #openstack-swift05:30
*** openstackgerrit has quit IRC05:31
*** openstackgerrit has joined #openstack-swift05:31
*** DericHorn-HP has quit IRC05:37
*** m_kazuhiro has quit IRC05:46
*** hrou has quit IRC05:56
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-swift06:01
*** baojg has quit IRC06:12
*** baojg has joined #openstack-swift06:19
*** jroll has quit IRC06:27
*** DericHorn-HP has joined #openstack-swift06:28
*** DericHorn-HP has quit IRC06:31
*** jroll has joined #openstack-swift06:33
*** baojg has quit IRC06:33
*** DericHorn-HP has joined #openstack-swift06:36
*** baojg has joined #openstack-swift06:39
*** mac_ified has quit IRC06:48
*** DericHorn-HP has quit IRC06:48
*** geaaru has joined #openstack-swift06:56
*** kota_ has joined #openstack-swift06:56
*** ChanServ sets mode: +v kota_06:56
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-swift07:01
*** rledisez has joined #openstack-swift07:04
*** DericHorn-HP has joined #openstack-swift07:09
*** rledisez has quit IRC07:17
*** DericHorn-HP has quit IRC07:19
*** rledisez has joined #openstack-swift07:20
*** HenryG has quit IRC07:21
*** acoles_ is now known as acoles07:27
*** esker has joined #openstack-swift07:27
*** esker has quit IRC07:28
*** esker has joined #openstack-swift07:28
*** aix has joined #openstack-swift07:42
*** jst_ has joined #openstack-swift07:56
*** resker has joined #openstack-swift07:57
*** esker has quit IRC08:00
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-swift08:01
*** baojg has quit IRC08:01
*** dmorita has quit IRC08:04
*** T0m_ has joined #openstack-swift08:05
*** T0m_ has left #openstack-swift08:05
*** jistr has joined #openstack-swift08:07
*** baojg has joined #openstack-swift08:08
*** jordanP has joined #openstack-swift08:09
*** HenryG has joined #openstack-swift08:12
*** aix has quit IRC08:13
*** HenryG has quit IRC08:16
*** baojg has quit IRC08:17
*** baojg has joined #openstack-swift08:18
*** aix has joined #openstack-swift08:27
*** silor has joined #openstack-swift08:29
*** HenryG has joined #openstack-swift08:30
openstackgerritChristopher Bartz proposed openstack/swift-specs: formpost should allow subprefix-based signature  https://review.openstack.org/22505908:34
*** ho has quit IRC08:46
*** chlong has quit IRC08:47
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-swift09:01
*** nakagawamsa has quit IRC09:16
*** hezhiqiang has quit IRC09:28
*** haomaiwang has quit IRC10:01
*** haomaiwang has joined #openstack-swift10:01
*** SkyRocknRoll has quit IRC10:21
*** km has quit IRC10:38
*** baojg has quit IRC10:45
*** baojg has joined #openstack-swift10:46
*** baojg has quit IRC10:50
*** flwang has quit IRC10:53
*** mfalatic has quit IRC11:00
*** SkyRocknRoll has joined #openstack-swift11:00
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-swift11:01
*** mfalatic has joined #openstack-swift11:06
*** kei_yama has quit IRC11:08
*** flwang has joined #openstack-swift11:10
*** hezhiqiang has joined #openstack-swift11:26
openstackgerritChristopher Bartz proposed openstack/swift-specs: formpost should allow subprefix-based signature  https://review.openstack.org/22505911:38
*** bill_az has joined #openstack-swift11:42
*** cdelatte has joined #openstack-swift11:48
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-swift12:01
*** chlong has joined #openstack-swift12:06
*** chlong has quit IRC12:07
*** chlong has joined #openstack-swift12:07
*** jkugel has joined #openstack-swift12:10
*** haomaiwang has quit IRC12:19
*** kota_ has quit IRC12:24
*** janonymous has joined #openstack-swift12:31
*** SkyRocknRoll_ has joined #openstack-swift12:50
*** fifieldt has quit IRC13:00
*** janonymous has quit IRC13:03
*** kutija has quit IRC13:05
*** hrou has joined #openstack-swift13:09
*** haomaiwang has joined #openstack-swift13:13
*** amoturi has joined #openstack-swift13:15
*** haomaiwang has quit IRC13:15
*** dustins has joined #openstack-swift13:16
*** haomaiwang has joined #openstack-swift13:16
*** pberis has joined #openstack-swift13:25
*** wbhuber has joined #openstack-swift13:25
*** nadeem has joined #openstack-swift13:32
*** nadeem has quit IRC13:32
*** nadeem has joined #openstack-swift13:33
*** SkyRocknRoll has quit IRC13:41
*** SkyRocknRoll_ has quit IRC13:42
*** jrichli has joined #openstack-swift13:42
*** openstackgerrit has quit IRC13:46
*** openstackgerrit has joined #openstack-swift13:46
*** tongli has joined #openstack-swift13:58
*** haomaiwang has quit IRC14:01
*** 77CAAT0IJ has joined #openstack-swift14:01
*** SkyRocknRoll has joined #openstack-swift14:15
*** SkyRocknRoll_ has joined #openstack-swift14:15
*** SkyRocknRoll has quit IRC14:18
*** SkyRocknRoll has joined #openstack-swift14:19
*** baojg has joined #openstack-swift14:30
*** jroll is now known as jroll|dupe14:31
*** jlhinson has joined #openstack-swift14:31
*** jroll|dupe is now known as brickednick14:31
*** david-lyle has quit IRC14:31
*** brickednick is now known as jroll14:31
*** baojg has quit IRC14:45
*** minwoob has joined #openstack-swift14:54
*** wbhuber has quit IRC14:55
*** wbhuber has joined #openstack-swift14:57
*** wbhuber_ has joined #openstack-swift15:00
*** 77CAAT0IJ has quit IRC15:01
*** haomaiwang has joined #openstack-swift15:01
*** jistr is now known as jistr|call15:02
*** wbhuber has quit IRC15:04
*** mac_ified has joined #openstack-swift15:10
*** resker has quit IRC15:14
*** esker has joined #openstack-swift15:14
*** trifon has quit IRC15:15
*** lpabon has joined #openstack-swift15:20
*** pberis has quit IRC15:26
*** DericHorn-HP has joined #openstack-swift15:27
*** bill_az has quit IRC15:28
*** janonymous has joined #openstack-swift15:28
*** chsc has joined #openstack-swift15:37
*** gyee has joined #openstack-swift15:42
*** pberis has joined #openstack-swift15:47
*** haomaiwang has quit IRC16:01
*** haomaiwang has joined #openstack-swift16:01
peluseacoles, you there?16:04
acolespeluse: yup16:04
peluseits Fri night right? :)16:04
acolesyup16:05
acolesgetting close anyway16:05
peluseso hey, where's the hot patch on Ec in the alt frag chain / opt GET stuff right now?  I can go through and try to figure out where to jump back in but figured I'd ask instead...16:05
acolespeluse: patch 215276 is where i am working on optimistic gets16:06
patchbotacoles: https://review.openstack.org/#/c/215276/16:06
acolespeluse: what is there kinda works but i'd like to improve it (see TODO's inline)16:07
*** jordanP has quit IRC16:08
acolespeluse: i think it will be more efficient if the fallback GETS (ones that require durable) are targetted to nodes where we have learnt that there is a durable.16:08
peluseOK, so it looks like we scrapped alt_frags for now and extracted the dict stuff from it as its own to patch to move forward on opt GET?16:08
peluseoh I see, even alt frags is dependent on that one now...16:09
peluseOK, I'll go review that one next, looks like clay is already god with it.  cool16:10
pelusegood16:10
peluseclayg, don't let that typo go to your head :)16:10
acolespeluse: yeah, i didnt want optimistics to get trapped dependeing on alt frags but wanted to share the get_ondisk_files change16:10
peluseacoles, makes sense16:10
*** haomaiwang has quit IRC16:11
janonymousHi16:11
janonymousI think i have seen this issue before also but couldn't remember : https://bugs.launchpad.net/bugs/149725616:11
openstackLaunchpad bug 1497256 in swift-bench "SWIFT unit tests failing giving the error (liberasurecode[1907]: liberasurecode_backend_open: dynamic linking error libJerasure.so: cannot open shared object file: No such file or directory)" [Undecided,New]16:11
acolespeluse: cool if you can review that patch 222706 that'd be great16:11
patchbotacoles: https://review.openstack.org/#/c/222706/16:11
pelusejanonymous, yeah, something didn't go right with the install of pyeclib16:12
peluseacoles, on it16:12
pelusejanonymous, try just reinstalling pyeclib16:13
*** janonymous_ has joined #openstack-swift16:13
janonymous_peluse: Is it wrong version in requirements .. ?16:13
acolespeluse: i spent today hacking patch 222706 some more. i want to make it much smarter about going after durables when the optimistic get fails to get one i.e. when backend returns a non-durable it also tells proxy if it has an older durable.16:15
patchbotacoles: https://review.openstack.org/#/c/222706/16:15
*** janonymous has quit IRC16:15
*** garthb has joined #openstack-swift16:15
acolespeluse: i think its all gonna end up colliding back into the alt frags thing - 'alt' becomes another frag at same timestamp or another frag thats older but durable.16:16
peluseacoles, a good reason to do the opt get stuff first!16:17
pelusejanonymous_, well some things are in flux there so install the version that's in requirements.txt16:17
*** mfalatic has quit IRC16:17
acolespeluse: clayg so patch 222706 is WIP for now16:18
patchbotacoles: https://review.openstack.org/#/c/222706/16:18
janonymous_peluse: Ohhkay, so the fix of the bug would be to install the correct version16:20
acolespeluse: another good one to review would be clayg's patch 218023 - jenkins has a -1 but i suspect it just needs a rebase and i had a +2 on it16:20
patchbotacoles: https://review.openstack.org/#/c/218023/16:20
*** mfalatic has joined #openstack-swift16:20
*** DericHorn-HP has quit IRC16:20
pelusejanonymous_, I can't say that as I don't know what went wrong with your install :) tsg and/or keving are working on the getting the newest in there and there were some problems with versioning (downrev support) which is why its in flux.  The new version has all sorts of little fixes in there so maybe...16:21
peluseacoles, cool.  will put that next on my list and maybe get 2 things done today!16:21
janonymous_janonymous: Ohh  cool. thanks16:22
janonymous_*peluse16:22
*** mfalatic_ has joined #openstack-swift16:26
*** jistr|call is now known as jistr16:28
janonymous_acoles , peluse : could you answer a small question: Does this have a impact on swift also https://bugs.launchpad.net/nova/+bug/136136016:29
openstackLaunchpad bug 1361360 in Sahara "Eventlet green threads not released back to the pool leading to choking of new requests" [Medium,Confirmed] - Assigned to Xurong Yang (idopra)16:29
*** jistr has quit IRC16:30
*** jordanP has joined #openstack-swift16:30
*** mfalatic has quit IRC16:30
*** jordanP has quit IRC16:30
*** mfalatic_ is now known as mfalatic16:37
*** hrou has quit IRC16:42
*** hrou has joined #openstack-swift16:42
*** esker has quit IRC16:51
*** rledisez has quit IRC17:05
*** janonymous_ has quit IRC17:13
*** DericHorn-HP has joined #openstack-swift17:14
*** zhill has joined #openstack-swift17:14
*** acoles is now known as acoles_17:15
*** jrichli has quit IRC17:25
*** jrichli has joined #openstack-swift17:27
*** xnox has quit IRC17:28
*** rohit_ has joined #openstack-swift17:32
*** xnox has joined #openstack-swift17:33
*** DericHorn-HP has quit IRC17:38
*** DericHorn-HP has joined #openstack-swift17:51
*** pberis has quit IRC17:51
*** barker has joined #openstack-swift17:55
*** CaioBrentano has joined #openstack-swift18:00
CaioBrentanoSwift gurus, a simple question: Is it possible to create a "write-only" user ? A user that can't delete anything18:00
CaioBrentano(I'm using Keystone authentication)18:01
claygheyoh!18:03
*** geaaru has quit IRC18:04
*** SkyRocknRoll has quit IRC18:04
*** pberis has joined #openstack-swift18:05
claygpeluse: acoles_: nice work!18:05
*** barker has quit IRC18:08
claygooops - just realized lp bug #1496205 was not tagged ec18:11
openstackLaunchpad bug 1496205 in OpenStack Object Storage (swift) "EC: Client Disconnect leaves inaccessible data on disk" [Undecided,New] https://launchpad.net/bugs/149620518:11
claygnotmyname: peluse: acoles_: torgomatic: wbhuber_: minwoob: I could really use a confirm on that one - and maybe some help with priority - I think it's critical maybe?18:11
claygalso I'm very close to a fix18:11
*** eranrom has joined #openstack-swift18:13
*** wbhuber_ is now known as wbhuber18:20
*** lyrrad has quit IRC18:23
*** lyrrad has joined #openstack-swift18:26
*** mragupat has joined #openstack-swift18:31
*** annegentle has joined #openstack-swift18:39
*** SkyRocknRoll_ has quit IRC18:42
wbhuberclayg: looks like test_server.py:TestObjectDisconnectCleanup also failed on my cluster - http://paste.openstack.org/show/468301/18:44
wbhuberclayg: evidently, i was using EC policy for this case.18:45
*** hezhiqiang has quit IRC18:45
*** trifon has joined #openstack-swift18:47
*** SkyRocknRoll_ has joined #openstack-swift18:57
claygpaste.openstack.org is so slow :'(19:00
claygyeah I think the test/patch I associated with that bug report isn't totally perfect - I think it does ok in isolation - but in my latest rev it's a little more tidy19:00
claygwbhuber: but yeah - looks like we have a pretty good bug19:01
claygthe shell script also demonstrates the issue pretty well I think19:01
minwoobclayg: Where did you run your python script that tests the disconnect?19:05
minwoobI'm trying to verify it that way.19:05
claygummm just like on my saio19:05
*** pberis has quit IRC19:09
*** vinsh_ has joined #openstack-swift19:18
minwoobclayg: Confirmed!19:19
minwoobclayg: I'll go ahead and post a fixup for the script.19:19
*** vinsh has quit IRC19:21
minwoobclayg: It was the part about setting the policy to ec42 rather than just ec since it wasn't initially there.19:21
*** vinsh_ has quit IRC19:24
*** vinsh has joined #openstack-swift19:24
claygminwoob: ahh... yeah the policy name wasn't really paramaterized outside of the script - didn't think about that - whoops!19:24
*** annegentle has quit IRC19:25
wbhuberminwoob: clayg: it's quite possible that clayg revised to ec from ec42 and the script finished fine for him19:30
claygwbhuber: i mean the name of the policy is configurable - omm it's just 'ec'19:32
*** haypo has left #openstack-swift19:38
minwoobMeh. Maybe it wasn't necessary to post a follow-up, but just did so anyway.19:48
*** DericHorn-HP has quit IRC19:49
*** annegentle has joined #openstack-swift19:55
*** CaioBrentano has quit IRC19:58
*** CaioBren_ has joined #openstack-swift20:00
*** cdelatte has quit IRC20:11
*** CaioBren_ has quit IRC20:13
*** silor has quit IRC20:27
notmynamehello, everyone20:32
*** CaioBrentano has joined #openstack-swift20:34
eranromGreetings. Is it me or is there an issue with './.unittests common/middleware/test_recon.py'20:34
wbhuberclayg: IMHO, re: priority on the bug for which you're closely coming up with a fix, i d value it as high or higher.  i see this case as an intermittent issue that occurs every now and then but those release blockers as critical are the ones that our eyes shd peel upon20:35
wbhubernotmyname: its been eons i've seen u blip a message on IRC20:36
wbhubereranrom: let me try20:36
notmynamewbhuber: I've been traveling all week. just got back home20:36
wbhubernotmyname: how was D.C.?20:36
notmynameI got to hang out with tdasilva and portante last night in Boston20:36
notmynamewbhuber: great. I was in DC, NYC, Boston, and points in between20:37
eranromwbhuber, Thanks!20:37
wbhuberi am enivous. ;-)20:37
openstackgerritMinwoo Bae proposed openstack/swift: Reconstructor logging to omit 404 warnings  https://review.openstack.org/22195620:37
notmynamewbhuber: I hd about 3.75 hours of sleep last night and a 6 hour flight today. don't be too envious ;-)20:37
wbhubernotmyname: hope u've a 64-oz jug of coffee handy....20:38
notmynameoh yeah. coffee. I was going to go make some20:38
wbhuberimitating clayg: MOAR coffee :)20:39
wbhubereranrom: ran 59 tests clean for test_recon.py20:39
eranromwbhuber, ok thanks! will start digging.20:40
wbhubereranrom: assumedly, u're not running it on master?20:42
*** amoturi has left #openstack-swift20:42
eranromwbhuber: I am on master20:42
*** hezhiqiang has joined #openstack-swift20:46
*** trifon has quit IRC20:48
minwoobctennis: Are you sure you haven't seen any 404s being reported by the replicator?20:49
claygmmmmmmmm KAUPHY!20:50
wbhubereranrom: are you seeing "ImportError" for test_recon?20:50
wbhubereranrom: this patch is likely causing what you're seeing: https://review.openstack.org/#/c/219617/20:52
claygwait - so is everyone's not failing on master now?  test_get_ring_md5_failed_ring_hash_recovers_without_restart20:52
claygI mean I know it *can* pass (like in the gate where there's only one policy)20:52
claygbut now that the rings are enumerated based on policy config on my saio with two policies I get a "items in first list are not in the second"20:53
claygand this seems totally reasonable to me20:53
clayg... master must be broken for everyone running >1 policy20:53
*** hezhiqiang has quit IRC20:53
wbhuberclayg: that sounds right - i've at least several policies running in SAIO.  test_get_ring_md5_ioerror_produces_none_hash also fails along with the test you mentioned20:55
wbhuberclayg: going to look at the test to see if i can make it smarter to handle a policy at a time20:55
openstackgerritClay Gerrard proposed openstack/swift: Fix recon tests on SAIO with multiple policies  https://review.openstack.org/22532920:58
clayg^ that 'ought do it20:58
wbhuberclayg: u speedy rat :)20:58
claygbriancline: FTFY ;)20:58
claygbriancline: note I'm just poking fun - i reviewed it - it's mostly mud on ME20:59
eranromclayg, I wish I could just +4 this one20:59
claygLOL20:59
wbhubereranrom: +A!20:59
wbhuberclayg: all clean on my SAIO w/ ur patch.21:00
notmynameso what have I missed this week?21:02
*** dustins has quit IRC21:04
notmynameclayg: wbhuber: what is patch 225329 fixing? how do I break it?21:07
patchbotnotmyname: https://review.openstack.org/#/c/225329/21:07
notmynameoh. so master fails for me already. wonder when that started21:13
*** chlong has quit IRC21:14
torgomaticnotmyname: commit f4e6d39, Wed Sep 16 17:02:08 2015 +000021:15
notmynamethanks21:15
notmynamepatch approved21:15
openstackgerritSamuel Merritt proposed openstack/swift: Let operators add watchers to object audit  https://review.openstack.org/21282421:17
brianclineuh oh, I found all-new ways to break something?21:20
*** lpabon has quit IRC21:26
*** DericHorn-HP has joined #openstack-swift21:27
brianclineclayg: I don't quite understand the patch description -- which tests were failing?21:28
*** DericHorn-HP has quit IRC21:28
*** DericHorn-HP has joined #openstack-swift21:29
notmynametest_get_ring_md5_failed_ring_hash_recovers_without_restart21:31
wbhuberbriancline: before clayg's patch, failure logs: http://paste.openstack.org/show/468509/21:33
openstackgerritEran Rom proposed openstack/swift: Add process level concurrency to container sync  https://review.openstack.org/21009921:33
openstackgerritEran Rom proposed openstack/swift: Container-Sync to iterate only over synced containers  https://review.openstack.org/20580321:33
openstackgerritEran Rom proposed openstack/swift: Add thread level concurrency to container sync  https://review.openstack.org/22533821:33
*** annegentle has quit IRC21:34
*** CaioBrentano has quit IRC21:35
brianclinewbhuber: oh, weird. so I get that it's because of the presence of other policy rings, but what's different about the dev test environment vs. the gate environment that they would have different results in the tmp dir?21:36
wbhuberbriancline: gate only runs on one policy so your tests passed21:37
notmynameah ok21:38
wbhuberbriancline: so those who are running multiple policies on master in a dev environment fail21:38
brianclinewbhuber: ahh. so since the test sets up the env, where or at what point do the additional policies get introduced?21:40
*** jkugel has quit IRC21:40
*** BAKfr has quit IRC21:41
wbhuberbriancline: well, it's one's preference to have > 1 policy, like in my case, i've replication and EC running for testing purposes. (2 policies, thus 2 rings, etc.)21:41
*** mragupat_ has joined #openstack-swift21:42
brianclinewbhuber: yeah, definitely -- but in that case is the test discovering those additional policies from a "real" /etc/swift/swift.conf?21:43
*** BAKfr has joined #openstack-swift21:43
*** jlhinson has quit IRC21:44
wbhuberbriancline:   line 344 for test_recon.py in ur patch21:46
*** mragupat has quit IRC21:46
*** mragupat_ has quit IRC21:46
wbhuberbriancline: it gets rings from i believe /etc/swift21:46
wbhuberbriancline: and it finds more rings than the test expected21:46
*** mragupat has joined #openstack-swift21:47
*** hrou has quit IRC21:47
brianclinewbhuber: ahhh, gotcha. yeah, I was trying to make the connection with what I could have done differently in my own environment to reproduce and test under both scenarios. that makes sense21:48
brianclineI'm guessing if I'd patched them for that method and had a second, multi-policy equivalent of that one, it might've caught it?21:50
wbhuberbriancline: i wouldn't have caught it either.  not sure if we should make gate smarter to handle > 1 policy.  since EC is to be production ready, gate might have to be altered to handle > 1.  but that's not up to me.21:50
brianclinewbhuber: yeah, seems prudent21:50
brianclinewhat's *really* great about my breaking it is that I really only created the failed_ring_hash test as an ancillary thing, because the old test case was doing it in a really haphazard way :)21:53
*** luksaur has quit IRC21:53
brianclinelooks like it was just to achieve coverage of the error condition21:53
*** eranrom has quit IRC21:54
*** tongli has quit IRC22:00
*** DericHorn-HP has quit IRC22:00
openstackgerritMerged openstack/swift: go: add a way to terminate replication cleanly  https://review.openstack.org/22488122:06
openstackgerritMerged openstack/swift: go: fix some panics in unpickle  https://review.openstack.org/20803322:08
*** mragupat has quit IRC22:12
openstackgerritMerged openstack/swift: Reconstructor GET excludes user_agent in log  https://review.openstack.org/22150622:12
*** NM has quit IRC22:19
*** fbo has quit IRC22:19
*** minwoob has quit IRC22:21
brianclineok yeah, just got it to fail. didn't realize the unit tests pick up live configs22:21
brianclinesorry for that22:21
*** fbo has joined #openstack-swift22:23
*** lpabon has joined #openstack-swift22:26
*** lpabon has quit IRC22:31
claygbriancline: yeah we should @patch_policies everywhere once and for all - but it's sorta much fun to run around with hair on fire every so often!22:32
openstackgerritClay Gerrard proposed openstack/swift: Fix proxy hadling of EC client disconnect  https://review.openstack.org/22535722:32
*** jrichli has quit IRC22:32
*** garthb has quit IRC22:33
claygso I'm little worried about the *lack* of failing tests when I started to move that code around - but I'm pretty sure if you put it back my *new* tests would fail - and I think they somewhat obviously demonstrade the desireable behavior22:33
*** lpabon has joined #openstack-swift22:37
claygmattoliverau: next time you see kota tell him to get a bouncer or something - drives me nuts that I can't message him async22:37
*** lpabon has quit IRC22:38
claygI mean I don't expect him to /lastlog kota *everytime* he comes online - most of the time I just makes me *feel* better to talk my friends - even if they can't here me22:38
claygacoles_: hi22:38
*** lpabon has joined #openstack-swift22:38
wbhuberclayg: line 2182 in your latest patch - should it be indented 4 spaces left?22:38
claygI DON'T KNOW!!!!22:38
*** lpabon has quit IRC22:39
claygi... don't *think* so?22:39
wbhuberin swift_proxy_controller_obj.py...22:39
*** lpabon has joined #openstack-swift22:39
clayglike we only send the chunk if it *wasn't* StopIteration right?22:39
claygwhat does replicated do?22:39
wbhuberright but uh... else?22:42
wbhuberi'd need to look more22:42
*** lpabon has quit IRC22:44
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-swift22:46
claygyeah!  try: except: else: is the bomb!22:49
claygonly thing cooler is for: break else:22:49
wbhuberno while: else:? :)22:50
wbhuberclient disconnects without sending "last" chunk?  you mean the last chunk of chunks or the latest chunk that its being sent?22:50
claygyou know - i don't know if I ever needed a while: break else:22:55
claygthe "last chunk" in chunked-trasnfer context the 0\r\n\r\n (how you terminate a stream of bytes with an inditerminate length)22:55
claygwbhuber: I'm not really saying any of that patch is good except the part where the tests pass - because the uploading and disconnecting mistream resuling in data is crap - everything else except for that is up for debate - reviews much appreciated!22:56
claygbut... I need to bolt22:56
claygthere's a thing at the kids school tonite22:56
wbhuberclayg: have a good 1.  i'm leaving a comment.22:56
claygso... ya'll have fun - we'll keep banging on it next week22:57
wbhuberclayg: cool!  they're best at keeping your mind off22:57
*** hrou has joined #openstack-swift22:59
openstackgerritMerged openstack/swift: Fix recon tests on SAIO with multiple policies  https://review.openstack.org/22532923:08
*** zhill has quit IRC23:09
*** wbhuber has quit IRC23:10
*** chsc has quit IRC23:13
mattoliverauclayg: will do :)23:14
*** esker has joined #openstack-swift23:15
*** zhill_ has joined #openstack-swift23:16
*** nadeem has quit IRC23:22
*** esker has quit IRC23:22
*** esker has joined #openstack-swift23:41
*** esker has quit IRC23:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!