| *** chlong has joined #openstack-swift | 00:03 | |
| *** jasondotstar has joined #openstack-swift | 00:28 | |
| *** Kennan has left #openstack-swift | 00:29 | |
| *** ho has joined #openstack-swift | 00:39 | |
| *** kei_yama has quit IRC | 01:03 | |
| *** kei_yama has joined #openstack-swift | 01:04 | |
| *** DericHorn-HP has joined #openstack-swift | 01:06 | |
| *** jamielennox is now known as jamielennox|away | 01:08 | |
| *** DericHorn-HP has quit IRC | 01:09 | |
| *** haigang has joined #openstack-swift | 01:10 | |
| *** DericHorn-HP has joined #openstack-swift | 01:11 | |
| *** DericHorn-HP has quit IRC | 01:11 | |
| *** kei_yama has quit IRC | 01:28 | |
| *** kei_yama has joined #openstack-swift | 01:28 | |
| *** haigang has quit IRC | 01:35 | |
| *** haigang has joined #openstack-swift | 01:36 | |
| *** kota_ has joined #openstack-swift | 01:59 | |
| *** ChanServ sets mode: +v kota_ | 01:59 | |
| kota_ | good morning | 02:01 |
|---|---|---|
| *** haomaiw__ has joined #openstack-swift | 02:09 | |
| *** haomaiwang has quit IRC | 02:11 | |
| mattoliverau | kota_: good morning! | 02:20 |
| *** haomaiwang has joined #openstack-swift | 02:25 | |
| *** haomaiw__ has quit IRC | 02:28 | |
| charz | morning | 03:03 |
| *** jrichli has joined #openstack-swift | 03:07 | |
| *** alejandrito has quit IRC | 03:12 | |
| *** sanchitmalhotra has joined #openstack-swift | 03:13 | |
| kota_ | mattoliverau, charz: morning :D | 03:17 |
| *** sanchitmalhotra1 has joined #openstack-swift | 03:22 | |
| *** sanchitmalhotra has quit IRC | 03:23 | |
| mattoliverau | charz: morning | 03:30 |
| *** sanchitmalhotra has joined #openstack-swift | 03:44 | |
| *** sanchitmalhotra1 has quit IRC | 03:47 | |
| *** jrichli has quit IRC | 03:49 | |
| *** ppai has joined #openstack-swift | 04:00 | |
| *** DericHorn-HP has joined #openstack-swift | 04:05 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 04:08 | |
| *** sanchitmalhotra has quit IRC | 04:10 | |
| *** sanchitmalhotra has joined #openstack-swift | 04:24 | |
| *** sanchitmalhotra1 has quit IRC | 04:26 | |
| *** jamielennox|away is now known as jamielennox | 04:38 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 04:42 | |
| *** sanchitmalhotra has quit IRC | 04:44 | |
| *** DericHorn-HP has quit IRC | 04:53 | |
| *** sanchitmalhotra has joined #openstack-swift | 05:01 | |
| *** sanchitmalhotra1 has quit IRC | 05:03 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 05:14 | |
| *** sanchitmalhotra has quit IRC | 05:16 | |
| *** jome has joined #openstack-swift | 05:18 | |
| *** madhuri has joined #openstack-swift | 05:22 | |
| *** mahatic has joined #openstack-swift | 05:30 | |
| *** ig0r_ has joined #openstack-swift | 05:33 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:38 | |
| *** nexusz99 has joined #openstack-swift | 05:42 | |
| *** DericHorn-HP has joined #openstack-swift | 05:47 | |
| *** DericHorn-HP has quit IRC | 05:51 | |
| *** ig0r_ has quit IRC | 05:53 | |
| *** ig0r_ has joined #openstack-swift | 05:56 | |
| *** madhuri has quit IRC | 05:57 | |
| *** haigang has quit IRC | 06:03 | |
| *** haigang has joined #openstack-swift | 06:04 | |
| *** pcaruana has quit IRC | 06:09 | |
| *** Kennan has joined #openstack-swift | 06:11 | |
| *** haigang has quit IRC | 06:16 | |
| *** haigang has joined #openstack-swift | 06:20 | |
| *** nakagawamsa has joined #openstack-swift | 06:23 | |
| openstackgerrit | Hiroshi Miura proposed openstack/python-swiftclient: change deprecated assertEquals to assertEqual https://review.openstack.org/208331 | 06:26 |
| openstackgerrit | Hiroshi Miura proposed openstack/python-swiftclient: fix old style class definition(H238) https://review.openstack.org/208332 | 06:27 |
| openstackgerrit | Hiroshi Miura proposed openstack/python-swiftclient: fix H101 TODO(name) https://review.openstack.org/208333 | 06:28 |
| *** geaaru has joined #openstack-swift | 07:03 | |
| *** jome has quit IRC | 07:07 | |
| *** rledisez has joined #openstack-swift | 07:07 | |
| *** SkyRocknRoll has quit IRC | 07:25 | |
| *** chlong has quit IRC | 07:38 | |
| *** pcaruana has joined #openstack-swift | 07:40 | |
| *** sanchitmalhotra has joined #openstack-swift | 07:44 | |
| *** sanchitmalhotra1 has quit IRC | 07:46 | |
| *** hrou has quit IRC | 07:47 | |
| *** jordanP has joined #openstack-swift | 07:47 | |
| *** jamielennox is now known as jamielennox|away | 07:57 | |
| *** jistr has joined #openstack-swift | 08:15 | |
| *** aix has joined #openstack-swift | 08:18 | |
| *** mahatic has quit IRC | 08:30 | |
| *** mahatic has joined #openstack-swift | 08:38 | |
| *** jordanP has quit IRC | 08:39 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 08:54 | |
| *** sanchitmalhotra has quit IRC | 08:56 | |
| openstackgerrit | Hiroshi Miura proposed openstack/python-swiftclient: fix import order for H306 https://review.openstack.org/208376 | 08:58 |
| *** ho has quit IRC | 08:58 | |
| *** julian has joined #openstack-swift | 09:12 | |
| *** julian is now known as Guest13124 | 09:13 | |
| Guest13124 | Hi everybody. I have a problem uploading a file with formpost middleware. When I print the request.body within my own middleware, the content seems to be modified and there is a corrupt image saved into swift. I have read I can access a file like object with request.body_fil but this do not work also. Any tips where I can find an example for this? | 09:15 |
| Guest13124 | Have already found this: http://stackoverflow.com/questions/1783383/how-do-i-copy-wsgi-input-if-i-want-to-process-post-data-more-than-once | 09:15 |
| Guest13124 | Which sounds similar to my problem? | 09:15 |
| *** sanchitmalhotra has joined #openstack-swift | 09:20 | |
| *** jordanP has joined #openstack-swift | 09:21 | |
| *** sanchitmalhotra1 has quit IRC | 09:22 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Make test_proxy work independent of env vars https://review.openstack.org/188756 | 09:24 |
| acoles | cschwede: torgomatic: you already +2'd this ^^ but it needed a trivial change to satisfy stricter pep8 checks | 09:34 |
| *** Guest13124 has quit IRC | 09:42 | |
| *** marzif_ has quit IRC | 09:46 | |
| *** marzif_ has joined #openstack-swift | 09:47 | |
| *** marzif_ has quit IRC | 09:48 | |
| *** marzif has joined #openstack-swift | 09:57 | |
| *** aix has quit IRC | 10:06 | |
| *** Kennan has quit IRC | 10:07 | |
| *** logan2 has quit IRC | 10:08 | |
| *** HenryG has quit IRC | 10:08 | |
| *** blair has quit IRC | 10:08 | |
| *** HenryG has joined #openstack-swift | 10:08 | |
| *** logan2 has joined #openstack-swift | 10:08 | |
| *** Kennan has joined #openstack-swift | 10:09 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 10:31 | |
| *** sanchitmalhotra has quit IRC | 10:33 | |
| *** haigang has quit IRC | 10:44 | |
| *** haigang has joined #openstack-swift | 10:48 | |
| *** pcaruana has quit IRC | 10:57 | |
| *** marzif has quit IRC | 11:09 | |
| *** marzif has joined #openstack-swift | 11:10 | |
| *** pcaruana has joined #openstack-swift | 11:14 | |
| *** blair has joined #openstack-swift | 11:24 | |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/swift: WIP: fixups for thiago https://review.openstack.org/208439 | 11:27 |
| *** sanchitmalhotra has joined #openstack-swift | 11:27 | |
| *** marzif has quit IRC | 11:27 | |
| *** sanchitmalhotra1 has quit IRC | 11:29 | |
| *** kota_ has quit IRC | 11:38 | |
| *** marcusvrn has joined #openstack-swift | 11:49 | |
| *** ChanServ sets mode: +v tdasilva | 12:00 | |
| *** kei_yama has quit IRC | 12:02 | |
| *** ppai has quit IRC | 12:03 | |
| *** km has quit IRC | 12:05 | |
| *** jome has joined #openstack-swift | 12:11 | |
| *** ppai has joined #openstack-swift | 12:17 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 12:20 | |
| *** sanchitmalhotra has quit IRC | 12:22 | |
| *** jasondotstar has quit IRC | 12:22 | |
| *** marzif has joined #openstack-swift | 12:24 | |
| *** marzif has quit IRC | 12:24 | |
| *** marzif has joined #openstack-swift | 12:25 | |
| *** marzif_ has joined #openstack-swift | 12:32 | |
| *** jasondotstar has joined #openstack-swift | 12:32 | |
| *** daemontool_ has joined #openstack-swift | 12:33 | |
| *** marzif has quit IRC | 12:33 | |
| *** chlong has joined #openstack-swift | 12:35 | |
| *** nadeem has joined #openstack-swift | 12:36 | |
| *** SkyRocknRoll has joined #openstack-swift | 12:37 | |
| *** ppai has quit IRC | 12:38 | |
| openstackgerrit | Nicolas Trangez proposed openstack/swift: Use entrypoints for storage policy implementation lookups https://review.openstack.org/206105 | 12:45 |
| *** daemontool_ is now known as marzif | 12:46 | |
| *** nakagawamsa has quit IRC | 13:02 | |
| *** NM has joined #openstack-swift | 13:02 | |
| *** lpabon has joined #openstack-swift | 13:05 | |
| *** breitz has joined #openstack-swift | 13:08 | |
| *** aix has joined #openstack-swift | 13:11 | |
| *** janonymous_ has joined #openstack-swift | 13:14 | |
| *** SkyRocknRoll has quit IRC | 13:14 | |
| janonymous_ | Hi Guys, i think this review is not moving to gate instead of +2s and A: https://review.openstack.org/#/c/200873/ | 13:15 |
| *** haigang has quit IRC | 13:17 | |
| acoles | janonymous_: ok i added another +A to try to move it to gate queue. | 13:20 |
| janonymous_ | acoles: Thanks ..! | 13:20 |
| *** zul has joined #openstack-swift | 13:21 | |
| *** haomaiw__ has joined #openstack-swift | 13:24 | |
| *** ig0r_ has quit IRC | 13:26 | |
| *** haomaiwang has quit IRC | 13:27 | |
| *** bapalm has joined #openstack-swift | 13:27 | |
| acoles | janonymous_: seemed to work. | 13:30 |
| janonymous_ | Yes .. :) | 13:31 |
| *** ig0r__ has joined #openstack-swift | 13:33 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Handle removed suffix dirs the same as empty suffix dirs https://review.openstack.org/185679 | 13:38 |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org has been restarted in an attempt to improve performance. | 13:41 | |
| *** jistr is now known as jistr|mtg | 13:41 | |
| *** marzif_ has quit IRC | 13:43 | |
| *** ig0r__ has quit IRC | 13:44 | |
| *** marzif_ has joined #openstack-swift | 13:44 | |
| *** h00327910__ has quit IRC | 13:48 | |
| *** bapalm_ has joined #openstack-swift | 13:51 | |
| *** bapalm has quit IRC | 13:54 | |
| *** annegentle has joined #openstack-swift | 13:58 | |
| *** haomaiw__ has quit IRC | 14:01 | |
| *** vinsh has quit IRC | 14:01 | |
| *** nadeem has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-swift | 14:02 | |
| *** nadeem has joined #openstack-swift | 14:02 | |
| *** jrichli has joined #openstack-swift | 14:02 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Test that get_hashes ignores only removed hash dir https://review.openstack.org/208494 | 14:05 |
| *** ig0r__ has joined #openstack-swift | 14:14 | |
| *** mahatic_ has joined #openstack-swift | 14:18 | |
| *** mahatic has quit IRC | 14:18 | |
| *** jistr|mtg is now known as jistr | 14:20 | |
| *** janonymous_ has quit IRC | 14:37 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Merge branch 'master' into merge-master https://review.openstack.org/208513 | 14:40 |
| openstackgerrit | Alistair Coles proposed openstack/swift: Merge branch 'master' into feature/crypto https://review.openstack.org/208513 | 14:40 |
| * eikke hates imports-with-side-effects | 14:41 | |
| *** jlhinson has joined #openstack-swift | 14:41 | |
| *** jlhinson_ has joined #openstack-swift | 14:43 | |
| *** jlhinson has quit IRC | 14:43 | |
| acoles | jrichli: ^^ when the merge of master lands on feature/crypto there will some style things to clean up due to the pep8 checks on master becoming stricter | 14:45 |
| jrichli | acoles: understood, thx | 14:46 |
| acoles | jrichli: not too much http://paste.openstack.org/show/406767/ | 14:46 |
| *** jlhinson_ has quit IRC | 14:48 | |
| *** vinsh has joined #openstack-swift | 14:49 | |
| acoles | jrichli: i figured its worth getting that change and the diskfile refactor onto feature/crypto sooner rather than later. | 14:49 |
| jrichli | acoles: sounds good, thank you! | 14:50 |
| *** abaptist has joined #openstack-swift | 14:54 | |
| openstackgerrit | Merged openstack/swift: sys.exc_type/exc_value/exc_traceback are Deprecated https://review.openstack.org/200873 | 14:54 |
| *** barra204 has joined #openstack-swift | 14:57 | |
| *** jlhinson has joined #openstack-swift | 14:58 | |
| *** hrou has joined #openstack-swift | 14:58 | |
| *** minwoob has joined #openstack-swift | 14:59 | |
| *** zaitcev has joined #openstack-swift | 15:01 | |
| *** ChanServ sets mode: +v zaitcev | 15:01 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** dustins has joined #openstack-swift | 15:01 | |
| *** haomaiwang has joined #openstack-swift | 15:02 | |
| *** jasondotstar has quit IRC | 15:02 | |
| *** ig0r__ has quit IRC | 15:09 | |
| *** barra204 has quit IRC | 15:09 | |
| *** pcaruana has quit IRC | 15:13 | |
| *** thumpba has joined #openstack-swift | 15:14 | |
| *** shakamunyi has joined #openstack-swift | 15:14 | |
| *** jasondotstar has joined #openstack-swift | 15:15 | |
| *** shakamunyi is now known as barra204 | 15:16 | |
| *** barra204 has quit IRC | 15:26 | |
| acoles | jrichli: looking at the cryto etherpad section "Overall metadata length can break constraints", its only broken for account/containers right? For objects the current fixes are sufficient? | 15:34 |
| jrichli | acoles: tbh, I dont remember. I will look at that in a moment. in a call right now | 15:34 |
| acoles | jrichli: k, no rush | 15:35 |
| *** silor has joined #openstack-swift | 15:38 | |
| *** barra204 has joined #openstack-swift | 15:40 | |
| *** abaptist has quit IRC | 15:41 | |
| *** gyee has joined #openstack-swift | 15:47 | |
| *** openstackgerrit_ has joined #openstack-swift | 15:53 | |
| *** abaptist has joined #openstack-swift | 15:54 | |
| *** jasondotstar has quit IRC | 15:54 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** lpabon has quit IRC | 16:01 | |
| *** jome has quit IRC | 16:02 | |
| *** haomaiwang has joined #openstack-swift | 16:02 | |
| *** ig0r_ has joined #openstack-swift | 16:08 | |
| *** lcurtis has joined #openstack-swift | 16:15 | |
| charz | clayg: peluse I can repo this issue on VMs (https://bugs.launchpad.net/swift/+bug/1469094), please take a look the gist. | 16:16 |
| openstack | Launchpad bug 1469094 in OpenStack Object Storage (swift) "Missing .durable files of FAs can cause rebuildable objects to be inaccessible" [Medium,Confirmed] | 16:16 |
| peluse | charz, awesome! will do | 16:18 |
| charz | peluse: cool! | 16:18 |
| *** dmorita has joined #openstack-swift | 16:24 | |
| peluse | charz, OK, just commented on the big. Wow man, really, really great job w/debug and documentation there. I think we should be able to get line of sight on this one pretty quickly now, thanks!!!! | 16:25 |
| *** jlhinson has quit IRC | 16:25 | |
| peluse | bug that is, not big :) | 16:25 |
| *** marzif_ has quit IRC | 16:25 | |
| *** tab___ has joined #openstack-swift | 16:27 | |
| *** jistr has quit IRC | 16:28 | |
| *** dustins has quit IRC | 16:28 | |
| *** rledisez has quit IRC | 16:28 | |
| charz | peluse: That's great, I'll do other tests(different object sizes) to see the root cause is it or there still have others. | 16:31 |
| peluse | awesome, thanks again. | 16:31 |
| charz | peluse: have a good day, nite | 16:31 |
| *** jlhinson has joined #openstack-swift | 16:34 | |
| *** jordanP has quit IRC | 16:37 | |
| notmyname | good morning | 16:38 |
| *** dustins has joined #openstack-swift | 16:39 | |
| *** kutija has joined #openstack-swift | 16:48 | |
| *** ig0r_ has quit IRC | 16:49 | |
| *** jasondot_ has joined #openstack-swift | 16:51 | |
| *** jasondot_ has quit IRC | 16:52 | |
| *** jasondot_ has joined #openstack-swift | 16:52 | |
| *** jasondot_ is now known as jasondotstar_ | 16:54 | |
| *** jasondotstar_ is now known as jasondotstar__ | 16:54 | |
| *** jasondotstar__ is now known as jasondotstar_ | 16:54 | |
| *** ig0r_ has joined #openstack-swift | 16:54 | |
| *** ig0r_ has quit IRC | 16:55 | |
| clayg | charz: great work | 16:56 |
| clayg | notmyname: good morning | 16:56 |
| peluse | good morning to both of you | 16:56 |
| *** bi_fa_fu has joined #openstack-swift | 16:57 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-swift | 17:02 | |
| *** tongli has joined #openstack-swift | 17:03 | |
| *** ig0r_ has joined #openstack-swift | 17:04 | |
| *** pcaruana has joined #openstack-swift | 17:05 | |
| *** zhill has joined #openstack-swift | 17:07 | |
| notmyname | one thing I missed when I was traveling last week was my keyboard. it's nice to be back in the office this week :-) | 17:07 |
| breitz | I submitted a simple test bug just now (Bug #1481019). Since I'm new to contributing I'd like to use this bug to learn the process. | 17:11 |
| openstack | bug 1481019 in OpenStack Object Storage (swift) "docstring in test_denied_DELETE_of_versioned_object confuses test output" [Undecided,New] https://launchpad.net/bugs/1481019 | 17:11 |
| breitz | heh - that one ^^ :-) | 17:12 |
| notmyname | breitz: great. so do you know what needs to happen next? | 17:12 |
| breitz | notmyname: not really | 17:12 |
| breitz | I *think* I do - but I need to make sure. | 17:13 |
| notmyname | breitz: I'll walk you throught he process. but my boss just grabbed me to chat about something. give me a few minutes :-) | 17:16 |
| breitz | sure np. thanks! | 17:16 |
| *** mahatic_ has quit IRC | 17:18 | |
| *** DericHorn-HP has joined #openstack-swift | 17:20 | |
| *** abaptist has quit IRC | 17:22 | |
| *** ig0r_ has quit IRC | 17:25 | |
| *** DericHorn-HP_ has joined #openstack-swift | 17:25 | |
| *** DericHorn-HP has quit IRC | 17:25 | |
| *** DericHorn-HP_ is now known as DericHorn-HP | 17:25 | |
| *** chlong has quit IRC | 17:31 | |
| *** hrou has quit IRC | 17:32 | |
| *** ig0r_ has joined #openstack-swift | 17:33 | |
| *** jasondotstar_ has quit IRC | 17:34 | |
| acoles | jrichli: left some comments on patch 193749 but gotta run now. | 17:43 |
| patchbot | acoles: https://review.openstack.org/#/c/193749/ | 17:43 |
| *** ig0r_ has quit IRC | 17:44 | |
| *** acoles is now known as acoles_away | 17:45 | |
| *** NM has quit IRC | 17:49 | |
| *** NM has joined #openstack-swift | 17:56 | |
| notmyname | breitz: back | 17:58 |
| breitz | hi | 17:59 |
| notmyname | the funny thing is that he wanted to talk about some stuff we're working on the help people get involved in swift ;-) | 17:59 |
| breitz | good timing | 17:59 |
| notmyname | breitz: ok, so you've identified a problem and you filed a bug about it | 17:59 |
| notmyname | thanks for filing the bug | 17:59 |
| breitz | sure - np | 17:59 |
| notmyname | based on what you write there, it seems that you already have dev environment set up. is that right? | 18:00 |
| breitz | yes | 18:00 |
| notmyname | ie you've run tests, so you must have the code somewhere | 18:00 |
| notmyname | cool | 18:00 |
| *** haomaiwang has quit IRC | 18:01 | |
| breitz | ubuntu - devstack | 18:01 |
| notmyname | how did you set it up? did you set up the Swift All in One (SAIO)? are you running in a VM? via a cloud provider | 18:01 |
| notmyname | ah ok | 18:02 |
| breitz | two ways - solaris bits - and ubuntu devstack | 18:02 |
| *** haomaiwang has joined #openstack-swift | 18:02 | |
| breitz | yes - running in a VM | 18:02 |
| notmyname | devstackw ill be ok for a little while (and for your change that you're looking at now), but there's a better way to have a swift dev environment. for now, though, let's skip over that part and move on to some of the mundane setup pieces | 18:03 |
| breitz | k - but that part I'd be really interested in learning more about (not using devstack) | 18:04 |
| notmyname | ok. we'll get there :-) | 18:04 |
| breitz | sure - thanks | 18:04 |
| notmyname | have you installed git-review yet? if so, you need to run `git review -s` in your local copy of the repo | 18:04 |
| breitz | yes | 18:04 |
| notmyname | ok, great | 18:04 |
| notmyname | and so you've set up the appropriate launchpad accounts (of course, you've submitted a bug!) and signed the CLA in gerrit? | 18:04 |
| breitz | yes I believe so | 18:05 |
| notmyname | great :-) | 18:05 |
| notmyname | (you're making this easy, so far) | 18:05 |
| notmyname | how comfortable are you with git? | 18:05 |
| breitz | comfortable | 18:05 |
| notmyname | ok | 18:05 |
| breitz | I'm sure I'm not a power user - but I understand how to use it | 18:06 |
| notmyname | the general idea of code contributions is that you make a change and propose it. it gets reviewed by other people, and when it's good, it lands. by convention, that requires 2 people who have commit rights (core-reviewers) to approve the change | 18:07 |
| breitz | right - got it | 18:07 |
| *** openstackgerrit_ has quit IRC | 18:07 | |
| notmyname | specifically in openstack projects and the configuration of the gerrit code review tool we use, each change is one commit. and if you have to make updates to it, then you'll amend the first change and resubmit it | 18:08 |
| notmyname | so you propose a change, I review and make suggestions, you fix it and resubmit it as one ammended commit, not as a commit on top of the first one | 18:08 |
| notmyname | make sense? | 18:08 |
| breitz | I think so yes - so each patch is a complete entity - not a collection of patches that you would need to apply in order | 18:09 |
| *** abaptist has joined #openstack-swift | 18:09 | |
| notmyname | the way gerrit ties it all together is with a Change-Id that is in the commit message. the `git review -s` you ran to set up the gerrit remote also installed a post-commit hook to make sure there is a change-id in the commit message | 18:09 |
| notmyname | so when you amend a commit, you keep the same change-id, and it all works | 18:09 |
| breitz | cool | 18:09 |
| breitz | I was wondering how that works (from the git mechanics point of view) | 18:10 |
| notmyname | it's not complicated, but it is different enough from some other common methods that it's worth pointing out up front | 18:10 |
| notmyname | ok, so let's get down to the patch itself | 18:10 |
| notmyname | at this point, it's type to type | 18:11 |
| notmyname | I'd recommend creating a local branch in which to do your patch | 18:11 |
| breitz | sure | 18:11 |
| notmyname | make the change, commit it. make sure there's just one commit on that branch, and type `git review` | 18:11 |
| notmyname | that will submit it to gerrit for review | 18:11 |
| notmyname | (which behind the scenes is pushing a reference to the gerrit remote) | 18:12 |
| breitz | k - I assume a test stage in there would be good. make change, commit, test, git review? | 18:12 |
| notmyname | yes, of course :-) | 18:12 |
| breitz | k - just making sure. :-) | 18:13 |
| notmyname | so I'd expect that you will run tests on a patch before you submit it | 18:13 |
| notmyname | but the CI system will also run tests against the patch | 18:13 |
| notmyname | in reality, no human actually will commit code to master. humans say "this should land" but it only happens after the bots run the tests and they pass | 18:13 |
| breitz | right - is there a way to run CI on your own - or does that typically happen post git review time? | 18:13 |
| notmyname | both | 18:14 |
| notmyname | in your source repo that has your change checked out (on your dev environment), there are a couple of ways to run tests | 18:15 |
| notmyname | one is to use `tox` and the other is to use the provided scripts. they do pretty much the same things | 18:15 |
| notmyname | the local scripts are ./.unittests ./.functests and ./.probetests | 18:15 |
| notmyname | only the first 2 will work on a devstack environment (which is the reason for my comment earlier) | 18:16 |
| breitz | ok - good to know | 18:16 |
| notmyname | unit tests test small sections of code. functests are functional tests that test the API as a black-box. and probe tests are for checking that various components in a cluster interact as expected | 18:17 |
| notmyname | now, in this case, you're talking about a docstring change. so testing requirements are pretty minimal ;-) | 18:18 |
| breitz | right - which is sort of why I picked to bug - so I could focus on the process, and learn more about testing as well along the way | 18:18 |
| notmyname | once you've made your changes and seen that the patch works as expected and you've submitted it for review... | 18:18 |
| notmyname | at that point, others in the community will review it | 18:19 |
| notmyname | and to review it, they will pull down your change, run it, check that it does what it says and its a good change, and leave a review | 18:19 |
| breitz | right | 18:21 |
| *** Kennan has quit IRC | 18:21 | |
| notmyname | at this point I think it's up to you to start typing :-) | 18:22 |
| breitz | k - thanks! I'm interested in learning more about how to setup a dev env outside of devstack. Is there docs/wiki that I can read? | 18:23 |
| breitz | also - I assume I can just assign the bug to myself? Or does somebody else need to do that | 18:23 |
| notmyname | yes | 18:25 |
| *** abaptist has quit IRC | 18:25 | |
| notmyname | the launchpad stuff is good for trackign what's going on, but don't consider it as a permission slip to work on stuff :-) | 18:25 |
| notmyname | ie you don't have to have something with all the right values in the right places before you can work on something | 18:26 |
| breitz | sure | 18:27 |
| notmyname | or as I've phrased it in other places, they are tools to facilitate communication, not a goal in themselves. so as long as communication happens, we're all good :-) | 18:27 |
| breitz | k - I appreciate the help. I'll go off and type, type, type. | 18:28 |
| notmyname | as my australian friends say, "typey typey" | 18:28 |
| jrichli | acoles: thanks for reviewing! | 18:28 |
| *** Kennan has joined #openstack-swift | 18:29 | |
| breitz | heh | 18:29 |
| notmyname | ok, for other swift dev environments | 18:30 |
| notmyname | oh, actually, here's another thing. it just was added a few days ago :-) http://docs.openstack.org/developer/swift/first_contribution_swift.html | 18:31 |
| notmyname | the swift dev environment is the SAIO (Swift All in One) | 18:31 |
| notmyname | docs to set it up are at http://docs.openstack.org/developer/swift/development_saio.html | 18:31 |
| breitz | ah - cool. thanks | 18:31 |
| notmyname | and there is also https://github.com/swiftstack/vagrant-swift-all-in-one that automates it all for you and takes care of some config options | 18:32 |
| breitz | I'll snapshot my vm and give that a try | 18:32 |
| breitz | I really appreciate all the help | 18:33 |
| notmyname | happy to help | 18:33 |
| *** abaptist has joined #openstack-swift | 18:34 | |
| *** mahatic has joined #openstack-swift | 18:45 | |
| *** shakamunyi has joined #openstack-swift | 18:46 | |
| *** mahatic has quit IRC | 18:46 | |
| openstackgerrit | paul luse proposed openstack/swift: Add ability for GET path to see/select alternate frag archs https://review.openstack.org/207165 | 18:48 |
| peluse | clayg, ^ obj server test as requested. acoles_away minor nits addressed. Still need to add the alt headers to HEAD but that won't change whats in there now (just add to it) | 18:49 |
| *** haomaiwang has quit IRC | 19:01 | |
| *** haomaiwang has joined #openstack-swift | 19:02 | |
| openstackgerrit | paul luse proposed openstack/swift: Add ability for GET path to see/select alternate frag archs https://review.openstack.org/207165 | 19:08 |
| peluse | clayg, acoles_away ^ there's everything (HEAD stuff too) | 19:08 |
| *** zul has quit IRC | 19:11 | |
| *** lpabon has joined #openstack-swift | 19:11 | |
| *** tab___ has quit IRC | 19:11 | |
| *** bi_fa_fu has quit IRC | 19:12 | |
| *** kutija_ has joined #openstack-swift | 19:14 | |
| lcurtis | hello all...when someone has a moment...i have a bunch of async_pending objects from a few days ago that seem to be orphaned... | 19:16 |
| lcurtis | any thoughts on how to rectify? | 19:16 |
| *** kutija has quit IRC | 19:16 | |
| *** jasondot_ has joined #openstack-swift | 19:17 | |
| *** michaeljk has joined #openstack-swift | 19:18 | |
| *** jome has joined #openstack-swift | 19:20 | |
| *** jasondot_ has quit IRC | 19:26 | |
| *** abaptist has quit IRC | 19:33 | |
| minwoob | Isn't a primary node both primary and a handoff, if it contains a handoff fragment that belongs on a partner primary? | 19:36 |
| minwoob | Basically, it serves the function of *both* a primary, and a handoff node, if that is the case? | 19:37 |
| minwoob | Or is there something unique about such nodes? | 19:37 |
| *** geaaru has quit IRC | 19:38 | |
| peluse | minwoob, for a given hash a single node can't be a primary and a handoff at the same time. when handoff nodes are iterrated they exlucde primaries | 19:39 |
| peluse | minwoob, but that doesn't mean that a primary for obj 1 can't be a handoff for obj 2... | 19:40 |
| minwoob | peluse: I see. How is it possible, then, for a fragment for primary x to end up on partner primary y? | 19:41 |
| peluse | heh, I was just about to explain that... | 19:41 |
| peluse | rebalance | 19:42 |
| minwoob | Ahhh. Okay. | 19:43 |
| minwoob | Then it's just a new permanent location. | 19:43 |
| peluse | there are a bunch of crazy things you can do chaning the ring around before a rebalance is totally done that can result in fragments all over th epalce | 19:43 |
| *** michaeljk has quit IRC | 19:43 | |
| peluse | and the reconstructor has the job of figuring who is supposed to be where and getting them back the node that is best (node index = fragment index) | 19:44 |
| *** jome has quit IRC | 19:44 | |
| *** bi_fa_fu has joined #openstack-swift | 19:45 | |
| peluse | minwoob, great question though | 19:45 |
| *** silor has quit IRC | 19:45 | |
| minwoob | peluse: Thanks for the helpful explanation :-) | 19:46 |
| minwoob | Btw, has it ever been considered to architect the rebalancing process so that only the partitions being moved to an added node are actually shuffled around? | 19:50 |
| minwoob | ... or is that not possible? | 19:50 |
| peluse | that's a question for one of the other cores... I have succesfully avoided the guts of the ring code so far :) | 19:51 |
| * peluse outta here for a few hours... | 19:51 | |
| minwoob | I see. | 19:52 |
| minwoob | For instance, Ceph is implemented that way, I believe. | 19:53 |
| *** sanchitmalhotra has joined #openstack-swift | 19:59 | |
| *** mfalatic has joined #openstack-swift | 20:01 | |
| *** haomaiwang has quit IRC | 20:01 | |
| *** sanchitmalhotra1 has quit IRC | 20:01 | |
| *** haomaiwang has joined #openstack-swift | 20:02 | |
| redbo | I'm pretty sure that's how it works, or else I don't know what you mean. | 20:03 |
| redbo | it tries to move as few partitions as possible | 20:03 |
| *** dustins has quit IRC | 20:05 | |
| redbo | someone needs to give our algorithm a catchy name and write up a white paper | 20:06 |
| openstackgerrit | Merged openstack/swift: go: add ability to lock device/drive with file on file system https://review.openstack.org/203789 | 20:07 |
| minwoob | I could be wrong about that. But that was from my last impression on it. | 20:08 |
| notmyname | unique-as-possible? | 20:10 |
| notmyname | (which today is more of distributed-as-balanceable) | 20:10 |
| notmyname | https://www.youtube.com/watch?v=JUXRJaZMOb0&list=PLIr7I80Leee5NpoYTd9ffNvWq0pG18CN3&index=1 | 20:11 |
| MooingLemur | if you have two zones and three replicas, adding storage to one zone results in additional inter-zone movement to keep things as balanced as possible (at least in the old ring code that doesn't have the overload parameter). Has this changed? | 20:16 |
| notmyname | lcurtis: the object updater clears those. check that it's running. you could stop it on a machine and run it explicitly to see what's happening | 20:17 |
| notmyname | MooingLemur: correct, in general. it's a good idea to keep zones pretty evenly balanced | 20:18 |
| lcurtis | thanks notmyname...was just about to report back that was what i did...and they are cleared | 20:18 |
| lcurtis | thanks! | 20:18 |
| MooingLemur | but I suppose that all depends on uniqueness of data that exists on a host anyway. If it can, I suppose it would prefer to move the data off of zone 1 that it could add directly to the host with increased storage in zone 2. | 20:19 |
| MooingLemur | Or at least should :) | 20:19 |
| MooingLemur | It really sounds like it can get messy, and you end up with conflicting objectives that a rebalance would have to satisfy. I haven't looked much at the rebalancing code :) | 20:20 |
| clayg | minwoob: redbo: notmyname: torgomatic: we of course try to move as few partitions as possible - it's a design goal for the rebalance algorithm - but we've discovered some scenarios in the past where there was room to improve (e.g. 2328983b) | 20:23 |
| *** bi_fa_fu has quit IRC | 20:24 | |
| *** bi_fa_fu has joined #openstack-swift | 20:24 | |
| redbo | but you should only discuss the straightforward case in the white paper | 20:25 |
| clayg | redbo: oh good call | 20:25 |
| *** bi_fa_fu has quit IRC | 20:26 | |
| openstackgerrit | Merged openstack/swift: Make test_proxy work independent of env vars https://review.openstack.org/188756 | 20:26 |
| clayg | ^ well that sucks - gholt (and acoles, and I) worked really hard on that test -> https://review.openstack.org/#/c/102598/ | 20:34 |
| clayg | after a few bugs with a similar "make sure we use the args" test - we seem to have decided to man up and make an integration test - but idk, i guess as long as we don't have anymore regressions in that area | 20:35 |
| clayg | I agree requiring the env var was not great, but it seems like you could fix that by just stubbing the environment | 20:35 |
| clayg | oh well | 20:35 |
| *** ig0r_ has joined #openstack-swift | 20:36 | |
| *** hrou has joined #openstack-swift | 20:44 | |
| *** breitz has quit IRC | 20:50 | |
| *** ig0r__ has joined #openstack-swift | 20:50 | |
| *** breitz has joined #openstack-swift | 20:50 | |
| *** ig0r_ has quit IRC | 20:50 | |
| *** lpabon has quit IRC | 20:53 | |
| *** annegentle has quit IRC | 20:54 | |
| *** thumpba has quit IRC | 20:56 | |
| *** bapalm_ has quit IRC | 21:00 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-swift | 21:01 | |
| *** jrichli has quit IRC | 21:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/swift: Updated from global requirements https://review.openstack.org/88736 | 21:03 |
| *** lpabon has joined #openstack-swift | 21:15 | |
| *** ig0r__ has quit IRC | 21:21 | |
| *** lpabon has quit IRC | 21:32 | |
| *** lpabon has joined #openstack-swift | 21:33 | |
| *** lpabon has quit IRC | 21:35 | |
| *** annegentle has joined #openstack-swift | 21:47 | |
| *** breitz has quit IRC | 21:58 | |
| *** tongli has quit IRC | 21:59 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-swift | 22:02 | |
| *** breitz has joined #openstack-swift | 22:06 | |
| *** sanchitmalhotra1 has joined #openstack-swift | 22:09 | |
| *** sanchitmalhotra has quit IRC | 22:11 | |
| *** minwoob has quit IRC | 22:12 | |
| *** NM has quit IRC | 22:18 | |
| *** thumpba has joined #openstack-swift | 22:19 | |
| *** jlhinson has quit IRC | 22:21 | |
| clayg | dfg: I'd appreciate your thoughts on patch 208106 - if those fixups make sense to you maybe we could merge it with patch 208057 | 22:23 |
| patchbot | clayg: https://review.openstack.org/#/c/208106/ | 22:23 |
| *** DericHorn-HP has quit IRC | 22:24 | |
| mattoliverau | Morning | 22:25 |
| openstackgerrit | Hamdi Roumani proposed openstack/swift: Doc instructions for post rebase steps https://review.openstack.org/208669 | 22:26 |
| *** thumpba has quit IRC | 22:29 | |
| *** breitz has quit IRC | 22:34 | |
| *** breitz1 has joined #openstack-swift | 22:34 | |
| *** annegentle has quit IRC | 22:35 | |
| lcurtis | hmm...is there a utility to get total number of objects in a swift cluster? | 22:36 |
| openstackgerrit | Brian Reitz proposed openstack/swift: Convert docstring to a comment in test_denied_DELETE_of_versioned_object unit test. https://review.openstack.org/208675 | 22:40 |
| *** thumpba has joined #openstack-swift | 22:41 | |
| *** thumpba has quit IRC | 22:41 | |
| *** annegentle has joined #openstack-swift | 22:43 | |
| *** nadeem has quit IRC | 22:45 | |
| *** shakamunyi has quit IRC | 22:51 | |
| notmyname | breitz1: I see your patch ^ | 22:55 |
| *** km has joined #openstack-swift | 22:55 | |
| breitz1 | yep | 22:56 |
| *** breitz1 is now known as breitz | 22:56 | |
| breitz | your help got me this far. :-) | 22:57 |
| notmyname | breitz: the patch looks fine. I didn't know that nose was pickup up the docstrings. good thing to keep in mind | 22:59 |
| notmyname | breitz: in this case, since it's "just" a docstring to comment patch in a test (and thus very low risk), I will go ahead and approve it without another review. for most changes though, it will take 2 +2 votes from core reviewers before a patch lands | 23:00 |
| notmyname | eventually zuul will get around to running the tests and jenkins will leave the test results as comments in gerrit. once it goes through that a couple of times, it will get merged | 23:00 |
| *** haomaiwang has quit IRC | 23:01 | |
| breitz | right - I need to figure out how to follow all of that around (as far as a progress tracking sort of thing - for my own education) | 23:01 |
| notmyname | breitz: http://status.openstack.org/zuul/ and find the patch id of your patch | 23:01 |
| *** haomaiwa_ has joined #openstack-swift | 23:02 | |
| breitz | my patch id is 208675 right? | 23:02 |
| notmyname | correct | 23:02 |
| breitz | k - thanks | 23:02 |
| breitz | I still have a list of a bunch of test env things I want to try (SAIO) but post this patch it would be awesome to find something else to work on in swift | 23:06 |
| notmyname | there's a few places to look for things to do, but a lot of it comes down to "what do you want to work on?" | 23:07 |
| notmyname | https://wiki.openstack.org/wiki/Swift/ideas is a list of ideas of stuff to work on | 23:07 |
| breitz | thanks - I can go read that | 23:08 |
| notmyname | https://wiki.openstack.org/wiki/Swift/PriorityReviews has a list of some of the bigger things that are ongoing, including some notes from the last summit | 23:08 |
| breitz | k - nice | 23:08 |
| notmyname | and in the channel topic there's a "review dashboard" link that has open patches that need reviews. the starred section of the top are the ones that are most important to review | 23:08 |
| breitz | ah ok. cool | 23:09 |
| notmyname | breitz: what brings you to swift? how'd you find it and are you using it today? | 23:11 |
| breitz | I work on openstack for solaris. I've been involved in storage as a kernel developer for years. | 23:12 |
| *** aix has quit IRC | 23:12 | |
| notmyname | cool | 23:12 |
| breitz | I want to help contribute to the product - and learn as much as I can | 23:12 |
| notmyname | have you seen any problems running swift on solaris? | 23:12 |
| notmyname | (and by "...for solaris", I assume you work for oracle?) | 23:13 |
| breitz | yes - I work for Oracle. No I've not seen issues in what I've done with it yet - but I'm just starting to learn all of this (I'm new to the openstack group in solaris as well) | 23:14 |
| breitz | relatively new anyway. :-) | 23:14 |
| breitz | thanks again for all of your help. | 23:16 |
| breitz | off to dinner - biab | 23:16 |
| notmyname | breitz: welcome to swift | 23:16 |
| *** darrenc has quit IRC | 23:23 | |
| *** darrenc has joined #openstack-swift | 23:23 | |
| *** annegentle has quit IRC | 23:24 | |
| *** kei_yama has joined #openstack-swift | 23:25 | |
| *** jlhinson has joined #openstack-swift | 23:33 | |
| *** marcusvrn has quit IRC | 23:33 | |
| *** darrenc has quit IRC | 23:35 | |
| *** darrenc has joined #openstack-swift | 23:35 | |
| *** ho has joined #openstack-swift | 23:36 | |
| breitz | thanks! | 23:42 |
| *** DericHorn-HP has joined #openstack-swift | 23:42 | |
| *** jrichli has joined #openstack-swift | 23:42 | |
| peluse | hmmm, did something hppen w/the tests on pep8/flake8 in the last few days? I have a patch that passes locally, and passed in gerrit within the last few days, that now fails in gerrit for what looks like no valid pep8 reason at all (and that file didn't change since the last time I submitted it)? | 23:43 |
| *** darrenc is now known as darrenc_afk | 23:45 | |
| notmyname | yay | 23:46 |
| notmyname | peluse: I hope not, but it's possible | 23:46 |
| peluse | argh | 23:47 |
| notmyname | peluse: with https://review.openstack.org/#/c/205977/ | 23:47 |
| notmyname | peluse: see clayg's comment at teh bottom | 23:48 |
| peluse | so I'm to yell at clayg now huh? | 23:48 |
| notmyname | seems that way | 23:49 |
| *** jrichli has quit IRC | 23:50 | |
| hrou | notmyname, peluse - and one more thing, if you use tox, use -r to update the tox env (as this will rebuild the tox env with the new packages that are required) | 23:50 |
| peluse | hrou, OK thanks. | 23:59 |
| peluse | now if pip install would just work.... | 23:59 |
| hrou | anytime ! 'sudo pip install ..' ? : ) | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!