| *** dmorita has joined #openstack-swift | 00:34 | |
| *** ho has joined #openstack-swift | 00:48 | |
| ho | good morning guys! | 01:05 |
|---|---|---|
| mattoliverau | ho: morning | 01:05 |
| ho | mattoliverau: morning! | 01:06 |
| *** km has joined #openstack-swift | 01:09 | |
| ho | mattoliverau: I got a "merge conflict" of my patch but when I tried to check the conflict, there is no conflict. Do you have similar experience? | 01:10 |
| mattoliverau | ho, it may mean you have to rebase it. | 01:11 |
| ho | mattoliverau: OK. I will rebase it but I don't know the reason... thanks! | 01:13 |
| mattoliverau | ho: gerrit probably tried to run tests on it on the current state of master.. that might have conflicted | 01:15 |
| ho | mattoliverau: could be. do you have info for gerrit tests around? | 01:17 |
| mattoliverau | ho: if you press the 'toggle ci' button on your change you can see what happened | 01:22 |
| ho | mattoliverau: thanks! I can see the reason for this. So far I can not find actual reason for rebasing from code but I will rebase it as a workaround. Thanks for quick response! | 01:25 |
| notmyname | ho: gerrit does approximately zero to resolve anything that isn't a simple fast-forward or non-3-way merge, even if there are no conflicts. I've seen it happen before. so you gotta rebase locally and push it up. so you're doing the right thing | 01:26 |
| * notmyname isn't really here | 01:26 | |
| ho | notmyname: thanks for the info! I will do it. | 01:27 |
| openstackgerrit | Hisashi Osanai proposed openstack/swift: Enable Object Replicator's failure count in recon https://review.openstack.org/138342 | 01:28 |
| mattoliverau | wow, the ghost of notmyname or was that just a jedi mind trick :P | 01:28 |
| mattoliverau | k, I'm going to grab some lunch. bbs | 01:29 |
| mattoliverau | . | 01:57 |
| *** rmcall has joined #openstack-swift | 02:22 | |
| *** rmcall has quit IRC | 02:45 | |
| ho | mattoliverau: Do you know how to make an entry (put a patch) in Swift Review Dashboard? (I would like to know why my patch #138342 doesn't is in there) | 03:16 |
| ho | s/is/exist/ | 03:17 |
| mattoliverau | ho: it is a bunch of filters run while your logged in, so it excludes your patches (you wont review your own, except in the my patches section). | 03:19 |
| mattoliverau | ho: so your do exist | 03:19 |
| mattoliverau | *yours do exist | 03:19 |
| mattoliverau | ho: your patch for me, is first in No Negative Feedback. | 03:20 |
| mattoliverau | but you wont see it. | 03:20 |
| ho | mattoliverau: i see. this list is for reviewers so there is not necessary to display own patches. thanks, i understand. | 03:20 |
| mattoliverau | yup, except under the my patches section, which will be all of yours | 03:21 |
| ho | mattoliverau: To realize it I have to make a lot of patches :) | 03:26 |
| *** panbalag has joined #openstack-swift | 03:38 | |
| *** panbalag has quit IRC | 03:47 | |
| *** tsg has quit IRC | 04:02 | |
| *** david-lyle_afk has quit IRC | 04:02 | |
| *** silor has joined #openstack-swift | 04:03 | |
| *** tsg has joined #openstack-swift | 04:12 | |
| *** fifieldt has joined #openstack-swift | 04:44 | |
| *** artTH has joined #openstack-swift | 04:44 | |
| *** ppai has joined #openstack-swift | 05:05 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:11 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:11 | |
| openstackgerrit | Tushar Gohad proposed openstack/swift: EC: Multi-phase commit conversation for PUTs https://review.openstack.org/153843 | 05:18 |
| openstackgerrit | Tushar Gohad proposed openstack/swift: EC: Multi-phase commit conversation for PUTs https://review.openstack.org/153843 | 05:25 |
| tsg | mattoliverau: just uploaded new rev ^^^^ of the multiphase put patchif you are experimenting. thx! for the review btw | 05:27 |
| mattoliverau | tsg: cools I'll pull it down, ta! and your welcome, nice work BTW :) | 05:28 |
| tsg | mattoliverau: thanks! :) another small put patch coming up .. will keep ya posted | 05:30 |
| mattoliverau | tsg: ta | 05:30 |
| tsg | tak :) | 05:32 |
| tsg | mattoliverau: (just looked up the urban dictionary for 'ta' ;)) | 05:33 |
| mattoliverau | :) | 05:34 |
| *** SkyRocknRoll has quit IRC | 05:34 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:34 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:34 | |
| *** SkyRocknRoll has quit IRC | 05:41 | |
| *** SkyRocknRoll has joined #openstack-swift | 05:42 | |
| *** tsg has quit IRC | 05:52 | |
| mattoliverau | K I'm calling it a day. Time to go cook some dinner | 06:17 |
| openstackgerrit | Prashanth Pai proposed openstack/swift: fsync() on directories https://review.openstack.org/126923 | 06:38 |
| hugokuo | hmm.... Object auditors do check the .ts files . Right ? | 07:08 |
| *** ihrachyshka has joined #openstack-swift | 07:58 | |
| *** chlong has quit IRC | 08:02 | |
| ho | hugokuo: object-server and replicator uses it but i'm not sure whether audtor uses it or not. | 08:17 |
| *** nellysmitt has joined #openstack-swift | 08:18 | |
| hugokuo | ho: k.... thx dude | 08:18 |
| *** rledisez has joined #openstack-swift | 08:20 | |
| *** Guest78669 is now known as d0ugal | 08:20 | |
| *** d0ugal has joined #openstack-swift | 08:21 | |
| *** nshaikh has joined #openstack-swift | 08:37 | |
| *** geaaru has joined #openstack-swift | 08:45 | |
| *** mmcardle has joined #openstack-swift | 08:47 | |
| *** bkopilov has quit IRC | 08:59 | |
| *** bkopilov has joined #openstack-swift | 08:59 | |
| *** ihrachyshka has quit IRC | 09:07 | |
| openstackgerrit | Prashanth Pai proposed openstack/swift: Allow rsync to use compression https://review.openstack.org/148454 | 09:10 |
| *** jistr has joined #openstack-swift | 09:12 | |
| *** straycat has joined #openstack-swift | 09:14 | |
| *** dmorita has quit IRC | 09:31 | |
| *** artTH has quit IRC | 09:31 | |
| *** Trixboxer has joined #openstack-swift | 09:36 | |
| *** ppai has quit IRC | 09:57 | |
| *** jordanP has joined #openstack-swift | 10:05 | |
| *** bkopilov has quit IRC | 10:11 | |
| *** ppai has joined #openstack-swift | 10:11 | |
| *** bkopilov has joined #openstack-swift | 10:16 | |
| openstackgerrit | Charles Hsu proposed openstack/python-swiftclient: Add ability to download objects to particular folder. https://review.openstack.org/160283 | 10:17 |
| *** bkopilov has quit IRC | 10:29 | |
| *** bkopilov has joined #openstack-swift | 10:30 | |
| *** aix has joined #openstack-swift | 10:41 | |
| *** bkopilov has quit IRC | 10:46 | |
| *** ihrachyshka has joined #openstack-swift | 10:46 | |
| *** silor has quit IRC | 10:47 | |
| *** EmilienM is now known as EmilienM|afk | 10:54 | |
| *** ho has quit IRC | 11:25 | |
| *** km has quit IRC | 11:30 | |
| *** ppai has quit IRC | 11:57 | |
| *** ppai has joined #openstack-swift | 12:00 | |
| *** silor has joined #openstack-swift | 12:23 | |
| *** nshaikh has quit IRC | 12:23 | |
| *** SkyRocknRoll has quit IRC | 12:29 | |
| *** ppai has quit IRC | 12:37 | |
| *** bkopilov has joined #openstack-swift | 12:43 | |
| *** panbalag has joined #openstack-swift | 12:44 | |
| *** ppai has joined #openstack-swift | 12:49 | |
| *** mahatic has joined #openstack-swift | 13:05 | |
| *** ppai has quit IRC | 13:05 | |
| *** ppai has joined #openstack-swift | 13:19 | |
| *** jrichli has joined #openstack-swift | 13:48 | |
| *** nshaikh has joined #openstack-swift | 13:59 | |
| *** ppai has quit IRC | 14:10 | |
| *** nshaikh has quit IRC | 14:14 | |
| openstackgerrit | Charles Hsu proposed openstack/python-swiftclient: Add ability to download objects to particular folder. https://review.openstack.org/160283 | 14:58 |
| *** mahatic has quit IRC | 15:00 | |
| *** tsg_ has joined #openstack-swift | 15:03 | |
| *** tgohad has joined #openstack-swift | 15:05 | |
| *** tsg_ has quit IRC | 15:08 | |
| *** rdaly2 has joined #openstack-swift | 15:12 | |
| *** dmsimard_away is now known as dmsimard | 15:20 | |
| *** mahatic has joined #openstack-swift | 15:21 | |
| *** annegentle has joined #openstack-swift | 15:31 | |
| *** rsFF has joined #openstack-swift | 15:32 | |
| *** silor has quit IRC | 15:46 | |
| *** zaitcev has joined #openstack-swift | 16:03 | |
| *** ChanServ sets mode: +v zaitcev | 16:03 | |
| notmyname | good morning | 16:04 |
| acoles | notmyname: morning | 16:04 |
| *** annegentle has quit IRC | 16:10 | |
| *** doxavore has joined #openstack-swift | 16:15 | |
| openstackgerrit | Stuart McLaren proposed openstack/python-swiftclient: Retry download after streaming has started https://review.openstack.org/159208 | 16:16 |
| jrichli | good morning! I noticed that after the encryption branch took merges from master, I am getting 31 functests skipped. Is that normal? | 16:22 |
| jrichli | or should I enable something in my config, perhaps? | 16:23 |
| doxavore | is anyone aware of a devstack-like SAIO installer? just a simple way to get developers using a local VM without all the config required for SAIO (and without spinning CPU on other openstack services)... | 16:25 |
| ctennis | https://github.com/swiftstack/vagrant-swift-all-in-one ? | 16:26 |
| *** reed has joined #openstack-swift | 16:27 | |
| doxavore | ctennis: that. thank you. i'm not sure what's wrong with my googling skills today... :-/ | 16:27 |
| acoles | jrichli: can you paste the skipped test method names? | 16:29 |
| peluse | morning folks | 16:29 |
| jrichli | acoles: I will gather the names soon. gotta meeting now. Thanks! | 16:30 |
| acoles | peluse: hi! i changed the .durable to sort newer than .data (e.g. 123.durable, 123-0.data) and a bunch of hash_cleanup_listdir tests failed, so I am just fixing those (just the order of asserted returned files is wrong with durables now coming ahead of .data) | 16:31 |
| peluse | acoles, yeah, there's a lot of those tests that need tweaking with every little change in GOF :( | 16:32 |
| acoles | peluse: changing .durable to sort newer worked nicely though. | 16:33 |
| peluse | acoles, did my replies to your email on the various test scenarios for GOF make sense? | 16:33 |
| peluse | cool | 16:33 |
| acoles | peluse: yes, all made sense. one other corner case i am not sure about: starts with: can we have an object dir with a .durable with no .data (e.g. .data PUT failed but the durable gets written out) or would that never happen? | 16:36 |
| peluse | acoles, I think the only case there would be, like we talked about, if the auditor came in afterwards and Q'd the .data file but we can make an update there to have it also unlink the .durable when it does so | 16:37 |
| *** annegentle has joined #openstack-swift | 16:37 | |
| peluse | or maybe we don't want to do that actually... | 16:37 |
| acoles | peluse: i had a look at the auditor and I *think* it moves the whole object dir. | 16:38 |
| peluse | ahh, OK then cool | 16:38 |
| peluse | but the scenario of a PUT failing and a .durable being written should not happen | 16:38 |
| acoles | peluse: caveat: i looked at the code, i didn't run it : | 16:39 |
| peluse | reviewing tsg's patch now which, BTW, has some overlap with GOF as he made some changes there that the patch you're working on will likely override | 16:39 |
| acoles | ok, good, because the next question was can we add a .meta where there is a .durable but no .data, but that isn't relevant if we can't have a .durable without a .data | 16:40 |
| peluse | yup | 16:40 |
| *** gyee has joined #openstack-swift | 16:42 | |
| acoles | peluse: also, i ran into a wrinkle with those assertions at end of GOF - they assert 'no .meta without a .data', but when searching for a specific frag index, its possible we find the .meta but not the *specific* .data, so i had to work around that one | 16:42 |
| peluse | acoles, yeah, that's also why I removed 2 early assertions - they are extrmemely rigid wrt the contract for replication. Not sure when we want conditional rigid assertions like that or not. My inclination is not and instead tighten up test code (well add some) for GOF | 16:44 |
| acoles | peluse: yep. i have a bunch of unit tests directly on GOF now. but i guess the assertions are about what could ever appear in an object dir, which depends on what other code paths do (e.g. as discussed above), so its hard to test that the assertions are valid | 16:47 |
| peluse | agreed | 16:47 |
| *** jordanP has quit IRC | 17:02 | |
| *** jordanP has joined #openstack-swift | 17:03 | |
| *** annegentle has quit IRC | 17:07 | |
| *** rdaly2 has quit IRC | 17:10 | |
| *** rdaly2 has joined #openstack-swift | 17:11 | |
| *** jistr has quit IRC | 17:21 | |
| *** MVenesio has joined #openstack-swift | 17:22 | |
| *** rledisez has quit IRC | 17:22 | |
| *** tgohad is now known as tsg_ | 17:25 | |
| *** rdaly2 has quit IRC | 17:31 | |
| *** rdaly2 has joined #openstack-swift | 17:31 | |
| *** zhill has joined #openstack-swift | 17:38 | |
| *** rdaly2 has quit IRC | 17:39 | |
| *** rdaly2_ has joined #openstack-swift | 17:39 | |
| *** tsg_ has quit IRC | 17:41 | |
| *** ihrachyshka has quit IRC | 17:50 | |
| *** mahatic has quit IRC | 18:00 | |
| peluse | cores, tsg's patch for multi-phase PUT is in need of a 2nd review. https://review.openstack.org/#/c/153843/ | 18:00 |
| peluse | this is a big thing for us to be comfortable with ASAP to move forward on beta... please block off some time as soon as you can, thanks! | 18:01 |
| *** mmcardle has quit IRC | 18:03 | |
| acoles | peluse: in test_diskfile there's places where the diskfile name is constructed like this Timestamp(time()).internal + '-0.data'. ok with you if i change it to use the ts_to_fname helper method? | 18:05 |
| peluse | acoles, yeah, totally. I was thikning about that when you asked about changing the "-", sorry :) | 18:07 |
| *** annegentle has joined #openstack-swift | 18:07 | |
| acoles | peluse: no worries, its defensive coding on my part in case someone objects to # :D | 18:07 |
| peluse | acoles, I would have taken the time to do it that way to being but as I said the elements now broken out in that patch (which you need to add yourrself as co-author to on next submit BTW) started off as simply things I needed to quickly hack out of the way so I could test reconstructor scenarios. bad me :( | 18:10 |
| peluse | torgomatic, FYI I didn't merge master-->EC Fri on purpose because I wanted us to land tsg's patch first to keep it as simple as possible. Will do so after its down | 18:11 |
| acoles | peluse: sorry, one other thing - i have some tests failing now because for example they create a diskfile with EC policy and then try to open it, but with no .durable and the change to get_ondisk_file, the open will raise an exception (cos no data file returned without a durable) | 18:12 |
| acoles | peluse: not sure how to work around that - there's no .durable writer in this patch | 18:12 |
| acoles | peluse: i could put in a 'dont_require_durable' option but that would only be for testing?? | 18:13 |
| peluse | acoles, or, you could add tsg's patch as a dependency | 18:14 |
| * peluse apologizes for the suggestion, I hate managing dependencies | 18:15 | |
| peluse | acoles, or, as you can see with a few test cases I write one in the test case | 18:16 |
| acoles | peluse: of course. ok i'll do that tomorrow. so status fo rnow is get_ondisk_files and hash_cleanup_listdir both re-worked, tested, just got these knock-on effects to iron out. | 18:16 |
| acoles | peluse: just need to remember to always get a coffee before rebasing dependencies ;) | 18:17 |
| peluse | acoles, and a beer or two afterwards | 18:17 |
| acoles | right! | 18:17 |
| *** jordanP has quit IRC | 18:25 | |
| *** theanalyst has joined #openstack-swift | 18:30 | |
| theanalyst | Does swift have the notion of object acls? | 18:32 |
| peluse | theanalyst, no, container level | 18:33 |
| theanalyst | peluse: so at a container level I can only give access to reading the entire container right .. not specific objects I suppose | 18:34 |
| peluse | theanalyst, correct | 18:35 |
| theanalyst | peluse: and probably the way to give object level access is tempurl or is there any other way to share a specific object? | 18:36 |
| peluse | theanalyst, sure - have you checked out notmyname's blog on the subject https://swiftstack.com/blog/2015/01/29/swift-feature-highlight-tempurls/ | 18:39 |
| *** aix has quit IRC | 18:41 | |
| theanalyst | peluse: thanks :) | 18:41 |
| *** geaaru has quit IRC | 18:47 | |
| clayg | charz: unittests would be great for https://review.openstack.org/#/c/160283/2 - did you try to look for any tests that might cover similar functionality? | 18:51 |
| clayg | charz: I added a gist to https://review.openstack.org/#/c/148791/ that I think would be a very similar scenario to your patch? | 18:52 |
| *** bkopilov has quit IRC | 18:53 | |
| *** bkopilov has joined #openstack-swift | 18:53 | |
| clayg | https://gist.github.com/clayg/a82f475edf46e61eb4b6 <- somewhere in test_service, create a tempdir, add some stub files, mock a few responses and kick off an upload job | 18:54 |
| *** zul has quit IRC | 18:56 | |
| *** zul has joined #openstack-swift | 18:56 | |
| *** devlaps has joined #openstack-swift | 19:01 | |
| *** rdaly2_ has quit IRC | 19:09 | |
| *** annegentle has quit IRC | 19:10 | |
| *** shakamunyi has joined #openstack-swift | 19:20 | |
| *** doxavore has quit IRC | 19:23 | |
| *** annegentle has joined #openstack-swift | 19:27 | |
| *** devlaps has quit IRC | 19:29 | |
| *** doxavore has joined #openstack-swift | 19:35 | |
| *** acoles is now known as acoles_away | 19:46 | |
| *** icksa has joined #openstack-swift | 19:54 | |
| jrichli | I have noticed that if I use a debugger with the functests, I can sometimes get a ResponseError: 408: 'Request Timeout' whereas I don't get that when the debugger is not used. | 19:57 |
| jrichli | I tried increasing the configured timeouts in my SAIO, but that didn't solve the problem. | 19:57 |
| *** straycat has quit IRC | 19:58 | |
| *** straycat has joined #openstack-swift | 20:02 | |
| *** sandywalsh_ has joined #openstack-swift | 20:05 | |
| *** nellysmi_ has joined #openstack-swift | 20:05 | |
| *** fifieldt has quit IRC | 20:07 | |
| *** sandywalsh has quit IRC | 20:07 | |
| *** nellysmitt has quit IRC | 20:09 | |
| *** EmilienM|afk is now known as EmilienM | 20:10 | |
| *** tsg has joined #openstack-swift | 20:17 | |
| *** zaitcev has quit IRC | 20:19 | |
| notmyname | great email on openstack-dev ML from jeblair on auto-abandoned patches. subject is "[openstack-dev] auto-abandon changesets considered harmful..." | 20:23 |
| *** fifieldt has joined #openstack-swift | 20:25 | |
| *** lpabon has joined #openstack-swift | 20:32 | |
| clayg | notmyname: i'm not sure i follow the logic that lead to the conclusion, changes which have negative feedback that isn't addressed means 1) the author didn't care about it enough to follow up 2) the core reviewers didn't care about it enough to fix it for them - if it's not going to get abandonded what do where do we think it's going to go? | 20:46 |
| notmyname | what I like about the email is the consideration of the negative effects of auto-abandon (potential or realized) and using existing tools to filter | 20:50 |
| notmyname | I'm not sure there was anything mentioned about patches specifically with negative reviews (as opposed to just old stuff) | 20:50 |
| clayg | oh, maybe i'm confused then - do *we* abandon changes just cause no one has looked at them? | 20:51 |
| notmyname | no. only if it has a negative review and 6 weeks of no activity | 20:51 |
| clayg | ^ see that seems reasonable | 20:51 |
| clayg | is that thread about abandoning changes that don't meet that requirement? | 20:52 |
| notmyname | I think the auto-abandon stuff came up because people were looking at review stats, seeing big numbers, and suspecting that the lack of abandon scripts was causing inflation in the mean/median review time | 20:53 |
| * notmyname gives clayg 10 review points for using the word "persnickety" in a code review | 20:54 | |
| clayg | ok, well I think tom's suggestion of a pre abandon message wouldn't hurt at all | 21:01 |
| notmyname | ya, we do an email, since a gerrit review comment actually resets the timer on detecting activity | 21:02 |
| *** lpabon has quit IRC | 21:05 | |
| *** annegentle has quit IRC | 21:05 | |
| *** shakamunyi has quit IRC | 21:07 | |
| *** shakamunyi has joined #openstack-swift | 21:08 | |
| mattoliverau | Morning | 21:16 |
| *** chlong has joined #openstack-swift | 21:23 | |
| jrichli | morning | 21:26 |
| *** annegentle has joined #openstack-swift | 21:29 | |
| *** icksa has quit IRC | 21:38 | |
| notmyname | tsg: re the eventlet update in requirements, please wait until later this week to repropose to master. it should only go there if we're going to do ec in kilo. and we should be able to make that call on wednesday | 21:46 |
| tsg | notmyname: yes, I will wait until we make a decision | 21:46 |
| notmyname | tsg: or to rephrase, only propose to master if the next planned swift release will have ec | 21:46 |
| tsg | sure - that makes sense | 21:46 |
| notmyname | there isn't anything dependent on it, is there? | 21:47 |
| notmyname | dependent patch sets | 21:47 |
| tsg | notmyname: nothing except for the multiphase PUT patch | 21:47 |
| notmyname | oh that's all? ;-) | 21:47 |
| tsg | ;) | 21:48 |
| notmyname | tsg: but since CI tests with the latest available, why does it need to be a dependent patch? | 21:48 |
| tsg | notmyname: that's true - we can get the patch in by removing the dependency for now | 21:48 |
| notmyname | ok | 21:49 |
| notmyname | tsg: do you want to rebase away from the dependency or should I? | 21:49 |
| tsg | notmyname: there are some suggestions from peluse that I need to incorporate and send a new version anyway so no worries, I will get it done shortly | 21:50 |
| notmyname | ok, thanks | 21:50 |
| *** chlong has quit IRC | 21:51 | |
| notmyname | jrichli: any thoughts on me abandoning this patch? https://review.openstack.org/#/c/122773/ | 21:51 |
| notmyname | or, I can't see a reason not too, but you may know more about what he's working on | 21:52 |
| jrichli | notmyname: I haven't seen this before. I will take a look | 21:52 |
| *** shakamunyi_ has joined #openstack-swift | 21:53 | |
| notmyname | jrichli: I think the summary is "older work that is superseded by what you're doing now" | 21:53 |
| *** shakamunyi has quit IRC | 21:54 | |
| jrichli | notmyname: sorry, I was in a different world a moment ago. I HAVE seen this :-) | 21:54 |
| jrichli | notmyname: yes, I agree to abandon. | 21:54 |
| *** aix has joined #openstack-swift | 21:56 | |
| notmyname | I know many of you will be devastated by this, but this week's swift team meeting will need to be limited to 30 minutes (instead of a full hour). | 21:59 |
| *** cebruns has quit IRC | 22:01 | |
| mattoliverau | What! Oh the humanity! Tho that means we should definitely focus on our EC decision | 22:06 |
| notmyname | someone please look at https://gist.github.com/notmyname/f0b69acf4b88d2eebdc8 (copy and paste to your browser). I'm playing with the top section. should be "patches starred by you or me" and should include the bump eventlet patch (as a test) | 22:08 |
| notmyname | this was something we talked about at the hackathon ("get the dashboard to show patches starred by the ptl") | 22:08 |
| peluse | tsg, I'd prefer you not push a new patch just for my comments (unless you're almost done), would rather that one get another +2 and a new patch can be done later to cover the small things | 22:12 |
| tsg | peluse: ok | 22:12 |
| tsg | peluse: think I should take care of the DiskFile change (removing the is_durable() method) though? | 22:13 |
| notmyname | tsg: peluse: if it gets the necessary reviews and is ready to land (but is dependent on the unmerged eventlet bump), then at that point rebase away from the requirements patch and merge it based on existing reviews | 22:13 |
| tsg | peluse, notmyname: I will remove the eventlet patch dependency at the least | 22:14 |
| notmyname | tsg: but if it's about to get a 2nd +2, then don't push a new patch set yet | 22:14 |
| mattoliverau | notmyname: cool, I can see 4 patchsets in Starred: 145403, 152283, 117193 and 120424 | 22:14 |
| peluse | tsg, OK, cool. the other stuff can wait, just want to get more eyes on it sooner than later and I don't think there's any reason right now why another core can't review what's there | 22:14 |
| notmyname | mattoliverau: oh? interesting. you can see the keystonemiddleware and the tempest ones? | 22:15 |
| * peluse nudges torgomatic and clayg who have the most history looking at the PUT side wrt multi-phase.... | 22:16 | |
| tsg | peluse: I will find time to get a new rev pushed in the next hour .. torgomatic has any comments on https://review.openstack.org/#/c/153843/ | 22:16 |
| notmyname | mattoliverau: next up is to star one yourself and make sure the resulting list is a superset of yours and mine | 22:17 |
| tsg | torgomatic: comments on https://review.openstack.org/#/c/153843/? | 22:17 |
| mattoliverau | yup I can... let me go star one and see what happens | 22:18 |
| mattoliverau | notmyname: yup, the one I just starred turned up as well! | 22:19 |
| notmyname | mattoliverau: great! thanks | 22:19 |
| *** tsg_ has joined #openstack-swift | 22:30 | |
| *** tsg has quit IRC | 22:32 | |
| tdasilva | notmyname: starred == priority reviews, right? | 22:35 |
| *** cl__ has quit IRC | 22:35 | |
| notmyname | tdasilva: you can star whatever you want. but in SF several people said that if I starred priority patches and that were visible on the review dash, that would be helpful. so ya, I'm going to star priority stuff and stuff to track | 22:36 |
| tdasilva | notmyname: yeah...that's what I meant to say..... PTL starred == priority reviews... | 22:37 |
| tdasilva | notmyname: I think it's a good idea! | 22:37 |
| notmyname | I think it's an imperfect tracking thing. but better than nothing! | 22:37 |
| notmyname | I like it too | 22:37 |
| *** rdaly2 has joined #openstack-swift | 22:42 | |
| *** annegentle has quit IRC | 22:47 | |
| *** rdaly2 has quit IRC | 22:47 | |
| notmyname | torgomatic: what's up with https://review.openstack.org/#/c/104705/ | 22:51 |
| torgomatic | notmyname: it's old and broken; did the abandoner not get it? | 22:53 |
| *** MVenesio has quit IRC | 22:54 | |
| notmyname | torgomatic: nope. b/c you have it WIP. if it's dead, can you abandon it? | 22:54 |
| torgomatic | sure | 22:54 |
| * torgomatic heads for a late lunch | 22:54 | |
| notmyname | thanks | 22:54 |
| *** annegentle has joined #openstack-swift | 22:59 | |
| *** km has joined #openstack-swift | 23:02 | |
| *** shakamunyi_ has quit IRC | 23:06 | |
| *** cebruns has joined #openstack-swift | 23:11 | |
| *** ahale has quit IRC | 23:14 | |
| *** jrichli has quit IRC | 23:18 | |
| *** annegentle has quit IRC | 23:20 | |
| *** nellysmi_ has quit IRC | 23:21 | |
| *** annegentle has joined #openstack-swift | 23:22 | |
| *** nellysmitt has joined #openstack-swift | 23:23 | |
| *** ahale has joined #openstack-swift | 23:24 | |
| *** nellysmitt has quit IRC | 23:28 | |
| *** annegentle has quit IRC | 23:33 | |
| *** chlong has joined #openstack-swift | 23:33 | |
| *** doxavore has quit IRC | 23:38 | |
| *** openstackgerrit has quit IRC | 23:38 | |
| *** openstackgerrit has joined #openstack-swift | 23:38 | |
| *** annegentle has joined #openstack-swift | 23:48 | |
| notmyname | k, I think I have a couple of new (*updated) swift gerrit dashboards | 23:48 |
| notmyname | now to shorten the URLs | 23:48 |
| notmyname | http://goo.gl/uRzLBX <--- review dahsboard | 23:49 |
| notmyname | http://goo.gl/9EI0Sz <--- project overview dashboard | 23:50 |
| notmyname | the review one is more of "review this stuff now" and is probably better for a day-to-day list of stuff to review | 23:51 |
| *** erlon has quit IRC | 23:51 | |
| notmyname | the overview one is more about "stuff that's going on and potential issues" (eg gate is blocked or needs reverify) and also tracks the feature branches | 23:51 |
| notmyname | the overview one also has a section for "any open patch starred by any core reviewer" | 23:52 |
| *** dmsimard is now known as dmsimard_away | 23:52 | |
| notmyname | and I just starred all the stuff on the priority reviews page so that shows up in the review dashboard | 23:54 |
| *** ChanServ changes topic to "Review Dashboard: http://goo.gl/uRzLBX | Priority Reviews: https://wiki.openstack.org/wiki/Swift/PriorityReviews | Ideas: https://wiki.openstack.org/wiki/Swift/ideas" | 23:55 | |
| *** tsg_ has quit IRC | 23:56 | |
| *** EmilienM is now known as EmilienM|afk | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!