Thursday, 2014-12-04

*** Masahiro has joined #openstack-swift00:01
*** Masahiro has quit IRC00:05
*** rdaly2 has quit IRC00:17
notmynamegyee: looking00:25
gyee_notmyname, thanks00:25
notmynamegyee: I'm pretty sure there's a way, but I haven't looked at that section of code recently enough to remember. checking now00:25
gyee_my understanding is that it requires db hack00:25
gyee_like manually reverse the status00:26
notmynameso far I'm reaching that same conclusion00:28
gyee_notmyname, I was looking at this doc http://docs.openstack.org/developer/swift/overview_reaper.html00:28
gyee_not sure if its up-to-date though00:28
*** jwang__ has quit IRC00:28
notmyname(for others, we're talking about how to undelete an account before the reaper picks it up)00:28
*** nellysmitt has joined #openstack-swift00:29
gyee_notmyname, cool, thanks for the help!00:30
notmynamegyee_: yup. that's the current truth of things. that doc is correct00:34
*** nellysmitt has quit IRC00:34
gyee_notmyname, cool, thanks!00:35
notmynamegyee_: that being said, I'd love to see a patch for that utility00:36
gyee_me too :)00:37
gyee_I'll see what I can do00:37
notmynamegyee_: yay!00:37
*** dmorita has joined #openstack-swift00:50
*** jwang__ has joined #openstack-swift00:55
*** Masahiro has joined #openstack-swift00:55
*** addnull has joined #openstack-swift01:03
*** Masahiro has quit IRC01:07
*** tellesnobrega_ has quit IRC01:10
*** Masahiro has joined #openstack-swift01:10
openstackgerritClay Gerrard proposed openstack/swift: Fix reclaim on deleted containers  https://review.openstack.org/13892401:11
*** dmsimard is now known as dmsimard_away01:12
*** rmcall has quit IRC01:12
*** occupant has joined #openstack-swift01:27
*** gyee_ has quit IRC01:28
*** tellesnobrega_ has joined #openstack-swift01:32
*** bill_az has quit IRC01:33
*** nosnos has joined #openstack-swift01:52
*** sluo_wfh has joined #openstack-swift01:58
*** sluo_wfh has quit IRC02:03
*** haomaiwa_ has joined #openstack-swift02:11
*** Masahiro has quit IRC02:20
*** Masahiro has joined #openstack-swift02:23
*** nellysmitt has joined #openstack-swift02:30
*** sluo_wfh has joined #openstack-swift02:30
*** nellysmitt has quit IRC02:35
*** Masahiro has quit IRC02:38
*** Masahiro has joined #openstack-swift02:41
openstackgerritMerged openstack/swift: Clean up empty account and container partitions directories.  https://review.openstack.org/13852402:44
*** cppforlife has joined #openstack-swift02:52
mattoliverauSigh, you know your unit test-fu is a little off when you write a unit test to actally tests concurrent reads, which actually seems to succeeds but almost takes down my dev desktop when the test method runs! :P Might test it somewhere else before I take down infra and the swift stack bot :P03:02
mattoliverauin other words.. back to debugging :P03:02
*** tellesnobrega_ has quit IRC03:10
*** Masahiro has quit IRC03:18
*** Masahiro has joined #openstack-swift03:19
*** rdaly2 has joined #openstack-swift03:20
*** jwang__ has quit IRC03:22
*** nosnos has quit IRC03:23
*** rdaly2 has quit IRC03:25
*** Masahiro has quit IRC03:27
*** Masahiro has joined #openstack-swift03:30
*** rmcall has joined #openstack-swift03:33
*** rmcall has quit IRC03:38
*** bkopilov has quit IRC03:39
*** nosnos has joined #openstack-swift04:16
*** sandywalsh_ has quit IRC04:18
*** SkyRocknRoll has joined #openstack-swift04:23
*** echevemaster has quit IRC04:30
*** nellysmitt has joined #openstack-swift04:31
*** Masahiro has quit IRC04:31
*** nellysmitt has quit IRC04:36
*** Masahiro has joined #openstack-swift04:42
*** rmcall has joined #openstack-swift04:44
*** rmcall_ has joined #openstack-swift04:47
*** rmcall has quit IRC04:48
*** rmcall has joined #openstack-swift04:51
*** rmcall_ has quit IRC04:51
*** kopparam has joined #openstack-swift04:53
*** bkopilov has joined #openstack-swift04:58
*** kopparam has quit IRC05:03
*** Masahiro has quit IRC05:06
*** erlon has quit IRC05:09
*** erlon has joined #openstack-swift05:09
*** erlon has quit IRC05:09
*** erlon has joined #openstack-swift05:09
*** kopparam has joined #openstack-swift05:16
*** Masahiro has joined #openstack-swift05:16
openstackgerritMatthew Oliver proposed openstack/swift: Add concurrent reads option to proxy  https://review.openstack.org/11771005:21
*** dmorita has quit IRC05:21
*** rdaly2 has joined #openstack-swift05:22
*** addnull has quit IRC05:23
*** ahonda has quit IRC05:23
*** ahonda has joined #openstack-swift05:24
*** zaitcev has quit IRC05:26
*** rdaly2 has quit IRC05:26
*** Masahiro has quit IRC05:26
*** Masahiro has joined #openstack-swift05:32
*** sungju has quit IRC05:50
*** Masahiro has quit IRC05:52
*** Masahiro has joined #openstack-swift05:55
*** addnull has joined #openstack-swift05:59
*** kopparam has quit IRC06:02
*** kopparam has joined #openstack-swift06:02
*** haomaiwa_ has quit IRC06:03
*** Masahiro has quit IRC06:05
*** Masahiro has joined #openstack-swift06:05
mattoliverauWell, I'm calling it a night. Sleep well swiftland.. or as the case may be have a great day to those of you who are just waking up!06:06
*** nshaikh has joined #openstack-swift06:11
*** nellysmitt has joined #openstack-swift06:32
*** nellysmitt has quit IRC06:37
*** kopparam has quit IRC06:39
*** kopparam has joined #openstack-swift06:39
*** addnull has quit IRC06:41
*** k4n0 has joined #openstack-swift06:54
*** addnull has joined #openstack-swift07:01
*** haomaiwa_ has joined #openstack-swift07:05
*** rmcall has quit IRC07:07
*** addnull has quit IRC07:16
*** addnull has joined #openstack-swift07:16
*** rdaly2 has joined #openstack-swift07:23
*** rdaly2 has quit IRC07:28
*** Masahiro has quit IRC07:38
*** Masahiro has joined #openstack-swift07:49
*** addnull has quit IRC07:53
*** addnull has joined #openstack-swift07:54
*** rledisez has joined #openstack-swift08:08
*** nellysmitt has joined #openstack-swift08:26
*** geaaru has joined #openstack-swift08:36
*** jordanP has joined #openstack-swift08:53
*** kopparam has quit IRC09:01
*** jistr has joined #openstack-swift09:05
*** jordanP has quit IRC09:05
openstackgerritMerged openstack/swift: Fix reclaim on deleted containers  https://review.openstack.org/13892409:10
*** jordanP has joined #openstack-swift09:17
*** rdaly2 has joined #openstack-swift09:25
*** nshaikh has quit IRC09:27
*** rdaly2 has quit IRC09:29
*** foexle has joined #openstack-swift09:31
*** jistr is now known as jistr|trng09:35
*** kopparam has joined #openstack-swift09:37
*** nshaikh has joined #openstack-swift09:52
*** addnull has quit IRC09:56
*** rledisez has quit IRC09:59
*** rledisez has joined #openstack-swift10:07
*** Masahiro has quit IRC10:14
*** tellesnobrega_ has joined #openstack-swift10:34
openstackgerritDonagh McCabe proposed openstack/swift-specs: Minor updates to composite token spec  https://review.openstack.org/13877110:40
*** addnull has joined #openstack-swift10:44
*** haomaiwa_ has quit IRC11:01
*** tellesnobrega_ has quit IRC11:04
*** Masahiro has joined #openstack-swift11:15
*** Masahiro has quit IRC11:19
*** kopparam has quit IRC11:24
*** rdaly2 has joined #openstack-swift11:26
*** tellesnobrega_ has joined #openstack-swift11:28
*** kopparam has joined #openstack-swift11:30
*** rdaly2 has quit IRC11:31
*** acoles_away is now known as acoles11:35
acolesmattoliverau: hey matt, i used to almost overlap with you but now the clocks have changed it seems there is no chance11:37
acolesmattoliverau: glad you din't wake early for the meeting!11:38
mattoliverauacoles: yeah, perils of the opposite side of the globe, in spring (my time) I go forward and you guys go back, Autumn is the opposite. Making the gap either 2 hours closer or apart.11:47
mattoliverauacoles: thanks for the review :) anyway sleep time :)11:48
acolesmattoliverau: g'nite11:48
mattoliverauNight (or I guess I should say g'day)11:49
*** aix has quit IRC11:59
*** yuanz has quit IRC11:59
*** yuanz has joined #openstack-swift12:00
*** peluse_ has joined #openstack-swift12:00
*** peluse has quit IRC12:00
openstackgerritHisashi Osanai proposed openstack/swift: Allow hostnames for nodes in Rings  https://review.openstack.org/13315512:33
*** kopparam_ has joined #openstack-swift12:42
*** kopparam_ has quit IRC12:42
*** kopparam has quit IRC12:44
*** addnull has quit IRC13:08
*** SkyRocknRoll has quit IRC13:11
*** addnull has joined #openstack-swift13:12
*** Masahiro has joined #openstack-swift13:17
*** aix has joined #openstack-swift13:18
mordredan anybody point me to docs on how I get the info on a file I've uploaded to swift such that I can tell glance about it?13:20
*** aix has quit IRC13:20
*** bkopilov has quit IRC13:20
mordred(specifically on rackspace, but I'd probably like to just learn more about the swift concepts at play anyway)13:20
*** Masahiro has quit IRC13:22
*** nosnos has quit IRC13:27
*** rdaly2 has joined #openstack-swift13:28
*** bill_az has joined #openstack-swift13:29
*** rdaly2 has quit IRC13:32
*** bkopilov has joined #openstack-swift13:35
*** tellesnobrega_ has quit IRC13:35
*** nshaikh has quit IRC13:40
*** addnull has quit IRC13:41
*** tellesnobrega_ has joined #openstack-swift13:48
*** bkopilov has quit IRC13:49
*** ppai has joined #openstack-swift13:49
*** addnull has joined #openstack-swift13:50
*** addnull has quit IRC13:53
*** miqui_ has joined #openstack-swift14:06
*** jordanP has quit IRC14:07
annegentlemordred: so there's this https://developer.rackspace.com/docs/cloud-files/getting-started/#change-object-metadata but I am still looking for how to change object metadata14:12
*** jistr|trng has quit IRC14:13
annegentlemordred: then list it here http://docs.rackspace.com/files/api/v1/cf-devguide/content/HEAD_retrieveobjectmeta_v1__account___container___object__objectServicesOperations_d1e000.html14:14
annegentleoh I meant "looking for how to view it"14:14
ahalemordred: this kinda stuff, http://www.rackspace.com/knowledge_center/article/creating-an-ubuntu-1310-image-for-the-rackspace-open-cloud-0 ?14:15
ahalei dont think theres much swift concepts in play in this :)14:16
mordredahale: yes - although I'd love if there was a version of that which used python-glanceclient - but that's super helpful14:17
mordredahale: I think the swift concept I'm missing is "so I've uploaded a file to swift, what url can I fetch it from?"14:17
*** aix has joined #openstack-swift14:18
annegentlemordred: you want temp url, https://developer.rackspace.com/docs/cloud-files/getting-started/#get-object14:19
ahaleaha yeah that'll be the container/obj name in the glance api reqs, i guess it already knows your tenant etc14:19
mordredannegentle: I tried making one of those, I thought - but maybe with glance I don't actually need one of those, based on the curl examples14:20
*** ppai has quit IRC14:20
*** jordanP has joined #openstack-swift14:20
*** tellesnobrega_ has quit IRC14:21
*** jistr has joined #openstack-swift14:22
*** jistr is now known as jistr|trng14:22
*** tellesnobrega_ has joined #openstack-swift14:24
mordredahale: thank you VERY MUCH - that link was super helpful14:26
ahalecool stuff :)14:26
mordredahale: for what it's worth, the python-glanceclient translation seems to be:14:26
mordredglance --os-image-api-version=2 task-create --type=import --input='{"import_from": "images/test-monty-ubuntu.vhd", "image_properties" : {"name": "Test Monty Ubuntu"}}'14:26
ahaleoh neat, thats pretty straightforward14:27
mordredit's still in "processing" state, so I'm going to assume that the json payload made sense :)14:27
*** k4n0 has quit IRC14:33
*** miqui_ has quit IRC14:36
*** tdasilva has joined #openstack-swift14:37
*** tellesnobrega_ has quit IRC14:38
*** miqui_ has joined #openstack-swift14:47
*** sandywalsh has joined #openstack-swift14:56
*** kopparam has joined #openstack-swift14:58
*** lpabon has joined #openstack-swift14:58
*** geaaru has quit IRC15:02
*** kopparam has quit IRC15:04
*** Masahiro has joined #openstack-swift15:06
*** Masahiro has quit IRC15:11
*** dmsimard_away is now known as dmsimard15:16
*** pwehrle has joined #openstack-swift15:20
*** pwehrle has quit IRC15:22
*** kajinamit has joined #openstack-swift15:26
kajinamitIs there anybody available now?15:31
*** rdaly2 has joined #openstack-swift15:32
kajinamitI want somebody to review my patch(https://review.openstack.org/#/c/99598/) about bug in object-updater(https://bugs.launchpad.net/swift/+bug/1328735), which may cause dark object data in swift cluster not listed in container.15:33
openstackgerritChristian Schwede proposed openstack/python-swiftclient: Fix download redirect to stdout  https://review.openstack.org/13909115:35
openstackgerritThiago da Silva proposed openstack/swift: added testing notes to the contributing doc  https://review.openstack.org/13856815:41
*** bkopilov has joined #openstack-swift15:41
*** kajinamit has quit IRC15:43
*** mahatic has joined #openstack-swift15:44
*** aix has quit IRC15:49
openstackgerritAlistair Coles proposed openstack/python-swiftclient: Fix cross account upload using --os-storage-url  https://review.openstack.org/12575915:57
*** aix has joined #openstack-swift16:01
*** tellesnobrega_ has joined #openstack-swift16:07
*** SkyRocknRoll has joined #openstack-swift16:08
*** SkyRocknRoll has joined #openstack-swift16:08
*** rdaly2_ has joined #openstack-swift16:12
*** miqui__ has joined #openstack-swift16:15
*** clds_ has joined #openstack-swift16:16
*** zacksh has joined #openstack-swift16:17
*** rdaly2 has quit IRC16:18
*** jroll has quit IRC16:18
*** miqui_ has quit IRC16:18
*** jordanP has quit IRC16:18
*** zacksh_ has quit IRC16:18
*** ondergetekende has quit IRC16:18
*** JelleB has quit IRC16:18
*** mhu has quit IRC16:18
*** aix has quit IRC16:18
*** clds has quit IRC16:18
*** jroll has joined #openstack-swift16:18
*** jordanP has joined #openstack-swift16:19
*** mhu has joined #openstack-swift16:19
*** aix has joined #openstack-swift16:19
*** ondergetekende has joined #openstack-swift16:19
*** jroll has quit IRC16:19
*** jroll has joined #openstack-swift16:19
*** AbyssOne_ has joined #openstack-swift16:20
*** flwang has quit IRC16:26
*** nshaikh has joined #openstack-swift16:30
*** silor has joined #openstack-swift16:33
*** flwang has joined #openstack-swift16:39
*** exploreshaifali has joined #openstack-swift16:49
*** kopparam_ has joined #openstack-swift16:54
*** Masahiro has joined #openstack-swift16:54
*** Masahiro has quit IRC16:59
*** nshaikh has quit IRC17:04
*** tdasilva_ has joined #openstack-swift17:05
*** gyee_ has joined #openstack-swift17:07
*** tellesnobrega_ has quit IRC17:11
*** tdasilva has quit IRC17:12
*** foexle has quit IRC17:22
*** rledisez has quit IRC17:24
*** tellesnobrega_ has joined #openstack-swift17:25
*** rdaly2_ has quit IRC17:30
notmynamegood morning17:32
notmynameclayg: around yet/17:32
notmyname?17:32
*** annegent_ has joined #openstack-swift17:32
*** aix has quit IRC17:35
*** kopparam_ has quit IRC17:41
*** jordanP has quit IRC17:44
*** tellesnobrega_ has quit IRC17:44
*** geaaru has joined #openstack-swift17:45
*** annegent_ has quit IRC17:48
*** rdaly2 has joined #openstack-swift17:48
*** rdaly2 has quit IRC17:49
*** rdaly2 has joined #openstack-swift17:49
*** kopparam has joined #openstack-swift17:49
*** jistr|trng has quit IRC17:51
*** jwang__ has joined #openstack-swift17:55
*** annegent_ has joined #openstack-swift17:57
*** AbyssOne_ is now known as JelleB18:01
*** rdaly2 has quit IRC18:04
*** nshaikh has joined #openstack-swift18:18
*** kopparam has quit IRC18:19
ipolyzoshello18:22
ipolyzostry to use the keystone ec2-credentials-create but even though I provide the correct credential and produces an empty answer, could you please help me on how to proceed with identify potential problem that cause this ?18:24
*** jwang__ has quit IRC18:32
notmynameipolyzos: I'm not familiar with that tool, but the "ec2" part of it makes me think you aren't using swift. if you're looking for some keystone-specific help, #openstack-keystone might be a good place. if you're looking for help with compute, #openstack-nova is where I'd go18:34
*** Masahiro has joined #openstack-swift18:43
*** jwang__ has joined #openstack-swift18:43
openstackgerritMerged openstack/swift: Fix container quota check during cross-account COPY  https://review.openstack.org/13690418:44
openstackgerritMerged openstack/swift: Raise ValueError for offset on Timestamp over limit  https://review.openstack.org/13816118:44
*** gyee_ has quit IRC18:45
*** Masahiro has quit IRC18:48
*** openstackgerrit has quit IRC18:50
*** openstackgerrit has joined #openstack-swift18:50
*** nellysmitt has quit IRC19:00
*** tellesnobrega_ has joined #openstack-swift19:06
*** pberis_ has joined #openstack-swift19:09
*** annegent_ has quit IRC19:28
ipolyzosnotmyname: thanks alot,  I'm not very familiar also.  Got it out was a config mistake in the env vars. Thanks alot in any case...19:30
openstackgerritMerged openstack/swift: added testing notes to the contributing doc  https://review.openstack.org/13856819:36
*** jwang__ has quit IRC19:37
*** jwang__ has joined #openstack-swift19:38
*** tellesnobrega_ has quit IRC19:38
*** flwang has quit IRC19:40
*** tellesnobrega_ has joined #openstack-swift19:42
*** jbonjean has joined #openstack-swift19:45
jbonjeanHi, does anyone know why in the proxy server, connection timeout and refused are not considered as errors ? (so the error count not incremented ...)19:48
jbonjeanthis mean the nodes that do not respond are never ignored19:49
*** flwang has joined #openstack-swift19:52
*** rdaly2 has joined #openstack-swift19:52
*** openstackgerrit has quit IRC20:04
*** openstackgerrit has joined #openstack-swift20:04
*** annegent_ has joined #openstack-swift20:05
*** annegent_ has quit IRC20:08
*** annegent_ has joined #openstack-swift20:12
*** annegent_ has quit IRC20:21
claygtdasilva_: thanks for updates on https://review.openstack.org/#/c/138568/ - totally got that bad boy merged!20:23
claygcschwede: looks like you need to six up https://review.openstack.org/#/c/139091/ - you around to do that or you need a push over?20:25
*** annegent_ has joined #openstack-swift20:26
*** annegent_ has quit IRC20:26
openstackgerritAlistair Coles proposed openstack/python-swiftclient: Fix cross account upload using --os-storage-url  https://review.openstack.org/12575920:30
*** acoles is now known as acoles_away20:32
*** Masahiro has joined #openstack-swift20:32
*** jwang__ has quit IRC20:35
claygnotmyname: this change got merged pretty fast (good) but I think was a sorta terrible bug - and I had the fix before even opening anything on launchpad - can you put on your community operator hat and figure out what we need to do re notification or worst case even backporting :\20:36
claygredbo: dfg: ^20:36
*** Masahiro has quit IRC20:37
claygsorry, forgot the link!20:41
clayghttps://review.openstack.org/#/c/138924/20:41
notmynameclayg: I propose we use zaitcev's review comment as the changelog message: "Closed bug blah 'lift the fist of an angry god'"20:42
clayglike?20:43
*** exploreshaifali has quit IRC20:43
mattoliverauMorning21:08
notmynamemattoliverau: hi21:10
clayghi mattoliverau!21:11
*** tellesnobrega_ has quit IRC21:14
*** silor has quit IRC21:14
*** nshaikh has left #openstack-swift21:15
tdasilva_clayg: hi, got time to talk about obj. versioning?21:17
claygtdasilva_: yeah ok21:20
tdasilva_clayg: just a quick question: in the commit message, you added a question about making version_writes a required middleware. I was thinking of removing the allow_versions option from the container server config. and just making the middleware optional21:22
claygtdasilva_: i have no idea what to do for upgrade path there :\21:22
tdasilva_clayg: oh, yeah...I always forget to think of upgrades, good point..well, couldn't we just add to the release notes that the middleware should now be added to the pipeline for those deployments that had "allow_versions=true"21:24
*** SkyRocknRoll has quit IRC21:25
claygtdasilva_: idk, in most cases that means the operator has to update a bunch of deployment tooling before they can update to the new version - and most of the time you want your deployment tooling to push out a single config that would be valid the old and new version21:26
claygso you have this change that requires you make different looking configs, you halt the upgrade train and update your deployment tools to push out a config that would also work with the new code, then you push out the new code, then you remove the cruft*21:26
clayg* note the last part never happens21:26
claygif it's not a required middleware, then I can't put it in the pipeline?21:27
claygmaybe if the proxy had an "make the versions works" flag that old code would simply ignore - then I could just turn it on in both places and after the upgrade everything still works?21:27
claygmaybe the "make the versions works" flag is a noop if the middleware is alreayd in the pipeline or something and it defaults to true... i don't really know?21:28
tdasilva_clayg: how about checking in the proxy server where we add the required middleware to see if it's in the pipeline, if it's not and the old flag is still saying true, then auto add to the pipeline21:29
claygwhat old flag - the one in the container server?  proxy may not have it21:29
tdasilva_oh, true21:30
claygnotmyname: you screwed up when you put the version option in the container servers configs21:30
tdasilva_lol21:30
claygnotmyname: next time use your time machine21:30
notmyname;-)21:30
notmynameI screwed up when i didn't make it middleware ;-)21:30
tdasilva_notmyname: that's ok, gave opportunity to learn a bunch stuff :-)21:31
claygthere's no problem in object storage that can't be solved with another piece of middleware exept too many middlewares?21:31
claygpretty sure someone said that21:31
notmynameclayg: maybe one middleware that takes plugins?21:31
notmynamemaybe we could have a whole "openstack middleware" project!21:31
tdasilva_clayg: i will think a bit more about this problem...next question: you also added this note: "write new tests to verify correct handling metadata on backend COPYs"21:32
tdasilva_clayg: not sure what that means honestly21:32
tdasilva_clayg: what backend COPYs?21:34
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873621:34
claygtdasilva_: well the unittest's that did the real socket stuff caught the content-type thing, but I don't think they would have caught the same problem for x-object-meta21:35
claygi'm pretty sure your latest code get's metadata right just like content-type cause it uses subrequest or w/e - but it'd be nice to have a test that proves it21:35
claygI think "backedn copy" in this context was the GET/PUT request that deals with the current version before handling the PUT that triggered it (or something)21:36
claygtdasilva_: wasn't it like the PUT of the current version into the version backlog was getting headers that came along with the PUT that was trying to over-write it or something?21:36
tdasilva_clayg: yes, now i understand21:36
claygtdasilva_: a test to validate the metadata sent in the PUT doesn't leak into the old version seemed to be missing, maybe I'm off my rocker, this is all from memeory21:36
*** bitblt has joined #openstack-swift21:37
tdasilva_clayg: no no, now i understand, thanks!21:37
claygtdasilva_: sweet!  no thank YOU!21:37
tdasilva_clayg: for some reason I got caught up in "backend COPY" and I thought you were talking about some backend daemons that I don't know about21:37
tdasilva_clayg: thanks!21:38
claygyeah i'm sure there's something to do with some backend something that's not covered by any test anywhere - but I'm not really sure what to tell you about that...21:38
tdasilva_no, it's ok..makes sense now...I'm in the process of adding more functional tests and I'll make sure to add those tests there too21:40
claygtdasilva_: oh awesome!21:40
claygtdasilva_: yeah I was thinking most of those real socket tests would have looked great/better as functional tests - I think I'd be totally fine dropping them in favor of better functional tests of versioned objects21:41
tdasilva_clayg: you had mentioned that they tested some corner cases, do you remember specifically what they were?21:44
tdasilva_clayg: i've tried going through the tests, but couldn't really point to anything that would be a corner case, so I'm probably missing something21:45
*** tdasilva has joined #openstack-swift21:50
*** tdasilva has quit IRC21:58
*** jwang__ has joined #openstack-swift22:05
*** rdaly2 has quit IRC22:05
*** tellesnobrega_ has joined #openstack-swift22:16
*** Masahiro has joined #openstack-swift22:21
*** gyee has quit IRC22:24
*** Masahiro has quit IRC22:26
*** gyee has joined #openstack-swift22:27
claygtdasilva_: the existing socket tests?  they just looked like the poked around the corners - and *they* found the content-type thing - not me really, i just ported them instead of skipping them and they found a bug (although i'll admit it took way too long to tease apart what exactly was failing and why because the stupid readuntil2cr style of requests is a total disaster)22:30
claygtdasilva_: I think they also hit some utf-8 stuff, but all of that seemed to work.22:31
claygtdasilva_: didn't your current change set eat all my ports - so all the existing tests are running and passing?  that's about as good as we've got, i don't know off the top of my head any behaviors of versioned objects that are not currently covered by any tests - I just didn't want to loose any coverage we had currently22:32
claygtdasilva_: I guess i thought i saw a gap for preservation of x-object-meta, there's weird combinations of features + object versions that I'm not even sure about the existing behavior - maybe bulk, *lo, expiring + versioned objects22:34
claygnotmyname: did the reclaim fix apply pretty cleanly to juno or did you have to un conflict it a bunch?22:36
notmynameclayg: cleanly22:37
*** pberis_ has quit IRC22:37
*** pberis has quit IRC22:37
notmynamehmm...but it looks like tests have an issue22:38
claygweeeeeee22:38
notmynameoh, maybe it's22:38
notmynameor maybe it's not22:38
*** jwang__ has quit IRC22:49
mattoliverauYay, I have a concurrent read unit test that only takes 0.703 seconds and doesn't almost crash my desktop.. the secret ended up being using <mock>.read.side_effect = ['custom body',''], so it actually ends and doesn't go into a infinite read() loop. (for those playing along at home) :P22:52
*** weishao has joined #openstack-swift22:53
*** miqui__ has quit IRC22:54
*** bkopilov has quit IRC22:54
notmynamemattoliverau: yay22:56
*** occup4nt has joined #openstack-swift22:57
mattoliverauyay mock-isms22:58
notmynameclayg: in the backport, the final part dir isn't getting cleaned up (line 1406 is the backport patch)22:59
notmynameclayg: is it assuming the behavior in ctennis's patch (d40cebfe)?23:00
*** occupant has quit IRC23:01
claygnotmyname: oh... yeah it sure it :\23:01
notmynameclayg: ok, no worries. want me to include that patch or remove the final test in the backport?23:01
claygso that whole run it again and validate the part dir is cleaned up bit can come off, i'm not sure when dfg's remove the suffix dir patch came in?23:01
claygnotmyname: can you just modify the test to not have that assert?  the part about deleting the db is pretty good - again not sure if we expect the suffix dir to be cleaned up in juno or not?23:02
notmynameclayg: actually the patch was from ctennis not dfg23:02
claygno no no, not the remove the *part* dir - the remove the *suffix* dir23:02
notmynameoj23:03
clayggawd there's only 4 dirs you'd think you could keep them stright23:03
*** oomichi has joined #openstack-swift23:07
notmynameok, bot ctennis's patch and your's proposed as backports to juno. 2 dependent patches23:09
*** bitblt has quit IRC23:18
*** occupant has joined #openstack-swift23:18
*** occup4nt has quit IRC23:20
*** weishao has quit IRC23:33
*** reed has joined #openstack-swift23:48
*** mahatic has quit IRC23:48
reednotmyname, I stumbled up this patch, wondering if it needs a blueprint/spec or may not need one https://review.openstack.org/#/c/137659/23:49
reedI am conversating with people at OVH already, I may ask them to add more details, if you think they're needed23:49
*** geaaru has quit IRC23:51
notmynamereed: need some answers to what clayg asked first. the commit message seems to say it does something that swift has supported for a while, so we want to hear back what they're doing and/or wanting23:52
*** dmsimard is now known as dmsimard_away23:53
reedok, I'll suggest them to get on IRC, email and respond to review23:53
reedthanks23:53
notmynamereed: thank you :-)23:53
tdasilva_clayg: sorry, had to step out for a bit, but I understand everything you said, got enough to keep me going now...23:54
claygtdasilva_: sweet23:54
*** ahonda has quit IRC23:58
*** ahonda has joined #openstack-swift23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!