| *** baoli has joined #openstack-sprint | 01:27 | |
| *** baoli has quit IRC | 01:56 | |
| *** dhellmann has quit IRC | 06:39 | |
| *** vern has quit IRC | 06:40 | |
| *** dhellmann has joined #openstack-sprint | 06:42 | |
| *** vern has joined #openstack-sprint | 06:43 | |
| *** matjazp has joined #openstack-sprint | 08:41 | |
| *** matjazp has quit IRC | 10:02 | |
| ianychoi | Hello ildikov! Are you online now? :) | 10:33 |
|---|---|---|
| *** matjazp has joined #openstack-sprint | 10:40 | |
| *** baoli_ has joined #openstack-sprint | 11:37 | |
| *** rfolco has joined #openstack-sprint | 12:30 | |
| *** electrofelix has joined #openstack-sprint | 13:55 | |
| zxiiro | electrofelix: waynr morning! | 14:21 |
| ildikov | ianychoi: hi | 14:26 |
| ildikov | ianychoi: now I'm online :) | 14:27 |
| waynr | howdy | 14:29 |
| waynr | zxiiro: i just got to my office at $dayjob and can't find my desk anywhere | 14:29 |
| zxiiro | waynr: oops unexpected moving? | 14:30 |
| waynr | it was expected, just executed with very little competence at least as far as the "services" teams are concerned | 14:32 |
| waynr | some idiot at the top of the corporate hierarchy decided everyone's desks need to be rearranged even if there wasn't a solid plan | 14:33 |
| electrofelix | zxiiro: morning | 14:35 |
| electrofelix | waynr: must be a popular guy at the office parties | 14:37 |
| zxiiro | electrofelix: waynr cool. I need to take off in 1.5 hrs (have an appointment) but we can probably get the couple patches merged and make plans for what to do next in that time | 14:37 |
| electrofelix | zxiiro waynr: I don't know if we want to merge "Support explicit API and simple config creation" yet as might have questions over whether it's a good idea or not | 14:42 |
| electrofelix | I'd like to read up a bit more about how to ensure good API design, we've got the first part, make it simple by being able to use a config object for most things | 14:43 |
| zxiiro | ok | 14:43 |
| zxiiro | let's remove it from the list then | 14:44 |
| zxiiro | electrofelix: I moved it down to the discussion list | 14:45 |
| zxiiro | so I think we can probably reasonably get 3 patches merged today | 14:45 |
| electrofelix | I've also updated https://review.openstack.org/#/c/319756 from where it was as it referenced the wrong object Jenkins versus JenkinsManager, but commit message probably needs redoing since it no longer makes attr's private (they are already '_' prefixed?) | 14:46 |
| zxiiro | thanks | 14:46 |
| electrofelix | I also have an updated patch for https://review.openstack.org/#/c/333076 that removes the double underscore '__', I've asked in python irc channel and it appears there really is no benefit any only downsides to using '__' versus '_'. | 14:49 |
| electrofelix | I've got an updated one that removes those and trims the commit message, to save some time from anyone else needing to do anything | 14:50 |
| *** rfolco has quit IRC | 14:50 | |
| electrofelix | only 2 comments on it about areas we can look for efficiency improvements, though I'm sure we could work out some more, one query on the unit tests change though that is unclear as to the purpose | 14:51 |
| electrofelix | I'm happy enough to do the fix on the setup.cfg to get macro component groups from the module entry points instead as a separate patch on top | 14:53 |
| zxiiro | electrofelix: sounds good. I also added to the etherpad the Views, Folders, Job DSL, and precendence patches we discussed yesterday | 14:54 |
| zxiiro | electrofelix: I plan to have the views patches complete by the next meeting | 14:54 |
| electrofelix | few other patches that might be worth landing in the mean time: | 14:58 |
| electrofelix | https://review.openstack.org/314136 - Raise exception on unrecognized project type | 14:58 |
| electrofelix | https://review.openstack.org/336091 - Improve logger output for expanding templates | 14:58 |
| electrofelix | https://review.openstack.org/336090 - Refactor base test classes inheritance for reuse | 14:58 |
| electrofelix | https://review.openstack.org/309735 - Output additional info when exceptions occur | 14:58 |
| zxiiro | electrofelix: https://review.openstack.org/319756 I updated the commit message, what do you think? | 14:59 |
| electrofelix | I think that's good enough | 15:01 |
| electrofelix | I couldn't come up with a phrasing at all | 15:01 |
| zxiiro | electrofelix: ok I added your patches to the list for merging today | 15:04 |
| zxiiro | Anything else we want to get in before 2.0? | 15:08 |
| waynr | whew, found my desk got everything plugged in | 15:10 |
| *** rfolco has joined #openstack-sprint | 15:10 | |
| electrofelix | zxiiro: I think https://review.openstack.org/150730 - Support deep merge of defaults | 15:11 |
| electrofelix | needs to be rewritten to use waynr's work, but the original reason is valid | 15:11 |
| *** pabelanger has left #openstack-sprint | 15:11 | |
| waynr | electrofelix zxiiro is that a backwards-incompatible change? | 15:11 |
| waynr | I think that's the change I wanted to be gated by some kind of config file feature flag | 15:12 |
| waynr | until we have an opportunity to discuss general DSL design direction | 15:13 |
| waynr | looks like that is the current state of the patch: https://review.openstack.org/150730 so yeah, looks good to me | 15:14 |
| waynr | erh https://review.openstack.org/#/c/150730/30/tests/yamlparser/fixtures/deep_merge_with_defaults.conf | 15:14 |
| zxiiro | electrofelix: ok i'll add that to do | 15:14 |
| zxiiro | cool I think we have enough todo items (probably more than enough) to aim for the next sprint | 15:15 |
| electrofelix | waynr: think you meant https://review.openstack.org/#/c/150730/30/tools/configs/non-defaults.conf | 15:15 |
| electrofelix | since that will test the infra configs with that behaviour enabled | 15:15 |
| waynr | electrofelix zxiiro, looks like both of you are +2 here: https://review.openstack.org/#/c/319756/ | 15:21 |
| electrofelix | waynr: ha, right at the same time1 | 15:22 |
| zxiiro | nice :) | 15:22 |
| *** mmedvede has quit IRC | 15:26 | |
| electrofelix | going to pick up the "Make delete_old_managed more convenient when using after update by tracking what's been just processed" task and also add the test to catch 'keep_old' being set incorrectly from the update command. | 15:32 |
| electrofelix | it seems that it's mostly because when you check whether certain calls are made, there is no api into mock to make sure they were the only calls made. | 15:33 |
| electrofelix | zxiiro waynr: regression test for --delete-old and keep_jobs in update command - https://review.openstack.org/371661 | 15:45 |
| electrofelix | ok, have to head for now, I'll check in via mobile in a little while on the other patches. | 15:46 |
| zxiiro | electrofelix: sounds good. I need to head out too for lunch. I'll check again later when i'm back if there's new feedback | 15:47 |
| electrofelix | I'll upload the fixes for my comments on https://review.openstack.org/#/c/333076/ | 15:47 |
| electrofelix | ttyl | 15:50 |
| *** electrofelix has quit IRC | 15:50 | |
| waynr | er i was just working on 333076 | 15:54 |
| waynr | okay i have to focus on $dayjob stuff right now, it's too stressfull trying to split my attention between this and the 3-4 things that i am being paid to pay attention to | 16:16 |
| waynr | especially when i don't get a chance to address comments on a patch before those comments are addressed by the person who made the comments | 16:17 |
| zxiiro | sorry about that. | 18:21 |
| zxiiro | waynr: anything I should look at? | 18:21 |
| zxiiro | zaro: do you have some time to help us land some patches? https://etherpad.openstack.org/p/jjb_api_v2.0 | 18:23 |
| waynr | zxiiro: it's no anyone's fault but my own really, i am just overcommitted with $dayjob and JJB right now | 18:50 |
| *** openstackstatus has quit IRC | 19:58 | |
| *** openstackstatus has joined #openstack-sprint | 20:00 | |
| *** ChanServ sets mode: +v openstackstatus | 20:00 | |
| *** larainema has quit IRC | 20:24 | |
| *** rfolco has quit IRC | 21:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!