| *** kien-ha has quit IRC | 05:36 | |
| *** hieulq has quit IRC | 09:12 | |
| *** hieulq has joined #openstack-sprint | 09:27 | |
| *** rfolco_ has joined #openstack-sprint | 11:46 | |
| *** baoli has joined #openstack-sprint | 12:11 | |
| *** baoli_ has joined #openstack-sprint | 12:12 | |
| *** baoli has quit IRC | 12:16 | |
| *** waynr has joined #openstack-sprint | 13:15 | |
| *** kien-ha has joined #openstack-sprint | 13:19 | |
| *** cdelatte has joined #openstack-sprint | 13:30 | |
| *** electrofelix has joined #openstack-sprint | 13:44 | |
| waynr | electrofelix: yo | 13:55 |
|---|---|---|
| waynr | I saw your comments about inheriting from jenkins.Jenkins, I actually agree pretty much 100% | 13:56 |
| waynr | well, 95% | 13:56 |
| waynr | the other 5% wanted to experiment and see what everyone else thought | 13:57 |
| waynr | i'm actually not too fond of the way the python-jenkins library is structured, useful as it is | 13:58 |
| electrofelix | wanted to hear what others thought as well, figured I'd bring it up early so that people have time to think and comment | 14:02 |
| zxiiro | electrofelix: waynr I'm around but need to split my focus with release activities today | 14:03 |
| electrofelix | zxiiro: that's cool, I'm in a split brain situation as well, need to leave for about an hour in the middle to sort out a spare tyre issue | 14:04 |
| electrofelix | as well as other work on going, but as long as we can make sure that any concerns in the list of main patches are addressed and we can respond quickly to work out what is needed I think the main focus is the next 30-45 minutes | 14:05 |
| electrofelix | and then after that it should be just working away as needed with a few QA on specific details | 14:05 |
| waynr | i'm also on a video call with a belfast coworker at the moment, will be free in about an hour | 14:09 |
| electrofelix | hmm, maybe convene in an hour and I'll run off and sort out the spare tyre issue now | 14:12 |
| *** cdelatte has quit IRC | 14:16 | |
| electrofelix | zxiiro: I think the first set of patches look ok - https://review.openstack.org/#/c/319615 & https://review.openstack.org/319616, first thing needing fix or todo is on https://review.openstack.org/#/c/262954/10 | 14:17 |
| zxiiro | electrofelix: looking | 14:20 |
| electrofelix | other than those, check back in an hour and we can discuss the next few | 14:23 |
| zxiiro | electrofelix: ok merged the 2 patches i'll check back in a bit for the 3rd one once it's resolved | 14:24 |
| waynr | okay meeting done can focus on reviews | 15:13 |
| waynr | huh I definitely don't recall intending to remove that log message | 15:17 |
| waynr | although looking at it I don't see how I could have not intended to do it | 15:19 |
| waynr | electrofelix: did you see the response to your comment here: https://review.openstack.org/#/c/319621/ | 15:37 |
| *** rfolco_ has quit IRC | 15:47 | |
| electrofelix | back | 15:47 |
| electrofelix | sorry, that took longer than planned | 15:47 |
| electrofelix | ok, so I'm happy with the answer on that, I'm not fully read up on openstacks guidance on backwards compatibility around major releases, so was unsure if we were just going to follow semver or if there was anything openstack specific we should be looking to follow | 15:52 |
| electrofelix | waynr: was the change to the logging in https://review.openstack.org/#/c/262954 intended or accidental? Wondering if there was a reason or if we need to add it to the TODO list to be touched up on top? | 15:53 |
| waynr | i've already fixed it in my local copy, just waiting to push until i've addressed feedback on other patchsets | 15:54 |
| electrofelix | waynr: oh, just assumed that these nits would be handled as TODOs, but if you already have it fixed that's great | 15:57 |
| waynr | i don't remember why i made that change, strange to me because I never use the delete old unmanaged behavior | 15:59 |
| waynr | s/un// | 15:59 |
| waynr | okay, I think i've addressed all available feedback | 16:10 |
| electrofelix | excellent | 16:14 |
| *** baoli_ has quit IRC | 16:27 | |
| *** baoli has joined #openstack-sprint | 16:28 | |
| *** baoli has quit IRC | 16:33 | |
| electrofelix | ok, all looks good to me as far as https://review.openstack.org/#/c/319621 which is Remove deprecated 'extended-choice' property., just waiting for zuul to vote on them | 16:42 |
| zxiiro | stepping out for late lunch. I'll be back in a bit | 16:48 |
| electrofelix | ok, I think most of the patches are in the 2x2+ just waiting on Zuul to +1 before approving | 17:18 |
| electrofelix | zxiiro: I think the only remaining ones from the proposed set are https://review.openstack.org/#/c/319618 and https://review.openstack.org/#/c/319620 | 17:18 |
| electrofelix | waynr zxiiro: I don't think we've added any more todo's so far | 17:19 |
| electrofelix | and I'll see if I can get a review of https://review.openstack.org/#/c/319622 this evening | 17:19 |
| electrofelix | zxiiro waynr: sorry I haven't been able to be more responsive today, hadn't expected to have to also have a few other things on the plate here at the same time | 17:20 |
| electrofelix | I need to drop off for about 45 minutes to pick the gf up (she's no car as the spare tyre doesn't fit, hence why I was getting her punctured tyre fixed) and will connect from home | 17:21 |
| *** electrofelix has quit IRC | 17:21 | |
| waynr | i'm finding it pretty difficult to focus on JJB stuff today also | 17:21 |
| *** baoli has joined #openstack-sprint | 17:50 | |
| *** electrofelix has joined #openstack-sprint | 18:52 | |
| electrofelix | waynr: bit delayed getting back on | 18:52 |
| electrofelix | I see one of the changes caused some problems for someone unfortunately | 18:52 |
| waynr | yeah i workflow+1'd the revert and added a note that when we re-revert the change later we need to add a regression test | 18:53 |
| waynr | (added that note to the wiki that is) | 18:53 |
| electrofelix | ok, well I guess that this will probably cause https://review.openstack.org/#/c/319617 to refuse to merge, so we'll need to rebase the series after applying the corrected change | 18:58 |
| electrofelix | so probably that means a hold off on approving any more patches till Mon/Tue | 18:58 |
| electrofelix | hopefully most of the others won't conflict so it won't be too difficult to resync the series | 18:59 |
| electrofelix | waynr: shame this caught us out, hopefully I'll have more time the next scheduled sync up so won't be quite so in/out of contact | 19:01 |
| electrofelix | since I'm out Monday, I can take a look at redoing that patch on Tuesday unless you get to it before then | 19:02 |
| electrofelix | and we can then see about continuing to land the remaining patches, I suspect that's the only one that will trip us up (at least I hope so). | 19:03 |
| electrofelix | waynr zxiiro: chat to you on Tuesday, hopefully that revert will merge soon | 19:04 |
| zxiiro | electrofelix: have a good weekend! I'm catching up on all the stuff that when by while i was out for lunch | 19:04 |
| *** electrofelix has quit IRC | 19:04 | |
| *** baoli has quit IRC | 19:07 | |
| zxiiro | waynr: looks like everything has +2s now looks like we got through everything except that one with the delete bug | 19:25 |
| waynr | cool thanks for reviewing zxiiro | 19:27 |
| *** baoli has joined #openstack-sprint | 19:42 | |
| *** baoli has quit IRC | 20:23 | |
| *** kien-ha has quit IRC | 20:44 | |
| *** rfolco_ has joined #openstack-sprint | 21:21 | |
| *** rfolco_ has quit IRC | 21:21 | |
| *** rfolco_ has joined #openstack-sprint | 21:21 | |
| *** rfolco_ has quit IRC | 21:21 | |
| *** mmedvede has left #openstack-sprint | 22:04 | |
| *** mmedvede has joined #openstack-sprint | 22:05 | |
| *** larainema has quit IRC | 22:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!