| *** salmon_ has quit IRC | 01:22 | |
| *** openstackgerrit has quit IRC | 01:47 | |
| *** openstackgerrit has joined #openstack-solar | 01:48 | |
| *** ogelbukh has quit IRC | 03:26 | |
| *** ogelbukh has joined #openstack-solar | 05:27 | |
| *** dshulyak has joined #openstack-solar | 06:42 | |
| openstackgerrit | Dmitry Shulyak proposed openstack/solar: Insert missing events during build of staged graph https://review.openstack.org/286665 | 07:47 |
|---|---|---|
| *** salmon_ has joined #openstack-solar | 08:31 | |
| salmon_ | dshulyak: hi, we need to regenerate resources. This file moved from astute dir to roles https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/roles/enable_cinder.pp | 08:42 |
| salmon_ | dshulyak: and maybe it would be better to generete it on the iso and not store in repo? | 08:43 |
| dshulyak | salmon_: hi, i can remove it from repo, i guess you can use f2s t2r to generate it even now | 08:44 |
| salmon_ | dshulyak: yeah I can, but I wanted to know your opinion :) | 08:45 |
| dshulyak | salmon_: so was your deployment successful ? | 08:54 |
| salmon_ | dshulyak: controller+compute+cinder, I had to update action path in db for this one resource, and I still have problem with permissions for /var/lib/glance/node. I fixed this two problems manually and it succeed :) | 08:56 |
| dshulyak | salmon_: graph is connected? | 08:57 |
| salmon_ | it seems so | 08:57 |
| salmon_ | dshulyak: I tested it with your patch | 08:57 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Solar orch report doesn't fail for empty graph https://review.openstack.org/286571 | 09:09 |
| pigmej | hey guys, what's up ? | 09:19 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Add /etc/solar/config.yaml as first file in config https://review.openstack.org/287680 | 09:50 |
| *** openstackgerrit_ has joined #openstack-solar | 09:53 | |
| salmon_ | +3 :) | 09:54 |
| pigmej | :) | 09:56 |
| pigmej | I'm reviewing stuff that we need for packages so... ;) | 09:56 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Solar orch report doesn't fail for empty graph https://review.openstack.org/286571 | 09:58 |
| *** openstackgerrit_ has quit IRC | 10:02 | |
| openstackgerrit | Merged openstack/solar: Solar orch report doesn't fail for empty graph https://review.openstack.org/286571 | 10:09 |
| openstackgerrit | Merged openstack/solar: Insert missing events during build of staged graph https://review.openstack.org/286665 | 10:32 |
| pigmej | dshulyak: https://review.openstack.org/#/c/287680/ take look at this very complex PR :) | 10:39 |
| pigmej | thx ;) | 10:45 |
| openstackgerrit | Merged openstack/solar: Add /etc/solar/config.yaml as first file in config https://review.openstack.org/287680 | 10:48 |
| dshulyak | salmon_: btw i think i will drop vrs directory | 10:57 |
| salmon_ | dshulyak: +1 | 10:57 |
| pigmej | especially that it should say crs :P | 10:57 |
| pigmej | dshulyak: when we can merge: https://review.openstack.org/#/c/285336/ ? | 11:17 |
| dshulyak | pigmej: actually there was ‘8.0’ for all resources, i think we had some misunderstanding when u asked this | 11:18 |
| dshulyak | i made it ‘8.0.0’, but thats another story | 11:19 |
| openstackgerrit | Aleksey Zvyagintsev proposed openstack/solar: Add default solar.yaml config https://review.openstack.org/287723 | 11:20 |
| pigmej | dshulyak: you mean? | 11:22 |
| pigmej | 8.0.0 will be ok | 11:23 |
| dshulyak | it was 8.0 already | 11:23 |
| dshulyak | as a string | 11:23 |
| azvyagintsev | dshulyak: you drop recources and vrs, but forgot to drop them from spec https://github.com/Mirantis/f2s/blob/master/spec/f2s.spec#L42-L43 | 11:56 |
| azvyagintsev | rpm build will fail | 11:56 |
| azvyagintsev | will you fix it? or should i ? | 11:56 |
| dshulyak | azvyagintsev: i will fix | 11:57 |
| dshulyak | azvyagintsev: thanks | 11:57 |
| azvyagintsev | thx | 11:57 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added systemd solar-worker.service https://review.openstack.org/287744 | 11:59 |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** openstackgerrit has joined #openstack-solar | 12:03 | |
| openstackgerrit | Merged openstack/solar-resources: Add spec for rpmbuild solar-resources.spec https://review.openstack.org/287256 | 12:04 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Remove repository if adding contents raised error https://review.openstack.org/287748 | 12:06 |
| mkwiek | pigmej: can you check out if above commit is a proper implementation for the issue with creating repositories? | 12:07 |
| pigmej | mkwiek: no | 12:09 |
| pigmej | that was not the idea | 12:09 |
| pigmej | you should operate on tmp stuff | 12:09 |
| pigmej | and then do atomic operation that will bring it back | 12:09 |
| pigmej | you have no guarantee that rmtree will succeed | 12:09 |
| pigmej | you should add repo to temp directory which will be ignored by repository module, and then at the end rename it | 12:10 |
| pigmej | :) | 12:11 |
| pigmej | I mean that rm could say but it could clean only these 'temp' | 12:11 |
| mkwiek | I see, I thought that tmp won't be necessary, because if rmtree on the directory that we created a moment ago failed, we have bigger problems than broken repo, but I guess it will add another layer of security there | 12:14 |
| mkwiek | I will add this stuff, thanks! | 12:14 |
| pigmej | well, you could crtl+C | 12:15 |
| pigmej | or just process died | 12:15 |
| pigmej | also bp is named "atomic" | 12:16 |
| dshulyak | pigmej: do you know if we have simple api to check if resource exists? | 12:31 |
| dshulyak | i mean without DBLayerNoFound | 12:31 |
| pigmej | well, why do you want to do such check ? | 12:33 |
| openstackgerrit | Aleksey Zvyagintsev proposed openstack/solar: Add default solar.yaml config https://review.openstack.org/287723 | 12:34 |
| dshulyak | pigmej: to create resource if it doesnt exist | 12:35 |
| dshulyak | otherwise update it | 12:35 |
| pigmej | race conditions everywhere then... | 12:35 |
| dshulyak | thats one of the most basic operations... | 12:36 |
| dshulyak | why do i, as a user, care about those conditons | 12:36 |
| dshulyak | also i am working with single process | 12:36 |
| pigmej | I know | 12:36 |
| pigmej | just wanted to mention it | 12:36 |
| dshulyak | ok, we dont have :) | 12:36 |
| pigmej | yup we don't have any "exists" just because it's "unsafe" | 12:37 |
| dshulyak | it basically means that i will have this in client applications | 12:37 |
| pigmej | hmm but also we have some | 12:37 |
| pigmej | get_or_create | 12:37 |
| pigmej | Model.get_or_create which is thing that you added | 12:38 |
| pigmej | well, you should avoid if exists: update else create() you could assume always "update" | 12:38 |
| pigmej | adding any if exists: update else create() is huge place for race conditions and is usually dangerous in any concurrent / distributed env | 12:39 |
| dshulyak | salmon_: why do u need id of env in fuel_data ? | 12:53 |
| salmon_ | dshulyak: just in case :) If we add manager there we wiill need it | 12:57 |
| pigmej | guys what about this: https://review.openstack.org/#/c/287394/ ? have you time to chcek it ? | 12:59 |
| pigmej | https://review.openstack.org/#/c/287390/ this one :D | 12:59 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Support permissions, owner and group in naive_sync https://review.openstack.org/287390 | 13:36 |
| pigmej | mkwiek: ^ | 13:37 |
| dshulyak | salmon_: take a look please https://github.com/Mirantis/f2s/pull/20, if it makes sense i will update README | 14:00 |
| dshulyak | azvyagintsev: pleae take a look if i fixed spec correctly - https://github.com/Mirantis/f2s/pull/21/ | 14:05 |
| salmon_ | dshulyak: hiera patches may be useful later | 14:05 |
| dshulyak | salmon_: we can restore them from history, but also i am not sure that it is viable approach to run tests on master node to generate those inputs | 14:06 |
| salmon_ | dshulyak: I see, ok | 14:07 |
| dshulyak | first of all fixtures are not even in library package | 14:07 |
| dshulyak | pigmej: to merge sources patch - we need to adjust fsclient first | 14:13 |
| dshulyak | i will do it later | 14:13 |
| salmon_ | dshulyak: I like it https://github.com/Mirantis/f2s/pull/20 | 14:14 |
| salmon_ | non fatal error https://bpaste.net/show/2562cdfb990d | 14:18 |
| pigmej | dshulyak: k | 14:18 |
| pigmej | guys: "- wrap solar states (error or sucess) so they can be used in Nailgun in context of nodes" what about that ? | 14:21 |
| salmon_ | not even started | 14:25 |
| pigmej | guys, can you craete bugs/issues whatever with todo items that exists for experimental f2s "fully" integrated ? | 14:26 |
| pigmej | by "fully" I mean minimal set of functions that enables it. | 14:26 |
| pigmej | or update https://etherpad.openstack.org/p/solar-fuel-integration-9.0 | 14:27 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Remove repository if adding contents raised error https://review.openstack.org/287748 | 14:32 |
| pigmej | shit I started to write test suite for handlers/transports and well.... | 14:57 |
| azvyagintsev | dshulyak: please get back "space" from line 51 https://github.com/dshulyak/f2s/commit/485602aae0a858b08dba7dfed75cdfee357eb76c#diff-57da169f716e33d76b2d10b0a84c3c98L51 | 15:07 |
| azvyagintsev | some builder will fail w\o it.. | 15:08 |
| dshulyak | i am not responsible for this, it was my editor decision | 15:08 |
| pigmej | :D | 15:09 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Remove repository if adding contents raised error https://review.openstack.org/287748 | 15:21 |
| *** angdraug has joined #openstack-solar | 15:31 | |
| dshulyak | salmon_: i also added a fix to 20 pull request - in some cases it was possible that dependencies between nodes were absent | 15:38 |
| salmon_ | dshulyak: is it ready to be merged? | 15:41 |
| dshulyak | salmon_: yes, everything looks good | 15:46 |
| dshulyak | solar-worker consumes too much - 31956 root 20 0 734292 89056 11032 R 94.0 5.8 0:12.47 solar-worker | 15:48 |
| dshulyak | cpu | 15:48 |
| salmon_ | maybe because of pigmej's locks implementation :) | 15:50 |
| pigmej | :| | 15:50 |
| pigmej | no it should be not | 15:50 |
| dshulyak | azvyagintsev: are u around? confirm please that it is ok https://github.com/Mirantis/f2s/pull/21 | 15:51 |
| pigmej | OR if you deploy the same stuff all over again | 15:51 |
| pigmej | then it may be possible | 15:51 |
| dshulyak | it mights be database, i know that it is not used there in optimal way | 15:51 |
| pigmej | because locks are never cleared, so full locking history is preserved | 15:51 |
| dshulyak | nah, it is first run | 15:51 |
| pigmej | :| | 15:51 |
| pigmej | weird | 15:51 |
| pigmej | what db backend ? | 15:52 |
| pigmej | sqlite ? | 15:52 |
| azvyagintsev | <azvyagintsev> dshulyak: please get back "space" from line 51 https://github.com/dshulyak/f2s/commit/485602aae0a858b08dba7dfed75cdfee357eb76c#diff-57da169f716e33d76b2d10b0a84c3c98L51 | 15:52 |
| azvyagintsev | already :) | 15:52 |
| azvyagintsev | all ok, just move back "space" | 15:52 |
| dshulyak | yes, i added it back | 15:53 |
| dshulyak | pigmej: yes, i am using sqlite, but the problem is that i am fetching all tasks every time, we can avoid that | 15:54 |
| dshulyak | we need current + childs + parents of those childs | 15:54 |
| pigmej | yaeh for big graph that may be the case | 15:54 |
| pigmej | we already discussed it I think | 15:55 |
| dshulyak | yep | 15:55 |
| pigmej | or we could use cache in better way | 15:55 |
| dshulyak | it is not big though… maybe ~150 items | 15:55 |
| pigmej | depends how many times we're fething it ;D | 15:56 |
| pigmej | I can play with it tomorrow | 15:57 |
| pigmej | :) | 15:57 |
| pigmej | I like profilling if so :D | 15:57 |
| dshulyak | atleast 150 + 1 | 15:57 |
| dshulyak | actually exectly 150 + 1 | 15:58 |
| pigmej | so 150 * 150 ? | 15:58 |
| pigmej | + inputs ? | 15:58 |
| dshulyak | which inputs? | 15:58 |
| pigmej | ah no | 15:58 |
| pigmej | it's graph :) | 15:58 |
| pigmej | I will create big enough graph with noops | 15:58 |
| pigmej | but I have interview right now ;/ | 15:58 |
| pigmej | and we have weekly in 2 minutes... | 15:58 |
| dshulyak | salmon_: so whats your testing results? any success with /var/lib/glance ? | 16:01 |
| salmon_ | dshulyak: still debuging, I also added ceilometer and it also fails :( | 16:03 |
| dshulyak | looks like we will need to get bogdando tomorrow | 16:03 |
| salmon_ | yup | 16:03 |
| *** dshulyak has left #openstack-solar | 19:01 | |
| *** angdraug has quit IRC | 19:57 | |
| *** angdraug has joined #openstack-solar | 21:21 | |
| *** dshulyak has joined #openstack-solar | 21:52 | |
| *** dshulyak has quit IRC | 22:06 | |
| *** salmon_ has quit IRC | 22:45 | |
| *** salmon_ has joined #openstack-solar | 23:05 | |
| *** salmon_ has quit IRC | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!