| *** salmon_ has joined #openstack-solar | 08:39 | |
| *** dshulyak_ has joined #openstack-solar | 08:41 | |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixing concurrency problems in history counter https://review.openstack.org/269238 | 09:04 |
|---|---|---|
| pigmej | hmm, I think we should have possibility to "inherit" from other resources | 09:06 |
| pigmej | imagine I want to alter riak_node.run action, let's say i want to turn some bucket types by default (or whatever), for now I would need to change whole riak_node or write my own. | 09:06 |
| pigmej | while for example in Dockerfiles you can "inherit" from other images, and just change/add what you need. | 09:07 |
| pigmej | dshulyak_: salmon_ what do you think ? | 09:07 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixing concurrency problems in history counter https://review.openstack.org/269238 | 09:11 |
| dshulyak_ | probably we will need some instruction to execute tasks right after riak_run, and before all other successors of riak run, but im not sure about dockerfile inherit | 09:17 |
| pigmej | dshulyak_: I meant, let's say you have some complicated resource, and you want to alter it a bit | 09:18 |
| pigmej | currently you will need to create new resource or copy&paste from original | 09:18 |
| dshulyak_ | what kind of modifications? if such things as you said, e.g create/change bucket type, you just need some tasks that will run right after parent and before all dependencies | 09:22 |
| pigmej | dshulyak_ yeah but that was just an example | 09:25 |
| pigmej | maybe not perfect though because btype requires healhy cluster | 09:25 |
| dshulyak_ | we want to release tomorrow of by the end of the week? | 09:29 |
| dshulyak_ | s/of/or | 09:29 |
| salmon_ | pigmej: you can use Composer file for it, but yes in feature some kind of inheritance may be useful | 09:33 |
| pigmej | dshulyak_: i would bet "never release on friday", so let's make a release on friday ?:D | 09:34 |
| openstackgerrit | Merged openstack/solar: Remove ansible.cfg, we use .ssh/config now https://review.openstack.org/269035 | 10:25 |
| bogdando | salmon_, what is docs-on-rtfd ? https://review.openstack.org/#/c/267558 | 10:35 |
| bogdando | can you give me RTFM link?) | 10:35 |
| salmon_ | bogdando: http://solar.readthedocs.org/en/latest/ | 10:35 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixing concurrency problems in history counter https://review.openstack.org/269238 | 10:36 |
| pigmej | ^ rebased | 10:36 |
| openstackgerrit | Merged openstack/solar: Hardcode ansible version. We are not ready for 2.0 https://review.openstack.org/269239 | 10:53 |
| openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Add tox checkniceness,checksyntax for docs https://review.openstack.org/269559 | 11:14 |
| bogdando | salmon_, ^^ | 11:15 |
| pigmej | bogdando: I added a comment just now | 11:16 |
| bogdando | for some strange reason we have this https://review.openstack.org/#/c/269559/1/ChangeLog is a bonus as well :-o | 11:16 |
| pigmej | I don't think that it's bonus | 11:17 |
| bogdando | and this https://review.openstack.org/#/c/269559/1/AUTHORS | 11:17 |
| bogdando | I think it is cool | 11:17 |
| bogdando | but I can disable this if you help me how :) | 11:17 |
| pigmej | bogdando: it's full of mess | 11:18 |
| pigmej | same as automated generated changelog | 11:18 |
| salmon_ | bogdando: changelog is generated by pbr, we don't need it in repo | 11:18 |
| salmon_ | it should go to .gitignore | 11:18 |
| bogdando | ok | 11:19 |
| bogdando | authors to keep maybe?.. | 11:20 |
| bogdando | easy to add ppl to review | 11:20 |
| pigmej | bogdando: ? | 11:20 |
| bogdando | pigmej, what? | 11:21 |
| bogdando | Let's keep authors to be genereted, thoughts? | 11:21 |
| pigmej | I dislike these "autogenerated authors" usually | 11:23 |
| openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Add tox checkniceness,checksyntax for docs https://review.openstack.org/269559 | 11:23 |
| pigmej | I also dislike "doc" requirements in test-requirements | 11:26 |
| openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Add tox checkniceness,checksyntax for docs https://review.openstack.org/269559 | 11:28 |
| bogdando | pigmej, ok, I removed both | 11:28 |
| salmon_ | We may add MAINTAINERS later | 11:28 |
| pigmej | bogdando: but I don't see these changes | 11:29 |
| salmon_ | afk, ~1h | 11:30 |
| bogdando | pigmej, the patchset 3 | 11:30 |
| bogdando | I can see changes | 11:30 |
| pigmej | https://review.openstack.org/#/c/269559/3/test-requirements.txt ? | 11:30 |
| pigmej | ah you removed files | 11:30 |
| pigmej | https://review.openstack.org/#/c/269559/1/test-requirements.txt@19 I added this comment in meantime :) | 11:31 |
| *** salmon_ has quit IRC | 11:34 | |
| bogdando | pigmej, where are those tox env dependencies? | 11:35 |
| bogdando | I'd like the docs check to be run at CI gates by default | 11:35 |
| bogdando | there would If I run just tox | 11:36 |
| pigmej | https://github.com/openstack/solar/blob/master/tox.ini#L29 | 11:36 |
| pigmej | https://github.com/openstack/solar/blob/master/tox.ini#L15 | 11:36 |
| pigmej | etc | 11:36 |
| openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Add tox checkniceness,checksyntax for docs https://review.openstack.org/269559 | 11:38 |
| bogdando | done | 11:38 |
| pigmej | bogdando: hmm | 11:39 |
| pigmej | I'm not sure if these deps are correctly placed | 11:40 |
| pigmej | also what's "doc" dependency ? | 11:40 |
| pigmej | ah nvm !! | 11:40 |
| pigmej | bogdando: the drawback of that approach that you have, is that we will need to install solar deps 4 times, instead of 2 | 11:50 |
| pigmej | which takes obviously double time | 11:50 |
| pigmej | just for checking if docs are "cool" | 11:50 |
| *** salmon_ has joined #openstack-solar | 12:19 | |
| bogdando | pigmej, any idea how to fix this? | 13:09 |
| bogdando | pigmej, master branch - tox 40.20s user 2.87s system 301% cpu 14.290 total | 13:10 |
| bogdando | the docs - 56.03s user 5.36s system 187% cpu 32.777 total | 13:10 |
| pigmej | bogdando: we should probably include these commands in docs step BUT I'm not sure | 13:11 |
| pigmej | in all other cases we will make 4 tox envs, with a lot of dependencies. | 13:12 |
| pigmej | also for docs you probably don't need all our dependencies, isn't it ? | 13:12 |
| pigmej | you probably just need few of them ? Like in our 'docs' env, where we only require | 13:13 |
| openstackgerrit | Dmitry Shulyak proposed openstack/solar: Zerorpc worker for orchestration modules https://review.openstack.org/269166 | 13:13 |
| pigmej | also I'm kinda sure that adding these to env isn't enough if you want to check them automaticaly on openstack-infra | 13:13 |
| pigmej | because afair commands are predefined and they are `tox -epy27` tox -edocs` | 13:14 |
| pigmej | but salmon_ can say more about that | 13:14 |
| salmon_ | docs are build by jenkins with something like this: tox -e testenv python setup.py build_sphinx | 13:20 |
| salmon_ | I don't see a way to run this checks automaticly | 13:23 |
| dshulyak_ | please review https://review.openstack.org/269166, to test - you can run solar-worker in foreground | 13:30 |
| pigmej | dshulyak_: with pleasure but I need to fix mess that we did in transports :P | 13:31 |
| dshulyak_ | i will do concurrency patches in 30 mins | 13:32 |
| dshulyak_ | what mess? | 13:32 |
| dshulyak_ | errors? | 13:32 |
| pigmej | not only | 13:32 |
| pigmej | right now each transport returns different stuff | 13:32 |
| pigmej | you removed fabric partially, I had partially working wrapper for fabric, | 13:32 |
| pigmej | so let's say that we have 3 different return values from transports :D | 13:32 |
| pigmej | with 3 different API ;D | 13:33 |
| pigmej | so I'm improving that situation, after that errros :) | 13:34 |
| pigmej | we broke it over time, or improve because it depends from which side will we look ;D | 13:38 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Unify returned transport results https://review.openstack.org/269653 | 13:59 |
| pigmej | it's WIP still | 13:59 |
| pigmej | hmm dshulyak_ so you started that "errors" in fact some time ago (when you removed fabric) | 14:26 |
| dshulyak_ | what do you mean? some time ago i added unified handling of erros for puppet/ansible/bash | 14:27 |
| dshulyak_ | when i partially removed fabric | 14:27 |
| pigmej | ah ok | 14:28 |
| pigmej | I wondered when this happened ;D | 14:28 |
| pigmej | ok, then I know wtf ;) | 14:29 |
| openstackgerrit | Lukasz Oles proposed openstack/solar: Update Wordpress tutorial https://review.openstack.org/269673 | 14:29 |
| pigmej | dshulyak_: hmm, how did you get that 'exists' error? | 14:39 |
| dshulyak_ | i used - next(solar_models.NegativeCounter.get_or_create(str(i))) | 14:41 |
| pigmej | hmm, | 14:41 |
| pigmej | it seems that I did something wrong during rebase :D | 14:43 |
| dshulyak_ | i cant find exists property on Counter - https://github.com/basho/riak-python-client/blob/master/riak/datatypes/counter.py | 14:43 |
| pigmej | because it's not | 14:44 |
| dshulyak_ | it shouldnt be Counter? | 14:44 |
| pigmej | trying to see wtf | 14:44 |
| pigmej | it shouldn't be get_or_create that's for sure | 14:45 |
| dshulyak_ | get_or_create was used in LogItem | 14:47 |
| pigmej | yaeh yeah, I see, I wonder what's going on currently :) | 14:48 |
| pigmej | Maybe I patched riak client for a while and I forgot about it... | 14:48 |
| pigmej | hmm, something is definitely wrong with this counter patch, I will fix it dshulyak_ now | 14:50 |
| dshulyak_ | when this is possible if siblings[0]._get_encoded_data() == siblings[1]._get_encoded_data(): | 14:50 |
| pigmej | it's in conflict resolution right? | 14:51 |
| dshulyak_ | yes | 14:52 |
| pigmej | yeah it's there, so there are at least one place where we can have this situation, one is counter on that branch | 14:53 |
| pigmej | also I had some problems with system log updates afair, so I added this there, "just in case", because I thought that 2 the same => ok | 14:53 |
| pigmej | and when I was experimenting with some reducing load in CRDT values, there was a chance that you had 2 the same childs, then I craeted separate resolver for it completely | 14:54 |
| pigmej | brb dinner arriwed | 14:59 |
| pigmej | arrived | 14:59 |
| dshulyak_ | i will need to spend more time on crdtish locking, it is not very clear why it became so complex :) | 15:01 |
| dshulyak_ | afk for 1-1.3h | 15:01 |
| *** dshulyak_ has quit IRC | 15:02 | |
| *** dshulyak_ has joined #openstack-solar | 15:06 | |
| pigmej | dshulyak_: we can switch later to riak native locking | 15:10 |
| pigmej | riak native crdt but we will need it for sqlite too | 15:10 |
| pigmej | in fact it's simple, it's just of operations :) | 15:11 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixing concurrency problems in history counter https://review.openstack.org/269238 | 15:19 |
| pigmej | dshulyak_: adjusted :) | 15:19 |
| pigmej | sorry :( | 15:19 |
| pigmej | "something went wrong" :P | 15:19 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Unify returned transport results https://review.openstack.org/269653 | 15:56 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Unify returned transport results https://review.openstack.org/269653 | 16:15 |
| pigmej | ok, unify seems to be ok, it's required step for https://bugs.launchpad.net/solar/+bug/1532872 | 16:16 |
| openstack | Launchpad bug 1532872 in Solar "Handle errors from transports" [Undecided,In progress] - Assigned to Jedrzej Nowak (jnowak) | 16:16 |
| pigmej | salmon_: hmm, so we have some bot there... | 16:16 |
| salmon_ | :D | 16:18 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixing concurrency problems in history counter https://review.openstack.org/269238 | 17:16 |
| pigmej | salmon_: I hate git rebase.... | 17:16 |
| salmon_ | Yeah, me too :) | 17:17 |
| pigmej | I don't remember that I had conflict on solar.yaml... but it show up after rebase.... | 17:17 |
| pigmej | weird :) | 17:18 |
| *** dshulyak_ has quit IRC | 19:46 | |
| *** salmon_ has quit IRC | 22:42 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!