Saturday, 2017-07-08

morganmordred: ^ wtf...00:05
morganmordred: that patch missed on a test that I couldn't repro locally00:06
morgan*blink* wut00:06
morganhttp://logs.openstack.org/82/478582/3/check/gate-shade-python35/a85aa0c/console.html#_2017-07-07_22_38_38_19042900:06
morganugh... this is non-deterministiv00:18
morganaha00:21
morganfound it00:21
morgancreate_endpoint is busted00:21
mordredmorgan: uhm. ...00:28
morganwe are creating things based upon an order of the items in a dict00:28
morganand we cannot reliably test that00:28
morgansince seed will change that order00:29
morganit is non-deterministic in the order we create 2-on-3 for endpoints, it could be public, admin, internal, or internal,public,admin or....00:29
morganso trying to make sure we do a fixed ordering00:29
morganhttps://www.irccloud.com/pastebin/SrGtNsfb/00:30
morgan^ that is the code that is causing the issue with the test00:31
openstackgerritMorgan Fainberg proposed openstack-infra/shade master: Make sure we pass propert dicts to validate  https://review.openstack.org/47858200:34
morgan^ there. fixed00:34
mordredmorgan: ahhhhhhhh00:37
mordredmorgan: yes- that change makes total sense00:37
mordredwow. well done00:37
*** slaweq has joined #openstack-shade00:50
*** slaweq has quit IRC00:56
openstackgerritMorgan Fainberg proposed openstack-infra/shade master: Make sure we don't fail open on bad input to validate  https://review.openstack.org/47858901:13
morgan^simple rebase01:13
openstackgerritMorgan Fainberg proposed openstack-infra/shade master: Make sure we don't fail open on bad input to validate  https://review.openstack.org/47858901:37
morganmordred: ^ missed one01:38
morganfixed there01:38
openstackgerritMerged openstack-infra/shade master: Make sure we pass propert dicts to validate  https://review.openstack.org/47858202:01
*** slaweq has joined #openstack-shade02:52
*** slaweq has quit IRC02:57
*** gouthamr has quit IRC03:13
*** gouthamr has joined #openstack-shade03:14
*** gouthamr has quit IRC04:38
*** slaweq has joined #openstack-shade04:50
*** slaweq has quit IRC04:54
*** slaweq_ has joined #openstack-shade04:54
*** slaweq_ has quit IRC05:00
*** slaweq has joined #openstack-shade07:58
*** slaweq has quit IRC08:03
*** slaweq has joined #openstack-shade08:54
*** slaweq has quit IRC09:53
*** slaweq has joined #openstack-shade09:53
*** slaweq_ has joined #openstack-shade09:55
*** slaweq has quit IRC09:55
*** ioggstream has joined #openstack-shade10:12
*** ioggstream has quit IRC10:53
*** slaweq_ has quit IRC11:18
*** slaweq has joined #openstack-shade11:19
*** slaweq has quit IRC11:23
*** slaweq has joined #openstack-shade11:45
openstackgerritMerged openstack-infra/shade master: Make sure we don't fail open on bad input to validate  https://review.openstack.org/47858911:55
*** slaweq has quit IRC12:01
*** slaweq has joined #openstack-shade12:01
*** slaweq has quit IRC12:06
*** ioggstream has joined #openstack-shade12:24
*** slaweq has joined #openstack-shade13:16
mordredmorgan: ^^ woot!13:17
*** slaweq has quit IRC13:30
*** ioggstream has quit IRC15:30
*** openstackgerrit has quit IRC16:17
*** yfried has joined #openstack-shade19:28
*** slaweq has joined #openstack-shade19:43
*** slaweq has quit IRC19:56
*** gouthamr has joined #openstack-shade21:19
*** slaweq has joined #openstack-shade21:27
*** gouthamr has quit IRC21:32
*** gouthamr has joined #openstack-shade21:33
*** slaweq has quit IRC21:43
*** slaweq has joined #openstack-shade21:44
*** slaweq has quit IRC21:48
*** gouthamr has quit IRC22:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!