| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Project Update https://review.openstack.org/473629 | 00:03 |
|---|---|---|
| *** yolanda has quit IRC | 00:14 | |
| *** yolanda has joined #openstack-shade | 00:37 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Project Delete https://review.openstack.org/473628 | 01:23 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Project Create https://review.openstack.org/473609 | 01:24 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Project Update https://review.openstack.org/473629 | 01:24 |
| *** yolanda has quit IRC | 01:37 | |
| *** gouthamr has quit IRC | 01:42 | |
| *** dfflanders has joined #openstack-shade | 01:47 | |
| *** gouthamr has joined #openstack-shade | 02:52 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: RESTify create_server https://review.openstack.org/473555 | 03:06 |
| openstackgerrit | Merged openstack-infra/shade master: Improve grant docs on when and how use domain arg https://review.openstack.org/473589 | 03:50 |
| openstackgerrit | Merged openstack-infra/shade master: Don't remove top-container for stack and zone REST API calls https://review.openstack.org/473517 | 03:53 |
| *** htaccess has joined #openstack-shade | 04:00 | |
| htaccess | hello, commit ba0e9451e664743dbc5d24307ca5a3829ee3e91b released in shade==1.21.0 breaks ansible instance creation using os_server on our cloud | 04:03 |
| htaccess | https://paste.fedoraproject.org/paste/GadXSOVxLBY2xBp4Gu6bkA | 04:05 |
| htaccess | expecting ports to have a created_at key seems reasonable but for whatever reason ours don't | 04:06 |
| *** gkadam has joined #openstack-shade | 04:06 | |
| htaccess | where is the right place to file a bug report? | 04:07 |
| htaccess | https://github.com/openstack-infra/shade does not seem to have issues enabled | 04:10 |
| htaccess | it would be nice to point the github readme at the openstack gerrit as github is higher in google search | 04:12 |
| htaccess | only breaks instances that need a floating ip | 04:15 |
| *** slaweq has joined #openstack-shade | 05:08 | |
| *** slaweq has quit IRC | 05:08 | |
| *** gouthamr has quit IRC | 05:23 | |
| *** slaweq has joined #openstack-shade | 05:36 | |
| *** slaweq has quit IRC | 05:41 | |
| *** yolanda has joined #openstack-shade | 05:54 | |
| *** ioggstream has joined #openstack-shade | 06:05 | |
| *** slaweq has joined #openstack-shade | 06:37 | |
| *** slaweq has quit IRC | 06:42 | |
| *** yolanda has quit IRC | 07:28 | |
| *** gkadam is now known as gkadam-afk | 07:51 | |
| *** gkadam-afk is now known as gkadam | 08:53 | |
| *** yfried has joined #openstack-shade | 09:02 | |
| *** yfried has quit IRC | 09:05 | |
| *** dfflanders has quit IRC | 09:16 | |
| *** cdent has joined #openstack-shade | 09:59 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Don't remove top-container element for sec group REST API calls https://review.openstack.org/473770 | 10:04 |
| frickler | htaccess: https://storyboard.openstack.org/#!/project/760 | 10:05 |
| *** slaweq has joined #openstack-shade | 10:43 | |
| *** slaweq has quit IRC | 10:48 | |
| *** cdent has quit IRC | 10:51 | |
| *** nokes has joined #openstack-shade | 11:03 | |
| *** noshankus has quit IRC | 11:04 | |
| *** nokes is now known as noshankus | 11:04 | |
| *** noshankus has quit IRC | 11:14 | |
| Shrews | htaccess: looks like that's fixed in the latest version of shade | 11:28 |
| Shrews | but not yet released | 11:29 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Enforce API version in functional tests https://review.openstack.org/473795 | 11:32 |
| samueldmq | morning shade | 11:32 |
| *** cdent has joined #openstack-shade | 11:38 | |
| mordred | htaccess: yah - as Shrews says, it's fixed in master. we'll try to get a release cut today | 11:44 |
| mordred | Shrews, samueldmq: morning! | 11:44 |
| *** slaweq has joined #openstack-shade | 11:44 | |
| mordred | Shrews: the stack at https://review.openstack.org/#/c/473555/ passes tests now if you have a sec to look at it (create_server is kinda heavily used, so eyes on it would be nice) | 11:45 |
| Shrews | mordred: sure, after i breakfast | 11:45 |
| *** slaweq has quit IRC | 11:49 | |
| *** openstackgerrit has quit IRC | 12:18 | |
| *** cdent has quit IRC | 12:22 | |
| *** olaph has quit IRC | 12:27 | |
| *** cdent has joined #openstack-shade | 12:34 | |
| rods | mordred is this safe `'delete_on_termination': True`? I'm wondering if would be safer to explicitly let the user delete the volume | 12:36 |
| *** slaweq has joined #openstack-shade | 12:45 | |
| mordred | rods: it's a nova feature | 12:46 |
| mordred | rods: when you create a server using boot-from-volume, you can tell it to delete the volume when you delete the server - this is helpful if you're using bfv but you're doing it with a normal image workflow | 12:47 |
| mordred | so - "boot me a server from the ubuntu-xenial image but make me a volume out of the image first and boot using that" | 12:47 |
| *** slaweq has quit IRC | 12:50 | |
| rods | mordred ya, I know the feature, my concern is that in our case is not an option, is just set to True. Worried someone could have a bad surprise | 12:52 |
| mordred | OH! that | 12:54 |
| Shrews | mordred: default for delete_on_termination seems to be False | 12:54 |
| Shrews | fwiw | 12:54 |
| mordred | sorry - this is a whole different thing | 12:54 |
| mordred | so when you boot from an _IMAGE_ normally but attach a volume at boot time, nova requires you to pass an entry into the block_device_mapping for the image | 12:55 |
| mordred | it's not actually a volume | 12:55 |
| mordred | u'destination_type': u'local', is the key | 12:55 |
| mordred | novaclient does this behind the scenes for the user, so the REST translation is the first I learned of it :) | 12:56 |
| mordred | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L737-L745 | 12:57 |
| rods | mordred oh I see, thx | 12:58 |
| Shrews | mordred: ugh, i forgot how much i hate these api docs | 12:59 |
| *** slaweq has joined #openstack-shade | 13:01 | |
| mordred | I also learned that apparently one is supposed to POST to /os-volumes_boot instead of /servers | 13:02 |
| mordred | even though that's not in the API docs | 13:02 |
| mordred | in fact, I should file a bug on that | 13:02 |
| *** slaweq has quit IRC | 13:06 | |
| Shrews | mordred: where is the server normalization happening now? | 13:07 |
| mordred | Shrews: in _list_servers | 13:09 |
| Shrews | mordred: but create_server() also returns a server | 13:10 |
| Shrews | dict | 13:10 |
| mordred | Shrews: yes - but it calls get_server_by_id first which also does the normalization | 13:10 |
| Shrews | ah, ok | 13:11 |
| Shrews | mordred: didn't test it, but no glaring problems jump out | 13:12 |
| mordred | Shrews: woot! thanks | 13:12 |
| Shrews | and i'm not about to validate all of the rest api stuff :) | 13:12 |
| Shrews | but it looks reasonable | 13:13 |
| mordred | Shrews: that's what the tests are for | 13:13 |
| Shrews | yup | 13:13 |
| mordred | Shrews: fwiw, the functional tests do a very good job for us here | 13:13 |
| Shrews | yup | 13:13 |
| *** openstackgerrit has joined #openstack-shade | 13:20 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert get_server_by_id https://review.openstack.org/473838 | 13:20 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert delete server mocks to requests_mock https://review.openstack.org/473839 | 13:20 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert delete server calls to REST https://review.openstack.org/473840 | 13:20 |
| mordred | Shrews: there's get_server_by_id and delete calls | 13:20 |
| mordred | Shrews: only list remains now. I'm going to see if I cna get that done in the next 40 minutes or so and if so, get it landed and ina release- if not, we can just release what we have now to unbreak htaccess | 13:20 |
| *** gouthamr has joined #openstack-shade | 13:36 | |
| *** cdent has quit IRC | 13:51 | |
| *** slaweq has joined #openstack-shade | 14:02 | |
| *** gkadam has quit IRC | 14:02 | |
| *** slaweq has quit IRC | 14:06 | |
| *** slaweq has joined #openstack-shade | 15:03 | |
| *** cdent has joined #openstack-shade | 15:04 | |
| *** slaweq has quit IRC | 15:07 | |
| *** slaweq has joined #openstack-shade | 15:24 | |
| *** slaweq has quit IRC | 15:26 | |
| *** slaweq has joined #openstack-shade | 15:47 | |
| *** slaweq has quit IRC | 15:55 | |
| *** cdent has quit IRC | 16:01 | |
| * morgan goes to look for a new phone | 16:11 | |
| morgan | phone was lost today :( | 16:12 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Enforce API version in functional tests https://review.openstack.org/473795 | 16:12 |
| mordred | morgan: GROSS | 16:14 |
| morgan | slipped walking the dog, heard phone skitter... and gone (not online anymore) | 16:16 |
| morgan | so... in a drain? in water? who knows. | 16:16 |
| morgan | RIP Pixel XL | 16:16 |
| morgan | also... lots of Ibprofen | 16:16 |
| morgan | cause... ouch. | 16:17 |
| morgan | mordred: i still have my Nexus 5x, i might just order a new sim for it | 16:17 |
| morgan | and run with it for a bit (as underpowered as it is) | 16:17 |
| mordred | morgan: fwiw, I did that with my one plus when I left my pixel in a cab in berlin a few weeks before the barcelona summit | 16:18 |
| mordred | morgan: fi sim in non-fi phone is REALLY bad | 16:18 |
| morgan | yeah the 5x is thankfully a Fi phone | 16:18 |
| mordred | oh right | 16:18 |
| morgan | hehe | 16:18 |
| mordred | that's much better | 16:18 |
| morgan | right?! | 16:19 |
| mordred | jlk: speaking of ansible - I've got patches up leading up to https://review.openstack.org/#/c/473838 which RESTify create_server ... once they're in, I'm going to add support for network tags for yolanda | 16:31 |
| mordred | jlk: I'm pinging you because network tags are a microversion-protected feature (and will be our first) ... so I thought maybe we should think real quick about the 'right' way to expose that in ansible? | 16:31 |
| jlk | neat | 16:31 |
| jlk | I'll peruse the stack. | 16:32 |
| mordred | jlk: like, I'm thinking, always accept tag as input, but if it's given and the cloud doens't support it, return an error about microversion mismatch? | 16:32 |
| jlk | I have to page back in openstack knowledge bits. | 16:32 |
| jlk | are there some clouds that don't allow getting an instance by iD? Or should I be looking at a different patch in teh stack? | 16:33 |
| mordred | oh - sorry - I'm talking about hte next patches I'm going to write | 16:33 |
| mordred | jlk: that's the last patch in a stack of 5 that convert create_server and get_server_by_id to rest | 16:34 |
| mordred | those are all good and shouldn't break nothing | 16:34 |
| mordred | jlk: the question comes in that basically, in general, shade isn't planning on *directly* exposing microversion things to its users. rather it will use the best microversion it knows how to use after negotiating such with the cloud in question | 16:34 |
| jlk | ah | 16:35 |
| mordred | but for some things, like "the user wants to express network tags" - the feature just flat doesn't work on older clouds | 16:35 |
| mordred | I _think_ we just treat that the same as any feature that may or may not work depending on cloud age, yeah? | 16:35 |
| jlk | yeah that seems like time to throw an error. | 16:35 |
| mordred | cool | 16:35 |
| *** slaweq has joined #openstack-shade | 16:56 | |
| *** slaweq has quit IRC | 17:01 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert delete server calls to REST https://review.openstack.org/473840 | 17:04 |
| *** yfried has joined #openstack-shade | 17:51 | |
| *** slaweq has joined #openstack-shade | 17:57 | |
| *** slaweq has quit IRC | 18:01 | |
| *** ioggstream has quit IRC | 18:15 | |
| *** cdent has joined #openstack-shade | 18:25 | |
| *** slaweq has joined #openstack-shade | 18:58 | |
| samueldmq | mordred: how can I get the "final" url inside the shade adapter? | 19:02 |
| samueldmq | I guess it isnt always available in endpoint_override | 19:03 |
| *** slaweq has quit IRC | 19:03 | |
| samueldmq | re: https://review.openstack.org/#/c/473795 | 19:03 |
| *** yfried has quit IRC | 19:04 | |
| mordred | samueldmq: get_endpoint should always return the correct value | 19:04 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Enforce API version in functional tests https://review.openstack.org/473795 | 19:05 |
| samueldmq | mordred: thanks | 19:05 |
| mordred | samueldmq: however, it's worth noting that self.operator_cloud.cloud_config.get_api_version('identity') will return the detected version | 19:06 |
| mordred | samueldmq: if you look at it after the adapter has been constructed | 19:06 |
| samueldmq | mordred: so I can match self.cloud_config.get_api_version('identity') with what's in self.get_endpoint() | 19:06 |
| mordred | samueldmq: we update the value there after discovery so that the rest of shade knows which logic path to use | 19:06 |
| samueldmq | from inside the adapter code | 19:06 |
| mordred | samueldmq: you don't need to call get_endpoint at all - you can just check self.cloud_config.get_api_version('identity') | 19:07 |
| mordred | as long as you've referenced the adapter - so if you do "self.operator_cloud._identity_client" - that'll cause the adapter to be created which will update the api_version if needed | 19:07 |
| mordred | then you can check self.cloud_config.get_api_version('identity') | 19:07 |
| samueldmq | mordred: yes, but what I want to do is to check no v3 calls are made in the legacy tests, for instance | 19:08 |
| samueldmq | first, I do that inside the request() method of the adapter | 19:08 |
| samueldmq | and I can check the version the test says (2.0) against self.cloud_config.get_api_version('identity') | 19:09 |
| samueldmq | since we want to short-circuit if v3 is called in the -legacy gate | 19:10 |
| samueldmq | see https://review.openstack.org/#/c/473795 | 19:10 |
| *** slaweq has joined #openstack-shade | 19:11 | |
| samueldmq | mordred: ah I got it, if discovery gets v3 (even if I ask v2.0 because only v3 is available) it will update the version number anyways | 19:14 |
| samueldmq | so I can check against that | 19:14 |
| mordred | samueldmq: yes indeed. and if that's broken a _ton_ of other stuff will break :) | 19:15 |
| samueldmq | neat | 19:16 |
| samueldmq | mordred: and self.cloud_config.get_api_version('identity') is '3' or '2.0' (str), correct? | 19:17 |
| mordred | samueldmq: yes. well- it'll actually be "2" after discovery if we find 2 iirc ... | 19:17 |
| mordred | samueldmq: self.cloud_config.get_api_version('identity')[0] is always safe to check against either "3" or "2" | 19:18 |
| mordred | :) | 19:18 |
| samueldmq | ++ | 19:29 |
| *** cdent has quit IRC | 19:56 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert delete server mocks to requests_mock https://review.openstack.org/473839 | 20:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert delete server calls to REST https://review.openstack.org/473840 | 20:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Cleanup volumes in functional tests in parallel https://review.openstack.org/473969 | 20:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Update tests for server calls that aren't list https://review.openstack.org/473970 | 20:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Migrate non-list server interactions to REST https://review.openstack.org/473971 | 20:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Properly expand server dicts after rebuild and update https://review.openstack.org/473972 | 20:27 |
| *** slaweq has quit IRC | 20:41 | |
| *** slaweq has joined #openstack-shade | 20:42 | |
| *** slaweq has quit IRC | 20:46 | |
| *** gouthamr has quit IRC | 21:03 | |
| *** slaweq has joined #openstack-shade | 21:20 | |
| *** slaweq has quit IRC | 21:24 | |
| *** gouthamr has joined #openstack-shade | 21:28 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Cleanup volumes in functional tests in parallel https://review.openstack.org/473969 | 21:37 |
| *** slaweq has joined #openstack-shade | 22:33 | |
| *** slaweq has quit IRC | 22:38 | |
| *** slaweq has joined #openstack-shade | 23:34 | |
| *** slaweq has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!