| mordred | rods: hi! the designate client calls are probably pretty easy to get started with - although wow, I just realized three of four things you'd need to know that I don't have writtne down | 00:31 |
|---|---|---|
| mordred | but tl;dr is - pick a test to work on (I always start with a single test when I'm doing a new service) - change the base class of the test class to base.RequestsMockTestCase instead of base.TestCase | 00:33 |
| mordred | add an entry to shade/tests/unit/fixtures/catalog-v3.json for dns - then remove the @mock entries from one of the tests, run it and start watching what requests_mock complains is missing :) | 00:34 |
| rods | mordred hi, this looked as an easy one https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L1718 | 00:38 |
| rods | just started from it :) | 00:38 |
| mordred | awesome! I'm getting close to AFK for the night - but let me know if you get stuck anywhere and I'll do what I can to help | 00:46 |
| rods | mordred cool, thx | 00:47 |
| *** jamielennox is now known as jamielennox|away | 04:01 | |
| *** jamielennox|away is now known as jamielennox | 04:29 | |
| *** jamielennox is now known as jamielennox|away | 06:52 | |
| *** ioggstream has joined #openstack-shade | 07:28 | |
| *** Aqsa has joined #openstack-shade | 07:51 | |
| *** cdent has joined #openstack-shade | 08:47 | |
| -openstackstatus- NOTICE: zuul was restarted due to an unrecoverable disconnect from gerrit. If your change is missing a CI result and isn't listed in the pipelines on http://status.openstack.org/zuul/ , please recheck | 08:52 | |
| *** cdent has quit IRC | 09:07 | |
| *** cdent has joined #openstack-shade | 09:50 | |
| *** jamielennox|away is now known as jamielennox | 11:18 | |
| *** jamielennox is now known as jamielennox|away | 12:05 | |
| *** cdent has quit IRC | 12:12 | |
| *** gouthamr has joined #openstack-shade | 13:28 | |
| *** cdent has joined #openstack-shade | 13:33 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Pass in app_name information to keystoneauth https://review.openstack.org/456268 | 14:12 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use keystone_session in _get_raw_client https://review.openstack.org/456633 | 14:12 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Pass shade version info to session user_agent https://review.openstack.org/456634 | 14:12 |
| mordred | jamielennox|away, samueldmq, morgan: after chatting with jamie yesterday, I believe that's what that wants to look like | 14:12 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Pass shade version info to session user_agent https://review.openstack.org/456634 | 15:06 |
| *** melwitt_ has joined #openstack-shade | 15:09 | |
| *** dtroyer_zz has joined #openstack-shade | 15:09 | |
| *** mordred1 has joined #openstack-shade | 15:10 | |
| *** dtroyer has quit IRC | 15:10 | |
| *** melwitt has quit IRC | 15:10 | |
| *** thingee has quit IRC | 15:10 | |
| *** mordred has quit IRC | 15:10 | |
| *** TheJulia has quit IRC | 15:10 | |
| *** Shrews has quit IRC | 15:10 | |
| *** Shrews has joined #openstack-shade | 15:11 | |
| *** thingee has joined #openstack-shade | 15:13 | |
| *** TheJulia has joined #openstack-shade | 15:18 | |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add ability to pass in user_agent https://review.openstack.org/452550 | 15:39 |
| *** mordred1 is now known as mordred | 15:46 | |
| morgan | mordred: interesting | 15:56 |
| *** openstack has joined #openstack-shade | 16:32 | |
| *** openstackstatus has joined #openstack-shade | 16:35 | |
| *** ChanServ sets mode: +v openstackstatus | 16:35 | |
| *** melwitt_ is now known as melwitt | 16:43 | |
| rods | it is possible that the names of these two tests have been inverted? https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L195 and https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L213? | 16:47 |
| rods | seems like the first one is doing the invalidation but the second has `invalidates` in the name | 16:47 |
| mordred | rods: no - they're right. the first one is testing that list_volumes is being cached - the invalidates in the test is to verify that the previous call was returning the cached value | 16:50 |
| mordred | the second test is testing that issuing a create automatically invalidates the cache | 16:50 |
| mordred | so the test doens'tneed to do an invalidate itself | 16:51 |
| rods | oh, I see | 16:51 |
| *** Aqsa has quit IRC | 17:03 | |
| *** ioggstream has quit IRC | 17:23 | |
| rods | mordred I'm trying to upgrade test_list_volumes to use requests_mock. For the cache tests we need to fake two api calls to return different results but looks like register_uris can be called just once per test. https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/base.py#L475. Any hint? | 17:25 |
| rods | sorry trying to get familiar with the code | 17:25 |
| mordred | rods: you can pass a list of calls in to it -- for instance: https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_flavors.py#L46-L57 | 17:26 |
| mordred | so if you put in a list of the calls in sequence - it'll do the right things | 17:26 |
| mordred | rods: and no worries - there's a bunch of stuff going on - thanks for digging in! | 17:27 |
| *** cdent has quit IRC | 18:45 | |
| *** gouthamr has quit IRC | 19:17 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST for the cinder volumes list https://review.openstack.org/456736 | 19:18 |
| rods | ^^ still a working progress(there is an other test to fix) but I'd love some feedback :) | 19:22 |
| *** cdent has joined #openstack-shade | 19:27 | |
| -openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks. | 19:52 | |
| *** cdent has quit IRC | 19:59 | |
| *** ioggstream has joined #openstack-shade | 20:10 | |
| *** gouthamr has joined #openstack-shade | 20:10 | |
| *** Aqsa has joined #openstack-shade | 20:14 | |
| *** cdent has joined #openstack-shade | 21:04 | |
| *** ioggstream has quit IRC | 21:12 | |
| *** cdent has quit IRC | 21:25 | |
| *** jamielennox|away is now known as jamielennox | 22:19 | |
| *** Aqsa has quit IRC | 22:40 | |
| *** gouthamr has quit IRC | 23:24 | |
| *** gouthamr has joined #openstack-shade | 23:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!