| *** yolanda has quit IRC | 00:45 | |
| *** yolanda has joined #openstack-shade | 00:51 | |
| *** yolanda has quit IRC | 00:53 | |
| *** yolanda has joined #openstack-shade | 01:00 | |
| *** yolanda has quit IRC | 01:04 | |
| *** jamielennox is now known as jamielennox|away | 05:06 | |
| *** yfried has joined #openstack-shade | 05:27 | |
| *** yfried has quit IRC | 05:31 | |
| *** abregman has joined #openstack-shade | 05:55 | |
| *** yfried has joined #openstack-shade | 06:27 | |
| *** yolanda has joined #openstack-shade | 06:51 | |
| *** yfried has quit IRC | 07:00 | |
| *** yfried has joined #openstack-shade | 07:04 | |
| *** yfried has quit IRC | 07:22 | |
| *** yfried has joined #openstack-shade | 07:30 | |
| *** yfried has quit IRC | 07:46 | |
| *** abregman has quit IRC | 08:32 | |
| *** Matias has quit IRC | 08:33 | |
| *** Matias has joined #openstack-shade | 08:36 | |
| *** Matias has quit IRC | 08:41 | |
| *** abregman has joined #openstack-shade | 08:47 | |
| *** Matias has joined #openstack-shade | 08:55 | |
| *** Matias has joined #openstack-shade | 08:55 | |
| *** abregman has quit IRC | 08:58 | |
| *** abregman has joined #openstack-shade | 09:00 | |
| *** abregman has quit IRC | 09:53 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** abregman has joined #openstack-shade | 10:34 | |
| *** yfried has joined #openstack-shade | 10:50 | |
| *** dfflanders has quit IRC | 10:59 | |
| *** yfried has quit IRC | 11:06 | |
| *** yfried has joined #openstack-shade | 11:08 | |
| *** yfried has quit IRC | 11:32 | |
| *** yfried has joined #openstack-shade | 11:42 | |
| *** openstackgerrit has joined #openstack-shade | 12:07 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 12:07 |
|---|---|---|
| *** yfried has quit IRC | 12:38 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to slow performance | 12:47 | |
| -openstackstatus- NOTICE: Gerrit has been successfully restarted | 12:50 | |
| *** yfried has joined #openstack-shade | 12:52 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 13:00 |
| *** yfried has quit IRC | 13:04 | |
| mordred | Shrews: I has added test (and yes, the test fails when I don't fix that bug you found) | 13:07 |
| Shrews | mordred: yeah. just left you a comment | 13:08 |
| mordred | ooh, look, you're awake! | 13:08 |
| mordred | Shrews: yah - SO not needed that it was also not working :) | 13:09 |
| Shrews | not sure "awake" is the correct word, but i am present, at least | 13:10 |
| mordred | Shrews: dude. I woke up at 5am europe time to get on a 7am flight and am currently over the atlantic. I don't know that I even exist | 13:11 |
| Shrews | you're still in the future, so technically you DON'T exist yet | 13:12 |
| Shrews | at least not in my timeline | 13:13 |
| *** yfried has joined #openstack-shade | 13:13 | |
| Shrews | mordred: so, i guess we should remove that comment now since it doesn't make sense, yeah? | 13:13 |
| mordred | did I not? | 13:14 |
| mordred | gah | 13:14 |
| Shrews | nope | 13:14 |
| Shrews | that's why i commented :) | 13:14 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 13:14 |
| Shrews | mordred: but i think roberto also had a valid point in PS2 | 13:15 |
| Shrews | mordred: you raise a new exception that gets ignored | 13:15 |
| mordred | oh - right. thanks for reminding me | 13:15 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 13:16 |
| mordred | Shrews: I've never seen that scenario, so it was a sort of crazy exception anyway | 13:17 |
| mordred | Shrews: changed it to a debug log | 13:17 |
| mordred | if anybody complains about their logs being filled with tha tmessage, we can handle it :) | 13:17 |
| *** yfried has quit IRC | 14:08 | |
| *** flvszch50 has quit IRC | 14:18 | |
| *** gouthamr has joined #openstack-shade | 14:31 | |
| *** abregman has quit IRC | 15:59 | |
| *** abregman has joined #openstack-shade | 16:01 | |
| morgan | mordred: ++ good plan | 16:08 |
| mordred | Shrews: my change to change the exception into a log statement sucked | 16:29 |
| *** abregman has quit IRC | 16:40 | |
| morgan | mordred: what did you do? | 17:09 |
| morgan | or why did it suck? | 17:09 |
| morgan | mordred: also FTR, .format is *way* slower than % | 17:09 |
| morgan | and log doesn't need .format or %, the logger will process: log.debug('blah %s', <string>) | 17:10 |
| sigmavirus | mordred: str.format is getting better in newer versions of Python fwiw | 17:11 |
| sigmavirus | should be better even in Py35 | 17:11 |
| morgan | sigmavirus: it is. | 17:12 |
| morgan | sigmavirus: it still isn't *great* | 17:12 |
| morgan | sigmavirus: i expect it to be on par somewhere in py36 or 37 | 17:12 |
| morgan | ;) | 17:12 |
| sigmavirus | I doubt it'll ever get equal performance | 17:12 |
| morgan | sigmavirus: but there is no reason to .format when passing to a logger | 17:12 |
| sigmavirus | the implementations are a bit too diffrent | 17:13 |
| sigmavirus | morgan: oh absolutely | 17:13 |
| morgan | "on par" = not orders of magnitude difference | 17:13 |
| sigmavirus | Wasn't disagreeing with that :) | 17:13 |
| morgan | like it is in 27/pre-35 | 17:13 |
| morgan | ^_^ | 17:13 |
| morgan | sigmavirus: also Hey! :) | 17:13 |
| morgan | longtime no see/chat | 17:13 |
| sigmavirus | Hi! | 17:13 |
| sigmavirus | Yeah I've been head's down elsewhere | 17:13 |
| morgan | well, welcome back! | 17:14 |
| sigmavirus | Thanks :) | 17:15 |
| sigmavirus | Not quite back, so much as peeking into channels | 17:15 |
| *** yolanda has quit IRC | 17:18 | |
| *** yolanda has joined #openstack-shade | 17:41 | |
| *** yolanda has quit IRC | 18:06 | |
| *** cdent has joined #openstack-shade | 18:21 | |
| *** yolanda has joined #openstack-shade | 18:40 | |
| *** Shrews has quit IRC | 18:46 | |
| *** Shrews has joined #openstack-shade | 18:47 | |
| *** cdent has quit IRC | 19:03 | |
| *** abregman has joined #openstack-shade | 19:32 | |
| *** abregman has quit IRC | 20:13 | |
| *** abregman has joined #openstack-shade | 20:13 | |
| *** abregman has quit IRC | 20:28 | |
| *** jamielennox|away has quit IRC | 20:46 | |
| *** jamielennox|away has joined #openstack-shade | 20:56 | |
| *** jamielennox|away is now known as jamielennox | 20:56 | |
| mordred | morgan: so ... I find {foo} more readable than %s personally - and would rather readable where we can have it ... if we hit places where we're having performance issues, I'd rather we profile and prove out that there are issues before optimizing away readablity | 22:07 |
| mordred | I mean, not that the code is the world's cleanest :) | 22:07 |
| morgan | i use %(foo)s | 22:08 |
| morgan | and then {'foo': <value>{ | 22:08 |
| morgan | in the substitution | 22:08 |
| morgan | i wasn't implying we should use %s %s %s %s and hope it made sense ;) | 22:09 |
| mordred | sure, that's an option - but it still reads mor3 clunky to me - and the other things we;re doing are bazillions of external HTTP calls which I imagine are going to be where all th ecost is | 22:09 |
| mordred | morgan: :) | 22:09 |
| mordred | replace all with %s !!! :) | 22:09 |
| morgan | iirc you can do: log.debug('%(foo)s %(bar)s', foo=value, bar=value) | 22:09 |
| mordred | yah - and I actually should do that for log calls - the format call to log _is_ a mistake | 22:10 |
| morgan | :) | 22:11 |
| * morgan shrugs | 22:11 | |
| morgan | was mostly a nit | 22:11 |
| morgan | i wouldn't -1 or anything based on that | 22:11 |
| morgan | (in keystone... I'd be more "dude... follow the other style we use everywhere else") but | 22:11 |
| mordred | we actually landed a patch about a month ago to not do formats to log calls ... so it's a good catch :) | 22:11 |
| morgan | in shade, as long as the info is there and the code is managable/readable, win | 22:11 |
| mordred | so it's both good, _and_ in keeping with the prevailing style for log calls | 22:12 |
| * morgan nods. | 22:12 | |
| mordred | morgan: btw - downside of travelling to europe with a european cable for laptop rather than an adapter - when your transatlantic flight power doens't work - you don't have any way to plug in at the airport | 22:13 |
| morgan | ouch | 22:13 |
| morgan | yeah. | 22:13 |
| morgan | mordred: time to connect the android phone to the wifi in flight/airport and then code from it! :P | 22:13 |
| mordred | :) | 22:14 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 22:14 |
| clarkb | mordred: I once fixed a bug and pushed a patch into production from a MAX train ssh'd into a server with connectbot editing files with vim | 22:18 |
| clarkb | do not recommend :P | 22:18 |
| mordred | clarkb: I assume that's your normal work environment | 22:23 |
| clarkb | mordred: I actually have a proper office with a desk and keyboard (two actually because i am weird) and monitor | 22:24 |
| *** gouthamr has quit IRC | 22:24 | |
| clarkb | I have been told that my das keyboard and model M are too noisy when twins are napping so I have an hhkb plugged in that I switch to during their naps | 22:24 |
| mordred | hah. nice | 22:25 |
| mordred | morgan: does that look better? | 22:25 |
| morgan | mordred: looks way better! | 22:45 |
| morgan | hhkb is cherry brown or similar "quiet clicky" vs blue (das ?) | 22:45 |
| morgan | clarkb: ^ | 22:45 |
| clarkb | morgan: no its a 20 year old membrane switch keyboard | 22:46 |
| clarkb | but its tiny with programmable dip switch meta keys so has quite a following (I never really got into it) | 22:46 |
| clarkb | but found one for cheap | 22:47 |
| morgan | hehe nice | 22:47 |
| morgan | and clearly "quiet" compared to the mechanicals | 22:47 |
| clarkb | oh hhkb does put control in the right location though :) | 22:55 |
| *** thingee has quit IRC | 23:31 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!