| thingee | mordred hey, do you know what's going with the issue moves to ansible/ansible? https://github.com/ansible/ansible-modules-core/issues/4108#issuecomment-262195852 | 00:06 |
|---|---|---|
| thingee | if you take that one for example, it's not moved over to ansible/ansible when doing a search for it | 00:06 |
| mordred | thingee: there's a tool they made that can help move things ... | 00:07 |
| thingee | I thought it was automatic though? | 00:07 |
| thingee | or are we expected to run this "automatic tool" | 00:07 |
| mordred | no - unfortunately not automatic | 00:07 |
| mordred | the issue move they suggest is https://github-issue-mover.appspot.com/ | 00:07 |
| mordred | https://docs.ansible.com/ansible/dev_guide/repomerge.html <-- docs on the merge | 00:08 |
| thingee | ugh | 00:08 |
| mordred | yah. it's not the best | 00:16 |
| *** gouthamr has quit IRC | 02:10 | |
| *** jamielennox is now known as jamielennox|away | 03:08 | |
| *** jamielennox|away is now known as jamielennox | 03:22 | |
| *** yfried has joined #openstack-shade | 06:48 | |
| *** jamielennox is now known as jamielennox|away | 07:28 | |
| *** abregman has joined #openstack-shade | 07:41 | |
| *** abregman has quit IRC | 08:13 | |
| *** abregman has joined #openstack-shade | 09:31 | |
| *** yfried has quit IRC | 12:22 | |
| *** gouthamr has joined #openstack-shade | 12:55 | |
| *** yfried has joined #openstack-shade | 13:05 | |
| *** abregman has quit IRC | 13:26 | |
| *** abregman has joined #openstack-shade | 13:26 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 15:19 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add functional test to show floating ip reuse https://review.openstack.org/409842 | 15:19 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 15:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add functional test to show floating ip reuse https://review.openstack.org/409842 | 15:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add test to verify devstack keystone config https://review.openstack.org/413139 | 15:27 |
| *** abregman has quit IRC | 16:24 | |
| Shrews | mordred: re: https://review.openstack.org/#/c/412530/2/shade/openstackcloud.py | 16:55 |
| Shrews | since the swift_client_lock is removed, do we need to always just return a new client from swift_client()? | 16:55 |
| Shrews | or maybe keep that lock around | 16:56 |
| mordred | Shrews: we could - we mostly stop caring about swift_client with that patch | 16:57 |
| mordred | since we don't use it interally | 16:57 |
| Shrews | mordred: that was option 3 | 16:57 |
| Shrews | which i'm good with, just wanted to make sure that was considered | 16:57 |
| mordred | Shrews: we could totally just always return one though - for glance_client too | 16:58 |
| mordred | Shrews: I don't think that we need to cache them anymore | 16:58 |
| openstackgerrit | Merged openstack-infra/shade: Extract assertion method for asserting calls made https://review.openstack.org/412103 | 17:08 |
| openstackgerrit | Merged openstack-infra/shade: Make munch aware assertEqual test method https://review.openstack.org/412104 | 17:09 |
| Shrews | mordred: reviewed your stack. https://review.openstack.org/412530 has a -1 | 17:11 |
| Shrews | all rest +2'd | 17:11 |
| mordred | Shrews: just fixing hte -1 now. thank you! | 17:13 |
| mordred | Shrews: so it makes sense / reads ok? | 17:13 |
| Shrews | mordred: yeah. i mean, i didn't bother testing things like i normally do (just trusted you knew what you were doing), but the flow makes sense | 17:14 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Switch swift calls to REST https://review.openstack.org/412530 | 17:15 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Make assert_calls a bit more readable https://review.openstack.org/412549 | 17:15 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Make delete_object return True and False https://review.openstack.org/412543 | 17:15 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Update swift exception tests to use 416 https://review.openstack.org/412544 | 17:15 |
| mordred | Shrews: ^^ fixed - and also just made swift_client return directly | 17:17 |
| morgan | mordred: annnnd now my internet is "working" again | 17:55 |
| morgan | .... grumble. | 17:55 |
| *** yfried has quit IRC | 18:01 | |
| morgan | mordred: looking at the failures now. | 18:04 |
| mordred | morgan: http://logs.openstack.org/42/409842/11/check/gate-shade-dsvm-functional-neutron/f94197d/console.html is the interesting one ... | 18:08 |
| mordred | morgan: http://logs.openstack.org/42/409842/11/check/gate-shade-dsvm-functional-neutron/f94197d/console.html | 18:08 |
| mordred | morgan: I'm about to push up a new patch to the base patchset I made (typo on my part) | 18:08 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 18:09 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add test to verify devstack keystone config https://review.openstack.org/413139 | 18:09 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add functional test to show floating ip reuse https://review.openstack.org/409842 | 18:09 |
| morgan | mordred: okie | 18:09 |
| mordred | morgan: gah. http://logs.openstack.org/42/409842/11/check/gate-shade-dsvm-functional-neutron/f94197d/console.html#_2016-12-20_16_14_08_123973 is what I meant to link | 18:10 |
| morgan | mordred: my assertion may just be wrong | 18:10 |
| *** yfried has joined #openstack-shade | 18:14 | |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 18:14 |
| morgan | mordred: ^ that was a bug. | 18:14 |
| morgan | i was trying to assign the user/grant to the original project | 18:15 |
| morgan | not the new one | 18:15 |
| mordred | morgan: whoopsie :) | 18:26 |
| morgan | mordred: yeah | 18:26 |
| morgan | https://www.irccloud.com/pastebin/BynLTd4P/ | 19:26 |
| morgan | mordred: ^ new failure. | 19:26 |
| morgan | mordred: but we're close | 19:27 |
| *** gouthamr has quit IRC | 19:29 | |
| morgan | mordred: ahh looks like that comes from your parent patch | 19:31 |
| morgan | mordred: i think your test needs to be inverted, devstack defaults to v3 only now | 19:39 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade: Add test to verify devstack keystone config https://review.openstack.org/413139 | 19:40 |
| mordred | morgan: export SHADE_USE_KEYSTONE_V2=1 should be set only in the keystone v2 job | 19:41 |
| morgan | or the mordred right, so you were checking v2 and defaulting it to "on" | 19:42 |
| mordred | morgan: oh. duh. because I'm dumb | 19:42 |
| morgan | if os.environ.get('SHADE_USE_KEYSTONE_V2', '1'): | 19:42 |
| morgan | self.assertEqual('2.0', self.identity_version) | 19:42 |
| morgan | yah | 19:42 |
| morgan | i just changed that to default to v3 | 19:42 |
| morgan | if os.environ.get('SHADE_USE_KEYSTONE_V2', '0'): | 19:42 |
| morgan | now | 19:42 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 19:48 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Add functional test to show floating ip reuse https://review.openstack.org/409842 | 19:48 |
| mordred | morgan: (rebased those other two) | 19:48 |
| morgan | cool | 19:49 |
| *** gouthamr has joined #openstack-shade | 19:50 | |
| morgan | mordred: https://review.openstack.org/#/c/409842/13/shade/tests/functional/test_floating_ip.py work in progress? with the pprint lines? | 20:02 |
| mordred | morgan: oh - well - I put those in there when it was failing to figure out what was going on | 20:07 |
| mordred | morgan: if it passes, we can remove them :) | 20:07 |
| morgan | ;) | 20:07 |
| morgan | hmm | 20:23 |
| morgan | mordred: oh.. i think i am "wrong" on my fix | 20:26 |
| morgan | too | 20:26 |
| *** yfried has quit IRC | 20:27 | |
| morgan | yep | 20:27 |
| morgan | >>> if '0': print "True" | 20:27 |
| morgan | ... | 20:27 |
| morgan | True | 20:27 |
| morgan | '0' is still "true" | 20:27 |
| mordred | morgan: we're really good at computers | 20:27 |
| morgan | right?! | 20:28 |
| morgan | fixing now | 20:28 |
| mordred | we need if os.environ.get('SHADE_USE_KEYSTONE_V2', '0') == '1' | 20:28 |
| mordred | morgan: and we need to both go back to basic computer school | 20:28 |
| morgan | i was going to go with: | 20:28 |
| morgan | use_keystone_v2 = os.environ.get('SHADE_USE_KEYSTONE_V2', False) | 20:29 |
| morgan | if use_keystone_v2 and use_keystone_v2 != '0': | 20:29 |
| morgan | which menas someone can override the env with '0' and get an expected result | 20:29 |
| morgan | but we can also accept "True", "yes", "omg pleae" | 20:29 |
| morgan | :P | 20:29 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade: Add test to verify devstack keystone config https://review.openstack.org/413139 | 20:30 |
| morgan | annnyway... | 20:31 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade: Add in a dynamic project scope test fixture https://review.openstack.org/410453 | 20:31 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade: Add functional test to show floating ip reuse https://review.openstack.org/409842 | 20:31 |
| *** jamielennox|away is now known as jamielennox | 20:44 | |
| mordred | thingee: if you have a moment - we keep failing with timeouts in a cinder test: https://review.openstack.org/#/c/412105/ like http://logs.openstack.org/05/412105/4/check/gate-shade-dsvm-functional-legacy/ba963f4/console.html#_2016-12-20_19_23_54_926739 | 21:02 |
| mordred | thingee: but only on the legacy devstack config (which has nova-net and keystone v2) | 21:02 |
| mordred | thingee: I'm wondering if there is something we're doing there which is causing cinder to have sads | 21:03 |
| mordred | thingee: but I can't see anything from looking | 21:03 |
| *** gouthamr has quit IRC | 21:09 | |
| morgan | mordred: https://review.openstack.org/#/c/413139/4 is passing now! | 21:19 |
| morgan | yay | 21:19 |
| morgan | mordred: looking at the fixture stuff, looks like a small bug in the logic | 21:20 |
| *** gouthamr has joined #openstack-shade | 22:13 | |
| thingee | mordred checking | 23:10 |
| mordred | thingee: awesome. thanks! | 23:43 |
| thingee | mordred the error mentions serverlist. Why do you think it's volume related? | 23:46 |
| thingee | aside from the test name | 23:47 |
| mordred | thingee: sorry, I gave bad link | 23:49 |
| mordred | thingee: http://logs.openstack.org/05/412105/4/gate/gate-shade-dsvm-functional-legacy/f3926ef/console.html#_2016-12-20_17_12_24_390634 | 23:49 |
| mordred | "Timeout waiting for the volume to be deleted." | 23:49 |
| thingee | got it, thanks! | 23:49 |
| mordred | thingee: that said - that could be ANYTHING tbh | 23:50 |
| mordred | thingee: as to verify the volume being deleted we may be getting status on other things | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!