| morgan | mordred: I am expecting to be cranking out some shade stuff over the holidays. | 01:14 |
|---|---|---|
| morgan | mordred: as I settle into the new place. (I also think I'll get stuff done this week) | 01:14 |
| morgan | but... lots of time to break in the new house... also woot possibly found a place with radiant heating | 01:14 |
| mordred | morgan: woot! | 02:36 |
| *** mordred has quit IRC | 04:26 | |
| *** greghaynes has quit IRC | 04:26 | |
| *** Shrews has quit IRC | 04:27 | |
| *** Shrews has joined #openstack-shade | 05:03 | |
| *** greghaynes has joined #openstack-shade | 05:04 | |
| *** mordred has joined #openstack-shade | 05:04 | |
| *** mordred has quit IRC | 05:18 | |
| *** Shrews has quit IRC | 05:18 | |
| *** Shrews has joined #openstack-shade | 05:26 | |
| *** mordred has joined #openstack-shade | 05:27 | |
| *** mordred has quit IRC | 07:25 | |
| *** Shrews has quit IRC | 07:30 | |
| *** mordred has joined #openstack-shade | 07:34 | |
| *** Shrews has joined #openstack-shade | 07:35 | |
| *** abregman has joined #openstack-shade | 08:17 | |
| *** larainema has quit IRC | 09:14 | |
| *** larainema_ has joined #openstack-shade | 09:14 | |
| *** abregman has quit IRC | 12:04 | |
| *** larainema_ has quit IRC | 12:46 | |
| *** larainema_ has joined #openstack-shade | 12:46 | |
| *** abregman has joined #openstack-shade | 13:02 | |
| *** gouthamr has joined #openstack-shade | 13:10 | |
| *** gouthamr has quit IRC | 13:10 | |
| *** gouthamr has joined #openstack-shade | 13:12 | |
| *** yfried has joined #openstack-shade | 14:06 | |
| yfried | Shrews: is this better? | 14:06 |
| Shrews | sure | 14:07 |
| yfried | https://storyboard.openstack.org/#!/story/2000820 https://storyboard.openstack.org/#!/story/2000819 | 14:07 |
| yfried | Shrews: ^ these will break os_floating_ip trying to use nat_destination | 14:08 |
| Shrews | i saw those get created, but haven't had any time to look into them. mordred would likely know more about that area than i would, anyway | 14:10 |
| yfried | Also, | 14:11 |
| yfried | https://github.com/ansible/ansible-modules-core/blob/devel/cloud/openstack/os_floating_ip.py#L71 | 14:11 |
| yfried | Shrews: if "internal_network" alias is used | 14:11 |
| yfried | https://github.com/ansible/ansible-modules-core/blob/devel/cloud/openstack/os_floating_ip.py#L187 | 14:12 |
| yfried | fails with some weird shade error re "internal_network" depracated, use networks[dict(name=net, external=False)] | 14:12 |
| Shrews | does it fail, or just give the deprecation warning? and can't you just use the suggested new key? | 14:16 |
| yfried | Shrews: it fails | 14:16 |
| Shrews | yfried: ok. have you submitted any fixes for these things? | 14:17 |
| yfried | Shrews: and the problem is that it's a module key, but the are all passed down to shade | 14:17 |
| yfried | Shrews: https://github.com/rhosqeauto/InfraRed/commit/ac77fc7e0cbdcf5585f028245f692533da81cfa5#diff-eac831ad0f353d4b5c59e72430f2ae82 | 14:17 |
| yfried | Shrews: ^ that's a possible fix. but it's ugly | 14:18 |
| Shrews | the os_floating_ip change seems reasonable to me, unless mordred has another idea | 14:19 |
| Shrews | though we might should check what's happening with shade first | 14:21 |
| mordred | Shrews, yfried: I'll look at it in a bit - still waking up | 14:55 |
| mordred | that ansible commit is a bad idea. we should just fix shade - but I don't have enough coffee yet to present thoughts on that | 14:57 |
| yfried | mordred: the commit is my own private module | 14:59 |
| mordred | yfried: yah - totally - just saying that's a bad idea for updating in the actual ansible modules when we can fix shade- I'm sure it's a good workaround for you for now | 15:02 |
| yfried | mordred: keep in mind that we have a problem if using shade keywords in ansible module requires shade fix | 15:10 |
| *** larainema_ is now known as larainema | 15:11 | |
| mordred | well - there is definitelya problem here and definitely also a bug in the ansible module | 15:14 |
| mordred | I have a hunch there may be a bug to fix in both the module and in shade | 15:15 |
| *** abregman has quit IRC | 15:36 | |
| *** abregman has joined #openstack-shade | 15:37 | |
| mordred | yfried: ok. for first thing, it seems that passing nat_destination in was simply not plumbed through for the case where an ip_pool is provided | 15:58 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Plumb nat_destination through for ip_pool case https://review.openstack.org/407578 | 15:59 |
| mordred | yfried, Shrews: ^^ there is a patch to fix that. I need to afk for a sec, I'll follow up with more in a little bit | 15:59 |
| Shrews | b 12 | 16:13 |
| *** cdent has joined #openstack-shade | 16:26 | |
| *** yfried has quit IRC | 16:57 | |
| mordred | Shrews: https://github.com/ansible/ansible-modules-core/pull/5845 - I'll re-submit after the repo merge | 17:09 |
| mordred | Shrews: but that should fix the yfried issue | 17:09 |
| Shrews | mordred: left a comment for yfried to test it | 17:12 |
| mordred | Shrews: he'll also need the shade change | 17:14 |
| *** abregman has quit IRC | 17:40 | |
| openstackgerrit | Merged openstack-infra/shade: Remove test of having a thundering herd https://review.openstack.org/406494 | 18:26 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Plumb nat_destination through for ip_pool case https://review.openstack.org/407578 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Move image tests from caching to image test file https://review.openstack.org/407668 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Remove caching config from test_image https://review.openstack.org/407669 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Convert test_create_image_put_v2 to requests_mock https://review.openstack.org/407670 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Convert test_create_image_put_v2 to requests_mock https://review.openstack.org/407670 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Move image tests from caching to image test file https://review.openstack.org/407668 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Remove caching config from test_image https://review.openstack.org/407669 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Plumb nat_destination through for ip_pool case https://review.openstack.org/407578 | 19:24 |
| mordred | Shrews, morgan: ^^ the changes there that are not the nat_destination change are starting to migrate image tests that mocked the clients to mocking the requests instead | 19:26 |
| morgan | ahh | 19:26 |
| morgan | mordred: will review today | 19:26 |
| mordred | morgan: I think there are things that we can likely streamline - but I tried to not think about that _too_ much yet | 19:27 |
| morgan | mordred: yeah not worried about cleanup | 19:27 |
| mordred | morgan: but luckily there are enough moving parts with image stuff that we can likely figure out all of the patterns we need for the requests_mock stuff | 19:27 |
| morgan | worried about basic "does it do the job" | 19:27 |
| morgan | shade has enough cases of "we should clean up" at this point, moving this around is functionally more important than "is it super slick code" | 19:28 |
| mordred | morgan: ++ | 19:29 |
| mordred | making sure it's the most elegant code is going to be a failing endeavor :) | 19:29 |
| morgan | nah. | 19:30 |
| morgan | it can be done | 19:30 |
| morgan | just kindof low on the requirement list atm | 19:30 |
| *** pleia2 has quit IRC | 19:34 | |
| *** pleia2 has joined #openstack-shade | 19:34 | |
| morgan | mordred: just had ghe mfa spec in keystone oopse merged. going to focus on addressing issues with it then review your code | 19:43 |
| morgan | mordred: in case we need to revert the spec merge | 19:43 |
| mordred | \o/ | 19:45 |
| morgan | ookay we haeve a reasonable MFA spec now :) | 19:53 |
| morgan | and (thankfully) should be relatively small code amounts to land (except the whole self-service API bit) | 19:53 |
| morgan | mordred: https://review.openstack.org/#/c/362473/ needs docs. | 19:54 |
| morgan | mordred: and it can land. | 19:54 |
| morgan | mordred: that is context manager for session | 19:54 |
| mordred | woot | 19:55 |
| morgan | mordred: how did that nat_destination thing ever work before? | 20:00 |
| mordred | morgan: it didn't | 20:00 |
| morgan | ahahahaha | 20:00 |
| mordred | wait - which one the shade one? | 20:00 |
| morgan | the shade one | 20:00 |
| morgan | yeah | 20:00 |
| mordred | yah - it did not work if you used the ip_pool option | 20:00 |
| morgan | LOL | 20:00 |
| morgan | yep | 20:00 |
| mordred | (which, as you might gather, we do not use in infra :) ) | 20:00 |
| morgan | that is what this change looks like it fixes | 20:00 |
| mordred | yuppers | 20:01 |
| morgan | that's pretty funny imo | 20:01 |
| morgan | through a couple of them | 20:03 |
| morgan | fwiw, I don;'t have +2 on shade, so just +1'ing | 20:03 |
| morgan | most are very straight forward so far | 20:03 |
| morgan | mordred: looks like https://review.openstack.org/#/c/407670/2 has a copy-paste error in it. using NO_MD5 for NO_sha256 | 20:06 |
| mordred | morgan: oh good | 20:07 |
| morgan | otherwise this is all looking pretty good across the board | 20:08 |
| mordred | morgan: oh - look at the python35 unit test failure in 407670 | 20:16 |
| morgan | oh interesting | 20:17 |
| mordred | morgan: I'm guessing because we're passing a file object to put | 20:18 |
| mordred | morgan: but have not investigated yet | 20:19 |
| morgan | yeah | 20:19 |
| morgan | that sounds correct | 20:19 |
| mordred | (especially since the calls before the PUT succeeded and the PUT did not) | 20:19 |
| morgan | interesting issue | 20:19 |
| morgan | i can dig into that in a bit here, need to re-review a spec in keystone then lunch | 20:22 |
| morgan | i'll happlily play some cleanup here | 20:22 |
| *** gouthamr has quit IRC | 20:39 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Convert test_create_image_put_v2 to requests_mock https://review.openstack.org/407670 | 21:19 |
| Shrews | mordred: sorry, been too busy with nodepool things today. will try to review some shade stuff tomorrow | 21:34 |
| mordred | Shrews: no worries at all! | 21:38 |
| mordred | Shrews: you do nodepool things - they're important | 21:38 |
| *** yolanda has quit IRC | 22:52 | |
| *** cdent has quit IRC | 22:53 | |
| *** yolanda has joined #openstack-shade | 22:54 | |
| *** yolanda has quit IRC | 23:04 | |
| *** yolanda has joined #openstack-shade | 23:13 | |
| *** yolanda has quit IRC | 23:22 | |
| *** yolanda has joined #openstack-shade | 23:35 | |
| *** yolanda has quit IRC | 23:43 | |
| openstackgerrit | Jamie Lennox proposed openstack-infra/shade: Convert test_create_image_put_v2 to requests_mock https://review.openstack.org/407670 | 23:48 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Convert test_create_image_put_v2 to requests_mock https://review.openstack.org/407670 | 23:57 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Change register_uri to use the per-method calls https://review.openstack.org/407767 | 23:57 |
| mordred | morgan: ^^ jamielennox found the requests_mock issue - and a thing he's going to add a test for in requests_mock | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!