| *** yingjun has joined #openstack-searchlight | 01:05 | |
| *** bpokorny has joined #openstack-searchlight | 02:03 | |
| *** bpokorny has quit IRC | 04:41 | |
| *** GB21 has joined #openstack-searchlight | 05:51 | |
| *** pcaruana has quit IRC | 06:02 | |
| *** openstackgerrit has quit IRC | 06:17 | |
| *** openstackgerrit_ is now known as openstackgerrit | 06:17 | |
| *** openstackgerrit_ has joined #openstack-searchlight | 06:18 | |
| *** openstackgerrit_ is now known as openstackgerrit | 06:19 | |
| *** openstackgerrit_ has joined #openstack-searchlight | 06:19 | |
| *** itisha has quit IRC | 06:49 | |
| *** GB21 has quit IRC | 07:45 | |
| openstackgerrit | Li Yingjun proposed openstack/searchlight: Catch endpoint not found exception https://review.openstack.org/295108 | 08:06 |
|---|---|---|
| *** GB21 has joined #openstack-searchlight | 08:25 | |
| openstackgerrit | Li Yingjun proposed openstack/searchlight: Add cleanup in functional tests https://review.openstack.org/295156 | 09:22 |
| *** yingjun has quit IRC | 09:36 | |
| *** GB21 has quit IRC | 10:12 | |
| *** GB21 has joined #openstack-searchlight | 11:19 | |
| *** GB21 has quit IRC | 12:31 | |
| *** akanksha_ has joined #openstack-searchlight | 12:40 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:51 | |
| sigmavirus24 | TravT_: apparently our WebOb change broke a lot of python clients | 14:00 |
| *** pcaruana has joined #openstack-searchlight | 14:05 | |
| sjmc7 | sigmavirus24: clients that were relying on the dodgy behavior? | 14:41 |
| sjmc7 | the timing of the 1.6.0 release was about as bad as it could have been :( | 14:44 |
| *** TravT_ is now known as TravT | 14:44 | |
| TravT | oh boy | 14:44 |
| sjmc7 | i thought though the change only took effect if Accept: was given as a header | 14:44 |
| TravT | sigmavirus24: so, what are the plans for it? | 14:44 |
| sigmavirus24 | Fix those clients/services | 14:45 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add network update, missing ports fields https://review.openstack.org/294733 | 14:48 |
| TravT | sjmc7. Based on comments on the subnets patch, it looks like we should land ^ first | 14:49 |
| TravT | ? | 14:49 |
| sjmc7 | :( mmm… maybe | 14:49 |
| TravT | ok, well, i'll look at that one now | 14:49 |
| sjmc7 | i’ll see if i can untangle them | 14:49 |
| sjmc7 | maybe i can pull out the network event one into a separate patch | 14:50 |
| TravT | well, however you want to handle it. | 14:51 |
| sjmc7 | i want to forget about everything and go back to sleep :) | 14:51 |
| TravT | that sounds like a reasonable plan | 14:52 |
| TravT | i'll brb | 14:52 |
| sjmc7 | i can probably extract the network event one. i don’t want to switch the dependency order, i’ll screw something up | 14:52 |
| TravT | well, i can just review it as a single patch right now. | 14:52 |
| sjmc7 | i think adding the event will be reasonably easy, one sec | 14:53 |
| TravT | ok | 14:53 |
| sjmc7 | the subnets one can be reviewed though | 14:53 |
| sjmc7 | it won’t change anything there | 14:53 |
| TravT | well, i'll be back in a few minutes anyway. | 14:53 |
| sjmc7 | ok | 14:53 |
| sjmc7 | gonna submit the network update as a separate patch, it was lazy bundling it with that one and it’s a small change | 14:59 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add network.update.end event https://review.openstack.org/295343 | 15:10 |
| sjmc7 | i’ll rebase the subnet patch on ^ | 15:11 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add neutron subnets and routers https://review.openstack.org/293771 | 15:21 |
| sjmc7 | when you’ve got a sec, TravT , have you had problems searching status fields in the UI? we store them as not_analyzed so that where they’re things like IN_PROGRESS you can have exact matches | 15:27 |
| sjmc7 | but because they tend to be upper case, it might make searching awkward | 15:28 |
| TravT | umm... i don't know. I have been using the facets in the UI | 15:28 |
| sjmc7 | ok | 15:28 |
| TravT | i'll poke on it in a bit... just going through the update patch right now | 15:29 |
| TravT | this one only adds the event. | 15:29 |
| sjmc7 | yep | 15:30 |
| sjmc7 | short and sweet | 15:30 |
| TravT | but there is more data that in the events.json, which i think will come in the other patches. | 15:30 |
| TravT | networks.json. sorry | 15:30 |
| sjmc7 | i only added the network.update.end event in that patch | 15:30 |
| sjmc7 | i think? | 15:30 |
| sjmc7 | and changed the delete one so the ids matched up | 15:31 |
| TravT | i just mean i see more data in the payload than in the networks.json in that patch | 15:32 |
| TravT | http://pasteboard.co/2qXeCGc8.png | 15:32 |
| TravT | https://review.openstack.org/#/c/295343/1/searchlight/tests/functional/data/events/networks.json | 15:32 |
| sjmc7 | i think the test data i had was from the pre-dates-added neutron | 15:33 |
| TravT | right, note that tags are also there | 15:34 |
| TravT | but we have a separate bug on that | 15:34 |
| sjmc7 | yeah, that’s interesting. maybe we can map those now | 15:34 |
| TravT | so, i'm okay with adding the update event | 15:34 |
| TravT | and then updating all the mappings / fields in that other patch you have going. | 15:34 |
| sjmc7 | yeah | 15:35 |
| *** bpokorny has joined #openstack-searchlight | 15:49 | |
| *** lakshmiS has joined #openstack-searchlight | 15:50 | |
| *** itisha has joined #openstack-searchlight | 16:12 | |
| *** pcaruana has quit IRC | 16:25 | |
| *** TravT has quit IRC | 16:32 | |
| *** TravT has joined #openstack-searchlight | 16:33 | |
| sjmc7 | lakshmiS: the date fields will be in a later patch | 16:37 |
| sjmc7 | the network update one is just to add that event | 16:37 |
| lakshmiS | ah ok | 16:40 |
| sjmc7 | the field patch was starting to get a bit monstrous | 16:41 |
| lakshmiS | ok i will approve it with link to that patch as follow up bug | 16:44 |
| lakshmiS | TravT: neutron patch is good to go. | 16:47 |
| TravT | which one? | 16:47 |
| TravT | i'm looking at a couple now | 16:48 |
| lakshmiS | https://review.openstack.org/#/c/293771 | 16:48 |
| TravT | i also am looking at port visibility | 16:48 |
| lakshmiS | ok | 16:48 |
| TravT | sjmc7 lakshmiS sorry to come back to this | 16:48 |
| TravT | but why are ports not also visible if shared? | 16:49 |
| TravT | is that due to the policy thing? | 16:49 |
| TravT | because policy will restrict a shared network further? | 16:49 |
| sjmc7 | no, think it’s just general security | 16:49 |
| sjmc7 | it’d give you information about servers that you shouldn’t have | 16:49 |
| lakshmiS | i think the best answer i got is that ports should only visible to owner/tenant so that ip's are not showed to non tenant users | 16:50 |
| openstackgerrit | Merged openstack/searchlight: Add network.update.end event https://review.openstack.org/295343 | 16:50 |
| TravT | i'm just looking at search results in horizon and it is inconsistent with what you'll get if you look at networks tab vs search results for ports | 16:50 |
| lakshmiS | can you paste it | 16:51 |
| sjmc7 | ok. if you both can figure out what’s different that’d be helpful. i need to focus on adding these fields for another 30 minutes or so | 16:51 |
| sjmc7 | DHCP ports won’t be visible yet | 16:52 |
| TravT | it is the parent rbac query on shared | 16:52 |
| TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/neutron/ports.py#L78 | 16:53 |
| lakshmiS | TravT: hangout would be good to discuss | 17:03 |
| TravT | yeah, just a sec... looking through it | 17:03 |
| TravT | it is also related to admin or not | 17:03 |
| TravT | ok, i think i've figured it out. | 17:05 |
| TravT | as Admin, when logged into project dashboard i can see shared networks and their ports | 17:06 |
| TravT | http://pasteboard.co/2r304inG.png | 17:06 |
| lakshmiS | yes | 17:06 |
| TravT | as demo user, i can see admin network in list, but i can't see anything (subnets / ports) when it isn't shared http://pasteboard.co/2r3eY2c2.png | 17:07 |
| lakshmiS | which is correct | 17:07 |
| lakshmiS | oh wait | 17:07 |
| TravT | as demo user when it is shared, i can see subnets but not ports http://pasteboard.co/2r3lvfkK.png | 17:07 |
| lakshmiS | you are seeing a network as demo which is not shared by admin? | 17:07 |
| TravT | it seems that way | 17:08 |
| lakshmiS | is it external true? | 17:08 |
| lakshmiS | demo user can see a network if it was created in the same tenant or shared/external network from other tenant | 17:09 |
| TravT | let me see. | 17:10 |
| TravT | that might be the magic | 17:12 |
| TravT | http://pasteboard.co/2r3PFLe3.png | 17:12 |
| TravT | ok, when i make the external-test network non-external / non-shared then it doesn't show up from the project dashboard even when logged in as admin. | 17:14 |
| TravT | http://pasteboard.co/2r3WVgQO.png | 17:14 |
| sjmc7 | how about from the admin dash? | 17:15 |
| sjmc7 | the project dashboards still restrict by project | 17:16 |
| sjmc7 | regardless of access level - if the network’s not in the project you’re in you won’t see it | 17:16 |
| lakshmiS | thats correct | 17:17 |
| TravT | no | 17:18 |
| TravT | that's not what i'm seeing | 17:18 |
| lakshmiS | can you write your usecase. i will try it out | 17:19 |
| TravT | i thought i put that above | 17:19 |
| TravT | As demo user... | 17:19 |
| TravT | as demo user, i can see networks in the list if it is external. | 17:20 |
| lakshmiS | just to make sure since i can see the nonshared/nonexternal network from the admin/admin user | 17:20 |
| TravT | but i can't see subnets or ports | 17:20 |
| TravT | unless the network is shared. then i can see subnets, but not ports. | 17:21 |
| lakshmiS | good so far | 17:21 |
| TravT | if i am an admin, i can see ports | 17:21 |
| TravT | even when logged into project dashboard | 17:21 |
| TravT | for a different project than the network is owned by | 17:21 |
| TravT | but let me try it all out again as well. | 17:22 |
| openstackgerrit | Merged openstack/searchlight: Add neutron subnets and routers https://review.openstack.org/293771 | 17:22 |
| TravT | ok, here are two screenshots. | 17:25 |
| TravT | Admin logged into demo project viewing admin owned and shared network (can see ports): http://pasteboard.co/2r4yj1Nc.png | 17:25 |
| TravT | Demo user logged into demo project viewing same admin owned and shared network (cannot see ports, but can see subnets): http://pasteboard.co/2r4BoP8e.png | 17:25 |
| lakshmiS | and do you see a difference in how SL rbac allows it? | 17:29 |
| TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/neutron/ports.py#L78 | 17:29 |
| TravT | yes | 17:29 |
| TravT | add the searchlight panel to your horizon and you'll see that you only see project ports regardless of user logged in. | 17:30 |
| TravT | it seems that if admin user and parent network is shared then an OR could be added to that filter query | 17:31 |
| TravT | better put... | 17:31 |
| sjmc7 | you’re passing all_projects? | 17:31 |
| TravT | no. | 17:31 |
| TravT | this is not searchlight results. | 17:32 |
| TravT | please see the screenshots | 17:32 |
| sjmc7 | ok, sorry, i’ll butt out. file a bug once you’ve narrowed it down | 17:32 |
| TravT | i think i have narrowed it down. | 17:32 |
| TravT | it is kind of odd | 17:33 |
| TravT | let me see if horizon is passing all projects on the networks page | 17:33 |
| TravT | if admin | 17:33 |
| lakshmiS | wrapping my head around it | 17:33 |
| TravT | lakshmiS: yep it is including external networks: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/views.py#L50-L52 | 17:37 |
| TravT | Which calls this: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L616-L641 | 17:38 |
| TravT | which calls this: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L603 | 17:39 |
| TravT | but we need to run direct API calls to neutron to see what we get. | 17:40 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add missing neutron fields https://review.openstack.org/294733 | 17:48 |
| sjmc7 | ok, i’m done concentrating on that one. will take a look at the screenshots but i need to get something to eat | 17:48 |
| TravT | yeah, i'm going to grab some food here in just a minute too | 17:49 |
| sjmc7 | i’ve decided i can no longer keep more than one train of thought in my head at once :) | 17:49 |
| sjmc7 | back in twenty minutes or so | 17:50 |
| sjmc7 | the patch i just put up adds the date fields and description etc. tags will need to be a separate patch, it’s still a bit fiddly | 17:50 |
| *** TravT has quit IRC | 17:57 | |
| *** bpokorny has quit IRC | 18:00 | |
| *** preetika has joined #openstack-searchlight | 18:22 | |
| *** bpokorny has joined #openstack-searchlight | 18:22 | |
| lakshmiS | TravT: that was a really good catch. like you said, port rbac filter needs a "or" check for all shared networks, specifically "admin" user only. Again this is an issue in SL only when "all_projects" is false | 18:28 |
| lakshmiS | all_projects being true for all our testing scenario hid the bug. need to check for that combination going forward. | 18:31 |
| lakshmiS | brb after lunch | 18:31 |
| lakshmiS | forgot to mention. direct call to neutron cli returns the port for demoadmin user in a demo tenant for a nonshared/nonexternal network from "admin" tenant. so we need that filter | 18:44 |
| sjmc7 | someone’ll have to explain it to me in words a three year old would understand :) | 18:55 |
| *** TravT has joined #openstack-searchlight | 19:20 | |
| lakshmiS | ok i am back | 19:33 |
| lakshmiS | sjmc7: this is my understanding. let TravT correct it if it's different. Currently whey you set "all_projects": false in SL query, you don't see the port for a nonshared/nonexternal network if you query it with an admin id of a different tenant | 19:35 |
| lakshmiS | on horizon/neutron cli you can see the port for the same access | 19:35 |
| lakshmiS | for the above test i created a nonshard/nonexternal network in "admin" tenant with "admin" user | 19:37 |
| lakshmiS | with subnet | 19:37 |
| lakshmiS | for testing i created a demoadmin user in demo tenant with admin role | 19:37 |
| lakshmiS | on horizon/cli when you login as demoadmin in demo project you can see the port for that nonshared network. same is not true in SL | 19:38 |
| lakshmiS | hope i was able to explain myself ;) | 19:39 |
| *** TravT has quit IRC | 19:39 | |
| *** TravT has joined #openstack-searchlight | 19:39 | |
| TravT | lakshmiS i think that sounds like what i was seeing. | 19:40 |
| sjmc7 | ok. and the horizon behavior seems correct? | 19:41 |
| lakshmiS | yes since its same as neutron cli | 19:41 |
| TravT | i think so. i don't see any magic in horizon queries that would cause that to happen. i was just going to setup some direct neutron queries | 19:41 |
| TravT | the only magic is the external network... | 19:42 |
| sjmc7 | ok, can we do a hangout? i’m still confused | 19:42 |
| TravT | yes. let me reboot though. | 19:42 |
| TravT | my mac has developed a nasty habit of not recognizing any of my usb devices with no apparent cause. | 19:43 |
| TravT | so i lose external, mouse, keyboard, and headset. | 19:43 |
| *** TravT has quit IRC | 19:44 | |
| *** TravT has joined #openstack-searchlight | 19:45 | |
| lakshmiS | if a filter makes it easy to explain, here it is - http://paste.openstack.org/show/491348/ | 19:48 |
| sjmc7 | ok. and that only applies to admins? | 19:48 |
| TravT | lakshmiS: yes, i think that is what i was trying to say above. | 19:48 |
| *** pcaruana has joined #openstack-searchlight | 20:21 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Allow multiple plugins to handle an event https://review.openstack.org/295503 | 20:32 |
| *** akanksha_ has quit IRC | 20:47 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for showing port to admin users in non-tenant https://review.openstack.org/295523 | 21:17 |
| sjmc7 | lakshmiS, TravT - i don’t think we can index the DHCP port :( the only notifications we get are based on the subnet, and the port seems to be updated after that notification is received in many cases | 21:33 |
| sjmc7 | i’ve filed a bug with neutron | 21:33 |
| TravT | ok | 21:33 |
| TravT | did you get a chance to file a bug on the missing tags? | 21:33 |
| lakshmiS | ok | 21:33 |
| sjmc7 | with neutron? no, will do though | 21:34 |
| sjmc7 | i think the chance of getting either dealt with are approximately zero for mitaka | 21:34 |
| TravT | probably | 21:34 |
| sjmc7 | i think i’d have to put a sleep(2) or something in to deal with creation, and do something even worse for deletion and i’m not sure it’s worth it | 21:35 |
| *** lakshmiS has quit IRC | 21:36 | |
| openstackgerrit | Rick Aulino proposed openstack/searchlight: Re-indexing optimization for doc_type https://review.openstack.org/295538 | 21:49 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Allow multiple plugins to handle an event https://review.openstack.org/295503 | 22:03 |
| *** pcaruana has quit IRC | 22:06 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
| *** bpokorny has quit IRC | 22:25 | |
| *** bpokorny has joined #openstack-searchlight | 22:31 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Simple Script for Generating Resources https://review.openstack.org/230697 | 22:34 |
| *** lakshmiS has joined #openstack-searchlight | 22:36 | |
| *** bpokorny has quit IRC | 22:37 | |
| *** preetika has quit IRC | 22:37 | |
| lakshmiS | sjmc7: saw your comment on the bug in launchpad. Either i don't understand it or not able to recreate the problem | 22:54 |
| lakshmiS | for clarity to myself i tried same on my vm : http://paste.openstack.org/show/491371/ | 22:55 |
| lakshmiS | a non-tenant non-admin user is able to see subnet from a shared network | 22:55 |
| lakshmiS | what am i doing differently? | 22:56 |
| sjmc7 | i think i was wrong | 22:57 |
| sjmc7 | external versus shared? | 22:57 |
| sjmc7 | i’m going mad | 22:57 |
| lakshmiS | external is tricky | 22:58 |
| sjmc7 | yeah, i think it was my mistake | 22:59 |
| lakshmiS | np. anyway i will try to add as much as info possible in the port and subnet plugin in the same patch | 23:00 |
| sjmc7 | yeah, maybe add a comment. i just tested it and the functionality looks good. maybe a functional test as well if you have a chance | 23:02 |
| *** openstackgerrit has quit IRC | 23:03 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:03 | |
| *** openstackgerrit has quit IRC | 23:03 | |
| *** openstackgerrit_ has joined #openstack-searchlight | 23:04 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:04 | |
| *** openstackgerrit_ has joined #openstack-searchlight | 23:09 | |
| openstackgerrit | Merged openstack/searchlight: Allow multiple plugins to handle an event https://review.openstack.org/295503 | 23:16 |
| *** bpokorny has joined #openstack-searchlight | 23:41 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Simple Script for Generating Resources https://review.openstack.org/230697 | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
