Friday, 2020-04-17

*** ricolin has joined #openstack-sdks01:14
*** dayou has quit IRC01:38
*** dayou has joined #openstack-sdks01:47
*** ttsiouts_ has joined #openstack-sdks03:31
*** ttsiouts has quit IRC03:34
*** evrardjp has quit IRC04:37
*** evrardjp has joined #openstack-sdks04:37
*** dayou has quit IRC05:10
*** vishakha has quit IRC05:10
*** mnasiadka has quit IRC05:10
*** dayou has joined #openstack-sdks05:15
*** vishakha has joined #openstack-sdks05:15
*** mnasiadka has joined #openstack-sdks05:15
*** dayou has quit IRC05:54
*** dayou has joined #openstack-sdks05:55
*** gtema has joined #openstack-sdks06:49
*** yolanda has quit IRC06:59
*** yolanda has joined #openstack-sdks07:00
*** nightmare_unreal has joined #openstack-sdks07:02
*** slaweq has joined #openstack-sdks07:11
*** rpittau|afk is now known as rpittau07:19
*** jpena|off is now known as jpena07:22
*** tosky has joined #openstack-sdks07:30
*** ralonsoh has joined #openstack-sdks07:38
*** jpich has joined #openstack-sdks07:39
*** gtema has quit IRC07:51
iurygregorymordred, hey o/ good morning (not sure if you are awake) re your comment in https://review.opendev.org/#/c/718746/1/openstack/baremetal/v1/_proxy.py you wanted to be volume_connectors only for that function since is the one to list correct?07:59
*** ttsiouts_ has quit IRC08:11
*** dtantsur|afk is now known as dtantsur08:13
*** gtema has joined #openstack-sdks08:18
*** ttsiouts has joined #openstack-sdks08:21
iurygregoryhey everyone locally I'm trying to run tox -r -vv -e docs for openstacksdk using the master and it's failling any tips?08:26
*** gtema has quit IRC08:29
*** gtema has joined #openstack-sdks08:30
amotokiiurygregory: it is caused by sphinx 3.0. If you would like to get the rendered documents, you can avoid the error with sphinx <3.08:35
AJaegeris anybody looking into it or shall I?08:37
amotokiAJaeger: I don't know someone is looking into it. I just confirmed it locally but I have something other to do right now.08:38
AJaegerjust noticed the logs - that's not one of the usual errors;( I'll check for 5 mins or so.08:39
gtemaI was having to fight downstream with those issues and can prepare fix for SDK docs for support of Sphin >=3.0, but this is quite a lot08:40
AJaegergtema: that would be appreciated!08:40
gtemaok, taken on my FIFO todo08:41
AJaegerthanks08:41
*** ttsiouts has quit IRC08:47
iurygregoryamotoki, i have some high priorities atm >.< otherwise I would be happy to help08:49
*** tkajinam has quit IRC08:51
*** ttsiouts has joined #openstack-sdks09:00
dtantsurwho could approve this simple patch please? https://review.opendev.org/#/c/717737/09:03
dtantsuramotoki, mordred ^^09:03
amotokidtantsur: sure09:03
*** ttsiouts has quit IRC09:16
*** yolanda has quit IRC09:23
*** yolanda has joined #openstack-sdks09:29
openstackgerritDmitry Tantsur proposed openstack/osc-lib master: Remove Babel from requirements  https://review.opendev.org/71773709:29
dtantsuramotoki: updated ^^09:29
amotokidtantsur: thanks. I read thru the translation handling scripts again :)09:30
gtemaamotoki, i placed my + there also. If you find ok let's do +A09:32
*** ttsiouts has joined #openstack-sdks09:39
*** yolanda has quit IRC10:10
openstackgerritMerged openstack/python-openstackclient master: Add resource option immutable  https://review.opendev.org/71526910:25
*** rpittau is now known as rpittau|bbl10:30
*** gtema has quit IRC10:34
*** gtema has joined #openstack-sdks10:35
*** ttsiouts has quit IRC10:49
*** ttsiouts has joined #openstack-sdks10:50
openstackgerritMerged openstack/openstacksdk stable/rocky: Add ansible collection job to rocky branch  https://review.opendev.org/71407911:35
openstackgerritMerged openstack/openstacksdk stable/rocky: Add tests for Ansible built-in modules in 2.8,2.9  https://review.opendev.org/71408611:35
*** jpena is now known as jpena|lunch11:37
*** tkajinam has joined #openstack-sdks11:56
AJaegerhere's a change for os-client-config to cleanup py27 support, please review https://review.opendev.org/#/c/717609/12:00
AJaegerand a similar one for service-types-authority, please: https://review.opendev.org/71918312:00
AJaegermordred: can you help, please? ^12:00
dtantsurAJaeger: there is a question re 3.5 on the first of them12:01
dtantsurI remember discussing it on another patch, but I don't remember the resolution12:01
openstackgerritAndreas Jaeger proposed openstack/os-client-config master: Cleanup py27 support  https://review.opendev.org/71760912:04
*** tkajinam has quit IRC12:04
AJaegerdtantsur: I followed your suggestion - as long as shade is testing 3.5, we need 3.5 in there...12:05
dtantsurthanks!12:06
*** gtema has quit IRC12:10
*** ttsiouts has quit IRC12:12
openstackgerritDmitry Tantsur proposed openstack/python-openstackclient master: Move Babel to test-requirements  https://review.opendev.org/72070112:15
dtantsurnot sure if even test-requirements is needed ^^^12:16
*** rpittau|bbl is now known as rpittau12:19
*** mgariepy has joined #openstack-sdks12:24
openstackgerritMerged openstack/service-types-authority master: Cleanup py27 support  https://review.opendev.org/71918312:24
*** enriquetaso has joined #openstack-sdks12:24
*** ttsiouts has joined #openstack-sdks12:42
*** gtema has joined #openstack-sdks12:43
*** jpena|lunch is now known as jpena12:44
*** gtema has quit IRC12:47
*** gtema has joined #openstack-sdks12:47
*** ttsiouts has quit IRC12:48
*** dayou has quit IRC13:23
*** ttsiouts has joined #openstack-sdks13:23
*** dayou has joined #openstack-sdks13:27
*** gtema_ has joined #openstack-sdks13:30
*** ttsiouts has quit IRC13:32
*** ttsiouts has joined #openstack-sdks13:32
*** dayou has quit IRC13:33
*** gtema has quit IRC13:33
*** dayou has joined #openstack-sdks13:33
openstackgerritDmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements  https://review.opendev.org/72070113:38
dtantsurupdated with the recent findings ^^^13:38
*** ttsiouts has quit IRC13:49
*** ttsiouts has joined #openstack-sdks14:06
*** dtantsur is now known as dtantsur|brb14:09
*** ttsiouts has quit IRC14:31
*** ttsiouts has joined #openstack-sdks14:36
*** ttsiouts has quit IRC14:48
AJaegerwho's reviewing shade? Here's a change to update the jobs which we need to move forward with py27 drop, please review https://review.opendev.org/#/c/718068/14:49
*** ttsiouts has joined #openstack-sdks14:50
openstackgerritMonty Taylor proposed openstack/shade master: Update master for stable/ussuri  https://review.opendev.org/71902114:54
openstackgerritMonty Taylor proposed openstack/shade master: Add Python3 victoria unit tests  https://review.opendev.org/71902214:55
mordredAJaeger: done!14:55
AJaegerthanks, mordred14:58
openstackgerritAndreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support  https://review.opendev.org/72074215:00
*** dtantsur|brb is now known as dtantsur15:03
openstackgerritSean McGinnis proposed openstack/shade master: Declare py38 support  https://review.opendev.org/72074615:07
*** gtema_ has quit IRC15:18
*** ricolin has quit IRC15:19
openstackgerritDmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements  https://review.opendev.org/72070115:31
openstackgerritDmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements  https://review.opendev.org/72070115:32
dtantsurlower-constraints is quite a fragile thing15:33
AJaegerdtantsur: it's not working as designed IMHO15:40
dtantsurto me we should only list direct dependencies in lower-constraints.txt15:41
dtantsurbut I seem to be alone in that15:41
AJaegerdtantsur: Let me write up something...15:41
AJaegerdtantsur: will take a bit, I need an example15:44
dtantsurdepending on what you need, I may be able to help15:47
smcginnisShould be able to AND the packages between lower-constraints.txt and (requirements.txt and test-requirements.txt).15:51
smcginnisI think Doug's original reasoning for having other packages was to be able to test all other dependencies too.15:52
dtantsurfor me it's very problematic every time the list is updated15:53
dtantsurif we include indirect dependencies (like babel now)15:53
dtantsurI can go back to putting babel in lower-constraints15:53
dtantsurwhatever is better15:53
smcginnisYeah, personally I would prefer to only enforce our direct dependencies too.15:53
smcginnisAnd trust that they are not installing their own dependencies unconstrained (which actually probably is a risky assumption).15:54
AJaegerThe problem is: We install package X in version 0.1, then package Y needs X in version 0.2 - and pip -U installs that ;( I need to dig out an example, this is happening often.15:56
dtantsuris it a problem though?15:58
dtantsurI thought the goal was to verify our minimum caps15:58
dtantsurso that e.g. we don't put requests>=1.0 but use features from 1.215:59
dtantsurindirect dependencies are not used directly, so it makes no sense for them?15:59
openstackgerritMerged openstack/shade master: Break out py27 job templates  https://review.opendev.org/71806815:59
openstackgerritMerged openstack/shade master: Update master for stable/ussuri  https://review.opendev.org/71902115:59
*** dustinc has joined #openstack-sdks16:00
AJaegerdtantsur: yes, if you change one line, everything blows up as you noticed16:01
smcginnisAJaeger: That may be the reason for inclusing our indirect dependencies in there - to make sure that scenario doesn't happen my locking down everything and make sure we always get the versions we expect to get.16:01
smcginnis*including16:01
AJaegersmcginnis: but we don't - I need an example, give me somem time, please16:02
AJaegerAnd then let's discuss whether I'm right or not...16:02
dtantsursmcginnis: the other way around. if you include all dependencies, any change will likely cascade.16:02
dtantsurif you only include direct dependencies, you'll get into trouble only if your minimum cap conflicts with some other.16:03
smcginnisdtantsur: Yes, but that would be by design, right?16:03
dtantsurnot sure16:03
dtantsurI see the goal of lower-constraints differently16:03
smcginnisIf we want a definitive set of requirement minimums that can be used, we need to be explicit about everything that gets installed to be able to verify it actually works.16:03
dtantsurI only care about direct dependencies because that's what we (in a project) control16:04
*** enriquetaso has quit IRC16:04
*** senrique_ has joined #openstack-sdks16:05
dtantsurlike, in this case I have to care that something else is using babel and pytz. I don't think I should.16:05
smcginnisBut like Andreas pointed out, if we say we want version 1.0, but then an indirect dependency raises that to 2.0, we aren't actually capturing (or at least validating) what our minimum version of that lib should be.16:05
dtantsursmcginnis: in this case the job will fail and we'll know :)16:06
dtantsurthat's literally what happened with my patch16:06
smcginnisI'm probably missing some context. Which patch is this?16:06
dtantsursmcginnis: tl;dr I've uncapped babel and it got pulled again down the road with a conflicting pytz requirement16:06
smcginnisYeah, so that points to the reason for why lower-constraints should have packages that are not in requirements and test-requirements.16:07
smcginnisIt needs to control the full environment.16:08
dtantsurfor me it points to the opposite thing :)16:08
dtantsurI don't need this control. As a developer I don't care about it.16:08
dtantsurMaybe we see the goals of lower-constraints differently?16:08
dtantsurFor me it's only to verify that we don't violate our minimum caps16:08
smcginnisBut going the route you are advocating, you've just pointed out that causes problems. :)16:09
dtantsurit caused a problem because we also capped pytz16:09
dtantsurwhich wasn't a direct dependency either16:09
dtantsuror maybe it's too late for me to think clearly :)16:10
smcginnisThe reason we have it in l-c is because it is an indirect dependency that of not constrained will install a different and potentially conflicting version like you are saying.16:11
AJaegersmcginnis: is lower-constraitns documented somewhere?16:11
smcginnisSo even if we use neither babel nor pytz directly, having them in l-c will force the exact versions to be installed and avoid conflicts like that.16:12
*** ttsiouts has quit IRC16:12
dtantsursmcginnis: okay, I remembered why we stopped doing it in ironic, I think. It's fine while it works, but every time you need to update something, it's a cascading nightmare.16:12
smcginnisAJaeger: I'm not really sure. I remember when Doug was working on it, and he had to explain some of the reasoning for the approach to me a few times, but I don't recall reading a spec or anything like that.16:12
dtantsuranyway, if people feel I should keep Babel in lower-constraints, I can do it16:13
dtantsurjust let me know16:13
smcginnisdtantsur: Well, again, you can argue that's by design. If you change one thing, then you have to expect there may be other packages that will also need to be raised.16:13
dtantsurit's not unreasonable, I just've never looked at it this way16:13
*** jpich has quit IRC16:13
smcginnisThe exercise being to find what the new lowest set of requirements are that should be expected to work.16:14
AJaegerI found https://docs.openstack.org/project-team-guide/dependency-management.html16:14
openstackgerritDmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements  https://review.opendev.org/72070116:15
dtantsurupdated ^^16:15
*** dtantsur is now known as dtantsur|afk16:16
*** rpittau is now known as rpittau|afk16:17
*** dtruong has quit IRC16:33
*** dtruong has joined #openstack-sdks16:34
AJaegersmcginnis, dtantsur|afk https://etherpad.opendev.org/p/S_6OvGeqCniK5CLVxIan is what I found out so far.16:35
AJaegerSo, lower-constraints might be working correctly - but we're usingn it in a broken way ;(16:35
AJaegerWith removing install_command suddenly you open pandora's box since none of the requirements is correct anymore ;(16:35
*** evrardjp has quit IRC16:37
*** evrardjp has joined #openstack-sdks16:37
AJaegerI'll send this out as an email...16:40
*** nightmare_unreal has quit IRC16:44
openstackgerritAndreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support  https://review.opendev.org/72074216:46
openstackgerritMerged openstack/shade master: Add Python3 victoria unit tests  https://review.opendev.org/71902216:52
smcginnisAJaeger: Thanks for sending that. I've seen a few projects fix that over the last several months, but I'm sure there are probably several more that are still doing that wrong.16:53
*** ttsiouts has joined #openstack-sdks17:04
openstackgerritMerged openstack/osc-lib master: Remove Babel from requirements  https://review.opendev.org/71773717:12
AJaegersmcginnis: too many repos ;(17:34
*** jpena is now known as jpena|off17:40
*** ralonsoh has quit IRC17:53
*** ttsiouts has quit IRC18:14
*** ttsiouts has joined #openstack-sdks19:26
*** ttsiouts has quit IRC19:47
*** ttsiouts has joined #openstack-sdks19:47
*** gtema has joined #openstack-sdks19:53
*** gtema has quit IRC20:01
*** dustinc has quit IRC20:29
openstackgerritMerged openstack/os-client-config master: Cleanup py27 support  https://review.opendev.org/71760920:42
AJaegersmcginnis: coming back to our discussion, the project-team-guide does not talk about adding all dependencies, it only talks about the direct requirements, doesn't it? Updating it becomes really tricky in my experience: You increase one version, that needs further updates, that need further...21:05
AJaegerTo me it looks like we're not mastering lower-constraints yet...21:05
AJaegersorry, enough on that - need to leave now...21:05
smcginnisAJaeger: Have a good weekend!21:10
smcginnisMaybe we can invoke Doug for more background. The concepts behind this were probably lost due to not having openstack-specs anymore. Or at least some other good place to write it all down.21:11
openstackgerritMerged openstack/python-openstackclient master: Use unittest.mock instead of third party mock  https://review.opendev.org/71741021:37
*** ttsiouts has quit IRC21:56
*** gtema has joined #openstack-sdks21:57
*** gtema has quit IRC22:02
*** mgariepy has quit IRC22:06
*** ttsiouts has joined #openstack-sdks22:43
*** ttsiouts has quit IRC22:52
*** senrique_ has quit IRC23:13
*** tosky has quit IRC23:21
*** gtema has joined #openstack-sdks23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!