Monday, 2020-01-13

*** slaweq has joined #openstack-sdks00:10
*** slaweq has quit IRC00:15
*** jistr has quit IRC00:45
*** jistr has joined #openstack-sdks00:48
*** slaweq has joined #openstack-sdks01:22
*** slaweq has quit IRC01:27
*** camelCaser has quit IRC02:33
*** camelCaser has joined #openstack-sdks02:33
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-sdks05:34
*** Luzi has joined #openstack-sdks06:35
*** jawad-axd has joined #openstack-sdks07:02
*** jawad-axd has quit IRC07:06
*** slaweq has joined #openstack-sdks07:07
*** jawad-axd has joined #openstack-sdks07:07
*** jawad-ax_ has joined #openstack-sdks07:10
*** jawad-axd has quit IRC07:12
*** slaweq has quit IRC07:12
*** slaweq has joined #openstack-sdks07:16
*** ralonsoh has joined #openstack-sdks07:29
openstackgerritVishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli
*** gtema has joined #openstack-sdks08:22
*** tosky has joined #openstack-sdks08:22
*** gtema has quit IRC08:26
*** jangutter has joined #openstack-sdks08:33
*** jpena|off is now known as jpena08:47
*** gtema has joined #openstack-sdks09:01
*** gtema has quit IRC09:02
*** jpich has joined #openstack-sdks09:06
*** gtema has joined #openstack-sdks09:08
openstackgerritBence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route
*** jawad-ax_ has quit IRC10:07
*** gtema has quit IRC10:20
*** jpich has quit IRC10:24
*** jpich has joined #openstack-sdks10:25
*** dtantsur|afk is now known as dtantsur10:32
*** jawad-axd has joined #openstack-sdks10:49
*** gtema has joined #openstack-sdks10:52
gundalowsshnaidm: Hi, I'm back now :)10:52
*** jawad-axd has quit IRC10:53
*** gtema has quit IRC11:04
sshnaidmgundalow, welcome back!11:05
sshnaidmgundalow, will you be available this week for helping with ansible bits of moving OS modules?11:10
gundalowSure, is there a doc where we are listing the steps?11:11
sshnaidmgundalow, I think we can use our etherpad for that:
*** jawad-axd has joined #openstack-sdks11:14
*** gtema has joined #openstack-sdks11:19
gundalowsshnaidm: perfect, thank you. Could you remind me if we decided on 1) namespace 2) Collection name 3) Host repo11:21
sshnaidmgundalow, updated in etherpad11:28
*** jpich has quit IRC11:40
*** jpich has joined #openstack-sdks11:43
*** gtema has quit IRC12:17
*** gtema has joined #openstack-sdks12:18
*** enriquetaso has joined #openstack-sdks12:21
*** jpena is now known as jpena|lunch12:23
*** gtema has quit IRC12:23
*** gtema has joined #openstack-sdks12:31
sshnaidmgundalow, I'd like to send a mail to Ansible devs/cores to ask them not to merge patches to OS modules w/o exceptional ack from specific OS cores. Where can I send it to?12:43
sshnaidmgundalow, because we want to freeze them in current state now12:44
*** adriant has quit IRC12:48
*** adriant has joined #openstack-sdks12:49
*** gtema has quit IRC13:08
*** jpena|lunch is now known as jpena13:22
*** gtema has joined #openstack-sdks13:30
*** KeithMnemonic has joined #openstack-sdks13:59
*** Luzi has quit IRC14:12
gundalowhum, Ansibulbot will also automerge. I wonder if we can somehow make the PRs fail CI14:53
*** jawad-axd has quit IRC15:27
*** dave-mccowan has joined #openstack-sdks15:47
sshnaidmgundalow, I think we can, need just to configure openstack job to fail always, but also I'd like to make people aware about it15:51
sshnaidmgundalow, do you have kind of "ansible-dev" list..?15:51
*** dave-mccowan has quit IRC15:52
KeithMnemonicam i reading this failure correctly, that it also due to the thread on openstack-discuss about setuptools and python2?
dtantsurKeithMnemonic: everything is broken, yes. the infra team is about to work it around though.16:25
mordredshould be fixed now16:34
KeithMnemonicthanks mordred. Does anyone have any objections for me starting the cherry-pick to stein on this change while I am waiting for a WF+1? ? That way i can start seeing if there are other issues on stable/stein.16:45
KeithMnemonicor would you prefer i wait until it merges16:45
mordredKeithMnemonic: go for it! stein has been a little shaky recently, so might as well go ahead and make sure things work16:48
KeithMnemonicthanks morded16:49
KeithMnemonicargh mordred: :-)16:50
*** icarusfactor has quit IRC16:55
dtantsurnote that if you press the cherry-pick button now, the patch will be missing the required "cherry picked from" line16:55
KeithMnemonicgot it thanks, there is a merge conflict so i need to do it by hand anyway16:55
*** jpich has quit IRC17:02
*** yolanda has quit IRC17:15
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Add unit tests and release note for dns_publish_fixed_ip
*** gtema_ has joined #openstack-sdks17:26
*** gtema has quit IRC17:30
*** jawad-axd has joined #openstack-sdks17:33
*** evrardjp has quit IRC17:33
*** evrardjp has joined #openstack-sdks17:34
*** dtantsur is now known as dtantsur|afk17:53
*** gtema_ has quit IRC18:02
*** jawad-axd has quit IRC18:04
*** jpena is now known as jpena|off18:06
openstackgerritMerged openstack/python-openstackclient master: Raise hacking to more recent 2.0.0
openstackgerritMerged openstack/python-openstackclient master: Raise flake8-import-order version to latest
*** gtema has joined #openstack-sdks18:36
*** gtema has quit IRC18:41
*** jawad-axd has joined #openstack-sdks18:45
*** gtema has joined #openstack-sdks18:51
*** jawad-axd has quit IRC19:00
efriedjohnsom: Before I go digging, can you remind me where we are on the osc-lib business that was holding up ?19:03
efriedlooks like is still open.19:04
johnsomefried This is stuck:
johnsomOn this:
efriedjohnsom: is it just that we need the latter approved before the former can pick it up properly?19:05
johnsomI think so, but it has been a long time, so the details are fuzzy19:05
*** gtema has quit IRC19:07
efriedjohnsom: Can we swap back in? Cause off the top I'm not sure I understand how needing should hold up
johnsomefried Yeah, the whole issue was the addition of "enhanced_help" you did. It broke other pending patches and is a bit of an oddity. So, the discussion was if we revert the "enhanced_help" change or if we move forward with it and add it to osc-lib.19:14
efriedjohnsom: but how does that relate to autogenerating docs for identity?19:14
johnsomefried if we reverted, this should not merge either19:14
johnsomefried that patch drops the versioning callout on the --tag options19:16
efriedtbc, ...31 doesn't do anything with enhance_help. If we revert that, we would have to revert down that (already merged) series as well.19:16
efriedif my delta makes the versioning of --tags wrong, that's its own issue.19:16
johnsomIt was a pretty nasty mess as I remember19:16
efriedjohnsom: I'm rechecking to get a new docs build to be sure, but looking at the code, it should be the case that we're only adding the docs for --tags to the v3 doc.19:19
johnsomIt looks like Dean was ok with moving forward with the "enhanced_help" path, but it looks like the cores never confirmed that19:19
efriedwhich is what we want to do.19:19
efriedjohnsom: "the cores" would be... Dean.19:19
johnsomlol, well19:19
efriedI think dtroyer was waiting for you to confirm that that solution would work for you.19:20
efriedbefore +2ing19:20
johnsomThere are five folks on the list, but yeah, I understand this area is lacking at the moment19:20
efriedI actually can't tell who's core in osc-lib19:21
efriedis it python-openstackclient-core?19:21
efriedin which case we really only have three: mordred, dtroyer, amotoki19:21
efriedMatt is gone, and Doug hasn't been active there for a while.19:21
johnsomSo maybe Dean is around and we can just get that osc-lib change rolling19:22
efriedjohnsom: so let me propose this: If the docs build confirms that --tags only show up in the v3 docs and not in the v2 docs, will you unblock the identity patch? Then we can decide whether to revert the enhance_help business -- in which case we'll need to do *something* else to fix that whole stack -- or approve the osc-lib patch, whereupon can be vetted to make sure it subsumes identity etc.19:23
johnsomI would really like to see a path forward on the centralized tags code before we merge another patch that changes the way we document / handle tags.19:24
efriedI get that, but my point is that that ship has already sailed19:25
johnsomThat change was pretty big breakage on an already half merged migration19:25
efriedFor that I apologize; I didn't know that change was in flight, and I was on a (totally unrelated) mission.19:25
efriedthat said, this kind of conflict is pretty standard fare for this kind of development19:26
johnsomYeah, I get it.19:26
openstackgerritMerged openstack/python-openstackclient master: Add dns_publish_fixed_ip attribute to subnets
openstackgerritMerged openstack/python-openstackclient master: Remove redundant OpenStackShell.prepare_to_run_command
johnsomThis is the tie-in with the identity stuff BTW:
efriedgot it19:32
efriedmordred: you willing to be the second core on this?19:35
efriedwhere "this" is: enhancing osc-lib's handling of --tag options to accept a callable so it can be decorated as pertaining to only a specific version of the API?19:36
efriedjohnsom: actually, wouldn't it only matter if add_project_domain_option_to_parser had *also* been added to osc-lib? (afaict it wasn't)19:39
efriedAnd that guy is using enhance_help to decorate the help as pertaining only to neutron (as opposed to a particular version)19:41
johnsomWasn't this all because you didn't want to fix the code structure to deal with the mixed neutron/nova commands?19:42
efriedthat's where it started, yes.19:43
johnsomThe new docs system can't handle the current method and some projects were using static pages.19:43
efriedwhere "fix the code structure" would have entailed splitting neutron and nova-network classes into 100% separate packages, like what we see for identity19:44
*** sshnaidm is now known as sshnaidm|bbl19:45
efrieddoing all of this -- enhance_help in python-openstackclient and osc-lib and reworking your change -- is still an order of magnitude less effort than that would be.19:46
efriedArguably "the right thing", but... 80/20 rule.19:46
johnsomYeah, and I agreed that I can live with that, we just need to commit to it or revert IMO19:47
efriedthat's fine, but I still don't agree that that should hold up (and its successor) which have nothing to do with enhance_help19:49
efriedBut that's your prerogative. So let's just push on dtroyer mordred amotoki to merge so we can move forward.19:50
johnsomWell, once the docs re-render maybe we can look at the changes and issues that related them. I think that if we revert, we will want to stick with the static pages until a new path forward is found19:50
efriedThe identity patch wouldn't be affected by that, though.19:52
efriedthe fact that there's an enhance_help in an identity lib is coincidental; it's only used by networking.19:52
efriedthat method is called in a hundred other places, but the enhance_help kwarg is only used from networking19:52
efriedso whichever approach we choose, the identity docs split/autogen patch wouldn't be different.19:52
* dtroyer starts catching up after lunch…20:02
efrieddtroyer: tl;dr:20:04
efriedYou +2ed the glance doc autogen patch and wondered why it hadn't been approved earlier20:04
efriedI mentioned its predecessor was held up20:04
efriedSo I was discussing with johnsom whether that holdup was valid20:04
efriedBut whether it is or not, we would like to move the osc-lib enhance_help patch along20:04
dtroyerefried: right, I figured that was the case (after I looked at them in the wrong order).  I'm getting to going ahead with merging 693267, but having to do something like this is a clue that maybe we should just copy that code instead now.   DRY is good, until it isn't, and OSC has taught me that sometimes the duplication is work it in the end…  thoughts to inform the future, I think we're going to finish this path at least for now20:09
efrieddtroyer: ack, and thanks.20:11
efriedto be clear, which piece would duplication have been better for in this scenario?20:11
dtroyerwith the changes to help, I would have re-thought moving the tags stuff to osc-lib in the first place.  In this case though that is being done to make it available to plugins… there is a school of thought that it is the plugins that should be eliminated so that would be an alternative someday20:14
dtroyerI just +W, we'll need to do an osc-lib release so OSC can pick that up.20:16
efriedgotcha. Thanks. johnsom ^20:17
*** ralonsoh has quit IRC20:34
johnsomSorry, had a meeting, catching up20:35
johnsomdtroyer Yeah, I think in the case of tags, it's a good thing that, plugins or not, we are using common code for tags. This is an area that is easy to start diverging in the commands.... This was part of why I proposed moving it into osc-lib and volunteered to do the work.20:37
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Add unit tests and release note for dns_publish_fixed_ip
*** enriquetaso has quit IRC21:17
KeithMnemonicsmcginnis: it passed! first hurdle done21:26
openstackgerritMerged openstack/osc-lib master: Add enhance_help kwarg to tags option generators
*** sshnaidm|bbl is now known as sshnaidm22:02
*** slaweq has quit IRC22:12
efriedsmcginnis: Did we decide the first release after dropping py2 needs to be a 'major'?22:17
efriedjohnsom, dtroyer: <== osc-lib 2.0.0 release (smcginnis assumed ^ yes)22:21
johnsomYes, dropping py2 is a major bump22:22
smcginnisefried: Sorry - correct, that's considered a backwards incompatible change and needs the major version bump.22:23
efriedcool, thanks.22:23
*** camelCaser has quit IRC22:24
johnsomThere should have been a release note for the py2 drop as well, but it doesn't look like that happened22:24
*** camelCaser has joined #openstack-sdks22:27
efriedjohnsom: Doesn't need to be a separate release. I incorporated it in the same patch. smcginnis: is there any reason the first release after dropping py2 needs to be immediately after that patch?22:28
efriedjohnsom: in other news, the new build for is available. I linked to the 'project' subcommand pages, please confirm whether the presence/absence of --tag is appropriate there.22:29
smcginnisefried: You mean if it should be released right away after making the changes in the cycle goal versus waiting for a bit and picking up some other changes?22:30
efriedsmcginnis: yes, that's what I mean.22:30
smcginnisNo, no real reason to have to do it right away.22:30
smcginnisOf course the sooner it's out there, the sooner others will pick it up and find out if there are any issues, but no reason that has to happen immediately.22:30
efriedOr rather, in this case, given that other changes are already available, should I force an artificial major release in between so I can immediately push a 2.1.0 for the subsequent feature?22:30
efriedack, so I think we're good here.22:31
johnsomYeah, release often is good actually.22:31
openstackgerritMerged openstack/python-openstackclient master: Create Volume v3 functional tests
smcginnisYeah, it's fine if there are other feature additions along with the py2 drop.22:31
smcginnisThe major bump is just a signal to downstream consumers of "hey, might want to check what changed here before you upgrade to this one" ;)22:31
johnsomI was just mentioning (not earth shattering) that there is no release note with the "Drop python 2.7 support and testing " patch in
smcginnisThat really should be included.22:32
efriedmm. We could add a patch for that and include it in the release...22:32
smcginnisWe can hold that release and quick get a release note added.22:32
openstackgerritEric Fried proposed openstack/osc-lib master: Add a release note for dropping py2
efrieddtroyer, smcginnis, johnsom: ^22:35
johnsomefried You are working on too many things... grin  Commented22:35
efriedjohnsom: just trying to flush some stuff off my stack.22:36
openstackgerritMichael Johnson proposed openstack/osc-lib master: Add a release note for dropping py2
efriedwhat did I miss?22:38
johnsomYou said "nova" instead of "osc-lib"22:38
efriedhah, whoops22:38
efriedthanks, blind copy/paste22:38
efrieddtroyer: ^ fast one if you please22:39
openstackgerritSean McGinnis proposed openstack/python-openstackclient master: Copy Volume v2 commands and unit tests to v3
*** tosky has quit IRC23:06

Generated by 2.15.3 by Marius Gedminas - find it at!