Tuesday, 2019-06-04

*** markvoelker has quit IRC00:24
*** bobh has joined #openstack-sdks00:58
*** ttsiouts has joined #openstack-sdks01:00
*** ttsiouts has quit IRC01:06
openstackgerritEric Fried proposed openstack/openstacksdk master: Support Proxy-specific region_name  https://review.opendev.org/66286501:49
*** bobh has quit IRC01:54
*** whoami-rajat has joined #openstack-sdks03:15
*** e0ne has joined #openstack-sdks05:43
*** slaweq has joined #openstack-sdks06:13
*** dtantsur|afk is now known as dtantsur06:16
*** holser_ has joined #openstack-sdks06:27
*** evrardjp_ is now known as evrardjp06:43
*** gtema has joined #openstack-sdks06:58
*** ITD27M01 has joined #openstack-sdks07:02
*** ttsiouts has joined #openstack-sdks07:09
*** e0ne has quit IRC07:09
*** slaweq has quit IRC07:16
*** adriant has quit IRC07:29
*** markvoelker has joined #openstack-sdks07:32
*** zbr has joined #openstack-sdks07:32
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer for network SecurityGroups  https://review.opendev.org/66272407:34
*** ttsiouts has quit IRC07:34
*** ttsiouts has joined #openstack-sdks07:35
*** ttsiouts has quit IRC07:39
*** slaweq has joined #openstack-sdks07:40
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer for compute KeyPairs  https://review.opendev.org/66272907:44
*** jpich has joined #openstack-sdks07:47
*** jpena|off is now known as jpena07:51
*** ttsiouts has joined #openstack-sdks08:02
*** markvoelker has quit IRC08:05
*** adriant has joined #openstack-sdks08:18
*** e0ne has joined #openstack-sdks08:32
*** ttsiouts has quit IRC09:01
*** ttsiouts has joined #openstack-sdks09:02
*** ttsiouts has quit IRC09:06
*** mugsie_ is now known as mugsie09:52
*** markvoelker has joined #openstack-sdks10:02
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server  https://review.opendev.org/66299810:15
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer for the compute Hypervsors and Images  https://review.opendev.org/66274310:16
*** cdent has joined #openstack-sdks10:27
*** slaweq has quit IRC10:30
*** markvoelker has quit IRC10:36
*** gtema has quit IRC10:43
*** gtema_ has joined #openstack-sdks10:43
*** gtema_ is now known as gtema10:43
*** slaweq has joined #openstack-sdks11:00
*** ttsiouts has joined #openstack-sdks11:22
*** holser_ is now known as holser|lunch11:26
*** ttsiouts has quit IRC11:33
*** markvoelker has joined #openstack-sdks11:33
*** ttsiouts has joined #openstack-sdks11:34
*** jpena is now known as jpena|lunch11:34
*** ttsiouts_ has joined #openstack-sdks11:37
*** dave-mccowan has joined #openstack-sdks11:37
*** ttsiouts has quit IRC11:38
*** yolanda has quit IRC11:44
*** holser|lunch is now known as holser_11:49
*** cdent has quit IRC11:54
*** markvoelker has quit IRC12:05
*** mugsie is now known as mugsie_12:18
*** mugsie_ is now known as mugsie12:18
*** gtema has quit IRC12:19
*** jpena|lunch is now known as jpena12:32
*** gtema has joined #openstack-sdks12:48
*** cdent has joined #openstack-sdks12:48
*** Luzi has joined #openstack-sdks13:00
*** ttsiouts_ has quit IRC13:10
*** ttsiouts has joined #openstack-sdks13:11
*** Luzi has quit IRC13:13
*** ttsiouts has quit IRC13:15
*** holser_ has quit IRC13:24
*** holser_ has joined #openstack-sdks13:25
*** ttsiouts has joined #openstack-sdks13:26
*** holser_ has quit IRC13:31
*** holser_ has joined #openstack-sdks13:32
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Make factory for a CloudRegion from CONF objects  https://review.opendev.org/64360113:36
mordredgtema, Shrews, dtantsur, slaweq: ^^ is ready for review when y'all get a spare minute. this is the needed feature for shifting nova to sdk and off of python-*client13:37
mordredefried: I just added a release note in that latest patchset - tests look great, thanks!13:37
efriedmordred: Nice. What more to get it merged?13:37
mordredefried: just need to convince people to review it now :)13:38
*** cdent has quit IRC13:38
efriedoh, I see previous alert13:38
efriedyes, cool.13:38
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Support Proxy-specific region_name  https://review.opendev.org/66286513:38
gtemaok, got it13:38
efriedmordred: region_name thing sane enough to fly, you think?13:38
gtemayeah, was looking at both today morning. Looked ok for me. If mordred also thinks ok - great13:39
mordredefried: reading that now13:40
efriedmordred: One tweak in the reno, I'll fix that up quick if you agree.13:41
mordredefried: I'm sure I do - looking13:41
efriedI mean, yes, you're using the CloudRegion to create a Connection, not sure if a CloudRegion is good for anything else, so maybe this is a distinction without a difference.13:42
mordredefried: yes. also - maybe it should be Connection or CloudRegion - because while you're right the primary thing is the CloudRegion- we also added a parameter to the Connection contructor13:42
mordredwho knows what people are using CloudRegions for :)13:43
efriedoh, sorry, you're right. Forest for the trees and all that. The primary use case would be Connection I guess, wouldn't it.13:44
mordredyeah. I could go either way ...13:45
mordredefried: what does "ddt this" mean?13:45
efriedI'll leave it alone, since we've got gtema's +2 now :)13:45
gtemaI can put another one - no problem13:46
efriedmordred: ddt does the same thing as testscenarios13:46
mordredah. is it more pleasant to use?13:46
gtemabut guys, what have you done with "/os-server-groups" with respect to microversions - all the finest things at once13:46
efriedmordred: That's probably in the eye of the beholder. Let me dig up an example quick...13:47
efriedmordred: I don't know if testscenarios works on a per-method basis; ddt does.13:47
mordredefried: cool - I like testscenarios - but I always have to go look at previous code I wrote to figure out how to use it13:47
mordredah - no - testscenarios is purely class based13:47
efriedditto ddt13:47
gtema++ - same for me13:47
mordredI like the concept of putting test data into a file too13:48
efriedmordred: https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/test_nova_manage.py#L133913:49
efriedThe data gets passed to the method as params13:49
mordredI like that13:49
mordredthat's nicer than class attributes, which I think is a bit too magical13:50
* mordred has learned something today13:50
efriedvs testscenarios where they're instance vars, but of course that difference makes sense when it's per-test13:50
*** holser_ has quit IRC13:50
efriedyeah, but it would be just as magical if they were method params, set up from the class level, wouldn't it?13:51
efriedlike using a @mock.patch decorator on your class, all your methods now get a new param.13:51
mordredoh - I don't think I've ever used mock.patch on a class :)13:51
mordredI guess I like that in ddt the magic is localized to the method you're looking at ... but yeah, still some magic13:52
*** holser_ has joined #openstack-sdks13:52
efriedI usually don't (use mock.patch on a class). If I need it to apply to all my tests, I'll useFixture(fixtures.MockPatch()) in setUp - and if I need the mock, I'll create an instance attribute :)13:52
mordredI *really* like the file_data - I've done a few testscenarios with a BUNCH of scenarios and it quickly becomes hard to read13:52
efried^ manual testscenarios :)13:52
mordred++ to useFixture in setUp13:53
*** holser_ has joined #openstack-sdks13:53
* efried experiences kumbaya moment on python test philosophy13:53
* mordred hands efried the bong13:54
efriedahem, "guitar"13:54
mordredyes yes. "guitar". sorry13:54
efriedbut the point of the comment was: dedup this repetitive code13:55
efriedI don't care if it's ddt or testscenarios or a helper method, whatevs.13:55
*** cdent has joined #openstack-sdks14:02
openstackgerritEric Fried proposed openstack/openstacksdk master: Get rid of unused _OpenStackCloudMixin.get_region  https://review.opendev.org/66303814:05
*** ITD27M01 has quit IRC14:12
gtemamordred: I forgot a bit about ver discovery. In the service catalog endpoint contains project_id at the end, but version info is available under compute/v2.114:20
gtemathe proxy is not able to discover supported microversion14:20
mordredgtema: version discovery should be able to handle project_id at the end of endpoint14:21
gtemawell, in the small script it is not working properly14:21
*** zbr has quit IRC14:21
gtemawait a sec, posting14:22
*** zbr has joined #openstack-sdks14:23
gtemamordred: http://paste.openstack.org/show/752487/14:24
mordredoh - you have a broken compute endpoint. it's requiring auth for version discovery14:24
mordredsee that first GET with the 40114:25
gtemaoh, indeed14:25
mordredI think we've got it written down somewhere that people should not auth-protect service version discovery - I don't remember where though14:26
efriedI remember this ^ but not sure if it's written14:26
gtemahmm, ok then. Will start alerting internally on all available channels14:26
efriedIt's written in IRC :)14:27
mordredefried: :)14:27
gtemalife is great ;-/14:27
mordredgtema: let me know if I can be helpful in corroborating that this should not be auth-protected.14:28
gtemawe probably should add it into https://opendev.org/openstack/api-sig/src/branch/master/guidelines/microversion_specification.rst14:29
mordredgtema: yah. it's possible it's mentioned in https://review.opendev.org/#/c/459405/ - looking14:31
efried++. I was looking for it in the keystoneauth docs, but that's the consuming side, so probably not the right place anyway.14:31
gtemahmm, 'it is recommended' is confusing. It is definitely not working at all otherwise14:33
efriedit's possible to make it work, I suppose. "strongly recommended"? ;P14:35
gtemaas a consumer I doubt you will make it work. If we bake it in - sure14:36
mordredyeah - we should probably change that to be stronger14:37
mordredit's unpossible to make it work with the official openstack libraries or any of the tools. obviously you could make it work with direct REST calls ...14:38
gtemaI guess it is either stricktly required, or possible otherwise (not as of now)14:38
gtemaso yeah - exactly what I mean14:38
mordredit's also not a thing we can update keystoneauth to handle reasonably - it would take basically a full rewrite IIRC14:39
gtemaok. Sad, means cloud is still cloudy, but that is how it is14:39
mordred:( - sorry about that14:40
gtemaanother question for the same topic. Some stuff require 'min' version. Do we have something to pick the proper version out of it (not sticking for this min if current is better)?14:41
mordredwe should really add a tempest test and get refstack to require that it works properly14:41
gtemathat is a cool idea14:41
mordredgtema: dtantsur added some stuff to the resource layer for specifying microversions needed for things -14:43
mordredthere's also https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/compute/v2/server.py#L42114:43
mordredhow we're doing it for live migrations14:43
mordredthere should probably be some sort of helper pattern extracted from that, because that's super manual14:44
gtemathe question is basically coming from: /servers/.../createImage returns image_id only after 2.45. And do not want to simply say - use 2.45 here. I would like to treat microver as a "num"14:44
gtemato get the newest14:44
mordredI think what the current resource microversion stuff is saying is "This resource knows how to handle microversions as new as 2.45" - because just doing latest could mean semantic changes that the resource can't handle14:46
mordredthen, in the code, if we wanted to make image_id part of our API all the time, we might need to make an extra call if the cloud is older than 2.45, yeah?14:47
gtemayeah, for server-group it is slightly more complicated - until 2.63 there is attr 'policies'14:47
gtemaafter 2.64 it is 'policy' and a single only14:47
mordredcan there be more than one policy in the list until 2.63? or is it a list that happened to only ever have one policy in it?14:48
gtemaso I need to somehow check - do we support max something older - than do one cool thing. If we support something newer than 2.64 - do other cool thing14:48
gtemanope, should not be14:49
gtemastated in docs - list with strictly one entity14:49
mordredso - we could conceivably support both in all cases and just map it differently depending on what we get back from the remote side14:49
mordredso have server_group.policy and server_group.polices - or we could just pick one and map in that direction regardless of server-side14:50
gtemayes, but depending on what is the max supported version I need to hack "create"14:50
mordredbut yeah - this is where everything gets tricky :)14:50
gtemaand if with following microvers new features will come - it will become even better14:50
gtema(will add)14:51
gtemaso we need really to treat microvers as numbers14:51
efrieddoes microversion_parse help here?14:53
gtemaefried: which one?14:54
efriedtreating microversions as numbers14:54
efriedI'm probably not following closely enough to be useful here, sorry.14:55
efried"treat microversions as numbers" => has to be a tuple, not a float, of course. Else 1.23 < 1.414:55
efriedksa has a crap-ton of code dealing with this.14:55
gtemareally? have not seen so far14:56
gtemaneed to admit was not even looking deeply14:56
gtemaaha discover.normalize_version_number returns tuple14:56
mordredyah. there's also some methods in discover for comparing versions15:00
gtemacool, thks15:00
*** ttsiouts has quit IRC15:04
*** ttsiouts has joined #openstack-sdks15:05
*** AJaeger has joined #openstack-sdks15:06
AJaegeropenstackclient cores, please review https://review.opendev.org/#/c/661947/3 and https://review.opendev.org/#/c/661974/ to update your docs Sphinx to pass checks again15:07
*** ttsiouts has quit IRC15:09
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer for next compute methods  https://review.opendev.org/66306415:21
openstackgerritMerged openstack/openstackclient master: Update sphinx dependency for python 2.7  https://review.opendev.org/66194715:21
openstackgerritMerged openstack/openstackclient master: Switch to openstackdocstheme  https://review.opendev.org/66197415:21
mordredAJaeger: done!15:22
AJaegerthanks, mordred !15:22
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Dropping the py35 testing  https://review.opendev.org/65465815:24
AJaegermordred: one more, please ^15:24
*** AJaeger has left #openstack-sdks15:27
*** e0ne has quit IRC15:32
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server  https://review.opendev.org/66299815:35
gtemamordred: is it ok from your pov not to check presence of both 'ephemeral' and 'OS-FLV-EXT-DATA:ephemeral' for flavors in func tests?15:42
gtemain resource we have ephemeral=OS-FLV-EXT-DATA:ephemeral15:42
gtemabut func test expects both15:42
gtemafor https://review.opendev.org/#/c/650903/15:42
*** gtema has quit IRC16:10
*** dtantsur is now known as dtantsur|afk16:11
*** holser_ has quit IRC16:23
*** holser_ has joined #openstack-sdks16:23
*** jangutter has quit IRC16:27
*** cdent has quit IRC16:29
*** jpich has quit IRC16:32
*** jpena is now known as jpena|off17:09
*** adriant has quit IRC17:20
*** whoami-rajat has quit IRC17:24
*** holser_ has quit IRC17:31
*** holser_ has joined #openstack-sdks17:32
*** holser_ has quit IRC17:37
*** ricolin has joined #openstack-sdks17:38
*** adriant has joined #openstack-sdks17:50
*** whoami-rajat has joined #openstack-sdks18:26
*** e0ne has joined #openstack-sdks18:54
*** e0ne has quit IRC18:55
*** ricolin has quit IRC19:10
*** cdent has joined #openstack-sdks19:20
*** e0ne has joined #openstack-sdks19:29
*** e0ne has quit IRC19:30
*** altlogbot_2 has joined #openstack-sdks19:40
*** slaweq has quit IRC19:43
*** slaweq has joined #openstack-sdks19:44
*** dave-mccowan has quit IRC19:55
*** dave-mccowan has joined #openstack-sdks20:01
openstackgerritMichael McCune proposed openstack/keystoneauth master: add a handler for unknown HTTP errors  https://review.opendev.org/66313220:07
*** e0ne has joined #openstack-sdks20:23
*** dave-mccowan has quit IRC20:27
*** e0ne has quit IRC20:41
*** e0ne has joined #openstack-sdks20:42
*** e0ne has quit IRC20:43
*** whoami-rajat has quit IRC20:54
*** cdent has quit IRC20:55
*** Qiming has quit IRC21:11
*** Qiming has joined #openstack-sdks21:14
*** slaweq has quit IRC22:07
*** slaweq has joined #openstack-sdks22:11
*** slaweq has quit IRC22:24
*** slaweq has joined #openstack-sdks22:34
*** dave-mccowan has joined #openstack-sdks22:44
*** slaweq has quit IRC22:47
*** dave-mccowan has quit IRC22:56
*** dave-mccowan has joined #openstack-sdks22:57
*** slaweq has joined #openstack-sdks23:04
*** slaweq has quit IRC23:17
*** slaweq has joined #openstack-sdks23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!