Tuesday, 2018-10-30

*** mriedem_away has quit IRC00:15
openstackgerritVishakha Agarwal proposed openstack/python-openstackclient master: Modify the help message for 'registered limit set'  https://review.openstack.org/60998501:57
*** rcarrillocruz has quit IRC02:43
*** gildub has joined #openstack-sdks04:12
openstackgerritIan Wienand proposed openstack/openstacksdk master: Make delete_unattached_floating_ips return a count  https://review.openstack.org/61407504:58
openstackgerritIan Wienand proposed openstack/openstacksdk master: Make delete_unattached_floating_ips return a count  https://review.openstack.org/61407505:06
*** d0ugal has joined #openstack-sdks05:18
*** d0ugal has quit IRC05:30
*** d0ugal has joined #openstack-sdks05:44
adriantmordred: I'm either hitting a really weird bug, or something stupid, but I can't use the SDK to list servers against our cloud anymore :/05:52
adriantwe are running nova still in Kilo though, so it's always possible that something there is a problem, but it's not that it errors, I just get back an empty list05:53
adriantit's calling the wrong region?!05:54
adriantok, nvm, found my issue05:55
adriantyeah, nvm this code just doesn't make sese05:58
* adriant is an idiot05:59
*** gildub has quit IRC06:05
*** gildub has joined #openstack-sdks06:12
*** mnaser has quit IRC06:16
*** mnaser has joined #openstack-sdks06:17
*** slaweq has quit IRC06:40
*** tonyb has quit IRC06:50
*** gildub has quit IRC06:51
*** Luzi has joined #openstack-sdks06:52
*** d0ugal has quit IRC07:01
*** gildub has joined #openstack-sdks07:02
*** slaweq has joined #openstack-sdks07:49
*** gkadam has joined #openstack-sdks08:05
*** jpich has joined #openstack-sdks08:26
adriantmordred: well after being and idiot, there is now a new version of my silly interpreter tool, and i've updated the docs to mostly ignore that the per service client libraries exist.08:40
*** e0ne has joined #openstack-sdks08:41
*** gtema has joined #openstack-sdks08:49
*** d0ugal has joined #openstack-sdks08:50
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource  https://review.openstack.org/59144508:52
*** slaweq has quit IRC08:53
*** jpena|off is now known as jpena08:57
*** d0ugal has quit IRC09:05
*** brtknr has left #openstack-sdks09:06
*** cdent has joined #openstack-sdks09:42
*** slaweq has joined #openstack-sdks10:08
*** ttsiouts has joined #openstack-sdks10:22
*** e0ne has quit IRC10:32
openstackgerritwangqiang-bj proposed openstack/keystoneauth master: fix wrong spelling of "unnecessary"  https://review.openstack.org/61417810:40
*** cdent has quit IRC10:42
*** e0ne has joined #openstack-sdks10:56
*** dave-mccowan has joined #openstack-sdks11:10
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource  https://review.openstack.org/59144511:12
*** gkadam has quit IRC11:12
*** cdent has joined #openstack-sdks11:13
*** dtantsur|afk is now known as dtantsur11:50
*** jpena is now known as jpena|lunch11:57
*** gtema has quit IRC12:14
*** ttsiouts has quit IRC12:16
*** e0ne has quit IRC12:21
*** ttsiouts has joined #openstack-sdks12:32
*** cdent has quit IRC13:07
*** e0ne has joined #openstack-sdks13:08
*** jpena|lunch is now known as jpena13:12
*** mriedem has joined #openstack-sdks13:13
*** bobh has joined #openstack-sdks13:20
mordredadriant: yay!13:26
*** cdent has joined #openstack-sdks13:27
*** gildub has quit IRC13:29
*** gildub has joined #openstack-sdks13:29
*** gildub has quit IRC13:36
*** ttsiouts has quit IRC13:40
*** ttsiouts has joined #openstack-sdks13:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect  https://review.openstack.org/61421313:42
Shrewsmordred: did we remove the old shade func tests in sdk?13:48
mordredShrews: no - they should still be there in openstack/tests/functional/cloud13:48
Shrewsoh yep13:48
mordredShrews: maybe before we retire we'll have all of that completely integrated13:49
Shrewsmordred: can we explore trying to have a func test for that before we merge? i mean, we're really just assuming it works13:50
*** gtema has joined #openstack-sdks13:50
Shrewsi might need to setup a devstack again to try to create a port in the down state13:51
Shrewsor maybe we could ask someone with actual knowledge of neutron13:51
Shrewshrm, our unit tests don't even test passing filter13:53
openstackgerritMonty Taylor proposed openstack/cliff master: Don't try to run issubclass on non-classes  https://review.openstack.org/61421813:56
mordredShrews: oh - totally. let's definitely add some tests14:00
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect  https://review.openstack.org/61421314:03
Shrewsmordred: ^^ unit test14:03
Shrewsmordred: double check me, but passes locally for me14:03
openstackgerritMonty Taylor proposed openstack/cliff master: Don't try to run issubclass on non-classes  https://review.openstack.org/61421814:05
Shrewsmordred: hrm, no. that passes on master when it shouldn't14:05
*** d0ugal has joined #openstack-sdks14:06
Shrewsso i've done something wrong14:06
mordredShrews: that test tests that the query returns an unfilted list14:11
mordredmock_neutron_port_list_rep is a list of ports that has non-down ports in it right?14:12
Shrewsmordred: it isn't asserting that the uri contains the filter params?14:12
Shrewsi thought assert_calls did that14:12
Shrewsi wasn't worried so much about the return data as much as i wanted to confirm the uri had any filters we passed14:13
mordredShrews: oh - i was looking at line 25314:13
mordredShrews: I think you need to configure caching14:14
mordredShrews: because we only skip passing the query string if caching is enabled14:14
mordred(although maybe leave that test to test that non-caching also works)14:14
Shrewsah. do we have an example of that?14:15
mordredlooking for one now14:15
mordredShrews: openstack/tests/unit/cloud/test_caching.py is set up to do servers caching - we could add prts to openstack/tests/unit/fixtures/clouds/clouds_cache.yaml14:16
mordredShrews: and add a copy of the test you just added but without the query string14:16
*** cdent has quit IRC14:21
*** gkadam has joined #openstack-sdks14:21
Shrewsdon't you need the query string??14:21
mordredwell - in the caching version we'd expect it to not pass filters on the query string14:21
Shrewsoh! b/c we filter ourselves14:22
* Shrews is slow14:22
Shrewsmordred: you seem to have a handle on it, feel free to push that PS while I caffeinate more appropriately14:23
mordredShrews: ok. I'll do that one14:24
mordredShrews: OH14:25
mordredShrews: also - re: functional ...14:25
mordredShrews: when you create a port but it isn't attached to anything - its state is totally DOWN14:25
mordredShrews: see mock_neutron_port_create_rep in openstack/tests/unit/cloud/test_port.py14:26
*** d0ugal has quit IRC14:28
Shrewsoh cool14:29
*** e0ne has quit IRC14:33
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect  https://review.openstack.org/61421314:35
mordredShrews: how's that look?14:35
*** e0ne has joined #openstack-sdks14:37
Shrewsmordred: yes, that fails for me on master14:40
mordredShrews: \o/14:40
mordredslaweq: feel in the mood to review a quick neutron related sdk patch? ^^14:40
mordredShrews: I believe this same bug exists for servers and floating ips - followup patch coming14:42
Shrewsoh goodie14:43
slaweqmordred: +W (I hope CI will be happy with it too) :)14:45
mordredslaweq: thanks!14:45
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Apply list filter fix to servers and floating ips too  https://review.openstack.org/61423614:48
mordredShrews: ^^ there it is applied to servers and floating ips too14:48
*** dtantsur is now known as dtantsur|brb14:50
*** Luzi has quit IRC14:52
mordredShrews: I put a pause on the 0.19.0 release (which contained the other fix we needed for nodepool) so we can get this in there15:02
*** dave-mccowan has quit IRC15:03
*** cdent has joined #openstack-sdks15:08
mordreddtroyer: if you get a sec, could you take a peep at https://review.openstack.org/#/c/614218/ ?15:22
*** e0ne has quit IRC15:25
*** Leo_m has joined #openstack-sdks15:27
*** e0ne has joined #openstack-sdks15:35
openstackgerritSean McGinnis proposed openstack/openstacksdk master: Remove setup.py check from pep8 job  https://review.openstack.org/61427415:38
mordredShrews: if you have a sec, https://review.openstack.org/#/c/613976 and https://review.openstack.org/#/c/613978 are in response to a feedback we got yesterday from wouterdb15:43
mordredShrews: who had a usecase where he was creating and destroying a ton of Connection objects, and the lack of a close to shutdown underlying threadpool objects was causing a preponderance of threads15:43
Shrewsmordred: i totes want a be_awesome() method15:45
*** Leo_m has quit IRC15:49
*** Leo_m has joined #openstack-sdks15:51
mordredShrews: we should make one15:52
mordredgtema: looking at your story from earlier about caching and wait_for methods ... we really need to do some work in the caching layer15:54
gtemamordred: agree15:55
gtemajust spend some time trying to figure out why it suddenly does not work properly15:55
gtemamordred: can I help there?15:55
mordredgtema: almost certainly! I think once we get this task manager updates finished it'll be a good time to work on it15:58
gtemamordred: what about backup support in block-storage (https://review.openstack.org/#/c/591445/)16:00
openstackgerritSean McGinnis proposed openstack/os-client-config master: Remove setup.py check from pep8 job  https://review.openstack.org/61428016:00
mordredgtema: "Note that backup restore is not documented in the official API, but is implemented in the cinderclient"16:01
mordredthat's so awesome16:01
gtemayes, I was clarifying it - it was a bug promised to be fixed in docs16:02
gtemaoh, it is even now fixed - will update commit message16:02
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource  https://review.openstack.org/59144516:04
smcginnisWhich "official API" is Cinder backup not documented in?16:04
gtemabackup restore was not documented16:04
gtemabut now it is documented16:05
smcginnisMust have been a really old reference.16:05
gtemafrom what I remember I was told there was a content error somewhere in sources, so that this method was not shown properly16:06
smcginnisAh, that could be then.16:06
smcginnisOK, yeah, I fixed that just in August. https://review.openstack.org/#/c/592026/16:07
gtemayes, I was asking in maillist sometime back in august - my change was for this time forgotten and I rebased it yesterday16:08
gtemamordred: thanks16:08
smcginnisgtema: Cool, thanks!16:08
dtroyermordred: +2…   there is an isclass() call in OSC that has gone back and forth a time or two, I'm wondering if a similar solution would be appropriate there (without looking before typing of course)16:11
*** dave-mccowan has joined #openstack-sdks16:23
*** dtantsur|brb is now known as dtantsur16:26
*** e0ne has quit IRC16:30
*** Leo_m has quit IRC16:44
*** Leo_m has joined #openstack-sdks16:45
*** Leo_m has quit IRC16:55
*** Leo_m has joined #openstack-sdks16:56
*** gkadam has quit IRC17:08
*** jpich has quit IRC17:08
openstackgerritMerged openstack/openstacksdk master: Add close method to shutdown threadpool  https://review.openstack.org/61397617:13
openstackgerritMerged openstack/openstacksdk master: Make Connection a context manager  https://review.openstack.org/61397817:13
*** gtema has quit IRC17:26
*** ttsiouts has quit IRC17:28
*** ttsiouts has joined #openstack-sdks17:29
*** gkadam has joined #openstack-sdks17:29
*** ttsiouts has quit IRC17:33
*** gkadam has quit IRC17:40
*** gyroknight_ has joined #openstack-sdks17:47
gyroknight_Hi, just wondering if anyone's had trouble with list_servers(all_projects=True) in openstack.connection.Connection? It seems to only list instances belonging to the authenticated user's project, even when the user is an admin17:50
gyroknight_I can't find any related tasks or stories in the StoryBoard17:50
*** bobh has quit IRC17:53
mordredgyroknight_: I feel like I saw a patch related to that recently17:53
gyroknight_The servers(all_projects=True) generator in the compute v2 proxy also doesn't seem to work. The generator creation seems to work fine, but if I try to iterate through it, Resource throws an error "openstack.exceptions.InvalidResourceQuery: Invalid query params: all_projects"17:54
mordredoh - maybe not17:54
*** bobh has joined #openstack-sdks17:55
mordredgyroknight_: cool (I mean, not cool, but good to know) - I've gotta run out for a sec, but will investigate in just a little bit17:55
*** dtantsur is now known as dtantsur|afk17:57
*** bobh has quit IRC17:59
*** jpena is now known as jpena|off18:10
*** e0ne has joined #openstack-sdks18:10
gyroknight_Figured out the compute proxy, seems the documentation is incorrect, it should be all_tenants instead of all_projects18:22
gyroknight_I'm using the documentation here: https://docs.openstack.org/openstacksdk/latest/user/proxies/compute.html#openstack.compute.v2._proxy.Proxy18:23
*** e0ne has quit IRC18:25
*** bobh has joined #openstack-sdks18:29
*** bobh has quit IRC18:33
*** gyroknight_ is now known as gyroknight18:40
*** bobh has joined #openstack-sdks18:41
mordredgyroknight: we just recently merged a fix for that ... https://review.openstack.org/#/c/540390/ (like, 2 days ago and it'll be in there when we release later today)18:56
gyroknightAwesome, thanks18:57
gyroknightI figured out the workaround with list_servers(filters={'all_tenants': True}) in the meantime, but it'll be nice to have the alias later on18:59
mordredhrm. list_servers(filters={'all_tenants': True}) works but list_servers(all_projects=True) doesn't work? that's sad making ...19:06
mordredgyroknight: do you have resource caching enabled?19:06
gyroknightNot sure19:06
gyroknightHow would I check?19:07
mordredyou'd have to do it explicitly by putting a cache: section in a clouds.yaml19:08
mordredso if you weren't intending on it, you are likely not doing it19:08
gyroknightYeah, don't have one of those19:08
mordredjust asking cause we found a bug earlier today with filters not being passed properly when caching was in play19:08
mordredkk. well - I'll see if I can figure out why one form works and the ohter doesn't19:09
*** e0ne has joined #openstack-sdks19:13
gyroknightInterestingly enough, all_projects=True works in get_server(), so maybe it's only isolated to those two occurences?19:14
mordredthat's excessively strange - get_server is built on top of list_server :)19:21
openstackgerritMerged openstack/openstacksdk master: Filter ports in list_ports when batching is in effect  https://review.openstack.org/61421319:41
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Apply list filter fix to servers and floating ips too  https://review.openstack.org/61423619:43
*** cdent has quit IRC19:56
*** gildub has joined #openstack-sdks20:05
*** gildub has quit IRC20:18
*** Leo_m has quit IRC20:51
*** bobh has quit IRC21:00
*** gildub has joined #openstack-sdks21:13
openstackgerritMerged openstack/openstacksdk master: Remove setup.py check from pep8 job  https://review.openstack.org/61427421:13
*** e0ne has quit IRC21:18
*** gyroknight has quit IRC21:21
*** mriedem has quit IRC21:30
*** ttsiouts has joined #openstack-sdks21:55
openstackgerritTony Breeds proposed openstack/cliff master: Removed unused err variable  https://review.openstack.org/61435921:57
*** ttsiouts has quit IRC22:04
*** ttsiouts has joined #openstack-sdks22:05
*** ttsiouts has quit IRC22:10
*** e0ne has joined #openstack-sdks22:49
*** tonyb has joined #openstack-sdks23:03
*** e0ne has quit IRC23:13
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add networks to Limestone vendor  https://review.openstack.org/60802723:16
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add networks to Limestone vendor  https://review.openstack.org/60802723:17
*** gildub has quit IRC23:32

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!