Tuesday, 2018-10-16

*** slaweq has joined #openstack-sdks01:11
*** slaweq has quit IRC01:16
*** openstackgerrit has quit IRC01:35
*** annp has joined #openstack-sdks02:26
*** dave-mccowan has quit IRC03:08
*** slaweq has joined #openstack-sdks03:11
*** bobh has joined #openstack-sdks03:14
*** slaweq has quit IRC03:16
*** openstackgerrit has joined #openstack-sdks03:17
openstackgerritMerged openstack/openstacksdk master: Turn down stevedore and urllib logging  https://review.openstack.org/60451503:17
*** bobh has quit IRC03:31
*** slaweq has joined #openstack-sdks04:11
*** slaweq has quit IRC04:16
*** slaweq has joined #openstack-sdks05:11
*** slaweq has quit IRC05:15
*** Luzi has joined #openstack-sdks06:01
*** slaweq has joined #openstack-sdks06:11
*** slaweq has quit IRC06:16
*** noama has joined #openstack-sdks06:24
*** edisonxiang has joined #openstack-sdks06:39
*** e0ne has joined #openstack-sdks06:48
*** slaweq has joined #openstack-sdks06:55
*** jpena|off is now known as jpena07:20
*** markvoelker has quit IRC07:29
*** markvoelker has joined #openstack-sdks07:29
*** ttsiouts has joined #openstack-sdks07:30
*** markvoelker has quit IRC07:34
*** edisonxiang has quit IRC07:39
*** tosky has joined #openstack-sdks07:52
*** jpich has joined #openstack-sdks08:00
*** dtantsur|afk is now known as dtantsur08:03
*** markvoelker has joined #openstack-sdks08:30
*** e0ne has quit IRC08:37
*** gkadam has joined #openstack-sdks08:38
*** gkadam has quit IRC08:38
*** e0ne has joined #openstack-sdks08:44
*** cdent has joined #openstack-sdks08:59
*** markvoelker has quit IRC09:03
openstackgerritTobias Rydberg proposed openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name.  https://review.openstack.org/61091909:36
openstackgerritTobias Rydberg proposed openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name.  https://review.openstack.org/61092109:49
*** imacdonn has quit IRC09:54
*** imacdonn has joined #openstack-sdks09:55
*** markvoelker has joined #openstack-sdks10:00
*** ttsiouts has quit IRC10:08
*** jamielennox has quit IRC10:11
*** jamielennox has joined #openstack-sdks10:13
openstackgerritMerged openstack/openstacksdk master: Update Auro cloud profile  https://review.openstack.org/61069910:13
openstackgerritMerged openstack/openstacksdk master: Update ElastX cloud profile  https://review.openstack.org/61070410:17
*** ttsiouts has joined #openstack-sdks10:29
*** markvoelker has quit IRC10:34
*** ttsiouts has quit IRC11:02
*** ttsiouts has joined #openstack-sdks11:03
*** ttsiouts has quit IRC11:07
*** dave-mccowan has joined #openstack-sdks11:09
*** ttsiouts has joined #openstack-sdks11:17
*** e0ne has quit IRC11:18
*** jpena is now known as jpena|lunch11:29
*** markvoelker has joined #openstack-sdks11:31
*** ttsiouts has quit IRC11:31
*** ttsiouts has joined #openstack-sdks11:32
*** e0ne has joined #openstack-sdks11:33
*** ttsiouts has quit IRC11:34
*** ttsiouts has joined #openstack-sdks11:35
*** ttsiouts has quit IRC11:37
*** ttsiouts has joined #openstack-sdks11:38
dtantsurmordred: morning! when you have some time, I could use your opinion on https://review.openstack.org/60342711:44
dtantsurnote that it does not take the TaskManager into account yet, I'd wait for its implementation to settle11:44
*** ttsiouts has quit IRC11:46
*** ttsiouts has joined #openstack-sdks11:47
*** ttsiouts has quit IRC11:47
*** ttsiouts has joined #openstack-sdks11:47
*** ttsiouts has quit IRC11:50
*** ttsiouts has joined #openstack-sdks11:51
*** ttsiouts has quit IRC11:55
*** ttsiouts has joined #openstack-sdks12:00
*** markvoelker has quit IRC12:04
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Convert inspect_machine to use the baremetal proxy  https://review.openstack.org/61094112:16
*** e0ne has quit IRC12:24
*** e0ne has joined #openstack-sdks12:27
*** ttsiouts has quit IRC12:32
mordreddtantsur: hrm. reading through 603427 - it makes me think more that maybe we really should push the fair-locking based task manager replacement down in to keystoneauth (I was waffling about it earlier)- since the retriable status code logic is down in the Session, if we want that to honor a rate limit setting, we'd need it to know about it12:47
dtantsurmordred: well, keystoneauth could certainly benefit from (optional) rate limiting logic12:49
LuziI already talked about this on the ML: We want to propose Image encryption for OpenStack, which would also affect osc. And we are gathering thought on which library to use: https://etherpad.openstack.org/p/library-for-image-encryption-and-decryption12:51
LuziIt would be nice, to have some input from your side :)12:51
mordreddtantsur: https://review.openstack.org/#/c/605043/1 :)12:52
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Move wait_for_baremetal_node_lock to the baremetal proxy  https://review.openstack.org/61094612:53
dtantsurmeanwhile, I continue polishing the bare metal stuff in OpenStackCloud ^^^12:53
dtantsurmordred: do you expect another release before 1.0? I guess I'll end up with a lot of deprecations..12:54
mordreddtantsur: yeah - I think we need to do at least one just to see what we might have missed/broken12:55
mordreddtantsur: the current master branch is ... large :)12:55
dtantsurright :)12:55
mordredeandersson: \o/ THANK YOU for fixing the magnum jobs12:55
*** bobh has joined #openstack-sdks13:04
Shrewsmordred: approved the stack13:06
mordredShrews: \o/13:07
mordredShrews: if you're still in the mood, dtantsur has a good patch here: https://review.openstack.org/#/c/60342713:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add stackviz processing to functional tests  https://review.openstack.org/61016713:10
mordreddtantsur: added comment ^13:10
*** e0ne has quit IRC13:12
samueldmqis the glance task import a v2 only thing or does it exist in v1?13:14
*** e0ne has joined #openstack-sdks13:16
mordredsamueldmq: only v213:21
mordredsamueldmq: v1 had PUT content upload- and also had import-from-url which 2 doesn't have13:21
samueldmqmordred: thanks, that one is a very special case. I haven't seen that in the clouds I tested though13:21
samueldmqmordred: kk but we don't do import-from-url for v113:22
samueldmqwe could technically try via put directly and if it fails try the task workflow when using v213:23
mordredsamueldmq: that's right - I never added it because it wasn't in v2 - so there was no way to add it consistently across both13:23
*** mriedem has joined #openstack-sdks13:23
samueldmqso that one didn't have to set use_task_api in the config... but as I haven't seen that anywhere... /me shrugs13:23
mordredsamueldmq: yes - I was thinking the same thing13:23
mordredsamueldmq: and have use_task_api as a config option to avoid the call to PUT13:23
mordredsamueldmq: rackspace and switch are the only clouds I'm aware of that make you use the task api13:24
samueldmqmordred: yes, that wins if set13:24
samueldmqmordred: switch no more. it's using the put api now13:24
mordredsamueldmq: we should test which error code we get on a task cloud when you try the put13:24
mordredsamueldmq: oh good!13:24
mordredsamueldmq: to make sure we can detect it properly13:24
samueldmqmordred: ++13:26
*** jpena|lunch is now known as jpena13:37
Shrewsmordred: what is your plan for using the stackviz output? what problem is it solving for us?13:38
mordredShrews: looking at it to see which tests take how long ... there's also supposed to be overlaid dstat output which seems to be not working atm13:39
mordredShrews: also - it's sort of an exploration about using that stackviz stuff for non-tempest runs - and it seems like it's going great13:40
Shrewsso the goal is to optimize our test suite?13:40
mordredShrews: yeah - or at least to be able to see if there are any problem children13:41
mordredShrews: also, from poking at this, in theory we could add dstat and stackviz to the unittests base job and wire it up such that we always produce the report for all stestr-based jobs13:42
mordredbut that, of course, is out of scope of this patch :)13:42
Shrewsk k13:43
*** e0ne has quit IRC13:53
*** Luzi has quit IRC14:00
*** e0ne has joined #openstack-sdks14:01
openstackgerritMonty Taylor proposed openstack-infra/shade master: Decouple OpenStackCloud from Connection  https://review.openstack.org/61098114:06
mordredShrews: ^^ there ya go14:06
*** Gurpreet_ has joined #openstack-sdks14:09
samueldmqwhat's the typical error code when quota is not enough?14:12
mordredShrews, dtantsur, samueldmq: was thinking, as you can likely see, that clarkb was right and that making shade.OpenStackCloud subclass from openstack.Connection may have been a mistake. Instead, just freezing shade at its current point in time so that shade users can happily not get messed with14:13
mordredsamueldmq: oh golly - no clue :)14:13
samueldmqmordred: :(14:14
dtantsurmordred: I think the baremetal shade parts need a lot of love, so dunno about freezing them..14:14
samueldmqnova servers says the precondition is to have enough quota, but doesn't specify the error code14:14
mordredsamueldmq: http://git.openstack.org/cgit/openstack-infra/nodepool/tree/nodepool/driver/openstack/handler.py#n25614:14
samueldmqmordred: :-)14:15
mordredsamueldmq: we should maybe figure out how to throw a better execption in sdk :)14:15
mordreddtantsur: well, we should definitely fix them in sdk ... then we can suggest to people that they just migrate from shade to sdk if they want to use baremetal?14:16
samueldmqthat's very realiable, until someone decides to use SDK in Portuguese14:16
mordredsamueldmq: silly them14:16
samueldmqSDK is fun.14:18
dtantsurmordred: I'm fine with that, but that's quite a change in the direction :)14:18
* dtantsur stops producing moar patches for now14:18
mordreddtantsur: oh - wait - I have potentially produced confusing words14:19
mordreddtantsur: I meant the shade library itself, not the shade parts of the openstacksdk library14:19
mordreddtantsur: it was actually the baremetal work you've been doing that made me think this - I like all the cleanups, and I think needing to keep in mind the older shade library while you do them is ... not super useful14:19
dtantsurright, yeah..14:20
mordreddtantsur: https://review.openstack.org/610981 might be clearer :)14:21
dtantsurgotcha, makes sense14:22
openstackgerritMerged openstack/openstacksdk master: Use network proxy in openstack.cloud  https://review.openstack.org/60464514:38
openstackgerritMerged openstack/openstacksdk master: Remove all the deprecated stuff  https://review.openstack.org/60550814:38
openstackgerritMerged openstack/openstacksdk master: Start shifting cloud object-store methods to proxy  https://review.openstack.org/60831714:38
openstackgerritMerged openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin  https://review.openstack.org/60831814:38
openstackgerritMerged openstack/openstacksdk master: Revert the Proxy metaclass  https://review.openstack.org/60974714:38
openstackgerritMerged openstack/openstacksdk master: Wire in retries for all baremetal actions  https://review.openstack.org/60342714:38
mordreddtantsur: don't kill me ... but in https://review.openstack.org/#/c/610024/2/openstack/cloud/openstackcloud.py - I don't think you even need the _to_munch() call14:46
dtantsurmaybe? I have hard time following the fast pace of changes here :)14:47
mordreddtantsur: I know :)14:47
dtantsuris Resource a dict now?14:47
mordredso hopefully we'll get to a place where we can use the Resource objects interchanably no matter whether someone used the shade layer or the sdk layer14:48
* dtantsur tries14:48
dtantsurAssertionError: Keys {'uuid', 'node_uuid'} are in Munch({'address': '00:01:02:03:04:05', 'node_uuid': '7172e42c-394f-4693-8e33-24d4cebf6813', 'uuid': '935433196bc54ac7b236732ef681bd37'}) but not in openstack.baremetal.v1.port.PortDetail(address=00:01:02:03:04:05, node_uuid=7172e42c-394f-4693-8e33-24d4cebf6813, uuid=935433196bc54ac7b236732ef681bd37)"14:52
dtantsurI wonder if uuid->id conversion screws me up in this test14:53
dtantsurmordred: ^^^14:53
mordreddtantsur: hrm. which test?14:55
dtantsurmordred: openstack.tests.unit.cloud.test_baremetal_ports.TestBaremetalPort.test_list_nics (try removing to_munch from my patch)14:55
dtantsuryeah, I highly suspect id vs uuid can be a problem. we can fix it in the test, but then it's a breaking change (?)\14:56
mordreddtantsur: how distasteful do you find this: http://paste.openstack.org/show/732253 ?15:05
dtantsurmordred: aren't we breaking our unification promise with s/id/uuid/ ?15:06
mordredactually, http://paste.openstack.org/show/732254 is better15:07
mordreddtantsur: amazingly enough that code sill produces port_detail.id15:07
dtantsurso, we're going to have both id and uuid on a resource?15:07
mordredmaybe? mostly just thinking out loud right now :)15:08
dtantsurI'll need to think about it for some time. what if we merge the to_munch variant for now, given that we already have this to_munch here and there?15:09
dtantsurand I'll take some deeper thought on the id vs uuid situation15:09
mordreddtantsur: sure - although, I think the test break is showing that we're winding up returning munch's with uuid in them instead of id?15:09
dtantsurmordred: which is what we have been doing so far, no?15:10
mordreddtantsur: http://paste.openstack.org/show/732255 is a bit more explicit and also works with the test15:10
dtantsurgiven that normalize_machine has never done s/uuid/id/15:10
dtantsurwhat I'm trying to say: baremetal functions in the shade and SDK parts already differ in this regard15:11
mordredyah - totally, although I'd say that not normalizing uuid to id was an oversight ... and one of the reasons decoupling the released shade library from the new shade portions of the sdk might be a good idea here ... shade was always also supposed to use id instead of uuid for things15:12
mordredif we return both uuid and id, then we should be able to move people towards just using id without breaking anyone who might be using it curently ... at the cost of a less clean interface15:12
mordredBUT - the number of consumersof openstacksdk shade layer so far should be fairly small, so maybe we do both in this next point release with an insta-deprecate on the uuid properties?15:13
mordredprobably all of these options are wrong :)15:13
mordredI clearly have not consumed enough coffee yet15:14
dtantsurthat's why I'd prefer a time out to think about it :)15:14
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return both uuid and id for baremetal port  https://review.openstack.org/61100915:15
mordreddtantsur, Shrews: ^^ I pushed up my change as a followup so that we can look at it and ponder and argue properly15:16
dtantsurmordred: instant comment: we need the same of all bm resources15:20
mordreddtantsur: oh - totally - whatever we decide here should apply across the board15:23
dtantsurmordred: is it possible to hide "uuid" from the resource and only make it visible when using dict stuff?15:23
dtantsurkind of thinking aloud15:24
mordreddtantsur: it's python - anything is possible :)15:24
dtantsurreasonable is a different question15:24
mordreddtantsur: not sure - would have to poke - I thinkn work already goes in to aligning object and dict access though15:24
dtantsuryeah, stupid idea probably...15:24
* dtantsur just hates having both15:25
mordredme to15:25
mordredme too15:25
dtantsurI'm thinking about ugly cases like creating a node with different id and uuid :D15:25
mordred>>> p = openstack.baremetal.v1.port.PortDetail(id='123', uuid='345')15:27
mordred>>> p._to_munch()15:28
mordredMunch({'node_uuid': None, 'extra': None, 'pxe_enabled': None, 'id': '345', 'name': None, 'internal_info': None, 'links': None, 'local_link_connection': None, 'updated_at': None, 'created_at': None, 'portgroup_uuid': None, 'address': None, 'physical_network': None, 'location': None, 'uuid': '345'})15:28
mordredyeah. that's not what we want :)15:28
dtantsuryeah, I wonder what happens if you try to create such port..15:30
dtantsurwell, ports do not allow to specify uuid on creation, but nodes do (consistency!)15:30
openstackgerritMerged openstack/os-api-ref master: tests: Support Sphinx 1.8+  https://review.openstack.org/60798415:36
*** Gurpreet_ has quit IRC15:39
openstackgerritweizj proposed openstack/os-service-types master: Update the hacking to latst  https://review.openstack.org/61105415:48
openstackgerritMerged openstack/openstacksdk master: Move wait_for_baremetal_node_lock to the baremetal proxy  https://review.openstack.org/61094615:49
*** e0ne has quit IRC15:50
dtantsurmordred: re https://review.openstack.org/610024 are you okay with it for now?15:52
openstackgerritMerged openstack/openstacksdk master: Remove duplicate code  https://review.openstack.org/61040415:52
mordreddtantsur: yeah - I thnk it's fine for today - it's not an additional issue from what today is15:54
mordreddtantsur: I think we should solve the other question before we 1.015:54
* dtantsur sees 1.0 moving closer to end of stein with every discussion :)15:55
dtantsurmy personal minimum plan is to get rid of every single hardcoded microversion=1.6 by the release15:56
mordreddtantsur: yah - I agree re: 1.0 ... I think this next point release will be close enough to 1.0 that we can start working on using it more within osc (discovery and resources-as-dicts were the last two things I was worried about getting in before we started doing that)15:57
dtantsurand osc does not use baremetal stuff, so this is not a concern here15:59
openstackgerritEric Fried proposed openstack/os-service-types master: Update the hacking to latst  https://review.openstack.org/61105416:01
*** noama has quit IRC16:10
openstackgerritMerged openstack/os-service-types master: Don't quote {posargs} in tox.ini  https://review.openstack.org/60897316:20
openstackgerritMerged openstack/os-service-types master: Removed older version of python added 3.5  https://review.openstack.org/60636816:20
openstackgerritMerged openstack/os-service-types master: Add unittest for os_service_types.data module.  https://review.openstack.org/59670116:20
*** d0ugal has quit IRC16:21
*** d0ugal has joined #openstack-sdks16:23
*** jpich has quit IRC16:29
*** jpena is now known as jpena|off16:45
*** dtantsur is now known as dtantsur|afk17:03
*** e0ne has joined #openstack-sdks17:08
openstackgerritMerged openstack/openstacksdk master: Switch bare metal NIC actions in OpenStackCloud to baremetal Proxy calls  https://review.openstack.org/61002417:12
eanderssonanytime mordred !17:41
*** e0ne has quit IRC17:59
*** olivierb has quit IRC18:02
*** e0ne has joined #openstack-sdks18:15
*** e0ne has quit IRC18:22
*** bobh has quit IRC18:54
*** bobh has joined #openstack-sdks18:56
*** bobh has quit IRC19:01
openstackgerritMerged openstack/os-service-types master: Update the hacking to latst  https://review.openstack.org/61105419:02
*** dave-mccowan has quit IRC19:07
openstackgerritSean McGinnis proposed openstack/keystoneauth master: Update sphinx extension logging  https://review.openstack.org/61113519:21
openstackgerritSean McGinnis proposed openstack/openstacksdk master: Update sphinx extension logging  https://review.openstack.org/61113819:27
*** bobh has joined #openstack-sdks19:32
*** bobh has quit IRC19:37
openstackgerritMerged openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name.  https://review.openstack.org/61092119:57
*** olivierb has joined #openstack-sdks19:59
*** bobh has joined #openstack-sdks20:06
*** bobh has quit IRC20:12
openstackgerritSean McGinnis proposed openstack/os-api-ref master: Update sphinx extension logging  https://review.openstack.org/61115720:14
*** cdent has quit IRC20:24
*** slaweq has quit IRC20:33
*** bobh has joined #openstack-sdks20:38
*** bobh has quit IRC20:52
*** mriedem is now known as mriedem_away21:02
*** bobh has joined #openstack-sdks21:28
*** bobh has quit IRC21:33
openstackgerritMonty Taylor proposed openstack/openstacksdk master: DNM Testing inline pep8  https://review.openstack.org/61074421:36
*** lbragstad is now known as lbragstad-50321:42
*** slaweq has joined #openstack-sdks21:53
*** mriedem_away has quit IRC21:55
*** smcginnis is now known as smcginnis_vaca21:55
*** slaweq has quit IRC22:09
*** slaweq has joined #openstack-sdks22:11
*** slaweq has quit IRC22:44
*** tosky has quit IRC23:10
*** slaweq has joined #openstack-sdks23:11
openstackgerritMerged openstack/openstacksdk master: Update sphinx extension logging  https://review.openstack.org/61113823:21
*** slaweq has quit IRC23:44

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!