Tuesday, 2018-07-03

openstackgerritMerged openstack/osc-lib master: Delete the output in "find_bulk" api  https://review.openstack.org/57537200:03
*** edmondsw has joined #openstack-sdks00:23
*** JudeC_ has joined #openstack-sdks00:24
*** JudeC__ has quit IRC00:25
*** tellesnobrega has quit IRC00:26
*** edmondsw has quit IRC00:28
*** tellesnobrega has joined #openstack-sdks00:32
*** kimamisa has quit IRC00:38
openstackgerritMerged openstack/osc-lib master: Add OpenTracing based driver id  https://review.openstack.org/56649300:50
*** gkadam_ has quit IRC01:07
*** gkadam has joined #openstack-sdks01:10
*** mhen has quit IRC01:32
*** mhen has joined #openstack-sdks01:32
*** annp has joined #openstack-sdks01:52
*** JudeC_ has quit IRC01:57
*** olaph has quit IRC04:04
*** olaph has joined #openstack-sdks04:06
openstackgerritMerged openstack/osc-lib master: fix tox python3 overrides  https://review.openstack.org/57291504:11
*** gkadam has quit IRC05:04
*** gkadam has joined #openstack-sdks05:08
*** gkadam has quit IRC05:31
*** edmondsw has joined #openstack-sdks05:48
*** edmondsw has quit IRC05:53
*** Luzi has joined #openstack-sdks06:00
openstackgerrittianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type  https://review.openstack.org/57776806:15
openstackgerrittianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type  https://review.openstack.org/57776806:18
Luzimordred: I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class?06:26
*** gtema has joined #openstack-sdks06:33
*** openstackgerrit has quit IRC06:49
*** liangbo has joined #openstack-sdks06:54
*** gtema has quit IRC06:59
*** gtema has joined #openstack-sdks07:00
*** kimamisa has joined #openstack-sdks07:18
*** gildub has joined #openstack-sdks07:18
*** peereb has joined #openstack-sdks07:21
*** openstackgerrit has joined #openstack-sdks07:32
openstackgerrithuangshan proposed openstack/openstacksdk master: Add vip_qos_policy_id options for loadbalancer  https://review.openstack.org/57979407:32
*** kimamisa has quit IRC07:35
*** edmondsw has joined #openstack-sdks07:36
*** edmondsw has quit IRC07:41
*** kimamisa has joined #openstack-sdks07:44
*** jpena|off is now known as jpena07:52
*** jpich has joined #openstack-sdks08:03
*** halbbalda has quit IRC08:14
*** halbbalda has joined #openstack-sdks08:16
*** ralonsoh has joined #openstack-sdks08:30
*** gkadam has joined #openstack-sdks08:33
*** cdent has joined #openstack-sdks08:56
*** cdent_ has joined #openstack-sdks09:04
*** cdent has quit IRC09:05
*** cdent_ is now known as cdent09:05
*** edmondsw has joined #openstack-sdks09:25
*** edmondsw has quit IRC09:29
*** e0ne has joined #openstack-sdks09:33
openstackgerrityanpuqing proposed openstack/python-openstackclient master: Add error message when using "set" command without all optional arguments  https://review.openstack.org/57951509:38
*** gildub has quit IRC09:44
*** liangbo has quit IRC10:04
*** dtantsur|afk is now known as dtantsur10:14
*** abishop has joined #openstack-sdks10:15
*** cdent has quit IRC10:25
*** jpena is now known as jpena|lunch11:29
dtantsurmordred: morning! any comments/suggestions on https://etherpad.openstack.org/p/microversions-better-than-beer ? particularly, a catchy title?12:15
dtantsuralso do you really want to participate or am I being too pushy to force it on you? :)12:16
*** jpena|lunch is now known as jpena12:28
fricklerdtantsur: mordred mentioned earlier in infra that he needs to do some bookkeeping before anything else, not sure whether that will apply here, too12:38
dtantsurfrickler: oh, I see, thanks!12:39
*** mriedem has joined #openstack-sdks12:51
*** yetiszaf has joined #openstack-sdks12:54
*** r-mibu has joined #openstack-sdks13:00
*** thrash|g0ne is now known as thrash13:00
*** edmondsw has joined #openstack-sdks13:01
*** edmondsw has quit IRC13:06
*** mriedem is now known as mriedem_afk13:09
*** crunchengine has joined #openstack-sdks13:11
mordreddtantsur: morning!13:24
mordreddtantsur: definitely want to participate ...13:25
fricklerdtroyer: could you add https://review.openstack.org/516701 and https://review.openstack.org/558824 to your review list, please? would be great to get these in for this cycle and also still have time to amend the Neutron docs accordingly13:26
dtantsurmordred: cool! no big pressure, but let's try to propose it by EOW since I'm out next week13:27
mordreddtantsur: I'm adding terrible titles13:29
dtantsur"Dmitry used Microversions and you won't believe what happened next..." AAAaaaaAAAAaaa :D13:29
mordredthat one is growing on me13:31
dtantsurmordred: I think #3 (unbearable lightness) is at the right crossing of being fun and acceptable for the audience :)13:31
dtantsurbut yes, #2 is so great13:31
mordredalso - white trash fast food is currently closed, so it's maybe not a great metaphor13:32
dtantsurmordred: is it some known thing?13:33
dtantsurI mean, this fast food thing13:34
mordreddtantsur: http://www.whitetrashfastfood.com/ - it's my favorite berlin restaurant (or, it was)13:34
dtroyerfrickler: will do… I'm wrapping up osc-lib first then back to osc itself13:35
dtantsurmordred: oh that's pity13:35
mordredyah. I'm hoping it comes back13:36
dtantsuryep. it's not even too far from my place (but in a, well, "funny" neighborhood)13:37
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported  https://review.openstack.org/57896013:37
fricklerdtroyer: cool, thx. I also asked a question about handling microversions, not sure whether this has been discussed globally already. mordred and dtantsur might also be interested. https://review.openstack.org/#/c/577768/4/openstackclient/compute/v2/keypair.py@8413:39
* dtantsur puts on this flame war costume13:39
Luzimordred, I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class?13:40
dtantsurfrickler: well, I left the same comment on an earlier revision13:40
* dtantsur comments13:41
mordredI think that's about as good as one can do before we plumb all the discovery stuff through - since the model there is assuming a configured api version13:41
fricklerdtantsur: oh, that was on the other review. but good to see we seem to agree13:42
dtantsuroh, right, another one13:42
dtantsurmordred: cannot we do version = max('2.2', os_compute_api_version) here?13:42
mordrednot without checking to see what api versions the remote side supports13:43
dtantsuranother thing to consider: we ended up with defaulting --os-baremetal-api-version to the known latest in ironicclient13:43
dtantsurmordred: why not? the requested will fail reasonably if the remote side only supports 2.1, no?13:43
mordredah - hrm. yeah - I suppose so in this case13:44
*** mriedem_afk is now known as mriedem13:44
dtantsurassuming we can provide a microversion per request in OSC13:45
mordredwe can using sdk - not so much with novaclient13:45
dtantsurwhich one is used by OSC?13:45
mordred*except* - at least in my world, if a user has explicity set a config value for a specific microversion in compute_api_version - I would argue that we should not override that setting13:45
mordreddtantsur: novaclient for now - although at some point we're hoping to get things shifted over to sdk - dean is waiting on a 1.0 from sdk before starting in on that13:46
dtantsuryep, so maybe if os_compute_api_version is None: os_compute_api_version = '2.2' elif os_compute_api_version < '2.2': boom13:46
mordreddtantsur: yah- I think that would be good and upwards compatible with a future where compute_api_version might not be set13:46
mordred(today it'll always be set because of defaults - but once we've got the discovery stuff finished plumbed through, it can start being None and things working)13:47
dtantsurah, random defaults, similar to 1.6 in ironic? :)13:47
* mordred hails our lord and master 1.613:47
dtantsur* 1.9 in ironicclient and 1.6 in openstacksdk because we LOVE consistency13:48
mordredwell - I've almost got the last discovery patch for sdk written in my head - so hopefully we're almost there13:48
mordredLuzi: hello! yes - I agree, putting it in OpenStackCloud is not the right place ...13:48
mordredLuzi: I've got a half-written patch on my laptop which should make a better place for you to put the generator13:49
mordredLuzi: let me push up the work-in-progress in just a few minutes and see what you think13:49
Luzimordred, that sounds good :)13:50
mordredLuzi: the generator class itself should probably just go in its own file in openstack/image - and then it should get attached to the image upload code in openstack/image/v1/_proxy and openstack/image/v2/_proxy ... but step 1 is to take the existing image upload logic from openstackcloud and move it to the proxy classes13:51
*** bobh has joined #openstack-sdks13:57
mordredfrickler: speaking of osc patches - https://review.openstack.org/#/c/540541/13:58
dtantsurmordred: any reason Resource does not implement the dict interface? This way it would be compatible with a Munch14:00
dtantsure.g. I could start returning openstack.baremetal.v1.Node from *machine* calls14:00
mordreddtantsur: that is the _other_ main patch I wanna finish before cutting 1.014:00
dtantsurvery good :)14:01
mordreddtantsur: https://review.openstack.org/#/c/530835/ is the very broken WIP patch for that14:01
dtantsurI want to move *machine* calls to use openstack.baremetal.v1.* stuff internally, but currently they return incompatible result14:01
mordredwe share the same goal14:02
dtantsurI guess currently I can do munchify(node.to_dict()) as an ugly hack14:03
dtantsurbut what I'm hitting with my provisioning state patch is that I get a redundant GET call on each conversion between a Munch and a Node14:04
dtantsurwhich is probably fine for now, but has to be fixed eventually14:04
mordredyah - extra calls seem lame14:04
*** mriedem has quit IRC14:04
dtantsuris it acceptable temporary?14:04
*** mriedem has joined #openstack-sdks14:04
mordreddtantsur: I'd be curious to discover why a GET call is being made during the conversion ...14:06
openstackgerritMonty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects  https://review.openstack.org/57913914:07
dtantsurmordred: https://review.openstack.org/#/c/570895/4/openstack/cloud/openstackcloud.py@9400 causes uuid-to-Node conversion14:07
mordreddtroyer: ^^ that patch passes for me locally now, so might be not a waste of your time to review14:07
dtantsureven when this call is used from e.g. register_machine where we already have a Munch14:07
dtantsurbecause we cannot pass in a Munch, we need a UUID or a Node14:07
mordredif we have a munch, we should be able to make a Node from it without an api call - I'd think Node(**munch_node) would do the trick?14:09
dtantsurgood idea, maybe we should generalize it as Resource.from_munch?14:10
dtantsurdefaulting to just cls(**munch)14:11
fricklermordred: oh, that makes me wonder whether it'll fix my neutron ssl issues. will check.14:12
mordreddtantsur: good idea - although maybe make it Resource._from_munch for now - since we might not need it once we finish and land the other thing14:13
dtantsurmordred: okay, I'll see what I can do14:14
dtroyermordred: coolio, will have a look14:14
*** bobh has quit IRC14:18
dtroyermordred: looks nice, thank you!14:23
mordreddtroyer: yay!14:27
*** gkadam_ has joined #openstack-sdks14:28
*** gkadam has quit IRC14:30
*** Luzi has quit IRC14:35
*** wacuuu has joined #openstack-sdks14:47
*** edmondsw has joined #openstack-sdks14:51
*** edmondsw has quit IRC14:55
*** peereb has quit IRC15:05
*** e0ne has quit IRC15:29
*** thrash is now known as thrash|f00dz16:06
*** jpich has quit IRC16:06
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method  https://review.openstack.org/57990816:11
dtantsurmordred: ^^^16:11
dtantsurnow let's see if I can get a good use of it16:11
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use shade create_image method in image proxy layer  https://review.openstack.org/57916816:11
mordreddtantsur: neat. I could probably use that in that patch ^^16:11
* mordred still needs to do more work on that concept - the logic for the methods needs to get moved, etc ...16:12
dtantsurmordred: oh, curious, I'm doing it the other way around in my patch: shade level calling baremetal proxy16:12
dtantsuris there The Right approach here? or just whatever fits?16:13
*** kimamisa has quit IRC16:14
dtantsurhmm, and should I wire this _from_munch into Proxy._get_resource? so that all proxies support it automagically?16:20
dtantsurthis can be dangerous, maybe only for ironic for now..16:20
dtantsuractually, from_munch can probably be implemented using the Body() fields16:22
* dtantsur thinks more16:22
*** yolanda has joined #openstack-sdks16:24
*** r-mibu has quit IRC16:29
*** gkadam__ has joined #openstack-sdks16:30
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method  https://review.openstack.org/57990816:32
*** gkadam_ has quit IRC16:32
*** ralonsoh has quit IRC16:35
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies  https://review.openstack.org/57990816:43
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies  https://review.openstack.org/57990816:55
*** dtantsur is now known as dtantsur|afk17:09
*** thrash|f00dz is now known as thrash17:12
*** jpena is now known as jpena|off17:35
mordreddtantsur|afk: your way is the better way - we want to get to the shade layer calling the proxy layer rather than the other way around17:42
mordreddtantsur|afk: but for create_image that's going to require some surgery, so I figured invert it for now, then iterate on getting it done right as a followup17:43
*** e0ne has joined #openstack-sdks17:45
*** gtema has quit IRC17:48
*** tellesnobrega has quit IRC17:52
*** cdent has joined #openstack-sdks18:13
*** yolanda_ has joined #openstack-sdks18:18
*** yolanda has quit IRC18:20
*** olaph1 has joined #openstack-sdks18:24
*** olaph has quit IRC18:26
*** yolanda__ has joined #openstack-sdks18:27
*** edmondsw has joined #openstack-sdks18:27
*** yolanda_ has quit IRC18:30
*** mriedem has quit IRC18:31
*** edmondsw has quit IRC18:32
*** mriedem has joined #openstack-sdks18:39
*** halbbalda has left #openstack-sdks18:54
*** bobh has joined #openstack-sdks19:00
*** tellesnobrega has joined #openstack-sdks19:22
*** bobh has quit IRC19:25
*** e0ne has quit IRC19:40
*** olaph1 has quit IRC19:40
*** bobh has joined #openstack-sdks19:42
*** bobh has quit IRC19:46
*** bobh has joined #openstack-sdks19:47
*** olaph has joined #openstack-sdks19:50
*** bobh has quit IRC20:05
*** yolanda_ has joined #openstack-sdks20:14
*** edmondsw has joined #openstack-sdks20:16
*** yolanda has joined #openstack-sdks20:16
*** yolanda__ has quit IRC20:18
*** yolanda_ has quit IRC20:18
*** yolanda_ has joined #openstack-sdks20:19
*** abishop has quit IRC20:20
*** edmondsw has quit IRC20:21
*** yolanda has quit IRC20:22
*** yolanda__ has joined #openstack-sdks20:24
*** yolanda_ has quit IRC20:24
openstackgerritDavid Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods  https://review.openstack.org/57997420:28
Shrewsthat probably could use a test20:29
mordredyah. also - I'm pretty sure pep8 is going to complain about the whitespace20:29
openstackgerritDavid Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods  https://review.openstack.org/57997420:32
Shrewspep8 passed for me20:32
mordredShrews: cool20:33
Shrewsmordred: you want a release note for that?20:35
wacuuuyyy question: are there any plans for sdk in go?20:38
mordredwacuuu: the gophercloud project is basically that20:42
mordredShrews: nah20:42
mordredwacuuu: https://github.com/gophercloud/gophercloud20:42
Shrewsoh that's interesting20:47
Shrewsmordred: my fav part: "Backwards-Compatibility Guarantees - None. Vendor it and write tests covering the parts you use."20:47
*** wacuuu has quit IRC21:05
*** gkadam__ has quit IRC21:35
*** lbragstad is now known as lbragstad_50322:02
*** edmondsw has joined #openstack-sdks22:05
*** edmondsw has quit IRC22:09
*** mriedem is now known as mriedem_explosio22:14
*** mriedem_explosio is now known as mriedem_burnmark22:14
*** crunchengine has quit IRC22:22
*** cdent has quit IRC22:23
*** dtruong has quit IRC22:30
*** gildub has joined #openstack-sdks23:24
*** mriedem_burnmark has quit IRC23:30
*** edmondsw has joined #openstack-sdks23:53
*** edmondsw has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!