Tuesday, 2018-03-20

EmilienMhi, any chance to have a review on https://review.openstack.org/#/c/553374/ please00:21
*** lifeless_ has joined #openstack-sdks00:46
*** lifeless has quit IRC00:46
*** chenyb4 has joined #openstack-sdks01:02
*** Kevin_Zheng has joined #openstack-sdks01:14
*** dayou has quit IRC01:56
*** annp has joined #openstack-sdks01:56
*** gildub has joined #openstack-sdks02:17
*** dave-mccowan has quit IRC02:31
*** gildub has quit IRC02:31
*** gildub has joined #openstack-sdks02:32
*** yolanda has quit IRC02:44
*** yolanda has joined #openstack-sdks02:45
*** ldl has joined #openstack-sdks02:46
*** ldl has quit IRC02:46
*** ldl has joined #openstack-sdks02:46
openstackgerritchenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error  https://review.openstack.org/55440302:50
*** salv-orl_ has joined #openstack-sdks02:50
*** salv-orlando has quit IRC02:52
*** yolanda has quit IRC02:53
*** yolanda has joined #openstack-sdks02:54
*** e0ne has joined #openstack-sdks06:21
*** gildub has quit IRC06:26
*** dayou has joined #openstack-sdks06:48
openstackgerritchenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error  https://review.openstack.org/55440307:09
*** d0ugal has joined #openstack-sdks07:12
*** d0ugal has quit IRC07:12
*** d0ugal has joined #openstack-sdks07:12
*** gildub has joined #openstack-sdks07:17
*** d0ugal has quit IRC07:21
openstackgerritPeter Balogh proposed openstack/python-openstacksdk master: Fix TypeError in case of FloatingIP add and remove  https://review.openstack.org/55211207:25
openstackgerritchenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error  https://review.openstack.org/55440307:26
*** tovin07 has joined #openstack-sdks07:31
*** salv-orl_ has quit IRC07:32
*** salv-orlando has joined #openstack-sdks07:33
*** salv-orlando has quit IRC07:33
*** salv-orlando has joined #openstack-sdks07:33
*** d0ugal has joined #openstack-sdks07:49
*** kmy has joined #openstack-sdks08:04
*** jpena|off is now known as jpena08:11
*** gildub has quit IRC08:21
*** gildub has joined #openstack-sdks08:21
*** gkadam has joined #openstack-sdks08:22
*** Kevin_Zheng has quit IRC08:30
*** Kevin_Zheng has joined #openstack-sdks08:31
*** e0ne has quit IRC08:33
*** cdent has joined #openstack-sdks08:50
*** d0ugal has quit IRC09:02
*** jpich has joined #openstack-sdks09:07
*** baffle has quit IRC09:13
*** baffle has joined #openstack-sdks09:14
*** ralonsoh has joined #openstack-sdks09:35
*** gildub has quit IRC09:38
*** kmy has quit IRC09:45
*** kmy has joined #openstack-sdks09:47
*** e0ne has joined #openstack-sdks09:55
*** gildub has joined #openstack-sdks10:05
openstackgerritchenyb4 proposed openstack/python-openstacksdk master: Use defined version instead of service.version parameter  https://review.openstack.org/55422310:28
*** gildub has quit IRC10:28
*** gildub has joined #openstack-sdks10:30
*** ralonsoh_ has joined #openstack-sdks10:33
*** ralonsoh has quit IRC10:37
*** jpena is now known as jpena|brb10:38
*** kmy has quit IRC10:50
*** kmy has joined #openstack-sdks10:51
*** ralonsoh__ has joined #openstack-sdks11:03
*** ralonsoh_ has quit IRC11:07
*** annp has quit IRC11:15
*** dayou has quit IRC11:25
*** jpena|brb is now known as jpena11:37
*** dayou has joined #openstack-sdks11:47
*** chenyb4 has quit IRC12:00
*** edmondsw has joined #openstack-sdks12:17
*** openstackgerrit has quit IRC12:33
mugsieelmiko: if you have any questions, please give me a ping :)12:36
elmikomugsie: ack, will do!12:38
*** d0ugal has joined #openstack-sdks12:41
*** d0ugal has quit IRC12:41
*** d0ugal has joined #openstack-sdks12:41
*** jpena is now known as jpena|lunch12:44
cdentelmiko, edleafe, anything blocking merging those microversion-parse changes? You guys +1d, but you should have the power to +2 if you want. I'd like to release a new version, even if its not yet perfect (as long as it doesn't break stuf, that's good enough)12:45
elmikocdent: nothing blocking from me12:49
elmikogimme like an hour and i can start adding the +2s12:49
elmikounless edleafe gets to it first ;)12:50
cdentcool, thanks, no huge rush, just got reminded of it by my to do list12:50
*** gildub has quit IRC12:54
*** ldl has quit IRC13:03
edleafecdent: elmiko: I had one little comment, but added a +2. elmiko, if you agree, wanna push it through?13:08
elmikoedleafe: sounds good!13:09
*** chenyb4 has joined #openstack-sdks13:37
*** jpena|lunch is now known as jpena13:42
*** SamYaple has quit IRC13:52
elmikocdent: i +w to the 2 that had other support13:53
elmikoi'd prefer more than just my lone review on these:13:53
*** openstackgerrit has joined #openstack-sdks13:54
openstackgerritChris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers  https://review.openstack.org/55454713:54
cdentelmiko: yeah. edleafe I added another patch to the end fixing the bug.13:55
*** dmellado has quit IRC13:55
elmikois that the one you just posted?13:55
elmikolooked sensible13:55
edleafecdent: cool. I would have just fixed it in place, but... meh13:59
openstackgerritMerged openstack/microversion-parse master: Provide a helper method to get headers from environ  https://review.openstack.org/49535613:59
cdentedleafe: for a change that didn't check that method at all? dirty!13:59
openstackgerritMerged openstack/microversion-parse master: Import functions from placement  https://review.openstack.org/49621214:00
edleafeGuess I'm a dirty guy14:01
cdentNewflash: edleafe states well known fact, wins t-shirt14:02
edleafeMy wardrobe needs sprucing up14:02
openstackgerritJens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails  https://review.openstack.org/55404414:04
*** stevebaker has quit IRC14:04
fricklerkmalloc: ^^ just for you ;)14:05
*** finucannot is now known as stephenfin14:07
*** bobh has joined #openstack-sdks14:07
elmikocdent: LOL14:10
*** SamYaple has joined #openstack-sdks14:11
*** chenyb4 has quit IRC14:14
*** chenyb4 has joined #openstack-sdks14:17
cdentedleafe: use your dirty old guy wisdom to fix that attribute problem on Version, I responded14:20
elmikothat sounds like the best super power ever14:28
openstackgerritMerged openstack/os-client-config master: Add image_format for VEXXHOST profile  https://review.openstack.org/55435114:36
*** d0ugal has quit IRC14:38
*** stevebaker has joined #openstack-sdks14:42
mnasermordred: did you ever get around this? https://specs.openstack.org/openstack/openstack-specs/specs/clouds-yaml-support.html14:47
mnaseri have a user who likes using python-openstackclient because clouds.yaml, but image member list is missing from it right now, so they have to use glanceclient14:47
*** chenyb4 has quit IRC14:48
mordredmnaser: we should just fix python-openstackclient - I've given up on that spec in favor of thinking we should delete python-*client14:48
mnasermordred: ok cool, i'll try to push a patch to add that support i guess14:49
mnasermordred: accepting and rejecting memberships is there, just listing is missing14:49
edleafecdent: who said I'm old??14:49
mordrededleafe: who didn't?14:49
*** chenyb4 has joined #openstack-sdks14:50
* edleafe shakes his cane at mordred 14:50
edleafecdent: answered14:50
* mordred falls over in alarm and probably breaks his hip14:50
*** dmellado has joined #openstack-sdks14:54
kmallocfrickler: fantastic!14:56
kmallocfrickler: thanks for the test!14:56
*** dmellado has quit IRC14:56
kmallocmordred: can we please delete python-*-client?14:57
kmallocmordred: please? :)14:57
mordredkmalloc: ++14:57
*** dtantsur|afk is now known as dtantsur15:00
*** dmellado has joined #openstack-sdks15:01
dtantsurelmiko: office hours is not a bad idea, but I also think that we should encourage people to talk async and on public ML15:02
dtantsure.g. I won't be able to attend apac-friendly times, I suspect15:02
dtantsuror rather: either me or the US15:02
edleafedtantsur: early APAC is late for me15:03
*** dmellado has quit IRC15:04
openstackgerritChris Dent proposed openstack/microversion-parse master: Improve Version.matches() method  https://review.openstack.org/55025115:04
openstackgerritChris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware  https://review.openstack.org/55025215:04
openstackgerritChris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware  https://review.openstack.org/55026315:04
openstackgerritChris Dent proposed openstack/microversion-parse master: Clean up package version and python version support  https://review.openstack.org/55026415:04
openstackgerritChris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers  https://review.openstack.org/55454715:04
cdentthere ya go edleafe, I think. and thanks.15:04
*** dmellado has joined #openstack-sdks15:05
*** stevebaker has quit IRC15:06
mnaseri'm working on adding support for glance image list15:07
mnaseri'm getting this when trying to run commands in tox venv (tox -evenv -- openstack image list)15:07
mnaser'module' object has no attribute 'OpenStackConfigException'15:07
mnaserany ideas?15:07
mnaserunless im doing something wrong, i dont think anything should be causing an excpetion like that15:08
*** stevebaker has joined #openstack-sdks15:10
*** d0ugal has joined #openstack-sdks15:10
mnaserok looks like it tries to get occ_exceptions from openstack.config and fallback to os_client_config if it cant find it15:10
mnaseros_client_config has OpenStackConfigException but i have no idea what 'openstack.config' comes from15:10
mnaserhttps://github.com/openstack/osc-lib/commit/86129e6f88289ef14bfaa3f7c9cdfbea8d9fc944 looks like this might be related?15:11
mnaseror actually, mordred: https://github.com/openstack/python-openstacksdk/commit/80716c144203a37edc7ddd324e0bc6be6cfda1e5 the renaming of OpenStackConfigException => ConfigException here broke things15:12
dtroyermnaser: what SDk version do you have?15:12
mnaserdtroyer: working on master using tox, so i assume whatever the latest thing it'll pull15:13
mnaserdtroyer: requirements.txt looks like it points to openstacksdk>=0.11.2 -- let me see what wasa pulled i15:14
dtroyerI think there is a 0.12.0 now15:14
dtroyerthis spanning multiple versions during the changeover is getting long and painful15:15
*** dmellado has quit IRC15:16
*** stevebaker has quit IRC15:17
mnaserdtroyer: sorry, got a call, openstacksdk==0.12.0 indeed15:20
mnaseri think the best 'compatible' way to take care of this would be to subclass ConfigException in openstacksdk as a 'compatibility' shim in the meantime15:20
mnaseri can push up a patch if that's the best way of taking care of it for now15:21
cdentedleafe: since you're my python wisdom source today, how do you feel about iterating over a set and popping members out of it?15:23
dtroyermnaser: in theory this should have been caught by the -tips jobs, did it get missed because OSc functional tests don't touch that command?15:23
elmikodtantsur: ack, and yeah, it will be a team effort to provide what the community might want. in general i agree with the notion of promoting async comms15:24
mnaserdtroyer: well, im just writing this command now (list image members)15:24
mnaserbut i think this is probably broken with any command over all15:24
dtroyerok, I'm finally catching up on the exact problem15:26
EmilienMhello, can someone review https://review.openstack.org/#/c/553374/ please?15:27
dtroyerthat's a gap in the functional tests, ie no negative tests there15:27
EmilienMI'm ok to send free mapple sirup15:28
*** dave-mccowan has joined #openstack-sdks15:29
dtroyermnaser: I'd probably lean toward restoring the compatibility in the SDK for that exception, we're going to have to go through a lot of code to change all those over someday anyway but really can't do that yet15:29
dtroyerand yes, that potentially affects any command that needs auth15:30
*** chenyb4 has quit IRC15:30
openstackgerritMohammed Naser proposed openstack/python-openstackclient master: Add support to list image members  https://review.openstack.org/55459015:32
mnaser^ my first osc change so it probably is mising a whole lot of stuff (and couldn't find a sample to iterate on)15:32
mnaserdtroyer: so what would be the best direction (aka, can i help with that?)15:33
dtroyermnaser: my gut says to put in a compat exception back into the SDK since that is what changed.  It appears, though, that osc-lib _may_ be the only casualty, but it'll be messier to fix there until we rip out the os-client-config imports15:35
*** thrash is now known as thrash|bbl15:35
dtroyerwhich is not going to happen until we get an SDK 1.0 release15:35
mnaserdtroyer: and the concern is how do you make sure that gets removed eventually and doesn't sit ther forever, but i cant imagine that being very harmful15:35
*** stevebaker has joined #openstack-sdks15:36
mnaserunless, well, people start relying on it.15:36
mordredmnaser: sorry - on phone, will help in just a few15:36
mnaserwhich they probably will if thats what is bubbling up the excpetion in osc_lib15:36
mnasernp :)15:36
dtroyerI would expect it to get caught when cleaning up the o-c-c stuff15:36
mordredin the shade layer we made the old exception classes aliases for the new ones - we should defintely do that here15:37
dtroyerI'm planning to rip out much of that module for OSC 4 anyway so we'll default to doing basically the same thing that all other SDK consumers do WRT auth and special cases15:37
mordredmnaser: if we just put a OpenStackConfigException = ConfigException in openstack/config/exceptions.py it should be happier15:38
edleafecdent: it *can* be ok to do that; depends on what you're doing with the members of the set15:38
edleafecdent: generally I use a 'to_remove' var to hold the ones to remove, and then remove 'em after the iteration15:39
mnasermordred: ok cool, i'd nominate myself to push up a patch for that but i think it would be useful to have the context of that in a note/commit message which i'm probably not the best at writing given i dont know the whole relationship between all these clients :)15:39
cdentedleafe: I'll put it up for people to think about. I'm pretty sure it works for the case I've got, but we'll see15:39
cdentedleafe: it's basically this: http://paste.openstack.org/show/706227/15:40
edleafecdent: did you run that?15:44
cdentI'm getting ready to test it15:44
cdentbut I hadn't gotten that far because I realized it may very well be to dirty, so I thought I'd ask the dirty guy before I kept moving15:44
dtroyermnaser: regarding the new command, stevemar points out a prior attempt and the objection then that "image member" is not currently a resource in OSC.  I don't like that name, the only place OSC uses "member" at all is in the image set command options —accept, —reject and —pending, there phrased as "project membership status".  So we treat this as an image property already, not as a top-level resource15:45
edleafecdent: Generally you can't change the size of a set during an iteration over it15:46
dtroyerAdding a —member (or —membership or —project) option to image show seems more natural, except that the nested structure of a list of data inside a field is always messy15:46
*** stevebaker has quit IRC15:46
cdentedleafe: ooops, I misread the docs for set.pop() for one thing15:47
edleafecdent: Since they're sets, I'd just grab the set of forbidden, and then do difference_update() to remove the forbidden traits15:48
cdentyeah, I'll do that15:48
mnaserdtroyer: i see.. so what is it that you'd recommend, i think ideally image member should be a resource and things like 'image member add' and 'image member remove' should be how things are15:48
mnaser(or they should have been from the start, at least imho)15:48
mnaseras members are image resources, i guess we can compare them to metadata15:49
cdentedleafe: my confusion originated from conflating behaviors in a while loop with a for loop. but yeah, will do something that's less clever and actually works15:49
dtroyermnaser: we have image add/remove project already for that15:50
dtroyeragain, we didn't use the 'member' word15:50
mnaseryeah but then image list project is weird15:50
mnaseror doesnt even technically work15:50
dtroyerthere is a parallel to this with security groups and security group rules15:50
mnaserso what was the solution from that parallel15:51
dtroyersecurity group rules _are_ a top-level resource and treated as that everywhere.15:51
dtroyerthey have their own properties/attributes and require the full set of create/delete/list/show commands15:52
dtroyerthe member list isn't the same thing15:52
dtroyerso that's not the best example of a one-to-many relationship after all :(15:52
*** stevebaker has joined #openstack-sdks15:53
dtroyerthe project list attached to an image is just another property that can have multiple values15:54
mnaserdtroyer: well, its an http resource so its not like it comes along a 'image show' http request15:55
dtroyerright, but frankly I don't care what the REST API looks like, it is about the model presented to the user.  which is one reason not automatically pulling the data is a consideration, via adding an option to image show15:56
*** salv-orlando has quit IRC15:56
mnaseri mean if it was a flat list (ex: projects only), it wouldn't be that bad to add it to the show15:57
*** salv-orlando has joined #openstack-sdks15:57
mnaserthe issue is that it presents other things like .. member id and status (ex: accepted, pending, etc)15:57
*** salv-orlando has quit IRC15:57
*** salv-orlando has joined #openstack-sdks15:57
mnaseri dont mind pushing it up to show but the thing that would make me sad is that the user will have a very hard time parsing it using the tools available in osc15:57
mnaserex cant use --columns and so on15:58
dtroyerright, that's a general problem with a number of our data structures, and is one reason we played with adding a jq interface to make dealing with nested data via JSON easier.  turns out to still be rather messy to do in a CLI16:00
openstackgerritJens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails  https://review.openstack.org/55404416:01
*** jamielennox has quit IRC16:01
*** stevebaker has quit IRC16:02
dtroyermnaser: so since image memebr has an ID, that improves the case for it being a top-level resource.  however, I'm not aware of any place to actually use that ID.  It is the status that makes this messy.16:02
*** stevebaker has joined #openstack-sdks16:05
dtroyerI still don't like "image member" but it is better than "image project".  unless we come up with something obviously better, lets add "image member" as a top-level resource, which means adding it to the resource list in doc/source/cli/commands.rst.  It should be in its own module but I don't plan on adding other commands so leaving it in image.py is probably fine.16:06
dtroyerI don't know what the API looks like offhand, but adding a —project option to image member list might be nice at some point to only list images that a particular project has access to.  future.16:07
dtroyerand now lunch.  I'll summarize this in the review after lunch.  thanks for the command and for letting me think through this out loud to refresh my mind.16:08
dtroyerEmilienM: I'll get to your review after lunch too16:09
mordreddtroyer, mnaser: ok - back ...16:10
EmilienMdtroyer: thanks!16:10
*** stevebaker has quit IRC16:12
*** stevebaker has joined #openstack-sdks16:14
openstackgerritMonty Taylor proposed openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat  https://review.openstack.org/55461516:15
mordredmnaser, dtroyer: ^^ that should unstick mnaser's issue ... although now that we can make osc-lib depend on openstacksdk>=0.12 - we could make a pass through and update it to remove the occ paths... I'll do that as a followup16:16
mordredperhaps land that patch, cut an sdk point release, bump the min in global-requirements, then push up osc-lib patches to remove occ fallback paths?16:17
mordreddtroyer: that sound like an ok plan?16:17
*** stevebaker has quit IRC16:22
*** stevebaker has joined #openstack-sdks16:24
*** salv-orlando has quit IRC16:28
*** salv-orlando has joined #openstack-sdks16:28
*** salv-orlando has quit IRC16:33
*** stevebaker has quit IRC16:35
mordredfrickler: left a comment on your ksa patch16:37
*** jamielennox has joined #openstack-sdks16:38
*** stevebaker has joined #openstack-sdks16:39
fricklermordred: I tend to agree with your comment, would you want to reword the original message down on L199 accordingly? would seem sensible to keep those in sync16:40
*** gkadam has quit IRC16:47
mordredfrickler: I'd love to - it's my least favorite error message ... however, ...16:49
mordredkmalloc: ^^ do we consider error message text part of keystoneauth's api?16:49
kmallocmordred: i hope we don't. but honestly, haven't thought about that16:49
kmallocmordred: maybe we should?16:49
mordredkmalloc: me either16:49
kmalloci'm willing to make a call on that right here conferring with you ... and....16:50
kmalloci'm inclined to say no16:50
kmallocbut the exception class would be.16:50
mordredkmalloc: specifically,  "Could not determine a suitable URL or the plugin" - which almost never actually means what it says16:50
mordredkmalloc: yah - exception class == part of aPI for sure16:50
kmallocso, i think the message shouldn't be because it might change to be "better" in the future16:51
kmallocunless it's structured data.16:51
kmallocwhichcase it would be part of the api16:51
kmallocif it's just a "message", it's not part of the api (in my mind, but i could be convinced otherwise)16:51
mordredkmalloc: yah - but in that case I'd expect us to put that data on the execeptoin instance16:51
kmallocso, you're good with saying it's not part of the API?16:52
mordredkmalloc: so maybe let's say "no" - and if people are finding places in which they need to look at exception text, then we nee more specific exception classes16:52
mordredfrickler: ^^16:52
kmallocexception text is useful for humans16:52
kmallocnot for programatic use.16:52
openstackgerritMerged openstack/python-openstacksdk master: Fix 'block_store' aliases define error  https://review.openstack.org/55440316:52
mordredfrickler: also - fwiw, maybe toss in an 'if isinstance(e, exceptions.DiscoveryFailure): raise else: raise exceptions.DiscoveryFailure(...) so that we don't lose the original discovery context just because we made an attempt to guess a versioned endpoint16:53
*** stevebaker has quit IRC17:00
*** stevebaker has joined #openstack-sdks17:09
*** bobh has quit IRC17:13
*** stevebaker has quit IRC17:19
*** stevebaker has joined #openstack-sdks17:28
openstackgerritChris Dent proposed openstack/microversion-parse master: Improve Version.matches() method  https://review.openstack.org/55025117:28
openstackgerritChris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware  https://review.openstack.org/55025217:28
openstackgerritChris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware  https://review.openstack.org/55026317:28
openstackgerritChris Dent proposed openstack/microversion-parse master: Clean up package version and python version support  https://review.openstack.org/55026417:28
openstackgerritChris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers  https://review.openstack.org/55454717:28
*** salv-orlando has joined #openstack-sdks17:29
*** salv-orlando has quit IRC17:34
*** ralonsoh__ has quit IRC17:35
*** e0ne has quit IRC17:35
*** stevebaker has quit IRC17:44
*** jpich has quit IRC17:50
*** stevebaker has joined #openstack-sdks17:54
*** salv-orlando has joined #openstack-sdks18:07
*** stevebaker has quit IRC18:07
*** thrash|bbl is now known as thrash18:12
*** dtantsur is now known as dtantsur|afk18:16
*** stevebaker has joined #openstack-sdks18:16
*** jpena is now known as jpena|away18:18
*** harlowja has joined #openstack-sdks18:23
*** stevebaker has quit IRC18:29
*** dave-mccowan has quit IRC18:32
*** stevebaker has joined #openstack-sdks18:36
*** dave-mccowan has joined #openstack-sdks18:45
*** stevebaker has quit IRC18:46
*** stevebaker has joined #openstack-sdks18:48
*** stevebaker has quit IRC18:57
*** dave-mccowan has quit IRC19:03
*** stevebaker has joined #openstack-sdks19:06
*** bobh has joined #openstack-sdks19:27
*** stevebaker has quit IRC19:30
*** stevebaker has joined #openstack-sdks19:36
*** dave-mccowan has joined #openstack-sdks19:36
*** stevebaker has quit IRC19:45
*** stevebaker has joined #openstack-sdks19:45
*** salv-orlando has quit IRC19:51
*** salv-orlando has joined #openstack-sdks19:52
*** e0ne has joined #openstack-sdks19:53
*** salv-orlando has quit IRC19:56
*** stevebaker has quit IRC19:58
*** stevebaker has joined #openstack-sdks19:59
*** dave-mccowan has quit IRC20:03
*** dave-mccowan has joined #openstack-sdks20:04
openstackgerritMerged openstack/python-openstacksdk master: Use defined version instead of service.version parameter  https://review.openstack.org/55422320:07
*** stevebaker has quit IRC20:08
*** stevebaker has joined #openstack-sdks20:08
*** stevebaker has quit IRC20:13
*** stevebaker has joined #openstack-sdks20:23
*** stevebaker has quit IRC20:30
*** dave-mccowan has quit IRC20:31
*** openstackgerrit has quit IRC20:33
*** stevebaker has joined #openstack-sdks20:36
*** stevebaker has quit IRC20:44
*** edmondsw has quit IRC20:51
*** stevebaker has joined #openstack-sdks20:51
*** salv-orlando has joined #openstack-sdks20:52
*** dmellado has joined #openstack-sdks20:56
*** salv-orlando has quit IRC20:57
*** dmellado has quit IRC20:58
*** dave-mccowan has joined #openstack-sdks21:00
*** dmellado has joined #openstack-sdks21:02
*** openstackgerrit has joined #openstack-sdks21:06
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix additional output encoding issues  https://review.openstack.org/55469821:06
*** dmellado has quit IRC21:08
*** stevebaker has quit IRC21:09
*** stevebaker has joined #openstack-sdks21:10
*** dmellado has joined #openstack-sdks21:12
*** dmellado has quit IRC21:13
*** bobh has quit IRC21:13
*** dmellado has joined #openstack-sdks21:15
*** stevebaker has quit IRC21:20
*** dmellado has quit IRC21:32
*** e0ne has quit IRC21:33
*** salv-orlando has joined #openstack-sdks21:53
dhellmanndtroyer : regarding https://review.openstack.org/#/c/554698/1 I wonder if cliff should grow support for progress bars?21:55
dhellmannhttps://pypi.python.org/pypi/progressbar was pretty easy to use in downpour21:56
dhellmannoh, although I wonder if that's actively supported any more if it's on code.google.com21:57
dhellmannah, redirects to https://github.com/niltonvolpato/python-progressbar21:57
dhellmannaha, I actually used https://pypi.python.org/pypi/progressbar221:59
dhellmannanyway, let me know if you think that would be a useful thing to be able to do via cliff21:59
dtroyerdhellmann: maybe?  I really didn't know what to do with that _show_progress() function.  Putting it where I did made calling easy to get cliff's stdout but made testing harder than I wanted to finesse to get a ppinter to the nested function.22:00
dhellmannoh, you could have made it a method instead of a closure22:01
dhellmannthat would make it easier to mock it out or whatever22:01
dtroyerbut then it would require passing self around and changing the signature of the callback22:01
dhellmannself is passed automatically to a bound method22:01
dhellmannif the signature is "def _show_progress(self, progress)" and you pass self._show_progress the callback will expect 1 arg22:02
dtroyerok, so I didn't even try that because I assumed it needed a second argument.22:02
dhellmannnah, it does the easy thing22:02
dtroyerthat is certainly a better solution22:02
dhellmannwhat sorts of values are passed to that method?22:02
dhellmannare they text like "working" or are they percentages?22:02
*** dmellado has joined #openstack-sdks22:04
dtroyerit is anything… if the resource being waited on has a progrss attribute, that is passed back22:05
dtroyer*progress attribute22:05
dhellmannso a progress bar might not really work22:05
dhellmannoh, there's an "animated marker"22:06
dhellmanneh, it's something to think about22:07
dtroyerit isn't something I really thing we should be doing, as that kind of stuff often just pollutes logs, but some like it as a touchy-feedbacky thing, even if it is usually not very accurate22:08
dhellmannthat's true, i guess22:09
dtroyerit could be tied to logging levels to address that, but I've never really cared enough to follow up22:09
dhellmannI guess it's hard to tell if self.stdout is sys.stdout after we wrap it up22:10
dhellmannit could be its own flag --progress or something22:10
dhellmannI don't feel strongly enough about it to push and implement it; it just seemed like a thing to talk about in light of that patch22:10
dhellmannI'll leave a wishlist ticket in lp in case someone else wants to do it22:11
dtroyersure, and I appreciate the reviews, this (encoding I/O) is an area I don't seem to be able to keep in my head and have to periodically e-learn it22:11
dhellmannit's like a sandwich. the encoding/decoding steps are the bread and the application is the peanut butter22:12
dtroyer:)   it much be dinnertime in GA?22:13
openstackLaunchpad bug 1757278 in cliff "add support for progress bar/widgets" [Wishlist,New]22:13
dhellmannhaha, yeah, I think I'm hungry :-)22:14
dhellmannspeaking of eating, it' time to go exercise some22:14
*** dave-mccowan has quit IRC22:17
*** gildub has joined #openstack-sdks22:25
*** stevebaker has joined #openstack-sdks22:27
*** dave-mccowan has joined #openstack-sdks22:28
*** harlowja has quit IRC22:57
*** jpena|away is now known as jpena|off23:21
*** Anticime1 is now known as Anticimex23:29
mordreddtroyer, dhellmann: fwiw, ianw has poked a little bit at the idea of having some of the calls in shade (so now obviously for sdk) to be able to have progress callbacks...23:44
mordredit's a little different than what you're discussing - this is more of a "do something in the requests/adapter layer so that as we upload 12G images we can tell that it's not just stuck"23:44
mordredbut - I could see the existence of a progress bar facility and the existence of an image upload/download progress callback being complimentary23:45
*** harlowja has joined #openstack-sdks23:49
*** cdent has quit IRC23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!